[GitHub] cordova-mobile-spec pull request: CB-6369:Update the descriptions ...
Github user lmnbeyond commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/53#issuecomment-39048158 @cmarcelk Thanks for your tips, I have updated my github profile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: CB-6369:Update the descriptions ...
GitHub user lmnbeyond opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/53 CB-6369:Update the descriptions of expected results for InAppBrowser ope... ...nWithScript tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lmnbeyond/cordova-mobile-spec CB-6369 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit aebd633d5c8f68ce5f648734778df5a4dd11ba9b Author: liumn Date: 2014-03-28T03:34:51Z CB-6369:Update the descriptions of expected results for InAppBrowser openWithScript tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS：Fix the probl...
Github user lmnbeyond commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/3#issuecomment-38384935 If I set web view frame as main screen bounds in pluginInitialize: , then the web view frame will be set again later to another value. However I can't figure it out why. I guess I'm not ready for this contribution, so I'm going to close this PR. So sorry and thanks for you time! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS：Fix the probl...
Github user lmnbeyond closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS：Fix the probl...
Github user lmnbeyond commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/3#issuecomment-38247400 @shazron Thanks for your kindly review, I really don't want to break any functionalities, I'm so sorry :( I have tired my best to fix the problem and already updated my PR, please review it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS：Fix the probl...
GitHub user lmnbeyond opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/3 CB-6318 iOSï¼Fix the problem that Statusbar can't blend into the backgrou... ...nd when embedding CDVViewController in a NavigationController You can merge this pull request into a Git repository by running: $ git pull https://github.com/lmnbeyond/cordova-plugin-statusbar CB-6318 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/3.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3 commit cf0dbe29a6bf7c436c8f7d29eb95ca0e9b9478dc Author: liumn Date: 2014-03-20T11:05:16Z CB-6318 iOSï¼Fix the problem that Statusbar can't blend into the background when embedding CDVViewController in a NavigationController --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Vote] Cordova 3.4.0 release
+1 Best Regards! > +1 > > On 2/18/14 3:26 PM, "Steven Gill" wrote: > >> Please review and vote on the Cordova 3.4.0 release. >> >> You can find the sample release at http://people.apache.org/~steven/ >> >> Voting will go on for 24 hours. >> >> Cheers, >> >> -Steve >
About PR and stale branches
Hi, 1. I’m wondering would it be better if we can clean up and merge the “open” pull requests before we do a release. As for me, if my pull requests can’t be merged into the coming release, it would make me a little frustrated. In fact, as a contributor, I’d like my PR to get accepted as soon as possible, this will encourage me to do more contributions. 2. I also noticed that there are some stale branches, e.g. cordova-ios/CB-. Do we have any special reasons for keeping these stale branches staying on repositories? Please don’t treat me as a critic, I’m very grateful to you guys, and just want to do my bit to make Cordova more better :) Best Regards!
Should we add platform info in commit message?
Hi guys, Since plugin-related code are all grouped into its own repo, should we add platform info in commit messages? I think it would be more clear when we view the commit history. e.g., [CB-1234][iOS] Fix… [CB-5678][all] Fix… [Android]… [js]… What do you think, guys? Best Regards!
Re: What's your daily workflow for cordova development?
> I also think it should sub-shell to a platform script. We already have > a `project template` folder in each platform. We can easily add a > `plugin template` as well and write a quick create_plugin script. > > What do you guys think of the workflow I described above ? Any > comments ? I can create jira issues for it and tackle it. > > -a > Hi Anis, I just want to confirm whether or not this is the workflow we are talking about : For a brand new plugin: $ cordova plugin create /path/to/myPlugin $ cordova plugin add /path/to/myPlugin --watch For an existing plugin: $ cordova plugin add /path/to/corePlugin --watch Although, I'm not quite clear about the complexity behind this, I think the above workflow is great for me!
Re: What's your daily workflow for cordova development?
+ 1 love "watch command" idea :) Best Regards! On 2013-9-3, at 上午7:34, Brian LeRoux wrote: > automate > add/remove with some sort of watch command. That way ppl are writing to the > plugin spec from the beginning instead of refactoring a plugin out of a > native project.
Re: cli plugins 'alias'?
+ 1 It's great Best Regards! On 2013-9-3, at 上午8:37, Brian LeRoux wrote: > love this idea > > > On Sat, Aug 31, 2013 at 2:36 PM, Jonathan Bond-Caron < > jbo...@gdesolutions.com> wrote: > >> Setting up the mobile spec app was tedious since I didn't know the >> dependencies. >> >> I wrote a small patch that allows to pull a plugin from a git subdirectory >> e.g. cordova plugin add >> https://github.com/jbondc/cordova-labs?subdir=cordova-deps-mobile-spec >> https://issues.apache.org/jira/browse/CB-4715 >> >> It got me thinking there might an opportunity to make this less tedious >> with an 'alias' >> >> e.g. cordova plugin add @cordova-test >> >> The @ symbol signals an 'alias' (cordova-test) that cli would expand to >> "https://.../cordova-plugin-battery-status https://.../cordova-plugin-device >> etc..." >> The list of plugins simply gets passed to plugman. >> >> A couple of 'core' aliases could make it easier to get started with >> cordova, e.g. >> cordova plugin add @cordova-common >> cordova plugin add @cordova-test >> cordova plugin rm @cordova-test >> >> Could also be called packaged / collection / grouped plugins. >> >> Thoughts? >> >>
Re: What's your daily workflow for cordova development?
e downstream >>>> changes inside feature branches etc. >>>> >>>> If you do not actually need to make changes to platforms/plugins, it is >>>> easier to let CLI automatically fetch the latest stable versions for you, >>>> or fetch specific version you request for you, and trust that we will >>> serve >>>> good working versions. You can always revert to older versions if issues >>>> come up. >>>> >>>> Again, you can of course add the whole workspace into a repo and share >>> that >>>> across a team, but much of those files are created as a result of file >>>> munging and will change in odd ways over time. >>>> >>>> -- >>>> >>>> >>>> [1]: >>>> >>> http://cordova.apache.org/docs/en/3.0.0/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide >>>> [2]: >>>> >>> http://cordova.apache.org/docs/en/3.0.0/plugin_ref_spec.md.html#Plugin%20Specification >>>> [3]: https://github.com/apache/cordova-plugin-device >>>> >>>> -Michal >>>> >>>> >>>> >>>> On Fri, Aug 30, 2013 at 5:51 AM, lmnbeyond wrote: >>>> >>>>> Hi all, >>>>> >>>>>Cordova was separated into tens of individual repos ever since >>> 3.0 >>>>> and we're benefit from this change and can quickly build/test apps. >>>>> >>>>>For now, if I want to develop some feature or plugin, I can >>> first >>>>> create a project by cli, then did some changes, but meanwhile it's >>>>> difficult to track which files got changed/added/removed, since all >>> source >>>>> was not under source control. And it's also error prone to manually do >>> the >>>>> tracking. The structure of cordova-x repos is different from the >>> structure >>>>> in a development project. >>>>> >>>>> It was easier if there was an all-in-one project, I mean all >>>>> native sources in a single project, before 3.0. >>>>> >>>>> >>>>> Best Regards! >>>>> >>>>> >>>>> >>>>> >>>
What's your daily workflow for cordova development?
Hi all, Cordova was separated into tens of individual repos ever since 3.0 and we're benefit from this change and can quickly build/test apps. For now, if I want to develop some feature or plugin, I can first create a project by cli, then did some changes, but meanwhile it's difficult to track which files got changed/added/removed, since all source was not under source control. And it's also error prone to manually do the tracking. The structure of cordova-x repos is different from the structure in a development project. It was easier if there was an all-in-one project, I mean all native sources in a single project, before 3.0. Best Regards!
Re: Pull requests
Hi all, That's right, my name is Meina Liu :) Best Regards! On 2013-8-20, at 上午4:10, Max Woghiren wrote: > I believe it's Meina Liu—the confirmation was sent on June 3rd. > > I'll pull these changes in. > > On Mon, Aug 19, 2013 at 4:07 PM, Andrew Grieve wrote:
Pull requests
Hi all, I want to do some contribution to Cordova, and I have tried to fix some minor issues: repo: cordova-plugin-contacts https://issues.apache.org/jira/browse/CB-4580 pull request: https://github.com/apache/cordova-plugin-contacts/pull/5/commits repo: cordova-ios https://issues.apache.org/jira/browse/CB-4567 pull request: https://github.com/apache/cordova-ios/pull/73/commits repo: cordova-mobile-spec https://issues.apache.org/jira/browse/CB-4568 pull request: https://github.com/apache/cordova-mobile-spec/pull/37/commits repo:cordova-plugin-file pull request: https://github.com/apache/cordova-plugin-file/pull/3/commits I would really appreciate your time in reviewing my pull requests. FYI: I have signed ICLA earlier. Best Regards!
