[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user mccob commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-216922029 how to invoke permission since Android M permissions system for WebRTC getUserMedia ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user SergiiS commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-193183285 Hello guys, was it merged? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-191358763 Hey @okonon, that has been done in #179, which will hopefully be merged in soon. Just waiting on an ICLA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user okonon commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-191237075 Hello all! @ochakov could you please resolve the conflicts so this can be merged? Or anyone else? @riknoll @infil00p @MatthewBooth As more people are upgrading to Android M this becomes more common issue out in the while. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user dieppe commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-188872652 You can also check this fork https://github.com/jnuine/cordova-plugin-camera It includes a major refactor of the iOS plugin which fixes some bugs, checks for option consistency and allows access to the picture metadata in all cases that make sense (available as a [PR](https://github.com/apache/cordova-plugin-camera/pull/101) since June last year, but I guess merging PR is not cordova's team strong suit). On Android, it includes these commits and also handles better the kitkat+ gallery (sadly not the images from Google Drive). We use it in an app used daily both on Android and iOS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186312333 @infil00p I've rebased here: https://github.com/apache/cordova-plugin-camera/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094 WTF? I thought this was merged weeks ago, or we decided not to merge it or something. We need to get the conflicts resolved and this thing pulled in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186290675 This should be merged ASAP. It fixes this very issue for a project I'm working on. You absolutely should be declaring the permissions in the manifest so that the user can see them on the Google Play Store, or while installing manually. It's poor practice to deny the user the chance to remove, revoke or review permissions. I'm using @ochakov's fork currently, but it would obviously be better if this was in the official channels. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ianisted commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181852903 @ochakov thanks, but I'm needing to perform QR code scanning. Seems you have a similar issue, though the phonegap-plugin-barcodescanner plugin uses Intent and not Permissions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181845807 @ianisted Use my version of the plugin https://github.com/ochakov/cordova-plugin-camera --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ianisted commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181845462 Any luck with a resolution to this issue? I'm using that Barcode plugin and I'm getting the following error "Sorry, the Android camera encountered a problem...". After much head scratching I discovered it didn't have permissions to access the Camera, and wasn't asking for them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-172336151 @riknoll, I can't really invest more time in this bug. I am doing completely different things now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-171800967 Awesome, thanks for doing that! Would you mind also incorporating the fix I commented on in the diff? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-168818980 @riknoll done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-168751426 @ochakov any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-162598821 @ochakov thanks for doing that! Can you add your name to your GitHub profile so that we can verify? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-162259724 ICLA has been filed and approved by Craig L Russell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#discussion_r46596545
--- Diff: src/android/CameraLauncher.java ---
@@ -178,7 +181,7 @@ else if ((this.srcType == PHOTOLIBRARY) ||
(this.srcType == SAVEDPHOTOALBUM)) {
// preserve the original exif data and filename in the
modified file that is
// created
if(this.mediaType == PICTURE && (this.destType ==
FILE_URI || this.destType == NATIVE_URI)
-&& fileWillBeModified() &&
!cordova.hasPermission(permissions[0])) {
+&& fileWillBeModified() &&
!cordova.hasPermission(permissions[SAVE_TO_ALBUM_SEC])) {
--- End diff --
I don't think we should be using SAVE_TO_ALBUM_SEC and TAKE_PICTURE_SEC for
the indices in the permissions array since those values mean something
different. The action after the permissions is not determined by the
permissions requested (both the camera and the photolibrary sources require
READ permission, for example). Could you define some different constants at the
top of the file; maybe CAMERA_PERMISSION_INDEX and READ_PERMISSION_INDEX?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161748614 @ochakov I'll do some testing, but this looks pretty good! In the meantime, can you fill out an Apache ICLA? There are instructions for doing so [here](http://cordova.apache.org/contribute/contribute_guidelines.html). That needs to be submitted/filed before I can merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161470590 Added both fixes to this PR Camera permission will not be required unless android.permission.CAMERA is set in the package. BTW, barcode scanner and flashlight plugins both set that permission in the manifest. I tested with and without android.permission.CAMERA and it works well in both cases, not asking for camera permission in case when both plugins are uninstalled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423854 riknoll, Sounds alright. I would also check camera and storage permissions separately in case someone will approve one of them, but deny the other. Next time, only the missing one should be asked. I will commit another update for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423220 Agreed. But this PR should be updated to check the PackageInfo first. @ochakov does that sound alright to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417898 Right, Barcode Scanner! That thing! So, if there's an app that uses the Barcode Scanner and takes a picture, then it can cause a problem. I'm still not stoked about this, but this code should probably be added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417577 Here's one that declares it: https://github.com/phonegap/phonegap-plugin-barcodescanner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416757 I feel like we can easily handle it, though, by programmatically checking if the permission was declared before we take a picture and only requesting it if it is (looks like it's in the [PackageInfo](http://developer.android.com/reference/android/content/pm/PackageInfo.html#requestedPermissions)). Plus, we avoid another quirk for the Android platform. Is there any danger in requesting that permission if some other plugin is already using it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416812 BTW: Do we have a third-party plugin that asks for Camera? And if a Third-Party plugin is asking for the CAMERA permission, shouldn't they have their own activity that actually uses the camera? This seems like a weird hypothetical situation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161415816 @ochakov 1. Yes, it still works, because this relies on the permission of the Camera, not the permission of the application firing the event. 2. If you don't declare camera permission, the result of cordova.hasPermission(CAMERA), assuming CAMERA is the string containing the Camera permission, would be false. We shouldn't request permissions for things that we're not actually doing, such as taking a photo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414891 @riknoll Yeah, but that's a problem that should be in the docs, and not in this code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414408 In the developer reference: http://developer.android.com/reference/android/content/pm/PackageInfo.html#requestedPermissions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414060 @infil00p if a third party plugin declares the permission in their plugin.xml so that is inserted into the manifest, then you get a SecurityException and a crash. I have reproduced that behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161413648 You do not need the Camera permission for the Camera plugin because we use intents. Why are we trying to request this permission? That's the recommended way of using the Camera as per the Android Guidelines, and it's so you don't have to have the permission in the manifest. I'm going to close this issue and I don't think we should accept this request, since we're requesting a permission that we don't actually need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161412438 I have two questions then: 1. When you do not declare camera permission in the manifest, does it work on older Android versions? 2. When you do not declare camera permission, what is the result of cordova.hasPermission(CAMERA)? We can tweak the function to request only those permissions for which cordova.hasPermission returns false. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410634 BTW, I created a JIRA for this ([CB-10120](https://issues.apache.org/jira/browse/CB-10120)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410396 Thanks for submitting a PR! I actually just ran into this issue while working on [another issue in JIRA](https://issues.apache.org/jira/browse/CB-10064). After doing some research into this problem, I found that it actually only comes up if you have the CAMERA permission declared in your manifest (I have no idea what the reasoning behind this behavior is). We don't declare that permission, but third party plugins can insert entries into the manifest and so we still need to handle the case. Anyway, the question is, should we always request the camera permission or should we check the manifest for the permission declaration first? I'm leaning towards checking the manifest (we shouldn't get extra permissions for no reason). @infil00p thoughts on that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...
GitHub user ochakov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/142 Fix missing CAMERA permission for Android M Fixing a bug where for Android M new permissions model, only external storage permission was asked, while camera permission was not, causing camera to fail on Android 6.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ochakov/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit 31dcf0f423b85023a183dc45efc2e93d648ef469 Author: ochakov Date: 2015-12-01T21:10:43Z Fix missing CAMERA permission for Android M Fixing a bug where for Android M new permissions model, only external storage permission was asked, while camera permission was not, causing camera to fail on Android 6.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
