[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user f3rno commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-138998550 @cjpearson, you are a gentleman and a scholar. After nearly a day of on-off debugging due to keyboard related issues, your fork works perfectly (so far) :dancer: Danke! Maybe it would be best to provide a clear warning to potential users in the "official" apache readme that the version here is broken. All sorts of strange issues on iOS 8.4.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-107082152 @Fmstrat itâs just basic js/css ⦠assuming your app is wrapped in a you can use css like this: $(div).css(âbottomâ, keyboardHeight) the wrapper div should be absolutely positioned of course. alternatively you can set a margin-bottom, but then you canât use css transitions to animate the shrinking ... > On 30 May 2015, at 05:28, Fmstrat wrote: > > Ahh, I gave that a shot, thanks. I've got a console.log running with the keyboard height, but any idea where I can find an example of using JS to shrink the window height down? (Using jQuery Mobile in my app if that matters) > > â > Reply to this email directly or view it on GitHub. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-107043443 @Fmstrat these changes should be in the latest version. Cordova no longer supports this as a core plugin though. I have a fork [here](https://github.com/cjpearson/cordova-plugin-keyboard) with some other fixes if you still want to use the shrinkview behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user Fmstrat commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106986865 Ahh, I gave that a shot, thanks. I've got a console.log running with the keyboard height, but any idea where I can find an example of using JS to shrink the window height down? (Using jQuery Mobile in my app if that matters) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106972661 I believe the general consensus is that itâs too hard to get resizing to behave reliably across many OS versions, and that the best solution is to use detect when the keyboard is shown/hidden and updated the UI of your app accordingly. ionic keyboard plugin is fairly good at detecting when the keyboard is going to pop up and gives you the height of the keyboard too, so you can adjust the app itself in javascript instead of resizing the whole web view. > On 30 May 2015, at 02:18, Fmstrat wrote: > > So, is this not ever being merged? There are a buttload of posts on Google of people trying to figure out how to get the WebView to resize on 7.1+, it took me all day to find this particular pull request. > > â > Reply to this email directly or view it on GitHub. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user Fmstrat commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106969886 So, is this not ever being merged? There are a buttload of posts on Google of people trying to figure out how to get the WebView to resize on 7.1+, it took me all day to find this particular pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87709992 Thanks for the merge @agrieve. Unfortunately, I've just found another issue. If I recall correctly, one of the major factors was because iOS 7 shrank webviews automatically, but they reversed this in 7.1. I'll definitely bring it up again, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87696102 Merged this in, but last I recall discussing the plugin on the dev mailinglist, I don't think anyone was interested in pursuing it. Might try raising the subject again to see, but otherwise I think it'd be awesome if you wanted to fork it and maintain a defacto version of it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugins/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87343580 @davidtlee If you're using the cordova command line, `cordova plugin add "https://github.com/cjpearson/cordova-plugins#master:keyboard"` should work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user davidtlee commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87331872 Would be great to have this merged in! :) @cjpearson, while I'm waiting for it to get merged in, is there a way for me to use your branch? (do I just clone and then copy that folder into my plugins directory? I'm still quite new to cordova... hehe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73932253 @akrymski I removed the animation block because it wasn't actually working. Even though the webview's frame was changing size inside the block, the content would immediately change size. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73753163 Just tried this together with wk-webview and getting compilation errors. Works fine with the old UIWebView though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73752088 Thanks for this, I've been cracking my head open trying to get the web view to shrink! This fork is the only one that does it on the latest iOS 8.1 but you MUST REMOVE height=device-height in your META tag for it to work. Please merge this in! Question: @cjpearson is there a way to bring back the animation? That would be really great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user sandstrom commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-71673165 @shazron friendly ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugins/pull/18 CB-8337: Fix keyboardShrinksView for external keyboards, CB-8339 enable keyboardShrinksView on iOS 7.1+ Instead of listening for keyboard show and hide events, the plugin now listens for keyboard frame change events and responds accordingly. This should also fix CB-5711 or any other case where the keyboard frame changes without firing a show or hide event. This also changes keyboardShrinksView from being a no-op on iOS >= 7.0 to being a no-op on iOS = 7.0 and fixes the screen being pushed up before being resized (CB-5642.) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugins master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugins/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit d1e9b85ad06af10759e68dcbc2b6af8cb1229e67 Author: Connor Pearson Date: 2015-01-09T17:24:53Z Change KeyboardShrinkView to use KeyboardFrameWillChange notification instead. Have animation match the keyboard animation. Support external keyboards. commit 398cca80652f6a6d0bd00440708db66b52380b81 Author: Connor Pearson Date: 2015-01-12T16:25:28Z Instead of adding and removing observer when _shrinkView changes, check for _shrinkView in the method that is called. Always resize the webview if the keyboard is moving off screen. This covers the case when shrinkView is disabled while the keyboard is visible. Only disable the webview push up if shrinkView is enabled. Fix regression which broke disableScrollingInShrinkView. commit 9414dbc01d109a54855f94a8d8223209ce82324f Author: Connor Pearson Date: 2015-01-12T17:15:58Z Take into account whether or not the accessory bar is showing when shrinking the webview. commit 2b83934c38f233253064a5c598b34dfdea7fc352 Author: Connor Pearson Date: 2015-01-12T18:27:58Z Handle split and undocked keyboards. They should hover over the app and not resize the webview. commit 5fb233b19ae8638c933506447bf54ffb89659c80 Author: Connor Pearson Date: 2015-01-12T18:38:01Z Remove empty getter/setter. Use autogenerated instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
