[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809198#comment-17809198 ] ASF subversion and git services commented on RAT-325: - Commit a0010fde6ce700bdd4019ae471aefabd1643e7f4 in creadur-rat's branch refs/heads/fix/RAT-353 from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=a0010fde ] Merge pull request #204 from Claudenw/RAT-325_Logging_Issue Changed default logging level to WARN > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809200#comment-17809200 ] ASF subversion and git services commented on RAT-325: - Commit 1036fcbcae3c070bd186653707c3cb6de05f1c62 in creadur-rat's branch refs/heads/fix/RAT-353 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=1036fcbc ] RAT-325: Add changelog entry about new default logging level WARN for CLI/test runs > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809194#comment-17809194 ] ASF subversion and git services commented on RAT-325: - Commit 1036fcbcae3c070bd186653707c3cb6de05f1c62 in creadur-rat's branch refs/heads/feature/RAT-293_sonarCloud from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=1036fcbc ] RAT-325: Add changelog entry about new default logging level WARN for CLI/test runs > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809191#comment-17809191 ] ASF subversion and git services commented on RAT-325: - Commit b157bce9e4408483b7233eaa356f6f1d1840c09d in creadur-rat's branch refs/heads/feature/RAT-293_sonarCloud from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=b157bce9 ] RAT-325: Add missing changelog about SPDX optimization > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809192#comment-17809192 ] ASF subversion and git services commented on RAT-325: - Commit b93793f28893c8ef7540884416e148b0ab59ed0c in creadur-rat's branch refs/heads/feature/RAT-293_sonarCloud from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=b93793f2 ] RAT-325: Reduce log level to not pollute build logs with each filename that is being processed > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809189#comment-17809189 ] ASF subversion and git services commented on RAT-325: - Commit 78e58eca8cd2a0295e9e80666f23bca83338740d in creadur-rat's branch refs/heads/feature/RAT-293_sonarCloud from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=78e58eca ] Fixed RAT-325 and added some logging > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809190#comment-17809190 ] ASF subversion and git services commented on RAT-325: - Commit af0452a5114917ed5f5ea804f506baf476898a7a in creadur-rat's branch refs/heads/feature/RAT-293_sonarCloud from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=af0452a5 ] Merge pull request #192 from Claudenw/RAT-325_fix_performance_degradation RAT-325 : Added check to skip expensive processing in SPDX > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809193#comment-17809193 ] ASF subversion and git services commented on RAT-325: - Commit a0010fde6ce700bdd4019ae471aefabd1643e7f4 in creadur-rat's branch refs/heads/feature/RAT-293_sonarCloud from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=a0010fde ] Merge pull request #204 from Claudenw/RAT-325_Logging_Issue Changed default logging level to WARN > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809181#comment-17809181 ] ASF subversion and git services commented on RAT-325: - Commit 1036fcbcae3c070bd186653707c3cb6de05f1c62 in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=1036fcbc ] RAT-325: Add changelog entry about new default logging level WARN for CLI/test runs > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809180#comment-17809180 ] ASF subversion and git services commented on RAT-325: - Commit a0010fde6ce700bdd4019ae471aefabd1643e7f4 in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=a0010fde ] Merge pull request #204 from Claudenw/RAT-325_Logging_Issue Changed default logging level to WARN > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809098#comment-17809098 ] Christofer Dutz commented on RAT-325: - Yeah ... confirmed: With version 0.16.1-SNAPSHOT the long wait and the error logs are no longer an issue ... thanks for the quick fix :) > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808961#comment-17808961 ] Claude Warren commented on RAT-325: --- [~cdutz] I ran a test. If you add 0.16.1-SNAPSHOT to your apache-rat entry in your pom file it will work correctly. This demonstrates that the proposed patches work as expected. Thank you for your report. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808950#comment-17808950 ] Philipp Ottlinger commented on RAT-325: --- [~cdutz] did you play around with a current 0.16.1-SNAPSHOT or with 0.16? We are working on a 0.16.1 release to fix the maven problems that were introduced in 0.16. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808899#comment-17808899 ] Christofer Dutz commented on RAT-325: - In the build of PLC4X rat (Maven plugin) seems to list a number of parser errors and then pauses for almost a minute till it continues ... is this related to the issue reported here? > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808481#comment-17808481 ] Maxim Solodovnik commented on RAT-325: -- [~pottlinger] Just have re-tested! 5 seconds for the build with unapproved licenses 3 seconds for the green build! Thanks for the fix! :) > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808372#comment-17808372 ] Philipp Ottlinger commented on RAT-325: --- [~solomax] pls retry - all changes were merged but I assume in your timezone the ASF Jenkins has not yet published a new SNAPSHOT-version of RAT. Should be available for you by now. Thanks. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807540#comment-17807540
]
Maxim Solodovnik commented on RAT-325:
--
Hello [~pottlinger],
I've just re-run {{mvn clean apache-rat:0.16.1-SNAPSHOT:check -U}}
got {{apache-rat-*-0.16.1-20240116.065051-10.jar}}
and the check tooks too long
Can you double check the SNAPSHOT contains the fix? :)
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Claude Warren
>Priority: Major
> Fix For: 0.16.1
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807456#comment-17807456 ] Philipp Ottlinger commented on RAT-325: --- fyi: [~joc...@apache.org] thanks for your analysis - when I create a new 0.16.1 release I will clone this ticket for 0.17 so further analysis may happen to further optimize and streamline the regexp-based license checks. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807444#comment-17807444 ] ASF subversion and git services commented on RAT-325: - Commit b93793f28893c8ef7540884416e148b0ab59ed0c in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=b93793f2 ] RAT-325: Reduce log level to not pollute build logs with each filename that is being processed > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807443#comment-17807443 ] Philipp Ottlinger commented on RAT-325: --- [~solomax] would you mind doing a retest with the current SNAPSHOT from branch master? I already realized that the latest PR pulled in a change that logs all of the processed files to level INFO, this will be changed to level INFO ([~claude]), but apart from that you should be able to get RAT up and running within your project with the new configuration options. Thanks for any feedback as we would create a new release 0.16.1 during the weekend if most of the performance/configuration regressions are fixed. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807440#comment-17807440 ] ASF subversion and git services commented on RAT-325: - Commit b157bce9e4408483b7233eaa356f6f1d1840c09d in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=b157bce9 ] RAT-325: Add missing changelog about SPDX optimization > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807326#comment-17807326 ] ASF subversion and git services commented on RAT-325: - Commit af0452a5114917ed5f5ea804f506baf476898a7a in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=af0452a5 ] Merge pull request #192 from Claudenw/RAT-325_fix_performance_degradation RAT-325 : Added check to skip expensive processing in SPDX > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807325#comment-17807325 ] ASF subversion and git services commented on RAT-325: - Commit 78e58eca8cd2a0295e9e80666f23bca83338740d in creadur-rat's branch refs/heads/master from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=78e58eca ] Fixed RAT-325 and added some logging > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806386#comment-17806386 ] Jochen Wiedmann commented on RAT-325: - See [https://lists.apache.org/thread/4qyjkh5fv464n1f60p1o44rb6yhdg5gj] for a preliminary analysis. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806270#comment-17806270 ] Jochen Wiedmann commented on RAT-325: - Perfect, [~solomax] , thank you! > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806251#comment-17806251 ] Maxim Solodovnik commented on RAT-325: -- looks promising! :) looking forward to get fresh SNAPSHOT to test locally :) I would also check the case when some unapproved licences are found > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806229#comment-17806229 ] Philipp Ottlinger commented on RAT-325: --- [~solomax] I've applied the changes proposed by [~claude] locally and applied above changes to this branch: ✔ ~/openmeetings/openmeetings-web [master|✚ 1] 23:45 $ mvn clean apache-rat:0.16.1-SNAPSHOT:check [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.openmeetings:openmeetings-web >-- [INFO] Building Openmeetings Web 8.0.0-SNAPSHOT [INFO] from pom.xml [INFO] [ war ]- [INFO] [INFO] --- clean:3.3.2:clean (default-clean) @ openmeetings-web --- [INFO] Deleting /home/hirsch/workspace2016//openmeetings/openmeetings-web/target [INFO] [INFO] --- apache-rat:0.16.1-SNAPSHOT:check (default-cli) @ openmeetings-web --- [WARNING] Parameter 'licenses' is deprecated: No reason given [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 63, approved: 601 licenses. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 2.524 s [INFO] Finished at: 2024-01-12T23:45:09+01:00 [INFO] We just need GithubActions to build the PR ;) after a good night's sleep. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806099#comment-17806099
]
Maxim Solodovnik commented on RAT-325:
--
Hello [~joc...@apache.org],
here are my steps:
Preparation:
{code}
git clone https://github.com/apache/openmeetings.git
cd openmeetings/openmeetings-web
{code}
h3. 1. to get 0.15 result (fastest)
run: {{mvn clean apache-rat:0.15:check}}
The results at my laptop:
{code}
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1.005 s
[INFO] Finished at: 2024-01-12T22:33:06+07:00
[INFO]
{code}
--
h3. 2. to get worst results: edit {{../pom}} (i.e. {{pom.xml}} at project root)
comment out {{}} at line 1420
run: {{mvn clean apache-rat:0.16:check}}
The results at my laptop:
{code}
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 38:15 min
[INFO] Finished at: 2024-01-12T21:46:04+07:00
[INFO]
{code}
Seems the job done twice:
- to print summary i.e. {{Rat check: Summary over all files. Unapproved: 6,
unknown: 6, generated: 63, approved: 595 licenses.}}
- to print list of files
--
h3. 3. to get better results: edit {{../pom}} (i.e. {{pom.xml}} at project root)
un-comment {{}} at line 1394
run: {{mvn clean apache-rat:0.16:check}}
The results at my laptop:
{code}
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 18:19 min
[INFO] Finished at: 2024-01-12T22:05:08+07:00
[INFO]
{code}
My configuration:
{code}
Ubuntu 22.04.3 LTS
Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Maven home: /opt/maven
Java version: 17.0.9, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-91-generic", arch: "amd64", family: "unix"
16 core AMD Ryzen 7 6800H
64GB RAM
{code}
BTW according to CPU load the process is single threaded
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806002#comment-17806002 ] Jochen Wiedmann commented on RAT-325: - [~solomax] Can you give a procedure for reproducing this, please? (Git Commit, Maven command line) > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805528#comment-17805528
]
Maxim Solodovnik commented on RAT-325:
--
Here are the results for our project: Apache OpenMeetings:
Rat 0.15
{code}
[INFO] Reactor Summary for Openmeetings 8.0.0-SNAPSHOT:
[INFO]
[INFO] Openmeetings ... SUCCESS [ 7.493 s]
[INFO] Openmeetings Tests . SUCCESS [ 5.237 s]
[INFO] Openmeetings Util .. SUCCESS [ 12.594 s]
[INFO] Openmeetings DB SUCCESS [ 16.765 s]
[INFO] Openmeetings Core .. SUCCESS [ 13.567 s]
[INFO] Openmeetings MediaServer ... SUCCESS [ 13.218 s]
[INFO] Openmeetings Install ... SUCCESS [ 12.963 s]
[INFO] Openmeetings Service ... SUCCESS [ 14.817 s]
[INFO] Openmeetings Webservices ... SUCCESS [ 13.905 s]
[INFO] Openmeetings Web ... SUCCESS [ 43.994 s]
[INFO] Openmeetings Screen Sharing applet . SUCCESS [ 7.467 s]
[INFO] Openmeetings Server SUCCESS [ 22.649 s]
[INFO]
[INFO] BUILD SUCCESS
{code}
Rat 0.16
{code}
[INFO] Reactor Summary for Openmeetings 8.0.0-SNAPSHOT:
[INFO]
[INFO] Openmeetings ... SUCCESS [ 10.183 s]
[INFO] Openmeetings Tests . SUCCESS [ 4.597 s]
[INFO] Openmeetings Util .. SUCCESS [ 13.439 s]
[INFO] Openmeetings DB SUCCESS [ 18.848 s]
[INFO] Openmeetings Core .. SUCCESS [ 14.530 s]
[INFO] Openmeetings MediaServer ... SUCCESS [ 13.718 s]
[INFO] Openmeetings Install ... SUCCESS [ 14.093 s]
[INFO] Openmeetings Service ... SUCCESS [ 18.380 s]
[INFO] Openmeetings Webservices ... SUCCESS [ 15.004 s]
[INFO] Openmeetings Web ... FAILURE [42:36 min]
[INFO] Openmeetings Screen Sharing applet . SKIPPED
[INFO] Openmeetings Server SKIPPED
[INFO]
[INFO] BUILD FAILURE
{code}
The results for modules without errors are very much the same
While for the failing module the results are ~60x slower :((
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805491#comment-17805491
]
Maxim Solodovnik commented on RAT-325:
--
I'm currently testing {{0.16}}
the performance seems to degrade significantly (I'll provide exact numbers as
soon as I'll bypass new custom license syntax)
The weird thing I've noticed very lng delay between:
{code}
[INFO] --- apache-rat:0.16:check (default) @ openmeetings-web ---
[INFO] Rat check: Summary over all files. Unapproved: 6, unknown: 6, generated:
63, approved: 595 licenses.
{code}
and
{code}
[WARNING] Files with unapproved licenses:
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/css/_cssemoticons.scss
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/chat/cssemoticons.js
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.min.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/images/audio.svg
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/images/phone.svg
{code}
i.e. list of files with unapproved licensed is being printed for about minute
.
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805031#comment-17805031 ] Jochen Wiedmann commented on RAT-325: - Could we, please, have a clear distinction between the following two topics: a) Identify the commit, which introduced the performance issue. That's what "git bisect" is for, and nothing else. b) As soon as we know that commit, look at the difference, develop ideas like "due to SPDX scanning", or "Copyright checks" and thereby create the basis for a fix. My observation is, that we are constantly mixing these two steps above. And that prevents me from doing my own analysis. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805012#comment-17805012 ] Claude Warren commented on RAT-325: --- I think the SPDX is slow because is it does a regex on every line (only 1 even if there are multiple SPDX targets). However I think this can be sped up even further by adding a string check to see if "SPDX" appears in the line first. The same is also true for the Copyright checks. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804985#comment-17804985 ] Jean-Baptiste Onofré commented on RAT-325: -- [~joc...@apache.org] I did the tests using 0.16-SNAPSHOT at the time of the test (build locally), running rat on iceberg repo (main). When I did the bisect, the performance regression was due to SPDX scanning. I was busy with other Apache projects, but now that 0.16 has been released, I will do the test again (adding itests/perf tests in the rat directly). > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804888#comment-17804888 ] Jochen Wiedmann commented on RAT-325: - [~jbonofre] In your comment from 30/Oct/2023, you unfortunately don't write, on which code basis you are running Rat. Is this some public code basis, so that we could reproduce your numbers, and use "git bisect" to really identify the commit, that introduced this problem? If so, we should be able to fix it quickly. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794922#comment-17794922 ] Jean-Baptiste Onofré commented on RAT-325: -- [~pottlinger] I'm back on RAT this week end. I will resume work on this one. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794875#comment-17794875 ] Philipp Ottlinger commented on RAT-325: --- [~jbonofre] [~claude] ping - is this task a blocker for releasing 0.16 or should we push out the release in order to collect more feedback from downstream clients? > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781890#comment-17781890 ] Claude Warren commented on RAT-325: --- I have created a branch on my repository that changes to block processing and defines an IHeaders interface that has the raw header as well as a pruned one. So the creation of the header block and the pruning of it is only done once. This should improve performance and reduce memory footprint. We can address if we want to change the prune function later (it is as originally developed prior to v0.16). The code is on: https://github.com/Claudenw/creadur-rat/tree/performance_improvement > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781683#comment-17781683 ] Claude Warren commented on RAT-325: --- That is what I would expect. If you edit the configuration file /org/apache/rat/default.xml and remove the "not" clause on lines 22-24 I expect you will see a speed up. This is the issue with "not" requiring that the block of input be processed until the end before being able to determine that the enclosed option is false. In this case that the copyright does not exist. Since it has to process to the end and since the Copyright is a regex on every line it is expensive. This is where I think the idea of specifying if a process is line or block oriented may make sense. Though I think that all of the line oriented checks work on the block as well. The code in the o.a.r.analysis.HeaderCheckWorker.readLine() reads each line and calls the matcher to see if it matches. I think it would be much faster to modify HeaderCheckWorker.read() so that it reads the entire header block into a buffer first and then pass that buffer to the Matcher to see if it matches. This will ammortise the "Not", "regex" and "long text" costs. Also, we should be able to simplify the "long text" checks as now each instance won't have to build the buffer itself and in the future we can probably convert it to a regex provided we do some work when we build the buffer to extract only comment code from the source files. This would be a further optimization. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781612#comment-17781612 ] Jean-Baptiste Onofré commented on RAT-325: -- It seems that commit c457a07f3768e6e2aebb4c326247170727fcaec2 introduced regression as well. I continue the investigations. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781273#comment-17781273 ] Jean-Baptiste Onofré commented on RAT-325: -- Good idea, I will add some regression/bench tests. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781272#comment-17781272 ] Claude Warren commented on RAT-325: --- Can you add tests so that we can catch performance degradation in the future even if they don't run automatically. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781269#comment-17781269 ] Jean-Baptiste Onofré commented on RAT-325: -- Let me do further tests to square the issue. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781268#comment-17781268 ] Claude Warren commented on RAT-325: --- I would doubt the SPDX feature because that was fixed in an earlier verson. SPDX uses a lot of regex. It may be the Copyright check that is now included in the Apache check. It also does regex checking. The solution may be to break the matchers into 2 classes. Those that work line-by-line, and those that work on the complete block. Do not call the evaluation of the block based matchers during the line reading, but wait until afther the entire header block (currently 50 lines) is read and then run all the block tests across that block of text. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781224#comment-17781224 ] Jean-Baptiste Onofré commented on RAT-325: -- I'm doing a new pass to be more precise on the change. I will do a test by removing the SPDX feature to narrow the issue. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781128#comment-17781128 ] Philipp Ottlinger commented on RAT-325: --- [~claud...@users.sourceforge.net] I assume the performance degradation is due to the new SPDX feature would it help to enable SPDX-scanning as a configuration parameter? > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781062#comment-17781062
]
Jean-Baptiste Onofré commented on RAT-325:
--
With rat 0.16-SNAPSHOT:
{code:java}
44.53s user 0.51s system 103% cpu 43.501 total {code}
With rat 0.15:
{code:java}
2.25s user 0.33s system 279% cpu 0.923 total {code}
On the same machine, same JVM, same directory scanned.
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.16
>
>
> While testing 0.16-SNAPSHOT, I identified rat is way longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
