Re: [VOTE] Release Apache Curator version 5.6.0
UNRESOLVED issues moved. I created [1] for resolving other website suggestions. Best, tison. [1] https://github.com/apache/curator-site/pull/4 tison 于2024年1月7日周日 22:15写道： > > Thanks for your verification and suggestions! > > Enrico said he would take a look at Monday, so I'll wait a bit. And I > can schedule to patch the suggestions :D > > Best, > tison. > > Kezhu Wang 于2024年1月7日周日 20:10写道： > > > > Hi all, > > > > Thanks @tison for the release work! > > > > +1 binding > > > > I checked the following and all succeeded. > > * Ran "./mvnw verify" in jdk 8,11 and 21. > > * Matched md5, sha1 and signature of artifacts. > > > > I found the following problems but I think none of them are blockers > > and could be fixed before/after official announcement: > > * ReleaseNode contains "Unresolved" jira issues. I think we should > > update "Fix Version" for these issues before the official > > announcement. > > * Link for PGP KEYS is invalid now. It should be > > https://downloads.apache.org/curator/KEYS now. We might also want to > > fix this in the email template hosted on confluence wiki or our new > > website. > > * This is the first release after our new website, so I guess our > > download link in the "ANNOUNCE" email template should also be updated. > > > > Best, > > Kezhu Wang > > > > On Fri, Jan 5, 2024 at 11:12 PM tison wrote: > > > > > > +1 binding > > > > > > + Download links valid > > > + Checksum and signature matched > > > + LICENSE and NOTICE present > > > + Build and test > > > > > > Best, > > > tison. > > > > > > Jordan Zimmerman 于2024年1月5日周五 00:50写道： > > > > > > > > > > > +1 binding > > > > > > > > Tests pass > > > > Hash matches > > > > Signature verifies > > > > > > > > -JZ > > > > > > > > > On Jan 2, 2024, at 4:40 PM, tison wrote: > > > > > > > > > > Hello, > > > > > > > > > > This is the vote for Apache Curator version 5.6.0 > > > > > > > > > > *** Please download, test and vote within approx. 72 hours > > > > > > > > > > Note that we are voting upon the source (tag) and binaries are > > > > > provided for convenience. > > > > > > > > > > Link to release notes: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353185&styleName=Text&projectId=12314425 > > > > > > > > > > Staging repo: > > > > > https://dist.apache.org/repos/dist/dev/curator/5.6.0/ > > > > > > > > > > Binary artifacts: > > > > > https://repository.apache.org/content/repositories/orgapachecurator-1057 > > > > > > > > > > The tag to be voted upon: > > > > > https://github.com/apache/curator/releases/tag/apache-curator-5.6.0 > > > > > > > > > > Curator's KEYS file containing PGP keys we use to sign the release: > > > > > https://www.apache.org/dist/curator/KEYS > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > Best, > > > > > tison. > > > >
[jira] [Updated] (CURATOR-654) DistributedBarrier watcher leak
[ https://issues.apache.org/jira/browse/CURATOR-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated CURATOR-654: -- Fix Version/s: 5.7.0 (was: 5.6.0) > DistributedBarrier watcher leak > --- > > Key: CURATOR-654 > URL: https://issues.apache.org/jira/browse/CURATOR-654 > Project: Apache Curator > Issue Type: Bug > Components: Recipes >Affects Versions: 5.3.0 >Reporter: Stuart Scott >Priority: Major > Fix For: 5.7.0 > > Attachments: > CURATOR-654__Remove_watchers_after_waiting_for_barrier_.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The DistributedBarrier adds a zookeeper exists watcher in the waitOnBarrier() > method. It appears as though the watcher is never removed. In a system where > DistributedBarriers are used heavily this eventually results in the system > running out of memory. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CURATOR-670) CuratorTransactionResult.ofTypeAndPath leaks guava Predicte to public
[ https://issues.apache.org/jira/browse/CURATOR-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated CURATOR-670: -- Fix Version/s: 5.7.0 (was: 5.6.0) > CuratorTransactionResult.ofTypeAndPath leaks guava Predicte to public > - > > Key: CURATOR-670 > URL: https://issues.apache.org/jira/browse/CURATOR-670 > Project: Apache Curator > Issue Type: Bug >Affects Versions: 5.5.0 >Reporter: Kezhu Wang >Assignee: Enrico Olivelli >Priority: Major > Fix For: 5.7.0 > > > I found this in verifying tests against staging artifacts. > From description, CURATOR-558 tried to drop usages of guava in public API. > This seems a missing. > PS: [https://cwiki.apache.org/confluence/display/CURATOR/TN13] seems dated in > upgrading to 5.x. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CURATOR-663) ZooKeeperServerEmbeddedAdapter.configure might fail with ClassCastException
[
https://issues.apache.org/jira/browse/CURATOR-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zili Chen updated CURATOR-663:
--
Fix Version/s: 5.7.0
(was: 5.6.0)
> ZooKeeperServerEmbeddedAdapter.configure might fail with ClassCastException
> ---
>
> Key: CURATOR-663
> URL: https://issues.apache.org/jira/browse/CURATOR-663
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
>Affects Versions: 5.4.0
>Reporter: Matthias Pohl
>Priority: Major
> Fix For: 5.7.0
>
>
> There might be a {{ClassCastException}} happening when starting the
> {{TestingZooKeeper}} instance. The following test reproduces the issue:
> {code}
> @Test
> public void testTestingZooKeeperServer() throws Exception
> {
> final Map customProperties = new HashMap<>();
> customProperties.put("maxSessionTimeout", 60_000);
> final Path tmpDirPath = Files.createTempDirectory("tmp-");
> final InstanceSpec instanceSpec = new InstanceSpec(tmpDirPath.toFile(), 0,
> 0, 0, true, 0, 10, 1, customProperties, "host-name");
> final QuorumConfigBuilder quorumConfigBuilder = new
> QuorumConfigBuilder(instanceSpec);
> final TestingZooKeeperServer zkServer = new
> TestingZooKeeperServer(quorumConfigBuilder);
> zkServer.start();
> }
> {code}
> The test above will fail with a {{ClassCastException}} because
> {{InstantSpec}} allows a {{Map}} for custom properties, i.e.
> a non-String value like Integer can be used.
> This {{Map}} is then passed over into a {{Properties}} instance in
> [QuorumConfigBuilder:163|https://github.com/apache/curator/blob/master/curator-test/src/main/java/org/apache/curator/test/QuorumConfigBuilder.java#L163].
> These {{Properties}} are then written to a temporary file in ZooKeeper's
> [ZooKeeperServerEmbeddedImpl:58|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/embedded/ZooKeeperServerEmbeddedImpl.java#L58]
> which expects only to have String values. The previously set Integer value
> isn't converted to a String anywhere, though.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CURATOR-688) SharedCount will be never updated successful when version of ZNode is overflow
[ https://issues.apache.org/jira/browse/CURATOR-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated CURATOR-688: -- Fix Version/s: 5.7.0 (was: 5.6.0) > SharedCount will be never updated successful when version of ZNode is overflow > -- > > Key: CURATOR-688 > URL: https://issues.apache.org/jira/browse/CURATOR-688 > Project: Apache Curator > Issue Type: Bug > Components: Recipes >Reporter: Xiaoqiao He >Priority: Major > Fix For: 5.7.0 > > > I met one issue which will never update znode value successfully when integer > overflow (-2147483648) of znode data version using curator to invoke > SharedCount#trySetCount(VersionedValue, int). > After dig the limitation logic and found that here could be the root cause. > https://github.com/apache/curator/blob/master/curator-recipes/src/main/java/org/apache/curator/framework/recipes/shared/SharedValue.java#L196C7-L196C7 > My environment is, curator version: curator-2.10.0, zookeeper version: 3.4.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Curator version 5.6.0
Thanks for your verification and suggestions! Enrico said he would take a look at Monday, so I'll wait a bit. And I can schedule to patch the suggestions :D Best, tison. Kezhu Wang 于2024年1月7日周日 20:10写道： > > Hi all, > > Thanks @tison for the release work! > > +1 binding > > I checked the following and all succeeded. > * Ran "./mvnw verify" in jdk 8,11 and 21. > * Matched md5, sha1 and signature of artifacts. > > I found the following problems but I think none of them are blockers > and could be fixed before/after official announcement: > * ReleaseNode contains "Unresolved" jira issues. I think we should > update "Fix Version" for these issues before the official > announcement. > * Link for PGP KEYS is invalid now. It should be > https://downloads.apache.org/curator/KEYS now. We might also want to > fix this in the email template hosted on confluence wiki or our new > website. > * This is the first release after our new website, so I guess our > download link in the "ANNOUNCE" email template should also be updated. > > Best, > Kezhu Wang > > On Fri, Jan 5, 2024 at 11:12 PM tison wrote: > > > > +1 binding > > > > + Download links valid > > + Checksum and signature matched > > + LICENSE and NOTICE present > > + Build and test > > > > Best, > > tison. > > > > Jordan Zimmerman 于2024年1月5日周五 00:50写道： > > > > > > > > +1 binding > > > > > > Tests pass > > > Hash matches > > > Signature verifies > > > > > > -JZ > > > > > > > On Jan 2, 2024, at 4:40 PM, tison wrote: > > > > > > > > Hello, > > > > > > > > This is the vote for Apache Curator version 5.6.0 > > > > > > > > *** Please download, test and vote within approx. 72 hours > > > > > > > > Note that we are voting upon the source (tag) and binaries are > > > > provided for convenience. > > > > > > > > Link to release notes: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353185&styleName=Text&projectId=12314425 > > > > > > > > Staging repo: > > > > https://dist.apache.org/repos/dist/dev/curator/5.6.0/ > > > > > > > > Binary artifacts: > > > > https://repository.apache.org/content/repositories/orgapachecurator-1057 > > > > > > > > The tag to be voted upon: > > > > https://github.com/apache/curator/releases/tag/apache-curator-5.6.0 > > > > > > > > Curator's KEYS file containing PGP keys we use to sign the release: > > > > https://www.apache.org/dist/curator/KEYS > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Best, > > > > tison. > > >
Re: [VOTE] Release Apache Curator version 5.6.0
Hi all, Thanks @tison for the release work! +1 binding I checked the following and all succeeded. * Ran "./mvnw verify" in jdk 8,11 and 21. * Matched md5, sha1 and signature of artifacts. I found the following problems but I think none of them are blockers and could be fixed before/after official announcement: * ReleaseNode contains "Unresolved" jira issues. I think we should update "Fix Version" for these issues before the official announcement. * Link for PGP KEYS is invalid now. It should be https://downloads.apache.org/curator/KEYS now. We might also want to fix this in the email template hosted on confluence wiki or our new website. * This is the first release after our new website, so I guess our download link in the "ANNOUNCE" email template should also be updated. Best, Kezhu Wang On Fri, Jan 5, 2024 at 11:12 PM tison wrote: > > +1 binding > > + Download links valid > + Checksum and signature matched > + LICENSE and NOTICE present > + Build and test > > Best, > tison. > > Jordan Zimmerman 于2024年1月5日周五 00:50写道： > > > > > +1 binding > > > > Tests pass > > Hash matches > > Signature verifies > > > > -JZ > > > > > On Jan 2, 2024, at 4:40 PM, tison wrote: > > > > > > Hello, > > > > > > This is the vote for Apache Curator version 5.6.0 > > > > > > *** Please download, test and vote within approx. 72 hours > > > > > > Note that we are voting upon the source (tag) and binaries are > > > provided for convenience. > > > > > > Link to release notes: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353185&styleName=Text&projectId=12314425 > > > > > > Staging repo: > > > https://dist.apache.org/repos/dist/dev/curator/5.6.0/ > > > > > > Binary artifacts: > > > https://repository.apache.org/content/repositories/orgapachecurator-1057 > > > > > > The tag to be voted upon: > > > https://github.com/apache/curator/releases/tag/apache-curator-5.6.0 > > > > > > Curator's KEYS file containing PGP keys we use to sign the release: > > > https://www.apache.org/dist/curator/KEYS > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove (and reason why) > > > > > > Best, > > > tison. > >
