Re: Release Notes pages
+1 this is something I’ve heard a lot of people ask for, and will make getting the word out about DS much easier. On 7 Sep 2014, at 16:06, John D. Ament wrote: > Hi all > > I was looking at other apache projects and noted that many of them include > dedicated pages for each release, with some summary information about what > went in. In DeltaSpike we're currently putting a short blurb, I was > wondering if it makes sense to include something similar, and perhaps even > merge with the generated release notes that make it into the SCM. > > Here's a prototype page: [1]. > > > http://deltaspike.staging.apache.org/documentation/deltaspike_1.0.2.html
Re: Gap with BeanManagerProvider
Hmm so it seems like when I look at the underlying classloader structure,
shrinkwrap is the lowest, then app cl, then ext cl. Inside the test,
there's never a case where it's invoked via shrinkwrap. I'm wondering if
it makes sense to also bind parent classloaders in the hashmap. They
should end up overwritten if a new one is created.
It does look like we have an ear test, so I can verify if this introduces
any issues or not.
On Mon, Sep 8, 2014 at 12:52 AM, Romain Manni-Bucau
wrote:
> Hi
>
> It means you'll not get the right bm sometimes (multithreaded arquillian
> tests for instance I think).
>
> BMP relies on classloader so if test is not executed in archive loader
> (shrinkwrapclassloader) then DS - but not only - is broken.
>
> I'd fix the arquillian adapter here.
> Le 8 sept. 2014 05:27, "John D. Ament" a écrit :
>
> > Hi all
> >
> > I noticed that there's a potential gap with BeanManagerProvider. I was
> > able to generate the following output when running a ShrinkWrap test with
> > the BeanManagerProvider:
> >
> > Retrieved bmi null with classloader
> > org.jboss.shrinkwrap.api.classloader.ShrinkWrapClassLoader@2ab4bc72
> >
> > Putting a new bmi
> >
> >
> >
> org.apache.deltaspike.core.api.provider.BeanManagerProvider$BeanManagerInfo@3d829787
> >
> > Sep 08, 2014 12:19:22 AM
> >
> >
> org.apache.deltaspike.core.impl.config.EnvironmentPropertyConfigSourceProvider
> >
> >
> > INFO: Custom config found by DeltaSpike. Name: 'se-example.properties',
> > URL:
> >
> >
> 'file:/Users/johnament/src/restful-and-beyond-tut2184/code/target/test-classes/se-example.properties'
> >
> > {org.jboss.shrinkwrap.api.classloader.ShrinkWrapClassLoader@2ab4bc72
> >
> >
> =org.apache.deltaspike.core.api.provider.BeanManagerProvider$BeanManagerInfo@3d829787
> > }
> >
> > Retrieved bmi null with classloader
> > sun.misc.Launcher$AppClassLoader@6e0be858
> >
> > Putting a new bmi
> >
> >
> >
> org.apache.deltaspike.core.api.provider.BeanManagerProvider$BeanManagerInfo@7278640c
> >
> > Getting parent classloader based bean manager
> >
> > Retrieved bmi null with classloader
> > sun.misc.Launcher$ExtClassLoader@9f7fc43
> >
> > Putting a new bmi
> >
> > Sep 08, 2014 12:19:23 AM
> > org.apache.deltaspike.core.api.provider.BeanManagerProvider
> getBeanManager
> >
> >
> > This line here is especially weird, it's happening as the first line of
> my
> > test, yet it looks like afterwards I'm getting more BeanManagerInfo's
> > loaded.
> >
> >
> > I was able to work around this issue by adding the following check when
> > loading the bean manager:
> >
> >
> > synchronized (this)
> > {
> > bmi = bmpSingleton.bmInfos.get(cl);
> > if (bmi == null && bmpSingleton.bmInfos.isEmpty())
> > {
> > bmi = new BeanManagerInfo();
> > bmpSingleton.bmInfos.put(cl, bmi);
> > }
> > else
> > {
> > ClassLoader classLoader =
> > bmpSingleton.bmInfos.keySet().iterator().next();
> > bmi = bmpSingleton.bmInfos.get(classLoader);
> > }
> > }
> >
>
Re: Gap with BeanManagerProvider
issue is parent classloaders can get a different BM (ears for instance
but OSGi where classloading is "weird")
something like
http://svn.apache.org/repos/asf/tomee/tomee/trunk/arquillian/arquillian-common/src/main/java/org/apache/openejb/arquillian/common/TestObserver.java
solves it - it uses openejb internals but hopefully the idea is more
explicit
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-09-08 13:09 GMT+02:00 John D. Ament :
> Hmm so it seems like when I look at the underlying classloader structure,
> shrinkwrap is the lowest, then app cl, then ext cl. Inside the test,
> there's never a case where it's invoked via shrinkwrap. I'm wondering if
> it makes sense to also bind parent classloaders in the hashmap. They
> should end up overwritten if a new one is created.
>
> It does look like we have an ear test, so I can verify if this introduces
> any issues or not.
>
> On Mon, Sep 8, 2014 at 12:52 AM, Romain Manni-Bucau
> wrote:
>
>> Hi
>>
>> It means you'll not get the right bm sometimes (multithreaded arquillian
>> tests for instance I think).
>>
>> BMP relies on classloader so if test is not executed in archive loader
>> (shrinkwrapclassloader) then DS - but not only - is broken.
>>
>> I'd fix the arquillian adapter here.
>> Le 8 sept. 2014 05:27, "John D. Ament" a écrit :
>>
>> > Hi all
>> >
>> > I noticed that there's a potential gap with BeanManagerProvider. I was
>> > able to generate the following output when running a ShrinkWrap test with
>> > the BeanManagerProvider:
>> >
>> > Retrieved bmi null with classloader
>> > org.jboss.shrinkwrap.api.classloader.ShrinkWrapClassLoader@2ab4bc72
>> >
>> > Putting a new bmi
>> >
>> >
>> >
>> org.apache.deltaspike.core.api.provider.BeanManagerProvider$BeanManagerInfo@3d829787
>> >
>> > Sep 08, 2014 12:19:22 AM
>> >
>> >
>> org.apache.deltaspike.core.impl.config.EnvironmentPropertyConfigSourceProvider
>> >
>> >
>> > INFO: Custom config found by DeltaSpike. Name: 'se-example.properties',
>> > URL:
>> >
>> >
>> 'file:/Users/johnament/src/restful-and-beyond-tut2184/code/target/test-classes/se-example.properties'
>> >
>> > {org.jboss.shrinkwrap.api.classloader.ShrinkWrapClassLoader@2ab4bc72
>> >
>> >
>> =org.apache.deltaspike.core.api.provider.BeanManagerProvider$BeanManagerInfo@3d829787
>> > }
>> >
>> > Retrieved bmi null with classloader
>> > sun.misc.Launcher$AppClassLoader@6e0be858
>> >
>> > Putting a new bmi
>> >
>> >
>> >
>> org.apache.deltaspike.core.api.provider.BeanManagerProvider$BeanManagerInfo@7278640c
>> >
>> > Getting parent classloader based bean manager
>> >
>> > Retrieved bmi null with classloader
>> > sun.misc.Launcher$ExtClassLoader@9f7fc43
>> >
>> > Putting a new bmi
>> >
>> > Sep 08, 2014 12:19:23 AM
>> > org.apache.deltaspike.core.api.provider.BeanManagerProvider
>> getBeanManager
>> >
>> >
>> > This line here is especially weird, it's happening as the first line of
>> my
>> > test, yet it looks like afterwards I'm getting more BeanManagerInfo's
>> > loaded.
>> >
>> >
>> > I was able to work around this issue by adding the following check when
>> > loading the bean manager:
>> >
>> >
>> > synchronized (this)
>> > {
>> > bmi = bmpSingleton.bmInfos.get(cl);
>> > if (bmi == null && bmpSingleton.bmInfos.isEmpty())
>> > {
>> > bmi = new BeanManagerInfo();
>> > bmpSingleton.bmInfos.put(cl, bmi);
>> > }
>> > else
>> > {
>> > ClassLoader classLoader =
>> > bmpSingleton.bmInfos.keySet().iterator().next();
>> > bmi = bmpSingleton.bmInfos.get(classLoader);
>> > }
>> > }
>> >
>>
[jira] [Commented] (DELTASPIKE-698) fix glassfish4 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125750#comment-14125750 ] Rafael Benevides commented on DELTASPIKE-698: - [~struberg] Do you mind testing it on your local machine and comment here the result with your maven and jdk version ? > fix glassfish4 profile > -- > > Key: DELTASPIKE-698 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-698 > Project: DeltaSpike > Issue Type: Bug >Affects Versions: 1.0.2 >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.3 > > > https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_GF4 > shows failing tests due to e.g. "Could not start container" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Release Notes pages
If no one has any objections, I'd like to move foward with using openhub for the contributors list. On Sun, Sep 7, 2014 at 3:47 PM, Gerhard Petracek wrote: > @john: > i'm not sure if romain finished all his plans with this site. > > regards, > gerhard > > > > 2014-09-07 21:38 GMT+02:00 John D. Ament : > > > Hi > > > > Seems like maintaining the csv file is a PITA. It's missing some newer > > committers. It also looks clearer to me who is actually active in the > > project, vs the csv file, especially at [1]. > > > > [1]: > https://www.openhub.net/p/DeltaSpike/contributors?query=&sort=commits > > > > On Sun, Sep 7, 2014 at 12:04 PM, Gerhard Petracek < > > gerhard.petra...@gmail.com> wrote: > > > > > hi john, > > > > > > @openhub - fyi: > > > we have a contributors page already (see [1]). > > > > > > regards, > > > gerhard > > > > > > [1] http://deltaspike.apache.org/contributors.html > > > > > > > > > > > > 2014-09-07 17:54 GMT+02:00 Karl Kildén : > > > > > > > What a great page! I did not know about Double-Submit prevention > > feature > > > > and I was actually investigating how to solve it just now :-) > > > > > > > > > > > > On 7 September 2014 17:06, John D. Ament > > wrote: > > > > > > > > > Hi all > > > > > > > > > > I was looking at other apache projects and noted that many of them > > > > include > > > > > dedicated pages for each release, with some summary information > about > > > > what > > > > > went in. In DeltaSpike we're currently putting a short blurb, I > was > > > > > wondering if it makes sense to include something similar, and > perhaps > > > > even > > > > > merge with the generated release notes that make it into the SCM. > > > > > > > > > > Here's a prototype page: [1]. > > > > > > > > > > > > > > > > > > > http://deltaspike.staging.apache.org/documentation/deltaspike_1.0.2.html > > > > > > > > > > > > > > >
Re: Release Notes pages
Agreed, I was about to post something on reddit for ds and noticed there was no release page. On Mon, Sep 8, 2014 at 6:04 AM, Pete Muir wrote: > +1 this is something I’ve heard a lot of people ask for, and will make > getting the word out about DS much easier. > > On 7 Sep 2014, at 16:06, John D. Ament wrote: > > > Hi all > > > > I was looking at other apache projects and noted that many of them > include > > dedicated pages for each release, with some summary information about > what > > went in. In DeltaSpike we're currently putting a short blurb, I was > > wondering if it makes sense to include something similar, and perhaps > even > > merge with the generated release notes that make it into the SCM. > > > > Here's a prototype page: [1]. > > > > > > http://deltaspike.staging.apache.org/documentation/deltaspike_1.0.2.html > >
[jira] [Commented] (DELTASPIKE-710) Error using clientWindow and (p|f):ajax
[
https://issues.apache.org/jira/browse/DELTASPIKE-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125946#comment-14125946
]
Thomas Andraschko commented on DELTASPIKE-710:
--
Could you please provide an complet test bean and page?
AFAIR It worked for me for f:ajax ->
https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;a=blob;f=deltaspike/examples/jsf-playground/src/main/webapp/views/windowhandling/lazy/test.xhtml;h=eb7ff03a6a7ce17a2f74d3a930d98c6be3c23b85;hb=HEAD
> Error using clientWindow and (p|f):ajax
> ---
>
> Key: DELTASPIKE-710
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-710
> Project: DeltaSpike
> Issue Type: Bug
> Components: JSF-Module
>Affects Versions: 1.0.2
>Reporter: Janario
> Attachments: console.log
>
>
> Trying to use CLIENTWINDOW with some h:commandLink and f:ajax or p:ajax
> doesn't work.
> I've tried, in a simple action method (public void actionTest() {} ):
> test f:ajax
>
>
> test f:ajax
>
>
> For f:ajax it doesn't log any error but doesn't call my action method.
> For p:ajax it logs some error on browser console:
> Uncaught TypeError: Cannot read property 'replace' of undefined
> primefaces.js?ln=primefaces&v=5.0:1
> b.escapeClientId
> primefaces.js?ln=primefaces&v=5.0:1
> PrimeFaces.ajax.Request.send
> primefaces.js?ln=primefaces&v=5.0:2
> PrimeFaces.ajax.Queue.offer
> primefaces.js?ln=primefaces&v=5.0:2
> PrimeFaces.ajax.Request.handle
> primefaces.js?ln=primefaces&v=5.0:2
> PrimeFaces.ab
> primefaces.js?ln=primefaces&v=5.0:2
> onclick
> ?dsrid=949&dswid=8555:1
> d.(anonymous function).onclick.match.d.(anonymous function).onclick
> windowhandler.js?ln=deltaspike&v=1.0.2:2
> d.(anonymous function).onclick.match.d.(anonymous function).onclick
> windowhandler.js?ln=deltaspike&v=1.0.2:2
> I've tried the same with p:commandLink and it works
> test f:ajax
>
>
> test f:ajax
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Release Notes pages
I like this, the whole thing. +1 from me. On Mon, Sep 8, 2014 at 12:04 PM, John D. Ament wrote: > Agreed, I was about to post something on reddit for ds and noticed there > was no release page. > > On Mon, Sep 8, 2014 at 6:04 AM, Pete Muir wrote: > > > +1 this is something I’ve heard a lot of people ask for, and will make > > getting the word out about DS much easier. > > > > On 7 Sep 2014, at 16:06, John D. Ament wrote: > > > > > Hi all > > > > > > I was looking at other apache projects and noted that many of them > > include > > > dedicated pages for each release, with some summary information about > > what > > > went in. In DeltaSpike we're currently putting a short blurb, I was > > > wondering if it makes sense to include something similar, and perhaps > > even > > > merge with the generated release notes that make it into the SCM. > > > > > > Here's a prototype page: [1]. > > > > > > > > > > http://deltaspike.staging.apache.org/documentation/deltaspike_1.0.2.html > > > > > -- Jason Porter http://en.gravatar.com/lightguardjp
[jira] [Created] (DELTASPIKE-711) Create placeholder documentation directory
John D. Ament created DELTASPIKE-711: Summary: Create placeholder documentation directory Key: DELTASPIKE-711 URL: https://issues.apache.org/jira/browse/DELTASPIKE-711 Project: DeltaSpike Issue Type: Task Components: Documentation Affects Versions: 1.0.2 Reporter: John D. Ament Assignee: John D. Ament Priority: Minor Fix For: 1.0.3 Add a documentation folder, top level, to allow the publishing of asciidoc files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DELTASPIKE-712) BeanManagerProvider : Wrap usage in parent class loaders
John D. Ament created DELTASPIKE-712: Summary: BeanManagerProvider : Wrap usage in parent class loaders Key: DELTASPIKE-712 URL: https://issues.apache.org/jira/browse/DELTASPIKE-712 Project: DeltaSpike Issue Type: Improvement Components: Core Affects Versions: 1.0.2 Reporter: John D. Ament Assignee: John D. Ament Fix For: 1.0.3 Currently, the parent classloader is not used in the BeanManagerProvider. In certain SE scenarios, when packaging a test with shrinkwrap, the parent classloader is required as the shrinkwrap classloader is only used during packaging and not runtime. This change adds an extra map entry for the parent classloader so that the app classloader can bring in the provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (DELTASPIKE-710) Error using clientWindow and (p|f):ajax
[
https://issues.apache.org/jira/browse/DELTASPIKE-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerhard Petracek updated DELTASPIKE-710:
Assignee: Thomas Andraschko
> Error using clientWindow and (p|f):ajax
> ---
>
> Key: DELTASPIKE-710
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-710
> Project: DeltaSpike
> Issue Type: Bug
> Components: JSF-Module
>Affects Versions: 1.0.2
>Reporter: Janario
>Assignee: Thomas Andraschko
> Attachments: console.log
>
>
> Trying to use CLIENTWINDOW with some h:commandLink and f:ajax or p:ajax
> doesn't work.
> I've tried, in a simple action method (public void actionTest() {} ):
> test f:ajax
>
>
> test f:ajax
>
>
> For f:ajax it doesn't log any error but doesn't call my action method.
> For p:ajax it logs some error on browser console:
> Uncaught TypeError: Cannot read property 'replace' of undefined
> primefaces.js?ln=primefaces&v=5.0:1
> b.escapeClientId
> primefaces.js?ln=primefaces&v=5.0:1
> PrimeFaces.ajax.Request.send
> primefaces.js?ln=primefaces&v=5.0:2
> PrimeFaces.ajax.Queue.offer
> primefaces.js?ln=primefaces&v=5.0:2
> PrimeFaces.ajax.Request.handle
> primefaces.js?ln=primefaces&v=5.0:2
> PrimeFaces.ab
> primefaces.js?ln=primefaces&v=5.0:2
> onclick
> ?dsrid=949&dswid=8555:1
> d.(anonymous function).onclick.match.d.(anonymous function).onclick
> windowhandler.js?ln=deltaspike&v=1.0.2:2
> d.(anonymous function).onclick.match.d.(anonymous function).onclick
> windowhandler.js?ln=deltaspike&v=1.0.2:2
> I've tried the same with p:commandLink and it works
> test f:ajax
>
>
> test f:ajax
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-698) fix glassfish4 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126443#comment-14126443 ] John D. Ament commented on DELTASPIKE-698: -- I'm using 1.7.0_55-b13 and it passed for me. I can try a newer JDK7 build as well. Ironically, glassfish3 was failing for me earlier. > fix glassfish4 profile > -- > > Key: DELTASPIKE-698 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-698 > Project: DeltaSpike > Issue Type: Bug >Affects Versions: 1.0.2 >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.3 > > > https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_GF4 > shows failing tests due to e.g. "Could not start container" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
