Re: [VOTE] Release 0.4.0, release candidate #2

2017-01-12 Thread Sijie Guo 
On Jan 12, 2017 6:59 PM, "liang xie"  wrote:

I am not good at here, per my knowledge, we should add the bindings
into benchmark package, at least in next release.


Agree. Do you mind creating a Jira for this?


On Fri, Jan 13, 2017 at 12:42 AM, Sijie Guo  wrote:
> I think we turned the log4j binding scope to test sometime ago. The
thought
> was not to conflict bindings when DL is used as a library in other
projects.
>
> For binaries, it seems worth brining the bindings in. What does other
> projects do for slf4j bindings?
>
> Sijie
>
> On Jan 12, 2017 12:58 AM, "liang xie"  wrote:
>
> Verified source package with provided command and looks good to me.
>
> Seems missing slf4j-log4j12-1.6.4.jar in benchmark lib directory ?
> since i saw this error if execute "dbench write":
>
> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
> SLF4J: Defaulting to no-operation (NOP) logger implementation
> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for
> further details.
>
>
>
> On Wed, Jan 11, 2017 at 3:56 PM, Sijie Guo  wrote:
>> Hi all,
>>
>> Please review and vote on the release candidate #2 for the version 0.4.0,
>> as follows:
>>
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> The complete staging area is available for your review, which includes:
>>
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to
dist.apache.org
>>  [2],
>> * all artifacts to be deployed to the Maven Central Repository
[3][4],
>> * source code tag "v0.4.0-incubating-RC1_2.11" (for scala 2.11) and
>> "v0.4.0-incubating-RC1_2.10" (for scala 2.10) [5][6],
>> * website pull request listing the release [7] and publishing the API
>> reference manual.
>>
>> A simple instruction for validation the source and binary packages.
>>
>> - source package: building the package with "*mvn clean apache-rat:check
>> package findbugs:check -DskipTests*"
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PPMC affirmative votes.
>>
>> Thanks,
>> Sijie
>>
>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> projectId=12320620=12337980
>> [2]
>> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating-RC2/
>> [3]
>> https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1003/
>> [4]
>> https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1004/
>> [5]
>> https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1_2.11
>> [6]
>> https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1_2.10
>> [7] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #2

2017-01-12 Thread Sijie Guo 
I think we turned the log4j binding scope to test sometime ago. The thought
was not to conflict bindings when DL is used as a library in other projects.

For binaries, it seems worth brining the bindings in. What does other
projects do for slf4j bindings?

Sijie

On Jan 12, 2017 12:58 AM, "liang xie"  wrote:

Verified source package with provided command and looks good to me.

Seems missing slf4j-log4j12-1.6.4.jar in benchmark lib directory ?
since i saw this error if execute "dbench write":

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for
further details.



On Wed, Jan 11, 2017 at 3:56 PM, Sijie Guo  wrote:
> Hi all,
>
> Please review and vote on the release candidate #2 for the version 0.4.0,
> as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
>
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
>  [2],
> * all artifacts to be deployed to the Maven Central Repository [3][4],
> * source code tag "v0.4.0-incubating-RC1_2.11" (for scala 2.11) and
> "v0.4.0-incubating-RC1_2.10" (for scala 2.10) [5][6],
> * website pull request listing the release [7] and publishing the API
> reference manual.
>
> A simple instruction for validation the source and binary packages.
>
> - source package: building the package with "*mvn clean apache-rat:check
> package findbugs:check -DskipTests*"
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PPMC affirmative votes.
>
> Thanks,
> Sijie
>
> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> [2]
> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
incubating-RC2/
> [3]
> https://repository.apache.org/content/repositories/
orgapachedistributedlog-1003/
> [4]
> https://repository.apache.org/content/repositories/
orgapachedistributedlog-1004/
> [5]
> https://github.com/apache/incubator-distributedlog/tree/
v0.4.0-incubating-RC1_2.11
> [6]
> https://github.com/apache/incubator-distributedlog/tree/
v0.4.0-incubating-RC1_2.10
> [7] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-12 Thread Sijie Guo 
Yeah, currently some of the tests are time dependent. So they failed
sometimes when the machine is slow. There were efforts on improving this
and will also do this in next release.

Sijie

On Jan 12, 2017 3:32 AM, "Flavio Junqueira"  wrote:

> Ok, so I've seen the following test cases showing errors:
>
> TestBKDistributedLogManager.testNumberOfTransactionsWithIn
> progressAtEnd:325
> TestAsyncReaderLock.testReaderLockDlmClosed » Cancellation
>
> They don't seem to fail consistently for me, though.
>
> -Flavio
>
> > On 10 Jan 2017, at 18:10, Sijie Guo  wrote:
> >
> > Liang had a pull request for the assembly issue. Going to cancel this
> vote
> > and produce a new RC.
> >
> > Flavio, what are the tests failed in your case?
> >
> > Sijie
> >
> > On Jan 10, 2017 9:10 AM, "Flavio Junqueira" > wrote:
> >
> > Yeah, I can't build because of the same issue:
> >
> >[ERROR] Failed to execute goal org.apache.maven.plugins:
> > maven-assembly-plugin:2.2.1:single (default) on project
> > distributedlog-service: Failed to create assembly: Error adding file to
> >archive: distributedlog-0.4.0-incubating/distributedlog-
> service/../README.md
> > isn't a file. -> [Help 1]
> >
> > The command I ran is:
> >
> >   mvn clean apache-rat:check package findbugs:check -DskipTests
> >
> > I also tried other commands, and they all seem to fail on tests.
> >
> > -Flavio
> >
> >> On 10 Jan 2017, at 07:24, Xi Liu  wrote:
> >>
> >> On Mon, Jan 9, 2017 at 8:00 PM, liang xie    > xieliang...@gmail.com>> wrote:
> >>
> >>> Glad to see 0.4 will be release soon :)
> >>> I could not find tutorials package from link[2], it should be released
> >>> as well, please correct me if i am wrong.
> >>> I can pass this command with current git master code: "mvn clean
> >>> apache-rat:check package findbugs:check -DskipTests", but failed with
> >>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> >>> dist.apache.org, the error msg:
> >>>
> >>> [ERROR] Failed to execute goal
> >>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> >>> on project distributedlog-service: Failed to create assembly: Error
> >>> adding file to archive:
> >>> /tmp/distributedlog-0.4.0-incubating/distributedlog-
> service/../README.md
> >>> isn't a file. -> [Help 1]
> >>>
> >>
> >> I also saw this issue.
> >>
> >>
> >>>
> >>> And none of you saw this : DL-181, it can be reproduced on my local
> >>> box always w/o patched,  weird...
> >>>
> >>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
>  Hi all,
> 
>  Please review and vote on the release candidate #1 for the version
> > 0.4.0,
>  as follows:
> 
>  [ ] +1, Approve the release
>  [ ] -1, Do not approve the release (please provide specific comments)
> 
>  The complete staging area is available for your review, which
> includes:
> 
>    * JIRA release notes [1],
>    * the official Apache source release to be deployed to
> >>> dist.apache.org
>  [2],
>    * all artifacts to be deployed to the Maven Central Repository [3],
>    * source code tag "v0.4.0-RC1" [4],
>    * website pull request listing the release [5] and publishing the
> API
>  reference manual.
> 
>  A simple instruction for validation the source and binary packages.
> 
>  - source package: run "*./scripts/integration/smoketest.sh*" after
> >>> building
>  the package with "*mvn clean apache-rat:check package findbugs:check
>  -DskipTests*"
> 
>  The vote will be open for at least 72 hours. It is adopted by majority
>  approval, with at least 3 PPMC affirmative votes.
> 
>  Thanks,
>  Sijie
> 
>  [1]
>  https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >>> projectId=12320620=12337980
>  [2]
>  https://dist.apache.org/repos/dist/dev/incubator/
> distributedlog/0.4.0-
> >>> incubating/
>  [3]
>  https://repository.apache.org/content/repositories/
> >>> orgapachedistributedlog-1001/
>  [4]
>  https://github.com/apache/incubator-distributedlog/tree/
> >>> v0.4.0-incubating-RC1
>  [5] https://github.com/apache/incubator-distributedlog/pull/109
>
>

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-12 Thread Flavio Junqueira 
Ok, so I've seen the following test cases showing errors:

TestBKDistributedLogManager.testNumberOfTransactionsWithInprogressAtEnd:325
TestAsyncReaderLock.testReaderLockDlmClosed » Cancellation

They don't seem to fail consistently for me, though.

-Flavio

> On 10 Jan 2017, at 18:10, Sijie Guo  wrote:
> 
> Liang had a pull request for the assembly issue. Going to cancel this vote
> and produce a new RC.
> 
> Flavio, what are the tests failed in your case?
> 
> Sijie
> 
> On Jan 10, 2017 9:10 AM, "Flavio Junqueira"  > wrote:
> 
> Yeah, I can't build because of the same issue:
> 
>[ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-assembly-plugin:2.2.1:single (default) on project
> distributedlog-service: Failed to create assembly: Error adding file to
>archive: 
> distributedlog-0.4.0-incubating/distributedlog-service/../README.md
> isn't a file. -> [Help 1]
> 
> The command I ran is:
> 
>   mvn clean apache-rat:check package findbugs:check -DskipTests
> 
> I also tried other commands, and they all seem to fail on tests.
> 
> -Flavio
> 
>> On 10 Jan 2017, at 07:24, Xi Liu  wrote:
>> 
>> On Mon, Jan 9, 2017 at 8:00 PM, liang xie >   xieliang...@gmail.com>> wrote:
>> 
>>> Glad to see 0.4 will be release soon :)
>>> I could not find tutorials package from link[2], it should be released
>>> as well, please correct me if i am wrong.
>>> I can pass this command with current git master code: "mvn clean
>>> apache-rat:check package findbugs:check -DskipTests", but failed with
>>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
>>> dist.apache.org, the error msg:
>>> 
>>> [ERROR] Failed to execute goal
>>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
>>> on project distributedlog-service: Failed to create assembly: Error
>>> adding file to archive:
>>> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
>>> isn't a file. -> [Help 1]
>>> 
>> 
>> I also saw this issue.
>> 
>> 
>>> 
>>> And none of you saw this : DL-181, it can be reproduced on my local
>>> box always w/o patched,  weird...
>>> 
>>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
 Hi all,
 
 Please review and vote on the release candidate #1 for the version
> 0.4.0,
 as follows:
 
 [ ] +1, Approve the release
 [ ] -1, Do not approve the release (please provide specific comments)
 
 The complete staging area is available for your review, which includes:
 
   * JIRA release notes [1],
   * the official Apache source release to be deployed to
>>> dist.apache.org
 [2],
   * all artifacts to be deployed to the Maven Central Repository [3],
   * source code tag "v0.4.0-RC1" [4],
   * website pull request listing the release [5] and publishing the API
 reference manual.
 
 A simple instruction for validation the source and binary packages.
 
 - source package: run "*./scripts/integration/smoketest.sh*" after
>>> building
 the package with "*mvn clean apache-rat:check package findbugs:check
 -DskipTests*"
 
 The vote will be open for at least 72 hours. It is adopted by majority
 approval, with at least 3 PPMC affirmative votes.
 
 Thanks,
 Sijie
 
 [1]
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>> projectId=12320620=12337980
 [2]
 https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
>>> incubating/
 [3]
 https://repository.apache.org/content/repositories/
>>> orgapachedistributedlog-1001/
 [4]
 https://github.com/apache/incubator-distributedlog/tree/
>>> v0.4.0-incubating-RC1
 [5] https://github.com/apache/incubator-distributedlog/pull/109