Re: [VOTE] Release 0.4.0, release candidate #1

[liang xie]

Glad to see 0.4 will be release soon :)
I could not find tutorials package from link[2], it should be released
as well, please correct me if i am wrong.
I can pass this command with current git master code: "mvn clean
apache-rat:check package findbugs:check -DskipTests", but failed with
from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
dist.apache.org, the error msg:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
on project distributedlog-service: Failed to create assembly: Error
adding file to archive:
/tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
isn't a file. -> [Help 1]

And none of you saw this : DL-181, it can be reproduced on my local
box always w/o patched,  weird...

On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> Hi all,
>
> Please review and vote on the release candidate #1 for the version 0.4.0,
> as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
>
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> * all artifacts to be deployed to the Maven Central Repository [3],
> * source code tag "v0.4.0-RC1" [4],
> * website pull request listing the release [5] and publishing the API
> reference manual.
>
> A simple instruction for validation the source and binary packages.
>
> - source package: run "*./scripts/integration/smoketest.sh*" after building
> the package with "*mvn clean apache-rat:check package findbugs:check
> -DskipTests*"
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PPMC affirmative votes.
>
> Thanks,
> Sijie
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320620=12337980
> [2]
> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-incubating/
> [3]
> https://repository.apache.org/content/repositories/orgapachedistributedlog-1001/
> [4]
> https://github.com/apache/incubator-distributedlog/tree/v0.4.0-incubating-RC1
> [5] https://github.com/apache/incubator-distributedlog/pull/109

Re: [DISCUSSION] First Release

[liang xie]

The conflicted DL-167 change has been rebased, please help to review :)

On Thu, Jan 5, 2017 at 8:53 AM, Sijie Guo  wrote:
> FYI. I merged the repackage script and repackage the namespace under
> org.apache.distributedlog. All the changes for 0.4.0 are merged (except one
> test case change - waiting for Liang's response). Ready to cut the first
> release candidate.
>
> - Sijie
>
> On Thu, Dec 29, 2016 at 8:40 PM, Sijie Guo  wrote:
>
>> I've merged all the pull requests that need to be included in 0.4.0 (and
>> both Jenkins and CI builds are green now). Also I moved inactive jiras to
>> 0.5.0.
>>
>> There are a few issues remaining - https://issues.apache.org/
>> jira/issues/?jql=project%20%3D%20DL%20AND%20resolution%20%
>> 3D%20Unresolved%20AND%20fixVersion%20%3D%200.4.0%
>> 20ORDER%20BY%20priority%20DESC
>>
>> Most of them already have pull requests (but need to be rebased to latest
>> master). So I can merge them.
>>
>> Hopefully I will be able to cut 0.4.0 release in following few days.
>>
>> - Sijie
>>
>> On Thu, Dec 8, 2016 at 9:16 PM, Sijie Guo  wrote:
>>
>>> I will start check the jiras that need to be included in 0.4.0 release at
>>> the weekend. If there is any jiras that need to be included in 0.4.0,
>>> please comment in the jira.
>>>
>>> - Sijie
>>>
>>> On Fri, Dec 2, 2016 at 8:28 PM, Sijie Guo  wrote:
>>>
 FYI.

 https://issues.apache.org/jira/browse/DL-81 is created for tracking
 building the process.

 https://issues.apache.org/jira/browse/INFRA-13024 and
 https://issues.apache.org/jira/browse/INFRA-13023 for setting the dists
 for DL.

 - Sijie

 On Fri, Dec 2, 2016 at 8:05 PM, Sijie Guo  wrote:

> Thank you for all the feedbacks. I will drive the release for this
> version. So that we can have all the procedures documented in the wiki.
>
> I created the wiki page here for documenting the procedure:
> https://cwiki.apache.org/confluence/display/DL/Pr
> eparing+DistributedLog+Releases
>
> - Sijie
>
>
> On Mon, Nov 21, 2016 at 7:10 PM, Jia Zhai  wrote:
>
>> +1
>> Great to know the commitment of merge twitter's branch. Looking
>> forward to
>> see bookkeeper 4.5.
>>
>> On Mon, Nov 21, 2016 at 6:36 PM, Flavio Junqueira 
>> wrote:
>>
>> > It does make sense, Sijie, thanks for the update.
>> >
>> > -Flavio
>> >
>> > > On 17 Nov 2016, at 05:12, Sijie Guo  wrote:
>> > >
>> > > Flavio,
>> > >
>> > > I totally agreed that not using an official Apache  version is not
>> great
>> > > for the community. We had a bookkeeper meetup last night. We've
>> discussed
>> > > the current situation with the community. We came to a commitment
>> to
>> > merge
>> > > Twitter's branch back into bookkeeper 4.5. After that we won't
>> maintain
>> > our
>> > > own branch and switch to 4.5.
>> > >
>> > > Hope this make sense.
>> > >
>> > > Sijie
>> > >
>> > > On Nov 16, 2016 8:04 PM, "Flavio Junqueira" 
>> wrote:
>> > >
>> > > It isn't great that DistributedLog is not using the Apache
>> BookKeeper
>> > > release. Essentially anyone using DistributedLog today needs to
>> use the
>> > > Twitter branch of BookKeeper, which has diverged from Apache
>> BookKeeper.
>> > > I'm sure the changes in the Twitter branch are all great, but I'd
>> be more
>> > > comfortable being able to rely on the Apache BookKeeper releases,
>> which
>> > are
>> > > community driven.
>> > >
>> > > I'm not going to block the release on this alone because it is
>> important
>> > > for this project to get a first release out soon, but we need to
>> fix
>> > DL-2.
>> > >
>> > > -Flavio
>> > >
>> > >> On 15 Nov 2016, at 19:02, Leigh Stewart
>> 
>> > > wrote:
>> > >>
>> > >> +1
>> > >>
>> > >> On Tue, Nov 15, 2016 at 7:01 PM, Franck Cuny <
>> franck.c...@gmail.com>
>> > > wrote:
>> > >>
>> > >>> +1 and I agree to not make DL-2 a blocker.
>> > >>>
>> > >>> On Tue, Nov 15, 2016 at 2:02 AM, Xi Liu 
>> wrote:
>> > >>>
>> >  +1 especially on DL-23.
>> > 
>> >  - Xi
>> > 
>> >  On Sat, Nov 12, 2016 at 2:22 AM, Khurrum Nasim <
>> > khurrumnas...@gmail.com>
>> >  wrote:
>> > 
>> > > +1 (non-binding)
>> > >
>> > > I am also interested in participating.
>> > >
>> > > - kn
>> > >
>> > > On Tue, Nov 8, 2016 at 11:08 PM, Sijie Guo 
>> wrote:
>> > >
>> > >> I'd like to start the discussion about the first release.
>> There 

[jira] [Updated] (DL-155) TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky

[Liang Xie (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Liang Xie updated DL-155:
-
Affects Version/s: 0.4.0

> TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky
> ---
>
> Key: DL-155
> URL: https://issues.apache.org/jira/browse/DL-155
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-core
>Affects Versions: 0.4.0
>    Reporter: Liang Xie
>Assignee: Liang Xie
>
> See 
> https://builds.apache.org/job/distributedlog-nightly-build/com.twitter$distributedlog-core/162/testReport/junit/com.twitter.distributedlog/TestAsyncReaderLock/testReaderLockMultiReadersScenario/
> The error  came from write path, due to extra control records be transmitted 
> sometimes, the entryId probably more than 99 which was expected in original 
> case.
> DL-151 had a similar issue and gave a solution already.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DL-145) Fix the flaky testServiceTimeout

[Liang Xie (JIRA)]

[ 
https://issues.apache.org/jira/browse/DL-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15769322#comment-15769322
 ] 

Liang Xie commented on DL-145:
--

ping [~si...@apache.org] :)

> Fix the flaky testServiceTimeout
> 
>
> Key: DL-145
> URL: https://issues.apache.org/jira/browse/DL-145
> Project: DistributedLog
>  Issue Type: Test
>  Components: distributedlog-service
>Affects Versions: 0.4.0
>    Reporter: Liang Xie
>Assignee: Liang Xie
>
> The TestDistributedLogService#testServiceTimeout case is not stable, e.g. 
> https://builds.apache.org/job/distributedlog-precommit-pullrequest/22/com.twitter$distributedlog-service/testReport/com.twitter.distributedlog.service/TestDistributedLogService/testServiceTimeout/
> It could be reproduced on my box occasionally, and the failures were stable 
> if i tuned the ServiceTimeoutMs from 200 to 150, and always passed if tuned 
> to a larger value, e.g. 1000(btw, my disk is SSD type)
> After digging into it, shows it related with starting a new log segment 
> corner case.
> For a good case, once service time out occurs, steam status : ERROR -> 
> CLOSING -> CLOSED, calling Abortables.asyncAbort will trigger the cached 
> logsegment be aborted, then writeOp will be injected an exception, e.g. write 
> cancel exception.
> For a bad case, since no log records be written before, so there'll be an 
> async start new log segment, once the timeout occurs, the segment starting 
> still not be done, so no cache, then asyncAbort has no change to abort that 
> segment.
> I think change the test timeout value to a larger one should be fine for this 
> special test corner case.
> will attach a minor patch later.  Any suggestions are welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (DL-155) TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky

[Liang Xie (JIRA)]

Liang Xie created DL-155:


 Summary: TestAsyncReaderLock#testReaderLockMultiReadersScenario is 
flaky
 Key: DL-155
 URL: https://issues.apache.org/jira/browse/DL-155
 Project: DistributedLog
  Issue Type: Bug
  Components: distributedlog-core
Reporter: Liang Xie
Assignee: Liang Xie


See 
https://builds.apache.org/job/distributedlog-nightly-build/com.twitter$distributedlog-core/162/testReport/junit/com.twitter.distributedlog/TestAsyncReaderLock/testReaderLockMultiReadersScenario/

The error  came from writh path, due to extra control records be transmitted 
sometimes, the entryId probably more than 99 which was expected in original 
case.

DL-151 had a similar issue and gave a solution already.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (DL-147) Improve DistributedLogServerTestCase

[Liang Xie (JIRA)]

Liang Xie created DL-147:


 Summary: Improve DistributedLogServerTestCase
 Key: DL-147
 URL: https://issues.apache.org/jira/browse/DL-147
 Project: DistributedLog
  Issue Type: Test
  Components: distributedlog-service
Reporter: Liang Xie


See 
https://builds.apache.org/job/distributedlog-precommit-pullrequest/38/com.twitter$distributedlog-service/testReport/

Currently, the port is hard-code:
{code}
@Before
public void setup() throws Exception {
dlServer = createDistributedLogServer(7001);
dlClient = createDistributedLogClient("test");
}
{code}

Therefore "java.net.BindException: Address already in use" will be seen under a 
not-cleaned or shared env. we should introduce a fall-back mechanism



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (DL-146) Fix Stream typo : initiaize

[Liang Xie (JIRA)]

Liang Xie created DL-146:


 Summary: Fix Stream typo : initiaize
 Key: DL-146
 URL: https://issues.apache.org/jira/browse/DL-146
 Project: DistributedLog
  Issue Type: Improvement
  Components: distributedlog-service
Reporter: Liang Xie
Assignee: Liang Xie
Priority: Minor


"moved to initiaize()" -> "moved to initialize()"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [Discuss] Transaction Support

[liang xie]

The developers upload the design doc onto JIRA at least for
HADOOP/HBase/Cassandra/... projects

On Mon, Dec 19, 2016 at 12:48 AM, Sijie Guo  wrote:
> Hi Xi,
>
> sorry for late response. I will review it soon.
>
> regarding this, a separate question "are we going to use google doc instead
> of email thread for any discussion"? I am a bit worried that the discussion
> will become lost after moving to google doc. No idea on how other apache
> projects are doing.
>
> - Sijie
>
> On Wed, Dec 14, 2016 at 11:41 PM, Xi Liu  wrote:
>
>> Hi all,
>>
>> I finalized the first version of the design. This time I used a google doc
>> so that it is easier for commenting and add a link the wiki page. I will
>> update this to the wiki page once we come to the finalized design.
>>
>> https://docs.google.com/document/d/14Ns05M8Z5a6DF6fHmWQwISyD5jjeK
>> bSIGgSzXuTI5BA/edit
>>
>> Let me know if you have any questions. Appreciate your reviews!
>>
>> - Xi
>>
>>
>>
>>
>>
>> On Fri, Oct 28, 2016 at 7:58 AM, Leigh Stewart
>> > > wrote:
>>
>> > Interesting proposal. A couple quick notes while you continue to flesh
>> this
>> > out.
>> >
>> > a. just to be sure - does this eliminate the need to save seqno with
>> > checkpoint?
>> >
>> > b. i.e. another way to describe this kind of improvement is "support
>> > records (atomic writes) larger than 1MB", iiuc. the advantage being it
>> > avoids the baggage of transactions. disadvantages include inability to do
>> > cross stream transactions, and flexibility (interleaving, etc) (are there
>> > others?).
>> >
>> > c. proxy use case is for supporting multiple writers - have you thought
>> > about how this would work with multiple writers?
>> >
>> > Thanks!
>> >
>> >
>> > On Tue, Oct 18, 2016 at 6:45 PM, Sijie Guo 
>> > wrote:
>> >
>> > > Sound good to me. look forward to the detailed proposal.
>> > >
>> > > (I don't mind the format if it makes things easier to you)
>> > >
>> > > Sijie
>> > >
>> > > On Friday, October 14, 2016, Xi Liu  wrote:
>> > >
>> > > > Thank you, Sijie
>> > > >
>> > > > We have some internal discussions to sort out some details. We are
>> > ready
>> > > to
>> > > > collaborate with the community for adding the transaction support in
>> > DL.
>> > > > We'd like to share more.
>> > > >
>> > > > I created a proposal wiki here -
>> > > > https://cwiki.apache.org/confluence/display/DL/DP-1+-+
>> > > > DistributedLog+Transaction+Support
>> > > >
>> > > > (I followed KIP format and named it as DP (DistributedLog Proposal -
>> DP
>> > > is
>> > > > also short for Dynamic Programming). I don't know if you guys like
>> this
>> > > > name or not. Feel free to change it :D)
>> > > >
>> > > > I basically put my initial email as the content there so far. Once we
>> > > > finished our final discussion, I will update with more details. At
>> the
>> > > same
>> > > > time, any comments are welcome.
>> > > >
>> > > > - Xi
>> > > >
>> > > >
>> > > >
>> > > > On Sat, Oct 8, 2016 at 6:58 AM, Sijie Guo > > > >
>> > > > wrote:
>> > > >
>> > > > > Xi,
>> > > > >
>> > > > > I just granted you the edit permission.
>> > > > >
>> > > > > - Sijie
>> > > > >
>> > > > > On Fri, Oct 7, 2016 at 10:34 AM, Xi Liu > > > > > wrote:
>> > > > >
>> > > > > > I still can not edit the wiki. Can any of the pmc members grant
>> me
>> > > the
>> > > > > > permissions?
>> > > > > >
>> > > > > > - Xi
>> > > > > >
>> > > > > > On Sat, Sep 17, 2016 at 10:35 PM, Xi Liu > > > > > wrote:
>> > > > > >
>> > > > > > > Sijie,
>> > > > > > >
>> > > > > > > I attempted to create a wiki page under that space. I found
>> that
>> > I
>> > > am
>> > > > > not
>> > > > > > > authorized with edit permission.
>> > > > > > >
>> > > > > > > Can any of the committers grant me the wiki edit permission? My
>> > > > account
>> > > > > > is
>> > > > > > > "xi.liu.ant".
>> > > > > > >
>> > > > > > > - Xi
>> > > > > > >
>> > > > > > >
>> > > > > > > On Tue, Sep 13, 2016 at 9:26 AM, Sijie Guo > > > > > wrote:
>> > > > > > >
>> > > > > > >> This sounds interesting ... I will take a closer look and give
>> > my
>> > > > > > comments
>> > > > > > >> later.
>> > > > > > >>
>> > > > > > >> At the same time, do you mind creating a wiki page to put your
>> > > idea
>> > > > > > there?
>> > > > > > >> You can add your wiki page under
>> > > > > > >> https://cwiki.apache.org/confluence/display/DL/Project+
>> > Proposals
>> > > > > > >>
>> > > > > > >> You might need to ask in the dev list to grant the wiki edit
>> > > > > permissions
>> > > > > > >> to
>> > > > > > >> you once you have a wiki account.
>> > > > > > >>
>> > > > > > >> - Sijie
>> > > > > > >>
>> > > > > > >>
>> > > > > > >> On Mon, Sep 12, 2016 at 2:20 AM, Xi Liu > > > > > wrote:
>> > > > > > >>

[jira] [Commented] (DL-145) Fix the flaky testServiceTimeout

[Liang Xie (JIRA)]

[ 
https://issues.apache.org/jira/browse/DL-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756120#comment-15756120
 ] 

Liang Xie commented on DL-145:
--

Before making a patch per [~si...@apache.org]'s comment,  i'd like to confirm 
with [~l4stewar], i noticed a pending change "Be able to close the writer 
within a timeout period", does that related with current issue? Thanks

> Fix the flaky testServiceTimeout
> 
>
> Key: DL-145
> URL: https://issues.apache.org/jira/browse/DL-145
> Project: DistributedLog
>  Issue Type: Test
>  Components: distributedlog-service
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
>
> The TestDistributedLogService#testServiceTimeout case is not stable, e.g. 
> https://builds.apache.org/job/distributedlog-precommit-pullrequest/22/com.twitter$distributedlog-service/testReport/com.twitter.distributedlog.service/TestDistributedLogService/testServiceTimeout/
> It could be reproduced on my box occasionally, and the failures were stable 
> if i tuned the ServiceTimeoutMs from 200 to 150, and always passed if tuned 
> to a larger value, e.g. 1000(btw, my disk is SSD tyle)
> After digging into it, shows it related with starting a new log segment 
> corner case.
> For a good case, once service time out occurs, steam status : ERROR -> 
> CLOSING -> CLOSED, calling Abortables.asyncAbort will trigger the cached 
> logsegment be aborted, then writeOp will be injected an exception, e.g. write 
> cancel exception.
> For a bad case, since no log records be written before, so there'll be an 
> async start new log segment, once the timeout occurs, the segment starting 
> still not be done, so no cache, then asyncAbort has no change to abort that 
> segment.
> I think change the test timeout value to a larger one should be find for this 
> special test corner case.
> will attache a minor patch later.  Any suggestions are welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (DL-145) Fix the flaky testServiceTimeout

[Liang Xie (JIRA)]

Liang Xie created DL-145:


 Summary: Fix the flaky testServiceTimeout
 Key: DL-145
 URL: https://issues.apache.org/jira/browse/DL-145
 Project: DistributedLog
  Issue Type: Test
  Components: distributedlog-service
Affects Versions: 0.4.0
Reporter: Liang Xie
Assignee: Liang Xie


The TestDistributedLogService#testServiceTimeout case is not stable, e.g. 
https://builds.apache.org/job/distributedlog-precommit-pullrequest/22/com.twitter$distributedlog-service/testReport/com.twitter.distributedlog.service/TestDistributedLogService/testServiceTimeout/

It could be reproduced on my box occasionally, and the failures were stable if 
i tuned the ServiceTimeoutMs from 200 to 150, and always passed if tuned to a 
larger value, e.g. 1000(btw, my disk is SSD tyle)

After digging into it, shows it related with starting a new log segment corner 
case.
For a good case, once service time out occurs, steam status : ERROR -> CLOSING 
-> CLOSED, calling Abortables.asyncAbort will trigger the cached logsegment be 
aborted, then writeOp will be injected an exception, e.g. write cancel 
exception.
For a bad case, since no log records be written before, so there'll be an async 
start new log segment, once the timeout occurs, the segment starting still not 
be done, so no cache, then asyncAbort has no change to abort that segment.

I think change the test timeout value to a larger one should be find for this 
special test corner case.

will attache a minor patch later.  Any suggestions are welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DL-28) generate java code failed using scrooge

[Liang Xie (JIRA)]

[ 
https://issues.apache.org/jira/browse/DL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750288#comment-15750288
 ] 

Liang Xie commented on DL-28:
-

It should be the scrooge windows platform issue, attached file is a workaround 
with "/* */" style comment.

> generate java code failed using scrooge
> ---
>
> Key: DL-28
> URL: https://issues.apache.org/jira/browse/DL-28
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-protocol
>Affects Versions: 0.4.0
> Environment: Apache Maven 3.2.5
> Maven home: C:\apache-maven-3.2.5
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: C:\Java\jdk1.8.0_60\jre
> Default locale: zh_CN, platform encoding: UTF-8
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>Reporter: weiwei
>Priority: Blocker
>  Labels: build
> Fix For: 0.4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] distributedlog . SUCCESS [  0.002 
> s]
> [INFO] DistributedLog Protocol  FAILURE [  1.081 
> s]
> [INFO] DistributedLog Core Library  SKIPPED
> [INFO] DistributedLog Client .. SKIPPED
> [INFO] DistributedLog Service . SKIPPED
> [INFO] DistributedLog Benchmark ... SKIPPED
> [INFO] DistributedLog Example . SKIPPED
> [INFO] DistributedLog Basics .. SKIPPED
> [INFO] DistributedLog Messaging Tutorial .. SKIPPED
> [INFO] DistributedLog Kafka Tutorial .. SKIPPED
> [INFO] DistributedLog MapReduce ... SKIPPED
> [INFO] DistributedLog Tutorials ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 1.321 s
> [INFO] Finished at: 2016-08-02T13:26:31+08:00
> [INFO] Final Memory: 12M/150M
> [INFO] 
> 
> [ERROR] Exception parsing: 
> E:\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift:
>  [3.1] failure: string matching regex `\z' expected but `/' found
> [ERROR] 
> [ERROR] // Response stats codes
> [ERROR] 
> [ERROR] ^
> [ERROR] -> [Help 1]
> com.twitter.scrooge.frontend.FileParseException: Exception parsing: 
> E:\isoftstone\workspacedeis\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at scala.Option.map(Option.scala:145)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parse(ThriftParser.scala:420)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parseFile(ThriftParser.scala:448)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:66)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:64)
>   at scala.collection.immutable.List.foreach(List.scala:318)
>   at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:32)
>   at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45)
>   at com.twitter.scrooge.Compiler.run(Compiler.scala:64)
>   at com.twitter.ScroogeRunner.compile(ScroogeRunner.scala:45)
>   at 
> com.twitter.AbstractMavenScroogeMojo.execute(AbstractMavenScroogeMojo.java:239)
>   at 
> com.twitter.MavenScroogeCompileMojo.execute(MavenScroogeCompileMojo.java:22)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apa

[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings

[Liang Xie (JIRA)]

[ 
https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744787#comment-15744787
 ] 

Liang Xie commented on DL-140:
--

passed "mvn test" under distributedlog-core dir on my box:
"Tests run: 486, Failures: 0, Errors: 0, Skipped: 9"

> Fix several FindBug "Inconsistent synchronization" warnings
> ---
>
> Key: DL-140
> URL: https://issues.apache.org/jira/browse/DL-140
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-core
>    Affects Versions: 0.4.0
>    Reporter: Liang Xie
>Assignee: Liang Xie
>
> Through most of findbug warnings are false alarm or trivial issues, we need 
> to fix the "Multithreaded correctness" related warning if occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings

[Liang Xie (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Liang Xie updated DL-140:
-
Summary: Fix several FindBug "Inconsistent synchronization" warnings  (was: 
Fix several "Inconsistent synchronization"s from FindBug warning)

> Fix several FindBug "Inconsistent synchronization" warnings
> ---
>
> Key: DL-140
> URL: https://issues.apache.org/jira/browse/DL-140
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-core
>    Affects Versions: 0.4.0
>    Reporter: Liang Xie
>Assignee: Liang Xie
>
> Through most of findbug warnings are false alarm or trivial issues, we need 
> to fix the "Multithreaded correctness" related warning if occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DL-135) Cleanup System.out and System.err usage

[Liang Xie (JIRA)]

[ 
https://issues.apache.org/jira/browse/DL-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744081#comment-15744081
 ] 

Liang Xie commented on DL-135:
--

A trivial patch :  https://github.com/apache/incubator-distributedlog/pull/70

> Cleanup System.out and System.err usage
> ---
>
> Key: DL-135
> URL: https://issues.apache.org/jira/browse/DL-135
> Project: DistributedLog
>  Issue Type: Task
>Reporter: Sijie Guo
>    Assignee: Liang Xie
>  Labels: help-wanted
>
> Based on the code analysis here : 
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/
> There are 272 calls to System.out and System.err usage. Most of them might 
> just come from distributedlog tool. But let's still audit the code to make 
> sure we are using System.out and System.err correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (DL-79) Add Eclipse-based Apache Formatter to DL Wiki

[Liang Xie (JIRA)]

Liang Xie created DL-79:
---

 Summary: Add Eclipse-based Apache Formatter to DL Wiki
 Key: DL-79
 URL: https://issues.apache.org/jira/browse/DL-79
 Project: DistributedLog
  Issue Type: Wish
  Components: documentation
Affects Versions: 0.4.0
Reporter: Liang Xie


>From 
>https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65867477, we 
>saw several text suggestions, it would be nice if we have a importable ide 
>formatter file like HDFS/HBase/... projects, here is a ref jira: 
>https://issues.apache.org/jira/browse/HBASE-3678



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)