[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765730#comment-15765730 ] ASF GitHub Bot commented on DL-129: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/54 > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763642#comment-15763642 ] ASF GitHub Bot commented on DL-129: --- Github user xiliuant commented on the issue: https://github.com/apache/incubator-distributedlog/pull/54 @sijie I addressed most of your comments. please let me know if you have any other comments. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763641#comment-15763641 ] ASF GitHub Bot commented on DL-129: --- Github user xiliuant commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190694 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- fixed. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763639#comment-15763639 ] ASF GitHub Bot commented on DL-129: --- Github user xiliuant commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190638 --- Diff: distributedlog-build-tools/pom.xml --- @@ -0,0 +1,30 @@ + --- End diff -- I moved the eclipse setting to the build-tools module. I will create a jira for findbugs settings. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742976#comment-15742976 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026632 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- add 'bk-shade' to avoid importing shaded bookkeeper dependencies? > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742975#comment-15742975 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026383 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- +1 for avoiding start import > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742979#comment-15742979 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026310 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- nice. sorting the imports looks really good to me. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742977#comment-15742977 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025594 --- Diff: distributedlog-build-tools/pom.xml --- @@ -0,0 +1,30 @@ + --- End diff -- I like the idea to organize the checkstyle files into a separated module so that we don't need to have configuration on each module. I think we should do the similar thing for findbugs settings. Can you move the findbug settings to builds-tool module? (It can be a separate jira and pull request). Also it might be clear to move the eclipse format settings and the merge-pr script to builds-tool module too. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[
https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742978#comment-15742978
]
ASF GitHub Bot commented on DL-129:
---
Github user sijie commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025930
--- Diff:
distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml ---
@@ -0,0 +1,443 @@
+
+
+http://www.puppycrawl.com/dtds/configuration_1_3.dtd";>
+
+
+
+
+
+
+
+
+
+
+
+
--- End diff --
it might be good to make sure there is a jira associated with TODO item?
E.g.
"TODO: {@link jira_link}"?
> Enable check style for distributedlog-protocol module
> -
>
> Key: DL-129
> URL: https://issues.apache.org/jira/browse/DL-129
> Project: DistributedLog
> Issue Type: Sub-task
> Components: distributedlog-protocol
>Reporter: Xi Liu
>Assignee: Xi Liu
> Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
