[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/970 +1, LGTM. ---
[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/970 Addressed comments. Rebased on master. Resolved merge conflicts. Squashed commits. @ilooner, @sachouche please do a quick final review to check for loose ends. ---
[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/970
@paul-rogers Will this be going in anytime soon? I'd like to fix the
annoying
```
test(String.format("alter session..."))
```
statements in the tests after this goes in.
---
[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/970 There is a funny thing about the way Drill works. I can review your changes and commit them as soon as I provide a +1. My changes must wait until another committer to find time in their very busy schedules to consider this work. So, we'll likely commit yours first, I'll rebase mine on top of it, then wait for another committer to find time to consider it. The one exception would be if a non-committer can give this PR a +1 and a committer agrees to do a bulk commit this week. ---
[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers Some of the changes I am making on top of https://github.com/apache/drill/pull/978/ as part of DRILL-5730 will likely conflict with this change. When do you think this could make it in? It would be helpful to have it merged sooner to avoid more conflicts down the line :) . ---
[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers It looks like the unit test failures were caused by an unrelated issue. My Mac sometimes create a wifi*.log file in /tmp . And the presence of the file in /tmp causes some unit tests to fail. Everything LGTM. ---
[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers Some tests are failing on my machine ``` Failed tests: TestMetadataProvider.tables:154 expected: but was: TestMetadataProvider.tablesWithTableNameFilter:219 expected: but was: TestMetadataProvider.tablesWithSystemTableFilter:191 expected: but was: TestMetadataProvider.tablesWithTableFilter:180 expected: but was: Tests in error: TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR: URISyn... TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth » UserRemote TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR: URISyntaxExcepti... TestViewSupport.infoSchemaWithView:355->BaseTestQuery.testRunAndReturn:356 » Rpc TestInfoSchemaFilterPushDown.testFilterPushdown_NonEqual » UserRemote SYSTEM E... TestParquetScan.testSuccessFile:60->BaseTestQuery.testRunAndReturn:356 » Rpc o... TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestSchemaChange.org.apache.drill.TestSchemaChange » Rpc CONNECTION : java.net... TestSchemaChange>DrillTest.finiDrillTest:106 » Interrupted sleep interrupted TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestSelectivity.org.apache.drill.TestSelectivity » Rpc CONNECTION : java.net.N... TestSelectivity>DrillTest.finiDrillTest:106 » Interrupted sleep interrupted TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestSelectWithOption.org.apache.drill.TestSelectWithOption » Rpc CONNECTION : ... TestSelectWithOption>DrillTest.finiDrillTest:106 » Interrupted sleep interrupt... TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166 » Runtime TestDynamicUDFSupport>DrillTest.finiDrillTest:106 » Interrupted sleep interrup... TestTpchDistributed.tpch14 » User CONNECTION ERROR: Connection /192.168.0.80:4... TestTpchDistributed.tpch15:104->testDistributed:28->BaseTestQuery.test:402 » User TestTpchDistributed.tpch16:109->testDistributed:28->BaseTestQuery.test:402 » User TestTpchDistributed.tpch17:114->testDistributed:28->BaseTestQuery.test:402 » User TestTpchDistributed.tpch18:119->testDistributed:28->BaseTestQuery.test:402 » User TestTpchDistributed.tpch20:135->testDistributed:28->BaseTestQuery.test:402 » User TestTpchDistributed.tpch19_1:130->testDistributed:28->BaseTestQuery.test:402 » User TestTpchDistributedConcurrent.testConcurrentQueries:195 » ConcurrentModification Tests run: 2335, Failures: 4, Errors: 29, Skipped: 138 ``` Otherwise option related changes LGTM ---
[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/970 @ilooner, please review the option-related changes. @sachouche, can you review the Parquet parts? ---
