Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/#review83024 --- Ship it! Ship It! - Mehant Baid On May 8, 2015, 4:55 p.m., abdelhakim deneche wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33897/ > --- > > (Updated May 8, 2015, 4:55 p.m.) > > > Review request for drill and Jason Altekruse. > > > Bugs: DRILL-2602 > https://issues.apache.org/jira/browse/DRILL-2602 > > > Repository: drill-git > > > Description > --- > > updated both ExternalSortBatch and StreamAggBatch to throw a proper > UNSUPPORTED user exception. > Here is the output when using a Stream aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support > sorts with changing schemas > > Fragment 0:0 > > [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] > ``` > And here is the error message for a hash aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support > schema changes > > Fragment 0:0 > > [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] > ``` > > > Diffs > - > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java > b753574 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java > c1c5cb9 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > e88bc67 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java > 75892f9 > > Diff: https://reviews.apache.org/r/33897/diff/ > > > Testing > --- > > all unit tests are passing along with customer/tpch100 > > > Thanks, > > abdelhakim deneche > >
Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/ --- (Updated May 8, 2015, 4:55 p.m.) Review request for drill and Jason Altekruse. Changes --- updated StreamingAggBatch to throw an UNSUPPORTED_OPERATION User Exception Bugs: DRILL-2602 https://issues.apache.org/jira/browse/DRILL-2602 Repository: drill-git Description --- updated both ExternalSortBatch and StreamAggBatch to throw a proper UNSUPPORTED user exception. Here is the output when using a Stream aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support sorts with changing schemas Fragment 0:0 [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] ``` And here is the error message for a hash aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support schema changes Fragment 0:0 [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] ``` Diffs (updated) - exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java b753574 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java c1c5cb9 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java e88bc67 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java 75892f9 Diff: https://reviews.apache.org/r/33897/diff/ Testing --- all unit tests are passing along with customer/tpch100 Thanks, abdelhakim deneche
Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
> On May 7, 2015, 5:49 p.m., Mehant Baid wrote: > > StreamingAggBatch also needs to be changed to raise a UserException instead > > of SchemaChangeException like the change you have made in HashAggBatch. > > That will occur when we have a straight aggregate without grouping. will fix this. Thanks! - abdelhakim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/#review82852 --- On May 7, 2015, 11:44 a.m., abdelhakim deneche wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33897/ > --- > > (Updated May 7, 2015, 11:44 a.m.) > > > Review request for drill and Jason Altekruse. > > > Bugs: DRILL-2602 > https://issues.apache.org/jira/browse/DRILL-2602 > > > Repository: drill-git > > > Description > --- > > updated both ExternalSortBatch and StreamAggBatch to throw a proper > UNSUPPORTED user exception. > Here is the output when using a Stream aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support > sorts with changing schemas > > Fragment 0:0 > > [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] > ``` > And here is the error message for a hash aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support > schema changes > > Fragment 0:0 > > [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] > ``` > > > Diffs > - > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java > b753574 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > e88bc67 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java > 75892f9 > > Diff: https://reviews.apache.org/r/33897/diff/ > > > Testing > --- > > all unit tests are passing along with customer/tpch100 > > > Thanks, > > abdelhakim deneche > >
Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/#review82852 --- StreamingAggBatch also needs to be changed to raise a UserException instead of SchemaChangeException like the change you have made in HashAggBatch. That will occur when we have a straight aggregate without grouping. - Mehant Baid On May 7, 2015, 11:44 a.m., abdelhakim deneche wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33897/ > --- > > (Updated May 7, 2015, 11:44 a.m.) > > > Review request for drill and Jason Altekruse. > > > Bugs: DRILL-2602 > https://issues.apache.org/jira/browse/DRILL-2602 > > > Repository: drill-git > > > Description > --- > > updated both ExternalSortBatch and StreamAggBatch to throw a proper > UNSUPPORTED user exception. > Here is the output when using a Stream aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support > sorts with changing schemas > > Fragment 0:0 > > [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] > ``` > And here is the error message for a hash aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support > schema changes > > Fragment 0:0 > > [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] > ``` > > > Diffs > - > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java > b753574 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > e88bc67 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java > 75892f9 > > Diff: https://reviews.apache.org/r/33897/diff/ > > > Testing > --- > > all unit tests are passing along with customer/tpch100 > > > Thanks, > > abdelhakim deneche > >
Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/#review82847 --- Ship it! Ship It! - Jason Altekruse On May 7, 2015, 11:44 a.m., abdelhakim deneche wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33897/ > --- > > (Updated May 7, 2015, 11:44 a.m.) > > > Review request for drill and Jason Altekruse. > > > Bugs: DRILL-2602 > https://issues.apache.org/jira/browse/DRILL-2602 > > > Repository: drill-git > > > Description > --- > > updated both ExternalSortBatch and StreamAggBatch to throw a proper > UNSUPPORTED user exception. > Here is the output when using a Stream aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support > sorts with changing schemas > > Fragment 0:0 > > [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] > ``` > And here is the error message for a hash aggregate: > ``` > Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support > schema changes > > Fragment 0:0 > > [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] > ``` > > > Diffs > - > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java > b753574 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > e88bc67 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java > 75892f9 > > Diff: https://reviews.apache.org/r/33897/diff/ > > > Testing > --- > > all unit tests are passing along with customer/tpch100 > > > Thanks, > > abdelhakim deneche > >
Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/ --- (Updated May 7, 2015, 11:44 a.m.) Review request for drill and Jason Altekruse. Bugs: DRILL-2602 https://issues.apache.org/jira/browse/DRILL-2602 Repository: drill-git Description --- updated both ExternalSortBatch and StreamAggBatch to throw a proper UNSUPPORTED user exception. Here is the output when using a Stream aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support sorts with changing schemas Fragment 0:0 [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] ``` And here is the error message for a hash aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support schema changes Fragment 0:0 [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] ``` Diffs - exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java b753574 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java e88bc67 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java 75892f9 Diff: https://reviews.apache.org/r/33897/diff/ Testing (updated) --- all unit tests are passing along with customer/tpch100 Thanks, abdelhakim deneche
Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/ --- (Updated May 6, 2015, 9:44 p.m.) Review request for drill and Jason Altekruse. Changes --- fixed patch: contained 2 separate commits rebased on top of master Bugs: DRILL-2602 https://issues.apache.org/jira/browse/DRILL-2602 Repository: drill-git Description --- updated both ExternalSortBatch and StreamAggBatch to throw a proper UNSUPPORTED user exception. Here is the output when using a Stream aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support sorts with changing schemas Fragment 0:0 [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] ``` And here is the error message for a hash aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support schema changes Fragment 0:0 [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] ``` Diffs (updated) - exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java b753574 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java e88bc67 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java 75892f9 Diff: https://reviews.apache.org/r/33897/diff/ Testing (updated) --- pending results of unit/regression tests Thanks, abdelhakim deneche
Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33897/ --- Review request for drill and Jason Altekruse. Bugs: DRILL-2602 https://issues.apache.org/jira/browse/DRILL-2602 Repository: drill-git Description --- updated both ExternalSortBatch and StreamAggBatch to throw a proper UNSUPPORTED user exception. Here is the output when using a Stream aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support sorts with changing schemas Fragment 0:0 [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010] ``` And here is the error message for a hash aggregate: ``` Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support schema changes Fragment 0:0 [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010] ``` Diffs - common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 4da4ee8 common/src/main/java/org/apache/drill/common/exceptions/UserException.java 9283339 common/src/test/java/org/apache/drill/common/exceptions/TestUserException.java a145f95 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java b753574 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java e88bc67 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java 75892f9 Diff: https://reviews.apache.org/r/33897/diff/ Testing --- all unit tests are passing along with functional/tpch100 Thanks, abdelhakim deneche
