Re: raised PR

2019-01-15 Thread Ian Luo
For PR#3093, I have the different opinion. I think this issue can be solved
as simple as catching 'NumberFormatException'.

Thanks,
-Ian.

On Tue, Jan 15, 2019 at 5:45 PM 华 钟明  wrote:

> Hi all:
> The following pr I modified, please review them
> https://github.com/apache/incubator-dubbo/pull/3230
> https://github.com/apache/incubator-dubbo/pull/3043
> https://github.com/apache/incubator-dubbo/pull/3003
> https://github.com/apache/incubator-dubbo/pull/3170
> https://github.com/apache/incubator-dubbo/pull/3093
>
> Best Regards!
> Zhongming Hua
>
>
>


Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 0.2.1 and 0.1.2 [RC2]

2019-01-15 Thread Huxing Zhang
Hi,

+1 to release.

I checked both 0.2.1 and 0.1.2 release:

- incubating in name
- disclaimer exist
- NOTICE and LICENSE exist, I saw NOTICE file included netty, but
actually it is not included, right? I think we can remove it next
time.
- sha512 checksum ok
- signatures are good.
- UT passed on Java 8
- META-INF directory contains NOTICE and LICENSE files in binary release.
- Compared source release zip file and git tag 0.2.1, only the
following files are different (in git tag 0.2.1 but not in source
release):
.git
.gitignore
.mvn
mvnw
mvnw.cmd
So I guess it is safe to go ahead.

On Tue, Jan 15, 2019 at 2:54 PM Mercy Ma  wrote:
>
> Hello Dubbo Community,
>
> This is a call for the vote to release Apache Dubbo Spring Boot Project
> (Incubating) versions 0.2.1(Spring Boot 2.x) and 0.1.2(Spring Boot 1.x).
>
> The release candidates:
> 0.2.1:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.2.1/
> 0.1.2:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.1.2/
>
> Git tag for the release:
> 0.2.1:
> https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.2.1-release
> 0.1.2:
> https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.1.2-release
>
> Hash for the release tag:
> 0.2.1: 79e9fa899b74324a8e83d00aac10e3d899b8c3f8
> 0.1.2: cb66ba32400986609f9e00b0d160173e7b2f55d2
>
> Release Notes:
> 0.2.1:
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.2.1
> 0.1.2:
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.1.2
>
> The artifacts have been signed with Key: 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team



-- 
Best Regards!
Huxing


Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 0.2.1 and 0.1.2 [RC2]

2019-01-15 Thread Ian Luo
+1 to approve.

I checked:

- signatures and hashes are good
- Can compile from source and unit tests pass
- DISCLAIMER exists, LICENSE and NOTICE exists
- All files and no binary files exist
- All files has standard ASF License header

-Ian.


On Tue, Jan 15, 2019 at 2:54 PM Mercy Ma  wrote:

> Hello Dubbo Community,
>
> This is a call for the vote to release Apache Dubbo Spring Boot Project
> (Incubating) versions 0.2.1(Spring Boot 2.x) and 0.1.2(Spring Boot 1.x).
>
> The release candidates:
> 0.2.1:
>
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.2.1/
> 0.1.2:
>
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.1.2/
>
> Git tag for the release:
> 0.2.1:
>
> https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.2.1-release
> 0.1.2:
>
> https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.1.2-release
>
> Hash for the release tag:
> 0.2.1: 79e9fa899b74324a8e83d00aac10e3d899b8c3f8
> 0.1.2: cb66ba32400986609f9e00b0d160173e7b2f55d2
>
> Release Notes:
> 0.2.1:
>
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.2.1
> 0.1.2:
>
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.1.2
>
> The artifacts have been signed with Key: 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
>


Re: raised PR

2019-01-15 Thread Ian Luo
merged PR#3170.

On Tue, Jan 15, 2019 at 5:45 PM 华 钟明  wrote:

> Hi all:
> The following pr I modified, please review them
> https://github.com/apache/incubator-dubbo/pull/3230
> https://github.com/apache/incubator-dubbo/pull/3043
> https://github.com/apache/incubator-dubbo/pull/3003
> https://github.com/apache/incubator-dubbo/pull/3170
> https://github.com/apache/incubator-dubbo/pull/3093
>
> Best Regards!
> Zhongming Hua
>
>
>


Re: raised PR

2019-01-15 Thread Ian Luo
good job on PR#3230, merged.

Thanks,
-Ian.

On Tue, Jan 15, 2019 at 5:45 PM 华 钟明  wrote:

> Hi all:
> The following pr I modified, please review them
> https://github.com/apache/incubator-dubbo/pull/3230
> https://github.com/apache/incubator-dubbo/pull/3043
> https://github.com/apache/incubator-dubbo/pull/3003
> https://github.com/apache/incubator-dubbo/pull/3170
> https://github.com/apache/incubator-dubbo/pull/3093
>
> Best Regards!
> Zhongming Hua
>
>
>


Re: raised PR

2019-01-15 Thread 华 钟明
Thank you for your review ,
I will do it.


在 2019/1/16 下午3:01,“Ian Luo” 写入:

I merged PR#3043, but here's one more thing [1] I'd like you to follow up.
I think we should do the same logic for response too.

Thanks,
-Ian.

1. https://github.com/apache/incubator-dubbo/issues/3244


On Tue, Jan 15, 2019 at 5:45 PM 华 钟明  wrote:

> Hi all:
> The following pr I modified, please review them
> https://github.com/apache/incubator-dubbo/pull/3230
> https://github.com/apache/incubator-dubbo/pull/3043
> https://github.com/apache/incubator-dubbo/pull/3003
> https://github.com/apache/incubator-dubbo/pull/3170
> https://github.com/apache/incubator-dubbo/pull/3093
>
> Best Regards!
> Zhongming Hua
>
>
>



Re: raised PR

2019-01-15 Thread Ian Luo
I merged PR#3043, but here's one more thing [1] I'd like you to follow up.
I think we should do the same logic for response too.

Thanks,
-Ian.

1. https://github.com/apache/incubator-dubbo/issues/3244


On Tue, Jan 15, 2019 at 5:45 PM 华 钟明  wrote:

> Hi all:
> The following pr I modified, please review them
> https://github.com/apache/incubator-dubbo/pull/3230
> https://github.com/apache/incubator-dubbo/pull/3043
> https://github.com/apache/incubator-dubbo/pull/3003
> https://github.com/apache/incubator-dubbo/pull/3170
> https://github.com/apache/incubator-dubbo/pull/3093
>
> Best Regards!
> Zhongming Hua
>
>
>


Re: raised PR

2019-01-15 Thread Ian Luo
Sorry for the slow response on pull request. I am on it.

-Ian.

On Tue, Jan 15, 2019 at 5:45 PM 华 钟明  wrote:

> Hi all:
> The following pr I modified, please review them
> https://github.com/apache/incubator-dubbo/pull/3230
> https://github.com/apache/incubator-dubbo/pull/3043
> https://github.com/apache/incubator-dubbo/pull/3003
> https://github.com/apache/incubator-dubbo/pull/3170
> https://github.com/apache/incubator-dubbo/pull/3093
>
> Best Regards!
> Zhongming Hua
>
>
>


Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-15 Thread Ian Luo
We should not shade gson binaries into dubbo all in one jar file, even
though there's no license issue. It is simply we should not do this,
instead, we should make sure dubbo all in one jar should have a transitive
dependency to gson library.

I noticed it's caused by'com.google.code.gson:gson' in
dubbo-all/pom.xml. We should fix it.

Thanks,
-Ian.


On Tue, Jan 15, 2019 at 5:16 PM jun liu  wrote:

> I noticed that a third-party source code ‘com.google 
> .gson.*’
> has been compiled into the convenient maven binary jar of 2.7.0 -
> dubbo-2.7.0.jar :
> 
> .
> ├── META-INF
> │   ├── DEPENDENCIES
> │   ├── LICENSE
> │   ├── MANIFEST.MF
> │   ├── NOTICE
> │   ├── assembly
> │   │   └── bin
> │   ├── compat
> │   │   └── dubbo.xsd
> │   ├── dubbo
> │   │   └── internal
> │   ├── dubbo.xsd
> │   ├── maven
> │   │   ├── com.alibaba
> │   │   ├── com.google.code.gson
> │   │   └── org.apache.dubbo
> │   ├── spring.handlers
> │   └── spring.schemas
> ├── com
> │   ├── alibaba
> │   │   ├── com
> │   │   └── dubbo
> │   └── google
> │   └── gson
> └── org
> └── apache
> └── dubbo
>
>
> Since this binary jar (dubbo-2.7.0.jar) will be included in the Apache
> Binary Release, should we update the LICENSE or NOTICE file in the Binary
> Release to announce the existence of these binary files?
>
> BTW, ‘com.google .gson’ is declared to be unde Apache
> License 2.0.
>
> You can directly download the latest SNAPSHOT release of 2.7.0-SNAPSHOT in
> here[1] and unzip and check the contents to better understand what I am
> trying to describe here.
>
> 1.
> https://repository.apache.org/content/repositories/snapshots/org/apache/dubbo/dubbo/2.7.0-SNAPSHOT/
>
> Jun
>
> > On Jan 13, 2019, at 5:58 PM, Huxing Zhang  wrote:
> >
> > Hi Jun,
> >
> > Could you summarize the current status of the 2.7-release branch?
> > I see there are still several enhancement on this branch.
> >
> > As this is the first time to prepare for a release for me, I am trying
> > to walk through the release steps[1].
> > I might try to deploy snapshot to maven repository.
> >
> > Once we feel it is ready to do the release, I will start the formal
> > release process.
> >
> >
> > [1] http://dubbo.apache.org/en-us/blog/prepare-an-apache-release.html
> >
> >
> > --
> > Best Regards!
> > Huxing
> >
> > On Mon, Jan 7, 2019 at 1:48 PM jun liu  wrote:
> >>
> 
>  Nice work!
> 
>  I think we should let the community to participate more in the release
>  process, for example,
>  1. check out a release branch called 2.7.0-release
>  2. encourage people to check it out, test it and report if there is
>  any regressions, bugs or issues.
>  3. while we are doing the test, we can start going through the ASF
>  release process locally, once we think it is ready to start a formal
>  release note, it can be done very quickly.
> 
>  By the way, we need decide the release manager of 2.7.0 release. Is
>  there anyone who volunteer to do that?
> >>
> >> Sorry, I missed this mail.
> >> * 2.7.0-release has been created
> >> * we've froze the codebase, test is underway.
> >>
> >>> I'd like to be the release manager if no one is claiming it.
> >>
> >> Great, I can help you with the source/binary packaging and tagging
> things.
> >>
> >> Jun
> >>
> >>> On Jan 5, 2019, at 12:11 PM, Huxing Zhang  wrote:
> >>>
> >>> Hi,
> >>>
> >>> On Fri, Dec 28, 2018 at 10:45 AM Huxing Zhang 
> wrote:
> 
>  Nice work!
> 
>  I think we should let the community to participate more in the release
>  process, for example,
>  1. check out a release branch called 2.7.0-release
>  2. encourage people to check it out, test it and report if there is
>  any regressions, bugs or issues.
>  3. while we are doing the test, we can start going through the ASF
>  release process locally, once we think it is ready to start a formal
>  release note, it can be done very quickly.
> 
>  By the way, we need decide the release manager of 2.7.0 release. Is
>  there anyone who volunteer to do that?
> >>>
> >>> I'd like to be the release manager if no one is claiming it.
> 
>  On Thu, Dec 27, 2018 at 11:53 PM jun liu  wrote:
> >
> > Hi, All
> >
> > I am writing this mail to
> >
> > * Keep you refreshed of the latest status about v2.7.0.
> > * Call for efforts on code review and tests
> > * Discuss possible release schedules of v2.7.0.
> >
> > About v2.7, it’s going to be a milestone version, in which will make
> some significant changes. Most importantly, we will complete all IP
> Clearance related works. Technically speaking, it’s from this version on
> that a Dubbo release starts fully follows the Apache rules (lawfully),
> totally independent from any other third-party organizations or companies.
> Secondly, this version will include many new features that have received
> wide attention from the community, by 

Re: Any plans for 服务测试?

2019-01-15 Thread Minxuan Zhuang
Thank you for your interesting, this feature is under development, you can
have a try in service-test branch:
https://github.com/apache/incubator-dubbo-ops/tree/service-test.
Service test is implemented by a generic invoke from Dubbo OPS to existing
service provider, the type and schema comes from service metadata, which is
a new feature in dubbo 2.7.
No plan to support PB testing yet

On Wed, Jan 16, 2019 at 2:16 PM 海洋  wrote:

> Hi,
>
> I've seen 服务测试 menu in the Dubbo OPS. I'm interesting about that, do we
> have any plans for that?
>
> 1. When will testing feature be released?
> 2. Will testing be invoked by generic? If so, where will the request types
> and schema comes from? Will we going to auto collect that, or relies on the
> users input?
> 3. Will we going to support PB testing? It's convenient for users that all
> kinds of testing in one platform. We are sure that PB object can support
> this scenario, but users have to upload the interface package. Not sure
> whether PB schema can helps that.
>
>
>
>
>


Any plans for 服务测试?

2019-01-15 Thread 海洋
Hi,


I've seen 服务测试 menu in the Dubbo OPS. I'm interesting about that, do we have 
any plans for that? 


1. When will testing feature be released?
2. Will testing be invoked by generic? If so, where will the request types and 
schema comes from? Will we going to auto collect that, or relies on the users 
input?
3. Will we going to support PB testing? It's convenient for users that all 
kinds of testing in one platform. We are sure that PB object can support this 
scenario, but users have to upload the interface package. Not sure whether PB 
schema can helps that.



Re: Fw:[WeeklyReport] Weekly report for Collabobot 2019-1-8 to 2019-1-15

2019-01-15 Thread Huxing Zhang
Hi,

On Tue, Jan 15, 2019 at 4:58 PM Frank Zhao  wrote:
>
> Hi all,
>
> Is this kind of weekly report email format OK? I think rendered format is 
> more readable than this.

Can you try to send the html format directly from the bot to dev list?
If not, I am ok with this format.

>
>
> Frank
>
>  Forwarding messages 
> From: "Frank Zhao" 
> Date: 2019-01-15 16:30:53
> To:  syzhao1...@126.com
> Subject: [WeeklyReport] Weekly report for Collabobot 2019-1-8 to 2019-1-15
> # Weekly Report of Collabobot
>
> This is a weekly report of Collabobot. It summarizes what have changed in the 
> project during the passed week, including pr merged, new contributors, and 
> more things in the future.
> It is all done by @collabobot which is a collaborate robot.
>
>
> ## Repo Overview
>
> ### Basic data
>
> Baisc data shows how the watch, star, fork and contributors count changed in 
> the passed week.
>
> | Watch | Star | Fork | Contributors |
> |:-:|::|::|::|
> | 1 | 11 (↑11) | 3 (↑3) | 1 (↑1) |
>
> ### Issues & PRs
>
> Issues & PRs show the new/closed issues/pull requests count in the passed 
> week.
>
> | New Issues | Closed Issues | New PR | Merged PR |
> |:--:|:-:|:--:|:-:|
> | 10 | 8 | 25 | 25 |
>
> ## PR Overview
>
> Thanks to contributions from community, Collabobot team merged **25** pull 
> requests in the repository last week. They are:
>
> * typo fix ([#35](https://github.com/AlibabaDR/Collabobot/pull/35))
> * Add custom config template 
> ([#34](https://github.com/AlibabaDR/Collabobot/pull/34))
> * Add auto close last weekly report function 
> ([#33](https://github.com/AlibabaDR/Collabobot/pull/33))
> * Change issue translation into comment format. 
> ([#32](https://github.com/AlibabaDR/Collabobot/pull/32))
> * README update ([#31](https://github.com/AlibabaDR/Collabobot/pull/31))
> * Add dingTalk notify service and and dingTalk weekly notify 
> ([#29](https://github.com/AlibabaDR/Collabobot/pull/29))
> * Add mail service and send mail service while generating weekly report 
> ([#28](https://github.com/AlibabaDR/Collabobot/pull/28))
> * Modify weekly report template. 
> ([#27](https://github.com/AlibabaDR/Collabobot/pull/27))
> * translator config update 
> ([#26](https://github.com/AlibabaDR/Collabobot/pull/26))
> * Update issue template 
> ([#24](https://github.com/AlibabaDR/Collabobot/pull/24))
> * ignore weeklyreport and notice issue, not translate. 
> ([#22](https://github.com/AlibabaDR/Collabobot/pull/22))
> * fix translator error 
> ([#21](https://github.com/AlibabaDR/Collabobot/pull/21))
> * update translator config 
> ([#20](https://github.com/AlibabaDR/Collabobot/pull/20))
> * fix translation error 
> ([#18](https://github.com/AlibabaDR/Collabobot/pull/18))
> * For translation concern, check label after edit 
> ([#17](https://github.com/AlibabaDR/Collabobot/pull/17))
> * update question keywords 
> ([#16](https://github.com/AlibabaDR/Collabobot/pull/16))
> * typo fix ([#15](https://github.com/AlibabaDR/Collabobot/pull/15))
> * bug report template fix 
> ([#13](https://github.com/AlibabaDR/Collabobot/pull/13))
> * [feature] Use optional tokens to fetch data to avoid abuse detection 
> ([#12](https://github.com/AlibabaDR/Collabobot/pull/12))
> * Check chinese char in issue translator 
> ([#11](https://github.com/AlibabaDR/Collabobot/pull/11))
> * Hide token & label update & tranlator fix 
> ([#9](https://github.com/AlibabaDR/Collabobot/pull/9))
> * Make custom config file path can be passed by command line. 
> ([#6](https://github.com/AlibabaDR/Collabobot/pull/6))
> * Issue auto label added. 
> ([#3](https://github.com/AlibabaDR/Collabobot/pull/3))
> * add label setup component and related files. 
> ([#2](https://github.com/AlibabaDR/Collabobot/pull/2))
> * first commit ([#1](https://github.com/AlibabaDR/Collabobot/pull/1))
>
>
> ## Code Review Statistics
>
> Collabobot encourages everyone to participant in code review, in order to 
> improve software quality. Every week @collabobot would automatically help to 
> count pull request reviews of single github user as the following. So, try to 
> help review code in this project.
>
> | Contributor ID | Pull Request Reviews |
> |:--:|::|
> | @Frankzhaopku | 19 |
>
>
> ## Contributors Overview
>
> It is Collabobot team's great honor to have new contributors from community. 
> We really appreciate your contributions. Feel free to tell us if you have any 
> opinion and please share this open source project with more people if you 
> could. If you hope to be a contributor as well, please start from 
> https://github.com/AlibabaDR/Collabobot/blob/master/CONTRIBUTING.md .
> Here is the list of new contributors:
>
> @Frankzhaopku
>
> Thanks to you all.
>
> *Note: This robot is supported by 
> [Collabobot](https://github.com/AlibabaDR/Collabobot).*



-- 
Best Regards!
Huxing


Re: Issues raised for tomcat servered HTTP Dubbo service

2019-01-15 Thread jun liu
Thanks for the help from Huxing, I just find the answer, simply put is:
We need to set one system property to tell Tomcat to interrupt the main process 
when the connector fails to init: 
‘org.apache.catalina.startup.EXIT_ON_INIT_FAILURE’, this should be done in 
TomcatHttpServer.java in Dubbo.

Jun

> On Jan 15, 2019, at 5:55 PM, jun liu  wrote:
> 
> Hi, all
> 
> Here is the Github issue: 
> https://github.com/apache/incubator-dubbo/issues/3236
> 
> I developed one HTTP service using Dubbo. I tried to start two provider 
> processes on the same machine with the same port. The second provider process 
> failed because of port conflict which is an expected behaviour. What confused 
> me is that the conflict error did not interrupt the exporting process of 
> Dubbo, the HTTP service URL was successfully registered to the Registry, no 
> doubt any Consumer that find and try to consume this URL would fail. So we 
> should find the reason why we are not interrupted by tomcat socket binding 
> error:
>  
>   try
>  {
> tomcat
> .
> start();
> } 
> catch (LifecycleException
>  e) {
> 
> throw new IllegalStateException("Failed to start tomcat server at " + url.
> getAddress(), e);
> } 
> catch (Exception
>  ee) {
> 
> throw new IllegalStateException
> (e);
> }
> 
> 
> 
> Jun
> 



Issues raised for tomcat servered HTTP Dubbo service

2019-01-15 Thread jun liu
Hi, all

Here is the Github issue: https://github.com/apache/incubator-dubbo/issues/3236

I developed one HTTP service using Dubbo. I tried to start two provider 
processes on the same machine with the same port. The second provider process 
failed because of port conflict which is an expected behaviour. What confused 
me is that the conflict error did not interrupt the exporting process of Dubbo, 
the HTTP service URL was successfully registered to the Registry, no doubt any 
Consumer that find and try to consume this URL would fail. So we should find 
the reason why we are not interrupted by tomcat socket binding error:
 
  try {
tomcat.start();
} catch (LifecycleException e) {
throw new IllegalStateException("Failed to start tomcat server at " 
+ url.getAddress(), e);
} catch (Exception ee) {
throw new IllegalStateException(e);
}


Jun



raised PR

2019-01-15 Thread 华 钟明
Hi all:
The following pr I modified, please review them
https://github.com/apache/incubator-dubbo/pull/3230
https://github.com/apache/incubator-dubbo/pull/3043
https://github.com/apache/incubator-dubbo/pull/3003
https://github.com/apache/incubator-dubbo/pull/3170
https://github.com/apache/incubator-dubbo/pull/3093

Best Regards!
Zhongming Hua




Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-15 Thread jun liu
I noticed that a third-party source code ‘com.google 
.gson.*’ has been compiled into the convenient maven binary 
jar of 2.7.0 - dubbo-2.7.0.jar :

.
├── META-INF
│   ├── DEPENDENCIES
│   ├── LICENSE
│   ├── MANIFEST.MF
│   ├── NOTICE
│   ├── assembly
│   │   └── bin
│   ├── compat
│   │   └── dubbo.xsd
│   ├── dubbo
│   │   └── internal
│   ├── dubbo.xsd
│   ├── maven
│   │   ├── com.alibaba
│   │   ├── com.google.code.gson
│   │   └── org.apache.dubbo
│   ├── spring.handlers
│   └── spring.schemas
├── com
│   ├── alibaba
│   │   ├── com
│   │   └── dubbo
│   └── google
│   └── gson
└── org
└── apache
└── dubbo


Since this binary jar (dubbo-2.7.0.jar) will be included in the Apache Binary 
Release, should we update the LICENSE or NOTICE file in the Binary Release to 
announce the existence of these binary files?

BTW, ‘com.google .gson’ is declared to be unde Apache 
License 2.0.

You can directly download the latest SNAPSHOT release of 2.7.0-SNAPSHOT in 
here[1] and unzip and check the contents to better understand what I am trying 
to describe here.

1. 
https://repository.apache.org/content/repositories/snapshots/org/apache/dubbo/dubbo/2.7.0-SNAPSHOT/

Jun

> On Jan 13, 2019, at 5:58 PM, Huxing Zhang  wrote:
> 
> Hi Jun,
> 
> Could you summarize the current status of the 2.7-release branch?
> I see there are still several enhancement on this branch.
> 
> As this is the first time to prepare for a release for me, I am trying
> to walk through the release steps[1].
> I might try to deploy snapshot to maven repository.
> 
> Once we feel it is ready to do the release, I will start the formal
> release process.
> 
> 
> [1] http://dubbo.apache.org/en-us/blog/prepare-an-apache-release.html
> 
> 
> -- 
> Best Regards!
> Huxing
> 
> On Mon, Jan 7, 2019 at 1:48 PM jun liu  wrote:
>> 
 
 Nice work!
 
 I think we should let the community to participate more in the release
 process, for example,
 1. check out a release branch called 2.7.0-release
 2. encourage people to check it out, test it and report if there is
 any regressions, bugs or issues.
 3. while we are doing the test, we can start going through the ASF
 release process locally, once we think it is ready to start a formal
 release note, it can be done very quickly.
 
 By the way, we need decide the release manager of 2.7.0 release. Is
 there anyone who volunteer to do that?
>> 
>> Sorry, I missed this mail.
>> * 2.7.0-release has been created
>> * we've froze the codebase, test is underway.
>> 
>>> I'd like to be the release manager if no one is claiming it.
>> 
>> Great, I can help you with the source/binary packaging and tagging things.
>> 
>> Jun
>> 
>>> On Jan 5, 2019, at 12:11 PM, Huxing Zhang  wrote:
>>> 
>>> Hi,
>>> 
>>> On Fri, Dec 28, 2018 at 10:45 AM Huxing Zhang  wrote:
 
 Nice work!
 
 I think we should let the community to participate more in the release
 process, for example,
 1. check out a release branch called 2.7.0-release
 2. encourage people to check it out, test it and report if there is
 any regressions, bugs or issues.
 3. while we are doing the test, we can start going through the ASF
 release process locally, once we think it is ready to start a formal
 release note, it can be done very quickly.
 
 By the way, we need decide the release manager of 2.7.0 release. Is
 there anyone who volunteer to do that?
>>> 
>>> I'd like to be the release manager if no one is claiming it.
 
 On Thu, Dec 27, 2018 at 11:53 PM jun liu  wrote:
> 
> Hi, All
> 
> I am writing this mail to
> 
> * Keep you refreshed of the latest status about v2.7.0.
> * Call for efforts on code review and tests
> * Discuss possible release schedules of v2.7.0.
> 
> About v2.7, it’s going to be a milestone version, in which will make some 
> significant changes. Most importantly, we will complete all IP Clearance 
> related works. Technically speaking, it’s from this version on that a 
> Dubbo release starts fully follows the Apache rules (lawfully), totally 
> independent from any other third-party organizations or companies. 
> Secondly, this version will include many new features that have received 
> wide attention from the community, by supporting these features, we can 
> better resolve the community’s long accumulated demands. Last but not 
> least, we have made some architectural changes in this version, made 
> Dubbo closer to the micro-service architecture, take the newly introduced 
> configuration center as an example, it can work both as the center of 
> Externalized Configuration at startup and as the center of service 
> management configurations at runtime.
> 
> To summarize, the contents already included in the CodeBase are:
> 
> * Config Center: Zookeeper, Apollo, Nacos
>

Fw:[WeeklyReport] Weekly report for Collabobot 2019-1-8 to 2019-1-15

2019-01-15 Thread Frank Zhao
Hi all,

Is this kind of weekly report email format OK? I think rendered format is more 
readable than this.


Frank

 Forwarding messages 
From: "Frank Zhao" 
Date: 2019-01-15 16:30:53
To:  syzhao1...@126.com
Subject: [WeeklyReport] Weekly report for Collabobot 2019-1-8 to 2019-1-15
# Weekly Report of Collabobot

This is a weekly report of Collabobot. It summarizes what have changed in the 
project during the passed week, including pr merged, new contributors, and more 
things in the future. 
It is all done by @collabobot which is a collaborate robot.


## Repo Overview

### Basic data

Baisc data shows how the watch, star, fork and contributors count changed in 
the passed week.

| Watch | Star | Fork | Contributors |
|:-:|::|::|::|
| 1 | 11 (↑11) | 3 (↑3) | 1 (↑1) |

### Issues & PRs

Issues & PRs show the new/closed issues/pull requests count in the passed week.

| New Issues | Closed Issues | New PR | Merged PR |
|:--:|:-:|:--:|:-:|
| 10 | 8 | 25 | 25 |

## PR Overview

Thanks to contributions from community, Collabobot team merged **25** pull 
requests in the repository last week. They are:

* typo fix ([#35](https://github.com/AlibabaDR/Collabobot/pull/35))
* Add custom config template 
([#34](https://github.com/AlibabaDR/Collabobot/pull/34))
* Add auto close last weekly report function 
([#33](https://github.com/AlibabaDR/Collabobot/pull/33))
* Change issue translation into comment format. 
([#32](https://github.com/AlibabaDR/Collabobot/pull/32))
* README update ([#31](https://github.com/AlibabaDR/Collabobot/pull/31))
* Add dingTalk notify service and and dingTalk weekly notify 
([#29](https://github.com/AlibabaDR/Collabobot/pull/29))
* Add mail service and send mail service while generating weekly report 
([#28](https://github.com/AlibabaDR/Collabobot/pull/28))
* Modify weekly report template. 
([#27](https://github.com/AlibabaDR/Collabobot/pull/27))
* translator config update 
([#26](https://github.com/AlibabaDR/Collabobot/pull/26))
* Update issue template ([#24](https://github.com/AlibabaDR/Collabobot/pull/24))
* ignore weeklyreport and notice issue, not translate. 
([#22](https://github.com/AlibabaDR/Collabobot/pull/22))
* fix translator error ([#21](https://github.com/AlibabaDR/Collabobot/pull/21))
* update translator config 
([#20](https://github.com/AlibabaDR/Collabobot/pull/20))
* fix translation error ([#18](https://github.com/AlibabaDR/Collabobot/pull/18))
* For translation concern, check label after edit 
([#17](https://github.com/AlibabaDR/Collabobot/pull/17))
* update question keywords 
([#16](https://github.com/AlibabaDR/Collabobot/pull/16))
* typo fix ([#15](https://github.com/AlibabaDR/Collabobot/pull/15))
* bug report template fix 
([#13](https://github.com/AlibabaDR/Collabobot/pull/13))
* [feature] Use optional tokens to fetch data to avoid abuse detection 
([#12](https://github.com/AlibabaDR/Collabobot/pull/12))
* Check chinese char in issue translator 
([#11](https://github.com/AlibabaDR/Collabobot/pull/11))
* Hide token & label update & tranlator fix 
([#9](https://github.com/AlibabaDR/Collabobot/pull/9))
* Make custom config file path can be passed by command line. 
([#6](https://github.com/AlibabaDR/Collabobot/pull/6))
* Issue auto label added. ([#3](https://github.com/AlibabaDR/Collabobot/pull/3))
* add label setup component and related files. 
([#2](https://github.com/AlibabaDR/Collabobot/pull/2))
* first commit ([#1](https://github.com/AlibabaDR/Collabobot/pull/1))


## Code Review Statistics

Collabobot encourages everyone to participant in code review, in order to 
improve software quality. Every week @collabobot would automatically help to 
count pull request reviews of single github user as the following. So, try to 
help review code in this project.

| Contributor ID | Pull Request Reviews |
|:--:|::|
| @Frankzhaopku | 19 |


## Contributors Overview

It is Collabobot team's great honor to have new contributors from community. We 
really appreciate your contributions. Feel free to tell us if you have any 
opinion and please share this open source project with more people if you 
could. If you hope to be a contributor as well, please start from 
https://github.com/AlibabaDR/Collabobot/blob/master/CONTRIBUTING.md .
Here is the list of new contributors:

@Frankzhaopku

Thanks to you all.

*Note: This robot is supported by 
[Collabobot](https://github.com/AlibabaDR/Collabobot).*


Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-15 Thread jun liu
PRs and issues regarding 2.7.0 raised recently:

Bugfixes:
1. https://github.com/apache/incubator-dubbo/pull/3233
2. https://github.com/apache/incubator-dubbo/pull/3232
3. https://github.com/apache/incubator-dubbo/pull/3229
4. https://github.com/apache/incubator-dubbo/pull/3224

* Async Enhancement
5. https://github.com/apache/incubator-dubbo/pull/3185
6. https://github.com/apache/incubator-dubbo/pull/3184

* Metadata Enhancement
7. https://github.com/apache/incubator-dubbo/pull/3182

Router Enhancement
8. https://github.com/apache/incubator-dubbo/pull/3173
9. https://github.com/apache/incubator-dubbo/pull/3233

Config Center
10. https://github.com/apache/incubator-dubbo/pull/3096

Jun

> On Jan 15, 2019, at 10:36 AM, jun liu  wrote:
> 
>> Hi Jun,
>> 
>> Could you summarize the current status of the 2.7-release branch?
>> I see there are still several enhancement on this branch.
> 
> The release notes draft[1] is available now (only Chinese version at 
> present). I will provide you the latest changes committed recently and the 
> TODOs left later today.
> 
> 1. https://github.com/apache/incubator-dubbo/blob/2.7.0-release/CHANGES.md
> 
> Jun
> 
>> On Jan 13, 2019, at 5:58 PM, Huxing Zhang  wrote:
>> 
>> Hi Jun,
>> 
>> Could you summarize the current status of the 2.7-release branch?
>> I see there are still several enhancement on this branch.
>> 
>> As this is the first time to prepare for a release for me, I am trying
>> to walk through the release steps[1].
>> I might try to deploy snapshot to maven repository.
>> 
>> Once we feel it is ready to do the release, I will start the formal
>> release process.
>> 
>> 
>> [1] http://dubbo.apache.org/en-us/blog/prepare-an-apache-release.html
>> 
>> 
>> -- 
>> Best Regards!
>> Huxing
>> 
>> On Mon, Jan 7, 2019 at 1:48 PM jun liu  wrote:
>>> 
> 
> Nice work!
> 
> I think we should let the community to participate more in the release
> process, for example,
> 1. check out a release branch called 2.7.0-release
> 2. encourage people to check it out, test it and report if there is
> any regressions, bugs or issues.
> 3. while we are doing the test, we can start going through the ASF
> release process locally, once we think it is ready to start a formal
> release note, it can be done very quickly.
> 
> By the way, we need decide the release manager of 2.7.0 release. Is
> there anyone who volunteer to do that?
>>> 
>>> Sorry, I missed this mail.
>>> * 2.7.0-release has been created
>>> * we've froze the codebase, test is underway.
>>> 
 I'd like to be the release manager if no one is claiming it.
>>> 
>>> Great, I can help you with the source/binary packaging and tagging things.
>>> 
>>> Jun
>>> 
 On Jan 5, 2019, at 12:11 PM, Huxing Zhang  wrote:
 
 Hi,
 
 On Fri, Dec 28, 2018 at 10:45 AM Huxing Zhang  wrote:
> 
> Nice work!
> 
> I think we should let the community to participate more in the release
> process, for example,
> 1. check out a release branch called 2.7.0-release
> 2. encourage people to check it out, test it and report if there is
> any regressions, bugs or issues.
> 3. while we are doing the test, we can start going through the ASF
> release process locally, once we think it is ready to start a formal
> release note, it can be done very quickly.
> 
> By the way, we need decide the release manager of 2.7.0 release. Is
> there anyone who volunteer to do that?
 
 I'd like to be the release manager if no one is claiming it.
> 
> On Thu, Dec 27, 2018 at 11:53 PM jun liu  wrote:
>> 
>> Hi, All
>> 
>> I am writing this mail to
>> 
>> * Keep you refreshed of the latest status about v2.7.0.
>> * Call for efforts on code review and tests
>> * Discuss possible release schedules of v2.7.0.
>> 
>> About v2.7, it’s going to be a milestone version, in which will make 
>> some significant changes. Most importantly, we will complete all IP 
>> Clearance related works. Technically speaking, it’s from this version on 
>> that a Dubbo release starts fully follows the Apache rules (lawfully), 
>> totally independent from any other third-party organizations or 
>> companies. Secondly, this version will include many new features that 
>> have received wide attention from the community, by supporting these 
>> features, we can better resolve the community’s long accumulated 
>> demands. Last but not least, we have made some architectural changes in 
>> this version, made Dubbo closer to the micro-service architecture, take 
>> the newly introduced configuration center as an example, it can work 
>> both as the center of Externalized Configuration at startup and as the 
>> center of service management configurations at runtime.
>> 
>> To summarize, the contents already included in the CodeBase are:
>> 
>> * Config Center: Zookeep

Re:Re: Fw:[WeeklyReport] Weekly report for Dubbo 2019-1-7 to 2019-1-14

2019-01-15 Thread Frank Zhao
OK, I will send plain markdown format without rendering.


--

Frank Zhao
Tel: 18513109194
Email: syzhao1...@126.com



At 2019-01-15 11:48:51, "Ian Luo"  wrote:
>Frank,
>
>HTML format is not welcomed and encouraged in the mailing list. I think it
>is fine to send the report in the plain text.
>
>Thanks,
>-Ian.
>
>
>On Mon, Jan 14, 2019 at 8:30 PM Frank Zhao  wrote:
>
>> Hi,
>> At 2019-01-14 16:30:40, "Huxing Zhang"  wrote:
>> >Hi,
>> >
>> >On Mon, Jan 14, 2019 at 2:56 PM Frank Zhao  wrote:
>> >>
>> >> Hi all,
>> >>
>> >>
>> >> The collabobot already starts to raise weekly report issue for Dubbo
>> from last week, now the framework supports mail sending function and can
>> send a weekly report email while raising an issue.
>> >>
>> >>
>> >> The email content will be like below and I propose to send weekly
>> report email to this mail list. WDYT.
>> >
>>
>> >The format has been lost. Can you try to post it directly to
>> >dev@dubbo.apache.org from the robot?
>>
>> >
>>
>>
>> Yes, the HTML format was transformed into Markdown format, I will send the
>> weekly email to dev@dubbo.apache.org mail list next week to see if the
>> format is right.
>>
>>
>> >>
>> >>
>> >> Regards.
>> >> Frank Zhao
>> >>
>> >>
>> >>  Forwarding messages 
>> >> From: "Frank Zhao" 
>> >> Date: 2019-01-14 14:51:04
>> >> To: syzhao1...@126.com
>> >> Subject: [WeeklyReport] Weekly report for Dubbo 2019-1-7 to 2019-1-14
>> >>
>> >> Weekly Report of Dubbo
>> >>
>> >> This is a weekly report of Dubbo. It summarizes what have changed in
>> the project during the passed week, including pr merged, new contributors,
>> and more things in the future. It is all done by @dubbo-bot which is a
>> collaborate robot.
>> >>
>> >> Repo Overview
>> >> Basic data
>> >>
>> >> Baisc data shows how the watch, star, fork and contributors count
>> changed in the passed week.
>> >>
>> >> | Watch | Star | Fork | Contributors |
>> >> | 3197 | 23904 (↑168) | 13569 (↑100) | 163 (↑2) |
>> >> Issues & PRs
>> >>
>> >> Issues & PRs show the new/closed issues/pull requests count in the
>> passed week.
>> >>
>> >> | New Issues | Closed Issues | New PR | Merged PR |
>> >> | 33 | 7 | 32 | 12 |
>> >> PR Overview
>> >>
>> >> Thanks to contributions from community, Dubbo team merged 12 pull
>> requests in the repository last week. They are:
>> >>
>> >> fix wrong word spelling (#3217)
>> >> [Dubbo-3169]Check future status before get(), return default value if
>> not completed yet. (#3185)
>> >> Async enhancement (#3184)
>> >> Fix metadata report configuration error (#3183)
>> >> Routers zookeeper path (#3173)
>> >> add some small optimize (#3171)
>> >> code optimization (#3167)
>> >> modify metadata node path in zookeeper (#3166)
>> >> optimize ReconnectTimerTask's log output (#3162)
>> >> Upgrade junt to junit5 (#3149)
>> >> fix telnet trace times is always 1 (#3038)
>> >> Add javadoc for dubbo-serialization module(#3002). (#3004)
>> >> Code Review Statistics
>> >>
>> >> Dubbo encourages everyone to participant in code review, in order to
>> improve software quality. Every week @dubbo-bot would automatically help to
>> count pull request reviews of single github user as the following. So, try
>> to help review code in this project.
>> >>
>> >> | Contributor ID | Pull Request Reviews |
>> >> | @khanimteyaz | 62 |
>> >> | @cvictory | 20 |
>> >> | @beiwei30 | 10 |
>> >> | @chickenlj | 8 |
>> >> | @CrazyHZM | 8 |
>> >> | @carryxyh | 7 |
>> >> | @lixiaojiee | 7 |
>> >> | @zhaoyuguang | 4 |
>> >> | @kexianjun | 3 |
>> >> | @zonghaishang | 3 |
>> >> | @LiZhenNet | 2 |
>> >> | @lovepoem | 1 |
>> >> | @kezhenxu94 | 1 |
>> >> | @htynkn | 1 |
>> >> Contributors Overview
>> >>
>> >> It is Dubbo team's great honor to have new contributors from community.
>> We really appreciate your contributions. Feel free to tell us if you have
>> any opinion and please share this open source project with more people if
>> you could. If you hope to be a contributor as well, please start from
>> https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md .
>> Here is the list of new contributors:
>> >>
>> >> @mimihom @majinkai
>> >>
>> >> Thanks to you all.
>> >>
>> >> Note: This robot is supported by Collabobot.
>> >
>> >
>> >
>> >--
>> >Best Regards!
>> >Huxing
>>