Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Liujie Qin
Yes

Gosling Von  于2019年4月9日周二 下午2:11写道:

> Yes
>
>
> Best Regards,
> Von Gosling
>
> > On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> >
> > Dear Dubbo PPMC members,
> >
> > (bcc to all PPMC members)
> >
> > The Dubbo community is discussing the graduation of Dubbo to be a Top
> > Level project of Apache Software Foundation in the dev mailing list.
> > As one of the steps towards graduation, the community needs to set up
> > list of Project Management Committees (PMC) members after graduation,
> > which will be included in the graduation resolution.
> >
> > The role of the PMC is included as follows[1]:
> >
> > The role of the PMC from a Foundation perspective is oversight. The
> > main role of the PMC is not code and not coding - but to ensure that
> > all legal issues are addressed, that procedure is followed, and that
> > each and every release is the product of the community as a whole.
> > That is key to our litigation protection mechanisms.
> >
> > Secondly the role of the PMC is to further the long term development
> > and health of the community as a whole, and to ensure that balanced
> > and wide scale peer review and collaboration does happen. Within the
> > ASF we worry about any community which centers around a few
> > individuals who are working virtually uncontested. We believe that
> > this is detrimental to quality, stability, and robustness of both code
> > and long term social structures.
> >
> > If you are willing to be a PMC member after graduation, please respond
> > YES to this thread by replying to dev@dubbo.apache.org no later than
> > 2019-04-12 (Friday).
> > If you are not subscribing the private list, please remember to
> > subscribe to the private@ list.
> >
> >
> > [1] http://www.apache.org/foundation/how-it-works.html#pmc
> > --
> > Best Regards!
> > Huxing
>
>


Re: [Suggestion] Dubbo should improve the way to achieve the config properties.

2019-04-08 Thread Huxing Zhang
Hi,

On Mon, Apr 8, 2019 at 2:04 PM 徐靖峰  wrote:
>
> Hi folks:
>
> Before Dubbo2.7 does not support the configuration center, the way to get the 
> system configuration parameters is mainly through the getProperty(String key, 
> String defaultValue) and getProperty(String key) methods provided by 
> org.apache.dubbo.common.utils.ConfigUtils.
>
> Sample inventory code:
>
> ```java
> / / Get the logback log level
> ConfigUtils.getProperty("dubbo.logback.level");
> / / Configure the number of shared connections
> ConfigUtils.getProperty("shareconnections","1");
> ```
>
> Dubbo2.7 provides `org.apache.dubbo.common.config.ConfigurationUtils` to 
> support loading configurations from multiple configuration sources.
>
> Sample inventory code:
>
> ```java
> / / Get the log4j log level
> ConfigurationUtils.getProperty("dubbo.log4j.level");
> / / Get the service outage timeout
> ConfigurationUtils.getServerShutdownTimeout()
> ```
>
> risk point:
>
> 1. After the configuration center is introduced in 2.7, you can configure the 
> parameters of the application granularity in the configuration center. Some 
> of the original parameters are obtained by using ConfigUtils, which may 
> invalidate the user configuration.
> 2. There are different styles of obtaining application parameters in the 
> inventory code. For example, the log level log4j and logback use different 
> APIs.
>
> improve proposals:
>
> 1. First mark the version of ConfigUtils as expired, modify the 
> implementation of ConfigUtils, and use ConfigurationUtils to bridge to 
> ConfigUtils.
> 2. Avoid using ConfigUtils in future developments, avoiding directly getting 
> Environment.getInstant.getConfiguration() and undoing ConfigurationUtils.
> 3. ConfigurationUtils should not contain a specific business method. It only 
> provides get/set methods for configuration parameters, such as the existing 
> getServerShutdownTimeout(), which should be passed in by the business 
> scenario: getProperty("dubbo.server.shutdown.timeout" ).

+1 to the proposal.

>
> I will do some improvement for these risk point.
>
> ——
> 在 Dubbo2.7 未支持配置中心之前,获取系统配置参数的方式主要是通过 
> org.apache.dubbo.common.utils.ConfigUtils 提供的 getProperty(String key, String 
> defaultValue),getProperty(String key) 方法。
> 存量代码示例:
> // 获取 logback 日志级别
> ConfigUtils.getProperty("dubbo.logback.level");
> // 配置共享连接的数量
> ConfigUtils.getProperty("shareconnections","1");
> Dubbo2.7 提供了 org.apache.dubbo.common.config.ConfigurationUtils 支持从多种配置源中加载配置
> 存量代码示例:
> // 获取 log4j 日志级别
> ConfigurationUtils.getProperty("dubbo.log4j.level");
> // 获取服务停机超时时间
> ConfigurationUtils.getServerShutdownTimeout()
> 风险点:
> 在 2.7 推出配置中心之后,允许用户在配置中心中配置应用粒度的参数,原有的一些参数使用了 ConfigUtils 去获取,可能导致用户配置失效。
> 存量代码中多处获取应用参数的代码风格不一,如获取日志级别 log4j 和 logback 使用了不同的 api。
> 改进方案:
> 首先将就版本的 ConfigUtils 标注为过期,修改 ConfigUtils 的实现,使用 ConfigurationUtils 桥接到 
> ConfigUtils。
> 今后开发中避免使用 ConfigUtils,避免直接获取 Environment.getInstant.getConfiguration(),统一走 
> ConfigurationUtils。
> ConfigurationUtils 不应该包含具体某个业务方法,只提供配置参数的 get/set 方法,例如现有的 
> getServerShutdownTimeout(),应当由业务场景传入键值: 
> getProperty("dubbo.server.shutdown.timeout")。
>
>
>


-- 
Best Regards!
Huxing


Suggested topic for ApacheCon

2019-04-08 Thread Huxing Zhang
Hi,

This year will be 20th anniversary of ASF, I am thinking about submit
a topic about Dubbo to ApacheCon NA[1]. The Call for Presentations
will close on the morning of May 13th, Pacific US time.

As Dubbo is relatively new to people outside China, I am thinking to
submit a topic about basic introduction to Dubbo, for example, what
Dubbo is, and introduce the cool features added recently.

The purpose should be let more people to know about Dubbo.

How do you think? Any other ideas?

[1] https://www.apachecon.com/
-- 
Best Regards!
Huxing


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Gosling Von
Yes


Best Regards,
Von Gosling

> On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> 
> Dear Dubbo PPMC members,
> 
> (bcc to all PPMC members)
> 
> The Dubbo community is discussing the graduation of Dubbo to be a Top
> Level project of Apache Software Foundation in the dev mailing list.
> As one of the steps towards graduation, the community needs to set up
> list of Project Management Committees (PMC) members after graduation,
> which will be included in the graduation resolution.
> 
> The role of the PMC is included as follows[1]:
> 
> The role of the PMC from a Foundation perspective is oversight. The
> main role of the PMC is not code and not coding - but to ensure that
> all legal issues are addressed, that procedure is followed, and that
> each and every release is the product of the community as a whole.
> That is key to our litigation protection mechanisms.
> 
> Secondly the role of the PMC is to further the long term development
> and health of the community as a whole, and to ensure that balanced
> and wide scale peer review and collaboration does happen. Within the
> ASF we worry about any community which centers around a few
> individuals who are working virtually uncontested. We believe that
> this is detrimental to quality, stability, and robustness of both code
> and long term social structures.
> 
> If you are willing to be a PMC member after graduation, please respond
> YES to this thread by replying to dev@dubbo.apache.org no later than
> 2019-04-12 (Friday).
> If you are not subscribing the private list, please remember to
> subscribe to the private@ list.
> 
> 
> [1] http://www.apache.org/foundation/how-it-works.html#pmc
> -- 
> Best Regards!
> Huxing



Re: About polish code related pr

2019-04-08 Thread Huxing Zhang
Hi,

I agree with Ian. I think small patches to polish code is acceptable.
People these days are getting busy, and might not have large amount of
time to contribute.
Meanwhile, the it is easy to review. Large size pull request can be
hard to review.

On Tue, Apr 9, 2019 at 10:31 AM yuhang xiu  wrote:
>
> Hi, all
>
> Recently I found out that we have merged some pull requests for the polish
> code.
>
> I personally do not advocate small-scale polish code, such as this pr [1].
> We can't see the improvement clearly.
>
> I think that for this pr, we should put it in a large-scale polish code, or
> bugfix and feature-related pr, rather than separate.
>
> It's important to note that I am not denying the importance of the polish
> code. I just think that these prs will disrupt our commits record.
>
> I have encountered this problem in the flink community. The flink community
> does not accept small-scale polish code pr. They suggested that this change
> should be placed in other prs.
>
> What do you think about this?
>
> [1] https://github.com/apache/incubator-dubbo/pull/3820/files



-- 
Best Regards!
Huxing


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread zhangli...@apache.org
Yes, I am very glad to see dubbo as a Apache TLP.

--

Liang Zhang (John)
Apache ShardingSphere & Dubbo


Huxing Zhang  于2019年4月9日周二 上午10:13写道:

> Dear Dubbo PPMC members,
>
> (bcc to all PPMC members)
>
> The Dubbo community is discussing the graduation of Dubbo to be a Top
> Level project of Apache Software Foundation in the dev mailing list.
> As one of the steps towards graduation, the community needs to set up
> list of Project Management Committees (PMC) members after graduation,
> which will be included in the graduation resolution.
>
> The role of the PMC is included as follows[1]:
>
> The role of the PMC from a Foundation perspective is oversight. The
> main role of the PMC is not code and not coding - but to ensure that
> all legal issues are addressed, that procedure is followed, and that
> each and every release is the product of the community as a whole.
> That is key to our litigation protection mechanisms.
>
> Secondly the role of the PMC is to further the long term development
> and health of the community as a whole, and to ensure that balanced
> and wide scale peer review and collaboration does happen. Within the
> ASF we worry about any community which centers around a few
> individuals who are working virtually uncontested. We believe that
> this is detrimental to quality, stability, and robustness of both code
> and long term social structures.
>
> If you are willing to be a PMC member after graduation, please respond
> YES to this thread by replying to dev@dubbo.apache.org no later than
> 2019-04-12 (Friday).
> If you are not subscribing the private list, please remember to
> subscribe to the private@ list.
>
>
> [1] http://www.apache.org/foundation/how-it-works.html#pmc
> --
> Best Regards!
> Huxing
>


Re: Incompatible license for dependency nacos-client

2019-04-08 Thread Ian Luo
Good idea. Should we introduce a script to guard against this first?

Thanks,
-Ian.

On Tue, Apr 9, 2019 at 11:14 AM YunKun Huang  wrote:

> Should we add this check in travis CI or do this check each time for a new
> dependency added
>
> On 2019/04/08 06:09:56, Ian Luo  wrote:
> > Great, let's target it to 2.7.2. I have moved the issue [1] into 2.7.2's
> > bucket.
> >
> > -Ian.
> >
> > 1. https://github.com/apache/incubator-dubbo/issues/3804
> >
> > On Tue, Apr 2, 2019 at 5:59 PM Huxing Zhang  wrote:
> >
> > > Hi,
> > >
> > > It looks like the dependencies with incompatible licenses have been
> > > removed on the Nacos side.
> > > So I think Dubbo should upgrade to the latest version once there is a
> > > release.
> > >
> > > On Tue, Apr 2, 2019 at 10:28 AM Ian Luo  wrote:
> > > >
> > > > We should contact nacos's developer to fix this dependency issue.
> > > >
> > > > -Ian.
> > > >
> > > > On Mon, Apr 1, 2019 at 6:15 PM Huxing Zhang 
> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > When I am looking at this issue[1], I realized that Dubbo may have
> the
> > > > > same issue.
> > > > > From Dubbo 2.7.1 and 2.6.6 onwards the Nacos support has been
> added,
> > > > > where the following dependency has been added:
> > > > >
> > > > > 
> > > > > com.alibaba.nacos
> > > > > nacos-client
> > > > > ${nacos.version}
> > > > > true
> > > > > 
> > > > >
> > > > > which depend on the following dependencies:
> > > > >
> > > > > 
> > > > > org.codehaus.jackson
> > > > > jackson-mapper-lgpl
> > > > > 
> > > > >
> > > > > 
> > > > > com.github.spotbugs
> > > > > spotbugs-annotations
> > > > > true
> > > > > 
> > > > >
> > > > > which is LGPL v2.1 licensed.
> > > > >
> > > > > This means nacos-client should not be Apache Licensed as claimed,
> and
> > > > > Dubbo could not depend on nacos-client.
> > > > >
> > > > > I have contacted the Nacos team they are addressing this issue.
> > > > >
> > > > > My question is how to avoid this kind of issue?
> > > > > Should we check every newly added dependency for license
> compatibility?
> > > > > Is there any tools which can do automatic scanning?
> > > > >
> > > > > [1] https://github.com/apache/incubator-skywalking/pull/2422
> > > > >
> > > > > --
> > > > > Best Regards!
> > > > > Huxing
> > > > >
> > >
> > >
> > >
> > > --
> > > Best Regards!
> > > Huxing
> > >
> >
>


Re: Incompatible license for dependency nacos-client

2019-04-08 Thread Huxing Zhang
Hi,

On Tue, Apr 9, 2019 at 11:14 AM YunKun Huang  wrote:
>
> Should we add this check in travis CI or do this check each time for a new 
> dependency added

The problem is that not every time a new dependency will be added, and
the process will take too much time in my local test. My concerns is
that UT will take much longer to finish.
So I suggest to check it manually when new dependency is added (the
reviewer should check the dependencies when doing code review) and
when doing release vote.
How do you think?

>
> On 2019/04/08 06:09:56, Ian Luo  wrote:
> > Great, let's target it to 2.7.2. I have moved the issue [1] into 2.7.2's
> > bucket.
> >
> > -Ian.
> >
> > 1. https://github.com/apache/incubator-dubbo/issues/3804
> >
> > On Tue, Apr 2, 2019 at 5:59 PM Huxing Zhang  wrote:
> >
> > > Hi,
> > >
> > > It looks like the dependencies with incompatible licenses have been
> > > removed on the Nacos side.
> > > So I think Dubbo should upgrade to the latest version once there is a
> > > release.
> > >
> > > On Tue, Apr 2, 2019 at 10:28 AM Ian Luo  wrote:
> > > >
> > > > We should contact nacos's developer to fix this dependency issue.
> > > >
> > > > -Ian.
> > > >
> > > > On Mon, Apr 1, 2019 at 6:15 PM Huxing Zhang  wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > When I am looking at this issue[1], I realized that Dubbo may have the
> > > > > same issue.
> > > > > From Dubbo 2.7.1 and 2.6.6 onwards the Nacos support has been added,
> > > > > where the following dependency has been added:
> > > > >
> > > > > 
> > > > > com.alibaba.nacos
> > > > > nacos-client
> > > > > ${nacos.version}
> > > > > true
> > > > > 
> > > > >
> > > > > which depend on the following dependencies:
> > > > >
> > > > > 
> > > > > org.codehaus.jackson
> > > > > jackson-mapper-lgpl
> > > > > 
> > > > >
> > > > > 
> > > > > com.github.spotbugs
> > > > > spotbugs-annotations
> > > > > true
> > > > > 
> > > > >
> > > > > which is LGPL v2.1 licensed.
> > > > >
> > > > > This means nacos-client should not be Apache Licensed as claimed, and
> > > > > Dubbo could not depend on nacos-client.
> > > > >
> > > > > I have contacted the Nacos team they are addressing this issue.
> > > > >
> > > > > My question is how to avoid this kind of issue?
> > > > > Should we check every newly added dependency for license 
> > > > > compatibility?
> > > > > Is there any tools which can do automatic scanning?
> > > > >
> > > > > [1] https://github.com/apache/incubator-skywalking/pull/2422
> > > > >
> > > > > --
> > > > > Best Regards!
> > > > > Huxing
> > > > >
> > >
> > >
> > >
> > > --
> > > Best Regards!
> > > Huxing
> > >
> >



-- 
Best Regards!
Huxing


Re: [DISCUSS] PMC Chair of Dubbo

2019-04-08 Thread Ian Luo
>From Mark's description, it looks quite a big challenge to me. In the past,
I focus more on driving this project forward from the perspective of
technique which apparent interests me very much. The most benefit I
received from this incubating practice is that I have truly believed
'community over code'. I'd like to give it a try if the board accepts the
proposal, and hope to contribute more by wearing this 'admin' hat.

Regards,
-Ian.


On Fri, Apr 5, 2019 at 11:42 PM Huxing Zhang  wrote:

> Hi,
>
>
> On Fri, Apr 5, 2019 at 5:42 PM Mark Thomas  wrote:
> >
> > On 04/04/2019 03:26, Huxing Zhang wrote:
> > > Hi All,
> > >
> > > According to [1], in the "Preparing a Charter" section, we need to
> > > decide PMC chair.
> >
> > Just to nitpick here.
> >
> > The PMC does not decide on who is the chair. The board does.
> >
> > The PMC makes a recommendation to the board as to who should be
> > appointed the PMC chair. The board nearly always accepts that
> > recommendation.
>
> Understand, what I mean is to decide the recommendation :-)
>
> >
> > > This is previously discussed on the "[DISCUSS] Graduate Apache
> > > Dubbo(incubating) as a Top Level Project" thread, but it looks like it
> > > is easily ignored. Therefore I am starting a dedicated thread to
> > > discuss this.
> > >
> > > I personally am suggesting Ian Luo as PMC chair. Ian is leading the
> > > Dubbo project, and has rich experience in RPC/service framework. I
> > > think he is the best candidate.
> >
> > Leading is a word that always makes me nervous around ASF projects.
>
> By saying leading, I mean to say skills like technical foresight,
> sophisticated understanding of the architecture and underlying
> implementation, and etc. to drive the project forward.
> I think every project/community will have one or more folk like this.
> I do not mean to say one has more power over others. In Apache, all
> the PMC members are equal.
>
> >
> > The role of PMC chair is an unusual one. PMC chairs are officers of the
> > foundation and, as such, have quite a lot of authority. However, if they
> > ever need to use that authority then it usually means things have gone
> > very badly wrong.
>
> Just adding some more information about what PMC chair is, and what it
> the responsibility.
>
> PMC CHAIR
> The Chair of a Project Management Committee (PMC) is appointed by the
> Board from the PMC Members. The PMC as a whole is the entity that
> controls and leads the project. The Chair is the interface between the
> Board and the Project. PMC Chairs have specific duties[1][2], which is
> briefly described here:
> - SUBSCRIBE TO THE BOARD@ MAILING LIST
> - REVIEW BOARD MEETING MINUTES ABOUT THEIR PROJECT
> - ENSURE THE PROJECT'S QUARTERLY BOARD REPORT IS SUBMITTED
> - ENSURE NEW COMMITTER REQUESTS ARE MADE
> - SEND NOTICES AND FOLLOWUP WHEN ADDING NEW PMC MEMBERS
> - MAINTAIN ASF RECORDS ON THE PMC ROSTER
>
> [1] http://www.apache.org/dev/pmc.html#chair
> [2]
> https://svn.apache.org/repos/private/foundation/officers/advice-for-new-pmc-chairs.txt
>
> >
> > If everything is working as it should, the role of PMC chair is mostly
> > an admin role. Applying for new accounts, writing quarterly reports, etc.
> >
> > The most important part of a PMC chair's role is to write quarterly
> > reports for the board that *accurately* describe the current state of
> > the project community. Note: not the technical state of the project, but
> > the state of the project community. I'd strongly recommend reading
> > through the minutes of the last few board meetings to get an idea of
> > what makes a good project report in the eyes of the board.
>
> I have added the link here[3] so that the community can take a look.
>
> [3]
> http://www.apache.org/foundation/records/minutes/2019/board_minutes_2019_02_20.txt
>
> >
> > Mark
>
>
>
> --
> Best Regards!
> Huxing
>


Re: Incompatible license for dependency nacos-client

2019-04-08 Thread YunKun Huang
Should we add this check in travis CI or do this check each time for a new 
dependency added

On 2019/04/08 06:09:56, Ian Luo  wrote: 
> Great, let's target it to 2.7.2. I have moved the issue [1] into 2.7.2's
> bucket.
> 
> -Ian.
> 
> 1. https://github.com/apache/incubator-dubbo/issues/3804
> 
> On Tue, Apr 2, 2019 at 5:59 PM Huxing Zhang  wrote:
> 
> > Hi,
> >
> > It looks like the dependencies with incompatible licenses have been
> > removed on the Nacos side.
> > So I think Dubbo should upgrade to the latest version once there is a
> > release.
> >
> > On Tue, Apr 2, 2019 at 10:28 AM Ian Luo  wrote:
> > >
> > > We should contact nacos's developer to fix this dependency issue.
> > >
> > > -Ian.
> > >
> > > On Mon, Apr 1, 2019 at 6:15 PM Huxing Zhang  wrote:
> > >
> > > > Hi,
> > > >
> > > > When I am looking at this issue[1], I realized that Dubbo may have the
> > > > same issue.
> > > > From Dubbo 2.7.1 and 2.6.6 onwards the Nacos support has been added,
> > > > where the following dependency has been added:
> > > >
> > > > 
> > > > com.alibaba.nacos
> > > > nacos-client
> > > > ${nacos.version}
> > > > true
> > > > 
> > > >
> > > > which depend on the following dependencies:
> > > >
> > > > 
> > > > org.codehaus.jackson
> > > > jackson-mapper-lgpl
> > > > 
> > > >
> > > > 
> > > > com.github.spotbugs
> > > > spotbugs-annotations
> > > > true
> > > > 
> > > >
> > > > which is LGPL v2.1 licensed.
> > > >
> > > > This means nacos-client should not be Apache Licensed as claimed, and
> > > > Dubbo could not depend on nacos-client.
> > > >
> > > > I have contacted the Nacos team they are addressing this issue.
> > > >
> > > > My question is how to avoid this kind of issue?
> > > > Should we check every newly added dependency for license compatibility?
> > > > Is there any tools which can do automatic scanning?
> > > >
> > > > [1] https://github.com/apache/incubator-skywalking/pull/2422
> > > >
> > > > --
> > > > Best Regards!
> > > > Huxing
> > > >
> >
> >
> >
> > --
> > Best Regards!
> > Huxing
> >
> 


Re: About polish code related pr

2019-04-08 Thread Ian Luo
I think it is fine to accept small pull request which contains code polish
only. What's others opinion?

-Ian.

On Tue, Apr 9, 2019 at 10:31 AM yuhang xiu  wrote:

> Hi, all
>
> Recently I found out that we have merged some pull requests for the polish
> code.
>
> I personally do not advocate small-scale polish code, such as this pr [1].
> We can't see the improvement clearly.
>
> I think that for this pr, we should put it in a large-scale polish code, or
> bugfix and feature-related pr, rather than separate.
>
> It's important to note that I am not denying the importance of the polish
> code. I just think that these prs will disrupt our commits record.
>
> I have encountered this problem in the flink community. The flink community
> does not accept small-scale polish code pr. They suggested that this change
> should be placed in other prs.
>
> What do you think about this?
>
> [1] https://github.com/apache/incubator-dubbo/pull/3820/files
>


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Ian Luo
YES

On Tue, Apr 9, 2019 at 10:13 AM Huxing Zhang  wrote:

> Dear Dubbo PPMC members,
>
> (bcc to all PPMC members)
>
> The Dubbo community is discussing the graduation of Dubbo to be a Top
> Level project of Apache Software Foundation in the dev mailing list.
> As one of the steps towards graduation, the community needs to set up
> list of Project Management Committees (PMC) members after graduation,
> which will be included in the graduation resolution.
>
> The role of the PMC is included as follows[1]:
>
> The role of the PMC from a Foundation perspective is oversight. The
> main role of the PMC is not code and not coding - but to ensure that
> all legal issues are addressed, that procedure is followed, and that
> each and every release is the product of the community as a whole.
> That is key to our litigation protection mechanisms.
>
> Secondly the role of the PMC is to further the long term development
> and health of the community as a whole, and to ensure that balanced
> and wide scale peer review and collaboration does happen. Within the
> ASF we worry about any community which centers around a few
> individuals who are working virtually uncontested. We believe that
> this is detrimental to quality, stability, and robustness of both code
> and long term social structures.
>
> If you are willing to be a PMC member after graduation, please respond
> YES to this thread by replying to dev@dubbo.apache.org no later than
> 2019-04-12 (Friday).
> If you are not subscribing the private list, please remember to
> subscribe to the private@ list.
>
>
> [1] http://www.apache.org/foundation/how-it-works.html#pmc
> --
> Best Regards!
> Huxing
>


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Jerrick Zhu
YES

Minxuan Zhuang  于2019年4月9日周二 上午10:54写道:

> YES
>
> On Tue, Apr 9, 2019 at 10:41 AM Zonghai Shang  wrote:
>
> > YES
> >
> > -yiji
> >
> > Xin Wang  于2019年4月9日周二 上午10:19写道:
> >
> > > YES
> > >
> > > Jun Liu  于2019年4月9日周二 上午10:16写道:
> > >
> > > > YES
> > > >
> > > > Jun
> > > >
> > > > > On Apr 9, 2019, at 10:12 AM, Huxing Zhang 
> wrote:
> > > > >
> > > > > Dear Dubbo PPMC members,
> > > > >
> > > > > (bcc to all PPMC members)
> > > > >
> > > > > The Dubbo community is discussing the graduation of Dubbo to be a
> Top
> > > > > Level project of Apache Software Foundation in the dev mailing
> list.
> > > > > As one of the steps towards graduation, the community needs to set
> up
> > > > > list of Project Management Committees (PMC) members after
> graduation,
> > > > > which will be included in the graduation resolution.
> > > > >
> > > > > The role of the PMC is included as follows[1]:
> > > > >
> > > > > The role of the PMC from a Foundation perspective is oversight. The
> > > > > main role of the PMC is not code and not coding - but to ensure
> that
> > > > > all legal issues are addressed, that procedure is followed, and
> that
> > > > > each and every release is the product of the community as a whole.
> > > > > That is key to our litigation protection mechanisms.
> > > > >
> > > > > Secondly the role of the PMC is to further the long term
> development
> > > > > and health of the community as a whole, and to ensure that balanced
> > > > > and wide scale peer review and collaboration does happen. Within
> the
> > > > > ASF we worry about any community which centers around a few
> > > > > individuals who are working virtually uncontested. We believe that
> > > > > this is detrimental to quality, stability, and robustness of both
> > code
> > > > > and long term social structures.
> > > > >
> > > > > If you are willing to be a PMC member after graduation, please
> > respond
> > > > > YES to this thread by replying to dev@dubbo.apache.org no later
> than
> > > > > 2019-04-12 (Friday).
> > > > > If you are not subscribing the private list, please remember to
> > > > > subscribe to the private@ list.
> > > > >
> > > > >
> > > > > [1] http://www.apache.org/foundation/how-it-works.html#pmc
> > > > > --
> > > > > Best Regards!
> > > > > Huxing
> > > >
> > > >
> > >
> >
>


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread YunKun Huang
YES

Huxing Zhang  于2019年4月9日周二 上午10:13写道:

> Dear Dubbo PPMC members,
>
> (bcc to all PPMC members)
>
> The Dubbo community is discussing the graduation of Dubbo to be a Top
> Level project of Apache Software Foundation in the dev mailing list.
> As one of the steps towards graduation, the community needs to set up
> list of Project Management Committees (PMC) members after graduation,
> which will be included in the graduation resolution.
>
> The role of the PMC is included as follows[1]:
>
> The role of the PMC from a Foundation perspective is oversight. The
> main role of the PMC is not code and not coding - but to ensure that
> all legal issues are addressed, that procedure is followed, and that
> each and every release is the product of the community as a whole.
> That is key to our litigation protection mechanisms.
>
> Secondly the role of the PMC is to further the long term development
> and health of the community as a whole, and to ensure that balanced
> and wide scale peer review and collaboration does happen. Within the
> ASF we worry about any community which centers around a few
> individuals who are working virtually uncontested. We believe that
> this is detrimental to quality, stability, and robustness of both code
> and long term social structures.
>
> If you are willing to be a PMC member after graduation, please respond
> YES to this thread by replying to dev@dubbo.apache.org no later than
> 2019-04-12 (Friday).
> If you are not subscribing the private list, please remember to
> subscribe to the private@ list.
>
>
> [1] http://www.apache.org/foundation/how-it-works.html#pmc
> --
> Best Regards!
> Huxing
>


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Minxuan Zhuang
YES

On Tue, Apr 9, 2019 at 10:41 AM Zonghai Shang  wrote:

> YES
>
> -yiji
>
> Xin Wang  于2019年4月9日周二 上午10:19写道:
>
> > YES
> >
> > Jun Liu  于2019年4月9日周二 上午10:16写道:
> >
> > > YES
> > >
> > > Jun
> > >
> > > > On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> > > >
> > > > Dear Dubbo PPMC members,
> > > >
> > > > (bcc to all PPMC members)
> > > >
> > > > The Dubbo community is discussing the graduation of Dubbo to be a Top
> > > > Level project of Apache Software Foundation in the dev mailing list.
> > > > As one of the steps towards graduation, the community needs to set up
> > > > list of Project Management Committees (PMC) members after graduation,
> > > > which will be included in the graduation resolution.
> > > >
> > > > The role of the PMC is included as follows[1]:
> > > >
> > > > The role of the PMC from a Foundation perspective is oversight. The
> > > > main role of the PMC is not code and not coding - but to ensure that
> > > > all legal issues are addressed, that procedure is followed, and that
> > > > each and every release is the product of the community as a whole.
> > > > That is key to our litigation protection mechanisms.
> > > >
> > > > Secondly the role of the PMC is to further the long term development
> > > > and health of the community as a whole, and to ensure that balanced
> > > > and wide scale peer review and collaboration does happen. Within the
> > > > ASF we worry about any community which centers around a few
> > > > individuals who are working virtually uncontested. We believe that
> > > > this is detrimental to quality, stability, and robustness of both
> code
> > > > and long term social structures.
> > > >
> > > > If you are willing to be a PMC member after graduation, please
> respond
> > > > YES to this thread by replying to dev@dubbo.apache.org no later than
> > > > 2019-04-12 (Friday).
> > > > If you are not subscribing the private list, please remember to
> > > > subscribe to the private@ list.
> > > >
> > > >
> > > > [1] http://www.apache.org/foundation/how-it-works.html#pmc
> > > > --
> > > > Best Regards!
> > > > Huxing
> > >
> > >
> >
>


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Mercy

YES

在 2019/4/9 上午10:12, Huxing Zhang 写道:

Dear Dubbo PPMC members,

(bcc to all PPMC members)

The Dubbo community is discussing the graduation of Dubbo to be a Top
Level project of Apache Software Foundation in the dev mailing list.
As one of the steps towards graduation, the community needs to set up
list of Project Management Committees (PMC) members after graduation,
which will be included in the graduation resolution.

The role of the PMC is included as follows[1]:

The role of the PMC from a Foundation perspective is oversight. The
main role of the PMC is not code and not coding - but to ensure that
all legal issues are addressed, that procedure is followed, and that
each and every release is the product of the community as a whole.
That is key to our litigation protection mechanisms.

Secondly the role of the PMC is to further the long term development
and health of the community as a whole, and to ensure that balanced
and wide scale peer review and collaboration does happen. Within the
ASF we worry about any community which centers around a few
individuals who are working virtually uncontested. We believe that
this is detrimental to quality, stability, and robustness of both code
and long term social structures.

If you are willing to be a PMC member after graduation, please respond
YES to this thread by replying to dev@dubbo.apache.org no later than
2019-04-12 (Friday).
If you are not subscribing the private list, please remember to
subscribe to the private@ list.


[1] http://www.apache.org/foundation/how-it-works.html#pmc


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Zonghai Shang
YES

-yiji

Xin Wang  于2019年4月9日周二 上午10:19写道:

> YES
>
> Jun Liu  于2019年4月9日周二 上午10:16写道:
>
> > YES
> >
> > Jun
> >
> > > On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> > >
> > > Dear Dubbo PPMC members,
> > >
> > > (bcc to all PPMC members)
> > >
> > > The Dubbo community is discussing the graduation of Dubbo to be a Top
> > > Level project of Apache Software Foundation in the dev mailing list.
> > > As one of the steps towards graduation, the community needs to set up
> > > list of Project Management Committees (PMC) members after graduation,
> > > which will be included in the graduation resolution.
> > >
> > > The role of the PMC is included as follows[1]:
> > >
> > > The role of the PMC from a Foundation perspective is oversight. The
> > > main role of the PMC is not code and not coding - but to ensure that
> > > all legal issues are addressed, that procedure is followed, and that
> > > each and every release is the product of the community as a whole.
> > > That is key to our litigation protection mechanisms.
> > >
> > > Secondly the role of the PMC is to further the long term development
> > > and health of the community as a whole, and to ensure that balanced
> > > and wide scale peer review and collaboration does happen. Within the
> > > ASF we worry about any community which centers around a few
> > > individuals who are working virtually uncontested. We believe that
> > > this is detrimental to quality, stability, and robustness of both code
> > > and long term social structures.
> > >
> > > If you are willing to be a PMC member after graduation, please respond
> > > YES to this thread by replying to dev@dubbo.apache.org no later than
> > > 2019-04-12 (Friday).
> > > If you are not subscribing the private list, please remember to
> > > subscribe to the private@ list.
> > >
> > >
> > > [1] http://www.apache.org/foundation/how-it-works.html#pmc
> > > --
> > > Best Regards!
> > > Huxing
> >
> >
>


About polish code related pr

2019-04-08 Thread yuhang xiu
Hi, all

Recently I found out that we have merged some pull requests for the polish
code.

I personally do not advocate small-scale polish code, such as this pr [1].
We can't see the improvement clearly.

I think that for this pr, we should put it in a large-scale polish code, or
bugfix and feature-related pr, rather than separate.

It's important to note that I am not denying the importance of the polish
code. I just think that these prs will disrupt our commits record.

I have encountered this problem in the flink community. The flink community
does not accept small-scale polish code pr. They suggested that this change
should be placed in other prs.

What do you think about this?

[1] https://github.com/apache/incubator-dubbo/pull/3820/files


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Xin Wang
YES

Jun Liu  于2019年4月9日周二 上午10:16写道:

> YES
>
> Jun
>
> > On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> >
> > Dear Dubbo PPMC members,
> >
> > (bcc to all PPMC members)
> >
> > The Dubbo community is discussing the graduation of Dubbo to be a Top
> > Level project of Apache Software Foundation in the dev mailing list.
> > As one of the steps towards graduation, the community needs to set up
> > list of Project Management Committees (PMC) members after graduation,
> > which will be included in the graduation resolution.
> >
> > The role of the PMC is included as follows[1]:
> >
> > The role of the PMC from a Foundation perspective is oversight. The
> > main role of the PMC is not code and not coding - but to ensure that
> > all legal issues are addressed, that procedure is followed, and that
> > each and every release is the product of the community as a whole.
> > That is key to our litigation protection mechanisms.
> >
> > Secondly the role of the PMC is to further the long term development
> > and health of the community as a whole, and to ensure that balanced
> > and wide scale peer review and collaboration does happen. Within the
> > ASF we worry about any community which centers around a few
> > individuals who are working virtually uncontested. We believe that
> > this is detrimental to quality, stability, and robustness of both code
> > and long term social structures.
> >
> > If you are willing to be a PMC member after graduation, please respond
> > YES to this thread by replying to dev@dubbo.apache.org no later than
> > 2019-04-12 (Friday).
> > If you are not subscribing the private list, please remember to
> > subscribe to the private@ list.
> >
> >
> > [1] http://www.apache.org/foundation/how-it-works.html#pmc
> > --
> > Best Regards!
> > Huxing
>
>


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread yuhang xiu
YES

Jun Liu  于2019年4月9日周二 上午10:16写道:

> YES
>
> Jun
>
> > On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> >
> > Dear Dubbo PPMC members,
> >
> > (bcc to all PPMC members)
> >
> > The Dubbo community is discussing the graduation of Dubbo to be a Top
> > Level project of Apache Software Foundation in the dev mailing list.
> > As one of the steps towards graduation, the community needs to set up
> > list of Project Management Committees (PMC) members after graduation,
> > which will be included in the graduation resolution.
> >
> > The role of the PMC is included as follows[1]:
> >
> > The role of the PMC from a Foundation perspective is oversight. The
> > main role of the PMC is not code and not coding - but to ensure that
> > all legal issues are addressed, that procedure is followed, and that
> > each and every release is the product of the community as a whole.
> > That is key to our litigation protection mechanisms.
> >
> > Secondly the role of the PMC is to further the long term development
> > and health of the community as a whole, and to ensure that balanced
> > and wide scale peer review and collaboration does happen. Within the
> > ASF we worry about any community which centers around a few
> > individuals who are working virtually uncontested. We believe that
> > this is detrimental to quality, stability, and robustness of both code
> > and long term social structures.
> >
> > If you are willing to be a PMC member after graduation, please respond
> > YES to this thread by replying to dev@dubbo.apache.org no later than
> > 2019-04-12 (Friday).
> > If you are not subscribing the private list, please remember to
> > subscribe to the private@ list.
> >
> >
> > [1] http://www.apache.org/foundation/how-it-works.html#pmc
> > --
> > Best Regards!
> > Huxing
>
>


Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Jun Liu
YES

Jun

> On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> 
> Dear Dubbo PPMC members,
> 
> (bcc to all PPMC members)
> 
> The Dubbo community is discussing the graduation of Dubbo to be a Top
> Level project of Apache Software Foundation in the dev mailing list.
> As one of the steps towards graduation, the community needs to set up
> list of Project Management Committees (PMC) members after graduation,
> which will be included in the graduation resolution.
> 
> The role of the PMC is included as follows[1]:
> 
> The role of the PMC from a Foundation perspective is oversight. The
> main role of the PMC is not code and not coding - but to ensure that
> all legal issues are addressed, that procedure is followed, and that
> each and every release is the product of the community as a whole.
> That is key to our litigation protection mechanisms.
> 
> Secondly the role of the PMC is to further the long term development
> and health of the community as a whole, and to ensure that balanced
> and wide scale peer review and collaboration does happen. Within the
> ASF we worry about any community which centers around a few
> individuals who are working virtually uncontested. We believe that
> this is detrimental to quality, stability, and robustness of both code
> and long term social structures.
> 
> If you are willing to be a PMC member after graduation, please respond
> YES to this thread by replying to dev@dubbo.apache.org no later than
> 2019-04-12 (Friday).
> If you are not subscribing the private list, please remember to
> subscribe to the private@ list.
> 
> 
> [1] http://www.apache.org/foundation/how-it-works.html#pmc
> -- 
> Best Regards!
> Huxing



Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Huxing Zhang
YES

On Tue, Apr 9, 2019 at 10:12 AM Huxing Zhang  wrote:
>
> Dear Dubbo PPMC members,
>
> (bcc to all PPMC members)
>
> The Dubbo community is discussing the graduation of Dubbo to be a Top
> Level project of Apache Software Foundation in the dev mailing list.
> As one of the steps towards graduation, the community needs to set up
> list of Project Management Committees (PMC) members after graduation,
> which will be included in the graduation resolution.
>
> The role of the PMC is included as follows[1]:
>
> The role of the PMC from a Foundation perspective is oversight. The
> main role of the PMC is not code and not coding - but to ensure that
> all legal issues are addressed, that procedure is followed, and that
> each and every release is the product of the community as a whole.
> That is key to our litigation protection mechanisms.
>
> Secondly the role of the PMC is to further the long term development
> and health of the community as a whole, and to ensure that balanced
> and wide scale peer review and collaboration does happen. Within the
> ASF we worry about any community which centers around a few
> individuals who are working virtually uncontested. We believe that
> this is detrimental to quality, stability, and robustness of both code
> and long term social structures.
>
> If you are willing to be a PMC member after graduation, please respond
> YES to this thread by replying to dev@dubbo.apache.org no later than
> 2019-04-12 (Friday).
> If you are not subscribing the private list, please remember to
> subscribe to the private@ list.
>
>
> [1] http://www.apache.org/foundation/how-it-works.html#pmc
> --
> Best Regards!
> Huxing



-- 
Best Regards!
Huxing


[IMPORTANT][PPMC] Invitation to be Dubbo PMC member

2019-04-08 Thread Huxing Zhang
Dear Dubbo PPMC members,

(bcc to all PPMC members)

The Dubbo community is discussing the graduation of Dubbo to be a Top
Level project of Apache Software Foundation in the dev mailing list.
As one of the steps towards graduation, the community needs to set up
list of Project Management Committees (PMC) members after graduation,
which will be included in the graduation resolution.

The role of the PMC is included as follows[1]:

The role of the PMC from a Foundation perspective is oversight. The
main role of the PMC is not code and not coding - but to ensure that
all legal issues are addressed, that procedure is followed, and that
each and every release is the product of the community as a whole.
That is key to our litigation protection mechanisms.

Secondly the role of the PMC is to further the long term development
and health of the community as a whole, and to ensure that balanced
and wide scale peer review and collaboration does happen. Within the
ASF we worry about any community which centers around a few
individuals who are working virtually uncontested. We believe that
this is detrimental to quality, stability, and robustness of both code
and long term social structures.

If you are willing to be a PMC member after graduation, please respond
YES to this thread by replying to dev@dubbo.apache.org no later than
2019-04-12 (Friday).
If you are not subscribing the private list, please remember to
subscribe to the private@ list.


[1] http://www.apache.org/foundation/how-it-works.html#pmc
-- 
Best Regards!
Huxing