Re: [ANN] Apache Dubbo as a Top-level project

[Imteyaz Khan]

Congratulation.

On Tue, May 21, 2019 at 11:35 AM Xin Wang  wrote:

> Congratulations!
>
>
> ding peng  于2019年5月21日周二 下午1:06写道：
>
> > Congratulations!
> >
> > BRs
> > moriadry
> >
> >
> > > On May 21, 2019, at 10:57 AM, YunKun Huang  wrote:
> > >
> > > Congratulations !
> > > : )
> > >
> > > Huxing Zhang  于2019年5月21日周二 上午10:53写道：
> > >
> > >> Hi,
> > >>
> > >> Today ASF officially announced Apache Dubbo as a Top-level project[1].
> > >> Congratulations to Dubbo!
> > >>
> > >> [1]
> > >>
> >
> https://blogs.apache.org/foundation/entry/the-apache-software-foundation-announces52
> > >>
> > >> --
> > >> Best Regards！
> > >> Huxing
> > >>
> >
> >
>

Re: [VOTE] Apache Dubbo graduation to Top Level Project

[Imteyaz Khan]

+1 to graduate as a TLP.

On Friday, April 19, 2019, Yuhao Bi  wrote:

> +1 to graduate as a TLP.
>
> 雷舜宇  于2019年4月19日周五 上午10:18写道：
>
> > +1to graduate as a TLP.
> >
> > YunKun Huang  于2019年4月19日周五 上午10:12写道：
> >
> > > +1 to recommend graduation of Apache Dubbo as a TLP
> > >
> > > yuhang xiu  于2019年4月19日周五 上午10:00写道：
> > >
> > > > +1 to graduate as a TLP.
> > > >
> > > > Jerrick Zhu  于2019年4月19日周五 上午9:01写道：
> > > >
> > > > > +1 to graduate as a TLP.
> > > > >
> > > > > Huxing Zhang  于2019年4月18日周四 下午8:24写道：
> > > > >
> > > > > > Hi All,
> > > > > >
> > > > > > After a discussion in the Apache Dubbo community on the dev
> mailing
> > > > > > list[1], choosing PMC chair[2], forming the PMC members[3],
> > > completing
> > > > > > the maturity model[4], and discussing the resolution
> proposal[5], I
> > > > > > would like to call a vote for Apache Dubbo graduating to a top
> > level
> > > > > > project.
> > > > > >
> > > > > > Please vote on the proposal to graduate Dubbo as TLP to submit to
> > the
> > > > > > Incubator PMC.
> > > > > >
> > > > > > Vote:
> > > > > > [ ] +1 - Recommend graduation of Apache Dubbo as a TLP
> > > > > > [ ] -1 - Do not recommend graduation of Apache Dubbo because ….
> > > > > >
> > > > > > The VOTE is open for a minimum of 72 hours.
> > > > > >
> > > > > > [1]
> > > > > >
> > > > >
> > > >
> > >
> > https://lists.apache.org/thread.html/767da61f249789f09665a52a241e3b
> 352d168fec051ee7dd1dd7c20b@%3Cdev.dubbo.apache.org%3E
> > > > > > [2]
> > > > > >
> > > > >
> > > >
> > >
> > https://lists.apache.org/thread.html/537a7a88ab19ffee31c0b642ff6239
> 372aa063985846febe2ad11d91@%3Cdev.dubbo.apache.org%3E
> > > > > > [3]
> > > > > >
> > > > >
> > > >
> > >
> > https://lists.apache.org/thread.html/b7218b3b441f7a96e1d339e1eeea60
> e8bba9b06295e73b56659524c0@%3Cdev.dubbo.apache.org%3E
> > > > > > [4]
> > > > > >
> > > > >
> > > >
> > >
> > https://github.com/apache/incubator-dubbo/wiki/Apache-
> Maturity-Model-Assessment-for-Dubbo
> > > > > > [5]
> > > > > >
> > > > >
> > > >
> > >
> > https://lists.apache.org/thread.html/2b9fb2c565656308dcce5281c5352d
> a41d5aabc56020af084c6888d3@%3Cdev.dubbo.apache.org%3E
> > > > > >
> > > > > > -
> > > > > > Establish the Apache Dubbo Project
> > > > > >
> > > > > > WHEREAS, the Board of Directors deems it to be in the best
> > interests
> > > of
> > > > > > the Foundation and consistent with the Foundation's purpose to
> > > > establish
> > > > > > a Project Management Committee charged with the creation and
> > > > maintenance
> > > > > > of open-source software, for distribution at no charge to the
> > public,
> > > > > > related to a high-performance, lightweight, java based RPC
> > framework.
> > > > > >
> > > > > > NOW, THEREFORE, BE IT RESOLVED, that a Project Management
> Committee
> > > > > > (PMC), to be known as the "Apache Dubbo Project", be and hereby
> is
> > > > > > established pursuant to Bylaws of the Foundation; and be it
> further
> > > > > >
> > > > > > RESOLVED, that the Apache Dubbo Project be and hereby is
> > responsible
> > > > for
> > > > > > the creation and maintenance of software related to a
> > > high-performance,
> > > > > > lightweight, java based RPC framework; and be it further
> > > > > >
> > > > > > RESOLVED, that the office of "Vice President, Apache Dubbo" be
> and
> > > > > > hereby is created, the person holding such office to serve at the
> > > > > > direction of the Board of Directors as the chair of the Apache
> > Dubbo
> > > > > > Project, and to have primary responsibility for management of the
> > > > > > projects within the scope of responsibility of the Apache Dubbo
> > > > Project;
> > > > > > and be it further
> > > > > >
> > > > > > RESOLVED, that the persons listed immediately below be and hereby
> > are
> > > > > > appointed to serve as the initial members of the Apache Dubbo
> > > Project:
> > > > > >
> > > > > >  * Huxing Zhang   
> > > > > >  * Ian Luo
> > > > > >  * Jun Liu
> > > > > >  * Justin Mclean  
> > > > > >  * Kimm King  
> > > > > >  * Liang Zhang
> > > > > >  * Liujie Qin 
> > > > > >  * Mercy Ma   
> > > > > >  * Minxuan Zhuang 
> > > > > >  * Shang Zonghai  
> > > > > >  * Von Gosling
> > > > > >  * Xin Wang   
> > > > > >  * Yong Zhu   
> > > > > >  * Yuhang Xiu 
> > > > > >  * YunKun Huang   
> > > > > >
> > > > > > NOW, THEREFORE, BE IT FURTHER RESOLVED, that Ian Luo be appointed
> > to
> > > > the
> > > > > > office of Vice President, Apache Dubbo, to serve in accordance
> with
> > > and
> > > > > > subject to the direction of the Board of Directors and the Bylaws
> > of
> > > > the
> > > > > > Foundation until death, resignation, retirement, removal or
> > > > > > disqualification, or until a successor is appointed; and be it
> > > further
> > > > > >
> > > > > > RESOLVED, that the Apache Dubbo Project be and hereby is tasked
> > with
> > > > the
> > > > > > migration and rationalization of the Apache Incubator 

Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

[Imteyaz Khan]

Huxing,
  Thanks I will have a look.

Regards
Imteyaz

On Mon, Apr 15, 2019 at 8:06 AM Huxing Zhang  wrote:

> Hi Imteyaz,
>
> The invitation is sent to all the PPMCs. :)
> Please refer to here[1] to see more introduction to the ASF roles.
>
> [1] https://www.apache.org/foundation/how-it-works.html#roles
>
> On Fri, Apr 12, 2019 at 2:04 AM Imteyaz Khan 
> wrote:
> >
> > YES
> >
> > On Thu, Apr 11, 2019 at 9:35 PM Mark Thomas  wrote:
> >
> > > On 09/04/2019 03:12, Huxing Zhang wrote:
> > >
> > > > If you are willing to be a PMC member after graduation, please
> respond
> > > > YES to this thread by replying to dev@dubbo.apache.org no later than
> > > > 2019-04-12 (Friday).
> > > > If you are not subscribing the private list, please remember to
> > > > subscribe to the private@ list.
> > >
> > > I'll probably continue to lurk on the private@ list (and maybe the
> dev@
> > > list) after graduation but I do not wish to be on the PMC.
> > >
> > > Mark
> > >
>
>
>
> --
> Best Regards！
> Huxing
>

Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

[Imteyaz Khan]

YES

On Thu, Apr 11, 2019 at 9:35 PM Mark Thomas  wrote:

> On 09/04/2019 03:12, Huxing Zhang wrote:
>
> > If you are willing to be a PMC member after graduation, please respond
> > YES to this thread by replying to dev@dubbo.apache.org no later than
> > 2019-04-12 (Friday).
> > If you are not subscribing the private list, please remember to
> > subscribe to the private@ list.
>
> I'll probably continue to lurk on the private@ list (and maybe the dev@
> list) after graduation but I do not wish to be on the PMC.
>
> Mark
>

Re: [ANN] Welcome new committer: Imteyaz Khan

[Imteyaz Khan]

Hi All,
  Thanks for your continued support and which has helped me to contribute
more. My name is Imteyaz and I am based on Bengalore,India and working in a
product development company.

Till end of this month I would occupied with some personal and official
assignment as last 3 months has been with me. I believe post that will be
able to continue as earlier.

Once again thanks for your support and Honor.

Regards
Imteyaz

On Tue, Apr 2, 2019 at 8:02 AM Ian Luo  wrote:

> Welcome to join us, Khan :)
>
> Cheers,
> -Ian.
>
> On Mon, Apr 1, 2019 at 10:19 AM Huxing Zhang  wrote:
>
> > Hi Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Imteyaz Khan,
> > a.k.a. khanimteyaz[1], has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Imteyaz, would you please briefly introduce yourself to the community?
> >
> > [1] https://github.com/khanimteyaz
> > --
> > Best Regards！
> > Huxing
> >
>

Re: [ANN] New PPMC member: Yunkun Huang

[Imteyaz Khan]

congratulations.

On Friday, February 22, 2019, zhongming hua  wrote:

> Congratulations！
>
> Huxing Zhang 于2019年2月22日 周五20:21写道：
>
> > Hi Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Yunkun
> Huang[1]
> > has been voted in as a new Dubbo PPMC member.
> >
> > Please join me to say congratulations to him!
> >
> > [1] https://github.com/htynkn
> > --
> > Best Regards！
> > Huxing
> >
>

Re: [ANN] New PPMC member: Minxuan Zhuang

[Imteyaz Khan]

Congratulations

On Monday, February 18, 2019, 柯振旭  wrote:

> Congratulations!!
>
>
>
>
>
>
>
>
> 在 2019-02-18 14:00:59，"Chen ZhiGuo"  写道：
> >Congratulations！！
> >
> >在 2019/2/18 13:40，“xxz” 写入:
> >
> >Congratulations！！
> >
> >
> >
> >
> >| |
> >xxz
> >邮箱：xxz...@126.com
> >|
> >
> >Signature is customized by Netease Mail Master
> >
> >On 02/18/2019 13:37, Huxing Zhang wrote:
> >Hi Community,
> >
> >On behalf of the Dubbo PPMC, I am pleased to announce that Minxuan
> Zhuang[1]
> >has been voted in as a new Dubbo PPMC member.
> >
> >Please join me to say congratulations to him!
> >
> >[1] https://github.com/nzomkxia
> >--
> >Best Regards！
> >Huxing
> >
> >
>

Re: [ANN] Welcome new committer: Zhongming Hua

[Imteyaz Khan]

Congratulations.

On Friday, February 15, 2019, LiZhenNet  wrote:

> Congratulations
>
> Taosheng, Wei  于2019年2月15日周五 上午10:15写道：
>
> > Congratulations and welcome!
> >
> >
> >
> >
> > -- Original --
> > From: Huxing Zhang 
> > Date: Fri,Feb 15,2019 10:12 AM
> > To: dev 
> > Subject: Re: [ANN] Welcome new committer: Zhongming Hua
> >
> >
> >
> > Hi Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Zhongming Hua,
> > a.k.a. CrazyHZM[1], has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Zhongming, would you please briefly introduce yourself to the community?
> >
> > [1] https://github.com/CrazyHZM
> >
> > --
> > Best Regards！
> > Huxing
>

Re: [ANN] Welcome new committer: Xiaojie Li

[Imteyaz Khan]

Congratulations.

On Thu, Feb 14, 2019 at 12:05 PM jun liu  wrote:

> Congratulations!
>
> Jun
>
> > On Feb 14, 2019, at 2:24 PM, Huxing Zhang  wrote:
> >
> > Hi Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Xiaojie Li,
> > a.k.a. lixiaojiee[1], has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Xiaojie, would you please briefly introduce yourself to the community?
> >
> > [1] https://github.com/lixiaojiee
> >
> > --
> > Best Regards！
> > Huxing
>
>

Re: Happy Chinese New Year

[Imteyaz Khan]

Happy new year to all of you.

On Sunday, February 3, 2019, jun liu  wrote:

> 新年快乐，恭喜发财！
>
> Happy Chinese New Year.
>
> Jun
>
> > On Feb 3, 2019, at 9:55 AM, Huxing Zhang  wrote:
> >
> > Hi All,
> >
> > Feb 4th - Feb 10th is the Chinese new year, I believe most of the
> > people will be on vacation during this period, or even several days
> > later, so please expect slow response on mailing list, GitHub issues
> > and etc. :)
> >
> > Last, happy Chinese new year!
> >
> > --
> > Best Regards！
> > Huxing
>
>

Re: [ANN] Welcome new committer: Yuhao Bi

[Imteyaz Khan]

congratulations...

On Sunday, February 3, 2019, Yuhao Bi  wrote:

> Thank you very much everyone!
>
> My name is Yuhao Bi. It's an honor to be part of the family!
> I work for a cybersecurity company in Chengdu.
> I will continue to contribute and grow up with the community.
>
> Thanks again and Happy Chinese New Year!
> Yuhao Bi
>
>
> 李 晓杰  于2019年2月3日周日 上午11:09写道：
>
> > Congratulations and welcome to join us.
> >
> > 获取 Outlook for iOS
> >
> > 
> > 发件人: Xin Wang 
> > 发送时间: 星期日, 二月 3, 2019 10:54
> > 收件人: dev@dubbo.apache.org
> > 主题: Re: [ANN] Welcome new committer: Yuhao Bi
> >
> > congratulations
> >
> > 在 2019年2月3日星期日，Ian Luo  写道：
> >
> > > Congratulations.
> > >
> > > On Sun, Feb 3, 2019 at 9:35 AM Huxing Zhang  wrote:
> > >
> > > > Hi Community,
> > > >
> > > > On behalf of the Dubbo PPMC, I am pleased to announce that Yuhao Bi,
> > > > a.k.a. biyuhao[1], has been voted in as a new Dubbo committer.
> > > >
> > > > Please join me to say congratulations to him!
> > > >
> > > > Yuhao, would you please briefly introduce yourself to the community?
> > > >
> > > > [1] https://github.com/biyuhao
> > > >
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> > >
> >
>

Re: [DISCUSS]: Some thoughts on What Dubbo 3.0 is, we really should start it ASAP

[Imteyaz Khan]

+1 in the suggestion.

On Saturday, February 2, 2019, Ian Luo  wrote:

> I am thinking of firing an issue on Github to collect 3.0 wishlist from the
> community. What do you say?
>
> -Ian.
>
>
>
>
> On Sat, Feb 2, 2019 at 6:12 AM Kun Song  wrote:
>
> > I especially interested in reactive programming and cloud native support.
> >
> > A reactive Dubbo will be attractive, as the community point out. I even
> > propose to make Dubbo implements the Reactive Streams specification,
> which
> > will integrate back pressure(flow control) and make Dubbo a choice for
> > stream processing(which is a booming area). Stream processing has many
> > advantages such as better resource utilization, as far as I know, Java
> > 9/RxJava/Akka-Streams have already implements Reactive Streams spec, and
> > have already gained great success.
> >
> > Of course cloud native support is a must, we should do it, and HTTP 2 &
> > RSocket are also interesting feature to me.
> >
> > When decide what features Dubbo 3 should have, I think we can make each
> > feature a proposal, which could including motivation/proposed
> > changes/interfaces/compatibility/deprecation/test plan …, so more
> > contributors can get involved in it.
> >
> >
> > [1] http://www.reactive-streams.org/ 
> >
> > > 在 2019年1月28日，下午10:44，Ian Luo  > ian@gmail.com>> 写道：
> > >
> > > Agree, we should consider seriously both HTTP/2 and rsocket.
> > >
> > > Thanks,
> > > -Ian.
> > >
> > >
> > > On Thu, Jan 24, 2019 at 10:59 AM Taosheng, Wei <
> weitaosh...@foxmail.com
> > >
> > > wrote:
> > >
> > >> Lan,
> > >> Yes, I think http2 and some new protocols such as rsocket can be
> > >> considered.
> > >> I will spend some time to study this issue.
> > >>
> > >>
> > >> Warm regards,
> > >> Taosheng
> > >>
> > >>
> > >>
> > >>
> > >> -- Original --
> > >> From: Ian Luo mailto:ian@gmail.com>>
> > >> Date: Thu,Jan 24,2019 9:58 AM
> > >> To: dev mailto:dev@dubbo.apache.org>>
> > >> Subject: Re: [DISCUSS]: Some thoughts on What Dubbo 3.0 is, we really
> > >> should start it ASAP
> > >>
> > >>
> > >>
> > >> Taosheng,
> > >>
> > >> In this scenario, it looks like we should use http2 to transport the
> > >> payload, what do you think?
> > >>
> > >> Thanks,
> > >> -Ian.
> > >>
> > >> On Wed, Jan 23, 2019 at 10:35 PM Taosheng Wei <
> tswstarpla...@apache.org
> > >
> > >> wrote:
> > >>
> > >>> I think we can find a binary protocol with strong potential to be a
> > >> public
> > >>> application protocol like http, and extend it with security function.
> > Or
> > >> if
> > >>> there aren't such suitable protocols, we can try to formulate a new
> > >>> protocol. Then make Dubbo support it.
> > >>> In my opinion, this way may not only solve the security problems, but
> > >> also
> > >>> solve the cross-language RPC with Dubbo.
> > >>>
> > >>> zhi_guang_...@163.com  <
> > zhi_guang_...@163.com > 于2019年1月23日周三
> > 下午5:47写道：
> > >>>
> >  I have a similar Question as this mail:
> >  Is Dubbo designed for use on internet?
> >  I have just join a company last year and our business is all around
> > the
> >  world.
> >  So we have servers on US and ASIA and EU.
> >  In this condition we use dubbo on internet and keep security by
> > >> security
> >  rules that only allow the servers connect to each other.
> > 
> >  I think this is not a  pretty useage of dubbo，but I cann't find
> Strong
> >  evidences to change the situation.
> > 
> >  Can any one help me to answer this questions? Thanks a lot.
> > 
> > 
> > 
> >  --
> >  您的朋友：刘志广
> > 
> > 
> >  *From:* Yuhao Bi mailto:byh0...@gmail.com>>
> >  *Date:* 2019-01-22 22:55
> >  *To:* dev mailto:dev@dubbo.apache.org>>
> >  *Subject:* Re: [DISCUSS]: Some thoughts on What Dubbo 3.0 is, we
> > really
> >  should start it ASAP
> >  Hi lan and community,
> > 
> >  Although I have already heard "Dubbo" a few years ago,
> >  but I just started to learn dubbo after the meetup last year in
> > Chengdu
> >  after it became the Apache Dubbo.
> >  Maybe I'm not such that familiar with the underlying details, but
> > after
> >  the continuous participated
> >  I feel like a part of the community, and free to share my opinion.
> > 
> >  So, here is my question and also consider it my suggestion:
> >  Should we care more about Security? How can we prevent from
> > >> unauthorized
> >  remote call?
> >  - Should we support Authentication and Authorization
> >  - Should we add Spring Security or Active Directory Service support
> at
> > >>> the
> >  framework level
> > 
> >  Thanks,
> >  Yuhao
> > 
> > 
> >  jun liu mailto:ken.lj...@gmail.com>>
> > 于2019年1月22日周二 下午5:50写道：
> 

Re: a follow up on pull request 3274

[Imteyaz Khan]

yes plz.

On Fri, Feb 1, 2019 at 2:11 PM Ian Luo  wrote:

> bravo, should I start reviewing on main repo?
>
> Thanks,
> -Ian.
>
> On Fri, Feb 1, 2019 at 3:44 PM Imteyaz Khan 
> wrote:
>
> > Thanks Ian for looking into this. Your PR looks good to me. I have
> approved
> > it to my branch.
> >
> > On Fri, Feb 1, 2019 at 8:46 AM Ian Luo  wrote:
> >
> > > Imteyaz,
> > >
> > > Pls. review my pull request sent to your repo. You don't need to redo
> > from
> > > the scratch if you see my change appropriated.
> > >
> > > Thanks,
> > > -Ian.
> > >
> > >
> > > On Thu, Jan 31, 2019 at 8:37 PM Imteyaz Khan 
> > > wrote:
> > >
> > > > Exactly this was my thoughts as well. Any way I will change to simple
> > > date
> > > > format and will remove the date util.
> > > >
> > > > On Thursday, January 31, 2019, Ian Luo  wrote:
> > > >
> > > > > @khanimteyaz <https://github.com/khanimteyaz> I submitted a pull
> > > request
> > > > > khanimteyaz#11 <
> > https://github.com/khanimteyaz/incubator-dubbo/pull/11
> > > >
> > > > in
> > > > > your repository. Would you mind to take a look?
> > > > >
> > > > > My basic idea is: since we are now formatting date and time in
> single
> > > > > thread, it is safe to use a singleton formatter without any risk.
> > > > >
> > > > >
> > > > > Thanks,
> > > > >
> > > > > -Ian.
> > > > >
> > > >
> > >
> >
>

Re: a follow up on pull request 3274

[Imteyaz Khan]

Thanks Ian for looking into this. Your PR looks good to me. I have approved
it to my branch.

On Fri, Feb 1, 2019 at 8:46 AM Ian Luo  wrote:

> Imteyaz,
>
> Pls. review my pull request sent to your repo. You don't need to redo from
> the scratch if you see my change appropriated.
>
> Thanks,
> -Ian.
>
>
> On Thu, Jan 31, 2019 at 8:37 PM Imteyaz Khan 
> wrote:
>
> > Exactly this was my thoughts as well. Any way I will change to simple
> date
> > format and will remove the date util.
> >
> > On Thursday, January 31, 2019, Ian Luo  wrote:
> >
> > > @khanimteyaz <https://github.com/khanimteyaz> I submitted a pull
> request
> > > khanimteyaz#11 <https://github.com/khanimteyaz/incubator-dubbo/pull/11
> >
> > in
> > > your repository. Would you mind to take a look?
> > >
> > > My basic idea is: since we are now formatting date and time in single
> > > thread, it is safe to use a singleton formatter without any risk.
> > >
> > >
> > > Thanks,
> > >
> > > -Ian.
> > >
> >
>

Re: a follow up on pull request 3274

[Imteyaz Khan]

Exactly this was my thoughts as well. Any way I will change to simple date
format and will remove the date util.

On Thursday, January 31, 2019, Ian Luo  wrote:

> @khanimteyaz  I submitted a pull request
> khanimteyaz#11  in
> your repository. Would you mind to take a look?
>
> My basic idea is: since we are now formatting date and time in single
> thread, it is safe to use a singleton formatter without any risk.
>
>
> Thanks,
>
> -Ian.
>

Re: [Discuss] About Clean Code Plan

[Imteyaz Khan]

Ian,
  Thanks for summarizing this for me. I personally very excited about
this. 

On Wed, Jan 30, 2019 at 12:33 PM Ian Luo  wrote:

> Jason,
>
> Agree, and pls. join us and keep an eye on this area for us :)
>
> Thanks,
> -Ian.
>
>
> On Tue, Jan 29, 2019 at 3:38 PM Jason Joo  wrote:
>
> > Hi, lan
> >
> > Agree with you.
> >
> > It's great for shorter, cleaner, more efficient logic optimizing. So I
> > suggest that modifications including grammar sugar purposed for shorter,
> > cleaner or more efficient are great but not just rewriting with another
> > form. I surely will not object it, too.
> >
> > But pay attention to some features or new styles that will generate more
> > objects.
> >
> > I think it would be more simple and easy we organize these as a kind of
> > issue. Focused and small PRs are easy to review after all.
> >
> > best regards,
> >
> > Jason
> >
> > > On Jan 29, 2019, at 14:38, Ian Luo  wrote:
> > >
> > > Jason,
> > >
> > > Totally agree with you on this point. We should focus less on grammar
> > sugar
> > > but focus more on make the code clean, for say: divide long method into
> > > shorter methods, better naming, or better doc, or even better design.
> > >
> > > But on the other hand, if someone from the community shows enthusiasm
> for
> > > updating code with new sugar, I will not object to the effort as long
> as
> > it
> > > doesn't hurt readability, after all it is low hanging fruit :)
> > >
> > > What I propose is we should gather all possible ideas and group them in
> > one
> > > project on GitHub [1], like I said in my previous email. It is critical
> > to
> > > make the code clean as much as possible in my opinion. It deserves one
> > > dedicated project to track all ideas. By doing this, the community can
> > also
> > > understand the current focuses are.
> > >
> > > So my question is, should we init a project focusing on clean code,
> while
> > > the purpose doesn't limit to grammar sugar?
> > >
> > > Regards,
> > > -Ian.
> > >
> > > 1. https://github.com/apache/incubator-dubbo/projects
> > >
> > > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo  wrote:
> > >
> > >> Hi, Huxing & LiZhen
> > >>
> > >> Things like diamond is something called grammar SUGAR.
> > >> Tasted good for developers but the same on byte code.
> > >>
> > >> So in my opinion we should not take it as a kind of "policy correct".
> > >> we can make the changes in the code of recent PRs but not for all the
> > >> code. Think about there may be more sugars in future JVM.
> > >>
> > >> best regards,
> > >>
> > >> Jason
> > >>
> > >>> On Jan 29, 2019, at 10:42, yuhang xiu  wrote:
> > >>>
> > >>> Your pr has modified more than 30,000 lines of code, and most of them
> > are
> > >>> modifications of the entire file.
> > >>> What is the meaning of your pr? Why do I need to keep it open?
> > >>>
> > >>> If you need to discuss, issues and mailing lists are good choices,
> why
> > do
> > >>> you need to discuss pr?
> > >>>
> > >>> Who can review this pr[1] and tell me what this pr is going to do?
> > >>>
> > >>> [1] https://github.com/apache/incubator-dubbo/pull/3371
> > >>>
> > >>> LiZhenNet  于2019年1月29日周二 上午10:29写道：
> > >>>
> >  Yes, we can create a project to manage it, and we can talk about it.
> > >> like:
> >  Should we used Diamond Operator replace  explicit type? Use Lambda?
> >  Let's discuss the two pull requests above instead of closed it
> > >> immediately.
> > 
> > 
> > 
> > 
> > 
> >  Huxing Zhang  于2019年1月29日周二 上午9:58写道：
> > 
> > > Hi,
> > >
> > > Nice suggestion!
> > >
> > > Shall we can create a project to manage it?
> > >
> > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> >  wrote:
> > >>
> > >> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >  unused
> > >> methods ,unused logic , nonstandard naming  in the code. And there
> > are
> > > some
> > >> code that can use the new features of java to make the code more
> >  concise
> > >> and understandable. like Lambda , Diamond Operator and so on.These
> > are
> > > easy
> > >> to find and fixed because of the tips of the idea .We should do it
> >  before
> > >> completing the incubation.
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> > 
> > >>
> > >>
> >
> >
>

Re: [ANN] Welcome new committer: Kun Song

[Imteyaz Khan]

Congratulations .

On Wed, Jan 30, 2019 at 12:25 PM Mercy  wrote:

> Congratulations! 
>
> Kind regards,
> Mercy Ma
>
> 在 2019/1/30 上午10:01, Huxing Zhang 写道:
> > Hi Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Kun Song,
> > a.k.a. satansk[1], has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Kun, would you please briefly introduce yourself to the community?
> >
> > [1] https://github.com/satansk
> >
>

Re: [Discuss] About Clean Code Plan

[Imteyaz Khan]

sorry I was not following the thread actively so might have missed
something.  how are planning the clean code approach as module by module or
will start with any new code modifications wise ?

On Tuesday, January 29, 2019, LiZhenNet  wrote:

> +1 ,
> Grammar sugar can easily be fixed by using Idea's Analyze. What deserves
> attention is the duplicate code and logic optimization.
>
>
> Jason Joo  于2019年1月29日周二 下午3:38写道：
>
> > Hi, lan
> >
> > Agree with you.
> >
> > It's great for shorter, cleaner, more efficient logic optimizing. So I
> > suggest that modifications including grammar sugar purposed for shorter,
> > cleaner or more efficient are great but not just rewriting with another
> > form. I surely will not object it, too.
> >
> > But pay attention to some features or new styles that will generate more
> > objects.
> >
> > I think it would be more simple and easy we organize these as a kind of
> > issue. Focused and small PRs are easy to review after all.
> >
> > best regards,
> >
> > Jason
> >
> > > On Jan 29, 2019, at 14:38, Ian Luo  wrote:
> > >
> > > Jason,
> > >
> > > Totally agree with you on this point. We should focus less on grammar
> > sugar
> > > but focus more on make the code clean, for say: divide long method into
> > > shorter methods, better naming, or better doc, or even better design.
> > >
> > > But on the other hand, if someone from the community shows enthusiasm
> for
> > > updating code with new sugar, I will not object to the effort as long
> as
> > it
> > > doesn't hurt readability, after all it is low hanging fruit :)
> > >
> > > What I propose is we should gather all possible ideas and group them in
> > one
> > > project on GitHub [1], like I said in my previous email. It is critical
> > to
> > > make the code clean as much as possible in my opinion. It deserves one
> > > dedicated project to track all ideas. By doing this, the community can
> > also
> > > understand the current focuses are.
> > >
> > > So my question is, should we init a project focusing on clean code,
> while
> > > the purpose doesn't limit to grammar sugar?
> > >
> > > Regards,
> > > -Ian.
> > >
> > > 1. https://github.com/apache/incubator-dubbo/projects
> > >
> > > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo  wrote:
> > >
> > >> Hi, Huxing & LiZhen
> > >>
> > >> Things like diamond is something called grammar SUGAR.
> > >> Tasted good for developers but the same on byte code.
> > >>
> > >> So in my opinion we should not take it as a kind of "policy correct".
> > >> we can make the changes in the code of recent PRs but not for all the
> > >> code. Think about there may be more sugars in future JVM.
> > >>
> > >> best regards,
> > >>
> > >> Jason
> > >>
> > >>> On Jan 29, 2019, at 10:42, yuhang xiu  wrote:
> > >>>
> > >>> Your pr has modified more than 30,000 lines of code, and most of them
> > are
> > >>> modifications of the entire file.
> > >>> What is the meaning of your pr? Why do I need to keep it open?
> > >>>
> > >>> If you need to discuss, issues and mailing lists are good choices,
> why
> > do
> > >>> you need to discuss pr?
> > >>>
> > >>> Who can review this pr[1] and tell me what this pr is going to do?
> > >>>
> > >>> [1] https://github.com/apache/incubator-dubbo/pull/3371
> > >>>
> > >>> LiZhenNet  于2019年1月29日周二 上午10:29写道：
> > >>>
> >  Yes, we can create a project to manage it, and we can talk about it.
> > >> like:
> >  Should we used Diamond Operator replace  explicit type? Use Lambda?
> >  Let's discuss the two pull requests above instead of closed it
> > >> immediately.
> > 
> > 
> > 
> > 
> > 
> >  Huxing Zhang  于2019年1月29日周二 上午9:58写道：
> > 
> > > Hi,
> > >
> > > Nice suggestion!
> > >
> > > Shall we can create a project to manage it?
> > >
> > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> >  wrote:
> > >>
> > >> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >  unused
> > >> methods ,unused logic , nonstandard naming  in the code. And there
> > are
> > > some
> > >> code that can use the new features of java to make the code more
> >  concise
> > >> and understandable. like Lambda , Diamond Operator and so on.These
> > are
> > > easy
> > >> to find and fixed because of the tips of the idea .We should do it
> >  before
> > >> completing the incubation.
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> > 
> > >>
> > >>
> >
> >
>

Re: [ANN] Welcome new committer: Xianjun Ke

[Imteyaz Khan]

Congratulations...

On Friday, January 25, 2019, Xianjun Ke  wrote:

> Hi community,
> It's an honor for me to become a committer of Dubbo.
> My name is Xianjun Ke,working in HangZhou caocaokeji as a senior software
> engineer.
> I'll keep contributing to the community,let's make Apache Duddo better and
> better.
>
> Taosheng, Wei  于2019年1月25日周五 上午11:56写道：
>
> > Congratulations  and welcome :)
> >
> >
> >
> >
> > -- Original --
> > From: LiZhenNet 
> > Date: Fri,Jan 25,2019 11:48 AM
> > To: dev 
> > Subject: Re: [ANN] Welcome new committer: Xianjun Ke
> >
> >
> >
> > Congratulations ,  Thanks for your advices for my pull request.
> >
> > yuhang xiu  于2019年1月25日周五 上午11:46写道：
> >
> > > Hi, xianjun, I think your review is great and gives a lot of valuable
> > > advice.
> > > Congratulations on becoming a committer!
> > >
> > > Huxing Zhang  于2019年1月25日周五 上午11:40写道：
> > >
> > > > Hi Community,
> > > >
> > > > On behalf of the Dubbo PPMC, I am pleased to announce that Xianjun
> Ke,
> > > > a.k.a. kexianjun[1], has been voted in as a new Dubbo committer.
> > > >
> > > > Please join me to say congratulations to him!
> > > >
> > > > Xianjun, would you please briefly introduce yourself to the
> community?
> > > >
> > > > [1] https://github.com/kexianjun
> > > >
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> > >
>

Re: [ANN] Welcome new committer: Taosheng Wei

[Imteyaz Khan]

Congratulation, thank you for your contributions.

On Wed, Jan 23, 2019 at 1:04 PM 华 钟明  wrote:

> Congratulations, thank you for your contribution.
>
> Zhongming Hua
>
>
>
> 在 2019/1/23 下午3:31，“LiZhenNet” 写入:
>
> Congratulations
>
> Yuhao Bi  于2019年1月23日周三 下午2:56写道：
>
> > Congratulations to you and thank you for your contribution!
> >
> > Taosheng, Wei  于2019年1月23日周三 下午2:47写道：
> >
> > > Hi community,
> > > I am honored to become part of Apache Dubbo community.
> > > My name is Taosheng Wei, I am in Beijing. I am a server software
> > engineer,
> > > working in a financial technology corporation focusing fund
> clearing of
> > > online pay.
> > > I will keep contributing to the community. Let’s do our best to
> make
> > > Apache Dubbo community better and better.
> > >
> > >
> > > Best regards,
> > > Taosheng
> > >
> > >
> > >
> > >
> > >
> > > -- Original --
> > > From: Huxing Zhang 
> > > Date: Wed,Jan 23,2019 2:07 PM
> > > To: dev 
> > > Subject: Re: [ANN] Welcome new committer: Taosheng Wei
> > >
> > >
> > >
> > > Hi Community,
> > >
> > > On behalf of the Dubbo PPMC, I am pleased to announce that
> Taosheng Wei,
> > > a.k.a. tswstarplanet[1], has been voted in as a new Dubbo
> committer.
> > >
> > > Please join me to say congratulations to him!
> > >
> > > Taosheng, would you please briefly introduce yourself to the
> community?
> > >
> > > [1] https://github.com/tswstarplanet
> > >
> > > --
> > > Best Regards！
> > > Huxing
> >
>
>

Re: Ordering in dubbo call

[Imteyaz Khan]

Should we support considering this as an feature in dubbo. Where driven by
configuration provider can gurantee order of its invocation against a
ordering *key*. Here I might have though very loud but as it come to my
mind so though to share with community as this could also become a
differenciating feature. Correct me if I am wrong.

On Mon, Jan 21, 2019 at 7:58 AM Ian Luo  wrote:

> Imteyaz,
>
> Let me try to answer your question. In your example, the order of the
> executions will not be guaranteed. The implementation of the service should
> guarantee it in no matter what the way is.
>
> 1) If the update address happens 2 times will they be executed in ordered
> > fasion (If it is async)
> >
>
> Depend on which call is received, put into the thread pool, and get
> executed first.
>
>
> > 2) If say if the first update stuck then second call not execute untill
> > first one not clear or gets executed.
>
>
> The second will not be stuck by the first unless the service implementation
> has synchronization.
>
>
> On Fri, Jan 18, 2019 at 11:49 PM Imteyaz Khan 
> wrote:
>
> > It was mine bad, I should have provided more details. I was looking for
> > information about how serialization of call or ordering against a call in
> > context of a key happen in dubbo. e.g. lets say I have a person service
> > with the capability of user address update, now this service get 2 call
> for
> > same user address update.
> > The information I am looking for how things will work in the below
> mention
> > case
> >
> > 1) If the update address happens 2 times will they be executed in ordered
> > fasion (If it is async)
> > 2) If say if the first update stuck then second call not execute untill
> > first one not clear or gets executed.
> >
> > Please do let me know, if I have failed to explained my above example
> > clearly.
> >
> >
> >
> >
> > On Fri, Jan 18, 2019 at 12:30 PM 田 小波 
> wrote:
> >
> > > Hi,
> > >
> > > Hi All,
> > > Could someone point me to any doc or material or with any
> information
> > > which can help me to understand the ordering of invocation in dubbo and
> > how
> > > it works?
> > >
> > > This article[1] analyzes Dubbo's calling process in detail, but
> > > unfortunately, this article is only available in Chinese.
> > > For non-native Chinese speakers, please translate via Chrome or Google
> > > Translate.
> > >
> > > [1]
> > >
> >
> http://dubbo.apache.org/zh-cn/docs/source_code_guide/service-invoking-process.html
> > >
> > > Regards,
> > > Xiaobo
> > >
> > >
> >
>

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[Imteyaz Khan]

Thanks a lot Jun.

On Tue, Jan 22, 2019 at 5:51 PM Ian Luo  wrote:

> Awesome. Thank you, Jun.
>
> -Ian.
>
> On Tue, Jan 22, 2019 at 5:53 PM jun liu  wrote:
>
> > 2.7.0-release has just been merged into master, please help to review.
> >
> > Jun
> >
> > > On Jan 21, 2019, at 10:42 AM, Xin Wang 
> wrote:
> > >
> > >> I am merging back the 2.7.0-release branch to master to avoid having
> too
> > > many conflicts if do it too late, then we may need to constantly do the
> > > merge with every few days before vote is done.
> > >
> > > Support this , then everyone can review the code on the master branch ,
> > > and find some issues earlier
> > >
> > > jun liu  于2019年1月21日周一 上午10:21写道：
> > >
> > >> I am merging back the 2.7.0-release branch to master to avoid having
> too
> > >> many conflicts if do it too late, then we may need to constantly do
> the
> > >> merge with every few days before vote is done.
> > >>
> > >> Jun
> > >>
> > >>> On Jan 18, 2019, at 2:28 PM, Huxing Zhang  wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> I still found some inconsistency between the source release and the
> > >>> Git tag dubbo-2.7.0:
> > >>>
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release: all
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release: bom
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release:
> dependencies-bom
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release: distribution
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release: dubbo-bootstrap
> > >>> Only in
> > >>
> >
> apache-dubbo-incubating-2.7.0-source-release/dubbo-config/dubbo-config-spring/src/test/resources:
> > >>> work
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release/dubbo-demo:
> > >>> dubbo-demo-consumer
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release/dubbo-demo:
> > >>> dubbo-demo-provider
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release/dubbo-metrics:
> > >>> dubbo-metrics-default
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release/dubbo-test:
> > >>> dubbo-test-benchmark
> > >>> Only in apache-dubbo-incubating-2.7.0-source-release/dubbo-test:
> > >>> dubbo-test-examples
> > >>>
> > >>> It is possibly due to my local environment, I am going to do it again
> > >>> with clean checkout of Dubbo 2.7.0-release branch.
> > >>>
> > >>> On Fri, Jan 18, 2019 at 10:25 AM Huxing Zhang 
> > wrote:
> > 
> >  Hi,
> > 
> >  I found that there is a file test.patch in source release, which was
> >  the patch I used to restore the commit I reverted yesterday.
> >  This is not what we want, I am going to remove this file and
> > re-tagging
> > >> 2.7.0.
> > 
> > 
> >  On Fri, Jan 18, 2019 at 9:47 AM Huxing Zhang 
> > wrote:
> > >
> > > Hi,
> > >
> > > On Fri, Jan 18, 2019 at 12:08 AM jun liu 
> > wrote:
> > >>
> > >>> Jun, could you please summarize an English version of the release
> > >> note.
> > >>> I will send the vote email once it is done.
> > >>
> > >> It’s now available here:
> > >>
> >
> https://github.com/apache/incubator-dubbo/blob/2.7.0-release/CHANGES.md#270
> > >
> > > Thanks for that, it looks good to me.
> > >
> > >> I think it’s time to prepare the upgrade guide and user docs now,
> > >> which is also a key part for this release.
> > >
> > > Yes, we can do that while we are doing the release vote.
> > >
> > > I am starting the vote today.
> > >>
> > >> Jun
> > >>
> > >>> On Jan 17, 2019, at 11:58 PM, Huxing Zhang 
> > >> wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> All the preparation seems going well.
> > >>> I have successfully uploaded 2.7.0 to staging repo, and upload
> the
> > >>> release candidate to svn.
> > >>> I saw that the release note is still in Chinese.
> > >>>
> > >>> Jun, could you please summarize an English version of the release
> > >> note.
> > >>> I will send the vote email once it is done.
> > >>>
> > >>> On Thu, Jan 17, 2019 at 5:48 PM victory 
> > >> wrote:
> > 
> >  I have check the file , it is the same as pull request #3263.
> > 
> > 
> >  Huxing Zhang  于2019年1月17日周四 下午5:34写道：
> > 
> > > Hi Victory,
> > >
> > > I've mistakenly reverted your recent pull request[1].
> > > Luckily I have restored it via the commit email message.
> > > I've push it to 2.7.0-release branch already.
> > > Would you please help to check it?
> > >
> > >
> > > [1] https://github.com/apache/incubator-dubbo/pull/3263
> > >
> > > On Thu, Jan 17, 2019 at 5:08 PM victory  >
> > >> wrote:
> > >>
> > >> I have review the code and it work well in
> > >>
> > >
> > >>
> >
> https://github.com/apache/incubator-dubbo-samples/tree/samples-for-2.7.0-SNAPSHOT/dubbo-samples-configcenter/dubbo-samples-configcenter-apollo
> > >>
> > >> 

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 0.2.1 and 0.1.2 [RC2]

[Imteyaz Khan]

+1.

On Mon, Jan 21, 2019 at 9:40 AM Chen ZhiGuo  wrote:

> +1
>
> Sent from my iPhone
>
> > On Jan 21, 2019, at 11:44, zhangxin525252  wrote:
> >
> > +1
> >
> >
> > 发自我的iPhone
> >
> > -- Original --
> > From: jun liu 
> > Date: Mon,Jan 21,2019 11:31 AM
> > To: dev 
> > Subject: Re: [VOTE]: Release Apache Dubbo Spring Boot Project
> (Incubating) 0.2.1 and 0.1.2 [RC2]
> >
> >
> >
> > +1 binding
> >
> > I checked both 0.1.2 and 0.2.1:
> >
> > * Signatures are good for both source and binary release
> > * No binary file in source release
> > * ‘Incubating’ in name
> > * All files have good license header: mvn clean compile -DskipTests
> -Drat.skip=false -Dcheckstyle.skip=false
> > * Can compile from source and all UT can pass: mvn clean test
> > * Source release can match with corresponding tag except for few
> expecting missing files.
> > * LICENSE, NOTICE and DISCLAIMER exist
> >
> > Jun
> >
> >> On Jan 15, 2019, at 2:54 PM, Mercy Ma  wrote:
> >>
> >> Hello Dubbo Community,
> >>
> >> This is a call for the vote to release Apache Dubbo Spring Boot Project
> >> (Incubating) versions 0.2.1(Spring Boot 2.x) and 0.1.2(Spring Boot 1.x).
> >>
> >> The release candidates:
> >> 0.2.1:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.2.1/
> >> 0.1.2:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.1.2/
> >>
> >> Git tag for the release:
> >> 0.2.1:
> >>
> https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.2.1-release
> >> 0.1.2:
> >>
> https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.1.2-release
> >>
> >> Hash for the release tag:
> >> 0.2.1: 79e9fa899b74324a8e83d00aac10e3d899b8c3f8
> >> 0.1.2: cb66ba32400986609f9e00b0d160173e7b2f55d2
> >>
> >> Release Notes:
> >> 0.2.1:
> >>
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.2.1
> >> 0.1.2:
> >>
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.1.2
> >>
> >> The artifacts have been signed with Key: 28681CB1, which can be found in
> >> the keys file:
> >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> >>
> >> The vote will be open for at least 72 hours or until the necessary
> number
> >> of votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thanks,
> >> The Apache Dubbo (Incubating) Team
>

Re: AccessLogFilter simple date format instance creation change PR

[Imteyaz Khan]

Thanks. Sure looking into it.

On Mon, Jan 21, 2019 at 8:08 AM Ian Luo  wrote:

> Imteyaz,
>
> I am on your pull request. I drop one comment, would you mind to take a
> look?
>
> Thanks,
> -Ian.
>
>
> On Sat, Jan 19, 2019 at 3:58 AM Imteyaz Khan 
> wrote:
>
> > Hi All,
> >PR which I raised mentioned in email thread, due to recent changes it
> > encounters some conflicts and after resolving and taking latest pull it
> was
> > showing 500+ file chages (It might I have not done it right way :). To
> > avoide confusion I have closed existing one and created new on. This new
> > *PR
> > <https://github.com/apache/incubator-dubbo/pull/3274>*has all the
> changes
> > till date which I have incorporated as review feedback.
> >
> > In my old PR <https://github.com/apache/incubator-dubbo/pull/3090>there
> > was
> > request changes asked by @zonghaishang <https://github.com/zonghaishang>
> > (Not
> > thread safe implementation), which I beleive I have addressed as there
> was
> > also about making thread safe and reducing the creation of
> > SimpleDateFormat.
> >
> > Old PR link : https://github.com/apache/incubator-dubbo/pull/3090
> > New PR link :https://github.com/apache/incubator-dubbo/pull/3274
> >
> > Once again sorry for the inconvenience, and would request review my PR.
> >
> > Regards
> > Imteyaz
> >
> > On Sat, Dec 29, 2018 at 11:58 AM yuhang xiu  wrote:
> >
> > > Hi, @beiwei @khan
> > >
> > > There have been a lot of things in recent work.
> > > After the end of New Year's Day, I believe that there will be more time
> > to
> > > work in the community, I am very sorry.
> > >
> > > I will dispose of this PR next week. @khan
> > > :)
> > >
> > > Ian Luo  于2018年12月29日周六 上午11:14写道：
> > >
> > > > I took a glance at the latest change. It looks good to me since we
> > avoid
> > > of
> > > > using thread-local and new instance for every incoming request,
> instead
> > > one
> > > > singleton date formatter runs in one single thread, which I totally
> > agree
> > > > with.
> > > >
> > > > Let's wait for Yuhang's review comments :)
> > > >
> > > > -Ian.
> > > >
> > > >
> > > > On Sat, Dec 29, 2018 at 12:11 AM Imteyaz Khan <
> khan.imte...@gmail.com>
> > > > wrote:
> > > >
> > > > > Due to my own confusion and bad I found I found my PR is containing
> > > more
> > > > > commits and more file modification other than mine. So avoid the
> > > > confusion
> > > > > I created new PR and close the old one. This PR containing the all
> > the
> > > > > review comments from old PR. Please review mine this PR
> > > > > <https://github.com/apache/incubator-dubbo/pull/3090>
> > > > >
> > > > >
> > > > > https://github.com/apache/incubator-dubbo/pull/3090
> > > > >
> > > > > Sorry for the inconvenience caused.
> > > > >
> > > > >
> > > > > On Thu, Dec 27, 2018 at 3:24 PM yuhang xiu 
> > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > I simply checked your pr and I agree with you. I will review it.
> > > > > > Nice work!
> > > > > >
> > > > > > Imteyaz Khan  于2018年12月27日周四 下午5:35写道：
> > > > > >
> > > > > > > Hi All,
> > > > > > >   I have raised a separate PR for the same issue 3026.
> > > > > > >
> > > > > > > https://github.com/apache/incubator-dubbo/pull/3080
> > > > > > >
> > > > > > > As my old PR was containing may commits of others and reviewer
> > > would
> > > > > like
> > > > > > > me to clear those commits and I tried hard to achieve the same
> > but
> > > > > failed
> > > > > > > so landed up creating new PR
> > > > > > > <https://github.com/apache/incubator-dubbo/pull/3080>.
> > > > > > >
> > > > > > > Please note :: older PR
> > > > > > > <https://github.com/apache/incubator-dubbo/pull/3027> 3027 has
> > > been
> > > > > > closed
> > > > > > > but all the comments are applicable here.
> > > > > > >
> > > > > > > On Thu, Dec 20, 2018 at 5:35 PM Imteyaz Khan <
> > > khan.imte...@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi All,
> > > > > > > >   I have raised a PR <
> > > > > > > https://github.com/apache/incubator-dubbo/pull/3027>for
> > > > > > > > issue 3026 <
> > > https://github.com/apache/incubator-dubbo/issues/3026
> > > > >.
> > > > > In
> > > > > > > > this PR , I am reducing the  number of SimpleDateFormat
> object
> > > > > creation
> > > > > > > > from each log message to per thread wise and reusing it.
> Please
> > > > > review
> > > > > > > it.
> > > > > > > >
> > > > > > > > https://github.com/apache/incubator-dubbo/pull/3027
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: AccessLogFilter simple date format instance creation change PR

[Imteyaz Khan]

Hi All,
   PR which I raised mentioned in email thread, due to recent changes it
encounters some conflicts and after resolving and taking latest pull it was
showing 500+ file chages (It might I have not done it right way :). To
avoide confusion I have closed existing one and created new on. This new *PR
<https://github.com/apache/incubator-dubbo/pull/3274>*has all the changes
till date which I have incorporated as review feedback.

In my old PR <https://github.com/apache/incubator-dubbo/pull/3090>there was
request changes asked by @zonghaishang <https://github.com/zonghaishang> (Not
thread safe implementation), which I beleive I have addressed as there was
also about making thread safe and reducing the creation of SimpleDateFormat.

Old PR link : https://github.com/apache/incubator-dubbo/pull/3090
New PR link :https://github.com/apache/incubator-dubbo/pull/3274

Once again sorry for the inconvenience, and would request review my PR.

Regards
Imteyaz

On Sat, Dec 29, 2018 at 11:58 AM yuhang xiu  wrote:

> Hi, @beiwei @khan
>
> There have been a lot of things in recent work.
> After the end of New Year's Day, I believe that there will be more time to
> work in the community, I am very sorry.
>
> I will dispose of this PR next week. @khan
> :)
>
> Ian Luo  于2018年12月29日周六 上午11:14写道：
>
> > I took a glance at the latest change. It looks good to me since we avoid
> of
> > using thread-local and new instance for every incoming request, instead
> one
> > singleton date formatter runs in one single thread, which I totally agree
> > with.
> >
> > Let's wait for Yuhang's review comments :)
> >
> > -Ian.
> >
> >
> > On Sat, Dec 29, 2018 at 12:11 AM Imteyaz Khan 
> > wrote:
> >
> > > Due to my own confusion and bad I found I found my PR is containing
> more
> > > commits and more file modification other than mine. So avoid the
> > confusion
> > > I created new PR and close the old one. This PR containing the all the
> > > review comments from old PR. Please review mine this PR
> > > <https://github.com/apache/incubator-dubbo/pull/3090>
> > >
> > >
> > > https://github.com/apache/incubator-dubbo/pull/3090
> > >
> > > Sorry for the inconvenience caused.
> > >
> > >
> > > On Thu, Dec 27, 2018 at 3:24 PM yuhang xiu  wrote:
> > >
> > > > Hi,
> > > >
> > > > I simply checked your pr and I agree with you. I will review it.
> > > > Nice work!
> > > >
> > > > Imteyaz Khan  于2018年12月27日周四 下午5:35写道：
> > > >
> > > > > Hi All,
> > > > >   I have raised a separate PR for the same issue 3026.
> > > > >
> > > > > https://github.com/apache/incubator-dubbo/pull/3080
> > > > >
> > > > > As my old PR was containing may commits of others and reviewer
> would
> > > like
> > > > > me to clear those commits and I tried hard to achieve the same but
> > > failed
> > > > > so landed up creating new PR
> > > > > <https://github.com/apache/incubator-dubbo/pull/3080>.
> > > > >
> > > > > Please note :: older PR
> > > > > <https://github.com/apache/incubator-dubbo/pull/3027> 3027 has
> been
> > > > closed
> > > > > but all the comments are applicable here.
> > > > >
> > > > > On Thu, Dec 20, 2018 at 5:35 PM Imteyaz Khan <
> khan.imte...@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > > > Hi All,
> > > > > >   I have raised a PR <
> > > > > https://github.com/apache/incubator-dubbo/pull/3027>for
> > > > > > issue 3026 <
> https://github.com/apache/incubator-dubbo/issues/3026
> > >.
> > > In
> > > > > > this PR , I am reducing the  number of SimpleDateFormat object
> > > creation
> > > > > > from each log message to per thread wise and reusing it. Please
> > > review
> > > > > it.
> > > > > >
> > > > > > https://github.com/apache/incubator-dubbo/pull/3027
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Ordering in dubbo call

[Imteyaz Khan]

It was mine bad, I should have provided more details. I was looking for
information about how serialization of call or ordering against a call in
context of a key happen in dubbo. e.g. lets say I have a person service
with the capability of user address update, now this service get 2 call for
same user address update.
The information I am looking for how things will work in the below mention
case

1) If the update address happens 2 times will they be executed in ordered
fasion (If it is async)
2) If say if the first update stuck then second call not execute untill
first one not clear or gets executed.

Please do let me know, if I have failed to explained my above example
clearly.




On Fri, Jan 18, 2019 at 12:30 PM 田 小波  wrote:

> Hi,
>
> Hi All,
> Could someone point me to any doc or material or with any information
> which can help me to understand the ordering of invocation in dubbo and how
> it works?
>
> This article[1] analyzes Dubbo's calling process in detail, but
> unfortunately, this article is only available in Chinese.
> For non-native Chinese speakers, please translate via Chrome or Google
> Translate.
>
> [1]
> http://dubbo.apache.org/zh-cn/docs/source_code_guide/service-invoking-process.html
>
> Regards,
> Xiaobo
>
>

Ordering in dubbo call

[Imteyaz Khan]

Hi All,
 Could someone point me to any doc or material or with any information
which can help me to understand the ordering of invocation in dubbo and how
it works?



Regards
Imteyaz

My schedule plan for current next week

[Imteyaz Khan]

Hi,
   Due to some urgent works, most of the time I was busy in organization
delivery related stuff and might be the situation will be for next week.
So I might  be less involve this and next week. Will try to allocate some
time (If I get :) ) for code review and going through dubbo dev  emails.

I would request if community can review my raised PR
 . If this PR looks
good to you then we can merge otherwise will try to incoporate the feedback
as and when time permiste me in these two week.

Regards
Imteyaz

Re: [External]Re: Propose to use robot to generate weekly report of Dubbo

[Imteyaz Khan]

A kudos to this feature and to enabler of this feature.

On Mon, Jan 7, 2019 at 2:49 PM ss宋顺  wrote:

> This looks really promising! Looking forward to more updates!
>
>
> On 07/01/2019, 16:52, "赵生宇"  wrote:
>
> >Hi,
> >
> >
> >For pull request review, actually GitHub provides API to get the review
> data, see:
> https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request
> , so the review statistics count all merged prs and still open prs in the
> project in passed week.
> >
> >
> >For other features, you can submit feature request issues to
> https://github.com/AlibabaDR/Collabobot and we can discuss on GitHub,
> actually the bot can get all data of the project and any kind of data
> presentation is quite easy to accomplish.
> >
> >
> >You can deploy this robot for any project on GitHub, I will continue to
> add some core features to it for collaborate convenience.
> >
> >
> >--
> >
> >FrankZhao
> >Tel: 086-18513109194
> >Email: syzhao1...@126.com
> >
> >
> >At 2019-01-07 13:50:55, "Huxing Zhang"  wrote:
> >>Hi,
> >>
> >>This looks awesome!
> >>
> >>To me, this weekly report shows some interesting data that I am
> >>looking for before.
> >>
> >>I especially like the "Code Review Statistics", this reports shows
> >>some hidden places where the contributions are made but failed to be
> >>noticed.
> >>
> >>I have one quick question, how did you count the pull request reviews,
> >>are you counting by the number of review comments, or by the number of
> >>pull request participated?
> >>
> >>In addition, I am thinking of some new metric, for example, the number
> >>of comments left in Github issues, which can measure how active a
> >>Github user is to the project.
> >>
> >>I also think we can add statistics to other projects, e.g. dubbo-ops,
> >>dubbo-website, dubbo-spring-boot-project, dubbo-samples.
> >>
> >>On Mon, Jan 7, 2019 at 11:32 AM 赵生宇  wrote:
> >>>
> >>> Hello,
> >>>
> >>>
> >>> I am a developer from Alibaba and build a robot(
> https://github.com/AlibabaDR/Collabobot) to collaborate with GitHub repos
> which can auto generate weekly report for repos.
> >>>
> >>>
> >>> The template issue is like this
> https://github.com/apache/incubator-dubbo/issues/3152 and the propose
> issue is https://github.com/apache/incubator-dubbo/issues/3153 .
> >>>
> >>>
> >>> Look forward to having your opinions.
> >>>
> >>>
> >>> --
> >>>
> >>> FrankZhao
> >>> Tel: 086-18513109194
> >>> Email: syzhao1...@126.com
> >>
> >>
> >>
> >>--
> >>Best Regards！
> >>Huxing
>

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[Imteyaz Khan]

Ian,
Thanks a lot for clearing my confusion.



On Monday, January 7, 2019, jun liu  wrote:

> >>
> >> Nice work!
> >>
> >> I think we should let the community to participate more in the release
> >> process, for example,
> >> 1. check out a release branch called 2.7.0-release
> >> 2. encourage people to check it out, test it and report if there is
> >> any regressions, bugs or issues.
> >> 3. while we are doing the test, we can start going through the ASF
> >> release process locally, once we think it is ready to start a formal
> >> release note, it can be done very quickly.
> >>
> >> By the way, we need decide the release manager of 2.7.0 release. Is
> >> there anyone who volunteer to do that?
>
> Sorry, I missed this mail.
> * 2.7.0-release has been created
> * we've froze the codebase, test is underway.
>
> > I'd like to be the release manager if no one is claiming it.
>
> Great, I can help you with the source/binary packaging and tagging things.
>
> Jun
>
> > On Jan 5, 2019, at 12:11 PM, Huxing Zhang  wrote:
> >
> > Hi,
> >
> > On Fri, Dec 28, 2018 at 10:45 AM Huxing Zhang  wrote:
> >>
> >> Nice work!
> >>
> >> I think we should let the community to participate more in the release
> >> process, for example,
> >> 1. check out a release branch called 2.7.0-release
> >> 2. encourage people to check it out, test it and report if there is
> >> any regressions, bugs or issues.
> >> 3. while we are doing the test, we can start going through the ASF
> >> release process locally, once we think it is ready to start a formal
> >> release note, it can be done very quickly.
> >>
> >> By the way, we need decide the release manager of 2.7.0 release. Is
> >> there anyone who volunteer to do that?
> >
> > I'd like to be the release manager if no one is claiming it.
> >>
> >> On Thu, Dec 27, 2018 at 11:53 PM jun liu  wrote:
> >>>
> >>> Hi, All
> >>>
> >>> I am writing this mail to
> >>>
> >>> * Keep you refreshed of the latest status about v2.7.0.
> >>> * Call for efforts on code review and tests
> >>> * Discuss possible release schedules of v2.7.0.
> >>>
> >>> About v2.7, it’s going to be a milestone version, in which will make
> some significant changes. Most importantly, we will complete all IP
> Clearance related works. Technically speaking, it’s from this version on
> that a Dubbo release starts fully follows the Apache rules (lawfully),
> totally independent from any other third-party organizations or companies.
> Secondly, this version will include many new features that have received
> wide attention from the community, by supporting these features, we can
> better resolve the community’s long accumulated demands. Last but not
> least, we have made some architectural changes in this version, made Dubbo
> closer to the micro-service architecture, take the newly introduced
> configuration center as an example, it can work both as the center of
> Externalized Configuration at startup and as the center of service
> management configurations at runtime.
> >>>
> >>> To summarize, the contents already included in the CodeBase are:
> >>>
> >>> * Config Center: Zookeeper, Apollo, Nacos
> >>> * Externalized Configuration
> >>> * Service governance enhancement: dynamic configuration & routing rule
> >>> * Repackage to 'org.apache.dubbo'
> >>> * Java 8 support
> >>> * Async programming support
> >>>
> >>> Most of the candidates listed above are in the proposal list that we
> have discussed in some threads before. For a more detailed description of
> these features or how they are realized, you can refer to the draft
> development documentations within this link[1]
> >>>
> >>> Thanks to the efforts from the community (especially thank to Ian,
> CVictory and Minxuan), most of the development work has been completed and
> a round of code review and regression test based on some basic use cases
> have been completed[2].
> >>> Now I think it's time to prepare the formal release. One most
> important thing I think we should pay attention to is stability. We should
> guarantee it's stable enough before release, so we may need to put more
> effort into code review and functional testing. Based on my understanding
> of the CodeBase, such tests may at least continue to last for about 1 week,
> during this period we may need to `freeze the code`, which means only
> optimization and bugfix will be allowed. After that, we can continue to
> evaluate when to start the formal vote process.
> >>>
> >>> 1. https://github.com/apache/incubator-dubbo/issues/2919
> >>> 2. https://github.com/apache/incubator-dubbo-samples/tree/
> samples-for-2.7.0-SNAPSHOT
> >>>
> >>> Jun
> >>>
> >>
> >>
> >> --
> >> Best Regards！
> >> Huxing
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
>
>

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[Imteyaz Khan]

Not saying wrong or unallowed. What I mean to say as part of release
process, do we need to provide any document if we are using
com.alibaba.fastjson package in our code or we have to replace it. This a
question from me not an any conclusion :) .


On Fri, Jan 4, 2019 at 1:54 PM LiZhenNet  wrote:

> What's wrong about it ?  Is fastjson unallowed used in Dubbo？
>
> Imteyaz Khan  于2019年1月4日周五 下午2:04写道：
>
> > Yes. import statement refer to package com.alibaba.fastjson, below are
> the
> > search result
> >
> > The Search "com.alibaba.fastjson" (14 hits in 11 files)
> >
> >
> dubbo\dubbo-cluster\src\test\java\org\apache\dubbo\rpc\cluster\loadbalance\LoadBalanceBaseTest.java
> > (1 hit)
> > Line 32: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-common\src\main\java\org\apache\dubbo\common\utils\StringUtils.java
> > (1 hit)
> > Line 24: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-compatible\src\test\java\org\apache\dubbo\generic\GenericServiceTest.java
> > (1 hit)
> > Line 36: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-metadata-report\dubbo-metadata-report-api\src\test\java\org\apache\dubbo\metadata\support\AbstractMetadataReportFactoryTest.java
> > (1 hit)
> > Line 25: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-rpc\dubbo-rpc-api\src\main\java\org\apache\dubbo\rpc\filter\AccessLogFilter.java
> > (1 hit)
> > Line 33: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-rpc\dubbo-rpc-api\src\main\java\org\apache\dubbo\rpc\support\MockInvoker.java
> > (1 hit)
> > Line 34: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-rpc\dubbo-rpc-dubbo\src\main\java\org\apache\dubbo\rpc\protocol\dubbo\filter\TraceFilter.java
> > (1 hit)
> > Line 32: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-rpc\dubbo-rpc-dubbo\src\main\java\org\apache\dubbo\rpc\protocol\dubbo\telnet\InvokeTelnetHandler.java
> > (2 hits)
> > Line 30: import com.alibaba.fastjson.JSON;
> > Line 31: import com.alibaba.fastjson.JSONObject;
> >
> >
> dubbo\dubbo-serialization\dubbo-serialization-fastjson\src\main\java\org\apache\dubbo\common\serialize\fastjson\FastJsonObjectInput.java
> > (1 hit)
> > Line 22: import com.alibaba.fastjson.JSON;
> >
> >
> dubbo\dubbo-serialization\dubbo-serialization-fastjson\src\main\java\org\apache\dubbo\common\serialize\fastjson\FastJsonObjectOutput.java
> > (3 hits)
> > Line 21: import com.alibaba.fastjson.serializer.JSONSerializer;
> > Line 22: import com.alibaba.fastjson.serializer.SerializeWriter;
> > Line 23: import com.alibaba.fastjson.serializer.SerializerFeature;
> >
> >
> > On Fri, Jan 4, 2019 at 8:29 AM jun liu  wrote:
> >
> > > Hi,
> > >
> > > Are there any IP Clearance work that need to be done but we have
> missed?
> > >
> > > Jun
> > >
> > > > On Jan 4, 2019, at 10:56 AM, jun liu  wrote:
> > > >
> > > > Hi,
> > > >
> > > > I have created a new branch ‘2.7.0-release’, this branch will work as
> > > the codebase of v2.7.0, for stability purpose, I think we should code
> > > freeze the codebase, so please only submit necessary bugfix or
> > enhancement
> > > patches to this branch.
> > > >
> > > > Activity can go as normal on master branch.
> > > >
> > > > For detailed release candidates of v2.7.0 I will search the commit
> > > history and sort them out, will send to this thread once it’s done.
> > > >
> > > > Jun
> > > >
> > > >> On Dec 27, 2018, at 11:53 PM, jun liu  > > ken.lj...@gmail.com>> wrote:
> > > >>
> > > >> Hi, All
> > > >>
> > > >> I am writing this mail to
> > > >>
> > > >> * Keep you refreshed of the latest status about v2.7.0.
> > > >> * Call for efforts on code review and tests
> > > >> * Discuss possible release schedules of v2.7.0.
> > > >>
> > > >> About v2.7, it’s going to be a milestone version, in which will make
> > > some significant changes. Most importantly, we will complete all IP
> > > Clearance related works. Technically speaking, it’s from this version
> on
> > > that a Dubbo release starts fully follows the Apache rules (lawfully),
> > > totally independent from any other third-party organizations or
> > companies.
> > > Secondly, this version will include many new features that have
> received

Re: slow on pull request and issue

[Imteyaz Khan]

Thanks for looking into this.

On Fri, Jan 4, 2019 at 1:25 PM yuhang xiu  wrote:

> Hi, all
>
> Recently we have completed the phased tasks and I will have more time to
> continue our community work.
>
> Working on this now:
> https://github.com/apache/incubator-dubbo/pull/3090
>
> LiZhenNet  于2019年1月3日周四 下午6:33写道：
>
> > I agree ， Currently the community relies on the committer from  alibaba
> >
> >
> > Huxing Zhang  于2019年1月3日周四 上午11:27写道：
> >
> > > Hi,
> > >
> > > I've noticed that the response time is slow for Dubbo's core
> > > repository, including reviewing pull request, issue triage and issue
> > > cleanup, it seems that not everyone has enough time to deal with
> > > things like this.
> > >
> > > My idea is to identify the active contributors of the community, and
> > > invite to become a committer, let more people come in and help. In
> > > addition, we should also use robot to help us.
> > >
> > > The problem is how to find such people, I think it can be collected by
> > > the data, such as GitHub activities, how often do they participate in
> > > the discussion, how often do they participate in the review code.
> > >
> > > Furthermore, I think that people who often send pull requests, and
> > > those who often participate in the community, may be two types of
> > > people. The former requires large amount of  time, and the latter can
> > > participate using their fragmented time.
> > >
> > > For example, if I want to send a pr, I need to understand an issue,
> > > fix, test, which takes a lot of time. However,  leaving a message on
> > > the issue, labelling an issue, or closing the issue, these tasks can
> > > be done small granularity.
> > >
> > > Maybe we know a lot about the first type of people, but we need to
> > > identify and discover the second type of people and let them come in
> > > to help manage the community.
> > >
> > >
> > >
> > >
> >
> 最近Dubbo的仓库，响应比较慢，包括pr的review，issue的分类和清理，似乎没有人处理。我的想法是发展一部分活跃的contributor成为committer，让更多的人参与进来一起帮忙。另外机器人也要参与进来。现在的问题是要找到这样的人，我觉得可以通过数据反映出来，比如GitHub上经常参加讨论的，经常参与review代码的。
> > >
> > > 另外我觉得经常提pull request的人，和经常参与社区的人，可能是两类人，前者对时间的的颗粒度要求很高，后者对时间颗粒度的要求度低。
> > >
> > > 比如我要提一个pr，需要理解一个issue,
> > > 修复，测试，需要花较大的时间，而在issue上留个言，打个label，close下issue，对时间的要求相对较低。
> > >
> > > 我们对第一类人的了解是比较多的，但需要识别和发现第二类人，让他们进来帮助管理社区。
> > >
> > > On Sat, Dec 29, 2018 at 5:13 PM Ian Luo  wrote:
> > > >
> > > > Hello folks,
> > > >
> > > > I'd like to apologize first since recently we are slow on issue and
> > pull
> > > > request. We are very busy on ramping up Dubbo 2.7.0 which is expected
> > to
> > > be
> > > > public available soon. I hope we could come back in one or two weeks
> so
> > > > depending on how soon we could finish. The code review for dubbo
> 2.7.0
> > > > release is happening now on Github pull request. Feel free to join us
> > to
> > > > raise issue or submit pull request against the recent code changes on
> > the
> > > > master branch.
> > > >
> > > > You are also very welcomed to interact on other issues and pull
> > requests
> > > > irrelevant to release 2.7.0. They are piling up and we can do nothing
> > > right
> > > > now :)
> > > >
> > > > I really hope we can ramp up release 2.7.0 very soon, and your
> > > > comments/efforts are appreciated. After that, I plan to continue the
> > > > discussion on release 3.0.
> > > >
> > > > Cheers,
> > > > -Ian.
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> >
>

PR raised for dubbo-config-spring

[Imteyaz Khan]

Hi All,
  I have raised PR for
dubbo-config-spring. This PR include changes for

DubboNamespaceHandler.java-- remove hard coded values wirh constants, so
that in future it is more controlled and avoid accidental bug to happens.

ServiceBean.java -- Readability enhancement by refactoring long method with
meaning full sub methods.


Please review my below PR.
https://github.com/apache/incubator-dubbo/pull/3139

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[Imteyaz Khan]

Yes. import statement refer to package com.alibaba.fastjson, below are the
search result

The Search "com.alibaba.fastjson" (14 hits in 11 files)
 
dubbo\dubbo-cluster\src\test\java\org\apache\dubbo\rpc\cluster\loadbalance\LoadBalanceBaseTest.java
(1 hit)
Line 32: import com.alibaba.fastjson.JSON;
 dubbo\dubbo-common\src\main\java\org\apache\dubbo\common\utils\StringUtils.java
(1 hit)
Line 24: import com.alibaba.fastjson.JSON;
 
dubbo\dubbo-compatible\src\test\java\org\apache\dubbo\generic\GenericServiceTest.java
(1 hit)
Line 36: import com.alibaba.fastjson.JSON;
 
dubbo\dubbo-metadata-report\dubbo-metadata-report-api\src\test\java\org\apache\dubbo\metadata\support\AbstractMetadataReportFactoryTest.java
(1 hit)
Line 25: import com.alibaba.fastjson.JSON;
 
dubbo\dubbo-rpc\dubbo-rpc-api\src\main\java\org\apache\dubbo\rpc\filter\AccessLogFilter.java
(1 hit)
Line 33: import com.alibaba.fastjson.JSON;
 
dubbo\dubbo-rpc\dubbo-rpc-api\src\main\java\org\apache\dubbo\rpc\support\MockInvoker.java
(1 hit)
Line 34: import com.alibaba.fastjson.JSON;
 
dubbo\dubbo-rpc\dubbo-rpc-dubbo\src\main\java\org\apache\dubbo\rpc\protocol\dubbo\filter\TraceFilter.java
(1 hit)
Line 32: import com.alibaba.fastjson.JSON;
 
dubbo\dubbo-rpc\dubbo-rpc-dubbo\src\main\java\org\apache\dubbo\rpc\protocol\dubbo\telnet\InvokeTelnetHandler.java
(2 hits)
Line 30: import com.alibaba.fastjson.JSON;
Line 31: import com.alibaba.fastjson.JSONObject;
 
dubbo\dubbo-serialization\dubbo-serialization-fastjson\src\main\java\org\apache\dubbo\common\serialize\fastjson\FastJsonObjectInput.java
(1 hit)
Line 22: import com.alibaba.fastjson.JSON;
 
dubbo\dubbo-serialization\dubbo-serialization-fastjson\src\main\java\org\apache\dubbo\common\serialize\fastjson\FastJsonObjectOutput.java
(3 hits)
Line 21: import com.alibaba.fastjson.serializer.JSONSerializer;
Line 22: import com.alibaba.fastjson.serializer.SerializeWriter;
Line 23: import com.alibaba.fastjson.serializer.SerializerFeature;


On Fri, Jan 4, 2019 at 8:29 AM jun liu  wrote:

> Hi,
>
> Are there any IP Clearance work that need to be done but we have missed?
>
> Jun
>
> > On Jan 4, 2019, at 10:56 AM, jun liu  wrote:
> >
> > Hi,
> >
> > I have created a new branch ‘2.7.0-release’, this branch will work as
> the codebase of v2.7.0, for stability purpose, I think we should code
> freeze the codebase, so please only submit necessary bugfix or enhancement
> patches to this branch.
> >
> > Activity can go as normal on master branch.
> >
> > For detailed release candidates of v2.7.0 I will search the commit
> history and sort them out, will send to this thread once it’s done.
> >
> > Jun
> >
> >> On Dec 27, 2018, at 11:53 PM, jun liu  ken.lj...@gmail.com>> wrote:
> >>
> >> Hi, All
> >>
> >> I am writing this mail to
> >>
> >> * Keep you refreshed of the latest status about v2.7.0.
> >> * Call for efforts on code review and tests
> >> * Discuss possible release schedules of v2.7.0.
> >>
> >> About v2.7, it’s going to be a milestone version, in which will make
> some significant changes. Most importantly, we will complete all IP
> Clearance related works. Technically speaking, it’s from this version on
> that a Dubbo release starts fully follows the Apache rules (lawfully),
> totally independent from any other third-party organizations or companies.
> Secondly, this version will include many new features that have received
> wide attention from the community, by supporting these features, we can
> better resolve the community’s long accumulated demands. Last but not
> least, we have made some architectural changes in this version, made Dubbo
> closer to the micro-service architecture, take the newly introduced
> configuration center as an example, it can work both as the center of
> Externalized Configuration at startup and as the center of service
> management configurations at runtime.
> >>
> >> To summarize, the contents already included in the CodeBase are:
> >>
> >> * Config Center: Zookeeper, Apollo, Nacos
> >> * Externalized Configuration
> >> * Service governance enhancement: dynamic configuration & routing rule
> >> * Repackage to 'org.apache.dubbo'
> >> * Java 8 support
> >> * Async programming support
> >>
> >> Most of the candidates listed above are in the proposal list that we
> have discussed in some threads before. For a more detailed description of
> these features or how they are realized, you can refer to the draft
> development documentations within this link[1]
> >>
> >> Thanks to the efforts from the community (especially thank to Ian,
> CVictory and Minxuan), most of the development work has been completed and
> a round of code review and regression test based on some basic use cases
> have been completed[2].
> >> Now I think it's time to prepare the formal release. One most important
> thing I think we should pay attention to is stability. We should guarantee
> it's stable enough before release, so we may need to put more effort into
> code review and functional testing. Based on my 

Re: slow on pull request and issue

[Imteyaz Khan]

+1 on this.

One suggestion,as I see there are currently 162 contributor for dubbo
core.  Lots of people who has participated in long past and may not be
active in community in recent past may be due to some reason. Do you should
we get in touch with them for their feedback as well support for community?

This is just an suggestion from my side and as being new in open source
community, I might express some ideas which may not be appropriate. So
please correct me.



On Thursday, January 3, 2019, Huxing Zhang  wrote:

> Hi,
>
> I've noticed that the response time is slow for Dubbo's core
> repository, including reviewing pull request, issue triage and issue
> cleanup, it seems that not everyone has enough time to deal with
> things like this.
>
> My idea is to identify the active contributors of the community, and
> invite to become a committer, let more people come in and help. In
> addition, we should also use robot to help us.
>
> The problem is how to find such people, I think it can be collected by
> the data, such as GitHub activities, how often do they participate in
> the discussion, how often do they participate in the review code.
>
> Furthermore, I think that people who often send pull requests, and
> those who often participate in the community, may be two types of
> people. The former requires large amount of  time, and the latter can
> participate using their fragmented time.
>
> For example, if I want to send a pr, I need to understand an issue,
> fix, test, which takes a lot of time. However,  leaving a message on
> the issue, labelling an issue, or closing the issue, these tasks can
> be done small granularity.
>
> Maybe we know a lot about the first type of people, but we need to
> identify and discover the second type of people and let them come in
> to help manage the community.
>
>
> 最近Dubbo的仓库，响应比较慢，包括pr的review，issue的分类和清理，似乎没有人处理。
> 我的想法是发展一部分活跃的contributor成为committer，让更多的人参与进来一起帮忙。
> 另外机器人也要参与进来。现在的问题是要找到这样的人，我觉得可以通过数据反映出来，比如GitHub上经常参加讨论的，经常参与review代码的。
>
> 另外我觉得经常提pull request的人，和经常参与社区的人，可能是两类人，前者对时间的的颗粒度要求很高，后者对时间颗粒度的要求度低。
>
> 比如我要提一个pr，需要理解一个issue,
> 修复，测试，需要花较大的时间，而在issue上留个言，打个label，close下issue，对时间的要求相对较低。
>
> 我们对第一类人的了解是比较多的，但需要识别和发现第二类人，让他们进来帮助管理社区。
>
> On Sat, Dec 29, 2018 at 5:13 PM Ian Luo  wrote:
> >
> > Hello folks,
> >
> > I'd like to apologize first since recently we are slow on issue and pull
> > request. We are very busy on ramping up Dubbo 2.7.0 which is expected to
> be
> > public available soon. I hope we could come back in one or two weeks so
> > depending on how soon we could finish. The code review for dubbo 2.7.0
> > release is happening now on Github pull request. Feel free to join us to
> > raise issue or submit pull request against the recent code changes on the
> > master branch.
> >
> > You are also very welcomed to interact on other issues and pull requests
> > irrelevant to release 2.7.0. They are piling up and we can do nothing
> right
> > now :)
> >
> > I really hope we can ramp up release 2.7.0 very soon, and your
> > comments/efforts are appreciated. After that, I plan to continue the
> > discussion on release 3.0.
> >
> > Cheers,
> > -Ian.
>
>
>
> --
> Best Regards！
> Huxing
>

Re: PR raised for dubbo-config-api

[Imteyaz Khan]

Ian, I have incorporated the changes, could you have a look and provide me
your feedback.

On Wed, Jan 2, 2019 at 3:08 PM Imteyaz Khan  wrote:

> Sure. I appreciate you comment and I am on it.
>
> On Wed, Jan 2, 2019 at 2:49 PM Ian Luo  wrote:
>
>> Imteyaz,
>>
>> The change looks good to me, but I have a minor comment on your change.
>> Would you mind to take a look?
>>
>> Thanks,
>> -Ian.
>>
>> On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan 
>> wrote:
>>
>> > Hi All,
>> >   I have raised PR  <
>> https://github.com/apache/incubator-dubbo/pull/3108>
>> > for
>> > dubbo-config-api. In this PR have replaced the pending hard coded values
>> > with constant so that we can minimize accidental issue due to hard coded
>> > value used in multiple places. I have created the issue (3107
>> > <https://github.com/apache/incubator-dubbo/issues/3107>) for the same.
>> >
>> > Please review.
>> >
>> > https://github.com/apache/incubator-dubbo/pull/3108
>> >
>>
>

Re: PR raised for dubbo-config-api

[Imteyaz Khan]

Sure. I appreciate you comment and I am on it.

On Wed, Jan 2, 2019 at 2:49 PM Ian Luo  wrote:

> Imteyaz,
>
> The change looks good to me, but I have a minor comment on your change.
> Would you mind to take a look?
>
> Thanks,
> -Ian.
>
> On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan 
> wrote:
>
> > Hi All,
> >   I have raised PR  <https://github.com/apache/incubator-dubbo/pull/3108
> >
> > for
> > dubbo-config-api. In this PR have replaced the pending hard coded values
> > with constant so that we can minimize accidental issue due to hard coded
> > value used in multiple places. I have created the issue (3107
> > <https://github.com/apache/incubator-dubbo/issues/3107>) for the same.
> >
> > Please review.
> >
> > https://github.com/apache/incubator-dubbo/pull/3108
> >
>

PR raised for dubbo-config-api

[Imteyaz Khan]

Hi All,
  I have raised PR   for
dubbo-config-api. In this PR have replaced the pending hard coded values
with constant so that we can minimize accidental issue due to hard coded
value used in multiple places. I have created the issue (3107
) for the same.

Please review.

https://github.com/apache/incubator-dubbo/pull/3108

Have raised PR for small for dubbo-config module

[Imteyaz Khan]

Hi All,
   I have raised a PR 
to remove hard coded value from few dubbo-config package's java class. Have
created the issue 3100
 for the  as well

https://github.com/apache/incubator-dubbo/pull/3101.

Below are the summary of modification (available in PR and issue details as
well)

*Replace existing hard coded values for dubbo-config below classes*

   - *dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java*
   -
   
*dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java*
   -
   
*dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java*
   -
   
*dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java*
   -
   
*dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractReferenceConfig.java*
   -
   
*dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConsumerConfig.java*

*Along with hard coded value replacement have done small refactoring to use
java stream and lambda.*

Re: A Proposal for Apache Dubbo(incubating) Guangzhou Meetup

[Imteyaz Khan]

Great. Will miss this event. A humble request to team, would be possible
for some one to send summary and highlight of discussion?

On Sat, Dec 29, 2018 at 1:45 PM Huxing Zhang  wrote:

> Hi,
>
> On Sat, Dec 29, 2018 at 3:30 PM chenwei qi  wrote:
> >
> > > 9:30-11:30 End User Discussion
> >
> > Would you please elaborate more about this section?
> > > What kind of form will it be?
> > > How to join this discussion?
> >
> >
> > We will invite 20-30 contributors and users of Dubbo and divide them
> into 5
> > teams to have discussion. Each team will include at least 1 committer,
> the
> > main topic they discuss can be as following: problems or confusion they
> are
> > facing while using Dubbo and attending the community, their further
> > suggestion about Dubbo and its community, etc..
>
> Thanks for the explanation.
> I think it is a good way to listen to end users and collect
> requirements from them.
> In addition, I know some of the user make customization in their own
> branch, we should encourage them to put them back to the community.
> I'd like to be part of it.
> Looking forward to this event!
>
> >
> > 17:00-17:30 Sentinel: Guard for Distributed Service
> > > Are these talks all go through the call for talks process?
> >
> >
> > Yes. All talks have been through the call for talks process for sure.
> >
> >
> > Yours,
> > Baike
> >
> > Huxing Zhang  于2018年12月26日周三 下午5:16写道：
> >
> > > Hi,
> > >
> > > On Tue, Dec 25, 2018 at 11:12 PM chenwei qi 
> > > wrote:
> > > >
> > > > Hi Dubbo PMC & community,
> > > >
> > > >
> > > > Apache Dubbo(incubating) Guangzhou Meetup will be held on Jan.19,
> 2019 (
> > > > Saturday), I am the organizer of the meetup and proposing the
> following
> > > > schedule and request for the permission from PMC.
> > > >
> > > >
> > > > * What is the topic focus of the event?
> > > >
> > > > Topics focus on Apache Dubbo (incubating) and its ecosystem
> > > >
> > > >
> > > > * Who is organizing the event
> > > >
> > > > Apache Dubbo PPMC
> > > >
> > > >
> > > > * When is the event
> > > >
> > > > Date: 2019.01.19 9:30-18:00
> > > >
> > > > Venue:  A320, A321 in Yinbao Building, No.289 of Guangzhou Avenue,
> Yuexiu
> > > > District, Guangzhou
> > > >
> > > >
> > > >
> > > > * How many attendees are expected
> > > >
> > > >  200~400
> > > >
> > > >
> > > > * Which marks are requested
> > > >
> > > > Name of "Apache Dubbo (Incubating)"
> > > >
> > > >
> > > > * How much PMC involvement is there already
> > > >
> > > > PMC is involved with the topic selection.
> > > >
> > > >
> > > > * How will the event selection work?
> > > >
> > > > Topics will be selected by Apache Dubbo PPMC.
> > > >
> > > >
> > > > * Is this for profit or non-profit?
> > > >
> > > > Non-profit
> > > >
> > > >
> > > > * Schedule:
> > > >
> > > > Morning
> > > >
> > > > 9:30-11:30 End User Discussion
> > >
> > > Would you please elaborate more about this section?
> > > What kind of form will it be?
> > > How to join this discussion?
> > >
> > > >
> > > >
> > > > Afternoon
> > > >
> > > > 13:00-13:40 Check In
> > > >
> > > > 13:40-14:10 New Features of Dubbo 2.7.0 and Dubbo Admin
> > > >
> > > > 14:10-14:30 How to Contribute to Dubbo
> > > >
> > > > 14:30-15:00 Dubbo RPC Practice of Node.js
> > > >
> > > > 15:00-15:30 Application Case of Dubbo in Telecom Carrier
> > > >
> > > > 15:30-16:00 Coffee Break
> > > >
> > > > 16:00-16:30 How to Support REST in Dubbo
> > > >
> > > > 16:30-17:00 Nacos Practice to huya.com
> > > >
> > > > 17:00-17:30 Sentinel: Guard for Distributed Service
> > >
> > > Are these talks all go through the call for talks process?
> > >
> > > >
> > > > 17:30-18:00 Q
> > > >
> > > >
> > > > I am following [1][2] for the procedure.
> > > >
> > > >
> > > > Thank Alibaba for sponsoring this event.
> > > >
> > > >
> > > > [1] http://www.apache.org/foundation/marks/events.html
> > > >
> > > > [2] http://community.apache.org/events/small-events.html
> > > >
> > > >
> > > > --
> > > >
> > > > Best Regards！
> > > >
> > > > Baike
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
>
>
>
> --
> Best Regards！
> Huxing
>

Re: PR raised for dubbo demo

[Imteyaz Khan]

Thanks a lot. Appreciate it.

On Saturday, December 29, 2018, Huxing Zhang  wrote:

> Thanks for the pull request!
>
> It looks good to me, I have merge your pull request.
>
> On Sat, Dec 29, 2018 at 1:22 AM Imteyaz Khan 
> wrote:
> >
> > Hi All,
> >   In latest master branch dobbo-demo consumer's dubbo-demo-consumer.xml
> is
> > configured to zookeeper where provider is configured to multicast.
> Because
> > of this mismatch consumer failing. This PR is about making the changes to
> > use multicast so that dubbo-demo can work without external
> configuration. I
> > have created the issue 3091
> > <https://github.com/apache/incubator-dubbo/issues/3091>  for the same
> and PR
> > <https://github.com/apache/incubator-dubbo/pull/3092>.
> >
> > Please review my PR
> > https://github.com/apache/incubator-dubbo/pull/3092
>
>
>
> --
> Best Regards！
> Huxing
>

PR raised for dubbo demo

[Imteyaz Khan]

Hi All,
  In latest master branch dobbo-demo consumer's dubbo-demo-consumer.xml is
configured to zookeeper where provider is configured to multicast. Because
of this mismatch consumer failing. This PR is about making the changes to
use multicast so that dubbo-demo can work without external configuration. I
have created the issue 3091
  for the same and PR
.

Please review my PR
https://github.com/apache/incubator-dubbo/pull/3092

Re: AccessLogFilter simple date format instance creation change PR

[Imteyaz Khan]

Due to my own confusion and bad I found I found my PR is containing more
commits and more file modification other than mine. So avoid the confusion
I created new PR and close the old one. This PR containing the all the
review comments from old PR. Please review mine this PR
<https://github.com/apache/incubator-dubbo/pull/3090>


https://github.com/apache/incubator-dubbo/pull/3090

Sorry for the inconvenience caused.


On Thu, Dec 27, 2018 at 3:24 PM yuhang xiu  wrote:

> Hi,
>
> I simply checked your pr and I agree with you. I will review it.
> Nice work!
>
> Imteyaz Khan  于2018年12月27日周四 下午5:35写道：
>
> > Hi All,
> >   I have raised a separate PR for the same issue 3026.
> >
> > https://github.com/apache/incubator-dubbo/pull/3080
> >
> > As my old PR was containing may commits of others and reviewer would like
> > me to clear those commits and I tried hard to achieve the same but failed
> > so landed up creating new PR
> > <https://github.com/apache/incubator-dubbo/pull/3080>.
> >
> > Please note :: older PR
> > <https://github.com/apache/incubator-dubbo/pull/3027> 3027 has been
> closed
> > but all the comments are applicable here.
> >
> > On Thu, Dec 20, 2018 at 5:35 PM Imteyaz Khan 
> > wrote:
> >
> > > Hi All,
> > >   I have raised a PR <
> > https://github.com/apache/incubator-dubbo/pull/3027>for
> > > issue 3026 <https://github.com/apache/incubator-dubbo/issues/3026>. In
> > > this PR , I am reducing the  number of SimpleDateFormat object creation
> > > from each log message to per thread wise and reusing it. Please review
> > it.
> > >
> > > https://github.com/apache/incubator-dubbo/pull/3027
> > >
> >
>

Do I need to provide CLA

[Imteyaz Khan]

Hi,
   Sorry for asking it and delaying this (if I have :) ). Do I need to
provide CLA here? If yes could some one guide me on this?

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[Imteyaz Khan]

In some places I see there are reference of code which is under
*com.alibaba.fastjson,
*as part of release process should we also consider rewriting them or
providing license from the owner org?



On Fri, Dec 28, 2018 at 8:15 AM Huxing Zhang  wrote:

> Nice work!
>
> I think we should let the community to participate more in the release
> process, for example,
> 1. check out a release branch called 2.7.0-release
> 2. encourage people to check it out, test it and report if there is
> any regressions, bugs or issues.
> 3. while we are doing the test, we can start going through the ASF
> release process locally, once we think it is ready to start a formal
> release note, it can be done very quickly.
>
> By the way, we need decide the release manager of 2.7.0 release. Is
> there anyone who volunteer to do that?
>
> On Thu, Dec 27, 2018 at 11:53 PM jun liu  wrote:
> >
> > Hi, All
> >
> > I am writing this mail to
> >
> >  * Keep you refreshed of the latest status about v2.7.0.
> >  * Call for efforts on code review and tests
> >  * Discuss possible release schedules of v2.7.0.
> >
> > About v2.7, it’s going to be a milestone version, in which will make
> some significant changes. Most importantly, we will complete all IP
> Clearance related works. Technically speaking, it’s from this version on
> that a Dubbo release starts fully follows the Apache rules (lawfully),
> totally independent from any other third-party organizations or companies.
> Secondly, this version will include many new features that have received
> wide attention from the community, by supporting these features, we can
> better resolve the community’s long accumulated demands. Last but not
> least, we have made some architectural changes in this version, made Dubbo
> closer to the micro-service architecture, take the newly introduced
> configuration center as an example, it can work both as the center of
> Externalized Configuration at startup and as the center of service
> management configurations at runtime.
> >
> > To summarize, the contents already included in the CodeBase are:
> >
> > * Config Center: Zookeeper, Apollo, Nacos
> > * Externalized Configuration
> > * Service governance enhancement: dynamic configuration & routing rule
> > * Repackage to 'org.apache.dubbo'
> > * Java 8 support
> > * Async programming support
> >
> > Most of the candidates listed above are in the proposal list that we
> have discussed in some threads before. For a more detailed description of
> these features or how they are realized, you can refer to the draft
> development documentations within this link[1]
> >
> > Thanks to the efforts from the community (especially thank to Ian,
> CVictory and Minxuan), most of the development work has been completed and
> a round of code review and regression test based on some basic use cases
> have been completed[2].
> > Now I think it's time to prepare the formal release. One most important
> thing I think we should pay attention to is stability. We should guarantee
> it's stable enough before release, so we may need to put more effort into
> code review and functional testing. Based on my understanding of the
> CodeBase, such tests may at least continue to last for about 1 week, during
> this period we may need to `freeze the code`, which means only optimization
> and bugfix will be allowed. After that, we can continue to evaluate when to
> start the formal vote process.
> >
> > 1. https://github.com/apache/incubator-dubbo/issues/2919
> > 2.
> https://github.com/apache/incubator-dubbo-samples/tree/samples-for-2.7.0-SNAPSHOT
> >
> > Jun
> >
>
>
> --
> Best Regards！
> Huxing
>

Re: Dubbo travis ci is failing because of dubbo-metadata-report-zookeeper

[Imteyaz Khan]

Thanks. Appreciate your information.

On Thursday, December 27, 2018, jun liu  wrote:

> I think a customized File Template and Code Style Template complying to
> Dubbo’s style in your IDE would be a good way to avoid.
>
> Jun
>
> > On Dec 27, 2018, at 9:18 PM, Imteyaz Khan 
> wrote:
> >
> > Thanks a lot. Any suggestions what could avoid in future if there is any
> > from this learning?
> >
> > On Thursday, December 27, 2018, jun liu  wrote:
> >
> >> Turns out to be a lack of license problem from rat plugin.
> >>
> >> Fixed.
> >>
> >> Jun
> >>
> >>> On Dec 27, 2018, at 6:51 PM, jun liu  wrote:
> >>>
> >>> I noticed the failure too, will try to figure it out.
> >>>
> >>> Jun
> >>>
> >>>> On Dec 27, 2018, at 6:07 PM, Imteyaz Khan  >> <mailto:khan.imte...@gmail.com>> wrote:
> >>>>
> >>>> Dubbo travis ci is failing because of dubbo-metadata-report-zookeeper
> >> UT
> >>>> failure.Have created an issue for the same and planning work on in
> >>>>
> >>>> https://github.com/apache/incubator-dubbo/issues/3081 <
> >> https://github.com/apache/incubator-dubbo/issues/3081>
> >>>
> >>
> >>
>
>

Re: Dubbo travis ci is failing because of dubbo-metadata-report-zookeeper

[Imteyaz Khan]

Thanks a lot. Any suggestions what could avoid in future if there is any
from this learning?

On Thursday, December 27, 2018, jun liu  wrote:

> Turns out to be a lack of license problem from rat plugin.
>
> Fixed.
>
> Jun
>
> > On Dec 27, 2018, at 6:51 PM, jun liu  wrote:
> >
> > I noticed the failure too, will try to figure it out.
> >
> > Jun
> >
> >> On Dec 27, 2018, at 6:07 PM, Imteyaz Khan  <mailto:khan.imte...@gmail.com>> wrote:
> >>
> >> Dubbo travis ci is failing because of dubbo-metadata-report-zookeeper
> UT
> >> failure.Have created an issue for the same and planning work on in
> >>
> >> https://github.com/apache/incubator-dubbo/issues/3081 <
> https://github.com/apache/incubator-dubbo/issues/3081>
> >
>
>

Dubbo travis ci is failing because of dubbo-metadata-report-zookeeper

[Imteyaz Khan]

Dubbo travis ci is failing because of dubbo-metadata-report-zookeeper UT
failure.Have created an issue for the same and planning work on in

https://github.com/apache/incubator-dubbo/issues/3081

Re: [DISCUSSION] Focus on making framework more development and maintenance friendly.

[Imteyaz Khan]

+1 from my side on this.

I might be thinking loud here, please correct me if requires correction :).
I am planning to look into developer community to come up with some data
point which can help us
   1. What are the convention or configuration approach developer are
using more and how. This is to see what convention, approach are mostly
followed and how far is dubbo from the line.
  2. Developer, Dev-ops and Support point of view what user is looking
or using from micro service architecture.


I might have misses something here (please add valuable missing points
which you know and I missed :) ).

Does the above approach looks ok to community?



On Thu, Dec 27, 2018 at 12:24 PM jun liu  wrote:

> > I am really appreciated that someone brings up this topic, dev
> experience.
> > I think we could set up this as the major theme for the next releases.
>
> +1, I think we can start a Github Project to track this topic.
>
> > I am a fan of one liner, and I am thinking it might be a good idea to
> > introduce a chained API to allow user to start up a simple Dubbo
> > application in just one line. Unfortunately I am always occupied by other
> > works and have no chance to build it.
>
> To make things happen, I think we should first list all possible aspects
> that worth urgent improvement. Then add them to the next release milestone
> according to priority. Think of possible solutions in detail and discuss
> each of them in a separated thread.
> I think the Committers and PPMCs should be responsible for starting things
> up.
>
> > - get rid of camel style attribute name and switched to 'dash' separated
> > attribute name
>
> I think camel or dash, which style should be used, should depends on the
> configuration method we use. It's easy to find how some popular frameworks
> set their configuration format, usually these conventions are followed by
> most developers and even are facto standards.
>
> Now, I decide to write a blog introducing Dubbo’s configuration
> conventions and all the possible configuration items available in Dubbo.
>
> > - consider to introduce delegated schema for different protocol
> > implementation.
>
> Could you describe this in depth? I failed to get your point.
>
> Jun
>
> > On Dec 25, 2018, at 1:53 PM, Ian Luo  wrote:
> >
> > I am really appreciated that someone brings up this topic, dev
> experience.
> > I think we could set up this as the major theme for the next releases.
> >
> > I am a fan of one liner, and I am thinking it might be a good idea to
> > introduce a chained API to allow user to start up a simple Dubbo
> > application in just one line. Unfortunately I am always occupied by other
> > works and have no chance to build it.
> >
> > Besides chained API, I suggest we should look into XML schema further, at
> > least we need to enhance the following areas:
> >
> > - get rid of camel style attribute name and switched to 'dash' separated
> > attribute name
> > - consider to introduce delegated schema for different protocol
> > implementation.
> >
> > Thanks,
> > -Ian.
> >
> >
> >
> > On Fri, Dec 21, 2018 at 4:30 PM jun liu  wrote:
> >
> >> Hi, All
> >>
> >>
> >>
> 最近收到了一些用户和开发者反馈，总结起来我觉得主要是Dubbo框架在开发态和运行态能力的一些欠缺。因此，除了我们经常提及的如何围绕Dubbo构建更丰富的微服务开发解决方案外，我个人觉得我们应该在核心框架的易用性上也应多投入一些精力，为用户提供更好的开发使用体验。
> >>
> >> 以下是我当前能想到的一些点，从我的认识中肯定还有很多需要优化的地方，我一时没能想起来，如果你觉得有亟需改进的地方，欢迎补充。
> >>
> >> 首先，开发层面。
> >> 1. 注解方式增强和bug修复，汇总和修复报告的issue，数量应该还挺多
> >> 2. 注解能力和XML、properties对齐，如方法级配置等
> >> 3. Dubbo配置格式的统一、增加面向用户的配置使用说明、配置项汇总等
> >> 4. API编程接口易用性的优化
> >> 5. 汇总和解决其他一些涉及到开发效率或易用性的issue报告
> >>
> >> 其次，运维层面。
> >> 1. OPS功能进一步丰富
> >> 2. Metrics
> >> 3. 内部配置和运行态数据采集并尝试通过各种Endpoints暴露等
> >> 4. Telnet指令丰富/增强
> >>
> >> 大家经常遇到问题的几个场景的blog输出
> >> 1. 优雅停机
> >> 2. 其他
> >>
> >> 其他需要补充的...
> >>
> >> Translated from Google:
> >>
> >> I have recently received some user and developer feedback. In summary, I
> >> think it is mainly due to the lack of development and runtime
> capabilities
> >> of the Dubbo framework. Therefore, in addition to how we often discuss
> how
> >> to build a richer microservice development solution around Dubbo, I
> >> personally feel that we should put more effort into the core framework
> to
> >> provide users with a better development experience.
> >>
> >> The following are some of the points that I can think of right now.
> There
> >> are definitely a lot of things that I need to optimize from my
> >> understanding. I can't think of it for a while. If you feel that there
> is a
> >> need for improvement, welcome to add.
> >>
> >> Firstly, development level.
> >> 1. Annotation enhancements and bug fixes, summary and fix report issues
> >> 2. Annotation capability and XML, properties alignment, such as method
> >> level configuration, etc.
> >> 3. Uniform configuration of Dubbo, increase user-oriented configuration
> >> instructions, and summary of configuration items
> >> 4. Optimization of the ease of use of the API programming interface
> >> 5. Summarize and resolve other issue 

Re: AccessLogFilter simple date format instance creation change PR

[Imteyaz Khan]

Hi All,
  I have raised a separate PR for the same issue 3026.

https://github.com/apache/incubator-dubbo/pull/3080

As my old PR was containing may commits of others and reviewer would like
me to clear those commits and I tried hard to achieve the same but failed
so landed up creating new PR
<https://github.com/apache/incubator-dubbo/pull/3080>.

Please note :: older PR
<https://github.com/apache/incubator-dubbo/pull/3027> 3027 has been closed
but all the comments are applicable here.

On Thu, Dec 20, 2018 at 5:35 PM Imteyaz Khan  wrote:

> Hi All,
>   I have raised a PR <https://github.com/apache/incubator-dubbo/pull/3027>for
> issue 3026 <https://github.com/apache/incubator-dubbo/issues/3026>. In
> this PR , I am reducing the  number of SimpleDateFormat object creation
> from each log message to per thread wise and reusing it. Please review it.
>
> https://github.com/apache/incubator-dubbo/pull/3027
>

travis ci are failing

[Imteyaz Khan]

Hi all,
   Travis CI are failing currently due to log size. Is it the same issue
3052 ?

Re: PR raised for 3032 (Assert check and readability enhancement)

[Imteyaz Khan]

Ian,
   Thanks for your appreciation.


On Tue, Dec 25, 2018 at 11:28 AM Ian Luo  wrote:

> Nice job, I've merged your change.
>
> Thanks,
> -Ian.
>
>
> On Sat, Dec 22, 2018 at 6:53 PM Imteyaz Khan 
> wrote:
>
> > Hi All,
> >   I have raised the PR <
> > https://github.com/apache/incubator-dubbo/pull/3048>for
> > issue number 3032. This PR has address few readability enhancement and
> > Assert check to simplyfy ConsumerModel constructor logic. Please review
> it.
> >
> > https://github.com/apache/incubator-dubbo/pull/3048
> >
>

PR raised for 3032 (Assert check and readability enhancement)

[Imteyaz Khan]

Hi All,
  I have raised the PR for
issue number 3032. This PR has address few readability enhancement and
Assert check to simplyfy ConsumerModel constructor logic. Please review it.

https://github.com/apache/incubator-dubbo/pull/3048

Re: ActiveLimitFilter some observation! Need your suggestion

[Imteyaz Khan]

Ian,
   Sure, on it.

On Fri, Dec 21, 2018 at 8:34 AM Ian Luo  wrote:

> Imteyaz,
>
> Would you mind to take a look at pull request 3035 [1] I submitted just
> now?
>
> Thanks,
> -Ian.
>
>
> 1. https://github.com/apache/incubator-dubbo/pull/3035
>
>
> On Thu, Dec 20, 2018 at 4:41 PM Imteyaz Khan 
> wrote:
>
> > Ian,
> >Yes please, incorporate the fix. Will wait for your PR to review.
> >
> >
> >
> > On Thu, Dec 20, 2018 at 2:01 PM Imteyaz Khan 
> > wrote:
> >
> > > Ian,
> > > You won't believe, but what a coincidence I just loggined to gmail, to
> > > reply on this tread to say, can I assist you on this issue any way and
> > saw
> > > your email. Any thing is fine with me.
> > >
> > >  Regarding the apporach, as you mentioned endCount needs to be called I
> > > certinly agree with you, but I was more looking for simplified approach
> > of
> > > changing if condition check where first check using beginCount then
> > > followed by max>0. In this case, begin count will be always set and
> > before
> > > the end of method endCount will reduce it.
> > >
> > > Please correct me if I am wrong here.
> > >
> > > On Thu, Dec 20, 2018 at 1:54 PM Ian Luo  wrote:
> > >
> > >> Khan,
> > >>
> > >> I know you may busy on other stuff, should I jump on to give it a fix?
> > >>
> > >> Thanks,
> > >> -Ian.
> > >>
> > >>
> > >> On Thu, Dec 20, 2018 at 10:11 AM Ian Luo  wrote:
> > >>
> > >> > We cannot simply comment out 'endCount' in finally clause. If
> > >> 'beginCount'
> > >> > happens, then 'endCount' must be called.
> > >> >
> > >> > Thanks,
> > >> > -Ian.
> > >> >
> > >> > On Wed, Dec 19, 2018 at 9:49 PM Imteyaz Khan <
> khan.imte...@gmail.com>
> > >> > wrote:
> > >> >
> > >> >> Ian,
> > >> >>   The approach you mentioned, I am certain it would works. I was
> > >> thinking
> > >> >> another approach
> > >> >>
> > >> >> if (!RpcStatus.beginCount(url, methodName, max) && max > 0) {
> > >> >> }
> > >> >>
> > >> >> ...
> > >> >> finally {
> > >> >>//already existing endCount call.
> > >> >> }
> > >> >>
> > >> >> Second approach I am mentioning because of simplification. Do let
> me
> > >> know
> > >> >> your thoughts on this.
> > >> >>
> > >> >>
> > >> >> On Wed, Dec 19, 2018 at 6:39 PM Ian Luo  wrote:
> > >> >>
> > >> >> > Hi Khan,
> > >> >> >
> > >> >> > Thanks for pointing out this issue. I guess we could change logic
> > to:
> > >> >> >
> > >> >> > if (max > 0 && !RpcStatus.beginCount(url, methodName, max)) {
> > >> >> >  ...
> > >> >> > } else {
> > >> >> >RpcStatus.beginCount(url, methodName);
> > >> >> > }
> > >> >> >
> > >> >> > And we should do the same logic in ExecuteLimitFilter. Let me
> know
> > >> your
> > >> >> > opinion on this.
> > >> >> >
> > >> >> > Thanks,
> > >> >> > -Ian.
> > >> >> >
> > >> >> >
> > >> >> > On Wed, Dec 19, 2018 at 7:42 PM Imteyaz Khan <
> > khan.imte...@gmail.com
> > >> >
> > >> >> > wrote:
> > >> >> >
> > >> >> > > Hi All,
> > >> >> > >I was trying to write UT for ActiveLimitFilter for
> > >> RuntimeException
> > >> >> > > scenarion and below is my UT for the same
> > >> >> > >
> > >> >> > > ActiveLimitFilterTest.java
> > >> >> > >
> > >> >> > > @Test()
> > >> >> > > public void testInvokeRuntimeExceptionWithActiveCountMatch() {
> > >> >> > > URL url =
> > >> >> > >
> > >> >> >
> > >> >>
> > >>
> >
&g

AccessLogFilter simple date format instance creation change PR

[Imteyaz Khan]

Hi All,
  I have raised a PR for
issue 3026 . In this
PR , I am reducing the  number of SimpleDateFormat object creation from
each log message to per thread wise and reusing it. Please review it.

https://github.com/apache/incubator-dubbo/pull/3027

Re: ActiveLimitFilter some observation! Need your suggestion

[Imteyaz Khan]

Ian,
   Yes please, incorporate the fix. Will wait for your PR to review.



On Thu, Dec 20, 2018 at 2:01 PM Imteyaz Khan  wrote:

> Ian,
> You won't believe, but what a coincidence I just loggined to gmail, to
> reply on this tread to say, can I assist you on this issue any way and saw
> your email. Any thing is fine with me.
>
>  Regarding the apporach, as you mentioned endCount needs to be called I
> certinly agree with you, but I was more looking for simplified approach of
> changing if condition check where first check using beginCount then
> followed by max>0. In this case, begin count will be always set and before
> the end of method endCount will reduce it.
>
> Please correct me if I am wrong here.
>
> On Thu, Dec 20, 2018 at 1:54 PM Ian Luo  wrote:
>
>> Khan,
>>
>> I know you may busy on other stuff, should I jump on to give it a fix?
>>
>> Thanks,
>> -Ian.
>>
>>
>> On Thu, Dec 20, 2018 at 10:11 AM Ian Luo  wrote:
>>
>> > We cannot simply comment out 'endCount' in finally clause. If
>> 'beginCount'
>> > happens, then 'endCount' must be called.
>> >
>> > Thanks,
>> > -Ian.
>> >
>> > On Wed, Dec 19, 2018 at 9:49 PM Imteyaz Khan 
>> > wrote:
>> >
>> >> Ian,
>> >>   The approach you mentioned, I am certain it would works. I was
>> thinking
>> >> another approach
>> >>
>> >> if (!RpcStatus.beginCount(url, methodName, max) && max > 0) {
>> >> }
>> >>
>> >> ...
>> >> finally {
>> >>//already existing endCount call.
>> >> }
>> >>
>> >> Second approach I am mentioning because of simplification. Do let me
>> know
>> >> your thoughts on this.
>> >>
>> >>
>> >> On Wed, Dec 19, 2018 at 6:39 PM Ian Luo  wrote:
>> >>
>> >> > Hi Khan,
>> >> >
>> >> > Thanks for pointing out this issue. I guess we could change logic to:
>> >> >
>> >> > if (max > 0 && !RpcStatus.beginCount(url, methodName, max)) {
>> >> >  ...
>> >> > } else {
>> >> >RpcStatus.beginCount(url, methodName);
>> >> > }
>> >> >
>> >> > And we should do the same logic in ExecuteLimitFilter. Let me know
>> your
>> >> > opinion on this.
>> >> >
>> >> > Thanks,
>> >> > -Ian.
>> >> >
>> >> >
>> >> > On Wed, Dec 19, 2018 at 7:42 PM Imteyaz Khan > >
>> >> > wrote:
>> >> >
>> >> > > Hi All,
>> >> > >I was trying to write UT for ActiveLimitFilter for
>> RuntimeException
>> >> > > scenarion and below is my UT for the same
>> >> > >
>> >> > > ActiveLimitFilterTest.java
>> >> > >
>> >> > > @Test()
>> >> > > public void testInvokeRuntimeExceptionWithActiveCountMatch() {
>> >> > > URL url =
>> >> > >
>> >> >
>> >>
>> URL.valueOf("test://test:11/test?accesslog=true=dubbo=1.1=0");
>> >> > > Invoker invoker = new
>> >> > > RuntimeExceptionInvoker(url);
>> >> > > Invocation invocation = new MockInvocation();
>> >> > > RpcStatus count = RpcStatus.getStatus(invoker.getUrl(),
>> >> > > invocation.getMethodName());
>> >> > > int beforeExceptionActiveCount = count.getActive();
>> >> > > try {
>> >> > > activeLimitFilter.invoke(invoker, invocation);
>> >> > > } catch (RuntimeException ex) {
>> >> > > int afterExceptionActiveCount = count.getActive();
>> >> > > assertEquals("After exception active count should be same"
>> >> > > , beforeExceptionActiveCount,
>> >> afterExceptionActiveCount);
>> >> > > }
>> >> > > }
>> >> > >
>> >> > >
>> >> > > Where I am expecting RpcStatus active count before call and after
>> >> invoke
>> >> > > should be same, irrespective of exceptional handling by
>> >> ActiveLimitFilter
>> >> > > (e.g. in this case it should be 0). UT showing me that after
>> >> encountering
>> >> 

Re: [ANN] New PPMC member: Yuhang Xiu

[Imteyaz Khan]

Congratulations  Yuhang Xiu .

Re: ActiveLimitFilter some observation! Need your suggestion

[Imteyaz Khan]

Ian,
You won't believe, but what a coincidence I just loggined to gmail, to
reply on this tread to say, can I assist you on this issue any way and saw
your email. Any thing is fine with me.

 Regarding the apporach, as you mentioned endCount needs to be called I
certinly agree with you, but I was more looking for simplified approach of
changing if condition check where first check using beginCount then
followed by max>0. In this case, begin count will be always set and before
the end of method endCount will reduce it.

Please correct me if I am wrong here.

On Thu, Dec 20, 2018 at 1:54 PM Ian Luo  wrote:

> Khan,
>
> I know you may busy on other stuff, should I jump on to give it a fix?
>
> Thanks,
> -Ian.
>
>
> On Thu, Dec 20, 2018 at 10:11 AM Ian Luo  wrote:
>
> > We cannot simply comment out 'endCount' in finally clause. If
> 'beginCount'
> > happens, then 'endCount' must be called.
> >
> > Thanks,
> > -Ian.
> >
> > On Wed, Dec 19, 2018 at 9:49 PM Imteyaz Khan 
> > wrote:
> >
> >> Ian,
> >>   The approach you mentioned, I am certain it would works. I was
> thinking
> >> another approach
> >>
> >> if (!RpcStatus.beginCount(url, methodName, max) && max > 0) {
> >> }
> >>
> >> ...
> >> finally {
> >>//already existing endCount call.
> >> }
> >>
> >> Second approach I am mentioning because of simplification. Do let me
> know
> >> your thoughts on this.
> >>
> >>
> >> On Wed, Dec 19, 2018 at 6:39 PM Ian Luo  wrote:
> >>
> >> > Hi Khan,
> >> >
> >> > Thanks for pointing out this issue. I guess we could change logic to:
> >> >
> >> > if (max > 0 && !RpcStatus.beginCount(url, methodName, max)) {
> >> >  ...
> >> > } else {
> >> >RpcStatus.beginCount(url, methodName);
> >> > }
> >> >
> >> > And we should do the same logic in ExecuteLimitFilter. Let me know
> your
> >> > opinion on this.
> >> >
> >> > Thanks,
> >> > -Ian.
> >> >
> >> >
> >> > On Wed, Dec 19, 2018 at 7:42 PM Imteyaz Khan 
> >> > wrote:
> >> >
> >> > > Hi All,
> >> > >I was trying to write UT for ActiveLimitFilter for
> RuntimeException
> >> > > scenarion and below is my UT for the same
> >> > >
> >> > > ActiveLimitFilterTest.java
> >> > >
> >> > > @Test()
> >> > > public void testInvokeRuntimeExceptionWithActiveCountMatch() {
> >> > > URL url =
> >> > >
> >> >
> >>
> URL.valueOf("test://test:11/test?accesslog=true=dubbo=1.1=0");
> >> > > Invoker invoker = new
> >> > > RuntimeExceptionInvoker(url);
> >> > > Invocation invocation = new MockInvocation();
> >> > > RpcStatus count = RpcStatus.getStatus(invoker.getUrl(),
> >> > > invocation.getMethodName());
> >> > > int beforeExceptionActiveCount = count.getActive();
> >> > > try {
> >> > > activeLimitFilter.invoke(invoker, invocation);
> >> > > } catch (RuntimeException ex) {
> >> > > int afterExceptionActiveCount = count.getActive();
> >> > > assertEquals("After exception active count should be same"
> >> > > , beforeExceptionActiveCount,
> >> afterExceptionActiveCount);
> >> > > }
> >> > > }
> >> > >
> >> > >
> >> > > Where I am expecting RpcStatus active count before call and after
> >> invoke
> >> > > should be same, irrespective of exceptional handling by
> >> ActiveLimitFilter
> >> > > (e.g. in this case it should be 0). UT showing me that after
> >> encountering
> >> > > exception it is not same, on my further investigation I found that
> >> > >
> >> > >
> >> > >- If there is no *actives (ACTIVE_KEY) *is set or if its value is
> >> less
> >> > >then *1* then it is always returning -1 (in UT active count),
> which
> >> > >means there is more number of call can be possible then it is
> >> > > allowed(this
> >> > >is my interpretation , correct me if this is wrong). e.g. if
> >> within a
> >> > >minute 10 call are allowe

Re: ActiveLimitFilter some observation! Need your suggestion

[Imteyaz Khan]

Ian,
  The approach you mentioned, I am certain it would works. I was thinking
another approach

if (!RpcStatus.beginCount(url, methodName, max) && max > 0) {
}

...
finally {
   //already existing endCount call.
}

Second approach I am mentioning because of simplification. Do let me know
your thoughts on this.


On Wed, Dec 19, 2018 at 6:39 PM Ian Luo  wrote:

> Hi Khan,
>
> Thanks for pointing out this issue. I guess we could change logic to:
>
> if (max > 0 && !RpcStatus.beginCount(url, methodName, max)) {
>  ...
> } else {
>RpcStatus.beginCount(url, methodName);
> }
>
> And we should do the same logic in ExecuteLimitFilter. Let me know your
> opinion on this.
>
> Thanks,
> -Ian.
>
>
> On Wed, Dec 19, 2018 at 7:42 PM Imteyaz Khan 
> wrote:
>
> > Hi All,
> >I was trying to write UT for ActiveLimitFilter for RuntimeException
> > scenarion and below is my UT for the same
> >
> > ActiveLimitFilterTest.java
> >
> > @Test()
> > public void testInvokeRuntimeExceptionWithActiveCountMatch() {
> > URL url =
> >
> URL.valueOf("test://test:11/test?accesslog=true=dubbo=1.1=0");
> > Invoker invoker = new
> > RuntimeExceptionInvoker(url);
> > Invocation invocation = new MockInvocation();
> > RpcStatus count = RpcStatus.getStatus(invoker.getUrl(),
> > invocation.getMethodName());
> > int beforeExceptionActiveCount = count.getActive();
> > try {
> > activeLimitFilter.invoke(invoker, invocation);
> > } catch (RuntimeException ex) {
> > int afterExceptionActiveCount = count.getActive();
> > assertEquals("After exception active count should be same"
> > , beforeExceptionActiveCount, afterExceptionActiveCount);
> > }
> > }
> >
> >
> > Where I am expecting RpcStatus active count before call and after invoke
> > should be same, irrespective of exceptional handling by ActiveLimitFilter
> > (e.g. in this case it should be 0). UT showing me that after encountering
> > exception it is not same, on my further investigation I found that
> >
> >
> >- If there is no *actives (ACTIVE_KEY) *is set or if its value is less
> >then *1* then it is always returning -1 (in UT active count), which
> >means there is more number of call can be possible then it is
> > allowed(this
> >is my interpretation , correct me if this is wrong). e.g. if within a
> >minute 10 call are allowed and if we encounter 5 *RuntimeException
> *then
> >in total we could landed up allowing 15 invoke. I am suspecting this
> is
> >because *max *being *0*  we don't increment active count of RpcStatus
> >and then decrease it in finally block where we have not even have
> > increase
> >the count, because *max* is before the count increment
> >
> > if (max > 0 && !RpcStatus.beginCount(url, methodName,
> max))
> >
> > As a reference I am copying the current master branch code of
> > ActiveLimitFilter.java. Would request to correct my understanding if it
> is
> > wrong, and if you feel my observation is correct then I would can raise a
> > PR for fixing this issue.
> > *Note: UT is in my local I have not checked in into any branch.
> >
> > if (max > 0 && !RpcStatus.beginCount(url, methodName, max)) {
> > long timeout =
> > invoker.getUrl().getMethodParameter(invocation.getMethodName(),
> > Constants.TIMEOUT_KEY, 0);
> > long start = System.currentTimeMillis();
> > long remain = timeout;
> > synchronized (count) {
> > while (!RpcStatus.beginCount(url, methodName, max)) {
> > try {
> > count.wait(remain);
> > } catch (InterruptedException e) {
> > // ignore
> > }
> > long elapsed = System.currentTimeMillis() - start;
> > remain = timeout - elapsed;
> > if (remain <= 0) {
> > throw new RpcException("Waiting concurrent
> > invoke timeout in client-side for service:  "
> > + invoker.getInterface().getName() +
> > ", method: "
> > + invocation.getMethodName() + ",
> > elapsed: " + elapsed
> > + ", timeout: " + timeout + ".
> > concurrent invokes: "

ActiveLimitFilter some observation! Need your suggestion

[Imteyaz Khan]

Hi All,
   I was trying to write UT for ActiveLimitFilter for RuntimeException
scenarion and below is my UT for the same

ActiveLimitFilterTest.java

@Test()
public void testInvokeRuntimeExceptionWithActiveCountMatch() {
URL url = 
URL.valueOf("test://test:11/test?accesslog=true=dubbo=1.1=0");
Invoker invoker = new RuntimeExceptionInvoker(url);
Invocation invocation = new MockInvocation();
RpcStatus count = RpcStatus.getStatus(invoker.getUrl(),
invocation.getMethodName());
int beforeExceptionActiveCount = count.getActive();
try {
activeLimitFilter.invoke(invoker, invocation);
} catch (RuntimeException ex) {
int afterExceptionActiveCount = count.getActive();
assertEquals("After exception active count should be same"
, beforeExceptionActiveCount, afterExceptionActiveCount);
}
}


Where I am expecting RpcStatus active count before call and after invoke
should be same, irrespective of exceptional handling by ActiveLimitFilter
(e.g. in this case it should be 0). UT showing me that after encountering
exception it is not same, on my further investigation I found that


   - If there is no *actives (ACTIVE_KEY) *is set or if its value is less
   then *1* then it is always returning -1 (in UT active count), which
   means there is more number of call can be possible then it is allowed(this
   is my interpretation , correct me if this is wrong). e.g. if within a
   minute 10 call are allowed and if we encounter 5 *RuntimeException *then
   in total we could landed up allowing 15 invoke. I am suspecting this is
   because *max *being *0*  we don't increment active count of RpcStatus
   and then decrease it in finally block where we have not even have increase
   the count, because *max* is before the count increment

if (max > 0 && !RpcStatus.beginCount(url, methodName, max))

As a reference I am copying the current master branch code of
ActiveLimitFilter.java. Would request to correct my understanding if it is
wrong, and if you feel my observation is correct then I would can raise a
PR for fixing this issue.
*Note: UT is in my local I have not checked in into any branch.

if (max > 0 && !RpcStatus.beginCount(url, methodName, max)) {
long timeout =
invoker.getUrl().getMethodParameter(invocation.getMethodName(),
Constants.TIMEOUT_KEY, 0);
long start = System.currentTimeMillis();
long remain = timeout;
synchronized (count) {
while (!RpcStatus.beginCount(url, methodName, max)) {
try {
count.wait(remain);
} catch (InterruptedException e) {
// ignore
}
long elapsed = System.currentTimeMillis() - start;
remain = timeout - elapsed;
if (remain <= 0) {
throw new RpcException("Waiting concurrent
invoke timeout in client-side for service:  "
+ invoker.getInterface().getName() +
", method: "
+ invocation.getMethodName() + ",
elapsed: " + elapsed
+ ", timeout: " + timeout + ".
concurrent invokes: " + count.getActive()
+ ". max concurrent invoke limit: " + max);
}
}
}
}

boolean isSuccess = true;
long begin = System.currentTimeMillis();
try {
return invoker.invoke(invocation);
} catch (RuntimeException t) {
isSuccess = false;
throw t;
} finally {
RpcStatus.endCount(url, methodName,
System.currentTimeMillis() - begin, isSuccess);
if (max > 0) {
synchronized (count) {
count.notifyAll();
}
}
}

Re: dubbo-rpc-api UT pr

[Imteyaz Khan]

@Ian and @Huxing thanks for your caring.

On Wed, Dec 19, 2018 at 11:17 AM Ian Luo  wrote:

> merged, your pull request looks good to me. Feel free to push multiple
> times for one particular pull request, 'Squash and merge' on GitHub will do
> the trick.
>
> -Ian.
>
> On Wed, Dec 19, 2018 at 10:12 AM Huxing Zhang  wrote:
>
> > Hi,
> >
> > On Wed, Dec 19, 2018 at 2:25 AM Imteyaz Khan 
> > wrote:
> > >
> > > Hi All,
> > > Raised a PR <https://github.com/apache/incubator-dubbo/pull/3010>for
> > > addition of UT for dubbo-rpc-api for issue id 3011
> > > <https://github.com/apache/incubator-dubbo/issues/3011>.  Please
> review
> > it.
> > > https://github.com/apache/incubator-dubbo/pull/3010
> > >
> > > Desclaimer: I am not much aware about github and tryin to learn stuff
> on
> > > it. I found deficult to combined multiple commits into single commit in
> > my
> > > fork repo brances but kind of scare how to do it. Any help would be
> > > appreciated.
> >
> > Don't worry, these commits will be squashed when getting merged.
> > To answer your question, please check [1] for more details.
> >
> > [1]
> >
> https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md#contribution-flow
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>

dubbo-rpc-api UT pr

[Imteyaz Khan]

Hi All,
Raised a PR for
addition of UT for dubbo-rpc-api for issue id 3011
.  Please review it.
https://github.com/apache/incubator-dubbo/pull/3010

Desclaimer: I am not much aware about github and tryin to learn stuff on
it. I found deficult to combined multiple commits into single commit in my
fork repo brances but kind of scare how to do it. Any help would be
appreciated.

Re: [Call for talks] Dubbo Guangzhou meetup

[Imteyaz Khan]

No worries. Any one of them should be fine for me. Thanks for caring about
it, I appreciate.

On Tue, Dec 18, 2018 at 8:58 PM Huxing Zhang  wrote:

> Hi,
>
> On Tue, Dec 18, 2018 at 2:55 PM Imteyaz Khan 
> wrote:
> >
> > No worries. Would there be english version of dubbo presentations(e.g.
> ppt)?
>
> I will encourage them to write the slides with English, but I can't
> guarantee that :)
> Another solution will be to let the community to help to translate into
> English.
>
> >
> >
> > On Tue, Dec 18, 2018 at 12:10 PM Huxing Zhang  wrote:
> >
> > > Hi,
> > >
> > > On Tue, Dec 18, 2018 at 2:27 PM Imteyaz Khan 
> > > wrote:
> > > >
> > > > Will be there any web cast (live streaming of meetup) for those who
> may
> > > not
> > > > be able to attend this meetup (As I will be one of those :) ) ?
> > >
> > > Yes, there is! Will put it on the mailing list when possible, and
> > > please also follow the official Twitter account @ApacheDubbo for
> > > latest updates.
> > >
> > > But unfortunately most of the talks are in Chinese. :)
> > >
> > > I am not sure if there is auto translation in the live streaming ...
> > > >
> > > >
> > > >
> > > >
> > > > On Tue, Dec 18, 2018 at 11:14 AM Eric Zhao 
> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > I'd like to share a talk about Sentinel [1], a powerful
> flow-control
> > > > > component open-sourced by Alibaba, enabling resilience and
> reliability
> > > for
> > > > > microservices.
> > > > >
> > > > > ## Topic
> > > > >
> > > > > Sentinel: The flow sentinel of your services
> > > > >
> > > > > ## Abstract
> > > > >
> > > > > - Introduce main features and scenarios of Sentinel, including
> cluster
> > > flow
> > > > > control, the new-released feature in Sentinel 1.4.0
> > > > > - Provide comparison with other open-source circuit breaking
> libraries
> > > to
> > > > > help users to choose the appropriate component
> > > > > - Introduce the roadmap of Sentinel
> > > > >
> > > > > [1] https://github.com/alibaba/Sentinel
> > > > >
> > > > >
> > > > > Best Regards,
> > > > > Eric
> > > > >
> > > > >
> > > > > On 2018/12/13 08:17:33, Huxing Zhang  wrote:
> > > > > > Hi,>
> > > > > >
> > > > > > I am pleased to announce that the Dubbo community are going to
> hold a
> > > > > meetup in>
> > > > > > Guangzhou on January 19th (Saturday), and we are now open to
> > > community
> > > > > talks>
> > > > > > about:>
> > > > > >
> > > > > > * How to contribute to Dubbo>
> > > > > > * How we use Dubbo in production system>
> > > > > > * Dubbo best practice>
> > > > > > * Integrate Dubbo with other open source software>
> > > > > > * Other topics involving Dubbo>
> > > > > >
> > > > > > Please submit your proposal including your topic, abstract, and>
> > > > > > speaker bio, submit by this link[1], and please also let the
> > > community>
> > > > > > to know by replying this email.>
> > > > > >
> > > > > > The call for talks will close by Dec 21st.>
> > > > > >
> > > > > > Below is a template:>
> > > > > >
> > > > > > ### Topic>
> > > > > >
> > > > > > Your awesome topic goes here>
> > > > > >
> > > > > > ### Abstract>
> > > > > >
> > > > > > Your awesome abstract goes here>
> > > > > >
> > > > > > ### Speaker Bio>
> > > > > >
> > > > > > Your awesome bio goes here>
> > > > > >
> > > > > > [1] http://alibabadeveloper.mikecrm.com/QBJtbV1>
> > > > > >
> > > > > > -->
> > > > > > Best Regards！>
> > > > > > Huxing>
> > > > > >
> > > > >
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
>
>
>
> --
> Best Regards！
> Huxing
>

Re: [Call for talks] Dubbo Guangzhou meetup

[Imteyaz Khan]

No worries. Would there be english version of dubbo presentations(e.g. ppt)?


On Tue, Dec 18, 2018 at 12:10 PM Huxing Zhang  wrote:

> Hi,
>
> On Tue, Dec 18, 2018 at 2:27 PM Imteyaz Khan 
> wrote:
> >
> > Will be there any web cast (live streaming of meetup) for those who may
> not
> > be able to attend this meetup (As I will be one of those :) ) ?
>
> Yes, there is! Will put it on the mailing list when possible, and
> please also follow the official Twitter account @ApacheDubbo for
> latest updates.
>
> But unfortunately most of the talks are in Chinese. :)
>
> I am not sure if there is auto translation in the live streaming ...
> >
> >
> >
> >
> > On Tue, Dec 18, 2018 at 11:14 AM Eric Zhao  wrote:
> >
> > > Hi,
> > >
> > > I'd like to share a talk about Sentinel [1], a powerful flow-control
> > > component open-sourced by Alibaba, enabling resilience and reliability
> for
> > > microservices.
> > >
> > > ## Topic
> > >
> > > Sentinel: The flow sentinel of your services
> > >
> > > ## Abstract
> > >
> > > - Introduce main features and scenarios of Sentinel, including cluster
> flow
> > > control, the new-released feature in Sentinel 1.4.0
> > > - Provide comparison with other open-source circuit breaking libraries
> to
> > > help users to choose the appropriate component
> > > - Introduce the roadmap of Sentinel
> > >
> > > [1] https://github.com/alibaba/Sentinel
> > >
> > >
> > > Best Regards,
> > > Eric
> > >
> > >
> > > On 2018/12/13 08:17:33, Huxing Zhang  wrote:
> > > > Hi,>
> > > >
> > > > I am pleased to announce that the Dubbo community are going to hold a
> > > meetup in>
> > > > Guangzhou on January 19th (Saturday), and we are now open to
> community
> > > talks>
> > > > about:>
> > > >
> > > > * How to contribute to Dubbo>
> > > > * How we use Dubbo in production system>
> > > > * Dubbo best practice>
> > > > * Integrate Dubbo with other open source software>
> > > > * Other topics involving Dubbo>
> > > >
> > > > Please submit your proposal including your topic, abstract, and>
> > > > speaker bio, submit by this link[1], and please also let the
> community>
> > > > to know by replying this email.>
> > > >
> > > > The call for talks will close by Dec 21st.>
> > > >
> > > > Below is a template:>
> > > >
> > > > ### Topic>
> > > >
> > > > Your awesome topic goes here>
> > > >
> > > > ### Abstract>
> > > >
> > > > Your awesome abstract goes here>
> > > >
> > > > ### Speaker Bio>
> > > >
> > > > Your awesome bio goes here>
> > > >
> > > > [1] http://alibabadeveloper.mikecrm.com/QBJtbV1>
> > > >
> > > > -->
> > > > Best Regards！>
> > > > Huxing>
> > > >
> > >
>
>
>
> --
> Best Regards！
> Huxing
>

Re: [Call for talks] Dubbo Guangzhou meetup

[Imteyaz Khan]

Will be there any web cast (live streaming of meetup) for those who may not
be able to attend this meetup (As I will be one of those :) ) ?




On Tue, Dec 18, 2018 at 11:14 AM Eric Zhao  wrote:

> Hi,
>
> I'd like to share a talk about Sentinel [1], a powerful flow-control
> component open-sourced by Alibaba, enabling resilience and reliability for
> microservices.
>
> ## Topic
>
> Sentinel: The flow sentinel of your services
>
> ## Abstract
>
> - Introduce main features and scenarios of Sentinel, including cluster flow
> control, the new-released feature in Sentinel 1.4.0
> - Provide comparison with other open-source circuit breaking libraries to
> help users to choose the appropriate component
> - Introduce the roadmap of Sentinel
>
> [1] https://github.com/alibaba/Sentinel
>
>
> Best Regards,
> Eric
>
>
> On 2018/12/13 08:17:33, Huxing Zhang  wrote:
> > Hi,>
> >
> > I am pleased to announce that the Dubbo community are going to hold a
> meetup in>
> > Guangzhou on January 19th (Saturday), and we are now open to community
> talks>
> > about:>
> >
> > * How to contribute to Dubbo>
> > * How we use Dubbo in production system>
> > * Dubbo best practice>
> > * Integrate Dubbo with other open source software>
> > * Other topics involving Dubbo>
> >
> > Please submit your proposal including your topic, abstract, and>
> > speaker bio, submit by this link[1], and please also let the community>
> > to know by replying this email.>
> >
> > The call for talks will close by Dec 21st.>
> >
> > Below is a template:>
> >
> > ### Topic>
> >
> > Your awesome topic goes here>
> >
> > ### Abstract>
> >
> > Your awesome abstract goes here>
> >
> > ### Speaker Bio>
> >
> > Your awesome bio goes here>
> >
> > [1] http://alibabadeveloper.mikecrm.com/QBJtbV1>
> >
> > -->
> > Best Regards！>
> > Huxing>
> >
>

Re: Apache dubbo website filter content (should we change)

[Imteyaz Khan]

Just noticed as this is PR is release to dubbo-website, so was not sure
whether do I need to PR email to another group. Any guide will be
appreciated.


On Fri, Dec 14, 2018 at 3:18 PM Imteyaz Khan  wrote:

> Hi, all
>
> I have raised the PR for dubbo website docs package name changes for the
> issue id 201
> <https://github.com/apache/incubator-dubbo-website/issues/201.>. Please
> find the PR details below
>
> https://github.com/apache/incubator-dubbo-website/pull/204
>
>
>
> On Fri, Dec 14, 2018 at 2:01 PM Ian Luo  wrote:
>
>> cool.
>>
>> On Fri, Dec 14, 2018 at 1:11 PM Imteyaz Khan 
>> wrote:
>>
>> > @Ian and @ huxing thanks a lot for guiding me on this, appreciate it.
>> > I have created an issue for the same and the issue link is
>> > https://github.com/apache/incubator-dubbo-website/issues/201.
>> >
>> > I am on it.
>> >
>> > Regards
>> > Imteyaz
>> >
>> > On Fri, Dec 14, 2018 at 9:13 AM Ian Luo  wrote:
>> >
>> > > Khan,
>> > >
>> > > As Huxing said, the package name has already change to
>> org.apache.dubbo
>> > on
>> > > branch 'master' for 2.7 releases. Pls. simply keep doc align with the
>> > main
>> > > trunk.
>> > >
>> > > Thanks,
>> > > -Ian.
>> > >
>> > > On Fri, Dec 14, 2018 at 1:39 AM Imteyaz Khan 
>> > > wrote:
>> > >
>> > > > Hi All,
>> > > >As part of one of my documentation task #2935, to get some more
>> > idea I
>> > > > was referring to
>> > > http://dubbo.apache.org/en-us/docs/dev/impls/filter.html
>> > > > page and come across some content which I am pasting below
>> > > >
>> > > > Existing Extension
>> > > >
>> > > >- com.alibaba.dubbo.rpc.filter.EchoFilter
>> > > >- com.alibaba.dubbo.rpc.filter.GenericFilter
>> > > >- com.alibaba.dubbo.rpc.filter.GenericImplFilter
>> > > >
>> > > >
>> > > > META-INF/dubbo/com.alibaba.dubbo.rpc.Filter：
>> > > >
>> > > > I believe the examples mentioned here (website) will work and people
>> > will
>> > > > get the information they are looking for, my query here is, is there
>> > any
>> > > > plan for changing it to org.apache.dubbo.* package notation or for
>> now
>> > it
>> > > > is ok?
>> > > >
>> > > > Regards
>> > > > Imteyaz
>> > > >
>> > >
>> >
>>
>

Re: Apache dubbo website filter content (should we change)

[Imteyaz Khan]

Hi, all

I have raised the PR for dubbo website docs package name changes for the
issue id 201 <https://github.com/apache/incubator-dubbo-website/issues/201.>.
Please find the PR details below

https://github.com/apache/incubator-dubbo-website/pull/204



On Fri, Dec 14, 2018 at 2:01 PM Ian Luo  wrote:

> cool.
>
> On Fri, Dec 14, 2018 at 1:11 PM Imteyaz Khan 
> wrote:
>
> > @Ian and @ huxing thanks a lot for guiding me on this, appreciate it.
> > I have created an issue for the same and the issue link is
> > https://github.com/apache/incubator-dubbo-website/issues/201.
> >
> > I am on it.
> >
> > Regards
> > Imteyaz
> >
> > On Fri, Dec 14, 2018 at 9:13 AM Ian Luo  wrote:
> >
> > > Khan,
> > >
> > > As Huxing said, the package name has already change to org.apache.dubbo
> > on
> > > branch 'master' for 2.7 releases. Pls. simply keep doc align with the
> > main
> > > trunk.
> > >
> > > Thanks,
> > > -Ian.
> > >
> > > On Fri, Dec 14, 2018 at 1:39 AM Imteyaz Khan 
> > > wrote:
> > >
> > > > Hi All,
> > > >As part of one of my documentation task #2935, to get some more
> > idea I
> > > > was referring to
> > > http://dubbo.apache.org/en-us/docs/dev/impls/filter.html
> > > > page and come across some content which I am pasting below
> > > >
> > > > Existing Extension
> > > >
> > > >- com.alibaba.dubbo.rpc.filter.EchoFilter
> > > >- com.alibaba.dubbo.rpc.filter.GenericFilter
> > > >- com.alibaba.dubbo.rpc.filter.GenericImplFilter
> > > >
> > > >
> > > > META-INF/dubbo/com.alibaba.dubbo.rpc.Filter：
> > > >
> > > > I believe the examples mentioned here (website) will work and people
> > will
> > > > get the information they are looking for, my query here is, is there
> > any
> > > > plan for changing it to org.apache.dubbo.* package notation or for
> now
> > it
> > > > is ok?
> > > >
> > > > Regards
> > > > Imteyaz
> > > >
> > >
> >
>

Re: Apache dubbo website filter content (should we change)

[Imteyaz Khan]

@Ian and @ huxing thanks a lot for guiding me on this, appreciate it.
I have created an issue for the same and the issue link is
https://github.com/apache/incubator-dubbo-website/issues/201.

I am on it.

Regards
Imteyaz

On Fri, Dec 14, 2018 at 9:13 AM Ian Luo  wrote:

> Khan,
>
> As Huxing said, the package name has already change to org.apache.dubbo on
> branch 'master' for 2.7 releases. Pls. simply keep doc align with the main
> trunk.
>
> Thanks,
> -Ian.
>
> On Fri, Dec 14, 2018 at 1:39 AM Imteyaz Khan 
> wrote:
>
> > Hi All,
> >As part of one of my documentation task #2935, to get some more idea I
> > was referring to
> http://dubbo.apache.org/en-us/docs/dev/impls/filter.html
> > page and come across some content which I am pasting below
> >
> > Existing Extension
> >
> >- com.alibaba.dubbo.rpc.filter.EchoFilter
> >- com.alibaba.dubbo.rpc.filter.GenericFilter
> >- com.alibaba.dubbo.rpc.filter.GenericImplFilter
> >
> >
> > META-INF/dubbo/com.alibaba.dubbo.rpc.Filter：
> >
> > I believe the examples mentioned here (website) will work and people will
> > get the information they are looking for, my query here is, is there any
> > plan for changing it to org.apache.dubbo.* package notation or for now it
> > is ok?
> >
> > Regards
> > Imteyaz
> >
>

Apache dubbo website filter content (should we change)

[Imteyaz Khan]

Hi All,
   As part of one of my documentation task #2935, to get some more idea I
was referring to http://dubbo.apache.org/en-us/docs/dev/impls/filter.html
page and come across some content which I am pasting below

Existing Extension

   - com.alibaba.dubbo.rpc.filter.EchoFilter
   - com.alibaba.dubbo.rpc.filter.GenericFilter
   - com.alibaba.dubbo.rpc.filter.GenericImplFilter


META-INF/dubbo/com.alibaba.dubbo.rpc.Filter：

I believe the examples mentioned here (website) will work and people will
get the information they are looking for, my query here is, is there any
plan for changing it to org.apache.dubbo.* package notation or for now it
is ok?

Regards
Imteyaz

Re: [Integration] Dubbo integrates with Nacos as a registry

[Imteyaz Khan]

@Yuhang Xiu thanks for the greet.

On Wed, Dec 12, 2018 at 1:48 PM yuhang xiu  wrote:

> Nice work, @khan
>
> I saw that you helped us to review a lot of PR, welcome you to make more
> contributions, I am looking forward to it.
> :)
>
> Imteyaz Khan  于2018年12月12日周三 下午4:00写道：
>
> > Sure, I will do that.
> >
> > Regards
> > Imteyaz
> >
> > On 12 Dec 2018 1:13 p.m., "Mercy"  wrote:
> >
> > > Hi, Imteyaz,
> > >
> > > Of course, thanks in advance, you could get source code from
> > > https://github.com/dubbo/dubbo-registry-nacos, and discuss with
> > commutity
> > > in issues.
> > >
> > >
> > > Kind regards,
> > > Mercy Ma
> > >
> > > 在 2018/12/12 下午2:50, Imteyaz Khan 写道:
> > >
> > >> Mercy Ma,
> > >> Is there any way I can assist you on this task? This one can help
> me
> > >> to
> > >> learn bit more about dubbo.
> > >>
> > >> Regards
> > >> Imteyaz
> > >>
> > >> On Tue, Dec 11, 2018 at 3:09 PM Huxing Zhang 
> wrote:
> > >>
> > >> Good job!
> > >>>
> > >>> With the separation between registration center and configuration
> > >>> center in Dubbo 2.7, it allows Dubbo to be able to have more choices
> > >>> of service discovery except ZooKeeper, for example, Nacos, consul,
> > >>> etcd, and third party configuration center such as Apollo[1].
> > >>>
> > >>> [1] https://github.com/ctripcorp/apollo
> > >>>
> > >>> On Tue, Dec 11, 2018 at 4:29 PM Mercy Ma 
> > wrote:
> > >>>
> > >>>> Hi, community,
> > >>>>
> > >>>> I'm working at integration between Dubbo and Nacos. Nacos <
> > >>>>
> > >>> https://nacos.io>
> > >>>
> > >>>> is an easy-to-use dynamic service discovery, configuration and
> service
> > >>>> management platform for building cloud native applications, it has
> > been
> > >>>> integrated into Spring Cloud Alibaba
> > >>>> <https://github.com/spring-cloud-incubator/spring-cloud-alibaba> as
> > the
> > >>>> service registration and discovery component. Like the ZooKeeper,
> > Nacos
> > >>>> will be used as a Dubbo registry.
> > >>>>
> > >>>>
> > >>>> Kind regards,
> > >>>> Mercy Ma
> > >>>> --
> > >>>> GMail: mercybl...@gmail.com
> > >>>> Weibo/Wechat: mercyblitz <https://weibo.com/mercyblitz>
> > >>>> Blog:  <http://goog_408526246>*https://mercyblitz.github.io/
> > >>>> <https://mercyblitz.github.io/>*
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> Best Regards！
> > >>> Huxing
> > >>>
> > >>>
> > >
> >
>

Re: [Integration] Dubbo integrates with Nacos as a registry

[Imteyaz Khan]

Sure, I will do that.

Regards
Imteyaz

On 12 Dec 2018 1:13 p.m., "Mercy"  wrote:

> Hi, Imteyaz,
>
> Of course, thanks in advance, you could get source code from
> https://github.com/dubbo/dubbo-registry-nacos, and discuss with commutity
> in issues.
>
>
> Kind regards,
> Mercy Ma
>
> 在 2018/12/12 下午2:50, Imteyaz Khan 写道:
>
>> Mercy Ma,
>> Is there any way I can assist you on this task? This one can help me
>> to
>> learn bit more about dubbo.
>>
>> Regards
>> Imteyaz
>>
>> On Tue, Dec 11, 2018 at 3:09 PM Huxing Zhang  wrote:
>>
>> Good job!
>>>
>>> With the separation between registration center and configuration
>>> center in Dubbo 2.7, it allows Dubbo to be able to have more choices
>>> of service discovery except ZooKeeper, for example, Nacos, consul,
>>> etcd, and third party configuration center such as Apollo[1].
>>>
>>> [1] https://github.com/ctripcorp/apollo
>>>
>>> On Tue, Dec 11, 2018 at 4:29 PM Mercy Ma  wrote:
>>>
>>>> Hi, community,
>>>>
>>>> I'm working at integration between Dubbo and Nacos. Nacos <
>>>>
>>> https://nacos.io>
>>>
>>>> is an easy-to-use dynamic service discovery, configuration and service
>>>> management platform for building cloud native applications, it has been
>>>> integrated into Spring Cloud Alibaba
>>>> <https://github.com/spring-cloud-incubator/spring-cloud-alibaba> as the
>>>> service registration and discovery component. Like the ZooKeeper, Nacos
>>>> will be used as a Dubbo registry.
>>>>
>>>>
>>>> Kind regards,
>>>> Mercy Ma
>>>> --
>>>> GMail: mercybl...@gmail.com
>>>> Weibo/Wechat: mercyblitz <https://weibo.com/mercyblitz>
>>>> Blog:  <http://goog_408526246>*https://mercyblitz.github.io/
>>>> <https://mercyblitz.github.io/>*
>>>>
>>>
>>>
>>> --
>>> Best Regards！
>>> Huxing
>>>
>>>
>

Re: [Integration] Dubbo integrates with Nacos as a registry

[Imteyaz Khan]

Mercy Ma,
   Is there any way I can assist you on this task? This one can help me to
learn bit more about dubbo.

Regards
Imteyaz

On Tue, Dec 11, 2018 at 3:09 PM Huxing Zhang  wrote:

> Good job!
>
> With the separation between registration center and configuration
> center in Dubbo 2.7, it allows Dubbo to be able to have more choices
> of service discovery except ZooKeeper, for example, Nacos, consul,
> etcd, and third party configuration center such as Apollo[1].
>
> [1] https://github.com/ctripcorp/apollo
>
> On Tue, Dec 11, 2018 at 4:29 PM Mercy Ma  wrote:
> >
> > Hi, community,
> >
> > I'm working at integration between Dubbo and Nacos. Nacos <
> https://nacos.io>
> > is an easy-to-use dynamic service discovery, configuration and service
> > management platform for building cloud native applications, it has been
> > integrated into Spring Cloud Alibaba
> >  as the
> > service registration and discovery component. Like the ZooKeeper, Nacos
> > will be used as a Dubbo registry.
> >
> >
> > Kind regards,
> > Mercy Ma
> > --
> > GMail: mercybl...@gmail.com
> > Weibo/Wechat: mercyblitz 
> > Blog:  *https://mercyblitz.github.io/
> > *
>
>
>
> --
> Best Regards！
> Huxing
>

Re: Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

Thanks a lot, appreciate it.

On Tue, Dec 11, 2018 at 7:03 AM Huxing Zhang  wrote:

> Hi,
>
> On Tue, Dec 11, 2018 at 3:04 AM Imteyaz Khan 
> wrote:
> >
> > Created an documentation an #2935
> > <https://github.com/apache/incubator-dubbo/issues/2935> issue  (Creating
> > dubbo dubbo-rpc-api java documentation) and will be on it, could someone
> > tag or assigned it to me.
>
> I've assigned it to you and add the issue to the project[1]. Happy coding!
>
> [1] https://github.com/apache/incubator-dubbo/projects/2
>
> >
> > Regards
> > Imteyaz
> >
> 
>
>
>
> --
> Best Regards！
> Huxing
>

Re: Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

Created an documentation an #2935
<https://github.com/apache/incubator-dubbo/issues/2935> issue  (Creating
dubbo dubbo-rpc-api java documentation) and will be on it, could someone
tag or assigned it to me.

Regards
Imteyaz

On Sat, Dec 8, 2018 at 7:19 PM Huxing Zhang  wrote:

> Hi Imteyaz,
>
> On Fri, Dec 7, 2018 at 9:30 PM Imteyaz Khan 
> wrote:
> >
> > Hi All,
> >   I have created the pull
> > <https://github.com/apache/incubator-dubbo/pull/2921>request for github
> > issue 2884 (which is getting used in the email thread). This PR is for
> > dubbo-filter modules (dubbo-filter-cache and dubbo-filter-validation).
>
> I've reviewed your pull request and it looks good to me, I have merged
> your pr already.
> I think it is really a good starting point, hope to see your further
> contributions!
>
> > While this is in PR is in review state I will take the other module of
> > writing javadoc and comments, I was thinking to start another email
> thread
> > for another documentation task or should I continue the same.
>
> Both are ok, it is up to you to decide. :)
>
> >
> > https://github.com/apache/incubator-dubbo/pull/2921
> >
> >
> > Regards
> > Imteyaz
> >
> > On Thu, Dec 6, 2018 at 4:57 PM Ian Luo  wrote:
> >
> > > :) welcome to the community.
> > >
> > > On Thu, Dec 6, 2018 at 2:58 PM Imteyaz Khan 
> > > wrote:
> > >
> > > > Ian,
> > > >
> > > > Thanks for guiding me. I am on it.
> > > >
> > > > Regards
> > > > Imteyaz
> > > >
> > > >
> > > > On 6 Dec 2018 11:49 a.m., "Ian Luo"  wrote:
> > > >
> > > > Hi Khan,
> > > >
> > > > Feel free to start from any module to enhance the existing JavaDoc
> and
> > > > comments, and submit the pull request when you feel it's ready. I am
> so
> > > > glad that there's native speaker willing to join this effort :)
> > > >
> > > > Thanks,
> > > > -Ian.
> > > >
> > > >
> > > > On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan 
> > > > wrote:
> > > >
> > > > > I have just started documenting module 'dubbo-filter',  below are
> > > example
> > > > > of mine, this is just to make sure I am in align with the
> documentation
> > > > > style
> > > > >
> > > > > /**
> > > > >  * CacheFilter is a core component of dubbo.Enabling cache
> key
> > > > > of service,method,consumer or provider dubbo will cache method
> return
> > > > > value.
> > > > >  * Along with cache key we need to configure cache type. Dubbo
> default
> > > > > implemented cache types are
> > > > >  * lur
> > > > >  * threadlocal
> > > > >  * jcache
> > > > >  * expiring
> > > > >  *
> > > > >  * 
> > > > >  *   e.g. 1)dubbo:service cache="lru" /
> > > > >  *2)dubbo:service / dubbo:method name="method2"
> > > > > cache="threadlocal" / dubbo:service/
> > > > >  *3)dubbo:provider cache="expiring" /
> > > > >  *4)dubbo:consumer cache="jcache" /
> > > > >  *
> > > > >  *If cache type is defined in method level then method level type
> will
> > > > > get precedence. According to above provided
> > > > >  *example, if service has two method, method1 and method2, method2
> > > > > will have cache type as threadlocal where others will
> > > > >  *be backed by lru
> > > > >  *
> > > > >  *
> > > > >  * @see org.apache.dubbo.rpc.Filter
> > > > >  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
> > > > >  * @see org.apache.dubbo.cache.support.lru.LruCache
> > > > >  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
> > > > >  * @see org.apache.dubbo.cache.support.jcache.JCache
> > > > >  * @see
> > > > org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
> > > > >  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
> > > > >  * @see
> org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
> > > > >  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
> > > > >  *
> &g

Re: Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

Hi All,
  I have created the pull
<https://github.com/apache/incubator-dubbo/pull/2921>request for github
issue 2884 (which is getting used in the email thread). This PR is for
dubbo-filter modules (dubbo-filter-cache and dubbo-filter-validation).
While this is in PR is in review state I will take the other module of
writing javadoc and comments, I was thinking to start another email thread
for another documentation task or should I continue the same.

https://github.com/apache/incubator-dubbo/pull/2921


Regards
Imteyaz

On Thu, Dec 6, 2018 at 4:57 PM Ian Luo  wrote:

> :) welcome to the community.
>
> On Thu, Dec 6, 2018 at 2:58 PM Imteyaz Khan 
> wrote:
>
> > Ian,
> >
> > Thanks for guiding me. I am on it.
> >
> > Regards
> > Imteyaz
> >
> >
> > On 6 Dec 2018 11:49 a.m., "Ian Luo"  wrote:
> >
> > Hi Khan,
> >
> > Feel free to start from any module to enhance the existing JavaDoc and
> > comments, and submit the pull request when you feel it's ready. I am so
> > glad that there's native speaker willing to join this effort :)
> >
> > Thanks,
> > -Ian.
> >
> >
> > On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan 
> > wrote:
> >
> > > I have just started documenting module 'dubbo-filter',  below are
> example
> > > of mine, this is just to make sure I am in align with the documentation
> > > style
> > >
> > > /**
> > >  * CacheFilter is a core component of dubbo.Enabling cache key
> > > of service,method,consumer or provider dubbo will cache method return
> > > value.
> > >  * Along with cache key we need to configure cache type. Dubbo default
> > > implemented cache types are
> > >  * lur
> > >  * threadlocal
> > >  * jcache
> > >  * expiring
> > >  *
> > >  * 
> > >  *   e.g. 1)dubbo:service cache="lru" /
> > >  *2)dubbo:service / dubbo:method name="method2"
> > > cache="threadlocal" / dubbo:service/
> > >  *3)dubbo:provider cache="expiring" /
> > >  *4)dubbo:consumer cache="jcache" /
> > >  *
> > >  *If cache type is defined in method level then method level type will
> > > get precedence. According to above provided
> > >  *example, if service has two method, method1 and method2, method2
> > > will have cache type as threadlocal where others will
> > >  *be backed by lru
> > >  *
> > >  *
> > >  * @see org.apache.dubbo.rpc.Filter
> > >  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
> > >  * @see org.apache.dubbo.cache.support.lru.LruCache
> > >  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
> > >  * @see org.apache.dubbo.cache.support.jcache.JCache
> > >  * @see
> > org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
> > >  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
> > >  * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
> > >  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
> > >  *
> > >  */
> > > @Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
> > > Constants.CACHE_KEY)
> > > public class CacheFilter implements Filter {
> > >
> > > 
> > >
> > > .
> > >
> > > }
> > >
> > >
> > > On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan 
> > > wrote:
> > >
> > > > Just to make sure I have not misunderstood what mentioned earlier by
> > > > 'Filter' is 'dubbo-filter' correct?
> > > >
> > > > On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> > > > wrote:
> > > >
> > > >> Thanks a lot for the start, much appreciated.
> > > >>
> > > >>
> > > >>
> > > >> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu 
> wrote:
> > > >>
> > > >>> In addition, we strongly encourage open discussion.
> > > >>> You can post your comments on a Filter directly here. There will be
> > > some
> > > >>> people who know more about dubbo to review and discuss.
> > > >>>
> > > >>> Of course, any problem can be raised here. We will answer as soon
> as
> > > >>> possible.
> > > >>>
> > > >>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> > > >>>
> > > >>> > 

Re: Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

Ian,

Thanks for guiding me. I am on it.

Regards
Imteyaz


On 6 Dec 2018 11:49 a.m., "Ian Luo"  wrote:

Hi Khan,

Feel free to start from any module to enhance the existing JavaDoc and
comments, and submit the pull request when you feel it's ready. I am so
glad that there's native speaker willing to join this effort :)

Thanks,
-Ian.


On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan  wrote:

> I have just started documenting module 'dubbo-filter',  below are example
> of mine, this is just to make sure I am in align with the documentation
> style
>
> /**
>  * CacheFilter is a core component of dubbo.Enabling cache key
> of service,method,consumer or provider dubbo will cache method return
> value.
>  * Along with cache key we need to configure cache type. Dubbo default
> implemented cache types are
>  * lur
>  * threadlocal
>  * jcache
>  * expiring
>  *
>  * 
>  *   e.g. 1)dubbo:service cache="lru" /
>  *2)dubbo:service / dubbo:method name="method2"
> cache="threadlocal" / dubbo:service/
>  *3)dubbo:provider cache="expiring" /
>  *4)dubbo:consumer cache="jcache" /
>  *
>  *If cache type is defined in method level then method level type will
> get precedence. According to above provided
>  *example, if service has two method, method1 and method2, method2
> will have cache type as threadlocal where others will
>  *be backed by lru
>  *
>  *
>  * @see org.apache.dubbo.rpc.Filter
>  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
>  * @see org.apache.dubbo.cache.support.lru.LruCache
>  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
>  * @see org.apache.dubbo.cache.support.jcache.JCache
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
>  *
>  */
> @Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
> Constants.CACHE_KEY)
> public class CacheFilter implements Filter {
>
> 
>
> .
>
> }
>
>
> On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan 
> wrote:
>
> > Just to make sure I have not misunderstood what mentioned earlier by
> > 'Filter' is 'dubbo-filter' correct?
> >
> > On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> > wrote:
> >
> >> Thanks a lot for the start, much appreciated.
> >>
> >>
> >>
> >> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> >>
> >>> In addition, we strongly encourage open discussion.
> >>> You can post your comments on a Filter directly here. There will be
> some
> >>> people who know more about dubbo to review and discuss.
> >>>
> >>> Of course, any problem can be raised here. We will answer as soon as
> >>> possible.
> >>>
> >>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> >>>
> >>> > very sorry. I have some work now, so I didn't respond to your email
> in
> >>> > time.
> >>> > I am very willing to help you with the completion of the comments.
If
> >>> you
> >>> > are a newbie, I suggest you start with a simple logic.
> >>> > Which parts of the logic are relatively simple? At present, I think
> >>> that
> >>> > our filter-related implementation is relatively simple (such as
> >>> > ActiveLimitFilter). You don't know the principle of dubbo at all,
and
> >>> you
> >>> > can understand the code and complete the comments more easily. You
> can
> >>> > start with the Filter related class and complete some of the
> comments.
> >>> >
> >>> > When you think that you know enough about dubbo, you can do some
core
> >>> > module comments, such as protocol-related comments.
> >>> >
> >>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >>> >
> >>> >> Hi All,
> >>> >>Trust you all are doing well. I am new to this community or even
> >>> new to
> >>> >> any open source development community. Had a chance to go through
> one
> >>> of
> >>> >> the dubbo github issue #2884('We need more code comments'), which
> was
> >>> >> marked as 'good first issue'. So thought it could be a good start
> for
> >>> me
> >>> >> to
> >>> >> start from here, but being new to open source and also to dubbo I
am
> >>> very
> >>> >> nervous from where and how to start. I will be great if team can
> help
> >>> me
> >>> >> and guide me too to assist you in any way I can.
> >>> >>
> >>> >> Regards
> >>> >> Imteyaz
> >>> >>
> >>> >
> >>>
> >>
>

Re: Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

I have just started documenting module 'dubbo-filter',  below are example
of mine, this is just to make sure I am in align with the documentation
style

/**
 * CacheFilter is a core component of dubbo.Enabling cache key
of service,method,consumer or provider dubbo will cache method return
value.
 * Along with cache key we need to configure cache type. Dubbo default
implemented cache types are
 * lur
 * threadlocal
 * jcache
 * expiring
 *
 * 
 *   e.g. 1)dubbo:service cache="lru" /
 *2)dubbo:service / dubbo:method name="method2"
cache="threadlocal" / dubbo:service/
 *3)dubbo:provider cache="expiring" /
 *4)dubbo:consumer cache="jcache" /
 *
 *If cache type is defined in method level then method level type will
get precedence. According to above provided
 *example, if service has two method, method1 and method2, method2
will have cache type as threadlocal where others will
 *be backed by lru
 *
 *
 * @see org.apache.dubbo.rpc.Filter
 * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
 * @see org.apache.dubbo.cache.support.lru.LruCache
 * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
 * @see org.apache.dubbo.cache.support.jcache.JCache
 * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
 * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
 * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
 * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
 *
 */
@Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
Constants.CACHE_KEY)
public class CacheFilter implements Filter {



.

}


On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan  wrote:

> Just to make sure I have not misunderstood what mentioned earlier by
> 'Filter' is 'dubbo-filter' correct?
>
> On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> wrote:
>
>> Thanks a lot for the start, much appreciated.
>>
>>
>>
>> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
>>
>>> In addition, we strongly encourage open discussion.
>>> You can post your comments on a Filter directly here. There will be some
>>> people who know more about dubbo to review and discuss.
>>>
>>> Of course, any problem can be raised here. We will answer as soon as
>>> possible.
>>>
>>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
>>>
>>> > very sorry. I have some work now, so I didn't respond to your email in
>>> > time.
>>> > I am very willing to help you with the completion of the comments. If
>>> you
>>> > are a newbie, I suggest you start with a simple logic.
>>> > Which parts of the logic are relatively simple? At present, I think
>>> that
>>> > our filter-related implementation is relatively simple (such as
>>> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
>>> you
>>> > can understand the code and complete the comments more easily. You can
>>> > start with the Filter related class and complete some of the comments.
>>> >
>>> > When you think that you know enough about dubbo, you can do some core
>>> > module comments, such as protocol-related comments.
>>> >
>>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
>>> >
>>> >> Hi All,
>>> >>Trust you all are doing well. I am new to this community or even
>>> new to
>>> >> any open source development community. Had a chance to go through one
>>> of
>>> >> the dubbo github issue #2884('We need more code comments'), which was
>>> >> marked as 'good first issue'. So thought it could be a good start for
>>> me
>>> >> to
>>> >> start from here, but being new to open source and also to dubbo I am
>>> very
>>> >> nervous from where and how to start. I will be great if team can help
>>> me
>>> >> and guide me too to assist you in any way I can.
>>> >>
>>> >> Regards
>>> >> Imteyaz
>>> >>
>>> >
>>>
>>

Re: Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

Just to make sure I have not misunderstood what mentioned earlier by
'Filter' is 'dubbo-filter' correct?

On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan  wrote:

> Thanks a lot for the start, much appreciated.
>
>
>
> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
>
>> In addition, we strongly encourage open discussion.
>> You can post your comments on a Filter directly here. There will be some
>> people who know more about dubbo to review and discuss.
>>
>> Of course, any problem can be raised here. We will answer as soon as
>> possible.
>>
>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
>>
>> > very sorry. I have some work now, so I didn't respond to your email in
>> > time.
>> > I am very willing to help you with the completion of the comments. If
>> you
>> > are a newbie, I suggest you start with a simple logic.
>> > Which parts of the logic are relatively simple? At present, I think that
>> > our filter-related implementation is relatively simple (such as
>> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
>> you
>> > can understand the code and complete the comments more easily. You can
>> > start with the Filter related class and complete some of the comments.
>> >
>> > When you think that you know enough about dubbo, you can do some core
>> > module comments, such as protocol-related comments.
>> >
>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
>> >
>> >> Hi All,
>> >>Trust you all are doing well. I am new to this community or even
>> new to
>> >> any open source development community. Had a chance to go through one
>> of
>> >> the dubbo github issue #2884('We need more code comments'), which was
>> >> marked as 'good first issue'. So thought it could be a good start for
>> me
>> >> to
>> >> start from here, but being new to open source and also to dubbo I am
>> very
>> >> nervous from where and how to start. I will be great if team can help
>> me
>> >> and guide me too to assist you in any way I can.
>> >>
>> >> Regards
>> >> Imteyaz
>> >>
>> >
>>
>

Re: Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

Thanks a lot for the start, much appreciated.



On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:

> In addition, we strongly encourage open discussion.
> You can post your comments on a Filter directly here. There will be some
> people who know more about dubbo to review and discuss.
>
> Of course, any problem can be raised here. We will answer as soon as
> possible.
>
> yuhang xiu  于2018年12月5日周三 下午8:58写道：
>
> > very sorry. I have some work now, so I didn't respond to your email in
> > time.
> > I am very willing to help you with the completion of the comments. If you
> > are a newbie, I suggest you start with a simple logic.
> > Which parts of the logic are relatively simple? At present, I think that
> > our filter-related implementation is relatively simple (such as
> > ActiveLimitFilter). You don't know the principle of dubbo at all, and you
> > can understand the code and complete the comments more easily. You can
> > start with the Filter related class and complete some of the comments.
> >
> > When you think that you know enough about dubbo, you can do some core
> > module comments, such as protocol-related comments.
> >
> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >
> >> Hi All,
> >>Trust you all are doing well. I am new to this community or even new
> to
> >> any open source development community. Had a chance to go through one of
> >> the dubbo github issue #2884('We need more code comments'), which was
> >> marked as 'good first issue'. So thought it could be a good start for me
> >> to
> >> start from here, but being new to open source and also to dubbo I am
> very
> >> nervous from where and how to start. I will be great if team can help me
> >> and guide me too to assist you in any way I can.
> >>
> >> Regards
> >> Imteyaz
> >>
> >
>

Wanted to learn from you starting with issue #2884

[Imteyaz Khan]

Hi All,
   Trust you all are doing well. I am new to this community or even new to
any open source development community. Had a chance to go through one of
the dubbo github issue #2884('We need more code comments'), which was
marked as 'good first issue'. So thought it could be a good start for me to
start from here, but being new to open source and also new to dubbo, I am
bit nervous also excited to know from where and how to start. It will be
great if team can help me and guide me too to assist you in any way I can.

Regards
Imteyaz

Wanted to assist dubbo community on issue #2884

[Imteyaz Khan]

Hi All,
   Trust you all are doing well. I am new to this community or even new to
any open source development community. Had a chance to go through one of
the dubbo github issue #2884('We need more code comments'), which was
marked as 'good first issue'. So thought it could be a good start for me to
start from here, but being new to open source and also to dubbo I am very
nervous from where and how to start. I will be great if team can help me
and guide me too to assist you in any way I can.

Regards
Imteyaz