[jira] [Created] (EAGLE-141) fix some unit testing exception which is thrown within annoymous class

2016-01-27 Thread Edward Zhang (JIRA)
Edward Zhang created EAGLE-141:
--

 Summary: fix some unit testing exception which is thrown within 
annoymous class
 Key: EAGLE-141
 URL: https://issues.apache.org/jira/browse/EAGLE-141
 Project: Eagle
  Issue Type: Bug
Affects Versions: 0.3.0
Reporter: Edward Zhang
Priority: Minor
 Fix For: 0.3.0


Sometimes unit test fails but throw exception within a annoymous inner class, 
so it is not caught by junit framework.
for example https://builds.apache.org/job/incubator-eagle-main/24/console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120897#comment-15120897
 ] 

ASF GitHub Bot commented on EAGLE-81:
-

Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-176018966
  
@yonzhang  , thanks Edward , Let me rebase it ..


> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

2016-01-27 Thread senthilec566
Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-176018966
  
@yonzhang  , thanks Edward , Let me rebase it ..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

2016-01-27 Thread yonzhang
Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-176016132
  
@senthilec566 I have difficulty to apply the patch into current master (in 
my local), probably you need do rebase.

git apply 76.patch
error: 
eagle-core/eagle-alert/eagle-alert-base/src/main/java/org/apache/eagle/alert/common/AlertConstants.java:
 No such file or directory
error: patch failed: 
eagle-core/eagle-alert/eagle-alert-base/src/main/java/org/apache/eagle/alert/common/AlertEmailSender.java:1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120894#comment-15120894
 ] 

ASF GitHub Bot commented on EAGLE-81:
-

Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-176016132
  
@senthilec566 I have difficulty to apply the patch into current master (in 
my local), probably you need do rebase.

git apply 76.patch
error: 
eagle-core/eagle-alert/eagle-alert-base/src/main/java/org/apache/eagle/alert/common/AlertConstants.java:
 No such file or directory
error: patch failed: 
eagle-core/eagle-alert/eagle-alert-base/src/main/java/org/apache/eagle/alert/common/AlertEmailSender.java:1


> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (EAGLE-95) DAM HDFS topology fails to start, if there is invalid policy.

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120851#comment-15120851
 ] 

ASF GitHub Bot commented on EAGLE-95:
-

Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175999816
  
@murkrishn @senthilec566 I suggest a different solution. 
1. define a new interface in PolicyEvaluator called isMarkedDown()
2. It is PolicyEvaluator implementation's responsibility to determine if 
the policy is marked down or not. In our case, SiddhiPolicyEvaluator and 
MLPolicyEvaluator should implement this above interface
3. It is PolicyEvaluator implementation's responsibility to determine if 
the policy should be marked down based on parsing for Siddhi case. For 
SiddhiPolicyEvaluator, we can catch exception from createSiddhiRuntime method, 
then markdown this policy by setting one field(markedDown) to be true. That can 
be in SiddhiPolicyEvaluator constructor method and onPolicyUpdate method
4. It is PolicyProcessExecutor's responsibility to report markdown status 
back to eagle service. So probably we can check PolicyEvaluator's isMarkedDown 
after policy creation or update, and then write back to eagle service.
Please suggest if that will do well.


> DAM HDFS topology fails to start, if there is invalid policy.
> -
>
> Key: EAGLE-95
> URL: https://issues.apache.org/jira/browse/EAGLE-95
> Project: Eagle
>  Issue Type: Bug
>Reporter: hemanth dendukuri
>Assignee: Senthilkumar
>Priority: Critical
>
> Step 1: Create a invalid policy (from hdfsAuditLogEventStream[(cmd == 'open') 
> and (str:contains(src,'/tmp/p')==true)] select * insert into outputStream;) 
> Step 2 : Deploy Dam HDFS topology. 
> Actual : The HDFS topology could not start because of the invalid policy. 
> 2015-12-16 23:51:17 b.s.d.executor [INFO] Shutting down executor 
> AlertEntityDeduplicationExecutor_9:[2 2] 2015-12-16 23:51:17 b.s.util [INFO] 
> Async loop interrupted! 
> Expected: Topology should start ignoring the invalid policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...

2016-01-27 Thread yonzhang
Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175999816
  
@murkrishn @senthilec566 I suggest a different solution. 
1. define a new interface in PolicyEvaluator called isMarkedDown()
2. It is PolicyEvaluator implementation's responsibility to determine if 
the policy is marked down or not. In our case, SiddhiPolicyEvaluator and 
MLPolicyEvaluator should implement this above interface
3. It is PolicyEvaluator implementation's responsibility to determine if 
the policy should be marked down based on parsing for Siddhi case. For 
SiddhiPolicyEvaluator, we can catch exception from createSiddhiRuntime method, 
then markdown this policy by setting one field(markedDown) to be true. That can 
be in SiddhiPolicyEvaluator constructor method and onPolicyUpdate method
4. It is PolicyProcessExecutor's responsibility to report markdown status 
back to eagle service. So probably we can check PolicyEvaluator's isMarkedDown 
after policy creation or update, and then write back to eagle service.
Please suggest if that will do well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-95) DAM HDFS topology fails to start, if there is invalid policy.

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120774#comment-15120774
 ] 

ASF GitHub Bot commented on EAGLE-95:
-

Github user murkrishn commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175984692
  
Thanks for pointing it out @yonzhang.

To avoid the same, I will still go with determining the markdown for the 
policy at PolicyProcessExecutor class (methods - createPolicyEvaluator and 
onPolicyChanged) and pass on the flag to PolicyEvaluator (will be adding 
another method for onPolicyUpdate which will take in a additional parameter for 
markdown). This will remove the query parsing at the 
SiddhiPolicyEvaluator.createSiddhiRuntime as we will be modifying it to have an 
additional parameter to be passed in for markdown. Is this approach good to go ?


> DAM HDFS topology fails to start, if there is invalid policy.
> -
>
> Key: EAGLE-95
> URL: https://issues.apache.org/jira/browse/EAGLE-95
> Project: Eagle
>  Issue Type: Bug
>Reporter: hemanth dendukuri
>Assignee: Senthilkumar
>Priority: Critical
>
> Step 1: Create a invalid policy (from hdfsAuditLogEventStream[(cmd == 'open') 
> and (str:contains(src,'/tmp/p')==true)] select * insert into outputStream;) 
> Step 2 : Deploy Dam HDFS topology. 
> Actual : The HDFS topology could not start because of the invalid policy. 
> 2015-12-16 23:51:17 b.s.d.executor [INFO] Shutting down executor 
> AlertEntityDeduplicationExecutor_9:[2 2] 2015-12-16 23:51:17 b.s.util [INFO] 
> Async loop interrupted! 
> Expected: Topology should start ignoring the invalid policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...

2016-01-27 Thread murkrishn
Github user murkrishn commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175984692
  
Thanks for pointing it out @yonzhang.

To avoid the same, I will still go with determining the markdown for the 
policy at PolicyProcessExecutor class (methods - createPolicyEvaluator and 
onPolicyChanged) and pass on the flag to PolicyEvaluator (will be adding 
another method for onPolicyUpdate which will take in a additional parameter for 
markdown). This will remove the query parsing at the 
SiddhiPolicyEvaluator.createSiddhiRuntime as we will be modifying it to have an 
additional parameter to be passed in for markdown. Is this approach good to go ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread Senthilkumar (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120762#comment-15120762
 ] 

Senthilkumar commented on EAGLE-81:
---

@RalphSu , thanks for pointing out . Yes , Eagle has Entity Repository Scanner. 
If i want to use EntityScanner, the entity should be registered with Entity 
Repository..

Here requirement is different..

Say , as a user i want to use eagle monitoring , eagle provides end to end 
components ..but as user i want to forward generated alert to Other System for 
Visuvalization .. in this case in Eagle we provide Plugin to implement and 
write their OWN business logic .. During deployment , users will upload their 
integrated library .. At the time of Topology Start Eagle should start load all 
API's which implements NotificationPlugin ..

I was thinking that Using Reflection API we could achieve this requirement :) ..

Per @yonzhang Edward's Suggestion , We can follow How PolicyManager Loads 
(Using JAVA SPI )..

I'll change from Reflection to JAVA SPI , i think that will avoid another 
dependency library :) .

TO summarize this :

1) For Entity Scanning - EntityRepositoryScanner
2) Loading API's which implements Specific Interface - JAVA SPI

> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120755#comment-15120755
 ] 

ASF GitHub Bot commented on EAGLE-81:
-

Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175976351
  
@RalphSu  , Yes , Eagle has Entity Repository Scanner.  If i want to use 
EntityScanner, the entity should be registered with Entity Repository..

My requirement is completely different..

Say , as a user i want to use eagle monitoring  , eagle provides end to end 
components ..but as user i want to forward generated alert to Other System for 
Visuvalization .. in this case in Eagle we provide Plugin to implement and 
write their OWN business logic .. During deployment , users will upload their 
integrated library .. At the time of Topology Start Eagle should start load all 
API's which implements NotificationPlugin ..  
I was thinking that Using Reflection API we could achieve this requirement 
:) .. 

Per @yonzhang  Edward's Suggestion , We can follow How PolicyManager Loads  
(Using JAVA SPI )..


> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

2016-01-27 Thread senthilec566
Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175976351
  
@RalphSu  , Yes , Eagle has Entity Repository Scanner.  If i want to use 
EntityScanner, the entity should be registered with Entity Repository..

My requirement is completely different..

Say , as a user i want to use eagle monitoring  , eagle provides end to end 
components ..but as user i want to forward generated alert to Other System for 
Visuvalization .. in this case in Eagle we provide Plugin to implement and 
write their OWN business logic .. During deployment , users will upload their 
integrated library .. At the time of Topology Start Eagle should start load all 
API's which implements NotificationPlugin ..  
I was thinking that Using Reflection API we could achieve this requirement 
:) .. 

Per @yonzhang  Edward's Suggestion , We can follow How PolicyManager Loads  
(Using JAVA SPI )..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (EAGLE-140) Eagle Pipeline Package and Script

2016-01-27 Thread Hao Chen (JIRA)
Hao Chen created EAGLE-140:
--

 Summary: Eagle Pipeline Package and Script
 Key: EAGLE-140
 URL: https://issues.apache.org/jira/browse/EAGLE-140
 Project: Eagle
  Issue Type: Sub-task
Affects Versions: 0.3.0
Reporter: Hao Chen
Assignee: Hao Chen
 Fix For: 0.3.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (EAGLE-130) Eagle Pipeline DSL: Parser, Compiler, Runner

2016-01-27 Thread Hao Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/EAGLE-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hao Chen resolved EAGLE-130.

Resolution: Resolved

> Eagle Pipeline DSL: Parser, Compiler, Runner
> 
>
> Key: EAGLE-130
> URL: https://issues.apache.org/jira/browse/EAGLE-130
> Project: Eagle
>  Issue Type: Sub-task
>Reporter: Hao Chen
>Assignee: Hao Chen
>
> https://cwiki.apache.org/confluence/display/EAG/Dynamical+Monitoring+Framework#DynamicalMonitoringFramework-DynamicalPipelineBuilder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120640#comment-15120640
 ] 

ASF GitHub Bot commented on EAGLE-81:
-

Github user RalphSu commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175927655
  
Eagle already have a class scanning lib. You might want to check the 
EntityRepositoryScanner for the current usage. We might keep stick to one 
scanning library


> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

2016-01-27 Thread RalphSu
Github user RalphSu commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175927655
  
Eagle already have a class scanning lib. You might want to check the 
EntityRepositoryScanner for the current usage. We might keep stick to one 
scanning library


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-95) DAM HDFS topology fails to start, if there is invalid policy.

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119718#comment-15119718
 ] 

ASF GitHub Bot commented on EAGLE-95:
-

Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175729908
  
@yonzhang  , we will modify the code not to do two siddhi query parsing..


> DAM HDFS topology fails to start, if there is invalid policy.
> -
>
> Key: EAGLE-95
> URL: https://issues.apache.org/jira/browse/EAGLE-95
> Project: Eagle
>  Issue Type: Bug
>Reporter: hemanth dendukuri
>Assignee: Senthilkumar
>Priority: Critical
>
> Step 1: Create a invalid policy (from hdfsAuditLogEventStream[(cmd == 'open') 
> and (str:contains(src,'/tmp/p')==true)] select * insert into outputStream;) 
> Step 2 : Deploy Dam HDFS topology. 
> Actual : The HDFS topology could not start because of the invalid policy. 
> 2015-12-16 23:51:17 b.s.d.executor [INFO] Shutting down executor 
> AlertEntityDeduplicationExecutor_9:[2 2] 2015-12-16 23:51:17 b.s.util [INFO] 
> Async loop interrupted! 
> Expected: Topology should start ignoring the invalid policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...

2016-01-27 Thread senthilec566
Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175729908
  
@yonzhang  , we will modify the code not to do two siddhi query parsing..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-95) DAM HDFS topology fails to start, if there is invalid policy.

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119261#comment-15119261
 ] 

ASF GitHub Bot commented on EAGLE-95:
-

Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175642671
  
It looks not efficient to do two siddhi query parsing. We should do only 
one siddhi query parsing and catch exception when parsing fails. If parsing 
fails, policy should be marked down.


> DAM HDFS topology fails to start, if there is invalid policy.
> -
>
> Key: EAGLE-95
> URL: https://issues.apache.org/jira/browse/EAGLE-95
> Project: Eagle
>  Issue Type: Bug
>Reporter: hemanth dendukuri
>Assignee: Senthilkumar
>Priority: Critical
>
> Step 1: Create a invalid policy (from hdfsAuditLogEventStream[(cmd == 'open') 
> and (str:contains(src,'/tmp/p')==true)] select * insert into outputStream;) 
> Step 2 : Deploy Dam HDFS topology. 
> Actual : The HDFS topology could not start because of the invalid policy. 
> 2015-12-16 23:51:17 b.s.d.executor [INFO] Shutting down executor 
> AlertEntityDeduplicationExecutor_9:[2 2] 2015-12-16 23:51:17 b.s.util [INFO] 
> Async loop interrupted! 
> Expected: Topology should start ignoring the invalid policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...

2016-01-27 Thread yonzhang
Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/71#issuecomment-175642671
  
It looks not efficient to do two siddhi query parsing. We should do only 
one siddhi query parsing and catch exception when parsing fails. If parsing 
fails, policy should be marked down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119252#comment-15119252
 ] 

ASF GitHub Bot commented on EAGLE-81:
-

Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175636078
  
Now code is ready for Review , the only pending thing is  which API is good 
for Scanning Classes , Java SPI or Reflection ?? 

Right now Notification Plugin Using Reflection tool for scanning entities.

The only problem i could see in Java SPI is 
you have to add 
META-INF/server//list of classes which 
extends/implements { i may be wrong - correct me if its wrong }.

But in Reflection API :
Reflections reflections = new Reflections("");
Set> subTypes = 
reflections.getSubTypesOf(NotificationPlugin.class);




> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

2016-01-27 Thread senthilec566
Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175636078
  
Now code is ready for Review , the only pending thing is  which API is good 
for Scanning Classes , Java SPI or Reflection ?? 

Right now Notification Plugin Using Reflection tool for scanning entities.

The only problem i could see in Java SPI is 
you have to add 
META-INF/server//list of classes which 
extends/implements { i may be wrong - correct me if its wrong }.

But in Reflection API :
Reflections reflections = new Reflections("");
Set> subTypes = 
reflections.getSubTypesOf(NotificationPlugin.class);




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119000#comment-15119000
 ] 

ASF GitHub Bot commented on EAGLE-81:
-

Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175541837
  
Missed to add table creation scritps :( .. Will add it soon.


> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

2016-01-27 Thread senthilec566
Github user senthilec566 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/76#issuecomment-175541837
  
Missed to add table creation scritps :( .. Will add it soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-121) predefined/generic topology for adhoc data sources

2016-01-27 Thread Senthilkumar (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118997#comment-15118997
 ] 

Senthilkumar commented on EAGLE-121:


Hi All  , I think this JIRA is for implementing Generic way of  Registering 
dataSource , stream metadata etc ( through User Interface user can add their 
data source etc ) where eagle take care of creating/starting  configured 
datasource specific topology in backend..  Pls let me know if my understanding 
is not correct ..

> predefined/generic topology for adhoc data sources
> --
>
> Key: EAGLE-121
> URL: https://issues.apache.org/jira/browse/EAGLE-121
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Aroop Maliakkal
>
> Eagle should provide one or more predefined topology where user can send any 
> metrics to the predefined topology. This predefined/generic topology should 
> be exposed with well documented contract/grammer details so that any process 
> which talks to this generic topology can send metrics on that contract



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review - EAGLE-81 and EAGLE-95

2016-01-27 Thread Krishna, Murali(AWF)
Hi Team,

Would like your review for,

https://issues.apache.org/jira/browse/EAGLE-81 (PR - 
https://github.com/apache/incubator-eagle/pull/76)
https://issues.apache.org/jira/browse/EAGLE-95 (PR - 
https://github.com/apache/incubator-eagle/pull/71)

Thanks,
Murali Krishna


[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

2016-01-27 Thread senthilec566
GitHub user senthilec566 opened a pull request:

https://github.com/apache/incubator-eagle/pull/76

EAGLE-81 Notification Plugin Framework

Captured design here in Confluence :


https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework

We may need to change the way to scan .. As per Edward Suggestion , We have 
to use  Java SPI .. For now , Notification Plugin using Reflection API to scan 
and load all notification plugins.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/senthilec566/incubator-eagle EAGLE-81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 74be03da8472f250d200a210ff177c6455a5d0ea
Author: senthilkumar 
Date:   2016-01-25T14:26:58Z

initial version of Notification Sink

commit f6abae72f6ec6b2e987e05b4df8bb0c0040badac
Author: senthilkumar 
Date:   2016-01-25T14:29:48Z

initial version of Notification Sink

commit d4556eebb4e48f441626809c3c8020c7df201973
Author: senthilkumar 
Date:   2016-01-25T17:43:09Z

notification plugin

commit a3024d8ab61c19e9cecb571cf80b8aad772ea4b3
Author: senthilkumar 
Date:   2016-01-27T06:21:13Z

 added java docs

commit e62d0c2689e2f118dca662413f105d17316f9db5
Author: senthilkumar 
Date:   2016-01-27T06:30:24Z

java docs added

commit d234fed7a5aa1277b747935e42b212fe5aa6466a
Author: senthilkumar 
Date:   2016-01-27T06:35:15Z

uncommented security config

commit ed0e7bc62f144b7b95365e5ab14c4808074c00ca
Author: senthilkumar 
Date:   2016-01-27T08:33:45Z

added notification config

commit 4183c0046e4f8c61ba82d760786343027242281a
Author: senthilkumar 
Date:   2016-01-27T08:48:11Z

modified app conf




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (EAGLE-81) Notification Plugin Framework

2016-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118899#comment-15118899
 ] 

ASF GitHub Bot commented on EAGLE-81:
-

GitHub user senthilec566 opened a pull request:

https://github.com/apache/incubator-eagle/pull/76

EAGLE-81 Notification Plugin Framework

Captured design here in Confluence :


https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework

We may need to change the way to scan .. As per Edward Suggestion , We have 
to use  Java SPI .. For now , Notification Plugin using Reflection API to scan 
and load all notification plugins.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/senthilec566/incubator-eagle EAGLE-81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 74be03da8472f250d200a210ff177c6455a5d0ea
Author: senthilkumar 
Date:   2016-01-25T14:26:58Z

initial version of Notification Sink

commit f6abae72f6ec6b2e987e05b4df8bb0c0040badac
Author: senthilkumar 
Date:   2016-01-25T14:29:48Z

initial version of Notification Sink

commit d4556eebb4e48f441626809c3c8020c7df201973
Author: senthilkumar 
Date:   2016-01-25T17:43:09Z

notification plugin

commit a3024d8ab61c19e9cecb571cf80b8aad772ea4b3
Author: senthilkumar 
Date:   2016-01-27T06:21:13Z

 added java docs

commit e62d0c2689e2f118dca662413f105d17316f9db5
Author: senthilkumar 
Date:   2016-01-27T06:30:24Z

java docs added

commit d234fed7a5aa1277b747935e42b212fe5aa6466a
Author: senthilkumar 
Date:   2016-01-27T06:35:15Z

uncommented security config

commit ed0e7bc62f144b7b95365e5ab14c4808074c00ca
Author: senthilkumar 
Date:   2016-01-27T08:33:45Z

added notification config

commit 4183c0046e4f8c61ba82d760786343027242281a
Author: senthilkumar 
Date:   2016-01-27T08:48:11Z

modified app conf




> Notification Plugin Framework
> -
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Senthilkumar
>Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)