[jira] [Commented] (EAGLE-471) AlertBolt introduce un-serializble member

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423950#comment-15423950
 ] 

ASF GitHub Bot commented on EAGLE-471:
--

GitHub user mizeng opened a pull request:

https://github.com/apache/incubator-eagle/pull/355

EAGLE-471: fix AlertBolt introduce un-serializble member



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mizeng/incubator-eagle EAGLE-471

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #355


commit 476b9930c6619a797af7b14b7480bf935b6d01f8
Author: mizeng 
Date:   2016-08-17T05:51:08Z

EAGLE-471: fix AlertBolt introduce un-serializble member




> AlertBolt introduce un-serializble member 
> --
>
> Key: EAGLE-471
> URL: https://issues.apache.org/jira/browse/EAGLE-471
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Zeng, Bryant
>Priority: Blocker
>
> AlerBolt.executors  
> 2016-08-16 16:13:32,994 INFO [main] runner.UnitTopologyRunner[160]: Set 
> topology.message.timeout.secs as 3600
> Exception in thread "main" java.lang.RuntimeException: 
> java.io.NotSerializableException: java.util.concurrent.ThreadPoolExecutor
>at 
> backtype.storm.serialization.DefaultSerializationDelegate.serialize(DefaultSerializationDelegate.java:43)
> at backtype.storm.utils.Utils.serialize(Utils.java:85)
> at 
> backtype.storm.topology.TopologyBuilder.createTopology(TopologyBuilder.java:106)
> at 
> org.apache.eagle.alert.engine.runner.UnitTopologyRunner.buildTopology(UnitTopologyRunner.java:144)
> at 
> org.apache.eagle.alert.engine.runner.UnitTopologyRunner.run(UnitTopologyRunner.java:168)
> at 
> org.apache.eagle.alert.engine.runner.UnitTopologyRunner.run(UnitTopologyRunner.java:193)
> at 
> org.apache.eagle.alert.engine.UnitTopologyMain.main(UnitTopologyMain.java:65)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> Caused by: java.io.NotSerializableException: 
> java.util.concurrent.ThreadPoolExecutor
> at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
> at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
> at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
> at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
> at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
> at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
> at 
> backtype.storm.serialization.DefaultSerializationDelegate.serialize(DefaultSerializationDelegate.java:39)[4:15]
>   
> idea里跑UnitTopologyMain



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...

[mizeng]

GitHub user mizeng opened a pull request:

https://github.com/apache/incubator-eagle/pull/355

EAGLE-471: fix AlertBolt introduce un-serializble member



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mizeng/incubator-eagle EAGLE-471

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #355


commit 476b9930c6619a797af7b14b7480bf935b6d01f8
Author: mizeng 
Date:   2016-08-17T05:51:08Z

EAGLE-471: fix AlertBolt introduce un-serializble member




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-472) Fix HBase unit test

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423901#comment-15423901
 ] 

ASF GitHub Bot commented on EAGLE-472:
--

GitHub user baibaichen opened a pull request:

https://github.com/apache/incubator-eagle/pull/354

[EAGLE-472] Fix HBase unit test

HBase UT is broken due to wrong configuration and guava conflict

https://issues.apache.org/jira/browse/EAGLE-472

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baibaichen/incubator-eagle Eagle-472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit 11b2207fbb7da10dc783aae5dceaec7456f94f6e
Author: baibaichen 
Date:   2016-08-17T03:31:58Z

[EAGLE-472] Fix HBase unit test

HBase UT is broken due to wrong configuration and guava conflict

https://issues.apache.org/jira/browse/EAGLE-472




>  Fix HBase unit test
> 
>
> Key: EAGLE-472
> URL: https://issues.apache.org/jira/browse/EAGLE-472
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
>  Labels: test
> Fix For: v0.5.0
>
>
> HBase UT is broken due to wrong configuration and guava conflict
> # [EAGLE-331 ingestion+alert engine 
> preview|https://github.com/apache/incubator-eagle/commit/eef4930c3b9cac7d8c596af684ba098ec2b2229d],
>  see what is added in EmbeddedHbase.java. To Fix it, we needn't specify 
> *hbase.master.ipc.address*, using default value is fine, which is 0.0.0.0, 
> means all IPv4 addresses on the local machine. Please note RegionServer will 
> not use 127.0.0.1 and localhost to contact master.
> # [Rebase code 
> base|https://github.com/apache/incubator-eagle/commit/72a1501c3ff645d93067b4fd9907f8183c2763b6]
>  , guava is upgraded to *19.0*,  however the dependent HBase 
> version(0.98.4.2.2.5.1-3-hadoop2) uses 12.01. It is OK in product 
> environment, but failed in UT, see HBASE-11694. To Fix it, we can downgrade 
> to guava 15.0 which works for eagle(*Stopwatch.createStarted*) and 
> HBase(*StopWatch.elapsedMillis*)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #354: [EAGLE-472] Fix HBase unit test

[baibaichen]

GitHub user baibaichen opened a pull request:

https://github.com/apache/incubator-eagle/pull/354

[EAGLE-472] Fix HBase unit test

HBase UT is broken due to wrong configuration and guava conflict

https://issues.apache.org/jira/browse/EAGLE-472

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baibaichen/incubator-eagle Eagle-472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit 11b2207fbb7da10dc783aae5dceaec7456f94f6e
Author: baibaichen 
Date:   2016-08-17T03:31:58Z

[EAGLE-472] Fix HBase unit test

HBase UT is broken due to wrong configuration and guava conflict

https://issues.apache.org/jira/browse/EAGLE-472




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (EAGLE-472) Fix HBase unit test

[Chang chen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chang chen reassigned EAGLE-472:


Assignee: Chang chen

>  Fix HBase unit test
> 
>
> Key: EAGLE-472
> URL: https://issues.apache.org/jira/browse/EAGLE-472
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
>  Labels: test
> Fix For: v0.5.0
>
>
> HBase UT is broken due to wrong configuration and guava conflict
> # [EAGLE-331 ingestion+alert engine 
> preview|https://github.com/apache/incubator-eagle/commit/eef4930c3b9cac7d8c596af684ba098ec2b2229d],
>  see what is added in EmbeddedHbase.java. To Fix it, we needn't specify 
> *hbase.master.ipc.address*, using default value is fine, which is 0.0.0.0, 
> means all IPv4 addresses on the local machine. Please note RegionServer will 
> not use 127.0.0.1 and localhost to contact master.
> # [Rebase code 
> base|https://github.com/apache/incubator-eagle/commit/72a1501c3ff645d93067b4fd9907f8183c2763b6]
>  , guava is upgraded to *19.0*,  however the dependent HBase 
> version(0.98.4.2.2.5.1-3-hadoop2) uses 12.01. It is OK in product 
> environment, but failed in UT, see HBASE-11694. To Fix it, we can downgrade 
> to guava 15.0 which works for eagle(*Stopwatch.createStarted*) and 
> HBase(*StopWatch.elapsedMillis*)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (EAGLE-472) Fix HBase unit test

[Chang chen (JIRA)]

Chang chen created EAGLE-472:


 Summary:  Fix HBase unit test
 Key: EAGLE-472
 URL: https://issues.apache.org/jira/browse/EAGLE-472
 Project: Eagle
  Issue Type: Sub-task
Affects Versions: v0.5.0
Reporter: Chang chen
 Fix For: v0.5.0


HBase UT is broken due to wrong configuration and guava conflict

# [EAGLE-331 ingestion+alert engine 
preview|https://github.com/apache/incubator-eagle/commit/eef4930c3b9cac7d8c596af684ba098ec2b2229d],
 see what is added in EmbeddedHbase.java. To Fix it, we needn't specify 
*hbase.master.ipc.address*, using default value is fine, which is 0.0.0.0, 
means all IPv4 addresses on the local machine. Please note RegionServer will 
not use 127.0.0.1 and localhost to contact master.
# [Rebase code 
base|https://github.com/apache/incubator-eagle/commit/72a1501c3ff645d93067b4fd9907f8183c2763b6]
 , guava is upgraded to *19.0*,  however the dependent HBase 
version(0.98.4.2.2.5.1-3-hadoop2) uses 12.01. It is OK in product environment, 
but failed in UT, see HBASE-11694. To Fix it, we can downgrade to guava 15.0 
which works for eagle(*Stopwatch.createStarted*) and 
HBase(*StopWatch.elapsedMillis*)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [Discussion] How to refactor EagleConfigFactory

[Liangfei.Su]

On test scenario with different config need for differest, i simply do
ConfigFactory.invalidateCaches() in setup().


On Wed, Aug 17, 2016 at 9:43 AM, Edward Zhang 
wrote:

> Sorry I mean "remove" :-)
>
> Thanks
> Edward
>
> On Tue, Aug 16, 2016 at 6:35 PM, Chang Chen  wrote:
>
> > Hi Edward
> >
> > Does remote mean run TestEagleConfig in different JVM?
> >
> > Thanks
> > Chang
> >
> > On Wednesday, August 17, 2016, Edward Zhang 
> > wrote:
> >
> > > TestEagleConfig is not a valid test case because it assumes that it can
> > > initialize EagleConfigFactory, but when we execute multiple test cases,
> > > this may not work as EagleConfigFactory may already be initialized
> before
> > > this test case is executed. So setting "config.resource" will not have
> > any
> > > effect.
> > >
> > > I suggest we remote TestEagleConfig, and also going forward we can need
> > > refactor EagleConfigFactor to be not a singleton but use
> > > com.typesafe.config.Config as constructor parameter.
> > >
> > > Thanks
> > > Edward
> > >
> > > On Tue, Aug 16, 2016 at 4:26 AM, Chang Chen  > > > wrote:
> > >
> > > > Hi Guys
> > > >
> > > > In the middle of writing UT for Eagle, we found it is difficult to
> mock
> > > >  EagleConfigFactory, since it has static method. The current
> workaround
> > > is
> > > > introducing powermock, so that we can set manager to mock object ,
> i.e.
> > > >
> > > >Whitebox.setInternalState(EagleConfigFactory.class, "manager",
> > > > eagleConfigFactory);
> > > >
> > > > This is OK in most cases, but TestEagleConfig.testInit could be
> failed,
> > > > because manager only initialized at first time and
> >  EagleConfigFactory's
> > > > Constructor is private:
> > > >
> > > >private static EagleConfigFactory manager = new
> > EagleConfigFactory();
> > > >
> > > > EagleConfigFactory actually has two roles, one is factory and another
> > is
> > > > configuration. I propose refactoring EagleConfigFactory and
> distinguish
> > > > these two roles:
> > > >
> > > > public class EagleConfigImpl implements EagleConfig{
> > > > }
> > > >
> > > > public class EagleConfigFactory {
> > > >   public static EagleConfig load(){}
> > > >   public static void reset(EagleConfig config){
> > > > if (config == null) {
> > > >   //default
> > > > }else{
> > > > }
> > > >   }
> > > > }
> > > >
> > > > However doing so, we need call EagleConfigFactory.reset at the
> > beginning
> > > of
> > > >  eagle start.
> > > >
> > > > Any ideas?
> > > >
> > > > Thanks
> > > > Chang
> > > >
> > >
> >
>

[jira] [Commented] (EAGLE-135) Run Eagle in Spark Streaming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423743#comment-15423743
 ] 

ASF GitHub Bot commented on EAGLE-135:
--

Github user qinzhaokun closed the pull request at:

https://github.com/apache/incubator-eagle/pull/213


> Run Eagle in Spark Streaming
> 
>
> Key: EAGLE-135
> URL: https://issues.apache.org/jira/browse/EAGLE-135
> Project: Eagle
>  Issue Type: New Feature
>Reporter: Zhaokun Qin
>Assignee: Zhaokun Qin
>Priority: Minor
>  Labels: new
>
> Eagle can run in Storm for now, to achieve Cross-platform feature, Eagle must 
> run in other streaming process platforms. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #213: EAGLE-135 Run Eagle on Spark Streaming

[qinzhaokun]

Github user qinzhaokun closed the pull request at:

https://github.com/apache/incubator-eagle/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Discussion] How to refactor EagleConfigFactory

[Edward Zhang]

Sorry I mean "remove" :-)

Thanks
Edward

On Tue, Aug 16, 2016 at 6:35 PM, Chang Chen  wrote:

> Hi Edward
>
> Does remote mean run TestEagleConfig in different JVM?
>
> Thanks
> Chang
>
> On Wednesday, August 17, 2016, Edward Zhang 
> wrote:
>
> > TestEagleConfig is not a valid test case because it assumes that it can
> > initialize EagleConfigFactory, but when we execute multiple test cases,
> > this may not work as EagleConfigFactory may already be initialized before
> > this test case is executed. So setting "config.resource" will not have
> any
> > effect.
> >
> > I suggest we remote TestEagleConfig, and also going forward we can need
> > refactor EagleConfigFactor to be not a singleton but use
> > com.typesafe.config.Config as constructor parameter.
> >
> > Thanks
> > Edward
> >
> > On Tue, Aug 16, 2016 at 4:26 AM, Chang Chen  > > wrote:
> >
> > > Hi Guys
> > >
> > > In the middle of writing UT for Eagle, we found it is difficult to mock
> > >  EagleConfigFactory, since it has static method. The current workaround
> > is
> > > introducing powermock, so that we can set manager to mock object , i.e.
> > >
> > >Whitebox.setInternalState(EagleConfigFactory.class, "manager",
> > > eagleConfigFactory);
> > >
> > > This is OK in most cases, but TestEagleConfig.testInit could be failed,
> > > because manager only initialized at first time and
>  EagleConfigFactory's
> > > Constructor is private:
> > >
> > >private static EagleConfigFactory manager = new
> EagleConfigFactory();
> > >
> > > EagleConfigFactory actually has two roles, one is factory and another
> is
> > > configuration. I propose refactoring EagleConfigFactory and distinguish
> > > these two roles:
> > >
> > > public class EagleConfigImpl implements EagleConfig{
> > > }
> > >
> > > public class EagleConfigFactory {
> > >   public static EagleConfig load(){}
> > >   public static void reset(EagleConfig config){
> > > if (config == null) {
> > >   //default
> > > }else{
> > > }
> > >   }
> > > }
> > >
> > > However doing so, we need call EagleConfigFactory.reset at the
> beginning
> > of
> > >  eagle start.
> > >
> > > Any ideas?
> > >
> > > Thanks
> > > Chang
> > >
> >
>

Re: [Discussion] How to refactor EagleConfigFactory

[Chang Chen]

Hi Edward

Does remote mean run TestEagleConfig in different JVM?

Thanks
Chang

On Wednesday, August 17, 2016, Edward Zhang  wrote:

> TestEagleConfig is not a valid test case because it assumes that it can
> initialize EagleConfigFactory, but when we execute multiple test cases,
> this may not work as EagleConfigFactory may already be initialized before
> this test case is executed. So setting "config.resource" will not have any
> effect.
>
> I suggest we remote TestEagleConfig, and also going forward we can need
> refactor EagleConfigFactor to be not a singleton but use
> com.typesafe.config.Config as constructor parameter.
>
> Thanks
> Edward
>
> On Tue, Aug 16, 2016 at 4:26 AM, Chang Chen  > wrote:
>
> > Hi Guys
> >
> > In the middle of writing UT for Eagle, we found it is difficult to mock
> >  EagleConfigFactory, since it has static method. The current workaround
> is
> > introducing powermock, so that we can set manager to mock object , i.e.
> >
> >Whitebox.setInternalState(EagleConfigFactory.class, "manager",
> > eagleConfigFactory);
> >
> > This is OK in most cases, but TestEagleConfig.testInit could be failed,
> > because manager only initialized at first time and   EagleConfigFactory's
> > Constructor is private:
> >
> >private static EagleConfigFactory manager = new EagleConfigFactory();
> >
> > EagleConfigFactory actually has two roles, one is factory and another is
> > configuration. I propose refactoring EagleConfigFactory and distinguish
> > these two roles:
> >
> > public class EagleConfigImpl implements EagleConfig{
> > }
> >
> > public class EagleConfigFactory {
> >   public static EagleConfig load(){}
> >   public static void reset(EagleConfig config){
> > if (config == null) {
> >   //default
> > }else{
> > }
> >   }
> > }
> >
> > However doing so, we need call EagleConfigFactory.reset at the beginning
> of
> >  eagle start.
> >
> > Any ideas?
> >
> > Thanks
> > Chang
> >
>

[jira] [Created] (EAGLE-471) AlertBolt introduce un-serializble member

[Su Ralph (JIRA)]

Su Ralph created EAGLE-471:
--

 Summary: AlertBolt introduce un-serializble member 
 Key: EAGLE-471
 URL: https://issues.apache.org/jira/browse/EAGLE-471
 Project: Eagle
  Issue Type: Bug
Affects Versions: v0.5.0
Reporter: Su Ralph
Assignee: Zeng, Bryant
Priority: Blocker


AlerBolt.executors  

2016-08-16 16:13:32,994 INFO [main] runner.UnitTopologyRunner[160]: Set 
topology.message.timeout.secs as 3600
Exception in thread "main" java.lang.RuntimeException: 
java.io.NotSerializableException: java.util.concurrent.ThreadPoolExecutor
   at 
backtype.storm.serialization.DefaultSerializationDelegate.serialize(DefaultSerializationDelegate.java:43)
at backtype.storm.utils.Utils.serialize(Utils.java:85)
at 
backtype.storm.topology.TopologyBuilder.createTopology(TopologyBuilder.java:106)
at 
org.apache.eagle.alert.engine.runner.UnitTopologyRunner.buildTopology(UnitTopologyRunner.java:144)
at 
org.apache.eagle.alert.engine.runner.UnitTopologyRunner.run(UnitTopologyRunner.java:168)
at 
org.apache.eagle.alert.engine.runner.UnitTopologyRunner.run(UnitTopologyRunner.java:193)
at 
org.apache.eagle.alert.engine.UnitTopologyMain.main(UnitTopologyMain.java:65)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
Caused by: java.io.NotSerializableException: 
java.util.concurrent.ThreadPoolExecutor
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
at 
java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
at 
backtype.storm.serialization.DefaultSerializationDelegate.serialize(DefaultSerializationDelegate.java:39)[4:15]
  
idea里跑UnitTopologyMain



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-469) make dataSource configuration extremely simple

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423656#comment-15423656
 ] 

ASF GitHub Bot commented on EAGLE-469:
--

Github user yonzhang closed the pull request at:

https://github.com/apache/incubator-eagle/pull/353


> make dataSource configuration extremely simple
> --
>
> Key: EAGLE-469
> URL: https://issues.apache.org/jira/browse/EAGLE-469
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Edward Zhang
>Assignee: Edward Zhang
>Priority: Minor
> Fix For: v0.5.0
>
>
> Today dataSource configuration is very cumbersome, we actually can reduce 
> significantly the size of config entries as most of configurations use the 
> default values.
> "dataSourceConfig": {
> "topic" : "sandbox_hbase_security_log",
> "zkConnection" : "sandbox.hortonworks.com:2181",
> "zkConnectionTimeoutMS" : 15000,
> "consumerGroupId" : "EagleConsumer",
> "fetchSize" : 1048586,
> "deserializerClass" : 
> "org.apache.eagle.security.hbase.HbaseAuditLogKafkaDeserializer",
> "transactionZKServers" : "sandbox.hortonworks.com",
> "transactionZKPort" : 2181,
> "transactionZKRoot" : "/consumers",
> "consumerGroupId" : "eagle.hbasesecurity.consumer",
> "transactionStateUpdateMS" : 2000
>   }
> The new data source config would be like:
> "dataSourceConfig": {
> "topic" : "hbase_audit_log",
> "zkConnection" : "server.eagle.apache.org:2181",
> "txZkServers" : "server.eagle.apache.org:2181",
> "schemeCls" : "storm.kafka.StringScheme"
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #353: EAGLE-469 make dataSource configuration e...

[yonzhang]

Github user yonzhang closed the pull request at:

https://github.com/apache/incubator-eagle/pull/353


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (EAGLE-470) data enrichment refactor in eagle security monitoring

[Edward Zhang (JIRA)]

Edward Zhang created EAGLE-470:
--

 Summary: data enrichment refactor in eagle security monitoring
 Key: EAGLE-470
 URL: https://issues.apache.org/jira/browse/EAGLE-470
 Project: Eagle
  Issue Type: Improvement
Affects Versions: v0.5.0
Reporter: Edward Zhang
Assignee: Edward Zhang
Priority: Minor
 Fix For: v0.5.0


Data enrichment happens in eagle security monitoring by retrieving sensitivity 
data from eagle service and then join in real time.

A lot of code is duplicated in current data enrich, this jira ticket is for 
simplifying data enrichment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Eagle mongodb test case failed in develop branch

[Liangfei.Su]

Find something in
https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues/71
 Looks like system compatibility issue. It runs ok in my local as well.

On Wed, Aug 17, 2016 at 5:29 AM, Edward Zhang 
wrote:

> It failed in Apache Jenkins, in my local it is ok.
> Can you fix if you know how?
>
>
> https://builds.apache.org/job/incubator-eagle-develop/40/
> testReport/org.apache.eagle.service.alert.resource.impl/
> MongoImplTest/org_apache_eagle_service_alert_resource_impl_MongoImplTest/
>
>
>
> Error Message
>
> Couldn't kill mongod process!
>  Something bad
> happend. We couldn't kill mongod process, and tried a lot. If you want
> this problem solved you can help us if you open a new issue.  Follow
> this link: https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/
> issues
>  Thank you:) 
>
> Stacktrace
>
> java.lang.IllegalStateException: Couldn't kill mongod process!
>
> 
> Something bad happend. We couldn't kill mongod process, and tried a lot.
> If you want this problem solved you can help us if you open a new issue.
>

Eagle mongodb test case failed in develop branch

[Edward Zhang]

It failed in Apache Jenkins, in my local it is ok.
Can you fix if you know how?


https://builds.apache.org/job/incubator-eagle-develop/40/testReport/org.apache.eagle.service.alert.resource.impl/MongoImplTest/org_apache_eagle_service_alert_resource_impl_MongoImplTest/



Error Message

Couldn't kill mongod process!
 Something bad
happend. We couldn't kill mongod process, and tried a lot. If you want
this problem solved you can help us if you open a new issue.  Follow
this link: https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues
 Thank you:) 

Stacktrace

java.lang.IllegalStateException: Couldn't kill mongod process!


Something bad happend. We couldn't kill mongod process, and tried a lot.
If you want this problem solved you can help us if you open a new issue.

[EAGLE BUILD FAILED] incubator-eagle-develop failed on build #40

[Apache Jenkins Server]

The Apache Jenkins build system has built incubator-eagle-develop (build 
#40) Status: Still Failing Check console output at 
https://builds.apache.org/job/incubator-eagle-develop/40/ to view the 
results. Test Report is at: Test Result

[EAGLE BUILD FAILED] incubator-eagle-develop failed on build #39

[Apache Jenkins Server]

The Apache Jenkins build system has built incubator-eagle-develop (build 
#39) Status: Failure Check console output at 
https://builds.apache.org/job/incubator-eagle-develop/39/ to view the 
results. Test Report is at: Test Result

[jira] [Commented] (EAGLE-469) make dataSource configuration extremely simple

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423252#comment-15423252
 ] 

ASF GitHub Bot commented on EAGLE-469:
--

GitHub user yonzhang opened a pull request:

https://github.com/apache/incubator-eagle/pull/353

EAGLE-469 make dataSource configuration extremely simple

https://issues.apache.org/jira/browse/EAGLE-469

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yonzhang/incubator-eagle develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #353


commit 5cf6a7f4a0918af79f8426dc1e83b435744a3b7e
Author: yonzhang 
Date:   2016-08-16T18:19:34Z

kafka datasource be made very simple

commit 256fda5db755ce1f4cb215c4482fec07f2d72338
Author: yonzhang 
Date:   2016-08-16T18:20:58Z

Merge remote-tracking branch 'upstream/develop' into develop




> make dataSource configuration extremely simple
> --
>
> Key: EAGLE-469
> URL: https://issues.apache.org/jira/browse/EAGLE-469
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Edward Zhang
>Assignee: Edward Zhang
>Priority: Minor
> Fix For: v0.5.0
>
>
> Today dataSource configuration is very cumbersome, we actually can reduce 
> significantly the size of config entries as most of configurations use the 
> default values.
> "dataSourceConfig": {
> "topic" : "sandbox_hbase_security_log",
> "zkConnection" : "sandbox.hortonworks.com:2181",
> "zkConnectionTimeoutMS" : 15000,
> "consumerGroupId" : "EagleConsumer",
> "fetchSize" : 1048586,
> "deserializerClass" : 
> "org.apache.eagle.security.hbase.HbaseAuditLogKafkaDeserializer",
> "transactionZKServers" : "sandbox.hortonworks.com",
> "transactionZKPort" : 2181,
> "transactionZKRoot" : "/consumers",
> "consumerGroupId" : "eagle.hbasesecurity.consumer",
> "transactionStateUpdateMS" : 2000
>   }
> The new data source config would be like:
> "dataSourceConfig": {
> "topic" : "hbase_audit_log",
> "zkConnection" : "server.eagle.apache.org:2181",
> "txZkServers" : "server.eagle.apache.org:2181",
> "schemeCls" : "storm.kafka.StringScheme"
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #353: EAGLE-469 make dataSource configuration e...

[yonzhang]

GitHub user yonzhang opened a pull request:

https://github.com/apache/incubator-eagle/pull/353

EAGLE-469 make dataSource configuration extremely simple

https://issues.apache.org/jira/browse/EAGLE-469

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yonzhang/incubator-eagle develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #353


commit 5cf6a7f4a0918af79f8426dc1e83b435744a3b7e
Author: yonzhang 
Date:   2016-08-16T18:19:34Z

kafka datasource be made very simple

commit 256fda5db755ce1f4cb215c4482fec07f2d72338
Author: yonzhang 
Date:   2016-08-16T18:20:58Z

Merge remote-tracking branch 'upstream/develop' into develop




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Discussion] How to refactor EagleConfigFactory

[Edward Zhang]

TestEagleConfig is not a valid test case because it assumes that it can
initialize EagleConfigFactory, but when we execute multiple test cases,
this may not work as EagleConfigFactory may already be initialized before
this test case is executed. So setting "config.resource" will not have any
effect.

I suggest we remote TestEagleConfig, and also going forward we can need
refactor EagleConfigFactor to be not a singleton but use
com.typesafe.config.Config as constructor parameter.

Thanks
Edward

On Tue, Aug 16, 2016 at 4:26 AM, Chang Chen  wrote:

> Hi Guys
>
> In the middle of writing UT for Eagle, we found it is difficult to mock
>  EagleConfigFactory, since it has static method. The current workaround is
> introducing powermock, so that we can set manager to mock object , i.e.
>
>Whitebox.setInternalState(EagleConfigFactory.class, "manager",
> eagleConfigFactory);
>
> This is OK in most cases, but TestEagleConfig.testInit could be failed,
> because manager only initialized at first time and   EagleConfigFactory's
> Constructor is private:
>
>private static EagleConfigFactory manager = new EagleConfigFactory();
>
> EagleConfigFactory actually has two roles, one is factory and another is
> configuration. I propose refactoring EagleConfigFactory and distinguish
> these two roles:
>
> public class EagleConfigImpl implements EagleConfig{
> }
>
> public class EagleConfigFactory {
>   public static EagleConfig load(){}
>   public static void reset(EagleConfig config){
> if (config == null) {
>   //default
> }else{
> }
>   }
> }
>
> However doing so, we need call EagleConfigFactory.reset at the beginning of
>  eagle start.
>
> Any ideas?
>
> Thanks
> Chang
>

[Discussion] How to refactor EagleConfigFactory

[Chang Chen]

Hi Guys

In the middle of writing UT for Eagle, we found it is difficult to mock
 EagleConfigFactory, since it has static method. The current workaround is
introducing powermock, so that we can set manager to mock object , i.e.

   Whitebox.setInternalState(EagleConfigFactory.class, "manager",
eagleConfigFactory);

This is OK in most cases, but TestEagleConfig.testInit could be failed,
because manager only initialized at first time and   EagleConfigFactory's
Constructor is private:

   private static EagleConfigFactory manager = new EagleConfigFactory();

EagleConfigFactory actually has two roles, one is factory and another is
configuration. I propose refactoring EagleConfigFactory and distinguish
these two roles:

public class EagleConfigImpl implements EagleConfig{
}

public class EagleConfigFactory {
  public static EagleConfig load(){}
  public static void reset(EagleConfig config){
if (config == null) {
  //default
}else{
}
  }
}

However doing so, we need call EagleConfigFactory.reset at the beginning of
 eagle start.

Any ideas?

Thanks
Chang

[jira] [Commented] (EAGLE-464) StateCheck: multiple stage of definition in single policy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422494#comment-15422494
 ] 

ASF GitHub Bot commented on EAGLE-464:
--

Github user RalphSu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/337


> StateCheck: multiple stage of definition in single policy
> -
>
> Key: EAGLE-464
> URL: https://issues.apache.org/jira/browse/EAGLE-464
> Project: Eagle
>  Issue Type: New Feature
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>
> The requirement of alert state and transition comes from two real customer 
> needs.
> Alert de-duplication
> "IMO, eagle should do state checks for all services. Eagle should not alert 
> in the first attempt itself. Instead it should change the state to SOFT for 2 
> tries and then if it is the same state, change the state to HARD and then 
> send the alert." - Aroop
> Currently, eagle's alert engine(and also that of UMP) use a simple 
> deduplication spec of time based redundancy check(dedupIntervalMin of 
> Publishment). This deduplication is not flexible to reflect the need of 
> alerts. There are common requests like to hold a alert/policy state 
> (basically a alert state is policy state on given partition value, more in 
> latter), and trigger alert when the state changed. This state change manner 
> could be 
> > Same alert trigger again in M time interval
> > N alerts in given M time interval.
> NOTE: on here, in this de-duplication mode, there is no required change of 
> the policy itself.
> Alert policy define on transition
> One example of the missingblock policy we met(only alert when missingblock 
> number changes). There is more general case with minor difference, given a 
> metric (or a field of a given stream), define value range, where each range 
> indicate different state. Etc. for perfmon.latency.avg.perpool, define value 
> range state as
> metric
> value range
> state
> alert trigger
> perfmon.latency.avg.perpool.5min  3000 - UnlimitedFATAL   always 
> (every 5min until FATAL fixed or alert muted explictly)
>   1000 - 3000 CRITICALon dual transition
>   100 - 1000  WARNon dual transition
>   10 - 50 NORMAL  on worse transition
>   0-10GOODon worse transition
> Then the alert should be trigger during the state changed expect for FATAL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-464) StateCheck: multiple stage of definition in single policy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422493#comment-15422493
 ] 

ASF GitHub Bot commented on EAGLE-464:
--

Github user RalphSu commented on the issue:

https://github.com/apache/incubator-eagle/pull/337
  
merged. 


> StateCheck: multiple stage of definition in single policy
> -
>
> Key: EAGLE-464
> URL: https://issues.apache.org/jira/browse/EAGLE-464
> Project: Eagle
>  Issue Type: New Feature
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>
> The requirement of alert state and transition comes from two real customer 
> needs.
> Alert de-duplication
> "IMO, eagle should do state checks for all services. Eagle should not alert 
> in the first attempt itself. Instead it should change the state to SOFT for 2 
> tries and then if it is the same state, change the state to HARD and then 
> send the alert." - Aroop
> Currently, eagle's alert engine(and also that of UMP) use a simple 
> deduplication spec of time based redundancy check(dedupIntervalMin of 
> Publishment). This deduplication is not flexible to reflect the need of 
> alerts. There are common requests like to hold a alert/policy state 
> (basically a alert state is policy state on given partition value, more in 
> latter), and trigger alert when the state changed. This state change manner 
> could be 
> > Same alert trigger again in M time interval
> > N alerts in given M time interval.
> NOTE: on here, in this de-duplication mode, there is no required change of 
> the policy itself.
> Alert policy define on transition
> One example of the missingblock policy we met(only alert when missingblock 
> number changes). There is more general case with minor difference, given a 
> metric (or a field of a given stream), define value range, where each range 
> indicate different state. Etc. for perfmon.latency.avg.perpool, define value 
> range state as
> metric
> value range
> state
> alert trigger
> perfmon.latency.avg.perpool.5min  3000 - UnlimitedFATAL   always 
> (every 5min until FATAL fixed or alert muted explictly)
>   1000 - 3000 CRITICALon dual transition
>   100 - 1000  WARNon dual transition
>   10 - 50 NORMAL  on worse transition
>   0-10GOODon worse transition
> Then the alert should be trigger during the state changed expect for FATAL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422495#comment-15422495
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74903923
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
 ---
@@ -35,6 +35,7 @@
 private StreamDefinition schema;
 private String createdBy;
 private long createdTime;
+private boolean isDuplicate = false;
--- End diff --

currently it is only for test. But should not "duplicate" be one property 
for StreamEvent? It sounds more naturally.


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle issue #337: EAGLE-464 : init draft impelmentation of multipl...

[RalphSu]

Github user RalphSu commented on the issue:

https://github.com/apache/incubator-eagle/pull/337
  
merged. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #337: EAGLE-464 : init draft impelmentation of ...

[RalphSu]

Github user RalphSu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/337


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[mizeng]

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74903923
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
 ---
@@ -35,6 +35,7 @@
 private StreamDefinition schema;
 private String createdBy;
 private long createdTime;
+private boolean isDuplicate = false;
--- End diff --

currently it is only for test. But should not "duplicate" be one property 
for StreamEvent? It sounds more naturally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-464) StateCheck: multiple stage of definition in single policy

[Su Ralph (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422480#comment-15422480
 ] 

Su Ralph commented on EAGLE-464:


In pr of : https://github.com/apache/incubator-eagle/pull/337. merged draft 
implementation

> StateCheck: multiple stage of definition in single policy
> -
>
> Key: EAGLE-464
> URL: https://issues.apache.org/jira/browse/EAGLE-464
> Project: Eagle
>  Issue Type: New Feature
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>
> The requirement of alert state and transition comes from two real customer 
> needs.
> Alert de-duplication
> "IMO, eagle should do state checks for all services. Eagle should not alert 
> in the first attempt itself. Instead it should change the state to SOFT for 2 
> tries and then if it is the same state, change the state to HARD and then 
> send the alert." - Aroop
> Currently, eagle's alert engine(and also that of UMP) use a simple 
> deduplication spec of time based redundancy check(dedupIntervalMin of 
> Publishment). This deduplication is not flexible to reflect the need of 
> alerts. There are common requests like to hold a alert/policy state 
> (basically a alert state is policy state on given partition value, more in 
> latter), and trigger alert when the state changed. This state change manner 
> could be 
> > Same alert trigger again in M time interval
> > N alerts in given M time interval.
> NOTE: on here, in this de-duplication mode, there is no required change of 
> the policy itself.
> Alert policy define on transition
> One example of the missingblock policy we met(only alert when missingblock 
> number changes). There is more general case with minor difference, given a 
> metric (or a field of a given stream), define value range, where each range 
> indicate different state. Etc. for perfmon.latency.avg.perpool, define value 
> range state as
> metric
> value range
> state
> alert trigger
> perfmon.latency.avg.perpool.5min  3000 - UnlimitedFATAL   always 
> (every 5min until FATAL fixed or alert muted explictly)
>   1000 - 3000 CRITICALon dual transition
>   100 - 1000  WARNon dual transition
>   10 - 50 NORMAL  on worse transition
>   0-10GOODon worse transition
> Then the alert should be trigger during the state changed expect for FATAL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (EAGLE-421) JMX Metric APP use new application framework

[Su Ralph (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Su Ralph resolved EAGLE-421.

Resolution: Fixed

> JMX Metric APP use new application framework
> 
>
> Key: EAGLE-421
> URL: https://issues.apache.org/jira/browse/EAGLE-421
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (EAGLE-464) StateCheck: multiple stage of definition in single policy

[Su Ralph (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Su Ralph resolved EAGLE-464.

Resolution: Fixed

> StateCheck: multiple stage of definition in single policy
> -
>
> Key: EAGLE-464
> URL: https://issues.apache.org/jira/browse/EAGLE-464
> Project: Eagle
>  Issue Type: New Feature
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>
> The requirement of alert state and transition comes from two real customer 
> needs.
> Alert de-duplication
> "IMO, eagle should do state checks for all services. Eagle should not alert 
> in the first attempt itself. Instead it should change the state to SOFT for 2 
> tries and then if it is the same state, change the state to HARD and then 
> send the alert." - Aroop
> Currently, eagle's alert engine(and also that of UMP) use a simple 
> deduplication spec of time based redundancy check(dedupIntervalMin of 
> Publishment). This deduplication is not flexible to reflect the need of 
> alerts. There are common requests like to hold a alert/policy state 
> (basically a alert state is policy state on given partition value, more in 
> latter), and trigger alert when the state changed. This state change manner 
> could be 
> > Same alert trigger again in M time interval
> > N alerts in given M time interval.
> NOTE: on here, in this de-duplication mode, there is no required change of 
> the policy itself.
> Alert policy define on transition
> One example of the missingblock policy we met(only alert when missingblock 
> number changes). There is more general case with minor difference, given a 
> metric (or a field of a given stream), define value range, where each range 
> indicate different state. Etc. for perfmon.latency.avg.perpool, define value 
> range state as
> metric
> value range
> state
> alert trigger
> perfmon.latency.avg.perpool.5min  3000 - UnlimitedFATAL   always 
> (every 5min until FATAL fixed or alert muted explictly)
>   1000 - 3000 CRITICALon dual transition
>   100 - 1000  WARNon dual transition
>   10 - 50 NORMAL  on worse transition
>   0-10GOODon worse transition
> Then the alert should be trigger during the state changed expect for FATAL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[RalphSu]

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74900271
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
 ---
@@ -35,6 +35,7 @@
 private StreamDefinition schema;
 private String createdBy;
 private long createdTime;
+private boolean isDuplicate = false;
--- End diff --

Looks this is only for test verification. Could we avoid add non-required 
method in stream event, instead use check the statistic info in deduplicator 
for test verify?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422465#comment-15422465
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74900271
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
 ---
@@ -35,6 +35,7 @@
 private StreamDefinition schema;
 private String createdBy;
 private long createdTime;
+private boolean isDuplicate = false;
--- End diff --

Looks this is only for test verification. Could we avoid add non-required 
method in stream event, instead use check the statistic info in deduplicator 
for test verify?


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422460#comment-15422460
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899457
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
 ---
@@ -0,0 +1,23 @@
+[
+{
+   "name":"test-stream-output",
+   
"type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher",
+   "policyIds": [
+   "perfmon_cpu_host_check", "perfmon_cpu_pool_check"
+   ],
+   "properties": {
+ "subject":"UMP Test Alert",
--- End diff --

got it.


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422459#comment-15422459
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899429
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
 ---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws 
Exception {
 if(event == null) {
 return;
 }
+
+if 
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --

mostly Yes.


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[mizeng]

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899457
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
 ---
@@ -0,0 +1,23 @@
+[
+{
+   "name":"test-stream-output",
+   
"type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher",
+   "policyIds": [
+   "perfmon_cpu_host_check", "perfmon_cpu_pool_check"
+   ],
+   "properties": {
+ "subject":"UMP Test Alert",
--- End diff --

got it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422456#comment-15422456
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899312
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
 ---
@@ -0,0 +1,23 @@
+[
+{
+   "name":"test-stream-output",
+   
"type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher",
+   "policyIds": [
+   "perfmon_cpu_host_check", "perfmon_cpu_pool_check"
+   ],
+   "properties": {
+ "subject":"UMP Test Alert",
--- End diff --

should be eagle test alert in "subject"


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[mizeng]

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899429
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
 ---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws 
Exception {
 if(event == null) {
 return;
 }
+
+if 
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --

mostly Yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422455#comment-15422455
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899209
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java
 ---
@@ -32,6 +32,7 @@
 private String type;
 private List policyIds;
 private String dedupIntervalMin;
+private List customDedupFields;
--- End diff --

sounds better.


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[RalphSu]

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899312
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
 ---
@@ -0,0 +1,23 @@
+[
+{
+   "name":"test-stream-output",
+   
"type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher",
+   "policyIds": [
+   "perfmon_cpu_host_check", "perfmon_cpu_pool_check"
+   ],
+   "properties": {
+ "subject":"UMP Test Alert",
--- End diff --

should be eagle test alert in "subject"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422454#comment-15422454
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899163
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
 ---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws 
Exception {
 if(event == null) {
 return;
 }
+
+if 
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --

what does this equals here for? For test only?


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[RalphSu]

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899163
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
 ---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws 
Exception {
 if(event == null) {
 return;
 }
+
+if 
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --

what does this equals here for? For test only?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[mizeng]

Github user mizeng commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74899209
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java
 ---
@@ -32,6 +32,7 @@
 private String type;
 private List policyIds;
 private String dedupIntervalMin;
+private List customDedupFields;
--- End diff --

sounds better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422451#comment-15422451
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74898917
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java
 ---
@@ -32,6 +32,7 @@
 private String type;
 private List policyIds;
 private String dedupIntervalMin;
+private List customDedupFields;
--- End diff --

dedupFields? looks custom is redundant here. 


> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[RalphSu]

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/352#discussion_r74898917
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java
 ---
@@ -32,6 +32,7 @@
 private String type;
 private List policyIds;
 private String dedupIntervalMin;
+private List customDedupFields;
--- End diff --

dedupFields? looks custom is redundant here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[EAGLE BUILD FAILED] incubator-eagle-develop failed on build #37

[Apache Jenkins Server]

The Apache Jenkins build system has built incubator-eagle-develop (build 
#37) Status: Failure Check console output at 
https://builds.apache.org/job/incubator-eagle-develop/37/ to view the 
results. Test Report is at: Test Result

[jira] [Commented] (EAGLE-421) JMX Metric APP use new application framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422411#comment-15422411
 ] 

ASF GitHub Bot commented on EAGLE-421:
--

Github user RalphSu commented on the issue:

https://github.com/apache/incubator-eagle/pull/344
  
Merged


> JMX Metric APP use new application framework
> 
>
> Key: EAGLE-421
> URL: https://issues.apache.org/jira/browse/EAGLE-421
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-421) JMX Metric APP use new application framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422410#comment-15422410
 ] 

ASF GitHub Bot commented on EAGLE-421:
--

Github user RalphSu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/344


> JMX Metric APP use new application framework
> 
>
> Key: EAGLE-421
> URL: https://issues.apache.org/jira/browse/EAGLE-421
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #344: EAGLE-421: JMX Metric APP use new applica...

[RalphSu]

Github user RalphSu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/344


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #344: EAGLE-421: JMX Metric APP use new application fr...

[RalphSu]

Github user RalphSu commented on the issue:

https://github.com/apache/incubator-eagle/pull/344
  
Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422369#comment-15422369
 ] 

ASF GitHub Bot commented on EAGLE-462:
--

GitHub user mizeng opened a pull request:

https://github.com/apache/incubator-eagle/pull/352

EAGLE-462: Alert Dudup

1. same metric generate alert should be deduped
2. user can define tags which is considered by dedup. by default will only
consider about policyId and streamId.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mizeng/incubator-eagle EAGLE-462

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #352


commit c8aae06e15e86c64b8deedc7eab1c3139f0b0b4e
Author: mizeng 
Date:   2016-08-16T07:48:14Z

EAGLE-462: Alert Dudup

1. same metric generate alert should be deduped
2. user can define tags which is considered by dedup. by default will only
consider about policyId and streamId.




> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup

[mizeng]

GitHub user mizeng opened a pull request:

https://github.com/apache/incubator-eagle/pull/352

EAGLE-462: Alert Dudup

1. same metric generate alert should be deduped
2. user can define tags which is considered by dedup. by default will only
consider about policyId and streamId.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mizeng/incubator-eagle EAGLE-462

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #352


commit c8aae06e15e86c64b8deedc7eab1c3139f0b0b4e
Author: mizeng 
Date:   2016-08-16T07:48:14Z

EAGLE-462: Alert Dudup

1. same metric generate alert should be deduped
2. user can define tags which is considered by dedup. by default will only
consider about policyId and streamId.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-465) Hive security monitoring refactor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422356#comment-15422356
 ] 

ASF GitHub Bot commented on EAGLE-465:
--

Github user wujinhu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/349


> Hive security monitoring refactor
> -
>
> Key: EAGLE-465
> URL: https://issues.apache.org/jira/browse/EAGLE-465
> Project: Eagle
>  Issue Type: Improvement
>Reporter: wujinhu
>Assignee: wujinhu
>
> refactor hive security monitoring with new application framework and delete 
> old mr running spout



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #349: [EAGLE-465] Hive security monitoring refa...

[wujinhu]

Github user wujinhu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/349


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---