[jira] [Commented] (EAGLE-781) Add unit test for eagle-audit-base module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670005#comment-15670005
 ] 

ASF GitHub Bot commented on EAGLE-781:
--

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/660#discussion_r88202951
  
--- Diff: 
eagle-core/eagle-query/eagle-audit-base/src/test/java/org/apache/eagle/audit/dao/TestSearchRequestBuilder.java
 ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.audit.dao;
+
+import junit.framework.Assert;
+import org.apache.commons.lang.time.DateUtils;
+import 
org.apache.eagle.service.client.EagleServiceSingleEntityQueryRequest;
+import org.apache.eagle.service.client.IEagleServiceClient;
+import org.apache.eagle.service.client.impl.EagleServiceClientImpl;
+import org.apache.eagle.service.client.impl.SearchRequestBuilder;
+import org.junit.Test;
+
+import java.lang.reflect.Field;
+
+/**
+ * @Since 11/15/16.
+ */
+public class TestSearchRequestBuilder {
+
+@Test
+public void testQuery() throws Exception {
+IEagleServiceClient client = new 
EagleServiceClientImpl("localhost", 9090);
--- End diff --

How could this UT work?


> Add unit test for eagle-audit-base module
> -
>
> Key: EAGLE-781
> URL: https://issues.apache.org/jira/browse/EAGLE-781
> Project: Eagle
>  Issue Type: Bug
>Reporter: Lingang Deng
>Assignee: Lingang Deng
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-773) org.apache.eagle.service.generic.MetaDataResource doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669992#comment-15669992
 ] 

ASF GitHub Bot commented on EAGLE-773:
--

Github user qingwen220 commented on the issue:

https://github.com/apache/incubator-eagle/pull/658
  
Thanks. Next time, you can paste the jira ticket link when you create the 
pull request, so that the jira can track the update of your pull request.  


> org.apache.eagle.service.generic.MetaDataResource doesn't work correctly
> 
>
> Key: EAGLE-773
> URL: https://issues.apache.org/jira/browse/EAGLE-773
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
> Fix For: v0.5.0
>
>
> when you access http:///rest/meta/resource,  the empty response is 
> returned, and an exception is output to log
> {quote}
>  org.codehaus.jackson.JsonParseException: Illegal character ':' (code 0x3a) 
> in base64 content
> {quote}
> This is due to version conflicts between [org.codehaus.jackson and 
> com.fasterxml.jackson|https://stackoverflow.com/questions/40445567/com-fasterxml-jackson-databind-node-objectnode-cannot-be-converted-to-org-codeha],
>  dropwizard uses fasterxml, and 
> org.apache.eagle.service.generic.MetaDataResource uses codehaus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-780) Update spark running config to integrate with the application framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669972#comment-15669972
 ] 

ASF GitHub Bot commented on EAGLE-780:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/659


> Update spark running config to integrate with the application framework
> ---
>
> Key: EAGLE-780
> URL: https://issues.apache.org/jira/browse/EAGLE-780
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
> Fix For: v0.5.0
>
>
> Update spark running config to integrate with the application framework



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-780) Update spark running config to integrate with the application framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669799#comment-15669799
 ] 

ASF GitHub Bot commented on EAGLE-780:
--

Github user qingwen220 commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/659#discussion_r88187298
  
--- Diff: 
eagle-jpm/eagle-jpm-spark-history/src/main/java/org/apache/eagle/jpm/spark/history/SparkHistoryJobAppConfig.java
 ---
@@ -31,7 +31,7 @@
 static final String SPARK_HISTORY_JOB_FETCH_SPOUT_NAME = 
"sparkHistoryJobFetchSpout";
 static final String SPARK_HISTORY_JOB_PARSE_BOLT_NAME = 
"sparkHistoryJobParseBolt";
 
-static final String DEFAULT_SPARK_JOB_HISTORY_ZOOKEEPER_ROOT = 
"/eagle/sparkJobHistory";
+static final String DEFAULT_SPARK_JOB_HISTORY_ZOOKEEPER_ROOT = 
"/app/spark/history";
--- End diff --

update /app -> /apps


> Update spark running config to integrate with the application framework
> ---
>
> Key: EAGLE-780
> URL: https://issues.apache.org/jira/browse/EAGLE-780
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
> Fix For: v0.5.0
>
>
> Update spark running config to integrate with the application framework



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-780) Update spark running config to integrate with the application framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669793#comment-15669793
 ] 

ASF GitHub Bot commented on EAGLE-780:
--

Github user wujinhu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/659#discussion_r88186623
  
--- Diff: 
eagle-jpm/eagle-jpm-spark-history/src/main/java/org/apache/eagle/jpm/spark/history/SparkHistoryJobAppConfig.java
 ---
@@ -31,7 +31,7 @@
 static final String SPARK_HISTORY_JOB_FETCH_SPOUT_NAME = 
"sparkHistoryJobFetchSpout";
 static final String SPARK_HISTORY_JOB_PARSE_BOLT_NAME = 
"sparkHistoryJobParseBolt";
 
-static final String DEFAULT_SPARK_JOB_HISTORY_ZOOKEEPER_ROOT = 
"/eagle/sparkJobHistory";
+static final String DEFAULT_SPARK_JOB_HISTORY_ZOOKEEPER_ROOT = 
"/app/spark/history";
--- End diff --

Currently, mr applications use /apps/mr/history path as zk root, can spark 
apps use the same root /apps?


> Update spark running config to integrate with the application framework
> ---
>
> Key: EAGLE-780
> URL: https://issues.apache.org/jira/browse/EAGLE-780
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
> Fix For: v0.5.0
>
>
> Update spark running config to integrate with the application framework



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-773) org.apache.eagle.service.generic.MetaDataResource doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669773#comment-15669773
 ] 

ASF GitHub Bot commented on EAGLE-773:
--

Github user baibaichen commented on the issue:

https://github.com/apache/incubator-eagle/pull/658
  
@qingwen220 , the detail is in the[  
EAGLE-773](https://issues.apache.org/jira/browse/EAGLE-773). In short, 
dropwizard uses fasterxml, and MetadataResource uses codehaus, which is 
conflict.


> org.apache.eagle.service.generic.MetaDataResource doesn't work correctly
> 
>
> Key: EAGLE-773
> URL: https://issues.apache.org/jira/browse/EAGLE-773
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
> Fix For: v0.5.0
>
>
> when you access http:///rest/meta/resource,  the empty response is 
> returned, and an exception is output to log
> {quote}
>  org.codehaus.jackson.JsonParseException: Illegal character ':' (code 0x3a) 
> in base64 content
> {quote}
> This is due to version conflicts between [org.codehaus.jackson and 
> com.fasterxml.jackson|https://stackoverflow.com/questions/40445567/com-fasterxml-jackson-databind-node-objectnode-cannot-be-converted-to-org-codeha],
>  dropwizard uses fasterxml, and 
> org.apache.eagle.service.generic.MetaDataResource uses codehaus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-781) Add unit test for eagle-audit-base module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669755#comment-15669755
 ] 

ASF GitHub Bot commented on EAGLE-781:
--

GitHub user chitin opened a pull request:

https://github.com/apache/incubator-eagle/pull/660

EAGLE-781 Add unit test for eagle-audit-base module

EAGLE-781 Add unit test for eagle-audit-base module
- Add unit test for eagle-audit-base module.

https://issues.apache.org/jira/browse/EAGLE-781

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chitin/incubator-eagle EAGLE-781

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #660


commit b18b69d4e9e5edbe6959c2b056083b6628a62f38
Author: chitin 
Date:   2016-11-16T07:52:57Z

EAGLE-781 Add unit test for eagle-audit-base module
- Add unit test for eagle-audit-base module.
https://issues.apache.org/jira/browse/EAGLE-781




> Add unit test for eagle-audit-base module
> -
>
> Key: EAGLE-781
> URL: https://issues.apache.org/jira/browse/EAGLE-781
> Project: Eagle
>  Issue Type: Bug
>Reporter: Lingang Deng
>Assignee: Lingang Deng
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-773) org.apache.eagle.service.generic.MetaDataResource doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669756#comment-15669756
 ] 

ASF GitHub Bot commented on EAGLE-773:
--

Github user qingwen220 commented on the issue:

https://github.com/apache/incubator-eagle/pull/658
  
@baibaichen, could you please give us more details on this issue?


> org.apache.eagle.service.generic.MetaDataResource doesn't work correctly
> 
>
> Key: EAGLE-773
> URL: https://issues.apache.org/jira/browse/EAGLE-773
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
> Fix For: v0.5.0
>
>
> when you access http:///rest/meta/resource,  the empty response is 
> returned, and an exception is output to log
> {quote}
>  org.codehaus.jackson.JsonParseException: Illegal character ':' (code 0x3a) 
> in base64 content
> {quote}
> This is due to version conflicts between [org.codehaus.jackson and 
> com.fasterxml.jackson|https://stackoverflow.com/questions/40445567/com-fasterxml-jackson-databind-node-objectnode-cannot-be-converted-to-org-codeha]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-780) Update spark running config to integrate with the application framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669703#comment-15669703
 ] 

ASF GitHub Bot commented on EAGLE-780:
--

GitHub user qingwen220 opened a pull request:

https://github.com/apache/incubator-eagle/pull/659

EAGLE-780: Update spark running config to integrate with the application 
framework

https://issues.apache.org/jira/browse/EAGLE-780

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/qingwen220/incubator-eagle EAGLE-780

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #659


commit b8008efe6cdbbd1e4d1ff9007affb8023b74f840
Author: Qingwen Zhao 
Date:   2016-11-16T05:40:54Z

update spark running job app config

commit 6b0e912ae483f1a95cd63711752c89326e48ccbd
Author: Zhao, Qingwen 
Date:   2016-11-16T07:23:58Z

update spark running job app config




> Update spark running config to integrate with the application framework
> ---
>
> Key: EAGLE-780
> URL: https://issues.apache.org/jira/browse/EAGLE-780
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
> Fix For: v0.5.0
>
>
> Update spark running config to integrate with the application framework



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-773) org.apache.eagle.service.generic.MetaDataResource doesn't work correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669569#comment-15669569
 ] 

ASF GitHub Bot commented on EAGLE-773:
--

GitHub user baibaichen opened a pull request:

https://github.com/apache/incubator-eagle/pull/658

[EAGLE-773] org.apache.eagle.service.generic.MetaDataResource doesn't work 
correctly

This commit fixs this issues and also adds UT to make sure it.

However, for introducing io.dropwizard:dropwizard-testing, we need specify 
the folloing dependencies:

1 only using logback for dropwizard
2 only using org.eclipse.jetty.orbit:javax.servlet
3 only using io.dropwizard.metrics:metrics-core and 
io.dropwizard.metrics:metrics-jvm

All of these are done by excluding other jars

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baibaichen/incubator-eagle 
feature/eagle-service-base-ut

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #658


commit 9dbba9896305dea9b606d0b1f89c61cc87804517
Author: chang chen 
Date:   2016-11-16T06:09:23Z

[EAGLE-773] org.apache.eagle.service.generic.MetaDataResource doesn't work 
correctly

This commit fixs this issues and also adds UT to make sure it.

However, for introducing io.dropwizard:dropwizard-testing, we need specify 
the folloing dependencies:

1 only using logback for dropwizard
2 only using org.eclipse.jetty.orbit:javax.servlet
3 only using io.dropwizard.metrics:metrics-core and 
io.dropwizard.metrics:metrics-jvm

All of these are done by excluding other jars




> org.apache.eagle.service.generic.MetaDataResource doesn't work correctly
> 
>
> Key: EAGLE-773
> URL: https://issues.apache.org/jira/browse/EAGLE-773
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
> Fix For: v0.5.0
>
>
> when you access http:///rest/meta/resource,  the empty response is 
> returned, and an exception is output to log
> {quote}
>  org.codehaus.jackson.JsonParseException: Illegal character ':' (code 0x3a) 
> in base64 content
> {quote}
> This is due to version conflicts between [org.codehaus.jackson and 
> com.fasterxml.jackson|https://stackoverflow.com/questions/40445567/com-fasterxml-jackson-databind-node-objectnode-cannot-be-converted-to-org-codeha]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-779) add a managed task to regularly schedule registered healthchecks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669537#comment-15669537
 ] 

ASF GitHub Bot commented on EAGLE-779:
--

GitHub user wujinhu opened a pull request:

https://github.com/apache/incubator-eagle/pull/657

[EAGLE-779] add a managed task to regularly schedule registered healthchecks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wujinhu/incubator-eagle EAGLE-779

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/657.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #657


commit 9978491765d15159c038300d3786f36e061cfae2
Author: wujinhu 
Date:   2016-11-16T05:34:35Z

add a managed task to regularly schedule registered healthchecks




> add a managed task to regularly schedule registered healthchecks
> 
>
> Key: EAGLE-779
> URL: https://issues.apache.org/jira/browse/EAGLE-779
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> add a managed task to regularly schedule registered healthchecks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-583) implement ldap authentication logic, taking Basic Authentication credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666795#comment-15666795
 ] 

ASF GitHub Bot commented on EAGLE-583:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/649


> implement ldap authentication logic, taking Basic Authentication credentials
> 
>
> Key: EAGLE-583
> URL: https://issues.apache.org/jira/browse/EAGLE-583
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Michael Wu
>Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> give the implementation of ldap authentication on Authenticator interface, 
> taking the Basic Authentication credentials as the input channel. Use basic 
> authentication by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-583) implement ldap authentication logic, taking Basic Authentication credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666708#comment-15666708
 ] 

ASF GitHub Bot commented on EAGLE-583:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/649
  
LGTM, please merge once PR building passed.


> implement ldap authentication logic, taking Basic Authentication credentials
> 
>
> Key: EAGLE-583
> URL: https://issues.apache.org/jira/browse/EAGLE-583
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Michael Wu
>Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> give the implementation of ldap authentication on Authenticator interface, 
> taking the Basic Authentication credentials as the input channel. Use basic 
> authentication by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-770) remove InterProcessMutex from JobHistoryZKStateManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1574#comment-1574
 ] 

ASF GitHub Bot commented on EAGLE-770:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/655


> remove InterProcessMutex from JobHistoryZKStateManager
> --
>
> Key: EAGLE-770
> URL: https://issues.apache.org/jira/browse/EAGLE-770
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> InterProcessMutex works across JVMs. But our applications are running in 
> storm cluster, a storm worker may contains many task threads. So that the 
> lock is useless.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-770) remove InterProcessMutex from JobHistoryZKStateManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666573#comment-15666573
 ] 

ASF GitHub Bot commented on EAGLE-770:
--

GitHub user wujinhu reopened a pull request:

https://github.com/apache/incubator-eagle/pull/655

[EAGLE-770] remove InterProcessMutex from JobHistoryZKStateManager



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wujinhu/incubator-eagle EAGLE-770

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/655.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #655


commit 890648662e1a4398de46a4925869d56f4e4135a4
Author: wujinhu 
Date:   2016-11-15T08:48:11Z

remove InterProcessMutex from JobHistoryZKStateManager

commit e4c9c58fc533f7374f05f9b662e89bd98daf6d60
Author: wujinhu 
Date:   2016-11-15T08:50:08Z

remove InterProcessMutex from JobHistoryZKStateManager




> remove InterProcessMutex from JobHistoryZKStateManager
> --
>
> Key: EAGLE-770
> URL: https://issues.apache.org/jira/browse/EAGLE-770
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> InterProcessMutex works across JVMs. But our applications are running in 
> storm cluster, a storm worker may contains many task threads. So that the 
> lock is useless.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-770) remove InterProcessMutex from JobHistoryZKStateManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666572#comment-15666572
 ] 

ASF GitHub Bot commented on EAGLE-770:
--

Github user wujinhu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/655


> remove InterProcessMutex from JobHistoryZKStateManager
> --
>
> Key: EAGLE-770
> URL: https://issues.apache.org/jira/browse/EAGLE-770
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> InterProcessMutex works across JVMs. But our applications are running in 
> storm cluster, a storm worker may contains many task threads. So that the 
> lock is useless.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-770) remove InterProcessMutex from JobHistoryZKStateManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666556#comment-15666556
 ] 

ASF GitHub Bot commented on EAGLE-770:
--

GitHub user wujinhu opened a pull request:

https://github.com/apache/incubator-eagle/pull/655

[EAGLE-770] remove InterProcessMutex from JobHistoryZKStateManager



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wujinhu/incubator-eagle EAGLE-770

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/655.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #655


commit 890648662e1a4398de46a4925869d56f4e4135a4
Author: wujinhu 
Date:   2016-11-15T08:48:11Z

remove InterProcessMutex from JobHistoryZKStateManager

commit e4c9c58fc533f7374f05f9b662e89bd98daf6d60
Author: wujinhu 
Date:   2016-11-15T08:50:08Z

remove InterProcessMutex from JobHistoryZKStateManager




> remove InterProcessMutex from JobHistoryZKStateManager
> --
>
> Key: EAGLE-770
> URL: https://issues.apache.org/jira/browse/EAGLE-770
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> InterProcessMutex works across JVMs. But our applications are running in 
> storm cluster, a storm worker may contains many task threads. So that the 
> lock is useless.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-583) implement ldap authentication logic, taking Basic Authentication credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666391#comment-15666391
 ] 

ASF GitHub Bot commented on EAGLE-583:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/649
  
LGTM


> implement ldap authentication logic, taking Basic Authentication credentials
> 
>
> Key: EAGLE-583
> URL: https://issues.apache.org/jira/browse/EAGLE-583
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Michael Wu
>Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> give the implementation of ldap authentication on Authenticator interface, 
> taking the Basic Authentication credentials as the input channel. Use basic 
> authentication by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-740) Fix eagle-query checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666390#comment-15666390
 ] 

ASF GitHub Bot commented on EAGLE-740:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/647
  
@koone As the PR changed too many files, please it may take a few days for 
reviewing.


> Fix eagle-query checkstyle warnings
> ---
>
> Key: EAGLE-740
> URL: https://issues.apache.org/jira/browse/EAGLE-740
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-769) InjectMembers in ServerApplication when initialization

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666349#comment-15666349
 ] 

ASF GitHub Bot commented on EAGLE-769:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/654


> InjectMembers in ServerApplication when initialization
> --
>
> Key: EAGLE-769
> URL: https://issues.apache.org/jira/browse/EAGLE-769
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
> InjectMembers in ServerApplication when initialization



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-769) InjectMembers in ServerApplication when initialization

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666279#comment-15666279
 ] 

ASF GitHub Bot commented on EAGLE-769:
--

GitHub user haoch opened a pull request:

https://github.com/apache/incubator-eagle/pull/654

[EAGLE-769] InjectMembers in ServerApplication when initialization

https://issues.apache.org/jira/browse/EAGLE-769

InjectMembers in ServerApplication when initialization

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/haoch/incubator-eagle EAGLE-769

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #654


commit 8179f4c44727a8bfc5a1a9e606f893472d0c98cc
Author: Hao Chen 
Date:   2016-11-15T06:36:01Z

InjectMembers in ServerApplication when initialization




> InjectMembers in ServerApplication when initialization
> --
>
> Key: EAGLE-769
> URL: https://issues.apache.org/jira/browse/EAGLE-769
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
> InjectMembers in ServerApplication when initialization



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-764) MR history feeder support Health Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666155#comment-15666155
 ] 

ASF GitHub Bot commented on EAGLE-764:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/652


> MR history feeder support Health Checks
> ---
>
> Key: EAGLE-764
> URL: https://issues.apache.org/jira/browse/EAGLE-764
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> MR history feeder support Health Checks
> Use Application Health Checks with DropWizard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-764) MR history feeder support Health Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666149#comment-15666149
 ] 

ASF GitHub Bot commented on EAGLE-764:
--

Github user wujinhu commented on the issue:

https://github.com/apache/incubator-eagle/pull/652
  
Fixed


> MR history feeder support Health Checks
> ---
>
> Key: EAGLE-764
> URL: https://issues.apache.org/jira/browse/EAGLE-764
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> MR history feeder support Health Checks
> Use Application Health Checks with DropWizard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-764) MR history feeder support Health Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666064#comment-15666064
 ] 

ASF GitHub Bot commented on EAGLE-764:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/652
  
Check failed, please fix it before merging.


> MR history feeder support Health Checks
> ---
>
> Key: EAGLE-764
> URL: https://issues.apache.org/jira/browse/EAGLE-764
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> MR history feeder support Health Checks
> Use Application Health Checks with DropWizard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-764) MR history feeder support Health Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665996#comment-15665996
 ] 

ASF GitHub Bot commented on EAGLE-764:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/652
  
LGTM.
As a future improvement, we could add a managed task to regularly schedule 
registered healthchecks and report the unhealthy result in different plug-gable 
`healthreport` ways for example: `logging` (by default) or `notification`


> MR history feeder support Health Checks
> ---
>
> Key: EAGLE-764
> URL: https://issues.apache.org/jira/browse/EAGLE-764
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> MR history feeder support Health Checks
> Use Application Health Checks with DropWizard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-764) MR history feeder support Health Checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665978#comment-15665978
 ] 

ASF GitHub Bot commented on EAGLE-764:
--

GitHub user wujinhu opened a pull request:

https://github.com/apache/incubator-eagle/pull/652

[EAGLE-764] MR history feeder support Health Checks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wujinhu/incubator-eagle EAGLE-764

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/652.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #652


commit bf7c54ece4b504e7a448f3b9cf768a63cc8c
Author: wujinhu 
Date:   2016-11-15T03:52:41Z

MR history feeder support Health Checks




> MR history feeder support Health Checks
> ---
>
> Key: EAGLE-764
> URL: https://issues.apache.org/jira/browse/EAGLE-764
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> MR history feeder support Health Checks
> Use Application Health Checks with DropWizard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-766) Set default host of JPM_WEB_APP as null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665912#comment-15665912
 ] 

ASF GitHub Bot commented on EAGLE-766:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/651


> Set default host of JPM_WEB_APP as null
> 
>
> Key: EAGLE-766
> URL: https://issues.apache.org/jira/browse/EAGLE-766
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Hao Chen
> Fix For: v0.5.0
>
>
> Set default host & port of JPM_WEB_APP as N/A to make sure the web will read 
> web service from configured instead of always using current.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-766) Set default host of JPM_WEB_APP as null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665893#comment-15665893
 ] 

ASF GitHub Bot commented on EAGLE-766:
--

GitHub user haoch opened a pull request:

https://github.com/apache/incubator-eagle/pull/651

[EAGLE-766] Set default host & port of JPM_WEB_APP as null

https://issues.apache.org/jira/browse/EAGLE-766

Set default host & port of JPM_WEB_APP as N/A to make sure the web will 
read web service from configured instead of always using current.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/haoch/incubator-eagle EAGLE-766

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #651


commit ec6d966de784ae0f412c7d01213b7aade622e1b9
Author: Hao Chen 
Date:   2016-11-15T02:46:15Z

Set default host & port of JPM_WEB_APP as N/A to make sure the web will 
read web service from configured instead of always using current.




> Set default host of JPM_WEB_APP as null
> 
>
> Key: EAGLE-766
> URL: https://issues.apache.org/jira/browse/EAGLE-766
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Hao Chen
> Fix For: v0.5.0
>
>
> Set default host & port of JPM_WEB_APP as N/A to make sure the web will read 
> web service from configured instead of always using current.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-740) Fix eagle-query checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665814#comment-15665814
 ] 

ASF GitHub Bot commented on EAGLE-740:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/647
  
@koone thanks


> Fix eagle-query checkstyle warnings
> ---
>
> Key: EAGLE-740
> URL: https://issues.apache.org/jira/browse/EAGLE-740
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-583) implement ldap authentication logic, taking Basic Authentication credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665770#comment-15665770
 ] 

ASF GitHub Bot commented on EAGLE-583:
--

GitHub user anyway1021 reopened a pull request:

https://github.com/apache/incubator-eagle/pull/649

[EAGLE-583] implement ldap authentication logic integrated with Basic 
Authentication

implement ldap authentication logic integrated with Basic Authentication

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anyway1021/incubator-eagle EAGLE-583

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #649


commit d80a5bc6c71a03aac4f801c6f035a6a1f94de022
Author: anyway1021 
Date:   2016-11-14T10:15:26Z

implement ldap authentication logic integrated with Basic Authentication




> implement ldap authentication logic, taking Basic Authentication credentials
> 
>
> Key: EAGLE-583
> URL: https://issues.apache.org/jira/browse/EAGLE-583
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Michael Wu
>Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> give the implementation of ldap authentication on Authenticator interface, 
> taking the Basic Authentication credentials as the input channel. Use basic 
> authentication by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-583) implement ldap authentication logic, taking Basic Authentication credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665768#comment-15665768
 ] 

ASF GitHub Bot commented on EAGLE-583:
--

Github user anyway1021 commented on the issue:

https://github.com/apache/incubator-eagle/pull/649
  
try to trigger the pr review ci job


> implement ldap authentication logic, taking Basic Authentication credentials
> 
>
> Key: EAGLE-583
> URL: https://issues.apache.org/jira/browse/EAGLE-583
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Michael Wu
>Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> give the implementation of ldap authentication on Authenticator interface, 
> taking the Basic Authentication credentials as the input channel. Use basic 
> authentication by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-583) implement ldap authentication logic, taking Basic Authentication credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665769#comment-15665769
 ] 

ASF GitHub Bot commented on EAGLE-583:
--

Github user anyway1021 closed the pull request at:

https://github.com/apache/incubator-eagle/pull/649


> implement ldap authentication logic, taking Basic Authentication credentials
> 
>
> Key: EAGLE-583
> URL: https://issues.apache.org/jira/browse/EAGLE-583
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Michael Wu
>Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> give the implementation of ldap authentication on Authenticator interface, 
> taking the Basic Authentication credentials as the input channel. Use basic 
> authentication by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-740) Fix eagle-query checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665761#comment-15665761
 ] 

ASF GitHub Bot commented on EAGLE-740:
--

Github user koone commented on the issue:

https://github.com/apache/incubator-eagle/pull/647
  
@haoch the last commit is already roolback the code format


> Fix eagle-query checkstyle warnings
> ---
>
> Key: EAGLE-740
> URL: https://issues.apache.org/jira/browse/EAGLE-740
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-740) Fix eagle-query checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15663714#comment-15663714
 ] 

ASF GitHub Bot commented on EAGLE-740:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/647
  
Could you please rollback the code format of files under 
`org.apache.eagle.query.antlr.generated` too?


> Fix eagle-query checkstyle warnings
> ---
>
> Key: EAGLE-740
> URL: https://issues.apache.org/jira/browse/EAGLE-740
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-583) implement ldap authentication logic, taking Basic Authentication credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15663441#comment-15663441
 ] 

ASF GitHub Bot commented on EAGLE-583:
--

GitHub user anyway1021 opened a pull request:

https://github.com/apache/incubator-eagle/pull/649

[EAGLE-583] implement ldap authentication logic integrated with Basic 
Authentication

implement ldap authentication logic integrated with Basic Authentication

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anyway1021/incubator-eagle EAGLE-583

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #649


commit d80a5bc6c71a03aac4f801c6f035a6a1f94de022
Author: anyway1021 
Date:   2016-11-14T10:15:26Z

implement ldap authentication logic integrated with Basic Authentication




> implement ldap authentication logic, taking Basic Authentication credentials
> 
>
> Key: EAGLE-583
> URL: https://issues.apache.org/jira/browse/EAGLE-583
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Michael Wu
>Assignee: Michael Wu
> Fix For: v0.5.0
>
>
> give the implementation of ldap authentication on Authenticator interface, 
> taking the Basic Authentication credentials as the input channel. Use basic 
> authentication by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-757) fix alert JdbcDatabaseHandler connection issue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15663101#comment-15663101
 ] 

ASF GitHub Bot commented on EAGLE-757:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/648


> fix alert JdbcDatabaseHandler connection issue
> --
>
> Key: EAGLE-757
> URL: https://issues.apache.org/jira/browse/EAGLE-757
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> 1. fix JdbcDatabaseHandler connection, could not share one connection
> 2. remove code like e.printStackTrace(); use log instead



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-740) Fix eagle-query checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662989#comment-15662989
 ] 

ASF GitHub Bot commented on EAGLE-740:
--

Github user koone commented on the issue:

https://github.com/apache/incubator-eagle/pull/647
  
revert eagle-antlr and exclude Classes under ` 
org.apache.eagle.query.antlr.generated`  from  checstyle
@haoch could you please check again


> Fix eagle-query checkstyle warnings
> ---
>
> Key: EAGLE-740
> URL: https://issues.apache.org/jira/browse/EAGLE-740
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-643) Implement oozieAuditLogAppProvider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662604#comment-15662604
 ] 

ASF GitHub Bot commented on EAGLE-643:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/606


> Implement oozieAuditLogAppProvider
> --
>
> Key: EAGLE-643
> URL: https://issues.apache.org/jira/browse/EAGLE-643
> Project: Eagle
>  Issue Type: New Feature
>Reporter: JiJun Tang
>Assignee: Lingang Deng
>Priority: Minor
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-643) Implement oozieAuditLogAppProvider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662601#comment-15662601
 ] 

ASF GitHub Bot commented on EAGLE-643:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/606
  
LGTM


> Implement oozieAuditLogAppProvider
> --
>
> Key: EAGLE-643
> URL: https://issues.apache.org/jira/browse/EAGLE-643
> Project: Eagle
>  Issue Type: New Feature
>Reporter: JiJun Tang
>Assignee: Lingang Deng
>Priority: Minor
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-740) Fix eagle-query checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662595#comment-15662595
 ] 

ASF GitHub Bot commented on EAGLE-740:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/647
  
Classes under `org.apache.eagle.query.antlr.generated` is automatically 
generated by `antlr`, so suggest to exclude it from checkstyle and keep the 
original code.


> Fix eagle-query checkstyle warnings
> ---
>
> Key: EAGLE-740
> URL: https://issues.apache.org/jira/browse/EAGLE-740
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-757) fix alert JdbcDatabaseHandler connection issue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662586#comment-15662586
 ] 

ASF GitHub Bot commented on EAGLE-757:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/648
  
LGTM, besides follow suggestions:

* Merge `alertDao` into `metadata.store`, probably by simply override 
system property
* Handle possible runtime exception during object mapping.


> fix alert JdbcDatabaseHandler connection issue
> --
>
> Key: EAGLE-757
> URL: https://issues.apache.org/jira/browse/EAGLE-757
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> 1. fix JdbcDatabaseHandler connection, could not share one connection
> 2. remove code like e.printStackTrace(); use log instead



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-757) fix alert JdbcDatabaseHandler connection issue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15661442#comment-15661442
 ] 

ASF GitHub Bot commented on EAGLE-757:
--

GitHub user wujinhu opened a pull request:

https://github.com/apache/incubator-eagle/pull/648

[EAGLE-757] fix alert JdbcDatabaseHandler connection issue



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wujinhu/incubator-eagle EAGLE-757

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #648


commit 2dc4bbdbb6427d566411de9a59a3fd922661b83e
Author: wujinhu 
Date:   2016-11-13T12:28:18Z

fix alert JdbcDatabaseHandler connection issue

commit 0eb2deda42d941f1cb61d5fdc4e4fb7daf890126
Author: wujinhu 
Date:   2016-11-13T12:42:08Z

Merge branch 'master' of https://github.com/apache/incubator-eagle into 
EAGLE-757

# Conflicts:
#   
eagle-core/eagle-metadata/eagle-metadata-jdbc/src/main/java/org/apache/eagle/metadata/store/jdbc/JDBCDataSourceConfig.java




> fix alert JdbcDatabaseHandler connection issue
> --
>
> Key: EAGLE-757
> URL: https://issues.apache.org/jira/browse/EAGLE-757
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: wujinhu
>Assignee: wujinhu
> Fix For: v0.5.0
>
>
> 1. fix JdbcDatabaseHandler connection, could not share one connection
> 2. remove code like e.printStackTrace(); use log instead



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-740) Fix eagle-query checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656677#comment-15656677
 ] 

ASF GitHub Bot commented on EAGLE-740:
--

GitHub user koone opened a pull request:

https://github.com/apache/incubator-eagle/pull/647

[EAGLE-740]Fix eagle-query checkstyle warnings

[EAGLE-740]Fix eagle-query checkstyle warnings

http://issues.apache.org/jira/browse/EAGLE-740

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/koone/incubator-eagle EAGLE-740

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #647


commit 42ebf7284e526e74b82e0c60e95515121f3d79f5
Author: koone 
Date:   2016-11-11T10:05:57Z

[EAGLE-740]Fix eagle-query checkstyle warnings




> Fix eagle-query checkstyle warnings
> ---
>
> Key: EAGLE-740
> URL: https://issues.apache.org/jira/browse/EAGLE-740
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-762) Add AlertEmailPublisherTest test cases

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656015#comment-15656015
 ] 

ASF GitHub Bot commented on EAGLE-762:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/645


> Add AlertEmailPublisherTest test cases
> --
>
> Key: EAGLE-762
> URL: https://issues.apache.org/jira/browse/EAGLE-762
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
> Add AlertEmailPublisherTest test cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-750) Improve coordinator schedule strategy to reuse alert work slot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655974#comment-15655974
 ] 

ASF GitHub Bot commented on EAGLE-750:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/638


> Improve coordinator schedule strategy to reuse alert work slot
> --
>
> Key: EAGLE-750
> URL: https://issues.apache.org/jira/browse/EAGLE-750
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> We catch with some critical problem about alert engine policy schedule 
> strategy: 
> For example for an alert topology with 20 alert bolts , and after boarding 4 
> policies and each assigning 5 slots, then the current alert coordinator will 
> treat the work slots as used up and be unable to schedule any more new 
> policies.
> But in fact some typical eagle deployment will have at least 20+ streams with 
> lots of different partition requirements, which means we could just define 
> very few policies under such scheduling strategy and may waste slot resources 
> of eagle’s deployment infrastructure.
> In original design, we should have designed to reused slot queue among 
> in-conflict monitored stream (stream-partition-sort), then eagle could try to 
> reuse alert slots if possible to improve resource utilization, and  it should 
> be time to implement it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-762) Add AlertEmailPublisherTest test cases

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653401#comment-15653401
 ] 

ASF GitHub Bot commented on EAGLE-762:
--

GitHub user haoch opened a pull request:

https://github.com/apache/incubator-eagle/pull/645

[EAGLE-762] Add AlertEmailPublisherTest test cases

Add AlertEmailPublisherTest test cases

https://issues.apache.org/jira/browse/EAGLE-762


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/haoch/incubator-eagle EAGLE-762

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/645.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #645


commit fda19ff533949bccac971689a4de99604697c8d2
Author: Hao Chen 
Date:   2016-11-10T08:09:42Z

Add AlertEmailPublisherTest test cases

commit 016b85b5636f6695065283d69937e46843083f8c
Author: Hao Chen 
Date:   2016-11-10T08:15:14Z

Fix eagle-parent pom.xml




> Add AlertEmailPublisherTest test cases
> --
>
> Key: EAGLE-762
> URL: https://issues.apache.org/jira/browse/EAGLE-762
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
> Add AlertEmailPublisherTest test cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-760) Policy alert list support size limit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653398#comment-15653398
 ] 

ASF GitHub Bot commented on EAGLE-760:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/644


> Policy alert list support size limit
> 
>
> Key: EAGLE-760
> URL: https://issues.apache.org/jira/browse/EAGLE-760
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Jilin, Jiang
>Assignee: Zhao, Qingwen
>Priority: Minor
>
> GET  /rest/metadata/policies/\{policyId\}/alerts?size=1000



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-760) Policy alert list support size limit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653372#comment-15653372
 ] 

ASF GitHub Bot commented on EAGLE-760:
--

Github user zombieJ commented on the issue:

https://github.com/apache/incubator-eagle/pull/644
  
LGTM


> Policy alert list support size limit
> 
>
> Key: EAGLE-760
> URL: https://issues.apache.org/jira/browse/EAGLE-760
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Jilin, Jiang
>Assignee: Zhao, Qingwen
>Priority: Minor
>
> GET  /rest/metadata/policies/\{policyId\}/alerts?size=1000



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-761) Data skews in KafakStreamSink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653356#comment-15653356
 ] 

ASF GitHub Bot commented on EAGLE-761:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/643


> Data skews in KafakStreamSink
> -
>
> Key: EAGLE-761
> URL: https://issues.apache.org/jira/browse/EAGLE-761
> Project: Eagle
>  Issue Type: Bug
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
>
> When data skews in Kafka sink topic, the alert engine may consumes the data 
> evenly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-761) Data skews in KafakStreamSink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653136#comment-15653136
 ] 

ASF GitHub Bot commented on EAGLE-761:
--

GitHub user qingwen220 opened a pull request:

https://github.com/apache/incubator-eagle/pull/643

EAGLE-761: remove partition key in kafkaStreamSink

https://issues.apache.org/jira/browse/EAGLE-761

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/qingwen220/incubator-eagle EAGLE-761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #643


commit 83c66e7ca399fa7f7fcda21e50103e968351bc5a
Author: Zhao, Qingwen 
Date:   2016-11-10T05:55:58Z

remove partition key in kafkaStreamSink




> Data skews in KafakStreamSink
> -
>
> Key: EAGLE-761
> URL: https://issues.apache.org/jira/browse/EAGLE-761
> Project: Eagle
>  Issue Type: Bug
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
>
> When data skews in Kafka sink topic, the alert engine may consumes the data 
> evenly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-643) Implement oozieAuditLogAppProvider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653010#comment-15653010
 ] 

ASF GitHub Bot commented on EAGLE-643:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/606
  
BTW: Could you please provide more description or screenshot about the 
feature? 

For example:

- Installation Dialog Screenshot
- Populated Stream Schema
- Any UI features?


> Implement oozieAuditLogAppProvider
> --
>
> Key: EAGLE-643
> URL: https://issues.apache.org/jira/browse/EAGLE-643
> Project: Eagle
>  Issue Type: New Feature
>Reporter: JiJun Tang
>Assignee: Lingang Deng
>Priority: Minor
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-643) Implement oozieAuditLogAppProvider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653004#comment-15653004
 ] 

ASF GitHub Bot commented on EAGLE-643:
--

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/606#discussion_r87327457
  
--- Diff: 
eagle-security/eagle-security-oozie-auditlog/src/main/resources/META-INF/providers/org.apache.eagle.security.oozie.parse.OozieAuditLogAppProvider.xml
 ---
@@ -0,0 +1,250 @@
+
+
+
+
+OOZIE_AUDIT_LOG_MONITOR
+Oozie Audit Log Monitor
+0.5.0-incubating
+
org.apache.eagle.security.oozie.parse.OozieAuditLogApplication
+
+
+
+workers
+workers
+1
+number of topology workers
+
+
+topology.numOfJoinTasks
+topology.numOfJoinTasks
--- End diff --

Please change `displayName` of all properties in configuration descriptor 
to **human-readable name**, for example:  topology.numOfJoinTasks -> "Join 
Tasks Num"



> Implement oozieAuditLogAppProvider
> --
>
> Key: EAGLE-643
> URL: https://issues.apache.org/jira/browse/EAGLE-643
> Project: Eagle
>  Issue Type: New Feature
>Reporter: JiJun Tang
>Assignee: Lingang Deng
>Priority: Minor
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-734) Integrate maven-buildNumber-plugin and Version.java

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652993#comment-15652993
 ] 

ASF GitHub Bot commented on EAGLE-734:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/639


> Integrate maven-buildNumber-plugin and Version.java
> ---
>
> Key: EAGLE-734
> URL: https://issues.apache.org/jira/browse/EAGLE-734
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
> * Integrate maven-buildNumber-plugin and Version.java
> * Format eagle version desc
> * Add `/server/version` and `/server/config` API



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-738) Fix eagle-metadata checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651032#comment-15651032
 ] 

ASF GitHub Bot commented on EAGLE-738:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/636


> Fix eagle-metadata checkstyle warnings
> --
>
> Key: EAGLE-738
> URL: https://issues.apache.org/jira/browse/EAGLE-738
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-metadata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-737) Fix eagle-embed checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651028#comment-15651028
 ] 

ASF GitHub Bot commented on EAGLE-737:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/634


> Fix eagle-embed checkstyle warnings
> ---
>
> Key: EAGLE-737
> URL: https://issues.apache.org/jira/browse/EAGLE-737
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-embed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-749) Add unit test for model

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651021#comment-15651021
 ] 

ASF GitHub Bot commented on EAGLE-749:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/632


> Add unit test for model
> ---
>
> Key: EAGLE-749
> URL: https://issues.apache.org/jira/browse/EAGLE-749
> Project: Eagle
>  Issue Type: Sub-task
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-734) Integrate maven-buildNumber-plugin and Version.java

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650968#comment-15650968
 ] 

ASF GitHub Bot commented on EAGLE-734:
--

GitHub user haoch opened a pull request:

https://github.com/apache/incubator-eagle/pull/639

[EAGLE-734] Integrate maven-buildNumber-plugin and Version.java

* Integrate maven-buildNumber-plugin and Version.java
* Format eagle version desc
* Add `/server/version` and `/server/config` API

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/haoch/incubator-eagle buildNumberVersion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/639.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #639


commit e4458f73487d476a1512d1282b32d20fedd8a2f6
Author: Hao Chen 
Date:   2016-11-09T13:37:10Z

Integrate buildnumbern and templating maven-plugin and Version

commit 3de726567c06e56b09ec4bbc4d8b8b83910b71e2
Author: Hao Chen 
Date:   2016-11-09T13:43:03Z

Format eagle version desc




> Integrate maven-buildNumber-plugin and Version.java
> ---
>
> Key: EAGLE-734
> URL: https://issues.apache.org/jira/browse/EAGLE-734
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>
> Integrate maven-buildNumber-plugin and Version.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-750) Improve coordinator schedule strategy to reuse alert work slot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650720#comment-15650720
 ] 

ASF GitHub Bot commented on EAGLE-750:
--

GitHub user garrettlish opened a pull request:

https://github.com/apache/incubator-eagle/pull/638

[EAGLE-750] Improve coordinator schedule strategy to reuse alert work slot

1. Add switch coordinator.reuseBoltInStreams to enable/disable reuse bolt 
in multiple streams
2. Add config coordinator.streamsPerBolt to set maximum streams in one bolt
3. Enable dedicated bolt for specific stream

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrettlish/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #638


commit 1be5974a460fdb61b9bf836145d3292be690d6cb
Author: Xiancheng Li 
Date:   2016-11-09T07:17:15Z

[EAGLE-750] Improve coordinator schedule strategy to reuse alert work slot

1. Add switch coordinator.reuseBoltInStreams to enable/disable reuse bolt 
in multiple streams
2. Add config coordinator.streamsPerBolt to set maximum streams in one bolt
3. Enable dedicated bolt for specific stream




> Improve coordinator schedule strategy to reuse alert work slot
> --
>
> Key: EAGLE-750
> URL: https://issues.apache.org/jira/browse/EAGLE-750
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> We catch with some critical problem about alert engine policy schedule 
> strategy: 
> For example for an alert topology with 20 alert bolts , and after boarding 4 
> policies and each assigning 5 slots, then the current alert coordinator will 
> treat the work slots as used up and be unable to schedule any more new 
> policies.
> But in fact some typical eagle deployment will have at least 20+ streams with 
> lots of different partition requirements, which means we could just define 
> very few policies under such scheduling strategy and may waste slot resources 
> of eagle’s deployment infrastructure.
> In original design, we should have designed to reused slot queue among 
> in-conflict monitored stream (stream-partition-sort), then eagle could try to 
> reuse alert slots if possible to improve resource utilization, and  it should 
> be time to implement it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-643) Implement oozieAuditLogAppProvider

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650648#comment-15650648
 ] 

ASF GitHub Bot commented on EAGLE-643:
--

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/606#discussion_r87172938
  
--- Diff: 
eagle-security/eagle-security-oozie-auditlog/src/main/java/org/apache/eagle/security/oozie/parse/OozieAuditLogAppProvider.java
 ---
@@ -0,0 +1,13 @@
+package org.apache.eagle.security.oozie.parse;
--- End diff --

Missing license header


> Implement oozieAuditLogAppProvider
> --
>
> Key: EAGLE-643
> URL: https://issues.apache.org/jira/browse/EAGLE-643
> Project: Eagle
>  Issue Type: New Feature
>Reporter: JiJun Tang
>Assignee: Lingang Deng
>Priority: Minor
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650643#comment-15650643
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/633


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-739) Fix eagle-metric checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650626#comment-15650626
 ] 

ASF GitHub Bot commented on EAGLE-739:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/637


> Fix eagle-metric checkstyle warnings
> 
>
> Key: EAGLE-739
> URL: https://issues.apache.org/jira/browse/EAGLE-739
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-metric



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-739) Fix eagle-metric checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650497#comment-15650497
 ] 

ASF GitHub Bot commented on EAGLE-739:
--

GitHub user koone opened a pull request:

https://github.com/apache/incubator-eagle/pull/637

[EAGLE-739]Fix eagle-metric checkstyle warnings

[EAGLE-739]Fix eagle-metric checkstyle warnings

https://issues.apache.org/jira/browse/EAGLE-739

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/koone/incubator-eagle EAGLE-739

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #637


commit 64cd3c9035eaebb5cc7e0b26fb1345cfdbb4dd29
Author: koone 
Date:   2016-11-09T09:49:48Z

[EAGLE-739]Fix eagle-metric checkstyle warnings




> Fix eagle-metric checkstyle warnings
> 
>
> Key: EAGLE-739
> URL: https://issues.apache.org/jira/browse/EAGLE-739
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-metric



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650468#comment-15650468
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user garrettlish commented on the issue:

https://github.com/apache/incubator-eagle/pull/631
  
@RalphSu @haoch I add switch for per-event log, could u please review - 
https://github.com/apache/incubator-eagle/pull/633?


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-749) Add unit test for model

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650416#comment-15650416
 ] 

ASF GitHub Bot commented on EAGLE-749:
--

Github user r7raul1984 commented on the issue:

https://github.com/apache/incubator-eagle/pull/632
  
The module coverage will change to 56%.


> Add unit test for model
> ---
>
> Key: EAGLE-749
> URL: https://issues.apache.org/jira/browse/EAGLE-749
> Project: Eagle
>  Issue Type: Sub-task
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650397#comment-15650397
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

GitHub user garrettlish opened a pull request:

https://github.com/apache/incubator-eagle/pull/633

[EAGLE-758] add switch to enable and disable per event log



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrettlish/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #633


commit 7fc1e7b091e04f04a981046a3b219ff749f49852
Author: Xiancheng Li 
Date:   2016-11-09T08:59:28Z

EAGLE-758: add switch to enable and disable event log




> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-749) Add unit test for model

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650393#comment-15650393
 ] 

ASF GitHub Bot commented on EAGLE-749:
--

GitHub user r7raul1984 opened a pull request:

https://github.com/apache/incubator-eagle/pull/632

[EAGLE-749] Add unit test for model.

 - Add unit test for model which under alert-common moudle.
 - Fix equals() hashcode() inconsistent for 
PartitionedEvent,StreamEvent,Publishment.
 - Fix bug for StreamColumn BooleanType.

https://issues.apache.org/jira/browse/EAGLE-749

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r7raul1984/incubator-eagle EAGLE-749

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #632


commit 767302211b4e80db1e46e05b86ee2c7dab7c2373
Author: r7raul1984 
Date:   2016-11-09T07:54:11Z

[EAGLE-749] Add unit test for model.
 - Add unit test for model which under alert-common moudle.
 - Fix equals() hashcode() inconsistent for 
PartitionedEvent,StreamEvent,Publishment.
 - Fix bug for StreamColumn BooleanType.

 https://issues.apache.org/jira/browse/EAGLE-749

commit 075940e5a4511b1d35fe9c6d2b952c6d07ee9621
Author: r7raul1984 
Date:   2016-11-09T08:20:52Z

Merge test into one file.




> Add unit test for model
> ---
>
> Key: EAGLE-749
> URL: https://issues.apache.org/jira/browse/EAGLE-749
> Project: Eagle
>  Issue Type: Sub-task
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-754) Refactor - move ignored test class to corresponding module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650357#comment-15650357
 ] 

ASF GitHub Bot commented on EAGLE-754:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/628


> Refactor -  move ignored test class to corresponding module
> ---
>
> Key: EAGLE-754
> URL: https://issues.apache.org/jira/browse/EAGLE-754
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
>Priority: Minor
>  Labels: unit-test
> Fix For: v0.5.0
>
>
> We already fixed HBase UT in 
> [Eagle-411|https://issues.apache.org/jira/browse/Eagle-411], so we can run 
> previous ignored hbase test of eagle-service-base.  However TestHBaseLogRead2 
> and TestListQueryCompile actually test ListQueryCompile, move them to 
> eagle-query-base



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650162#comment-15650162
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user garrettlish commented on the issue:

https://github.com/apache/incubator-eagle/pull/631
  
storm metrics cannot provide metrics base on group by, etc. You are 
correct, we cannot enable the per-event log in everywhere, I will add a config 
to enable/disable the per-event log. The default value is disabled.


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650155#comment-15650155
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user garrettlish commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/631#discussion_r87147672
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/spout/SpoutOutputCollectorWrapper.java
 ---
@@ -103,7 +103,7 @@ public SpoutOutputCollectorWrapper(CorrelationSpout 
spout,
  */
 List convertedTuple = converter.convert(tuple);
 if (convertedTuple == null) {
-LOG.warn("source data {} can't be converted to a stream, 
ignore this message", tuple);
+LOG.debug("source data {} can't be converted to a stream, 
ignore this message", tuple);
--- End diff --

If u are log the message without manipulating, it is unnecessary to add 
isDebugEnabled check since debug method will do the same thing.


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-747) Add unit test for eagle-storage-base module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650113#comment-15650113
 ] 

ASF GitHub Bot commented on EAGLE-747:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/620


> Add unit test for eagle-storage-base module
> ---
>
> Key: EAGLE-747
> URL: https://issues.apache.org/jira/browse/EAGLE-747
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Lingang Deng
>Assignee: Lingang Deng
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650058#comment-15650058
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/631
  
:-1: 


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-733) Add unit test for MetricSystem

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650046#comment-15650046
 ] 

ASF GitHub Bot commented on EAGLE-733:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/619


> Add unit test for MetricSystem
> --
>
> Key: EAGLE-733
> URL: https://issues.apache.org/jira/browse/EAGLE-733
> Project: Eagle
>  Issue Type: Sub-task
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650044#comment-15650044
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/631


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650030#comment-15650030
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/631
  
For requirements "spout/alert process issue or no event come", please refer 
to storm metrics.


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650022#comment-15650022
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/631
  
Overall, we really don't suggest to print `per-event` log anywhere for any 
big data application.


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650017#comment-15650017
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/631#discussion_r87141359
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/spout/SpoutOutputCollectorWrapper.java
 ---
@@ -103,7 +103,7 @@ public SpoutOutputCollectorWrapper(CorrelationSpout 
spout,
  */
 List convertedTuple = converter.convert(tuple);
 if (convertedTuple == null) {
-LOG.warn("source data {} can't be converted to a stream, 
ignore this message", tuple);
+LOG.debug("source data {} can't be converted to a stream, 
ignore this message", tuple);
--- End diff --

For any `debug` logging, check with `if(LOG.isDebugEnabled())` before.


> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-758) Add tuple log for spout & alert bolt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650004#comment-15650004
 ] 

ASF GitHub Bot commented on EAGLE-758:
--

GitHub user garrettlish opened a pull request:

https://github.com/apache/incubator-eagle/pull/631

EAGLE-758: Add tuple log for spout & alert bolt

Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
missing issue, we don't know whether the spout/alert process issue or no event 
come.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrettlish/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/631.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #631


commit 6acf260e5ee44d2951987cb6dc1cca7f8213a6a4
Author: Xiancheng Li 
Date:   2016-11-09T06:54:30Z

EAGLE-758: Add tuple log for spout & alert bolt




> Add tuple log for spout & alert bolt
> 
>
> Key: EAGLE-758
> URL: https://issues.apache.org/jira/browse/EAGLE-758
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Without tuple log for spout & alert bolt, it is hard to troubleshoot event 
> missing issue, we don't know whether the spout/alert process issue or no 
> event come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-736) Fix eagle-data-process checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649640#comment-15649640
 ] 

ASF GitHub Bot commented on EAGLE-736:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/623


> Fix eagle-data-process checkstyle warnings
> --
>
> Key: EAGLE-736
> URL: https://issues.apache.org/jira/browse/EAGLE-736
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-data-process



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-728) Application can't load application.properties when running local mode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649620#comment-15649620
 ] 

ASF GitHub Bot commented on EAGLE-728:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/612


> Application can't load application.properties when running local mode
> -
>
> Key: EAGLE-728
> URL: https://issues.apache.org/jira/browse/EAGLE-728
> Project: Eagle
>  Issue Type: Bug
>Reporter: Lingang Deng
>Assignee: Lingang Deng
>
> When running local mode, jpm app can't get property 
> "job.name.normalization.rules.key", then get exception
> {code}
> ERROR [2016-11-02 15:18:04,382] 
> org.apache.eagle.jpm.mr.history.crawler.AbstractJobHistoryDAO: fail reading 
> job history file
> ! java.lang.NoClassDefFoundError: Could not initialize class 
> org.apache.eagle.jpm.util.JobNameNormalization
> ! at 
> org.apache.eagle.jpm.mr.history.parser.JHFEventReaderBase.handleJob(JHFEventReaderBase.java:199)
>  ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> org.apache.eagle.jpm.mr.history.parser.JHFMRVer2EventReader.handleJobSubmitted(JHFMRVer2EventReader.java:187)
>  ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> org.apache.eagle.jpm.mr.history.parser.JHFMRVer2EventReader.handleEvent(JHFMRVer2EventReader.java:53)
>  ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> org.apache.eagle.jpm.mr.history.parser.JHFMRVer2Parser.parse(JHFMRVer2Parser.java:61)
>  ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> org.apache.eagle.jpm.mr.history.crawler.DefaultJHFInputStreamCallback.onInputStream(DefaultJHFInputStreamCallback.java:58)
>  ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> org.apache.eagle.jpm.mr.history.crawler.AbstractJobHistoryDAO.readFileContent(AbstractJobHistoryDAO.java:123)
>  ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> org.apache.eagle.jpm.mr.history.crawler.JHFCrawlerDriverImpl.crawl(JHFCrawlerDriverImpl.java:166)
>  [eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> org.apache.eagle.jpm.mr.history.storm.JobHistorySpout.nextTuple(JobHistorySpout.java:160)
>  [eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at 
> backtype.storm.daemon.executor$fn__3373$fn__3388$fn__3417.invoke(executor.clj:565)
>  [storm-core-0.9.3.jar:0.9.3]
> ! at backtype.storm.util$async_loop$fn__464.invoke(util.clj:463) 
> [storm-core-0.9.3.jar:0.9.3]
> ! at clojure.lang.AFn.run(AFn.java:24) 
> [eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-756) metadata change (with coordinator build) in publishment is not sent to runtime bolts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649612#comment-15649612
 ] 

ASF GitHub Bot commented on EAGLE-756:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/630


> metadata change (with coordinator build) in publishment is not sent to 
> runtime bolts
> 
>
> Key: EAGLE-756
> URL: https://issues.apache.org/jira/browse/EAGLE-756
> Project: Eagle
>  Issue Type: Bug
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>
> During test Alert Engine publisher, 
>  it looks like when we have slack publishment, the metadata reload become 
> slow refreshed when use change the metadata and manually trigger the 
> coordinator schedule.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-755) Publishment without streamIds update encountered NPE

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649611#comment-15649611
 ] 

ASF GitHub Bot commented on EAGLE-755:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/629


> Publishment without streamIds update encountered NPE
> 
>
> Key: EAGLE-755
> URL: https://issues.apache.org/jira/browse/EAGLE-755
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> 2016-11-08 22:24:05.924 o.a.c.f.r.c.NodeCache [ERROR] Calling listener
> java.lang.NullPointerException
> at 
> org.apache.eagle.alert.engine.publisher.impl.AlertPublisherImpl.onPublishChange(AlertPublisherImpl.java:170)
>  ~[stormjar.jar:?]
> at 
> org.apache.eagle.alert.engine.runner.AlertPublisherBolt.onAlertPublishSpecChange(AlertPublisherBolt.java:113)
>  ~[stormjar.jar:?]
> at 
> org.apache.eagle.alert.engine.coordinator.impl.AbstractMetadataChangeNotifyService.lambda$notifyAlertPublishBolt$3(AbstractMetadataChangeNot
> at java.util.ArrayList.forEach(ArrayList.java:1249) 
> ~[?:1.8.0_92-internal]
> at 
> org.apache.eagle.alert.engine.coordinator.impl.AbstractMetadataChangeNotifyService.notifyAlertPublishBolt(AbstractMetadataChangeNotifyServic
> at 
> org.apache.eagle.alert.engine.coordinator.impl.ZKMetadataChangeNotifyService.onNewConfig(ZKMetadataChangeNotifyService.java:137)
>  ~[stormjar.
> at 
> org.apache.eagle.alert.config.ConfigBusConsumer.lambda$new$0(ConfigBusConsumer.java:44)
>  ~[stormjar.jar:?]
> at 
> org.apache.curator.framework.recipes.cache.NodeCache$4.apply(NodeCache.java:293)
>  [stormjar.jar:?]
> at 
> org.apache.curator.framework.recipes.cache.NodeCache$4.apply(NodeCache.java:287)
>  [stormjar.jar:?]
> at 
> org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:92)
>  [stormjar.jar:?]
> at 
> com.google.common.util.concurrent.MoreExecutors$DirectExecutorService.execute(MoreExecutors.java:299)
>  [stormjar.jar:?]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-752) JPM statistic need remove jobType

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649544#comment-15649544
 ] 

ASF GitHub Bot commented on EAGLE-752:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/624


> JPM statistic need remove jobType
> -
>
> Key: EAGLE-752
> URL: https://issues.apache.org/jira/browse/EAGLE-752
> Project: Eagle
>  Issue Type: Bug
>Reporter: Jilin, Jiang
>Assignee: Jilin, Jiang
>
> JPM statistic need remove jobType



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-752) JPM statistic need remove jobType

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649520#comment-15649520
 ] 

ASF GitHub Bot commented on EAGLE-752:
--

Github user qingwen220 commented on the issue:

https://github.com/apache/incubator-eagle/pull/624
  
LGTM


> JPM statistic need remove jobType
> -
>
> Key: EAGLE-752
> URL: https://issues.apache.org/jira/browse/EAGLE-752
> Project: Eagle
>  Issue Type: Bug
>Reporter: Jilin, Jiang
>Assignee: Jilin, Jiang
>
> JPM statistic need remove jobType



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-733) Add unit test for MetricSystem

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649483#comment-15649483
 ] 

ASF GitHub Bot commented on EAGLE-733:
--

Github user r7raul1984 commented on the issue:

https://github.com/apache/incubator-eagle/pull/619
  
 @baibaichen The module coverage is changed to 22%.


> Add unit test for MetricSystem
> --
>
> Key: EAGLE-733
> URL: https://issues.apache.org/jira/browse/EAGLE-733
> Project: Eagle
>  Issue Type: Sub-task
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-733) Add unit test for MetricSystem

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649448#comment-15649448
 ] 

ASF GitHub Bot commented on EAGLE-733:
--

Github user baibaichen commented on the issue:

https://github.com/apache/incubator-eagle/pull/619
  
@r7raul1984 how code coverage is changed?


> Add unit test for MetricSystem
> --
>
> Key: EAGLE-733
> URL: https://issues.apache.org/jira/browse/EAGLE-733
> Project: Eagle
>  Issue Type: Sub-task
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-747) Add unit test for eagle-storage-base module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649445#comment-15649445
 ] 

ASF GitHub Bot commented on EAGLE-747:
--

Github user baibaichen commented on the issue:

https://github.com/apache/incubator-eagle/pull/620
  
@chitin how code coverage is changed?


> Add unit test for eagle-storage-base module
> ---
>
> Key: EAGLE-747
> URL: https://issues.apache.org/jira/browse/EAGLE-747
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Lingang Deng
>Assignee: Lingang Deng
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-755) Publishment without streamIds update encountered NPE

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649209#comment-15649209
 ] 

ASF GitHub Bot commented on EAGLE-755:
--

GitHub user garrettlish opened a pull request:

https://github.com/apache/incubator-eagle/pull/629

EAGLE-755: Publishment without streamIds update encountered NPE

fix NPE issue by use google Objects.equals method.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrettlish/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/629.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #629


commit 756cf42fb9ab8046d7057e6bf920bc18fffbba35
Author: Xiancheng Li 
Date:   2016-11-08T23:23:30Z

EAGLE-755: Publishment without streamIds update encountered NPE




> Publishment without streamIds update encountered NPE
> 
>
> Key: EAGLE-755
> URL: https://issues.apache.org/jira/browse/EAGLE-755
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> 2016-11-08 22:24:05.924 o.a.c.f.r.c.NodeCache [ERROR] Calling listener
> java.lang.NullPointerException
> at 
> org.apache.eagle.alert.engine.publisher.impl.AlertPublisherImpl.onPublishChange(AlertPublisherImpl.java:170)
>  ~[stormjar.jar:?]
> at 
> org.apache.eagle.alert.engine.runner.AlertPublisherBolt.onAlertPublishSpecChange(AlertPublisherBolt.java:113)
>  ~[stormjar.jar:?]
> at 
> org.apache.eagle.alert.engine.coordinator.impl.AbstractMetadataChangeNotifyService.lambda$notifyAlertPublishBolt$3(AbstractMetadataChangeNot
> at java.util.ArrayList.forEach(ArrayList.java:1249) 
> ~[?:1.8.0_92-internal]
> at 
> org.apache.eagle.alert.engine.coordinator.impl.AbstractMetadataChangeNotifyService.notifyAlertPublishBolt(AbstractMetadataChangeNotifyServic
> at 
> org.apache.eagle.alert.engine.coordinator.impl.ZKMetadataChangeNotifyService.onNewConfig(ZKMetadataChangeNotifyService.java:137)
>  ~[stormjar.
> at 
> org.apache.eagle.alert.config.ConfigBusConsumer.lambda$new$0(ConfigBusConsumer.java:44)
>  ~[stormjar.jar:?]
> at 
> org.apache.curator.framework.recipes.cache.NodeCache$4.apply(NodeCache.java:293)
>  [stormjar.jar:?]
> at 
> org.apache.curator.framework.recipes.cache.NodeCache$4.apply(NodeCache.java:287)
>  [stormjar.jar:?]
> at 
> org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:92)
>  [stormjar.jar:?]
> at 
> com.google.common.util.concurrent.MoreExecutors$DirectExecutorService.execute(MoreExecutors.java:299)
>  [stormjar.jar:?]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-754) Refactor - move ignored test class to corresponding module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647871#comment-15647871
 ] 

ASF GitHub Bot commented on EAGLE-754:
--

GitHub user baibaichen opened a pull request:

https://github.com/apache/incubator-eagle/pull/628

[EAGLE-754] Refactor - move ignored test class to corresponding module

With this commit, improving code coverage of eagle-entity-base to 51%, code 
coverage of eagle-query-base to 54%

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baibaichen/incubator-eagle feature/UT

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #628


commit fc7f43046c43249ea0ccc71a50be3db9892c2bdf
Author: chang chen 
Date:   2016-11-08T08:39:50Z

[EAGLE-754] Refactor - move ignored test class to corresponding module




> Refactor -  move ignored test class to corresponding module
> ---
>
> Key: EAGLE-754
> URL: https://issues.apache.org/jira/browse/EAGLE-754
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
>Priority: Minor
>  Labels: unit-test
> Fix For: v0.5.0
>
>
> We already fixed HBase UT in 
> [Eagle-411|https://issues.apache.org/jira/browse/Eagle-411], so we can run 
> previous ignored hbase test of eagle-service-base.  However TestHBaseLogRead2 
> and TestListQueryCompile actually test ListQueryCompile, move them to 
> eagle-query-base



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-754) Refactor - move ignored test class to corresponding module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647826#comment-15647826
 ] 

ASF GitHub Bot commented on EAGLE-754:
--

Github user baibaichen closed the pull request at:

https://github.com/apache/incubator-eagle/pull/627


> Refactor -  move ignored test class to corresponding module
> ---
>
> Key: EAGLE-754
> URL: https://issues.apache.org/jira/browse/EAGLE-754
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
>Priority: Minor
>  Labels: unit-test
> Fix For: v0.5.0
>
>
> We already fixed HBase UT in 
> [Eagle-411|https://issues.apache.org/jira/browse/Eagle-411], so we can run 
> previous ignored hbase test of eagle-service-base.  However TestHBaseLogRead2 
> and TestListQueryCompile actually test ListQueryCompile, move them to 
> eagle-query-base



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-754) Refactor - move ignored test class to corresponding module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647825#comment-15647825
 ] 

ASF GitHub Bot commented on EAGLE-754:
--

Github user baibaichen commented on the issue:

https://github.com/apache/incubator-eagle/pull/627
  
missing remove ignore of  TestHBaseLogReader2


> Refactor -  move ignored test class to corresponding module
> ---
>
> Key: EAGLE-754
> URL: https://issues.apache.org/jira/browse/EAGLE-754
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
>Priority: Minor
>  Labels: unit-test
> Fix For: v0.5.0
>
>
> We already fixed HBase UT in 
> [Eagle-411|https://issues.apache.org/jira/browse/Eagle-411], so we can run 
> previous ignored hbase test of eagle-service-base.  However TestHBaseLogRead2 
> and TestListQueryCompile actually test ListQueryCompile, move them to 
> eagle-query-base



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-754) Refactor - move ignored test class to corresponding module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647739#comment-15647739
 ] 

ASF GitHub Bot commented on EAGLE-754:
--

GitHub user baibaichen opened a pull request:

https://github.com/apache/incubator-eagle/pull/627

[EAGLE-754] Refactor - move ignored test class to corresponding module

With this commit, improve code coverage of eagle-entity-base to 51%, code 
coverage of eagle-query-base to 54%

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baibaichen/incubator-eagle feature/UT

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #627


commit 07247691a0d05de705966b0243ef5f5a83f3ec62
Author: chang chen 
Date:   2016-11-08T08:39:50Z

[EAGLE-754] Refactor - move ignored test class to corresponding module




> Refactor -  move ignored test class to corresponding module
> ---
>
> Key: EAGLE-754
> URL: https://issues.apache.org/jira/browse/EAGLE-754
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.0
>Reporter: Chang chen
>Assignee: Chang chen
>Priority: Minor
>  Labels: unit-test
> Fix For: v0.5.0
>
>
> We already fixed HBase UT in 
> [Eagle-411|https://issues.apache.org/jira/browse/Eagle-411], so we can run 
> previous ignored hbase test of eagle-service-base.  However TestHBaseLogRead2 
> and TestListQueryCompile actually test ListQueryCompile, move them to 
> eagle-query-base



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-675) AlertEngine: don't host long-live curator framework for schedule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647451#comment-15647451
 ] 

ASF GitHub Bot commented on EAGLE-675:
--

GitHub user RalphSu opened a pull request:

https://github.com/apache/incubator-eagle/pull/626

EAGLE-675 : AlertEngine: don't host long-live curator framework for s…


…chedule

Author: ralphsu

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RalphSu/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #626


commit 715a8f7a5f02fc7fb59af3816f1711a65b2150ab
Author: Ralph, Su 
Date:   2016-11-08T12:31:57Z

EAGLE-675 : AlertEngine: don't host long-live curator framework for schedule

Author: ralphsu




> AlertEngine: don't host long-live curator framework for schedule
> 
>
> Key: EAGLE-675
> URL: https://issues.apache.org/jira/browse/EAGLE-675
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>
> In Coordinator, the config bus producer is hold as member. This is try to 
> reuse connection for continous operation. But this is buggy, since when zk 
> server in network issue, curator framework would generate a lot of logs that 
> flood the log file.
> Same for ExclusiveExecutor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-746) PolicyValidation is insufficient, and will cause blocking for extended handler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647380#comment-15647380
 ] 

ASF GitHub Bot commented on EAGLE-746:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/625


> PolicyValidation is insufficient, and will cause blocking for extended handler
> --
>
> Key: EAGLE-746
> URL: https://issues.apache.org/jira/browse/EAGLE-746
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>
> Policy validation is hard code to siddhi ql without checking the policy type. 
> Also for complex query, we need to make sure leftjoin query things also works



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-746) PolicyValidation is insufficient, and will cause blocking for extended handler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647358#comment-15647358
 ] 

ASF GitHub Bot commented on EAGLE-746:
--

GitHub user RalphSu opened a pull request:

https://github.com/apache/incubator-eagle/pull/625

EAGLE-746 : PolicyValidation is insufficient, and will cause blocking…


… for extended handler

Author: ralphsu

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RalphSu/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #625


commit 34c69a9314ebecd9f71def46c6f72774e1084f84
Author: Ralph, Su 
Date:   2016-11-08T11:45:49Z

EAGLE-746 : PolicyValidation is insufficient, and will cause blocking for 
extended handler

Author: ralphsu




> PolicyValidation is insufficient, and will cause blocking for extended handler
> --
>
> Key: EAGLE-746
> URL: https://issues.apache.org/jira/browse/EAGLE-746
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.5.0
>Reporter: Su Ralph
>Assignee: Su Ralph
> Fix For: v0.5.0
>
>
> Policy validation is hard code to siddhi ql without checking the policy type. 
> Also for complex query, we need to make sure leftjoin query things also works



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-752) JPM statistic need remove jobType

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647186#comment-15647186
 ] 

ASF GitHub Bot commented on EAGLE-752:
--

GitHub user zombieJ opened a pull request:

https://github.com/apache/incubator-eagle/pull/624

EAGLE-752 JPM statistic need remove jobType

JPM statistic need remove jobType

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zombieJ/incubator-eagle EAGLE-752

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit ebce94d5386d0ea0a90a66d3aa81b93528cdcc1f
Author: zombieJ 
Date:   2016-11-08T10:37:42Z

JPM statistic need remove jobType




> JPM statistic need remove jobType
> -
>
> Key: EAGLE-752
> URL: https://issues.apache.org/jira/browse/EAGLE-752
> Project: Eagle
>  Issue Type: Bug
>Reporter: Jilin, Jiang
>Assignee: Jilin, Jiang
>
> JPM statistic need remove jobType



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-736) Fix eagle-data-process checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647038#comment-15647038
 ] 

ASF GitHub Bot commented on EAGLE-736:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/623
  
LGTM.


> Fix eagle-data-process checkstyle warnings
> --
>
> Key: EAGLE-736
> URL: https://issues.apache.org/jira/browse/EAGLE-736
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-data-process



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-736) Fix eagle-data-process checkstyle warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646845#comment-15646845
 ] 

ASF GitHub Bot commented on EAGLE-736:
--

GitHub user koone opened a pull request:

https://github.com/apache/incubator-eagle/pull/623

[EAGLE-736] Fix eagle-data-process checkstyle warnings



https://issues.apache.org/jira/browse/EAGLE-736
---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/koone/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #623


commit d089b85305b34cfc3dd1c258d1bd22f8
Author: koone 
Date:   2016-11-08T07:59:09Z

[EAGLE-736] Fix eagle-data-process checkstyle warnings




> Fix eagle-data-process checkstyle warnings
> --
>
> Key: EAGLE-736
> URL: https://issues.apache.org/jira/browse/EAGLE-736
> Project: Eagle
>  Issue Type: Bug
>Affects Versions: v0.4.0
>Reporter: luokun
>Assignee: luokun
> Fix For: v0.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Fix checkstyle problems on eagle-data-process



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-751) Two policyDefinitions with different status are equal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646787#comment-15646787
 ] 

ASF GitHub Bot commented on EAGLE-751:
--

GitHub user qingwen220 opened a pull request:

https://github.com/apache/incubator-eagle/pull/622

EAGLE-751: update policyDefinition#equal

https://issues.apache.org/jira/browse/EAGLE-751

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/qingwen220/incubator-eagle EAGEL-751

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #622


commit 8f7c2d03317502e9f121e4ce17cdeab99388a1dc
Author: Zhao, Qingwen 
Date:   2016-11-08T07:29:14Z

update policyDefinition#equal




> Two policyDefinitions with different status are equal 
> --
>
> Key: EAGLE-751
> URL: https://issues.apache.org/jira/browse/EAGLE-751
> Project: Eagle
>  Issue Type: Bug
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
>
> In equal() of  PolicyDefinition, field policyStatus is missed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-741) Make publishment settings both policy & stream awareness

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646382#comment-15646382
 ] 

ASF GitHub Bot commented on EAGLE-741:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/613


> Make publishment settings both policy & stream awareness
> 
>
> Key: EAGLE-741
> URL: https://issues.apache.org/jira/browse/EAGLE-741
> Project: Eagle
>  Issue Type: Improvement
>Affects Versions: v0.5.0
>Reporter: Garrett Li
>Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Currently our publishment is defined policy specific, we cannot publish the 
> alert into different places for one policy although there are multiple output 
> streams for this policy. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-747) Add unit test for eagle-storage-base module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646180#comment-15646180
 ] 

ASF GitHub Bot commented on EAGLE-747:
--

GitHub user chitin opened a pull request:

https://github.com/apache/incubator-eagle/pull/620

EAGLE-747 Add unit test for eagle-storage-base module

EAGLE-747 Add unit test for eagle-storage-base module
- Add unit test.

https://issues.apache.org/jira/browse/EAGLE-747

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chitin/incubator-eagle EAGLE-747

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #620


commit 7efadb4951b74400b8c2aae6a3b5eef72165
Author: chitin 
Date:   2016-11-08T02:07:51Z

EAGLE-747 Add unit test for eagle-storage-base module
- Add unit test.
https://issues.apache.org/jira/browse/EAGLE-747




> Add unit test for eagle-storage-base module
> ---
>
> Key: EAGLE-747
> URL: https://issues.apache.org/jira/browse/EAGLE-747
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Lingang Deng
>Assignee: Lingang Deng
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)