[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[ https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425629#comment-15425629 ] ASF GitHub Bot commented on EAGLE-462: -- Github user mizeng closed the pull request at: https://github.com/apache/incubator-eagle/pull/352 > Alert Dudup - same metric generate alert should be deduped > -- > > Key: EAGLE-462 > URL: https://issues.apache.org/jira/browse/EAGLE-462 > Project: Eagle > Issue Type: Improvement >Reporter: Zeng, Bryant >Assignee: Zeng, Bryant > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[ https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422495#comment-15422495 ] ASF GitHub Bot commented on EAGLE-462: -- Github user mizeng commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74903923 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java --- @@ -35,6 +35,7 @@ private StreamDefinition schema; private String createdBy; private long createdTime; +private boolean isDuplicate = false; --- End diff -- currently it is only for test. But should not "duplicate" be one property for StreamEvent? It sounds more naturally. > Alert Dudup - same metric generate alert should be deduped > -- > > Key: EAGLE-462 > URL: https://issues.apache.org/jira/browse/EAGLE-462 > Project: Eagle > Issue Type: Improvement >Reporter: Zeng, Bryant >Assignee: Zeng, Bryant > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[ https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422465#comment-15422465 ] ASF GitHub Bot commented on EAGLE-462: -- Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74900271 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java --- @@ -35,6 +35,7 @@ private StreamDefinition schema; private String createdBy; private long createdTime; +private boolean isDuplicate = false; --- End diff -- Looks this is only for test verification. Could we avoid add non-required method in stream event, instead use check the statistic info in deduplicator for test verify? > Alert Dudup - same metric generate alert should be deduped > -- > > Key: EAGLE-462 > URL: https://issues.apache.org/jira/browse/EAGLE-462 > Project: Eagle > Issue Type: Improvement >Reporter: Zeng, Bryant >Assignee: Zeng, Bryant > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422460#comment-15422460
]
ASF GitHub Bot commented on EAGLE-462:
--
Github user mizeng commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899457
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
---
@@ -0,0 +1,23 @@
+[
+{
+ "name":"test-stream-output",
+
"type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher",
+ "policyIds": [
+ "perfmon_cpu_host_check", "perfmon_cpu_pool_check"
+ ],
+ "properties": {
+ "subject":"UMP Test Alert",
--- End diff --
got it.
> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
> Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422459#comment-15422459
]
ASF GitHub Bot commented on EAGLE-462:
--
Github user mizeng commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899429
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws
Exception {
if(event == null) {
return;
}
+
+if
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --
mostly Yes.
> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
> Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422456#comment-15422456
]
ASF GitHub Bot commented on EAGLE-462:
--
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899312
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
---
@@ -0,0 +1,23 @@
+[
+{
+ "name":"test-stream-output",
+
"type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher",
+ "policyIds": [
+ "perfmon_cpu_host_check", "perfmon_cpu_pool_check"
+ ],
+ "properties": {
+ "subject":"UMP Test Alert",
--- End diff --
should be eagle test alert in "subject"
> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
> Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[ https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422455#comment-15422455 ] ASF GitHub Bot commented on EAGLE-462: -- Github user mizeng commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74899209 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java --- @@ -32,6 +32,7 @@ private String type; private List policyIds; private String dedupIntervalMin; +private List customDedupFields; --- End diff -- sounds better. > Alert Dudup - same metric generate alert should be deduped > -- > > Key: EAGLE-462 > URL: https://issues.apache.org/jira/browse/EAGLE-462 > Project: Eagle > Issue Type: Improvement >Reporter: Zeng, Bryant >Assignee: Zeng, Bryant > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422454#comment-15422454
]
ASF GitHub Bot commented on EAGLE-462:
--
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899163
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws
Exception {
if(event == null) {
return;
}
+
+if
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --
what does this equals here for? For test only?
> Alert Dudup - same metric generate alert should be deduped
> --
>
> Key: EAGLE-462
> URL: https://issues.apache.org/jira/browse/EAGLE-462
> Project: Eagle
> Issue Type: Improvement
>Reporter: Zeng, Bryant
>Assignee: Zeng, Bryant
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[ https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422451#comment-15422451 ] ASF GitHub Bot commented on EAGLE-462: -- Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74898917 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java --- @@ -32,6 +32,7 @@ private String type; private List policyIds; private String dedupIntervalMin; +private List customDedupFields; --- End diff -- dedupFields? looks custom is redundant here. > Alert Dudup - same metric generate alert should be deduped > -- > > Key: EAGLE-462 > URL: https://issues.apache.org/jira/browse/EAGLE-462 > Project: Eagle > Issue Type: Improvement >Reporter: Zeng, Bryant >Assignee: Zeng, Bryant > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-462) Alert Dudup - same metric generate alert should be deduped
[ https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422369#comment-15422369 ] ASF GitHub Bot commented on EAGLE-462: -- GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/352 EAGLE-462: Alert Dudup 1. same metric generate alert should be deduped 2. user can define tags which is considered by dedup. by default will only consider about policyId and streamId. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle EAGLE-462 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #352 commit c8aae06e15e86c64b8deedc7eab1c3139f0b0b4e Author: mizeng Date: 2016-08-16T07:48:14Z EAGLE-462: Alert Dudup 1. same metric generate alert should be deduped 2. user can define tags which is considered by dedup. by default will only consider about policyId and streamId. > Alert Dudup - same metric generate alert should be deduped > -- > > Key: EAGLE-462 > URL: https://issues.apache.org/jira/browse/EAGLE-462 > Project: Eagle > Issue Type: Improvement >Reporter: Zeng, Bryant >Assignee: Zeng, Bryant > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
