Re: [VOTE] Release Parent POM 5

[Pierre De Rop]

+1

Regards
Pierre

Le jeu 19 avr. 2018 21:22, Raymond Auge  a écrit :

> +1 (non-binding)
>
> - Ray
>
> On Thu, Apr 19, 2018, 21:17 Francois Papon, 
> wrote:
>
> > +1 (non-binding)
> >
> > François
> >
> >
> > Le 19/04/2018 à 17:44, Carsten Ziegeler a écrit :
> > > I would like to call a vote on a new parent pom releases.
> > > This issue has been addressed for this release:
> > > https://issues.apache.org/jira/browse/FELIX-5820
> > >
> > >
> > > Staging repositories:
> > >
> https://repository.apache.org/content/repositories/orgapachefelix-1217/
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures:
> > > http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
> > >
> > > Usage:
> > > sh check_staged_release.sh 1217 /tmp/felix-staging
> > >
> > > Please vote to approve this release:
> > >
> > > [ ] +1 Approve the release
> > > [ ] -1 Veto the release (please provide specific comments)
> > >
> > > Regards
> > > Carsten
> >
> >
>

Re: [VOTE] Release Parent POM 5

[Raymond Auge]

+1 (non-binding)

- Ray

On Thu, Apr 19, 2018, 21:17 Francois Papon, 
wrote:

> +1 (non-binding)
>
> François
>
>
> Le 19/04/2018 à 17:44, Carsten Ziegeler a écrit :
> > I would like to call a vote on a new parent pom releases.
> > This issue has been addressed for this release:
> > https://issues.apache.org/jira/browse/FELIX-5820
> >
> >
> > Staging repositories:
> > https://repository.apache.org/content/repositories/orgapachefelix-1217/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 1217 /tmp/felix-staging
> >
> > Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ] -1 Veto the release (please provide specific comments)
> >
> > Regards
> > Carsten
>
>

Re: [VOTE] Release Parent POM 5

[Francois Papon]

+1 (non-binding)

François


Le 19/04/2018 à 17:44, Carsten Ziegeler a écrit :
> I would like to call a vote on a new parent pom releases.
> This issue has been addressed for this release:
> https://issues.apache.org/jira/browse/FELIX-5820
>
>
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1217/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1217 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> Regards
> Carsten

[jira] [Resolved] (FELIX-5835) Upgrade to JDK 8

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5835.

Resolution: Fixed

https://github.com/apache/felix/commit/dcc561294bb0ef9c6786d9d6a9c74d73bb831374
https://github.com/apache/felix/commit/ef757edfcbf916fb971320a6b50760097d269171


> Upgrade to JDK 8
> 
>
> Key: FELIX-5835
> URL: https://issues.apache.org/jira/browse/FELIX-5835
> Project: Felix
>  Issue Type: New Feature
>  Components: Gogo Command, Gogo JLine, Gogo Runtime, Gogo Shell
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: gogo.jline-1.1.0, gogo.runtime-1.1.0, gogo.shell-1.1.0, 
> gogo.command-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (FELIX-5837) [gogo][jline] Improve styling support

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5837.

Resolution: Fixed

https://github.com/apache/felix/commit/607f748662ef8c5943c94f89c062f36e61200d9e

> [gogo][jline] Improve styling support
> -
>
> Key: FELIX-5837
> URL: https://issues.apache.org/jira/browse/FELIX-5837
> Project: Felix
>  Issue Type: New Feature
>  Components: Gogo JLine
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: gogo.jline-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (FELIX-5836) Upgrade to OSGi r6

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5836.

Resolution: Fixed

https://github.com/apache/felix/commit/448e3127f1d3e6277b2c8005cc2e21b719b2f248

> Upgrade to OSGi r6
> --
>
> Key: FELIX-5836
> URL: https://issues.apache.org/jira/browse/FELIX-5836
> Project: Felix
>  Issue Type: New Feature
>  Components: Gogo Command, Gogo JLine, Gogo Runtime, Gogo Shell
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: gogo.jline-1.1.0, gogo.runtime-1.1.0, gogo.shell-1.1.0, 
> gogo.command-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (FELIX-5834) Upgrade to JLine 3.7.0

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5834.

Resolution: Fixed

https://github.com/apache/felix/commit/9b7580135a8c31254b3b292fc2837cb102054684

> Upgrade to JLine 3.7.0
> --
>
> Key: FELIX-5834
> URL: https://issues.apache.org/jira/browse/FELIX-5834
> Project: Felix
>  Issue Type: New Feature
>  Components: Gogo JLine
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: gogo.jline-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (FELIX-5833) Support for completion of quoted arguments

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5833.

Resolution: Fixed

https://github.com/apache/felix/commit/a58e66f2485319410608ebffa3370db09b5eb1d9

> Support for completion of quoted arguments
> --
>
> Key: FELIX-5833
> URL: https://issues.apache.org/jira/browse/FELIX-5833
> Project: Felix
>  Issue Type: New Feature
>  Components: Gogo JLine
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: gogo.jline-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (FELIX-5837) [gogo][jline] Improve styling support

[Guillaume Nodet (JIRA)]

Guillaume Nodet created FELIX-5837:
--

 Summary: [gogo][jline] Improve styling support
 Key: FELIX-5837
 URL: https://issues.apache.org/jira/browse/FELIX-5837
 Project: Felix
  Issue Type: New Feature
  Components: Gogo JLine
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: gogo.jline-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (FELIX-5836) Upgrade to OSGi r6

[Guillaume Nodet (JIRA)]

Guillaume Nodet created FELIX-5836:
--

 Summary: Upgrade to OSGi r6
 Key: FELIX-5836
 URL: https://issues.apache.org/jira/browse/FELIX-5836
 Project: Felix
  Issue Type: New Feature
  Components: Gogo Command, Gogo JLine, Gogo Runtime, Gogo Shell
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: gogo.jline-1.1.0, gogo.runtime-1.1.0, gogo.shell-1.1.0, 
gogo.command-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (FELIX-5835) Upgrade to JDK 8

[Guillaume Nodet (JIRA)]

Guillaume Nodet created FELIX-5835:
--

 Summary: Upgrade to JDK 8
 Key: FELIX-5835
 URL: https://issues.apache.org/jira/browse/FELIX-5835
 Project: Felix
  Issue Type: New Feature
  Components: Gogo Command, Gogo JLine, Gogo Runtime, Gogo Shell
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: gogo.runtime-1.1.0, gogo.shell-1.1.0, gogo.command-1.1.0, 
gogo.jline-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (FELIX-5834) Upgrade to JLine 3.7.0

[Guillaume Nodet (JIRA)]

Guillaume Nodet created FELIX-5834:
--

 Summary: Upgrade to JLine 3.7.0
 Key: FELIX-5834
 URL: https://issues.apache.org/jira/browse/FELIX-5834
 Project: Felix
  Issue Type: New Feature
  Components: Gogo JLine
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: gogo.jline-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (FELIX-5833) Support for completion of quoted arguments

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reassigned FELIX-5833:
--

Assignee: Guillaume Nodet

> Support for completion of quoted arguments
> --
>
> Key: FELIX-5833
> URL: https://issues.apache.org/jira/browse/FELIX-5833
> Project: Felix
>  Issue Type: New Feature
>  Components: Gogo JLine
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: gogo.jline-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (FELIX-5833) Support for completion of quoted arguments

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated FELIX-5833:
---
Fix Version/s: gogo.jline-1.1.0

> Support for completion of quoted arguments
> --
>
> Key: FELIX-5833
> URL: https://issues.apache.org/jira/browse/FELIX-5833
> Project: Felix
>  Issue Type: New Feature
>  Components: Gogo JLine
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: gogo.jline-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (FELIX-5833) Support for completion of quoted arguments

[Guillaume Nodet (JIRA)]

Guillaume Nodet created FELIX-5833:
--

 Summary: Support for completion of quoted arguments
 Key: FELIX-5833
 URL: https://issues.apache.org/jira/browse/FELIX-5833
 Project: Felix
  Issue Type: New Feature
  Components: Gogo JLine
Reporter: Guillaume Nodet






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (FELIX-5832) ConfigInstaller should only handle events for configurations it manages

[Guillaume Nodet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5832.

   Resolution: Fixed
 Assignee: Guillaume Nodet
Fix Version/s: fileinstall-3.6.6

> ConfigInstaller should only handle events for configurations it manages
> ---
>
> Key: FELIX-5832
> URL: https://issues.apache.org/jira/browse/FELIX-5832
> Project: Felix
>  Issue Type: Bug
>  Components: File Install
>Affects Versions: fileinstall-3.6.0, fileinstall-3.6.2
>Reporter: Chris Drake
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: fileinstall-3.6.6
>
> Attachments: ConfigInstaller.diff
>
>
> Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
> incorrectly write configuration objects which it does not manage to disk.
> For example, given:
> {code:java}
> felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
> and a CustomConfigInstaller implementing the ArtifactInstaller and 
> ConfigurationListener interfaces for .json configuration files, the 
> expectation is that .cfg files will be installed and written back to disk by 
> Felix's ConfigInstaller.  Any .json configuration files will be installed and 
> written to disk by the CustomConfigInstaller. Unfortunately since FileInstall 
> 3.6.0, .json config files written to disk by the CustomConfigInstaller are 
> overwritten by Felix's own ConfigInstaller.
> The regression is caused by a change to the ConfigInstaller, whereby 
> ConfigurationEvents for _*all configuration objects*_ are handled as apposed 
> to previous behaviour where only those configuration objects managed by the 
> Felix ConfigInstaller (aka .cfg and .config) are managed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Parent POM 5

[David Bosschaert]

+1

David

On 19 April 2018 at 14:44, Carsten Ziegeler  wrote:

> I would like to call a vote on a new parent pom releases.
> This issue has been addressed for this release:
> https://issues.apache.org/jira/browse/FELIX-5820
>
>
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1217/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1217 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

Re: [VOTE] Release Parent POM 5

[Carsten Ziegeler]

+1


Carsten Ziegeler wrote
> I would like to call a vote on a new parent pom releases.
> This issue has been addressed for this release:
> https://issues.apache.org/jira/browse/FELIX-5820
> 
> 
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1217/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1217 /tmp/felix-staging
> 
> Please vote to approve this release:
> 
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
> 
> Regards
> Carsten
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Updated] (FELIX-5832) ConfigInstaller should only handle events for configurations it manages

[Chris Drake (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Drake updated FELIX-5832:
---
Description: 
Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
incorrectly write configuration objects which it does not manage to disk.

For example, given:
{code:java}
felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
and a CustomConfigInstaller implementing the ArtifactInstaller and 
ConfigurationListener interfaces for .json configuration files, the expectation 
is that .cfg files will be installed and written back to disk by Felix's 
ConfigInstaller.  Any .json configuration files will be installed and written 
to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, 
.json config files written to disk by the CustomConfigInstaller are overwritten 
by Felix's own ConfigInstaller.

The regression is caused by a change to the ConfigInstaller, whereby 
ConfigurationEvents for _*all configuration objects*_ are handled as apposed to 
previous behaviour where only those configuration objects managed by the Felix 
ConfigInstaller (aka .cfg and .config) are managed.

  was:
Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
incorrectly write configuration objets which it does not manage to disk.

For example, given:
{code:java}
felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
and a CustomConfigInstaller implementing the ArtifactInstaller and 
ConfigurationListener interfaces for .json configuration files, the expectation 
is that .cfg files will be installed and written back to disk by Felix's 
ConfigInstaller.  Any .json configuration files will be installed and written 
to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, 
.json config files written to disk by the CustomConfigInstaller are overwritten 
by Felix's own ConfigInstaller.

The regression is caused by a change to the ConfigInstaller, whereby 
ConfigurationEvents for _*all configuration objects*_ are handled as apposed to 
previous behaviour where only those configuration objects managed by the Felix 
ConfigInstaller (aka .cfg and .config) are managed.


> ConfigInstaller should only handle events for configurations it manages
> ---
>
> Key: FELIX-5832
> URL: https://issues.apache.org/jira/browse/FELIX-5832
> Project: Felix
>  Issue Type: Bug
>  Components: File Install
>Affects Versions: fileinstall-3.6.0, fileinstall-3.6.2
>Reporter: Chris Drake
>Priority: Major
> Attachments: ConfigInstaller.diff
>
>
> Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
> incorrectly write configuration objects which it does not manage to disk.
> For example, given:
> {code:java}
> felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
> and a CustomConfigInstaller implementing the ArtifactInstaller and 
> ConfigurationListener interfaces for .json configuration files, the 
> expectation is that .cfg files will be installed and written back to disk by 
> Felix's ConfigInstaller.  Any .json configuration files will be installed and 
> written to disk by the CustomConfigInstaller. Unfortunately since FileInstall 
> 3.6.0, .json config files written to disk by the CustomConfigInstaller are 
> overwritten by Felix's own ConfigInstaller.
> The regression is caused by a change to the ConfigInstaller, whereby 
> ConfigurationEvents for _*all configuration objects*_ are handled as apposed 
> to previous behaviour where only those configuration objects managed by the 
> Felix ConfigInstaller (aka .cfg and .config) are managed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] felix pull request #134: [FELIX-5832] Only handle ConfigurationEvents for co...

[cgdrake]

GitHub user cgdrake opened a pull request:

https://github.com/apache/felix/pull/134

[FELIX-5832] Only handle ConfigurationEvents for config objects managed by 
us



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cgdrake/felix bugfix/FELIX-5832

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134






---

[jira] [Commented] (FELIX-5832) ConfigInstaller should only handle events for configurations it manages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FELIX-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444241#comment-16444241
 ] 

ASF GitHub Bot commented on FELIX-5832:
---

GitHub user cgdrake opened a pull request:

https://github.com/apache/felix/pull/134

[FELIX-5832] Only handle ConfigurationEvents for config objects managed by 
us



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cgdrake/felix bugfix/FELIX-5832

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134






> ConfigInstaller should only handle events for configurations it manages
> ---
>
> Key: FELIX-5832
> URL: https://issues.apache.org/jira/browse/FELIX-5832
> Project: Felix
>  Issue Type: Bug
>  Components: File Install
>Affects Versions: fileinstall-3.6.0, fileinstall-3.6.2
>Reporter: Chris Drake
>Priority: Major
> Attachments: ConfigInstaller.diff
>
>
> Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
> incorrectly write configuration objets which it does not manage to disk.
> For example, given:
> {code:java}
> felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
> and a CustomConfigInstaller implementing the ArtifactInstaller and 
> ConfigurationListener interfaces for .json configuration files, the 
> expectation is that .cfg files will be installed and written back to disk by 
> Felix's ConfigInstaller.  Any .json configuration files will be installed and 
> written to disk by the CustomConfigInstaller. Unfortunately since FileInstall 
> 3.6.0, .json config files written to disk by the CustomConfigInstaller are 
> overwritten by Felix's own ConfigInstaller.
> The regression is caused by a change to the ConfigInstaller, whereby 
> ConfigurationEvents for _*all configuration objects*_ are handled as apposed 
> to previous behaviour where only those configuration objects managed by the 
> Felix ConfigInstaller (aka .cfg and .config) are managed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (FELIX-5832) ConfigInstaller should only handle events for configurations it manages

[Chris Drake (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Drake updated FELIX-5832:
---
Description: 
Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
incorrectly write configuration objets which it does not manage to disk.

For example, given:
{code:java}
felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
and a CustomConfigInstaller implementing the ArtifactInstaller and 
ConfigurationListener interfaces for .json configuration files, the expectation 
is that .cfg files will be installed and written back to disk by Felix's 
ConfigInstaller.  Any .json configuration files will be installed and written 
to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, 
.json config files written to disk by the CustomConfigInstaller are overwritten 
by Felix's own ConfigInstaller.

The regression is caused by a change to the ConfigInstaller, whereby 
ConfigurationEvents for _*all configuration objects*_ are handled as apposed to 
previous behaviour where only those configuration objects managed by the Felix 
ConfigInstaller (aka .cfg and .config) are managed.

  was:
Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
incorrectly write configuration objets which it does not manage to disk.

For example, given:

{{felix.fileinstall.filter=.*\\.cfg|.*\\}}{{.json}}

and a CustomConfigInstaller implementing the ArtifactInstaller and 
ConfigurationListener interfaces for .json configuration files, the expectation 
is that .cfg files will be installed and written back to disk by Felix's 
ConfigInstaller.  Any .json configuration files will be installed and written 
to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, 
.json config files written to disk by the CustomConfigInstaller are overwritten 
by Felix's own ConfigInstaller.

The regression is caused by a change to the ConfigInstaller, whereby 
ConfigurationEvents for _*all configuration objects*_ are handled as apposed to 
previous behaviour where only those configuration objects managed by the Felix 
ConfigInstaller (aka .cfg and .config) are managed.


> ConfigInstaller should only handle events for configurations it manages
> ---
>
> Key: FELIX-5832
> URL: https://issues.apache.org/jira/browse/FELIX-5832
> Project: Felix
>  Issue Type: Bug
>  Components: File Install
>Affects Versions: fileinstall-3.6.0, fileinstall-3.6.2
>Reporter: Chris Drake
>Priority: Major
> Attachments: ConfigInstaller.diff
>
>
> Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
> incorrectly write configuration objets which it does not manage to disk.
> For example, given:
> {code:java}
> felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
> and a CustomConfigInstaller implementing the ArtifactInstaller and 
> ConfigurationListener interfaces for .json configuration files, the 
> expectation is that .cfg files will be installed and written back to disk by 
> Felix's ConfigInstaller.  Any .json configuration files will be installed and 
> written to disk by the CustomConfigInstaller. Unfortunately since FileInstall 
> 3.6.0, .json config files written to disk by the CustomConfigInstaller are 
> overwritten by Felix's own ConfigInstaller.
> The regression is caused by a change to the ConfigInstaller, whereby 
> ConfigurationEvents for _*all configuration objects*_ are handled as apposed 
> to previous behaviour where only those configuration objects managed by the 
> Felix ConfigInstaller (aka .cfg and .config) are managed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (FELIX-5832) ConfigInstaller should only handle events for configurations it manages

[Chris Drake (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Drake updated FELIX-5832:
---
Description: 
Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
incorrectly write configuration objets which it does not manage to disk.

For example, given:

{{felix.fileinstall.filter=.*\\.cfg|.*\\}}{{.json}}

and a CustomConfigInstaller implementing the ArtifactInstaller and 
ConfigurationListener interfaces for .json configuration files, the expectation 
is that .cfg files will be installed and written back to disk by Felix's 
ConfigInstaller.  Any .json configuration files will be installed and written 
to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, 
.json config files written to disk by the CustomConfigInstaller are overwritten 
by Felix's own ConfigInstaller.

The regression is caused by a change to the ConfigInstaller, whereby 
ConfigurationEvents for _*all configuration objects*_ are handled as apposed to 
previous behaviour where only those configuration objects managed by the Felix 
ConfigInstaller (aka .cfg and .config) are managed.

  was:
Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
incorrectly write configuration objets which it does not manage to disk.

For example, given:

{{felix.fileinstall.filter=.*\\.cfg|.*\\.json}}

and a CustomConfigInstaller implementing the ArtifactInstaller and 
ConfigurationListener interfaces for .json configuration files, the expectation 
is that .cfg files will be installed and written back to disk by Felix's 
ConfigInstaller.  Any .json configuration files will be installed and written 
to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, 
.json config files written to disk by the CustomConfigInstaller are overwritten 
by Felix's own ConfigInstaller.

The regression is caused by a change to the ConfigInstaller, whereby 
ConfigurationEvents for _*all configuration objects*_ are handled as apposed to 
previous behaviour where only those configuration objects managed by the Felix 
ConfigInstaller (aka .cfg and .config) are managed.


> ConfigInstaller should only handle events for configurations it manages
> ---
>
> Key: FELIX-5832
> URL: https://issues.apache.org/jira/browse/FELIX-5832
> Project: Felix
>  Issue Type: Bug
>  Components: File Install
>Affects Versions: fileinstall-3.6.0, fileinstall-3.6.2
>Reporter: Chris Drake
>Priority: Major
> Attachments: ConfigInstaller.diff
>
>
> Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
> incorrectly write configuration objets which it does not manage to disk.
> For example, given:
> {{felix.fileinstall.filter=.*\\.cfg|.*\\}}{{.json}}
> and a CustomConfigInstaller implementing the ArtifactInstaller and 
> ConfigurationListener interfaces for .json configuration files, the 
> expectation is that .cfg files will be installed and written back to disk by 
> Felix's ConfigInstaller.  Any .json configuration files will be installed and 
> written to disk by the CustomConfigInstaller. Unfortunately since FileInstall 
> 3.6.0, .json config files written to disk by the CustomConfigInstaller are 
> overwritten by Felix's own ConfigInstaller.
> The regression is caused by a change to the ConfigInstaller, whereby 
> ConfigurationEvents for _*all configuration objects*_ are handled as apposed 
> to previous behaviour where only those configuration objects managed by the 
> Felix ConfigInstaller (aka .cfg and .config) are managed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (FELIX-5832) ConfigInstaller should only handle events for configurations it manages

[Chris Drake (JIRA)]

Chris Drake created FELIX-5832:
--

 Summary: ConfigInstaller should only handle events for 
configurations it manages
 Key: FELIX-5832
 URL: https://issues.apache.org/jira/browse/FELIX-5832
 Project: Felix
  Issue Type: Bug
  Components: File Install
Affects Versions: fileinstall-3.6.2, fileinstall-3.6.0
Reporter: Chris Drake
 Attachments: ConfigInstaller.diff

Recent changes introduced by FELIX-5609 have caused ConfigInstaller to 
incorrectly write configuration objets which it does not manage to disk.

For example, given:

{{felix.fileinstall.filter=.*\\.cfg|.*\\.json}}

and a CustomConfigInstaller implementing the ArtifactInstaller and 
ConfigurationListener interfaces for .json configuration files, the expectation 
is that .cfg files will be installed and written back to disk by Felix's 
ConfigInstaller.  Any .json configuration files will be installed and written 
to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, 
.json config files written to disk by the CustomConfigInstaller are overwritten 
by Felix's own ConfigInstaller.

The regression is caused by a change to the ConfigInstaller, whereby 
ConfigurationEvents for _*all configuration objects*_ are handled as apposed to 
previous behaviour where only those configuration objects managed by the Felix 
ConfigInstaller (aka .cfg and .config) are managed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Parent POM 5

[Karl Pauls]

+1

regards,

Karl

On Thu, Apr 19, 2018 at 3:44 PM, Carsten Ziegeler  wrote:
> I would like to call a vote on a new parent pom releases.
> This issue has been addressed for this release:
> https://issues.apache.org/jira/browse/FELIX-5820
>
>
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1217/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1217 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



-- 
Karl Pauls
karlpa...@gmail.com

[VOTE] Release Parent POM 5

[Carsten Ziegeler]

I would like to call a vote on a new parent pom releases.
This issue has been addressed for this release:
https://issues.apache.org/jira/browse/FELIX-5820


Staging repositories:
https://repository.apache.org/content/repositories/orgapachefelix-1217/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1217 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Proposal to donate the system readiness check framework to Apache Felix

[Christian Schneider]

Hi JB,

I did not get this. What do you mean by external dependency?
The code only depends on the OSGi specs and slf4j api. It runtime it needs
the scr and optionally a http service. In the reference docs you also find
how to set it up in Apache Karaf.

Best
Christian


2018-04-19 5:50 GMT+02:00 Jean-Baptiste Onofré :

> Hi Christian
>
> That's interesting. Can you enlight a bit on the external dependency
> required by the codebase ?
>
> Regards
> JB
>
> Le 17 avr. 2018 à 12:09, à 12:09, Christian Schneider <
> ch...@die-schneider.net> a écrit:
> >Dear Felix community,
> >
> >during the last weeks Andrei Dulvac and I worked on a small framework
> >to
> >check if an OSGi based system is fully up.
> >
> >Our work originated in testing sling modules and whole sling instances.
> >We
> >soon found though that the concept is more general than sling and can
> >be
> >applied to any OSGi based system.
> >
> >The system readiness framework has a SystemReadinessMonitor service
> >that
> >reports the aggregated state of the system. It delegates to
> >SystemReadinessCheck services that each check for a certain aspect. We
> >implemented a first check based on a list of expected top level
> >services.
> >The system can be customised by adding specific checks for your
> >application. For example we plan to add sling specific checks inside
> >the
> >sling project.
> >
> >In addition to simply detecting if the system is ready we also created
> >a DS
> >based root cause analysis that can be very helpful to detect why a set
> >of
> >components does not come up as expected.
> >
> >We would like to donate this project to the Apache Felix project as it
> >might get more attention there by people that are not related to sling.
> >The
> >project is Apache licensed from the start and we already got a basic
> >documentation as well as good test coverage.
> >
> >We currently host it in this github repository:
> >https://github.com/dulvac/system-readiness
> >
> >The packages are still mentioning sling but of course we would change
> >this
> >to felix if this community is interested in the donation.
> >
> >Best regards
> >
> >Christian and Andrei
> >
> >
> >--
> >--
> >Christian Schneider
> >http://www.liquid-reality.de
> >
> >Computer Scientist
> >http://www.adobe.com
>



-- 
-- 
Christian Schneider
http://www.liquid-reality.de

Computer Scientist
http://www.adobe.com