[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749575#comment-16749575
]
ASF GitHub Bot commented on FELIX-6034:
---
GitHub user jbonofre opened a pull request:
https://github.com/apache/felix/pull/169
[FELIX-6034] Remove Requirement from Gogo JLine
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/felix FELIX-6034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
commit 0232e90938528333cf1e4a74adf8d372778d8ed5
Author: Paul McCulloch
Date: 2018-10-17T15:34:26Z
FELIX-5968 Posix 'ls' command ignores .. unless -a is specified
FELIX-5968
Posix 'ls' command ignores .. unless -a is specified
commit b8468b585a4d3b806cd0f2305b27c92b10b00473
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:16:14Z
[FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in
Apache Karaf shell
commit 9cabff641bd7cea4b606d0ee3251cd44ba8e289c
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:20:25Z
[FELIX-5963] Use named ExecutorService
commit bdb9fe5c0a84cacf198ffddc48dd14332cbe8125
Author: jbonofre
Date: 2019-01-22T14:36:59Z
[FELIX-5963] This closes #168
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851825
13f79535-47bb-0310-9956-ffa450edef68
commit 960943684003e763669bb662d6c220702602446c
Author: jbonofre
Date: 2019-01-22T14:40:53Z
[FELIX-5968] This closes #158
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851826
13f79535-47bb-0310-9956-ffa450edef68
commit 4a4df4950e045eb7bcebf2c5fc9d8fc8b6cd8b6f
Author: jbonofre
Date: 2019-01-22T14:54:54Z
[FELIX-6030] This closes #167
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851828
13f79535-47bb-0310-9956-ffa450edef68
commit 58c69580de5385b7ebd018f9abe56270779d7b97
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:06:10Z
[FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix
one
commit 0485eaf87c1237b7ab724cfd67fa1529697558b9
Author: jbonofre
Date: 2019-01-22T16:25:39Z
[FELIX-6033] This closes #166
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851830
13f79535-47bb-0310-9956-ffa450edef68
commit db0db44b5bdb798ae0d309fe0414b390f63552da
Author: Jean-Baptiste Onofré
Date: 2019-01-23T06:52:28Z
[FELIX-6034] Remove Requirement from Gogo JLine
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] felix pull request #169: [FELIX-6034] Remove Requirement from Gogo JLine
GitHub user jbonofre opened a pull request: https://github.com/apache/felix/pull/169 [FELIX-6034] Remove Requirement from Gogo JLine You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/felix FELIX-6034 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/felix/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit 0232e90938528333cf1e4a74adf8d372778d8ed5 Author: Paul McCulloch Date: 2018-10-17T15:34:26Z FELIX-5968 Posix 'ls' command ignores .. unless -a is specified FELIX-5968 Posix 'ls' command ignores .. unless -a is specified commit b8468b585a4d3b806cd0f2305b27c92b10b00473 Author: Jean-Baptiste Onofré Date: 2019-01-22T14:16:14Z [FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in Apache Karaf shell commit 9cabff641bd7cea4b606d0ee3251cd44ba8e289c Author: Jean-Baptiste Onofré Date: 2019-01-22T14:20:25Z [FELIX-5963] Use named ExecutorService commit bdb9fe5c0a84cacf198ffddc48dd14332cbe8125 Author: jbonofre Date: 2019-01-22T14:36:59Z [FELIX-5963] This closes #168 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851825 13f79535-47bb-0310-9956-ffa450edef68 commit 960943684003e763669bb662d6c220702602446c Author: jbonofre Date: 2019-01-22T14:40:53Z [FELIX-5968] This closes #158 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851826 13f79535-47bb-0310-9956-ffa450edef68 commit 4a4df4950e045eb7bcebf2c5fc9d8fc8b6cd8b6f Author: jbonofre Date: 2019-01-22T14:54:54Z [FELIX-6030] This closes #167 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851828 13f79535-47bb-0310-9956-ffa450edef68 commit 58c69580de5385b7ebd018f9abe56270779d7b97 Author: Jean-Baptiste Onofré Date: 2019-01-22T14:06:10Z [FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix one commit 0485eaf87c1237b7ab724cfd67fa1529697558b9 Author: jbonofre Date: 2019-01-22T16:25:39Z [FELIX-6033] This closes #166 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851830 13f79535-47bb-0310-9956-ffa450edef68 commit db0db44b5bdb798ae0d309fe0414b390f63552da Author: Jean-Baptiste Onofré Date: 2019-01-23T06:52:28Z [FELIX-6034] Remove Requirement from Gogo JLine ---
[jira] [Created] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
Jean-Baptiste Onofré created FELIX-6034:
---
Summary: Gogo JLine requirement doesn't allow to embed gogo.jline
Key: FELIX-6034
URL: https://issues.apache.org/jira/browse/FELIX-6034
Project: Felix
Issue Type: Bug
Components: Gogo JLine
Affects Versions: gogo.jline-1.1.2
Reporter: Jean-Baptiste Onofré
Assignee: Jean-Baptiste Onofré
Fix For: gogo.jline-1.1.3
Felix Gogo Jline 1.1.2 introduced a Requirement:
{code}
@Requirement(
effective = "active",
namespace = "org.apache.felix.gogo",
name = "command.implementation",
version = "1.0.0"
)
{code}
This requirement is a contract to find concrete command. However, in the case
of Gogo JLine embedded as a standalone bundle, waiting for commands
implementation (later on), this requirement doesn't allow to start. That's the
case in Apache Karaf shell.
[~rotty3000] do you mind if I remove this requirement (as I did other fixes
like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
and then, I will have to find a bypass or at least a fake command providing a
capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (FELIX-6033) wc command should be compliant with posix ones
[
https://issues.apache.org/jira/browse/FELIX-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré resolved FELIX-6033.
-
Resolution: Fixed
> wc command should be compliant with posix ones
> --
>
> Key: FELIX-6033
> URL: https://issues.apache.org/jira/browse/FELIX-6033
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.0, gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> The Posix {{wc}} command formatting is not fully correct. For instance, a
> simple:
> {code}
> echo "foo\nbar"|wc -l
> {code}
> displays:
> {code}
>2 2
> {code}
> So the output formatting is not correct (result is displayed twice) and
> {{wc}} can't be easily used in scripting.
> To be compliant with standard Posix {{wc}} command, the output should be:
> {code}
> 2
> {code}
> I'm adding tests and fixes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] felix pull request #166: [FELIX-6033] Align Felix Gogo wc posix action compl...
Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/166 ---
[jira] [Commented] (FELIX-6033) wc command should be compliant with posix ones
[
https://issues.apache.org/jira/browse/FELIX-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748883#comment-16748883
]
ASF GitHub Bot commented on FELIX-6033:
---
Github user asfgit closed the pull request at:
https://github.com/apache/felix/pull/166
> wc command should be compliant with posix ones
> --
>
> Key: FELIX-6033
> URL: https://issues.apache.org/jira/browse/FELIX-6033
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.0, gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> The Posix {{wc}} command formatting is not fully correct. For instance, a
> simple:
> {code}
> echo "foo\nbar"|wc -l
> {code}
> displays:
> {code}
>2 2
> {code}
> So the output formatting is not correct (result is displayed twice) and
> {{wc}} can't be easily used in scripting.
> To be compliant with standard Posix {{wc}} command, the output should be:
> {code}
> 2
> {code}
> I'm adding tests and fixes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (FELIX-6030) @Header in gogo.jline causing maven-bundle-plugin failure
[
https://issues.apache.org/jira/browse/FELIX-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré resolved FELIX-6030.
-
Resolution: Fixed
> @Header in gogo.jline causing maven-bundle-plugin failure
> -
>
> Key: FELIX-6030
> URL: https://issues.apache.org/jira/browse/FELIX-6030
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> In the https://svn.apache.org/viewvc?view=revision=1849343 revision,
> Gogo JLine bundle {{Activator}} now contains:
> {code}
> @Header(name = Constants.BUNDLE_ACTIVATOR, value = "${@class}")
> {code}
> In Karaf, we "wrap" {{gogo.jline}} in Karaf {{shell.core}}:
> {code}
>
> org.apache.felix
> maven-bundle-plugin
>
>
>
> org.osgi.service.event;resolution:=optional,
> org.apache.karaf.branding;resolution:=optional,
> !org.apache.felix.gogo.jline*,
> !org.apache.sshd.*,
> *
>
>
>
> org.apache.karaf.shell.api.*;version=${project.version},
>
> org.apache.karaf.shell.support.*;version=${project.version},
> org.apache.felix.service.command,
> org.apache.felix.service.threadio
>
>
> org.apache.karaf.service.guard.tools,
> org.apache.karaf.shell.impl.*,
> org.apache.karaf.util,
> org.apache.karaf.util.filesstream,
> org.apache.karaf.util.jaas,
> org.apache.karaf.util.tracker,
> org.apache.felix.utils.properties,
> org.apache.felix.utils.extender,
> org.apache.felix.utils.manifest,
> org.apache.felix.gogo.jline,
> org.apache.felix.gogo.runtime,
> org.apache.felix.gogo.runtime.threadio,
> org.apache.felix.service.command,
> org.apache.felix.service.threadio,
>
>
>
> osgi.service;effective:=active;objectClass=org.apache.karaf.shell.api.console.SessionFactory
>
>
> org.apache.karaf.shell.impl.console.osgi.Activator
>
>
>
> org.apache.karaf.shell.impl.console.standalone.Main
>
>
> true
>
>
> {code}
> Since the introduction of {{@Header}} in Felix Gogo JLine, the build fails
> with:
> {code}
> [ERROR] Bundle
> org.apache.karaf.shell:org.apache.karaf.shell.core:bundle:4.2.3-SNAPSHOT :
> The Bundle-Activator header only supports a single type. The following types
> were found:
> org.apache.karaf.shell.impl.console.osgi.Activator,org.apache.felix.gogo.jline.Activator.
> This usually happens when a macro resolves to multiple types
> [ERROR] Error(s) found in bundle configuration
> {code}
> [~rotty3000] do you know a workaround in the {{maven-bundle-plugin}} about
> that ? If not, do you mind if I remove {{@Header}} from Gogo JLine Activator ?
> Thanks.
> JB
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] felix pull request #167: [FELIX-6030] Remove @Header on Gogo JLine Activator...
Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/167 ---
[jira] [Commented] (FELIX-6030) @Header in gogo.jline causing maven-bundle-plugin failure
[
https://issues.apache.org/jira/browse/FELIX-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748801#comment-16748801
]
ASF GitHub Bot commented on FELIX-6030:
---
Github user asfgit closed the pull request at:
https://github.com/apache/felix/pull/167
> @Header in gogo.jline causing maven-bundle-plugin failure
> -
>
> Key: FELIX-6030
> URL: https://issues.apache.org/jira/browse/FELIX-6030
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> In the https://svn.apache.org/viewvc?view=revision=1849343 revision,
> Gogo JLine bundle {{Activator}} now contains:
> {code}
> @Header(name = Constants.BUNDLE_ACTIVATOR, value = "${@class}")
> {code}
> In Karaf, we "wrap" {{gogo.jline}} in Karaf {{shell.core}}:
> {code}
>
> org.apache.felix
> maven-bundle-plugin
>
>
>
> org.osgi.service.event;resolution:=optional,
> org.apache.karaf.branding;resolution:=optional,
> !org.apache.felix.gogo.jline*,
> !org.apache.sshd.*,
> *
>
>
>
> org.apache.karaf.shell.api.*;version=${project.version},
>
> org.apache.karaf.shell.support.*;version=${project.version},
> org.apache.felix.service.command,
> org.apache.felix.service.threadio
>
>
> org.apache.karaf.service.guard.tools,
> org.apache.karaf.shell.impl.*,
> org.apache.karaf.util,
> org.apache.karaf.util.filesstream,
> org.apache.karaf.util.jaas,
> org.apache.karaf.util.tracker,
> org.apache.felix.utils.properties,
> org.apache.felix.utils.extender,
> org.apache.felix.utils.manifest,
> org.apache.felix.gogo.jline,
> org.apache.felix.gogo.runtime,
> org.apache.felix.gogo.runtime.threadio,
> org.apache.felix.service.command,
> org.apache.felix.service.threadio,
>
>
>
> osgi.service;effective:=active;objectClass=org.apache.karaf.shell.api.console.SessionFactory
>
>
> org.apache.karaf.shell.impl.console.osgi.Activator
>
>
>
> org.apache.karaf.shell.impl.console.standalone.Main
>
>
> true
>
>
> {code}
> Since the introduction of {{@Header}} in Felix Gogo JLine, the build fails
> with:
> {code}
> [ERROR] Bundle
> org.apache.karaf.shell:org.apache.karaf.shell.core:bundle:4.2.3-SNAPSHOT :
> The Bundle-Activator header only supports a single type. The following types
> were found:
> org.apache.karaf.shell.impl.console.osgi.Activator,org.apache.felix.gogo.jline.Activator.
> This usually happens when a macro resolves to multiple types
> [ERROR] Error(s) found in bundle configuration
> {code}
> [~rotty3000] do you know a workaround in the {{maven-bundle-plugin}} about
> that ? If not, do you mind if I remove {{@Header}} from Gogo JLine Activator ?
> Thanks.
> JB
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-5963) Gogo runtime should use named executor threads
[ https://issues.apache.org/jira/browse/FELIX-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748785#comment-16748785 ] ASF GitHub Bot commented on FELIX-5963: --- Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/168 > Gogo runtime should use named executor threads > -- > > Key: FELIX-5963 > URL: https://issues.apache.org/jira/browse/FELIX-5963 > Project: Felix > Issue Type: Improvement > Components: Gogo Runtime >Reporter: Raymond Augé >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: gogo.runtime-1.1.4 > > > Simplifies diagnostics -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (FELIX-5968) Posix 'ls' command ignores .. unless -a is specified
[ https://issues.apache.org/jira/browse/FELIX-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved FELIX-5968. - Resolution: Fixed > Posix 'ls' command ignores .. unless -a is specified > > > Key: FELIX-5968 > URL: https://issues.apache.org/jira/browse/FELIX-5968 > Project: Felix > Issue Type: Bug > Components: Console, Gogo JLine >Reporter: Paul McCulloch >Assignee: Jean-Baptiste Onofré >Priority: Minor > Fix For: gogo.jline-1.1.3 > > > The ls command in org.apache.felix.gogo.jline.Posix applies a filter to all > paths beginning with a period. .. (parent) begins with a period, but isn't a > hidden directory. .(current) should also be listed without -a. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FELIX-5968) Posix 'ls' command ignores .. unless -a is specified
[ https://issues.apache.org/jira/browse/FELIX-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748788#comment-16748788 ] ASF GitHub Bot commented on FELIX-5968: --- Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/158 > Posix 'ls' command ignores .. unless -a is specified > > > Key: FELIX-5968 > URL: https://issues.apache.org/jira/browse/FELIX-5968 > Project: Felix > Issue Type: Bug > Components: Console, Gogo JLine >Reporter: Paul McCulloch >Assignee: Jean-Baptiste Onofré >Priority: Minor > Fix For: gogo.jline-1.1.3 > > > The ls command in org.apache.felix.gogo.jline.Posix applies a filter to all > paths beginning with a period. .. (parent) begins with a period, but isn't a > hidden directory. .(current) should also be listed without -a. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] felix pull request #158: FELIX-5968 Posix 'ls' command ignores .. unless -a ...
Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/158 ---
[jira] [Resolved] (FELIX-5963) Gogo runtime should use named executor threads
[ https://issues.apache.org/jira/browse/FELIX-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved FELIX-5963. - Resolution: Fixed > Gogo runtime should use named executor threads > -- > > Key: FELIX-5963 > URL: https://issues.apache.org/jira/browse/FELIX-5963 > Project: Felix > Issue Type: Improvement > Components: Gogo Runtime >Reporter: Raymond Augé >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: gogo.runtime-1.1.4 > > > Simplifies diagnostics -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FELIX-5968) Posix 'ls' command ignores .. unless -a is specified
[ https://issues.apache.org/jira/browse/FELIX-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated FELIX-5968: Fix Version/s: gogo.jline-1.1.3 > Posix 'ls' command ignores .. unless -a is specified > > > Key: FELIX-5968 > URL: https://issues.apache.org/jira/browse/FELIX-5968 > Project: Felix > Issue Type: Bug > Components: Console, Gogo JLine >Reporter: Paul McCulloch >Assignee: Jean-Baptiste Onofré >Priority: Minor > Fix For: gogo.jline-1.1.3 > > > The ls command in org.apache.felix.gogo.jline.Posix applies a filter to all > paths beginning with a period. .. (parent) begins with a period, but isn't a > hidden directory. .(current) should also be listed without -a. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] felix pull request #168: [FELIX-5963] Use named ExecutorService
Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/168 ---
[jira] [Commented] (FELIX-5963) Gogo runtime should use named executor threads
[ https://issues.apache.org/jira/browse/FELIX-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748767#comment-16748767 ] ASF GitHub Bot commented on FELIX-5963: --- GitHub user jbonofre opened a pull request: https://github.com/apache/felix/pull/168 [FELIX-5963] Use named ExecutorService You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/felix FELIX-5963 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/felix/pull/168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #168 commit 9cabff641bd7cea4b606d0ee3251cd44ba8e289c Author: Jean-Baptiste Onofré Date: 2019-01-22T14:20:25Z [FELIX-5963] Use named ExecutorService > Gogo runtime should use named executor threads > -- > > Key: FELIX-5963 > URL: https://issues.apache.org/jira/browse/FELIX-5963 > Project: Felix > Issue Type: Improvement > Components: Gogo Runtime >Reporter: Raymond Augé >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: gogo.runtime-1.1.4 > > > Simplifies diagnostics -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] felix pull request #168: [FELIX-5963] Use named ExecutorService
GitHub user jbonofre opened a pull request: https://github.com/apache/felix/pull/168 [FELIX-5963] Use named ExecutorService You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/felix FELIX-5963 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/felix/pull/168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #168 commit 9cabff641bd7cea4b606d0ee3251cd44ba8e289c Author: Jean-Baptiste Onofré Date: 2019-01-22T14:20:25Z [FELIX-5963] Use named ExecutorService ---
[jira] [Assigned] (FELIX-5963) Gogo runtime should use named executor threads
[ https://issues.apache.org/jira/browse/FELIX-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned FELIX-5963: --- Assignee: Jean-Baptiste Onofré > Gogo runtime should use named executor threads > -- > > Key: FELIX-5963 > URL: https://issues.apache.org/jira/browse/FELIX-5963 > Project: Felix > Issue Type: Improvement > Components: Gogo Runtime >Reporter: Raymond Augé >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: gogo.runtime-1.1.4 > > > Simplifies diagnostics -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FELIX-6030) @Header in gogo.jline causing maven-bundle-plugin failure
[
https://issues.apache.org/jira/browse/FELIX-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748764#comment-16748764
]
ASF GitHub Bot commented on FELIX-6030:
---
GitHub user jbonofre opened a pull request:
https://github.com/apache/felix/pull/167
[FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in
Apache Karaf shell
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/felix FELIX-6030
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #167
commit b8468b585a4d3b806cd0f2305b27c92b10b00473
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:16:14Z
[FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in
Apache Karaf shell
> @Header in gogo.jline causing maven-bundle-plugin failure
> -
>
> Key: FELIX-6030
> URL: https://issues.apache.org/jira/browse/FELIX-6030
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> In the https://svn.apache.org/viewvc?view=revision=1849343 revision,
> Gogo JLine bundle {{Activator}} now contains:
> {code}
> @Header(name = Constants.BUNDLE_ACTIVATOR, value = "${@class}")
> {code}
> In Karaf, we "wrap" {{gogo.jline}} in Karaf {{shell.core}}:
> {code}
>
> org.apache.felix
> maven-bundle-plugin
>
>
>
> org.osgi.service.event;resolution:=optional,
> org.apache.karaf.branding;resolution:=optional,
> !org.apache.felix.gogo.jline*,
> !org.apache.sshd.*,
> *
>
>
>
> org.apache.karaf.shell.api.*;version=${project.version},
>
> org.apache.karaf.shell.support.*;version=${project.version},
> org.apache.felix.service.command,
> org.apache.felix.service.threadio
>
>
> org.apache.karaf.service.guard.tools,
> org.apache.karaf.shell.impl.*,
> org.apache.karaf.util,
> org.apache.karaf.util.filesstream,
> org.apache.karaf.util.jaas,
> org.apache.karaf.util.tracker,
> org.apache.felix.utils.properties,
> org.apache.felix.utils.extender,
> org.apache.felix.utils.manifest,
> org.apache.felix.gogo.jline,
> org.apache.felix.gogo.runtime,
> org.apache.felix.gogo.runtime.threadio,
> org.apache.felix.service.command,
> org.apache.felix.service.threadio,
>
>
>
> osgi.service;effective:=active;objectClass=org.apache.karaf.shell.api.console.SessionFactory
>
>
> org.apache.karaf.shell.impl.console.osgi.Activator
>
>
>
> org.apache.karaf.shell.impl.console.standalone.Main
>
>
> true
>
>
> {code}
> Since the introduction of {{@Header}} in Felix Gogo JLine, the build fails
> with:
> {code}
> [ERROR] Bundle
> org.apache.karaf.shell:org.apache.karaf.shell.core:bundle:4.2.3-SNAPSHOT :
> The Bundle-Activator header only supports a single type. The following types
> were found:
> org.apache.karaf.shell.impl.console.osgi.Activator,org.apache.felix.gogo.jline.Activator.
> This usually happens when a macro resolves to multiple types
> [ERROR] Error(s) found in bundle configuration
> {code}
> [~rotty3000] do you know a workaround in the {{maven-bundle-plugin}} about
> that ? If not, do you mind if I remove {{@Header}} from Gogo JLine Activator ?
> Thanks.
> JB
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] felix pull request #167: [FELIX-6030] Remove @Header on Gogo JLine Activator...
GitHub user jbonofre opened a pull request: https://github.com/apache/felix/pull/167 [FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in Apache Karaf shell You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/felix FELIX-6030 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/felix/pull/167.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #167 commit b8468b585a4d3b806cd0f2305b27c92b10b00473 Author: Jean-Baptiste Onofré Date: 2019-01-22T14:16:14Z [FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in Apache Karaf shell ---
[GitHub] felix pull request #166: [FELIX-6033] Align Felix Gogo wc posix action compl...
GitHub user jbonofre opened a pull request: https://github.com/apache/felix/pull/166 [FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix one You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/felix FELIX-6033 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/felix/pull/166.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #166 commit 2ff4867362fb0cc7bb3783a0c8b28510b2feb58a Author: Jean-Baptiste Onofré Date: 2019-01-22T14:06:10Z [FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix one ---
[jira] [Commented] (FELIX-6033) wc command should be compliant with posix ones
[
https://issues.apache.org/jira/browse/FELIX-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748752#comment-16748752
]
ASF GitHub Bot commented on FELIX-6033:
---
GitHub user jbonofre opened a pull request:
https://github.com/apache/felix/pull/166
[FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix
one
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/felix FELIX-6033
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
commit 2ff4867362fb0cc7bb3783a0c8b28510b2feb58a
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:06:10Z
[FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix
one
> wc command should be compliant with posix ones
> --
>
> Key: FELIX-6033
> URL: https://issues.apache.org/jira/browse/FELIX-6033
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.0, gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> The Posix {{wc}} command formatting is not fully correct. For instance, a
> simple:
> {code}
> echo "foo\nbar"|wc -l
> {code}
> displays:
> {code}
>2 2
> {code}
> So the output formatting is not correct (result is displayed twice) and
> {{wc}} can't be easily used in scripting.
> To be compliant with standard Posix {{wc}} command, the output should be:
> {code}
> 2
> {code}
> I'm adding tests and fixes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FELIX-5968) Posix 'ls' command ignores .. unless -a is specified
[ https://issues.apache.org/jira/browse/FELIX-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned FELIX-5968: --- Assignee: Jean-Baptiste Onofré > Posix 'ls' command ignores .. unless -a is specified > > > Key: FELIX-5968 > URL: https://issues.apache.org/jira/browse/FELIX-5968 > Project: Felix > Issue Type: Bug > Components: Console, Gogo JLine >Reporter: Paul McCulloch >Assignee: Jean-Baptiste Onofré >Priority: Minor > > The ls command in org.apache.felix.gogo.jline.Posix applies a filter to all > paths beginning with a period. .. (parent) begins with a period, but isn't a > hidden directory. .(current) should also be listed without -a. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[BundleRepository] Anyone knows the reason findProviders() is merging attributes from Identity and Content capabilities?
Hello devs,
I'm integrating BundleRepository with a ResolveContext and I found a
problem while trying to get some capabilities from repository when using
R5 spec findProviders().
I have discovered that findProviders's result is not returning a Content
capability only one Identity capability containing attributes from both
Identity and Content.
I did a debug and found that BR's SpecXMLPullParser class is the
responsible for merging those attributes into one identity capability.
Anyone knows what is the reason for that ? this behavior is not
following the spec, right ?
thanks,
Cristiano
Below is some methods taken from SpecXMLPullParser that shows the
current behavior:
private static Capability parseCapability(XmlPullParser reader,
ResourceImpl resource, URI baseUri) throws Exception
{
String namespace = reader.getAttributeValue(null, NAMESPACE);
if (IdentityNamespace.IDENTITY_NAMESPACE.equals(namespace))
{
*parseIdentityNamespace(reader, resource);**
** return null;*
}
if (ContentNamespace.CONTENT_NAMESPACE.equals(namespace))
{
if (resource.getURI() == null)
{
* parseContentNamespace(reader, resource, baseUri);**
** return null;*
}
// if the URI is already set, this is a second
osgi.content capability.
// The first content capability, which is the main one, is
stored in the Resource.
// Subsequent content capabilities are stored are ordinary
capabilities.
}
private static Resource parseResource(XmlPullParser reader, URI
baseUri) throws Exception
{
ResourceImpl resource = new ResourceImpl();
try
{
int event;
while ((event = reader.nextTag()) == XmlPullParser.START_TAG)
{
String element = reader.getName();
if (CAPABILITY.equals(element))
{
Capability capability = parseCapability(reader,
resource, baseUri);
*if (capability != null)*
resource.addCapability(capability);
}
else if (REQUIREMENT.equals(element))
{
Requirement requirement = parseRequirement(reader);
if (requirement != null) {
resource.addRequire(requirement);
}
}
else
{
PullParser.ignoreTag(reader);
}
}
PullParser.sanityCheckEndElement(reader, event, RESOURCE);
return resource;
}
catch (Exception e)
{
throw new Exception("Error while parsing resource " +
resource.getId() + " at line " + reader.getLineNumber() + " and column
" + reader.getColumnNumber(), e);
}
}
private static void parseIdentityNamespace(XmlPullParser reader,
ResourceImpl resource) throws Exception
{
Map attributes = new HashMap();
parseAttributesDirectives(reader, attributes, new
HashMap(), CAPABILITY);
// TODO need to cater for the singleton directive...
for (Map.Entry entry : attributes.entrySet())
{
*if (IdentityNamespace.IDENTITY_NAMESPACE.equals(entry.getKey()))**
** resource.put(Resource.SYMBOLIC_NAME, entry.getValue());*
else
resource.put(entry.getKey(), entry.getValue());
}
}
