[GitHub] [felix-dev] amitjoy commented on pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
amitjoy commented on PR #172: URL: https://github.com/apache/felix-dev/pull/172#issuecomment-1256549717 Thanks @tjwatson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] tjwatson merged pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
tjwatson merged PR #172: URL: https://github.com/apache/felix-dev/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] tjwatson commented on pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
tjwatson commented on PR #172: URL: https://github.com/apache/felix-dev/pull/172#issuecomment-1256297819 > If you want, you can also cross-check it from your end. Just to be on the safe side. The fix looks safe enough, I just wanted to verify they ran on your end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] amitjoy commented on pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
amitjoy commented on PR #172: URL: https://github.com/apache/felix-dev/pull/172#issuecomment-1256259643 If you want, you can also cross-check it from your end. Just to be on the safe side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] amitjoy commented on pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
amitjoy commented on PR #172: URL: https://github.com/apache/felix-dev/pull/172#issuecomment-1256258253 I built it locally and all the tests ran successfully -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[RESULT][VOTE] Release Apache Felix Configurator 1.0.16
Hi all, We received 4 binding +1 votes and no other votes. This release has been successful. I've promoted the artifacts. Best regards, David On Tue, 20 Sept 2022 at 09:46, wrote: > Hi all, > > I'd like to call the vote on the Apache Felix Configurator 1.0.16 > > We solved the following issue: > https://issues.apache.org/jira/browse/FELIX-6554 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1441 > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1441 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > This vote will be open for 72 hours. > > Kind regards, > > David >
[jira] [Closed] (FELIX-6554) Exception while starting Felix Configurator
[
https://issues.apache.org/jira/browse/FELIX-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed FELIX-6554.
-
> Exception while starting Felix Configurator
> ---
>
> Key: FELIX-6554
> URL: https://issues.apache.org/jira/browse/FELIX-6554
> Project: Felix
> Issue Type: Bug
> Components: Configurator
>Affects Versions: configurator-1.0.14
>Reporter: Amit Mondal
>Assignee: Carsten Ziegeler
>Priority: Minor
> Labels: pull-request-available
> Fix For: configurator-1.0.16
>
>
> On startup when the set of current bundles with configurations is missing a
> bundle that was there on last shutdown, the configurator processes this
> bundle as a removed bundle but then might run into below concurrent
> modification exception:
> {code:java}
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextNode(HashMap.java:1469)
> at java.util.HashMap$KeyIterator.next(HashMap.java:1493)
> at
> org.apache.felix.configurator.impl.Configurator.start(Configurator.java:291)
> at
> org.apache.felix.configurator.impl.ServicesListener.notifyChange(ServicesListener.java:117)
> at
> org.apache.felix.configurator.impl.ServicesListener$1.addingService(ServicesListener.java:73)
> at
> org.apache.felix.configurator.impl.ServicesListener$1.addingService(ServicesListener.java:65)
> at
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:944)
> at
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:872)
> at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
> at
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
> at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:322)
> at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:265)
> at
> org.apache.felix.configurator.impl.ServicesListener.(ServicesListener.java:93)
> at org.apache.felix.configurator.impl.Activator.start(Activator.java:36)
> at
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:849)
> at org.apache.felix.framework.Felix.activateBundle(Felix.java:2429){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [VOTE] Release Apache Felix Configurator 1.0.16
+1 David On Tue, 20 Sept 2022 at 12:47, Raymond Augé wrote: > +1 > > On Tue, Sep 20, 2022 at 7:37 AM Carsten Ziegeler > wrote: > > > +1 > > > > Carsten > > > > Am 20.09.2022 um 10:46 schrieb dav...@apache.org: > > > Hi all, > > > > > > I'd like to call the vote on the Apache Felix Configurator 1.0.16 > > > > > > We solved the following issue: > > > https://issues.apache.org/jira/browse/FELIX-6554 > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachefelix-1441 > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > > > > > Usage: > > > sh check_staged_release.sh 1441 /tmp/felix-staging > > > > > > Please vote to approve this release: > > > > > > [ ] +1 Approve the release > > > [ ] -1 Veto the release (please provide specific comments) > > > > > > This vote will be open for 72 hours. > > > > > > Kind regards, > > > > > > David > > > > > > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > > > -- > *Raymond Augé* (@rotty3000) > Senior Software Architect *Liferay, Inc.* (@Liferay) > OSGi Fellow, Java Champion >
[GitHub] [felix-dev] amitjoy commented on a diff in pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
amitjoy commented on code in PR #172:
URL: https://github.com/apache/felix-dev/pull/172#discussion_r978659010
##
scr/src/main/java/org/apache/felix/scr/impl/runtime/ServiceComponentRuntimeImpl.java:
##
@@ -117,6 +117,10 @@ public Collection
getComponentConfigurationDTOs(Compo
try
{
ComponentHolder holder = getHolderFromDescription( description);
+// the holder can also be null if the associated component is
deregistered
Review Comment:
Thanks a lot for the detailed feedback I have updated the MR with the
required changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [felix-atomos] tjwatson closed issue #69: atomos-maven-plugin fails when building on Windows
tjwatson closed issue #69: atomos-maven-plugin fails when building on Windows URL: https://github.com/apache/felix-atomos/issues/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-atomos] tjwatson merged pull request #70: add handling for running build on Windows
tjwatson merged PR #70: URL: https://github.com/apache/felix-atomos/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] tjwatson commented on a diff in pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
tjwatson commented on code in PR #172:
URL: https://github.com/apache/felix-dev/pull/172#discussion_r978575369
##
scr/src/main/java/org/apache/felix/scr/impl/runtime/ServiceComponentRuntimeImpl.java:
##
@@ -117,6 +117,10 @@ public Collection
getComponentConfigurationDTOs(Compo
try
{
ComponentHolder holder = getHolderFromDescription( description);
+// the holder can also be null if the associated component is
deregistered
Review Comment:
If null is allowed to be returned here then I think we need null checks in
all 4 locations it is called:
`disableComponent(ComponentDescriptionDTO)`
`enableComponent(ComponentDescriptionDTO)`
`getComponentConfigurationDTOs(ComponentDescriptionDTO)`
`isComponentEnabled(ComponentDescriptionDTO)`
Also, looking at `getHolderFromDescription(ComponentDescriptionDTO
description)` I think it has an issue where it could get called on an
uninstalled bundle in which case `Bundle b = context.getBundle(bundleId);` will
result in a `null` value in `b` causing an NPE also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Mondal updated FELIX-6565:
---
Labels: (was: easyfix)
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608675#comment-17608675
]
Amit Mondal commented on FELIX-6565:
[~cziegeler] [~ghenzler] Could you kindly have a look into it?
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608674#comment-17608674
]
Amit Mondal commented on FELIX-6565:
I think, it would be better off with the following two solutions:
# Use OSGi Condition Service to conditionally enable these components when the
OSGi HTTP packages are wired
# Or separate _*org.apache.felix.hc.core.impl.servlet*_ and
_*org.apache.felix.hc.core.impl.filter*_ packages in a separate
_*org.apache.felix.hc.core.http*_ bundle
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608672#comment-17608672
]
Amit Mondal commented on FELIX-6565:
Since _*ServiceUnavailableFilter*_ and _*HealthCheckExecutorServlet*_ use
factory PIDs, we cannot simply disable them (by setting {*}_enabled =
false_{*}) ** and enable them when the OSGi HTTP packages are wired.
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608672#comment-17608672
]
Amit Mondal edited comment on FELIX-6565 at 9/23/22 10:05 AM:
--
Since _*ServiceUnavailableFilter*_ and _*HealthCheckExecutorServlet*_ use
factory PIDs, we cannot simply disable them (by setting {*}_enabled =
false_{*}) and enable them when the OSGi HTTP packages are wired.
was (Author: amitmondal):
Since _*ServiceUnavailableFilter*_ and _*HealthCheckExecutorServlet*_ use
factory PIDs, we cannot simply disable them (by setting {*}_enabled =
false_{*}) ** and enable them when the OSGi HTTP packages are wired.
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608667#comment-17608667
]
Amit Mondal commented on FELIX-6565:
I think we can make use of OSGi Conditions to ensure that the components are
enabled if the aforementioned packages are wired but it requires OSGi R8 core
dependency.
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608660#comment-17608660
]
Amit Mondal commented on FELIX-6565:
It seems it would be difficult to implement a strategy to conditionally
activate the components that depend on _*org.osgi.service.http*_ and
_*org.osgi.service.http.context.*_ My idea was to make the components
mandatorily depend on two PIDs one of which would only be created if the
aforementioned OSGi HTTP packages are wired to the HealthCheck core bundle.
Since, the components use metatype, we cannot provide a different PID for the
components to depend on.
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608655#comment-17608655
]
Amit Mondal commented on FELIX-6565:
Just noticed, _*ServiceUnavailableFilter*_ also references
_*org.osgi.service.http.context*_
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608651#comment-17608651
]
Amit Mondal commented on FELIX-6565:
[~ghenzler] What do you think about it?
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Mondal updated FELIX-6565:
---
Description:
Currently, the Felix HealthCheck core bundle mandatorily imports
org.osgi.service.http package which is used by
{_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP at
all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
available in the runtime. Hence, the health checks don't work as it mandatorily
requires _*org.osgi.service.http*_ package dependency. Since,
_*HealthCheckExecutorServlet*_ is not a core component for the health checks,
we can consider the following options:
# Provide a separate bundle with HTTP dependency (invasive approach)
# Make _*org.osgi.service.http*_ an optional package for HealthCheck core and
conditionally enable _*HealthCheckExecutorServlet*_ component if
_*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
approach we did for Quartz to check the availability of Quartz in runtime)
was:
Currently, the Felix HealthCheck core bundle mandatorily imports
org.osgi.service.http package which is used by
{_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP at
all, hence, neither _*javax.servlet*_ nor _** *org.osgi.service.http*_ is
available in the runtime. Hence, the health checks don't work as it mandatorily
requires _*org.osgi.service.http*_ package dependency. Since,
_*HealthCheckExecutorServlet*_ is not a core component for the health checks,
we can consider the following options:
# Provide a separate bundle with HTTP dependency (invasive approach)
# Make _*org.osgi.service.http*_ an optional package for HealthCheck core and
conditionally enable _*HealthCheckExecutorServlet*_ component if
_*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
approach we did for Quartz to check the availability of Quartz in runtime)
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Mondal updated FELIX-6565:
---
Summary: Make OSGi HTTP Package dependency optional in HealthCheck core
bundle (was: Make HTTP Servlet dependency optional in HealthCheck core bundle)
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> -
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _** *org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (FELIX-6565) Make HTTP Servlet dependency optional in HealthCheck core bundle
[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Mondal updated FELIX-6565:
---
Description:
Currently, the Felix HealthCheck core bundle mandatorily imports
org.osgi.service.http package which is used by
{_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP at
all, hence, neither _*javax.servlet*_ nor _** *org.osgi.service.http*_ is
available in the runtime. Hence, the health checks don't work as it mandatorily
requires _*org.osgi.service.http*_ package dependency. Since,
_*HealthCheckExecutorServlet*_ is not a core component for the health checks,
we can consider the following options:
# Provide a separate bundle with HTTP dependency (invasive approach)
# Make _*org.osgi.service.http*_ an optional package for HealthCheck core and
conditionally enable _*HealthCheckExecutorServlet*_ component if
_*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
approach we did for Quartz to check the availability of Quartz in runtime)
was:
Currently, the Felix HealthCheck core bundle mandatorily imports
_*javax.servlet*_ package which is used by {_}*HealthCheckExecutorServlet*{_}.
In our current system, we don't use HTTP at all, hence, _*javax.servlet*_ is
not available in the runtime. Hence, the health checks don't work as it
mandatorily requires _*javax.servlet*_ package dependency. Since,
_*HealthCheckExecutorServlet*_ is not a core component for the health checks,
we can consider the following options:
# Provide a separate bundle with HTTP dependency (invasive approach)
# Make _*javax.servlet*_ an optional package for HealthCheck core and
conditionally enable _*HealthCheckExecutorServlet*_ component if
_*javax.servlet*_ is wired to the HealthCheck core bundle (similar approach we
did for Quartz to check the availability of Quartz in runtime)
> Make HTTP Servlet dependency optional in HealthCheck core bundle
>
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
>Reporter: Amit Mondal
>Priority: Minor
> Labels: easyfix
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _** *org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (FELIX-6565) Make HTTP Servlet dependency optional in HealthCheck core bundle
Amit Mondal created FELIX-6565:
--
Summary: Make HTTP Servlet dependency optional in HealthCheck core
bundle
Key: FELIX-6565
URL: https://issues.apache.org/jira/browse/FELIX-6565
Project: Felix
Issue Type: Improvement
Components: Health Checks
Reporter: Amit Mondal
Currently, the Felix HealthCheck core bundle mandatorily imports
_*javax.servlet*_ package which is used by {_}*HealthCheckExecutorServlet*{_}.
In our current system, we don't use HTTP at all, hence, _*javax.servlet*_ is
not available in the runtime. Hence, the health checks don't work as it
mandatorily requires _*javax.servlet*_ package dependency. Since,
_*HealthCheckExecutorServlet*_ is not a core component for the health checks,
we can consider the following options:
# Provide a separate bundle with HTTP dependency (invasive approach)
# Make _*javax.servlet*_ an optional package for HealthCheck core and
conditionally enable _*HealthCheckExecutorServlet*_ component if
_*javax.servlet*_ is wired to the HealthCheck core bundle (similar approach we
did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [felix-dev] amitjoy commented on pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR
amitjoy commented on PR #172: URL: https://github.com/apache/felix-dev/pull/172#issuecomment-1255952462 @tjwatson Do you have any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
