date:20170408

Re: git commit: [flex-asjs] [refs/heads/develop] - CORS security. Allow auth credentials to be passed when using cross site calls. This is required as well as setting the Access-Control-Allow-Origin h

2017-04-08 Thread Alex Harui



On 4/8/17, 9:59 PM, "Greg Dove"  wrote:

>Just a general question about this type of thing:
>
>Because this is JS-only, does GCC eliminate it as deadcode in a release
>version if the method is never used? I would expect that, but I have not
>checked that yet... if it does then perhaps the PAYG concern might be moot
>(love that word!)

AFAIK, public APIs have @export and are kept around.  Which will be a good
thing in multi-module apps some day.


Thinking about this some more, it should probably be a bead and then baked
into a more swiss-army-knife version of HTTPService which would be a good
default for the Express package.

-Alex

>
>On Sun, Apr 9, 2017 at 4:48 PM, Alex Harui  wrote:
>
>> IMO, with PAYG, this would go in an extension of HTTPService.  Not all
>> apps will need CORS.
>>
>> Thanks,
>> -Alex
>>
>> On 4/8/17, 8:26 PM, "jmcl...@apache.org"  wrote:
>>
>> >Repository: flex-asjs
>> >Updated Branches:
>> >  refs/heads/develop 11ef21aae -> 326d69791
>> >
>> >
>> >CORS security. Allow auth credentials to be passed when using cross
>>site
>> >calls. This is required as well as setting the
>> >Access-Control-Allow-Origin header on the server.
>> >
>> >
>> >Project:
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fgit-wip-us
>> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%
>> 7C01%7C%7C58994717190
>> >044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C0%7C6362730
>> >52005920291=eQwxowk79ikXeDxbqXV3OeVrXUzTXN
>> fFR0eKzhU8wiw%3D=
>> >0
>> >Commit:
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fgit-wip-us
>> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%
>> 2F326d6979=02%7C01%7C%
>> >7C58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%
>> >7C0%7C636273052005930299=f8udpkPpLcL1ivRV3LDW0kJARc8QnL
>> hBDHVFGgCko7M
>> >%3D=0
>> >Tree:
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fgit-wip-us
>> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F326d6979&
>> data=02%7C01%7C%7C
>> >58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C
>> >0%7C636273052005930299=t6MMifwasbm2bgCuzsVN2q4%
>> 2BCYcB2uB8o7O%2B%2BJu
>> >yZ5w%3D=0
>> >Diff:
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fgit-wip-us
>> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F326d6979&
>> data=02%7C01%7C%7C
>> >58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C
>> >0%7C636273052005930299=gJDrCW4YbwaorNFSXVCVjLyq3lwTC6
>> 7VhCRLEtYlcD0%3
>> >D=0
>> >
>> >Branch: refs/heads/develop
>> >Commit: 326d69791b37cc2aaac546bcfcd3a51e88716f2f
>> >Parents: 11ef21a
>> >Author: Justin Mclean 
>> >Authored: Sun Apr 9 13:26:30 2017 +1000
>> >Committer: Justin Mclean 
>> >Committed: Sun Apr 9 13:26:30 2017 +1000
>> >
>> >--
>> > .../src/main/flex/org/apache/flex/net/HTTPService.as   | 13
>> +
>> > 1 file changed, 13 insertions(+)
>> >--
>> >
>> >
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fgit-wip-us
>> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F326d6979%
>> 2Fframeworks%2Fpro
>> >jects%2FNetwork%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%
>> 2Fnet%2FHTTPServ
>> >ice.as=02%7C01%7C%7C58994717190044f003a908d47ef8
>> 3ba7%7Cfa7b1b5a7b3443
>> >8794aed2c178decee1%7C0%7C0%7C636273052005930299=
>> TcDMCOEVbLKxedpsnACV
>> >OmZon89YgUkvGxOtd%2F3Qky8%3D=0
>> >--
>> >diff --git
>> >a/frameworks/projects/Network/src/main/flex/org/
>> apache/flex/net/HTTPServic
>> >e.as
>> >b/frameworks/projects/Network/src/main/flex/org/
>> apache/flex/net/HTTPServic
>> >e.as
>> >index b939751..3a9968c 100644
>> >---
>> >a/frameworks/projects/Network/src/main/flex/org/
>> apache/flex/net/HTTPServic
>> >e.as
>> >+++
>> >b/frameworks/projects/Network/src/main/flex/org/
>> apache/flex/net/HTTPServic
>> >e.as
>> >@@ -505,6 +505,18 @@ package org.apache.flex.net
>> >   return null;
>> >   }
>> >
>> >+/**
>> >+ *  Allows Javascript cross-site Access-Control requests to be
>> >made
>> >+ *  using credentials such as cookies or authorization headers
>> >+ *
>> >+ *  @productversion FlexJS 0.8
>> >+ */
>> >+COMPILE::JS
>> >+public function set withCredentials(value:Boolean):void {
>> >+var element:XMLHttpRequest = this.element as
>>XMLHttpRequest;
>> >+element.withCredentials = value;
>> >+}
>> >+
>> > COMPILE::SWF
>> > private var urlLoader:flash.net.URLLoader;
>> >
>> >@@ -606,6 +618,7 @@ package org.apache.flex.net
>> > }
>> > }
>> >
>> >+
>> > if (_method !==

Re: [FlexJS] internal classes based on other classes

2017-04-08 Thread Harbs


> On Apr 9, 2017, at 12:46 AM, Alex Harui  wrote:
> 
> I'll look into it.  I thought I'd fixed that already.  I assume
> BackgroundManager isn't one of the goog.requires in FactoryComposer.js?

I don’t remember, and I already modified my state of TLF. If you need me to 
check, I can try and revert.

> And I assume you cleaned out old JS files?

Yes.

> -Alex
> 
> On 4/8/17, 9:15 PM, "Harbs"  wrote:
> 
>> The current state of Falcon seems to be okay so far, but I just bumped
>> into an interesting problem.
>> 
>> In TLF, there’s a class: FactoryComposer. FactoryComposer has an internal
>> class called FactoryBackgroundManager which subclasses
>> org.apache.flex.textLayout.elements.BackgroundManager.
>> 
>> Because FactoryBackgroundManager is an internal class, the normal
>> dependency chain is not built and I’m getting an error on the following
>> line:
>> goog.inherits(org.apache.flex.textLayout.compose.FactoryComposer.FactoryBa
>> ckgroundManager, org.apache.flex.textLayout.elements.BackgroundManager);
>> 
>> This is because this code is running before  BackgroundManager is loaded.
>> 
>> The work-around is to move the internal class out into its own file, but
>> I think this is something which should work.
>> 
>> Harbs
>

Re: [FlexJS] non-primitive static consts

2017-04-08 Thread Harbs


> On Apr 9, 2017, at 12:50 AM, Alex Harui  wrote:
> 
> I assume this is only a problem for folks using -remove-circulars?
> 
I have not tested with remove-circulars truned off, so very possibly, yes.

> I assume what is broken is the order of loaded files instead of something
> else?

Correct. With the current status of remove-circulars, the only reliable way to 
deal with static values which are non-primitive are to use getters instead of 
static initializations.

> Thanks,
> -Alex
> 
> On 4/8/17, 9:46 PM, "Harbs"  wrote:
> 
>> Related issue:
>> 
>> The recent changes to Falcon has broken UIDUtil which has the following:
>> private static const UIDBuffer:BinaryData = new BinaryData();
>> 
>> Unless something changes, this needs to be changed to a getter.
>> 
>>> On Apr 8, 2017, at 11:40 PM, Harbs  wrote:
>>> 
>>> Currently initializing non-primitive static types are a big no-no in
>>> FlexJS. It causes all kinds of javascript runtime errors due to
>>> non-defined types depending on the order of loaded files.
>>> 
>>> I think this is an area which needs some improvement. The improvement
>>> can take two variations:
>>> 
>>> 1. We can simply disallow initializing non-primitive types at compile
>>> time, so at least there will be a compile-time warning of potential
>>> problems.
>>> 2. We can somehow allow these initializations.
>>> 
>>> I’m not sure if #2 is possible, but it would definitely be preferred to
>>> #1 if it is.
>>> 
>>> Thoughts?
>>> 
>>> Harbs
>> 
>

Re: git commit: [flex-asjs] [refs/heads/develop] - CORS security. Allow auth credentials to be passed when using cross site calls. This is required as well as setting the Access-Control-Allow-Origin h

2017-04-08 Thread Greg Dove

Just a general question about this type of thing:

Because this is JS-only, does GCC eliminate it as deadcode in a release
version if the method is never used? I would expect that, but I have not
checked that yet... if it does then perhaps the PAYG concern might be moot
(love that word!)

On Sun, Apr 9, 2017 at 4:48 PM, Alex Harui  wrote:

> IMO, with PAYG, this would go in an extension of HTTPService.  Not all
> apps will need CORS.
>
> Thanks,
> -Alex
>
> On 4/8/17, 8:26 PM, "jmcl...@apache.org"  wrote:
>
> >Repository: flex-asjs
> >Updated Branches:
> >  refs/heads/develop 11ef21aae -> 326d69791
> >
> >
> >CORS security. Allow auth credentials to be passed when using cross site
> >calls. This is required as well as setting the
> >Access-Control-Allow-Origin header on the server.
> >
> >
> >Project:
> >https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fgit-wip-us
> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%
> 7C01%7C%7C58994717190
> >044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6362730
> >52005920291=eQwxowk79ikXeDxbqXV3OeVrXUzTXN
> fFR0eKzhU8wiw%3D=
> >0
> >Commit:
> >https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fgit-wip-us
> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%
> 2F326d6979=02%7C01%7C%
> >7C58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%
> >7C0%7C636273052005930299=f8udpkPpLcL1ivRV3LDW0kJARc8QnL
> hBDHVFGgCko7M
> >%3D=0
> >Tree:
> >https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fgit-wip-us
> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F326d6979&
> data=02%7C01%7C%7C
> >58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C
> >0%7C636273052005930299=t6MMifwasbm2bgCuzsVN2q4%
> 2BCYcB2uB8o7O%2B%2BJu
> >yZ5w%3D=0
> >Diff:
> >https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fgit-wip-us
> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F326d6979&
> data=02%7C01%7C%7C
> >58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C
> >0%7C636273052005930299=gJDrCW4YbwaorNFSXVCVjLyq3lwTC6
> 7VhCRLEtYlcD0%3
> >D=0
> >
> >Branch: refs/heads/develop
> >Commit: 326d69791b37cc2aaac546bcfcd3a51e88716f2f
> >Parents: 11ef21a
> >Author: Justin Mclean 
> >Authored: Sun Apr 9 13:26:30 2017 +1000
> >Committer: Justin Mclean 
> >Committed: Sun Apr 9 13:26:30 2017 +1000
> >
> >--
> > .../src/main/flex/org/apache/flex/net/HTTPService.as   | 13
> +
> > 1 file changed, 13 insertions(+)
> >--
> >
> >
> >https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fgit-wip-us
> >.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F326d6979%
> 2Fframeworks%2Fpro
> >jects%2FNetwork%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%
> 2Fnet%2FHTTPServ
> >ice.as=02%7C01%7C%7C58994717190044f003a908d47ef8
> 3ba7%7Cfa7b1b5a7b3443
> >8794aed2c178decee1%7C0%7C0%7C636273052005930299=
> TcDMCOEVbLKxedpsnACV
> >OmZon89YgUkvGxOtd%2F3Qky8%3D=0
> >--
> >diff --git
> >a/frameworks/projects/Network/src/main/flex/org/
> apache/flex/net/HTTPServic
> >e.as
> >b/frameworks/projects/Network/src/main/flex/org/
> apache/flex/net/HTTPServic
> >e.as
> >index b939751..3a9968c 100644
> >---
> >a/frameworks/projects/Network/src/main/flex/org/
> apache/flex/net/HTTPServic
> >e.as
> >+++
> >b/frameworks/projects/Network/src/main/flex/org/
> apache/flex/net/HTTPServic
> >e.as
> >@@ -505,6 +505,18 @@ package org.apache.flex.net
> >   return null;
> >   }
> >
> >+/**
> >+ *  Allows Javascript cross-site Access-Control requests to be
> >made
> >+ *  using credentials such as cookies or authorization headers
> >+ *
> >+ *  @productversion FlexJS 0.8
> >+ */
> >+COMPILE::JS
> >+public function set withCredentials(value:Boolean):void {
> >+var element:XMLHttpRequest = this.element as XMLHttpRequest;
> >+element.withCredentials = value;
> >+}
> >+
> > COMPILE::SWF
> > private var urlLoader:flash.net.URLLoader;
> >
> >@@ -606,6 +618,7 @@ package org.apache.flex.net
> > }
> > }
> >
> >+
> > if (_method !== HTTPConstants.GET &&
> > !sawContentType && contentData) {
> > element.setRequestHeader(
> >
>
>

Re: [FlexJS] non-primitive static consts

2017-04-08 Thread Alex Harui

I assume this is only a problem for folks using -remove-circulars?

I assume what is broken is the order of loaded files instead of something
else?

Thanks,
-Alex

On 4/8/17, 9:46 PM, "Harbs"  wrote:

>Related issue:
>
>The recent changes to Falcon has broken UIDUtil which has the following:
>private static const UIDBuffer:BinaryData = new BinaryData();
>
>Unless something changes, this needs to be changed to a getter.
>
>> On Apr 8, 2017, at 11:40 PM, Harbs  wrote:
>> 
>> Currently initializing non-primitive static types are a big no-no in
>>FlexJS. It causes all kinds of javascript runtime errors due to
>>non-defined types depending on the order of loaded files.
>> 
>> I think this is an area which needs some improvement. The improvement
>>can take two variations:
>> 
>> 1. We can simply disallow initializing non-primitive types at compile
>>time, so at least there will be a compile-time warning of potential
>>problems.
>> 2. We can somehow allow these initializations.
>> 
>> I’m not sure if #2 is possible, but it would definitely be preferred to
>>#1 if it is.
>> 
>> Thoughts?
>> 
>> Harbs
>

Re: git commit: [flex-asjs] [refs/heads/develop] - CORS security. Allow auth credentials to be passed when using cross site calls. This is required as well as setting the Access-Control-Allow-Origin h

2017-04-08 Thread Alex Harui

IMO, with PAYG, this would go in an extension of HTTPService.  Not all
apps will need CORS.

Thanks,
-Alex

On 4/8/17, 8:26 PM, "jmcl...@apache.org"  wrote:

>Repository: flex-asjs
>Updated Branches:
>  refs/heads/develop 11ef21aae -> 326d69791
>
>
>CORS security. Allow auth credentials to be passed when using cross site
>calls. This is required as well as setting the
>Access-Control-Allow-Origin header on the server.
>
>
>Project: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C58994717190
>044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6362730
>52005920291=eQwxowk79ikXeDxbqXV3OeVrXUzTXNfFR0eKzhU8wiw%3D=
>0
>Commit: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2F326d6979=02%7C01%7C%
>7C58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>7C0%7C636273052005930299=f8udpkPpLcL1ivRV3LDW0kJARc8QnLhBDHVFGgCko7M
>%3D=0
>Tree: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F326d6979=02%7C01%7C%7C
>58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636273052005930299=t6MMifwasbm2bgCuzsVN2q4%2BCYcB2uB8o7O%2B%2BJu
>yZ5w%3D=0
>Diff: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F326d6979=02%7C01%7C%7C
>58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636273052005930299=gJDrCW4YbwaorNFSXVCVjLyq3lwTC67VhCRLEtYlcD0%3
>D=0
>
>Branch: refs/heads/develop
>Commit: 326d69791b37cc2aaac546bcfcd3a51e88716f2f
>Parents: 11ef21a
>Author: Justin Mclean 
>Authored: Sun Apr 9 13:26:30 2017 +1000
>Committer: Justin Mclean 
>Committed: Sun Apr 9 13:26:30 2017 +1000
>
>--
> .../src/main/flex/org/apache/flex/net/HTTPService.as   | 13 +
> 1 file changed, 13 insertions(+)
>--
>
>
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F326d6979%2Fframeworks%2Fpro
>jects%2FNetwork%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fnet%2FHTTPServ
>ice.as=02%7C01%7C%7C58994717190044f003a908d47ef83ba7%7Cfa7b1b5a7b3443
>8794aed2c178decee1%7C0%7C0%7C636273052005930299=TcDMCOEVbLKxedpsnACV
>OmZon89YgUkvGxOtd%2F3Qky8%3D=0
>--
>diff --git 
>a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServic
>e.as 
>b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServic
>e.as
>index b939751..3a9968c 100644
>--- 
>a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServic
>e.as
>+++ 
>b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServic
>e.as
>@@ -505,6 +505,18 @@ package org.apache.flex.net
>   return null;
>   }
> 
>+/**
>+ *  Allows Javascript cross-site Access-Control requests to be
>made
>+ *  using credentials such as cookies or authorization headers
>+ *
>+ *  @productversion FlexJS 0.8
>+ */
>+COMPILE::JS
>+public function set withCredentials(value:Boolean):void {
>+var element:XMLHttpRequest = this.element as XMLHttpRequest;
>+element.withCredentials = value;
>+}
>+
> COMPILE::SWF
> private var urlLoader:flash.net.URLLoader;
> 
>@@ -606,6 +618,7 @@ package org.apache.flex.net
> }
> }
> 
>+
> if (_method !== HTTPConstants.GET &&
> !sawContentType && contentData) {
> element.setRequestHeader(
>

Re: [FlexJS] non-primitive static consts

2017-04-08 Thread Harbs

Related issue:

The recent changes to Falcon has broken UIDUtil which has the following:
private static const UIDBuffer:BinaryData = new BinaryData();

Unless something changes, this needs to be changed to a getter.

> On Apr 8, 2017, at 11:40 PM, Harbs  wrote:
> 
> Currently initializing non-primitive static types are a big no-no in FlexJS. 
> It causes all kinds of javascript runtime errors due to non-defined types 
> depending on the order of loaded files.
> 
> I think this is an area which needs some improvement. The improvement can 
> take two variations:
> 
> 1. We can simply disallow initializing non-primitive types at compile time, 
> so at least there will be a compile-time warning of potential problems.
> 2. We can somehow allow these initializations.
> 
> I’m not sure if #2 is possible, but it would definitely be preferred to #1 if 
> it is.
> 
> Thoughts?
> 
> Harbs

Re: [FlexJS] internal classes based on other classes

2017-04-08 Thread Alex Harui

I'll look into it.  I thought I'd fixed that already.  I assume
BackgroundManager isn't one of the goog.requires in FactoryComposer.js?
And I assume you cleaned out old JS files?

-Alex

On 4/8/17, 9:15 PM, "Harbs"  wrote:

>The current state of Falcon seems to be okay so far, but I just bumped
>into an interesting problem.
>
>In TLF, there’s a class: FactoryComposer. FactoryComposer has an internal
>class called FactoryBackgroundManager which subclasses
>org.apache.flex.textLayout.elements.BackgroundManager.
>
>Because FactoryBackgroundManager is an internal class, the normal
>dependency chain is not built and I’m getting an error on the following
>line:
>goog.inherits(org.apache.flex.textLayout.compose.FactoryComposer.FactoryBa
>ckgroundManager, org.apache.flex.textLayout.elements.BackgroundManager);
>
>This is because this code is running before  BackgroundManager is loaded.
>
>The work-around is to move the internal class out into its own file, but
>I think this is something which should work.
>
>Harbs

Re: [FlexJS] non-primitive static consts

2017-04-08 Thread Alex Harui

Please provide some examples.

On 4/8/17, 8:40 PM, "Harbs"  wrote:

>Currently initializing non-primitive static types are a big no-no in
>FlexJS. It causes all kinds of javascript runtime errors due to
>non-defined types depending on the order of loaded files.
>
>I think this is an area which needs some improvement. The improvement can
>take two variations:
>
>1. We can simply disallow initializing non-primitive types at compile
>time, so at least there will be a compile-time warning of potential
>problems.
>2. We can somehow allow these initializations.
>
>I’m not sure if #2 is possible, but it would definitely be preferred to
>#1 if it is.
>
>Thoughts?
>
>Harbs

[FlexJS] internal classes based on other classes

2017-04-08 Thread Harbs

The current state of Falcon seems to be okay so far, but I just bumped into an 
interesting problem.

In TLF, there’s a class: FactoryComposer. FactoryComposer has an internal class 
called FactoryBackgroundManager which subclasses 
org.apache.flex.textLayout.elements.BackgroundManager.

Because FactoryBackgroundManager is an internal class, the normal dependency 
chain is not built and I’m getting an error on the following line:
goog.inherits(org.apache.flex.textLayout.compose.FactoryComposer.FactoryBackgroundManager,
 org.apache.flex.textLayout.elements.BackgroundManager);

This is because this code is running before  BackgroundManager is loaded.

The work-around is to move the internal class out into its own file, but I 
think this is something which should work.

Harbs

[FlexJS] non-primitive static consts

2017-04-08 Thread Harbs

Currently initializing non-primitive static types are a big no-no in FlexJS. It 
causes all kinds of javascript runtime errors due to non-defined types 
depending on the order of loaded files.

I think this is an area which needs some improvement. The improvement can take 
two variations:

1. We can simply disallow initializing non-primitive types at compile time, so 
at least there will be a compile-time warning of potential problems.
2. We can somehow allow these initializations.

I’m not sure if #2 is possible, but it would definitely be preferred to #1 if 
it is.

Thoughts?

Harbs

Re: git commit: [flex-asjs] [refs/heads/feature/chart-work] - Updates to MDL.

2017-04-08 Thread piotrz

Additionally I was going on Sunday change this area a bit. 

DataProviderChangeNotifier - was suppose to stay without changes

DataProviderAddRemoveNotifier - I was going to add there updateEvent and
change its name to DataProviderItemsChangedNotifier

Create another bead DataProviderCollectionChangedNotifier which will react
only on collectionChanged event from ArrayList.

But you were fast with your changes. Let me know what do you think. :)

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-git-commit-flex-asjs-refs-heads-feature-chart-work-Updates-to-MDL-tp61043p61044.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: git commit: [flex-asjs] [refs/heads/feature/chart-work] - Updates to MDL.

2017-04-08 Thread Piotr Zarzycki

Hi Peter,

I'm concerning about changes in DataProviderChangeNotifier.

Since it is no longer emits dataProviderChanged event it can break logic in
some apps which people are working on.

Some time ago when I've changed ArrayList and add itemAdded/removed etc.
events I've created separate bead [1] which handle those cases.

If those changes stay I will remove my bead, but with this changes we will
lost ability to refresh whole collections by users who using this bead and
waiting for dataProviderChanged.

[1]
https://github.com/apache/flex-asjs/blob/develop/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderAddRemoveNotifier.as

Piotr

On Fri, Apr 7, 2017, 23:23  wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/feature/chart-work 02d4118f0 -> 448e9f8e3
>
>
> Updates to MDL.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/448e9f8e
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/448e9f8e
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/448e9f8e
>
> Branch: refs/heads/feature/chart-work
> Commit: 448e9f8e37c41bf296ea44b33a38adf5bdf10f00
> Parents: 02d4118
> Author: Peter Ent 
> Authored: Fri Apr 7 17:23:26 2017 -0400
> Committer: Peter Ent 
> Committed: Fri Apr 7 17:23:26 2017 -0400
>
> --
>  .../html/beads/DataProviderChangeNotifier.as| 61 +---
>  .../TabsItemRendererFactoryForArrayListData.as  |  3 +-
>  .../org/apache/flex/mdl/beads/views/TabsView.as |  2 +-
>  .../src/main/resources/defaults.css |  4 +-
>  4 files changed, 59 insertions(+), 11 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/448e9f8e/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> --
> diff --git
> a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> index a24810b..2d647c5 100644
> ---
> a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> +++
> b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> @@ -26,16 +26,48 @@ package org.apache.flex.html.beads
> import org.apache.flex.core.UIBase;
> import org.apache.flex.events.IEventDispatcher;
> import org.apache.flex.events.Event;
> +   import org.apache.flex.events.CollectionEvent;
> import org.apache.flex.collections.ArrayList;
>
> /**
> +* Dispatched when a new item has been added to the dataProvider
> being watched.
> +*
> +*  @langversion 3.0
> +*  @playerversion Flash 10.2
> +*  @playerversion AIR 2.6
> +*  @productversion FlexJS 0.8
> +*/
> +   [Event(name="itemAdded",
> type="org.apache.flex.events.CollectionEvent")]
> +
> +   /**
> +* Dispatched when an item has been removed from the dataProvider
> being watched.
> +*
> +*  @langversion 3.0
> +*  @playerversion Flash 10.2
> +*  @playerversion AIR 2.6
> +*  @productversion FlexJS 0.8
> +*/
> +   [Event(name="itemRemved",
> type="org.apache.flex.events.CollectionEvent")]
> +
> +   /**
> +* Dispatched when an item has updated in the dataProvider being
> watched.
> +*
> +*  @langversion 3.0
> +*  @playerversion Flash 10.2
> +*  @playerversion AIR 2.6
> +*  @productversion FlexJS 0.8
> +*/
> +   [Event(name="itemUpdated",
> type="org.apache.flex.events.CollectionEvent")]
> +
> +   /**
>  *  The DataProviderChangeNotifier notifies listeners when a
> selection model's
> -*  ArrayList dataProvider has changed.
> +*  ArrayList dataProvider has changed. It does this by forwarding
> events on
> +*  the dataProvider to the model associated with the strand.
>  *
>  *  @langversion 3.0
>  *  @playerversion Flash 10.2
>  *  @playerversion AIR 2.6
> -*  @productversion FlexJS 0.0
> +*  @productversion FlexJS 0.8
>  */
> public class DataProviderChangeNotifier implements IBead, IDocument
> {
> @@ -45,12 +77,15 @@ package org.apache.flex.html.beads
>  *  @langversion 3.0
>  *  @playerversion Flash 10.2
>  *  @playerversion AIR 2.6
> -*  @productversion FlexJS 0.0
> +*  @productversion FlexJS 0.8
>  */
> public function DataProviderChangeNotifier()
>

Re: git commit: [flex-asjs] [refs/heads/develop] - CORS security. Allow auth credentials to be passed when using cross site calls. This is required as well as setting the Access-Control-Allow-Origin h

Re: [FlexJS] internal classes based on other classes

Re: [FlexJS] non-primitive static consts

Re: git commit: [flex-asjs] [refs/heads/develop] - CORS security. Allow auth credentials to be passed when using cross site calls. This is required as well as setting the Access-Control-Allow-Origin h

Re: [FlexJS] non-primitive static consts

Re: git commit: [flex-asjs] [refs/heads/develop] - CORS security. Allow auth credentials to be passed when using cross site calls. This is required as well as setting the Access-Control-Allow-Origin h

Re: [FlexJS] non-primitive static consts

Re: [FlexJS] internal classes based on other classes

Re: [FlexJS] non-primitive static consts

[FlexJS] internal classes based on other classes

[FlexJS] non-primitive static consts

Re: git commit: [flex-asjs] [refs/heads/feature/chart-work] - Updates to MDL.

Re: git commit: [flex-asjs] [refs/heads/feature/chart-work] - Updates to MDL.

13 matches

Site Navigation

Mail list logo

Footer information