Re: [FlexJS] Merge feature/chart-work into develop

[piotrz]

Hi Peter,

If you stack with something let me know I will look into that.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61034.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[Peter Ent]

I fixed the missing piece for the text fields example. Still looking into
the tabs.
‹peter

On 4/5/17, 5:46 PM, "piotrz"  wrote:

>Peter,
>
>I just tried your changes and check MDLExample and MDLDynamicTabsExample.
>
>In MDLExample:
>TextFields are not displayed
>
>In MDLDynamicTabsExample:
>I see that switching between tabs, once I add Tab dynamically is broken.
>
>Piotr
>
>
>
>-
>Apache Flex PMC
>piotrzarzyck...@gmail.com
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.247.n4.nabble.com%2FFlexJS-Merge-feature-chart-work-into
>-develop-tp61019p61031.html=02%7C01%7C%7Ca61c76fe02a3403fbdd508d47c6e
>81c1%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636270261444943615
>=AGxXFnSHBUum2L1OaMO4fw%2B2hORlmjW0PpNOorXt%2F5g%3D=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[Alex Harui]

On 4/5/17, 10:03 AM, "Harbs"  wrote:

>That would be great.
>
>We need better test coverage. If we could get easy test setup for FlexJS,
>that would be a huge win.

Not sure how you define "easy" but we've had mustella running on FlexJS
for quite a while now.  It allows you to write the tests in MXML instead
of Java.

-Alex

Re: [FlexJS] Merge feature/chart-work into develop

[piotrz]

Peter,

I just tried your changes and check MDLExample and MDLDynamicTabsExample.

In MDLExample:
TextFields are not displayed

In MDLDynamicTabsExample:
I see that switching between tabs, once I add Tab dynamically is broken. 

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61031.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[Peter Ent]

I have decided not to merge today. I ran an example with DataGrid embedded
within a Container and sized to width="100%" and it did not respond
properly to the resize. I know what happened, just working on how to make
it work correctly.

‹peter

On 4/5/17, 1:35 PM, "piotrz"  wrote:

>Peter I just merged falcon develop branch to your chart-work.
>
>Piotr
>
>
>
>-
>Apache Flex PMC
>piotrzarzyck...@gmail.com
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.247.n4.nabble.com%2FFlexJS-Merge-feature-chart-work-into
>-develop-tp61019p61027.html=02%7C01%7C%7C781716181b2b415be00308d47c4b
>7a92%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636270111006084015
>=fRYvuMsfPzFz7V7JU8K%2BCmpWiWFDokA%2FM8f8RBZAzoY%3D=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[piotrz]

Peter I just merged falcon develop branch to your chart-work.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61027.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[piotrz]

Thanks Peter. I'm ok with merge then.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61026.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[Peter Ent]

I just changed Menu to extend DataContainer and now that works fine, for
me, in MDLExample. Thank you for reminding me.

‹peter

On 4/5/17, 11:37 AM, "piotrz"  wrote:

>Hi Peter,
>
>I didn't check MDLExample after your last push, but didn't you mention
>that
>MDL Menu is blank ?
>If it's not working I would say -1 till we have it look ok.
>
>Piotr
>
>
>
>-
>Apache Flex PMC
>piotrzarzyck...@gmail.com
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.247.n4.nabble.com%2FFlexJS-Merge-feature-chart-work-into
>-develop-tp61019p61020.html=02%7C01%7C%7C5d646cbc71544f2db0c808d47c3a
>eeae%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636270039930866144
>=FcdgwvNpXrJKpBYZFABsml8ww27%2B75P3eYM8%2FNNNWf0%3D=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[Christofer Dutz]

Hi Harbs,

Have you had a look at the Integration Test project in FlexJS?

I doubt it would get much simpler:
- The Maven build automatically:
o Downloads, configures and starts a tomcat server
o Deploys all examples as web applications 
o As soon as the server is up and the applications as running, runs the 
Selenium Tests
o Stops the Server after finishing

Just look at how simple these tests are. They are dead-simple Junit tests. I 
know they aren’t FlexUnit type tests, but they already do a good job for the 
examples I created tests for.

Chris


Am 05.04.17, 19:03 schrieb "Harbs" :

That would be great.

We need better test coverage. If we could get easy test setup for FlexJS, 
that would be a huge win.

> On Apr 5, 2017, at 12:33 PM, Christofer Dutz  
wrote:
> 
> I would start writing some simple Selenium Tests for these applications

Re: [FlexJS] Merge feature/chart-work into develop

[Harbs]

That would be great.

We need better test coverage. If we could get easy test setup for FlexJS, that 
would be a huge win.

> On Apr 5, 2017, at 12:33 PM, Christofer Dutz  
> wrote:
> 
> I would start writing some simple Selenium Tests for these applications

Re: [FlexJS] Merge feature/chart-work into develop

[Christofer Dutz]

Hi Peter,

If it improves things, I am fine with this merge. If it adds more areas that 
need fixing then I don’t.
As soon as things start to work again, I would start writing some simple 
Selenium Tests for these applications to ensure they are tested in the future. 

Chris

Am 05.04.17, 17:37 schrieb "piotrz" <piotrzarzyck...@gmail.com>:

Hi Peter,

I didn't check MDLExample after your last push, but didn't you mention that
MDL Menu is blank ?
If it's not working I would say -1 till we have it look ok.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61020.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Merge feature/chart-work into develop

[piotrz]

Hi Peter,

I didn't check MDLExample after your last push, but didn't you mention that
MDL Menu is blank ?
If it's not working I would say -1 till we have it look ok.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61020.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

[FlexJS] Merge feature/chart-work into develop

[Peter Ent]

Hi,

I would like to merge the feature/chart-work into the develop branch in about 5 
hours from now which would make it 4:30pm EDT (9:30pm UTC, I think). Does 
anyone have a strong objection to that?

To recap:
The thrust of this feature branch was to get Charts working, but that lead to 
re-examinging the class structures of the containers. I cleaned this up and 
kept the HTML/JS side output to a minimum. I have also improved the SWF-side 
layouts to more closely mimic CSS Flexbox.

It looks like most, if not all, of MDLExample is working. DataBindingExample, 
DataGridExample, ChartExample are working. I will go back and try the Tour and 
several others as well.

Regards,
Peter