JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

We shouldn't be putting jars in version control:
https://github.com/apache/flex-tlf/tree/develop/ant

Someone mind removing that?

Thanks,
Justin

Re: JAR in TLF svn/git mirror

[Erik de Bruin]

You, for example?

Commit, then review.

EdB



On Saturday, January 24, 2015, Justin Mclean  wrote:

> Hi,
>
> We shouldn't be putting jars in version control:
> https://github.com/apache/flex-tlf/tree/develop/ant
>
> Someone mind removing that?
>
> Thanks,
> Justin
>


-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

Also swfs here:
https://github.com/apache/flex-tlf/tree/develop/libs

And while we're at it. This is got good IP wise:
https://github.com/apache/flex-tlf/blob/develop/sdk/samples/flex/Logo.jpg

And this:
https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/ARIAL_FONT.swf

In fact several things under here:
https://github.com/apache/flex-tlf/tree/develop/test/testFiles/assets

For instance we probably don't have permission to redistribute:
https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/image1.jpg
 

And last I cheaked Alice in wonder land wasn't under an Apache license :-)
https://github.com/apache/flex-tlf/blob/develop/test/testFiles/markup/tlf/alice.xml

Looks like the TLF code in SVN needs a thorough IP review.

Thanks,
Justin

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

> You, for example?

Well normally the people who put the files there should fix them and the PMC as 
a whole is responsible for legal matter and the RM is legally responsible for 
any release that make.

Justin

Re: JAR in TLF svn/git mirror

[Alex Harui]

I took care of the stuff Justin found. Thanks for finding it.  Justin if
you find more, you can probably just delete it yourself.

-Alex

On 1/23/15, 6:39 PM, "Justin Mclean"  wrote:

>Hi,
>
>> You, for example?
>
>Well normally the people who put the files there should fix them and the
>PMC as a whole is responsible for legal matter and the RM is legally
>responsible for any release that make.
>
>Justin

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

> I took care of the stuff Justin found. Thanks for finding it.  Justin if
> you find more, you can probably just delete it yourself.

That was from a five minute look.We really need a full IP check on both Blaze 
DS and TLF repos as it's seems this important step may of been skipped. I would 
have concerns of release anything that contains anything form TLF and Blaze DS 
because of this.  I doubt rat even been run over the full repos given there's 
binary fines in there.

Justin

Re: JAR in TLF svn/git mirror

[Alex Harui]

AIUI, the state of the repos doesn’t affect the release.  BlazeDS passed
IP Clearance.  TLF entered during incubation so different rules apply.
Rat got run on the files in the source package.  I didn’t see anything in
the report.

On 1/23/15, 10:55 PM, "Justin Mclean"  wrote:

>Hi,
>
>> I took care of the stuff Justin found. Thanks for finding it.  Justin if
>> you find more, you can probably just delete it yourself.
>
>That was from a five minute look.We really need a full IP check on both
>Blaze DS and TLF repos as it's seems this important step may of been
>skipped. I would have concerns of release anything that contains anything
>form TLF and Blaze DS because of this.  I doubt rat even been run over
>the full repos given there's binary fines in there.
>
>Justin

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

> AIUI, the state of the repos doesn’t affect the release.  BlazeDS passed IP 
> Clearance.

It may of "passed" but it needs a review badly. A quick rat run on it shows it 
need some work. There's even a "maven-petesucks.png" file, although I think as 
that's in the in directory so that's clean not doing it's job cleaning that up?

Justin

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/23/15, 11:42 PM, "Justin Mclean"  wrote:

>Hi,
>
>> AIUI, the state of the repos doesn’t affect the release.  BlazeDS
>>passed IP Clearance.
>
>It may of "passed" but it needs a review badly.

OK, have fun.  I personally would appreciate it if you save up all your
findings for one email when you are done.  No need to clutter the list as
you find each thing.

>A quick rat run on it shows it need some work. There's even a
>"maven-petesucks.png" file, although I think as that's in the in
>directory so that's clean not doing it's job cleaning that up?

I’ll wait for your report before I go digging.  Files that aren’t in the
release candidate source package don’t need my time and energy right now.

-Alex

AW: JAR in TLF svn/git mirror

[Christofer Dutz]

Well I think it wasn't completely skipped.
When I made the BlazeDS testsuite run again. I a lot of files were missing. 
When looking into the old Adobe repos I could see these were all files with 
license headers of individual contributors ("This code is property of XYZ 
Telecom") and similarly license related stuff. I had to re-write some of that 
missing code and remove a hand full of tests (Can't test if the ressources the 
tests use are gone).

So checking has been done. And it seems to have been good enough for the Apache 
legal department ...

Chris

-Ursprüngliche Nachricht-
Von: Justin Mclean [mailto:jus...@classsoftware.com] 
Gesendet: Samstag, 24. Januar 2015 07:55
An: dev@flex.apache.org
Betreff: Re: JAR in TLF svn/git mirror

Hi,

> I took care of the stuff Justin found. Thanks for finding it.  Justin 
> if you find more, you can probably just delete it yourself.

That was from a five minute look.We really need a full IP check on both Blaze 
DS and TLF repos as it's seems this important step may of been skipped. I would 
have concerns of release anything that contains anything form TLF and Blaze DS 
because of this.  I doubt rat even been run over the full repos given there's 
binary fines in there.

Justin

AW: JAR in TLF svn/git mirror

[Christofer Dutz]

I think you are running the "Ant" build on the "Maven" project ... I have never 
gotten the Ant build to work. As the Maven build works like a charm, I would 
stick to that. I think we also discussed retiring the stuff outside the 
"modules" directory and as soon as I initiate a release for BlazeDS (As soon as 
4.14 is out the door). Moving that to a retirement branch and moving the stuff 
from modules up one directory, making it the new root, will be one of my first 
tasks.

Chris

-Ursprüngliche Nachricht-
Von: Justin Mclean [mailto:jus...@classsoftware.com] 
Gesendet: Samstag, 24. Januar 2015 08:42
An: dev@flex.apache.org
Betreff: Re: JAR in TLF svn/git mirror

Hi,

> AIUI, the state of the repos doesn't affect the release.  BlazeDS passed IP 
> Clearance.

It may of "passed" but it needs a review badly. A quick rat run on it shows it 
need some work. There's even a "maven-petesucks.png" file, although I think as 
that's in the in directory so that's clean not doing it's job cleaning that up?

Justin

Re: JAR in TLF svn/git mirror

[piotrz]

Hi Guys,

Files in /ant and /libs folders are needed for Unit tests in TLF. All these
files should be removed also from our git repository ? If yes - How Jenkins
will build everything and launch tests ? Is there any specific path where we
can point once we remove files from repository ?

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44594.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[Erik de Bruin]

If you explain what needs to be build, I can get Jenkins to build it
prior to launching the tests, no problem.

EdB



On Sat, Jan 24, 2015 at 9:57 PM, piotrz  wrote:
> Hi Guys,
>
> Files in /ant and /libs folders are needed for Unit tests in TLF. All these
> files should be removed also from our git repository ? If yes - How Jenkins
> will build everything and launch tests ? Is there any specific path where we
> can point once we remove files from repository ?
>
> Piotr
>
>
>
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in context: 
> http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44594.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: JAR in TLF svn/git mirror

[Harbs]

On Jan 24, 2015, at 2:53 AM, Justin Mclean  wrote:
> 
> In fact several things under here:
> https://github.com/apache/flex-tlf/tree/develop/test/testFiles/assets
> 
> For instance we probably don't have permission to redistribute:
> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/image1.jpg
>  

These are probably all public domain images (and look that way to me). I find 
it hard to believe that Adobe would have used copyrighted images for this. If 
anyone has objections to specific ones, we should swap them out for different 
ones (of the same resolution) which can be determined to be public domain.

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/24/15, 1:22 PM, "Harbs"  wrote:

>
>On Jan 24, 2015, at 2:53 AM, Justin Mclean 
>wrote:
>> 
>> In fact several things under here:
>> https://github.com/apache/flex-tlf/tree/develop/test/testFiles/assets
>> 
>> For instance we probably don't have permission to redistribute:
>> 
>>https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/ima
>>ge1.jpg 
>
>These are probably all public domain images (and look that way to me). I
>find it hard to believe that Adobe would have used copyrighted images for
>this. 

Actually, Adobe used tons of content they did not own in testing.  They
never really expected the test media to be open-source.  Some serious time
gets spent scrubbing prior to donation, but I never end up catching it all.

>If anyone has objections to specific ones, we should swap them out for
>different ones (of the same resolution) which can be determined to be
>public domain.

If the tests only care about the size and not the actual bits, then that
will make it easier to replace.

-Alex

Re: JAR in TLF svn/git mirror

[Harbs]

Yes. The tests do not do image comparisons. It’s only position, structure and 
metrics.

The following images appear to be used in the tests:

carrot.png
FremontBridge.jpg
fakepng.png
gremlin.jpg
leaves.jpg
RedCircles.swf
smiley.gif
smiling.png
smiling.swf.png
surprised.png

They do not look to me like they are copyrighted images, but I’d have a hard 
time proving that.

I suggest leaving them for now, and anyone who is concerned can swap them with 
different images later.

On Jan 24, 2015, at 11:40 PM, Alex Harui  wrote:

>> If anyone has objections to specific ones, we should swap them out for
>> different ones (of the same resolution) which can be determined to be
>> public domain.
> 
> If the tests only care about the size and not the actual bits, then that
> will make it easier to replace.

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

>> For instance we probably don't have permission to redistribute:
>> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/image1.jpg
>>  

I would be surprised if the above image was public domain.

Justin

Re: JAR in TLF svn/git mirror

[Harbs]

Yes. But it was obviously taken by an Adobe employee and then donated to 
Apache, so there’s no IP issues there.

On Jan 24, 2015, at 11:57 PM, Justin Mclean  wrote:

> Hi,
> 
>>> For instance we probably don't have permission to redistribute:
>>> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/image1.jpg
>>>  
> 
> I would be surprised if the above image was public domain.
> 
> Justin
> 

Re: JAR in TLF svn/git mirror

[Harbs]

However, as far as I can tell the image was not used in any of the tests, so 
it’s probably safe to remove it if you want.

On Jan 25, 2015, at 12:00 AM, Harbs  wrote:

> Yes. But it was obviously taken by an Adobe employee and then donated to 
> Apache, so there’s no IP issues there.
> 
> On Jan 24, 2015, at 11:57 PM, Justin Mclean  wrote:
> 
>> Hi,
>> 
 For instance we probably don't have permission to redistribute:
 https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/image1.jpg
  
>> 
>> I would be surprised if the above image was public domain.
>> 
>> Justin
>> 
> 

Re: JAR in TLF svn/git mirror

[Alex Harui]

I’ve reverted all the way back to before I tried fixing issues in Justin’s
list.  Once everything passes, I’ll try removing a few things.

On 1/24/15, 2:02 PM, "Harbs"  wrote:

>However, as far as I can tell the image was not used in any of the tests,
>so it’s probably safe to remove it if you want.
>
>On Jan 25, 2015, at 12:00 AM, Harbs  wrote:
>
>> Yes. But it was obviously taken by an Adobe employee and then donated
>>to Apache, so there’s no IP issues there.
>> 
>> On Jan 24, 2015, at 11:57 PM, Justin Mclean 
>>wrote:
>> 
>>> Hi,
>>> 
> For instance we probably don't have permission to redistribute:
> 
>https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/
>image1.jpg 
>>> 
>>> I would be surprised if the above image was public domain.
>>> 
>>> Justin
>>> 
>> 
>

Re: JAR in TLF svn/git mirror

[Harbs]

The only thing that concerns me from Justin’s list is the Arial font and 
possibly the Adobe logo.

I’m not sure what the Arial font is used for. Piotr will have to comment on 
that.

As far as I can tell, the Adobe logo is not used, so removing that should be 
fine.

On Jan 25, 2015, at 12:03 AM, Alex Harui  wrote:

> I’ve reverted all the way back to before I tried fixing issues in Justin’s
> list.  Once everything passes, I’ll try removing a few things.
> 
> On 1/24/15, 2:02 PM, "Harbs"  wrote:
> 
>> However, as far as I can tell the image was not used in any of the tests,
>> so it’s probably safe to remove it if you want.
>> 
>> On Jan 25, 2015, at 12:00 AM, Harbs  wrote:
>> 
>>> Yes. But it was obviously taken by an Adobe employee and then donated
>>> to Apache, so there’s no IP issues there.
>>> 
>>> On Jan 24, 2015, at 11:57 PM, Justin Mclean 
>>> wrote:
>>> 
 Hi,
 
>> For instance we probably don't have permission to redistribute:
>> 
>> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/
>> image1.jpg 
 
 I would be surprised if the above image was public domain.
 
 Justin
 
>>> 
>> 
> 

Re: JAR in TLF svn/git mirror

[piotrz]

Alex,

There are plenty of tests which are using Arial font in TLF, but removing
these ARIAL_FONT.swf wasn't have any wrong impact on our current working
tests. I don't know what will happen once I started to fix the rest one - We
will see. :)

Harbs,

I'm not sure whether tanach.xml won't be used somewhere in the rest of the
tests. If it was a license problem I'm ok, but if not please bring back this
file to the repo.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.2333347.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44636.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[piotrz]

Erik,

As for the build. We need these files for TLF Flex unit:

flexunit.swc
flexunit-cilistener.swc
flexunit-uilistener.swc

They are part of Apache Flex Unit and for running through ant unit tests we
need also

flexUnitTasks.jar

But maybe I'm wrong and we can replace these jar file to something else ? 

Piotr





-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44637.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[Harbs]

I searched the repo for a reference to the file and did not find one.

Are there more tests that are not in the repo?

On Jan 25, 2015, at 8:51 PM, piotrz  wrote:

> Harbs,
> 
> I'm not sure whether tanach.xml won't be used somewhere in the rest of the
> tests. If it was a license problem I'm ok, but if not please bring back this
> file to the repo.

Re: JAR in TLF svn/git mirror

[piotrz]

I know that this file is not used for now, but there are still more than 50
test classes in TLF which need to be fixed. Maybe some of them will require
these file, so I would be really carefully removing anything. :)

Piotr





-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44639.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[Harbs]

Where are these tests that need fixing? I’ll be happy to check whether the 
tanach.xml text is needed.

On Jan 25, 2015, at 9:14 PM, piotrz  wrote:

> I know that this file is not used for now, but there are still more than 50
> test classes in TLF which need to be fixed. Maybe some of them will require
> these file, so I would be really carefully removing anything. :)
> 
> Piotr
> 
> 
> 
> 
> 
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in context: 
> http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44639.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[piotrz]

Look into the module automation_tests and folders:

automation_tests\src\UnitTest\Tests\
automation_tests\src\UnitTest\PerformanceTests\

All classes from these folders which are not in AllTestsSuite class need to
be fixed/rewritten for Flex Unit 4.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44641.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[Harbs]

Okay. I already searched all those files, and there was no reference to 
tanach.xml.

I think we’re okay.

If we do need extensive Hebrew texts for testing, I’ll be happy to put 
something together when we do.

On Jan 25, 2015, at 9:24 PM, piotrz  wrote:

> Look into the module automation_tests and folders:
> 
> automation_tests\src\UnitTest\Tests\
> automation_tests\src\UnitTest\PerformanceTests\
> 
> All classes from these folders which are not in AllTestsSuite class need to
> be fixed/rewritten for Flex Unit 4.
> 
> Piotr
> 
> 
> 
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in context: 
> http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44641.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[piotrz]

No problem :) I will ping you once we will require this. :) 

Thank you,
Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44643.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/25/15, 10:51 AM, "piotrz"  wrote:

>Alex,
>
>There are plenty of tests which are using Arial font in TLF, but removing
>these ARIAL_FONT.swf wasn't have any wrong impact on our current working
>tests. I don't know what will happen once I started to fix the rest one -
>We
>will see. :)

It didn’t appear to be used, which is a bit surprising, since I’ve seen
that device fonts can choose different line-endings on different
platforms, but maybe that was only TextField and FTE no longer has that
problem.

But if we do want to use an embedded font, we should use Open Sans or some
other open source font.  And it is my preference that we take the time to
tweak the build scripts to create a SWF with the font from sources.  It
isn’t a violation to have SWCs and SWFs in a repo, but I’d rather we
always ensure that we truly can build everything from sources.  It has the
advantage of picking up the latest and greatest from the upstream source
and not getting stale (assuming you can trust the upstream to be backward
compatible).

-Alex

Re: JAR in TLF svn/git mirror

[Dave Fisher]

If it is any Category A including Public Domain at 
http://www.apache.org/legal/resolved.html you may put it in an Apache 
repository.

But - I mean dude!

http://www.metrolyrics.com/go-ask-alice-lyrics-jefferson-airplane.html

On Jan 23, 2015, at 4:53 PM, Justin Mclean wrote:

> Hi,
> 
> Also swfs here:
> https://github.com/apache/flex-tlf/tree/develop/libs
> 
> And while we're at it. This is got good IP wise:
> https://github.com/apache/flex-tlf/blob/develop/sdk/samples/flex/Logo.jpg
> 
> And this:
> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/ARIAL_FONT.swf
> 
> In fact several things under here:
> https://github.com/apache/flex-tlf/tree/develop/test/testFiles/assets
> 
> For instance we probably don't have permission to redistribute:
> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/assets/image1.jpg
>  
> 
> And last I cheaked Alice in wonder land wasn't under an Apache license :-)
> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/markup/tlf/alice.xml
> 
> Looks like the TLF code in SVN needs a thorough IP review.
> 
> Thanks,
> Justin

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

> If it is any Category A including Public Domain at 
> http://www.apache.org/legal/resolved.html you may put it in an Apache 
> repository.

If you'e referring to the Arial font it's not public domain / Category A [1] 
and this file was removed, then added back in, and then removed again, so we're 
fine there, but there are still other infringing files see [2].

Justin

1. http://en.wikipedia.org/wiki/Arial
2. https://issues.apache.org/jira/browse/FLEX-34729

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/27/15, 4:58 PM, "Dave Fisher"  wrote:

>If it is any Category A including Public Domain at
>http://www.apache.org/legal/resolved.html you may put it in an Apache
>repository.

Hi Dave, I don’t think the current debate is about whether Public Domain
content can be in the repository, it is how we give attribution.  My
current thinking is that we keep the Apache Headers in the source file [1]
and give attribution in a NOTICE.test file that would get merged with the
main NOTICE file if we ever release these tests.  My understanding of
Justin’s position is that he wants to remove the Apache header and replace
it with a header that calls out that most of the content came from the
public domain such as:

"Content taken form Alice in Wonderland, by Lewis Carroll. Now in the
public domain."


Do you have an answer or opinion?

Thanks,
-Alex

[1] 
https://github.com/apache/flex-tlf/blob/develop/test/testFiles/markup/tlf/a
lice.xml

RE: JAR in TLF svn/git mirror

[Chris Martin]

> My current thinking is that we keep the Apache Headers in the source file [1]
> and give attribution in a NOTICE.test file that would get merged with the
> main NOTICE file if we ever release these tests.
 
Just wanted to give my thoughts. I think the above should be fine.  Right in 
the Apache header it says, "See the NOTICE file distributed with this work for 
additional information regarding copyright ownership." So if I had a question 
about copyright ownership I'd look there.
 
I've always understood the apache header to identify that the work (in this 
case the xml structure, and others code, etc.) was donated/licensed under the 
apache contributor license agreement. Now in this case the content between the 
tags (Alice in Wonderland text) is public domain, so we'd be sure to add 
attribution in the NOTICE file. So if people wonder if we were allowed to use 
the text, they'd check the NOTICE file and realize the text is public domain.
 
Chris
 
 
> From: aha...@adobe.com
> To: dev@flex.apache.org
> Subject: Re: JAR in TLF svn/git mirror
> Date: Wed, 28 Jan 2015 07:58:48 +
> 
> 
> 
> On 1/27/15, 4:58 PM, "Dave Fisher"  wrote:
> 
> >If it is any Category A including Public Domain at
> >http://www.apache.org/legal/resolved.html you may put it in an Apache
> >repository.
> 
> Hi Dave, I don’t think the current debate is about whether Public Domain
> content can be in the repository, it is how we give attribution.  My
> current thinking is that we keep the Apache Headers in the source file [1]
> and give attribution in a NOTICE.test file that would get merged with the
> main NOTICE file if we ever release these tests.  My understanding of
> Justin’s position is that he wants to remove the Apache header and replace
> it with a header that calls out that most of the content came from the
> public domain such as:
> 
> "Content taken form Alice in Wonderland, by Lewis Carroll. Now in the
> public domain."
> 
> 
> Do you have an answer or opinion?
> 
> Thanks,
> -Alex
> 
> [1] 
> https://github.com/apache/flex-tlf/blob/develop/test/testFiles/markup/tlf/a
> lice.xml
> 
  

Re: JAR in TLF svn/git mirror

[Bertrand Delacretaz]

Hi,

On Wednesday, January 28, 2015, Alex Harui  wrote:

>  My current thinking is that we keep the Apache Headers in the
> source file [1] and give attribution in a NOTICE.test file...

> Justin’s position is that he wants to remove the Apache header and replace
> it with a header that calls out that most of the content came from the
> public domain...

I much prefer that second option, IIUC that text is clearly in the public
domain, so it's not licensed to Apache as the current header implies.

Also, NOTICE files should be minimal, I see no need to bother users with
such trivial stuff in the NOTICE.

-Bertrand

[1]
https://github.com/apache/flex-tlf/blob/develop/test/testFiles/markup/tlf/a
lice.xml

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/28/15, 9:45 AM, "Bertrand Delacretaz"  wrote:

>Hi,
>
>On Wednesday, January 28, 2015, Alex Harui  wrote:
>
>>  My current thinking is that we keep the Apache Headers in the
>> source file [1] and give attribution in a NOTICE.test file...
>
>> Justin’s position is that he wants to remove the Apache header and
>>replace
>> it with a header that calls out that most of the content came from the
>> public domain...
>
>I much prefer that second option, IIUC that text is clearly in the public
>domain, so it's not licensed to Apache as the current header implies.

Ok, I’m fine if we do that.  This is the frustrating part of Apache IP
handling.  Commons Compress seems to have used Apache headers around the
7zip code they use and give attribution in the NOTICE per the
legal-resolved page.  It just seems that once you start mixing content
that isn’t public domain (in this case the TLF markup) if you have to
determine the % of IP in order to determine which header to use it adds
extra overhead.

Re: JAR in TLF svn/git mirror

[Bertrand Delacretaz]

On Wed, Jan 28, 2015 at 7:32 PM, Alex Harui  wrote:
> ...It just seems that once you start mixing content
> that isn’t public domain (in this case the TLF markup) if you have to
> determine the % of IP in order to determine which header to use it adds
> extra overhead.

Yeah, that can complicate things, but maybe that TLF markup isnt'
really creative, in which case you don't really care.

-Bertrand

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/29/15, 1:02 AM, "Bertrand Delacretaz"  wrote:

>On Wed, Jan 28, 2015 at 7:32 PM, Alex Harui  wrote:
>> ...It just seems that once you start mixing content
>> that isn’t public domain (in this case the TLF markup) if you have to
>> determine the % of IP in order to determine which header to use it adds
>> extra overhead.
>
>Yeah, that can complicate things, but maybe that TLF markup isnt'
>really creative, in which case you don't really care.

My new recommendation is to follow your recommendation from several weeks
ago and simplify.  We should just remove this public domain content and
replace it with content that is under AL.  This has been suggested by
others in the JIRA thread so hopefully everyone will agree and someone
will just do it.

The bigger picture is even more complicated.  There is a code file with a
portion of the public domain text in it that would probably force a
mention of this content in NOTICE.

Thanks,
-Alex

Re: JAR in TLF svn/git mirror

[Bertrand Delacretaz]

On Thursday, January 29, 2015, Alex Harui  wrote:

> ... There is a code file with a portion of the public domain text in it
that
> would probably force a mention of this content in NOTICE

You can just add a comment before that public domain text, that it's public
domain.

That doesn't put any more constraints on users than the Apache License so
you're fine.

-Bertrand

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

> You can just add a comment before that public domain text, that it's public
> domain.
> 
> That doesn't put any more constraints on users than the Apache License so
> you're fine.

I's prefer to see in the actual files (so you know what is the public domain 
content) as above but I also think it's needed somewhere top level. If not the 
NOTICE file or perhaps then the LICENSE file as suggested by "Attribution is 
required (in a similar fashion to permissive licenses)". [1] Think what you do 
when adding MIT/BSD licenses (ie add them to LICENSE).

Take this scenario. Someone downloads the TLF repo because they want to use it 
in their project, they take a look at the top level LICENSE/NOTICE and 
currently would have no idea that there was content from the public domain in 
our repo, so they just bundle it up and distribute it with no changes to their 
LICENSE or NOTICE.

Thanks,
Justin

1. 
http://www.apache.org/legal/resolved.html#can-works-placed-in-the-public-domain-be-included-in-apache-products

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/29/15, 2:33 PM, "Justin Mclean"  wrote:

>Hi,
>
>> You can just add a comment before that public domain text, that it's
>>public
>> domain.
>> 
>> That doesn't put any more constraints on users than the Apache License
>>so
>> you're fine.
>
>I's prefer to see in the actual files (so you know what is the public
>domain content) as above but I also think it's needed somewhere top
>level. If not the NOTICE file or perhaps then the LICENSE file as
>suggested by "Attribution is required (in a similar fashion to permissive
>licenses)". [1] Think what you do when adding MIT/BSD licenses (ie add
>them to LICENSE).
>
>Take this scenario. Someone downloads the TLF repo because they want to
>use it in their project, they take a look at the top level LICENSE/NOTICE
>and currently would have no idea that there was content from the public
>domain in our repo, so they just bundle it up and distribute it with no
>changes to their LICENSE or NOTICE.

If we put the attribution in the main NOTICE, then if we don’t package the
tests in the release artifact we have to remember to change NOTICE or use
a different NOTICE.  I would imagine other projects who composite NOTICE
files are exposed in the same way.

All this is more reason for us to simply remove the public domain text and
replace it with text from our README or something like that.  Can we agree
to do that?

-Alex

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

> If we put the attribution in the main NOTICE, then if we don’t package the
> tests in the release artifact we have to remember to change NOTICE or use
> a different NOTICE.  I would imagine other projects who composite NOTICE
> files are exposed in the same way.

The NOTICE/LICENSE that's used in the SDK is in another repo so I don't see 
that issue here we just have to correct the top level TLF one. There's no need 
for multiple NOTICE/LICENSE in TLF just one for the whole repo.

> All this is more reason for us to simply remove the public domain text and
> replace it with text from our README or something like that.  Can we agree
> to do that?

That's also an valid option but may be more work than changing a few headers 
and possibly adding few lines to NOTICE/LICENSE.

Thanks,
Justin

Re: JAR in TLF svn/git mirror

[Harbs]

I think it’s likely that we’re going to break some of the tests if we swap out 
the texts for something else.

If someone wants to try, feel free, but it seems like a lot of work.

I really don’t understand why this is so complicated. Do we really need 
explicit attribution for some text that’s only being used in test suites? No 
one will even ever see the text except for some very small portions that might 
flash across a screen. It seems to me that some text like: "Potions of the 
texts used in the test suites are from public domain texts” is all that we’d 
need in a NOTICE. That really seems to me like it’s enough attribution.

On Jan 30, 2015, at 12:46 AM, Alex Harui  wrote:

> All this is more reason for us to simply remove the public domain text and
> replace it with text from our README or something like that.  Can we agree
> to do that?

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/29/15, 3:27 PM, "Harbs"  wrote:

>I think it’s likely that we’re going to break some of the tests if we
>swap out the texts for something else.
>
>If someone wants to try, feel free, but it seems like a lot of work.

I thought we’d found that the provenance of some of the other texts were
in question and were going to swap out some text anyway.  I don’t know
what kinds of things the tests were looking for, but if we swap in text
could we just assume that whatever result we get is right given that they
all pass now?

>
>I really don’t understand why this is so complicated. Do we really need
>explicit attribution for some text that’s only being used in test suites?
>No one will even ever see the text except for some very small portions
>that might flash across a screen. It seems to me that some text like:
>"Potions of the texts used in the test suites are from public domain
>texts” is all that we’d need in a NOTICE. That really seems to me like
>it’s enough attribution.

IMO, this stuff is always complicated because the instructions are not
clear and it takes several emails to agree and each email eats up 2 hours
of community time.  That’s why if we can find an easy way to swap in
different text, one person can do that without bothering everyone else.

-Alex

Re: JAR in TLF svn/git mirror

[Bertrand Delacretaz]

Hi,

On Thu, Jan 29, 2015 at 11:33 PM, Justin Mclean
 wrote:
> Bertrand wrote:
>> You can just add a comment before that public domain text, that it's public
>> domain.
>>
> I's prefer to see in the actual files (so you know what is the public 
> domain content) as above
> but I also think it's needed somewhere top level. If not the NOTICE file or 
> perhaps then
> the LICENSE file...

LICENSE sounds good to me if you want that.

NOTICE must stay minimal, i.e. contain only required notices, so for
public domain stuff I'd go for LICENCE.

-Bertrand

Re: JAR in TLF svn/git mirror

[Bertrand Delacretaz]

On Fri, Jan 30, 2015 at 12:46 AM, Alex Harui  wrote:
> ...IMO, this stuff is always complicated because the instructions are not
> clear and it takes several emails to agree...

If you keep track of those changes in jira, next time you can just
point to that and say "do like we did in FLEX-NNN" without having to
rehash the whole thing.

-Bertrand

Re: JAR in TLF svn/git mirror

[Alex Harui]

On 1/30/15, 1:38 AM, "Bertrand Delacretaz"  wrote:
>
>LICENSE sounds good to me if you want that.
>
>NOTICE must stay minimal, i.e. contain only required notices, so for
>public domain stuff I'd go for LICENCE.

And this is why it is so complicated.  See [1] (apologies that s.a.o is
down so I can’t provide a shortened link).  It appears to be the opposite
recommendation.  It is the last comment from Henri in [2].


And we will try to track this as a JIRA issue, but historically, we often
learn more about the rules around LICENSE and NOTICE so when the issue
comes up again we think there should be a different answer.

Anyway, at this point, my recommendation is: if we are going to be
changing other text because that other text wasn’t permissively licensed,
then we should replace all text, but otherwise or maybe in the interim,
let’s put something in LICENSE and/or NOTICE.

Thanks
-Alex

[1] 
https://issues.apache.org/jira/browse/LEGAL-72?focusedCommentId=12868014&pa
ge=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment
-12868014

[2] https://issues.apache.org/jira/browse/LEGAL-72

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

OK I gone though and fix up all of the public domain stuff, correct headers 
where needed and added some text to LICENSE. The rabbit hole was a little 
deeper than I first thought and there more files "infected" than a casual  
glance gave.

IMO replacing all of the pubic domain content would break a large number of 
tests and require more work than this was, but if someone is prepared to do 
that go for it.

Where we need to change content (as we're not legally allowed to use it) I've 
added a FIXME (mostly the Arabic and Japanese text samples).

Here's the current list of files than need content replaced.
./automation_tests/src/UnitTest/Tests/FloatTest.as
./automation_tests/src/UnitTest/Tests/ScrollToRangeTest.as
./automation_tests/src/UnitTest/Tests/TableTests.as
./test/testFiles/markup/tlf/JapaneseSampleMac.xml
./test/testFiles/markup/tlf/JapaneseSampleWin.xml
./test/testFiles/markup/tlf/RTLTabs.xml
./test/testFiles/markup/tlf/sampleArabic.xml
./testApps/src/school.mxml
./testApps/src/schoolV.mxml

Apologies in advance if I've broken any tests.

Thanks,
Justin

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

Also this file: 
automation_tests/src/UnitTest/Tests/FloatTest.as

Contains text from the NY Times and need some content replaced.

Justin

Re: JAR in TLF svn/git mirror

[Justin Mclean]

Hi,

Just replace the copyright text in th test with machine translated text from 
our README, as far as I can se eI've not broken any tests, but sorry in 
advanced if I have done so. I think that's all know IP issues dealt with and we 
can now close this JIRA. [1]

Thanks,
Justin

1. https://issues.apache.org/jira/browse/FLEX-34729

Re: AW: JAR in TLF svn/git mirror

[Alex Harui]

On 1/24/15, 1:25 AM, "Christofer Dutz"  wrote:

>I think you are running the "Ant" build on the "Maven" project ... I have
>never gotten the Ant build to work.

When did you last try?  I’m pretty sure I got it to work.  It works for me.

Hopefully Justin’s technique for scrubbing will be to blow away his
working copy, get a fresh clone and run rat then.  Then do build and clean
and run rat again and adjust clean until it matches the first rat.

-Alex

Re: AW: JAR in TLF svn/git mirror

[Dave Fisher]

For Apache Flex you are the Apache Legal department. The ASF counts on projects 
to do due diligence.

On Jan 24, 2015, at 1:21 AM, Christofer Dutz wrote:

> Well I think it wasn't completely skipped.
> When I made the BlazeDS testsuite run again. I a lot of files were missing. 
> When looking into the old Adobe repos I could see these were all files with 
> license headers of individual contributors ("This code is property of XYZ 
> Telecom") and similarly license related stuff. I had to re-write some of that 
> missing code and remove a hand full of tests (Can't test if the ressources 
> the tests use are gone).
> 
> So checking has been done. And it seems to have been good enough for the 
> Apache legal department ...
> 
> Chris
> 
> -Ursprüngliche Nachricht-
> Von: Justin Mclean [mailto:jus...@classsoftware.com] 
> Gesendet: Samstag, 24. Januar 2015 07:55
> An: dev@flex.apache.org
> Betreff: Re: JAR in TLF svn/git mirror
> 
> Hi,
> 
>> I took care of the stuff Justin found. Thanks for finding it.  Justin 
>> if you find more, you can probably just delete it yourself.
> 
> That was from a five minute look.We really need a full IP check on both Blaze 
> DS and TLF repos as it's seems this important step may of been skipped. I 
> would have concerns of release anything that contains anything form TLF and 
> Blaze DS because of this.  I doubt rat even been run over the full repos 
> given there's binary fines in there.
> 
> Justin