Re: [VOTE] Apache Flex 4.9.1 RC3
+1 The README still says we just graduated and the URLs will change, but I can live with that. I checked ASC sig for the tar.gz on mac. Rat was clean. Source distro built. Mustella passed. I'm not set up to try Windows at this time. Thanks Justin! On 2/18/13 12:41 AM, "Justin Mclean" wrote: > Hi, > > This is a Apache Flex 4.9.1 RC3. Please see the RELEASE_NOTES and the README. > > There are only very minor changes from RC2 including updating the > RELEASE_NOTES and REAMDE files, fixing the ASDocs logo and adding FLEX-29002 > (RTE fix for PopupManager). > > The release candidate can be found here; > https://dist.apache.org/repos/dist/dev/flex/sdk/4.9.1/rc3/ > > Before voting please review the section,"What are the ASF requirements on > approving a release?", at: > http://www.apache.org/dev/release.html#approving-a-release > > Please vote to approve this release: > +1 Approve the release > -1 Veto the release (please provide specific comments to why) > > This vote will be open for at least 72 hours or as long as needed given it > holidays. > > The vote passes if there is: > - At least 3 +1 votes from the PMC > - More positive votes than negative votes > > When voting please indicate what platform and IDE you compiled and tested the > SDK with. > > Please put all discussion about this release in a DISCUSSION thread not this > VOTE thread. > > Thanks, > Justin -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi, +1 (binding) from me also. Anyone else have some time to try this out? Thanks, Justin
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi, -1 at the moment as I still have failed tests and I can't solve them, Alex saied he's going to have a look, I sent him the images. -Fred -Message d'origine- From: Justin Mclean Sent: Thursday, February 21, 2013 1:09 AM To: dev@flex.apache.org Subject: Re: [VOTE] Apache Flex 4.9.1 RC3 Hi, +1 (binding) from me also. Anyone else have some time to try this out? Thanks, Justin
Re: [VOTE] Apache Flex 4.9.1 RC3
Turns out the tooltip was in bold which we don't have a font for. I just set the tooltip to normal and recut baselines. See if they pass for you. For the bubble test, I will look into it eventually, but time is limited for me right now as I'm prepping for a travel day tomorrow. I did notice that the width of the thick grey bar at the bottom seems to be one pixel shorter for you than in the baselines. If you have time to debug that test and follow the logic that determines that width, that might give us the clue we need. On 2/20/13 4:48 PM, "Frédéric THOMAS" wrote: > Hi, > > -1 at the moment as I still have failed tests and I can't solve them, Alex > saied he's going to have a look, I sent him the images. > > -Fred > > -Message d'origine- > From: Justin Mclean > Sent: Thursday, February 21, 2013 1:09 AM > To: dev@flex.apache.org > Subject: Re: [VOTE] Apache Flex 4.9.1 RC3 > > Hi, > > +1 (binding) from me also. > > Anyone else have some time to try this out? > > Thanks, > Justin > -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
My mustella tests failed last night (issues with my flash player after an update). I'm going to try and rerun it tonight. On Feb 20, 2013 7:10 PM, "Justin Mclean" wrote: > Hi, > > +1 (binding) from me also. > > Anyone else have some time to try this out? > > Thanks, > Justin >
Re: [VOTE] Apache Flex 4.9.1 RC3
It still happens besause of the headerStyleName of the DateChooser, I guess
I should re-generate the images with that, what do you think ?
mx|DateChooser
{
weekDayStyleName: "noBoldWeekDayStyle";
headerStyleName: "noBoldHeaderStyles"
}
.noBoldWeekDayStyle
{
fontWeight: normal;
textAlign: "center";
}
.noBoldHeaderStyles {
fontWeight: normal;
}
Another issue with pixel diffs of the
LangPacks/Japanese/tests/phoneNumberValidatorTests
JA_PhoneNumberValidator_wrongLengthError, I send you a copy of the bas png.
I'll be away from today until Monday, I'll take my laptop but I'm not sure
I'll have internet there.
-Fred
-Message d'origine-
From: Alex Harui
Sent: Thursday, February 21, 2013 3:32 AM
To: dev@flex.apache.org
Subject: Re: [VOTE] Apache Flex 4.9.1 RC3
Turns out the tooltip was in bold which we don't have a font for. I just
set the tooltip to normal and recut baselines. See if they pass for you.
For the bubble test, I will look into it eventually, but time is limited for
me right now as I'm prepping for a travel day tomorrow. I did notice that
the width of the thick grey bar at the bottom seems to be one pixel shorter
for you than in the baselines. If you have time to debug that test and
follow the logic that determines that width, that might give us the clue we
need.
On 2/20/13 4:48 PM, "Frédéric THOMAS" wrote:
Hi,
-1 at the moment as I still have failed tests and I can't solve them, Alex
saied he's going to have a look, I sent him the images.
-Fred
-Message d'origine-
From: Justin Mclean
Sent: Thursday, February 21, 2013 1:09 AM
To: dev@flex.apache.org
Subject: Re: [VOTE] Apache Flex 4.9.1 RC3
Hi,
+1 (binding) from me also.
Anyone else have some time to try this out?
Thanks,
Justin
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
On 2/20/13 8:20 PM, "Frédéric THOMAS" wrote: > It still happens besause of the headerStyleName of the DateChooser, I guess > I should re-generate the images with that, what do you think ? Hmm, I'm not sure how that happened. I guess I must have hit undo and some point. I called the style "noBold..." but didn't set the fontWeight. Feel free to make the changes. If you don't, I will on Friday. Are you still going to keep your vote at -1 until I have time to solve all of your mustella issues? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi Alex, I have a bit of time this morning to take care of the 2 issues relative to the DateChooser header style but that's it. Unfortunatly, I think I have neither the time nor the knowledge to deal with the other 2 remaining problems on windows. Are you still going to keep your vote at -1 until I have time to solve all of your mustella issues? If WE tolerate having 99.999% of tests passed and because those failed tests are only a few pixels differences, so, no stopper, I would go for a +1, for myself, I think, we can go for a release. -Fred -Message d'origine- From: Alex Harui Sent: Thursday, February 21, 2013 8:01 AM To: dev@flex.apache.org Subject: Re: [VOTE] Apache Flex 4.9.1 RC3 On 2/20/13 8:20 PM, "Frédéric THOMAS" wrote: It still happens besause of the headerStyleName of the DateChooser, I guess I should re-generate the images with that, what do you think ? Hmm, I'm not sure how that happened. I guess I must have hit undo and some point. I called the style "noBold..." but didn't set the fontWeight. Feel free to make the changes. If you don't, I will on Friday. Are you still going to keep your vote at -1 until I have time to solve all of your mustella issues? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi, I just committed a fix for the DateChooser test header issue, unfortunately, -createImages refused to do its job, that means only 1 image has been regenerated instead of 2. So, the remaining failed tests on windows are: LangPacks/Japanese/tests/dateFieldTests JA_DateField_Dropdown_Japanese_Layout LangPacks/Japanese/tests/phoneNumberValidatorTests JA_PhoneNumberValidator_wrongLengthError components/Charts/Bubble/Properties/BubbleProperties BubbleSeries_multipleAxes_disabledDays Those tests failed are only few pixels comparation differences, that's not a blocker to me, at least not revelant enough for delaying the release again, otherwize, it would mean we delay the release to next week, what do you think guys ? -Fred -Message d'origine- From: Frédéric THOMAS Sent: Thursday, February 21, 2013 8:18 AM To: dev@flex.apache.org Subject: Re: [VOTE] Apache Flex 4.9.1 RC3 Hi Alex, I have a bit of time this morning to take care of the 2 issues relative to the DateChooser header style but that's it. Unfortunatly, I think I have neither the time nor the knowledge to deal with the other 2 remaining problems on windows. Are you still going to keep your vote at -1 until I have time to solve all of your mustella issues? If WE tolerate having 99.999% of tests passed and because those failed tests are only a few pixels differences, so, no stopper, I would go for a +1, for myself, I think, we can go for a release. -Fred -Message d'origine- From: Alex Harui Sent: Thursday, February 21, 2013 8:01 AM To: dev@flex.apache.org Subject: Re: [VOTE] Apache Flex 4.9.1 RC3 On 2/20/13 8:20 PM, "Frédéric THOMAS" wrote: It still happens besause of the headerStyleName of the DateChooser, I guess I should re-generate the images with that, what do you think ? Hmm, I'm not sure how that happened. I guess I must have hit undo and some point. I called the style "noBold..." but didn't set the fontWeight. Feel free to make the changes. If you don't, I will on Friday. Are you still going to keep your vote at -1 until I have time to solve all of your mustella issues? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
Do you think it is a bug in the tests or in the release source? You can also run against earlier release if you want to know if it is an inject. Sent via the PANTECH Discover, an AT&T 4G LTE smartphone. Frédéric THOMAS wrote: Hi, I just committed a fix for the DateChooser test header issue, unfortunately, -createImages refused to do its job, that means only 1 image has been regenerated instead of 2. So, the remaining failed tests on windows are: LangPacks/Japanese/tests/dateFieldTests JA_DateField_Dropdown_Japanese_Layout LangPacks/Japanese/tests/phoneNumberValidatorTests JA_PhoneNumberValidator_wrongLengthError components/Charts/Bubble/Properties/BubbleProperties BubbleSeries_multipleAxes_disabledDays Those tests failed are only few pixels comparation differences, that's not a blocker to me, at least not revelant enough for delaying the release again, otherwize, it would mean we delay the release to next week, what do you think guys ? -Fred -Message d'origine- From: Frédéric THOMAS Sent: Thursday, February 21, 2013 8:18 AM To: dev@flex.apache.org Subject: Re: [VOTE] Apache Flex 4.9.1 RC3 Hi Alex, I have a bit of time this morning to take care of the 2 issues relative to the DateChooser header style but that's it. Unfortunatly, I think I have neither the time nor the knowledge to deal with the other 2 remaining problems on windows. >Are you still going to keep your vote at -1 until I have time to solve all of your mustella issues? If WE tolerate having 99.999% of tests passed and because those failed tests are only a few pixels differences, so, no stopper, I would go for a +1, for myself, I think, we can go for a release. -Fred -Message d'origine- From: Alex Harui Sent: Thursday, February 21, 2013 8:01 AM To: dev@flex.apache.org Subject: Re: [VOTE] Apache Flex 4.9.1 RC3 On 2/20/13 8:20 PM, "Frédéric THOMAS" wrote: > It still happens besause of the headerStyleName of the DateChooser, I > guess > I should re-generate the images with that, what do you think ? Hmm, I'm not sure how that happened. I guess I must have hit undo and some point. I called the style "noBold..." but didn't set the fontWeight. Feel free to make the changes. If you don't, I will on Friday. Are you still going to keep your vote at -1 until I have time to solve all of your mustella issues? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi, > We decided that we will be using a more official directory path when > cutting releases [1], [2] As far as I can see nothing was decided. Justin
Re: [VOTE] Apache Flex 4.9.1 RC3
On Fri, Feb 22, 2013 at 3:45 PM, Justin Mclean wrote: > Hi, > > > We decided that we will be using a more official directory path when > > cutting releases [1], [2] > > As far as I can see nothing was decided. > > Justin > What is your proposal going forward? Om
Re: [VOTE] Apache Flex 4.9.1 RC3
On 2/22/13 3:47 PM, "Om" wrote: > On Fri, Feb 22, 2013 at 3:45 PM, Justin Mclean > wrote: > >> Hi, >> >>> We decided that we will be using a more official directory path when >>> cutting releases [1], [2] >> >> As far as I can see nothing was decided. >> >> Justin >> > > What is your proposal going forward? > What would it take to get the CI server to generate the RCs? Would there be any security risks around doing so? And what would its path look like? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi, >> As far as I can see nothing was decided. This point release is not meant to solve all issues, see if this issue can be resolved for 4.10? Justin
Re: [VOTE] Apache Flex 4.9.1 RC3
On Feb 22, 2013 5:07 PM, "Justin Mclean" wrote: > > Hi, > > >> As far as I can see nothing was decided. > This point release is not meant to solve all issues, see if this issue can be resolved for 4.10? > > Justin > I am cool with that. Thanks, Om
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi, > I am cool with that. Mind changing your vote? We don;t have enough +1 to release this yet and nothing to add to a RC4. Thanks, Justin
Re: [VOTE] Apache Flex 4.9.1 RC3
Let me get home and do some more testing first? Maybe in another 12 hours. Thanks, Om On Feb 24, 2013 2:36 PM, "Justin Mclean" wrote: > Hi, > > > I am cool with that. > > Mind changing your vote? We don;t have enough +1 to release this yet and > nothing to add to a RC4. > > Thanks, > Justin
Re: [VOTE] Apache Flex 4.9.1 RC3
Hi, > Let me get home and do some more testing first? Maybe in another 12 hours. More testing is always good. Thanks, Justin
Re: [VOTE] Apache Flex 4.9.1 RC3
On 2/24/13 2:35 PM, "Justin Mclean" wrote: > Hi, > >> I am cool with that. > > Mind changing your vote? We don;t have enough +1 to release this yet and > nothing to add to a RC4. You should have yourself, Nick and me at +1. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
I was planning to run the Mustella tests overnight. Let me know if you have enough votes dont need me to.. Om On Sun, Feb 24, 2013 at 8:24 PM, Alex Harui wrote: > > > > On 2/24/13 2:35 PM, "Justin Mclean" wrote: > > > Hi, > > > >> I am cool with that. > > > > Mind changing your vote? We don;t have enough +1 to release this yet and > > nothing to add to a RC4. > You should have yourself, Nick and me at +1. > > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui > >
Re: [VOTE] Apache Flex 4.9.1 RC3
On 2/24/13 9:17 PM, "Om" wrote: > I was planning to run the Mustella tests overnight. Let me know if you have > enough votes dont need me to.. > I think you are currently a -1. If we have enough +1's, do you still want your -1 in the official record or do you want to withdraw it or change to 0? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [VOTE] Apache Flex 4.9.1 RC3
I change my vote to +0 given that we agreed to fix the issue I raised in a future release. Thanks, Om On Sun, Feb 24, 2013 at 9:35 PM, Alex Harui wrote: > > > > On 2/24/13 9:17 PM, "Om" wrote: > > > I was planning to run the Mustella tests overnight. Let me know if you > have > > enough votes dont need me to.. > > > I think you are currently a -1. If we have enough +1's, do you still want > your -1 in the official record or do you want to withdraw it or change to > 0? > > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui > >
Re: [VOTE] Apache Flex 4.9.1 RC3
+1 so far it seems really cool On Feb 25, 2013 5:44 AM, "Om" wrote: > I change my vote to +0 given that we agreed to fix the issue I raised in a > future release. > > Thanks, > Om > > On Sun, Feb 24, 2013 at 9:35 PM, Alex Harui wrote: > > > > > > > > > On 2/24/13 9:17 PM, "Om" wrote: > > > > > I was planning to run the Mustella tests overnight. Let me know if you > > have > > > enough votes dont need me to.. > > > > > I think you are currently a -1. If we have enough +1's, do you still > want > > your -1 in the official record or do you want to withdraw it or change to > > 0? > > > > -- > > Alex Harui > > Flex SDK Team > > Adobe Systems, Inc. > > http://blogs.adobe.com/aharui > > > > >
Re: [VOTE] Apache Flex 4.9.1 RC3
+1 non-binding
