Re: [DISCUSS] Alternative way of posting FLIPs
Hi all, Thanks for all your input. If there's no other opinions in the next couple of days, then I'll update the documentation accordingly. Best regards, Martijn On Mon, Feb 12, 2024 at 4:51 AM Benchao Li wrote: > > +1 for option 1. Thanks Martijn for taking care of this, I've also > filed a issue[1] for the infra a few days ago, but haven't been > resolved yet. > > [1] https://issues.apache.org/jira/browse/INFRA-25451 > > Jane Chan 于2024年2月10日周六 14:33写道： > > > > +1 for option 1. > > > > Hi Yun, > > > > > I am concerned about whether we can view the history of design docs > > > > > > > If someone has editor permissions, they can also view the editing history > > of Google Docs[1]. If the change history of the design document is equally > > important, would it be possible to selectively share the editor link with > > the developers involved in the discussion for the FLIP? > > > > [1] > > https://support.google.com/docs/answer/190843?sjid=8405245178977557481-NC > > > > Best, > > Jane > > > > On Fri, Feb 9, 2024 at 5:33 PM Sergey Nuyanzin wrote: > > > > > +1 for option 1 > > > > > > On Fri, Feb 9, 2024 at 10:18 AM Jing Ge > > > wrote: > > > > > > > +1 for option 1. The Github discussions look more like an overlap to the > > > ML > > > > instead of a wiki tool like Confluence. > > > > > > > > Best regards, > > > > Jing > > > > > > > > On Fri, Feb 9, 2024 at 10:08 AM Yun Tang wrote: > > > > > > > > > For the first solution, I am concerned about whether we can view the > > > > > history of design docs, which is supported by Confluence wiki and > > > GitHub > > > > > discussions. From my understanding, even the discussion history could > > > let > > > > > others know the evolution of this feature and the history of a design > > > doc > > > > > is also really important. > > > > > > > > > > Best > > > > > Yun Tang > > > > > > > > > > From: Piotr Nowojski > > > > > Sent: Thursday, February 8, 2024 14:17 > > > > > To: dev@flink.apache.org > > > > > Subject: Re: [DISCUSS] Alternative way of posting FLIPs > > > > > > > > > > +1 for the first option as well > > > > > > > > > > Best, > > > > > Piotrek > > > > > > > > > > śr., 7 lut 2024 o 16:48 Matthias Pohl > > > > > napisał(a): > > > > > > > > > > > +1 for option 1 since it's a reasonable temporary workaround > > > > > > > > > > > > Moving to GitHub discussions would either mean moving the current > > > FLIP > > > > > > collection or having the FLIPs in two locations. Both options do not > > > > seem > > > > > > to be optimal. Another concern I had was that GitHub Discussions > > > > wouldn't > > > > > > allow integrating diagrams that easily. But it looks like they > > > support > > > > > > Mermaid [1] for diagrams. > > > > > > > > > > > > One flaw of the GoogleDocs approach is, though, that we have to rely > > > on > > > > > > diagrams being provided as PNG/JPG/SVG rather than draw.io diagrams. > > > > > > draw.io > > > > > > is more tightly integrated with the Confluence wiki which allows > > > > > > editing/updating diagrams in the wiki rather than using some > > > > > > external > > > > > tool. > > > > > > Google Draw is also not that convenient to use in my opinion. > > > > > > Anyway, > > > > > > that's a minor issue, I guess. > > > > > > > > > > > > Matthias > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams > > > > > > > > > > > > On Wed, Feb 7, 2024 at 3:30 PM Lincoln Lee > > > > > wrote: > > > > > > > > > > > > > Thanks Martijn moving this forward! > > > > > > > > > > > > > > +1 for the first solution, because as of now it looks like this is > > > a > > > > > > > temporary solution and we're still looking forward to the > > > improvement > > > > > by > > > > > > > ASF Infra, when the access is ok for contributors, we can back to > > > the > > > > > > > current workflow. > > > > > > > > > > > > > > For solution 2, one visible downside is that it becomes > > > inconvenient > > > > to > > > > > > > look for flips (unless we permanently switch to github > > > > > > > discussion). > > > > > > > > > > > > > > Looking forward to hearing more thoughts. > > > > > > > > > > > > > > Best, > > > > > > > Lincoln Lee > > > > > > > > > > > > > > > > > > > > > Martijn Visser 于2024年2月7日周三 21:51写道： > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > ASF Infra has confirmed to me that only ASF committers can > > > > > > > > access > > > > the > > > > > > > > ASF Confluence site since a recent change. One of the results of > > > > this > > > > > > > > decision is that users can't signup and access Confluence, so > > > only > > > > > > > > committers+ can create FLIPs. > > > > > > > > > > > > > > > > ASF Infra hopes to improve this situation when they move to the > > > > Cloud > > > > > > > > shortly (as in: some months), but they haven't committed on an > > > > actual > > > > > >
[jira] [Created] (FLINK-34446) regression: alias is not in lateral join
Jing Ge created FLINK-34446:
---
Summary: regression: alias is not in lateral join
Key: FLINK-34446
URL: https://issues.apache.org/jira/browse/FLINK-34446
Project: Flink
Issue Type: Bug
Reporter: Jing Ge
found one regression issue. Query working Flink 1.17.2, but failing with Flink
1.18.+
{code:java}
-- Query working Flink 1.17.2, but failing with Flink 1.18.+
-- -- [ERROR] Could not execute SQL statement. Reason:
-- -- org.apache.calcite.sql.validate.SqlValidatorException: Table 's' not found
SELECT
a_or_b,
id,
splits
FROM sample as s ,
LATERAL TABLE(split(s.id,'[01]')) lt(splits)
CROSS JOIN (VALUES ('A'), ('B')) AS cj(a_or_b); {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [VOTE] FLIP-418: Show data skew score on Flink Dashboard
Thanks for driving thie Emre, +1 (binding) Thanks, Danny. On Mon, Feb 12, 2024 at 9:42 PM Hong Liang wrote: > +1 (binding) > > Thank you for driving this Emre! This is a good step towards better user > experience when diagnosing performance issues with Flink jobs. > > Best, > Hong > > On Wed, Jan 31, 2024 at 3:00 AM Aleksandr Pilipenko > wrote: > > > Thanks for the FLIP! > > > > +1 (non-binding) > > > > Best, > > Aleksandr > > > > On Mon, 29 Jan 2024 at 10:11, Kartoglu, Emre > > > wrote: > > > > > Hello, > > > > > > I'd like to call votes on FLIP-418: Show data skew score on Flink > > > Dashboard. > > > > > > FLIP: > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-418%3A+Show+data+skew+score+on+Flink+Dashboard > > > Discussion: > > > https://lists.apache.org/thread/m5ockoork0h2zr78h77dcrn71rbt35ql > > > > > > Kind regards, > > > Emre > > > > > > > > >
[jira] [Created] (FLINK-34447) ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime still fails on slow machines
Matthias Pohl created FLINK-34447:
-
Summary:
ActiveResourceManagerTest#testWorkerRegistrationTimeoutNotCountingAllocationTime
still fails on slow machines
Key: FLINK-34447
URL: https://issues.apache.org/jira/browse/FLINK-34447
Project: Flink
Issue Type: Technical Debt
Components: Runtime / Coordination
Affects Versions: 1.18.1, 1.19.0, 1.20.0
Reporter: Matthias Pohl
This appeared in this [PR CI
run|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=57529&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=7997]
of FLINK-34427.
{code}
Feb 14 18:50:01 18:50:01.283 [ERROR] Tests run: 18, Failures: 1, Errors: 0,
Skipped: 0, Time elapsed: 0.665 s <<< FAILURE! -- in
org.apache.flink.runtime.resourcemanager.active.ActiveResourceManagerTest
Feb 14 18:50:01 18:50:01.283 [ERROR]
org.apache.flink.runtime.resourcemanager.active.ActiveResourceManagerTest.testWorkerRegistrationTimeoutNotCountingAllocationTime
-- Time elapsed: 0.197 s <<< FAILURE!
Feb 14 18:50:01 java.lang.AssertionError:
Feb 14 18:50:01
Feb 14 18:50:01 Expecting
Feb 14 18:50:01
Feb 14 18:50:01 not to be done.
Feb 14 18:50:01 Be aware that the state of the future in this message might not
reflect the one at the time when the assertion was performed as it is evaluated
later on
Feb 14 18:50:01 at
org.apache.flink.runtime.resourcemanager.active.ActiveResourceManagerTest$15.lambda$new$3(ActiveResourceManagerTest.java:982)
Feb 14 18:50:01 at
org.apache.flink.runtime.resourcemanager.active.ActiveResourceManagerTest$Context.runTest(ActiveResourceManagerTest.java:1133)
Feb 14 18:50:01 at
org.apache.flink.runtime.resourcemanager.active.ActiveResourceManagerTest$15.(ActiveResourceManagerTest.java:963)
Feb 14 18:50:01 at
org.apache.flink.runtime.resourcemanager.active.ActiveResourceManagerTest.testWorkerRegistrationTimeoutNotCountingAllocationTime(ActiveResourceManagerTest.java:946)
Feb 14 18:50:01 at java.lang.reflect.Method.invoke(Method.java:498)
Feb 14 18:50:01 at
java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
Feb 14 18:50:01 at
java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
Feb 14 18:50:01 at
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
Feb 14 18:50:01 at
java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
Feb 14 18:50:01 at
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
{code}
But I was able to reproduce it locally as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [VOTE] FLIP-418: Show data skew score on Flink Dashboard
+1(binding) Thanks for driving this proposal! Best, Rui On Thu, 15 Feb 2024 at 17:47, Danny Cranmer wrote: > Thanks for driving thie Emre, > > +1 (binding) > > Thanks, > Danny. > > On Mon, Feb 12, 2024 at 9:42 PM Hong Liang wrote: > > > +1 (binding) > > > > Thank you for driving this Emre! This is a good step towards better user > > experience when diagnosing performance issues with Flink jobs. > > > > Best, > > Hong > > > > On Wed, Jan 31, 2024 at 3:00 AM Aleksandr Pilipenko > > wrote: > > > > > Thanks for the FLIP! > > > > > > +1 (non-binding) > > > > > > Best, > > > Aleksandr > > > > > > On Mon, 29 Jan 2024 at 10:11, Kartoglu, Emre > > > > > > wrote: > > > > > > > Hello, > > > > > > > > I'd like to call votes on FLIP-418: Show data skew score on Flink > > > > Dashboard. > > > > > > > > FLIP: > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-418%3A+Show+data+skew+score+on+Flink+Dashboard > > > > Discussion: > > > > https://lists.apache.org/thread/m5ockoork0h2zr78h77dcrn71rbt35ql > > > > > > > > Kind regards, > > > > Emre > > > > > > > > > > > > > >
Re: [VOTE] FLIP-418: Show data skew score on Flink Dashboard
+1(non-binding) Best, Yuepeng. At 2024-02-15 19:13:21, "Rui Fan" <1996fan...@gmail.com> wrote: >+1(binding) > >Thanks for driving this proposal! > >Best, >Rui > >On Thu, 15 Feb 2024 at 17:47, Danny Cranmer wrote: > >> Thanks for driving thie Emre, >> >> +1 (binding) >> >> Thanks, >> Danny. >> >> On Mon, Feb 12, 2024 at 9:42 PM Hong Liang wrote: >> >> > +1 (binding) >> > >> > Thank you for driving this Emre! This is a good step towards better user >> > experience when diagnosing performance issues with Flink jobs. >> > >> > Best, >> > Hong >> > >> > On Wed, Jan 31, 2024 at 3:00 AM Aleksandr Pilipenko >> > wrote: >> > >> > > Thanks for the FLIP! >> > > >> > > +1 (non-binding) >> > > >> > > Best, >> > > Aleksandr >> > > >> > > On Mon, 29 Jan 2024 at 10:11, Kartoglu, Emre >> > > > >> > > wrote: >> > > >> > > > Hello, >> > > > >> > > > I'd like to call votes on FLIP-418: Show data skew score on Flink >> > > > Dashboard. >> > > > >> > > > FLIP: >> > > > >> > > >> > >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-418%3A+Show+data+skew+score+on+Flink+Dashboard >> > > > Discussion: >> > > > https://lists.apache.org/thread/m5ockoork0h2zr78h77dcrn71rbt35ql >> > > > >> > > > Kind regards, >> > > > Emre >> > > > >> > > > >> > > >> > >>
Re: [VOTE] Release flink-connector-parent, release candidate #1
Hi, Considering that the code and artifact have note changed since last vote (only source release and tag have changed) and considering that there were already 3 binding votes for this RC1, I'll do this on a lazy consensus. I'll release if no one objects until tomorrow as it will be 72h since last change. Best Etienne Le 13/02/2024 à 13:24, Etienne Chauchot a écrit : Hi all, I fixed the source release [1] as requested, it no more contains tools/release/shared directory. I found out why it contained that directory, it was because parent_pom branch was referring to an incorrect sub-module mount point for release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3). And by the way I noticed that all the connectors source releases were containing an empty tools/releasing directory because only tools/releasing/shared is excluded in the source release script and not the whole tools/releasing directory. It seems a bit messy to me so I think we should fix that in the release scripts later on for next connectors releases. I also found out that the RC1 tag was pointing to my fork instead of the main repo so I remade the tag (4) Apart of that, the code and artifact have not changed so I did not invalidate the RC1. Please confirm that I can proceed to the release. Best Etienne [1] https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/ [2] https://issues.apache.org/jira/browse/FLINK-34364 [3] https://github.com/apache/flink-connector-shared-utils/pull/36 [4] https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1 Le 05/02/2024 à 12:36, Etienne Chauchot a écrit : Hi, I just got back from vacations. I'll close the vote thread and proceed to the release later this week. Here is the ticket: https://issues.apache.org/jira/browse/FLINK-34364 Best Etienne Le 04/02/2024 à 05:06, Qingsheng Ren a écrit : +1 (binding) - Verified checksum and signature - Verified pom content - Built flink-connector-kafka from source with the parent pom in staging Best, Qingsheng On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler wrote: - checked source/maven pom contents Please file a ticket to exclude tools/release from the source release. +1 (binding) On 29/01/2024 15:59, Maximilian Michels wrote: - Inspected the source for licenses and corresponding headers - Checksums and signature OK +1 (binding) On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot wrote: Hi everyone, Please review and vote on the release candidate #1 for the version 1.1.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the official Apache source release to be deployed to dist.apache.org [2], which are signed with the key with fingerprint D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3], * all artifacts to be deployed to the Maven Central Repository [4], * source code tag v1.1.0-rc1 [5], * website pull request listing the new release [6] * confluence wiki: connector parent upgrade to version 1.1.0 that will be validated after the artifact is released (there is no PR mechanism on the wiki) [7] The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes. Thanks, Etienne [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353442 [2] https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1 [3]https://dist.apache.org/repos/dist/release/flink/KEYS [4] https://repository.apache.org/content/repositories/orgapacheflink-1698/ [5] https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1 [6]https://github.com/apache/flink-web/pull/717 [7] https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development
Re: [VOTE] Release flink-connector-parent, release candidate #1
Hi Etienne, > I fixed the source release [1] as requested, it no more contains > tools/release/shared directory. I don't think that is the correct way: my understanding is that this invalidates basically all the votes, because now the checked artifact has changed. It was requested to file a ticket as a follow-up, not to immediately change the binary. We can't have a lazy consensus on a release topic, with a changed artifact. Best regards, Martijn On Thu, Feb 15, 2024 at 2:32 PM Etienne Chauchot wrote: > > Hi, > > Considering that the code and artifact have note changed since last vote > (only source release and tag have changed) and considering that there > were already 3 binding votes for this RC1, I'll do this on a lazy > consensus. I'll release if no one objects until tomorrow as it will be > 72h since last change. > > Best > > Etienne > > Le 13/02/2024 à 13:24, Etienne Chauchot a écrit : > > > > Hi all, > > > > I fixed the source release [1] as requested, it no more contains > > tools/release/shared directory. > > > > I found out why it contained that directory, it was because parent_pom > > branch was referring to an incorrect sub-module mount point for > > release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3). > > > > And by the way I noticed that all the connectors source releases were > > containing an empty tools/releasing directory because only > > tools/releasing/shared is excluded in the source release script and > > not the whole tools/releasing directory. It seems a bit messy to me so > > I think we should fix that in the release scripts later on for next > > connectors releases. > > > > I also found out that the RC1 tag was pointing to my fork instead of > > the main repo so I remade the tag (4) > > > > Apart of that, the code and artifact have not changed so I did not > > invalidate the RC1. > > > > Please confirm that I can proceed to the release. > > > > Best > > > > Etienne > > > > [1] > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/ > > > > [2] https://issues.apache.org/jira/browse/FLINK-34364 > > > > [3] https://github.com/apache/flink-connector-shared-utils/pull/36 > > > > [4] > > https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1 > > > > > > Le 05/02/2024 à 12:36, Etienne Chauchot a écrit : > >> > >> Hi, > >> > >> I just got back from vacations. I'll close the vote thread and > >> proceed to the release later this week. > >> > >> Here is the ticket: https://issues.apache.org/jira/browse/FLINK-34364 > >> > >> Best > >> > >> Etienne > >> > >> Le 04/02/2024 à 05:06, Qingsheng Ren a écrit : > >>> +1 (binding) > >>> > >>> - Verified checksum and signature > >>> - Verified pom content > >>> - Built flink-connector-kafka from source with the parent pom in staging > >>> > >>> Best, > >>> Qingsheng > >>> > >>> On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler > >>> wrote: > >>> > - checked source/maven pom contents > > Please file a ticket to exclude tools/release from the source release. > > +1 (binding) > > On 29/01/2024 15:59, Maximilian Michels wrote: > > - Inspected the source for licenses and corresponding headers > > - Checksums and signature OK > > > > +1 (binding) > > > > On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot > wrote: > >> Hi everyone, > >> > >> Please review and vote on the release candidate #1 for the version > >> 1.1.0, as follows: > >> > >> [ ] +1, Approve the release > >> [ ] -1, Do not approve the release (please provide specific comments) > >> > >> The complete staging area is available for your review, which includes: > >> * JIRA release notes [1], > >> * the official Apache source release to be deployed to dist.apache.org > >> [2], which are signed with the key with fingerprint > >> D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3], > >> * all artifacts to be deployed to the Maven Central Repository [4], > >> * source code tag v1.1.0-rc1 [5], > >> * website pull request listing the new release [6] > >> > >> * confluence wiki: connector parent upgrade to version 1.1.0 that will > >> be validated after the artifact is released (there is no PR mechanism > >> on > >> the wiki) [7] > >> > >> The vote will be open for at least 72 hours. It is adopted by majority > >> approval, with at least 3 PMC affirmative votes. > >> > >> Thanks, > >> > >> Etienne > >> > >> [1] > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353442 > >> [2] > >> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1 > >> [3]https://dist.apache.org/repos/dist/release/flink/KEYS > >> [4] > https://repository.apache.org/content/repositories/orgapacheflink-1698/ > >> [5] > >> > https://github.com/apache/flink-connector-shared-util
Re: [VOTE] Release flink-connector-parent, release candidate #1
Martijn is correct in that if the source release got changed we need to
vet everything again.
If anything else had been changed instead there'd be a bit of leeway but
the source release itself is the most important bit of a release and we
just can't allow changes to that after the fact and still allow votes to
count.
As for the change itself, it's good that the shared directory is now
excluded, but we still have a de-facto empty tools directory.
That's ultimately the (really minor) issue I was referring to that I'd
like to see resolved /eventually/, because an empty directory in a
source release is just a bit confusing ("Is the release missing
something?").
On 15/02/2024 17:27, Martijn Visser wrote:
Hi Etienne,
I fixed the source release [1] as requested, it no more contains
tools/release/shared directory.
I don't think that is the correct way: my understanding is that this
invalidates basically all the votes, because now the checked artifact
has changed. It was requested to file a ticket as a follow-up, not to
immediately change the binary. We can't have a lazy consensus on a
release topic, with a changed artifact.
Best regards,
Martijn
On Thu, Feb 15, 2024 at 2:32 PM Etienne Chauchot wrote:
Hi,
Considering that the code and artifact have note changed since last vote
(only source release and tag have changed) and considering that there
were already 3 binding votes for this RC1, I'll do this on a lazy
consensus. I'll release if no one objects until tomorrow as it will be
72h since last change.
Best
Etienne
Le 13/02/2024 à 13:24, Etienne Chauchot a écrit :
Hi all,
I fixed the source release [1] as requested, it no more contains
tools/release/shared directory.
I found out why it contained that directory, it was because parent_pom
branch was referring to an incorrect sub-module mount point for
release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3).
And by the way I noticed that all the connectors source releases were
containing an empty tools/releasing directory because only
tools/releasing/shared is excluded in the source release script and
not the whole tools/releasing directory. It seems a bit messy to me so
I think we should fix that in the release scripts later on for next
connectors releases.
I also found out that the RC1 tag was pointing to my fork instead of
the main repo so I remade the tag (4)
Apart of that, the code and artifact have not changed so I did not
invalidate the RC1.
Please confirm that I can proceed to the release.
Best
Etienne
[1]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/
[2]https://issues.apache.org/jira/browse/FLINK-34364
[3]https://github.com/apache/flink-connector-shared-utils/pull/36
[4]
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1
Le 05/02/2024 à 12:36, Etienne Chauchot a écrit :
Hi,
I just got back from vacations. I'll close the vote thread and
proceed to the release later this week.
Here is the ticket:https://issues.apache.org/jira/browse/FLINK-34364
Best
Etienne
Le 04/02/2024 à 05:06, Qingsheng Ren a écrit :
+1 (binding)
- Verified checksum and signature
- Verified pom content
- Built flink-connector-kafka from source with the parent pom in staging
Best,
Qingsheng
On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler wrote:
- checked source/maven pom contents
Please file a ticket to exclude tools/release from the source release.
+1 (binding)
On 29/01/2024 15:59, Maximilian Michels wrote:
- Inspected the source for licenses and corresponding headers
- Checksums and signature OK
+1 (binding)
On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot
wrote:
Hi everyone,
Please review and vote on the release candidate #1 for the version
1.1.0, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v1.1.0-rc1 [5],
* website pull request listing the new release [6]
* confluence wiki: connector parent upgrade to version 1.1.0 that will
be validated after the artifact is released (there is no PR mechanism on
the wiki) [7]
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Etienne
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353442
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1
[3]https://dist.apache.org/repos/dist/release/flink/KEYS
[4]
https://repository.apache.org/content/repositories/orgapacheflink-1698/
[5]
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0
RE: [VOTE] FLIP-418: Show data skew score on Flink Dashboard
Thanks all, this vote is now closed. I will announce the results on a separate thread. On 2024/01/29 10:09:10 "Kartoglu, Emre" wrote: > Hello, > > I'd like to call votes on FLIP-418: Show data skew score on Flink Dashboard. > > FLIP: > https://cwiki.apache.org/confluence/display/FLINK/FLIP-418%3A+Show+data+skew+score+on+Flink+Dashboard > Discussion: https://lists.apache.org/thread/m5ockoork0h2zr78h77dcrn71rbt35ql > > Kind regards, > Emre > >
[RESULT] [VOTE] FLIP-418: Show data skew score on Flink Dashboard
I am happy to announce that “FLIP-418: Show data skew score on Flink Dashboard” has been accepted with Consensus. FLIP: https://cwiki.apache.org/confluence/display/FLINK/FLIP-418%3A+Show+data+skew+score+on+Flink+Dashboard Votes: * Aleksandr Pilipenko +1 (non-binding) * Danny Cranmer +1 (binding) * Hong Liang +1 (binding) * Rui Fan +1 (binding) * Yuepeng Pan +1 (non-binding) There are no disapproving votes. Thanks all! Emre
Re: [DISCUSS] Externalized Google Cloud Connectors
Hi Alexander, Thanks so much for the info! It sounds like the best path forward is for us to develop outside of Apache while, in parallel, working to gain committer status. Our goal will be to eventually move anything we build under the Apache umbrella once we're more plugged in to the community. As for migrating the existing Pub/Sub connector to the new Source API, we actually have somebody currently building a new Pub/Sub connector from scratch (using the new Source API). Once that is ready, we will make sure to get that new implementation moved under Apache and help with the migration effort. Thanks again for the response and I'm sure we will be chatting soon! Best, Claire On Wed, Feb 14, 2024 at 7:36 AM Alexander Fedulov < alexander.fedu...@gmail.com> wrote: > Hi Claire, > > Thanks for reaching out. It's great that there is interest from Google > in spearheading the development of the respective Flink connectors. > > As of now,there is only one GCP-specific connector developed directly as > part > of ASF Flink, namely the Pub/Sub one. It has already been externalized here > [1]. > Grouping further connectors under apache/flink-connectors-gcp makes sense, > but > it would be nice to first understand which GCP connectors you plan to add > before we create this new umbrella project. > > I do not think establishing a dedicated workgroup to help with the > GCP-specific > development is a realistic goal, though. The development will most probably > take > place on the regular ASF best effort basis (which involves mailing list > discussions, > reaching out to people for reviews, etc.) until your developers gain > committer status > and can work more independently. > > One immediate open item where the Flink community would definitely > appreciate your > help is with the migration of the existing Pub/Sub connector to the new > Source API. > As you can see here [2], it is one of the two remaining connectors where we > have not > yet made progress, and it seems like a great place to start the > collaboration. > Flink 2.0 aims to remove the SourceFunction API, which the current Pub/Sub > connector > relies on. It would be great if your colleagues could assist with this > effort [3]. > > Best, > Alexander Fedulov > > [1] https://github.com/apache/flink-connector-gcp-pubsub > [2] https://issues.apache.org/jira/browse/FLINK-28045 > [3] https://issues.apache.org/jira/browse/FLINK-32673 > > > > On Tue, 13 Feb 2024 at 17:25, Claire McCarthy > wrote: > > > Hi Devs! > > > > I’d like to kick off a discussion on setting up a repo for a new fleet of > > Google Cloud connectors. > > > > A bit of context: > > > >- > > > >We have a team of Google engineers who are looking to build/maintain > >5-10 GCP connectors for Flink. > >- > > > >We are wondering if it would make sense to host our connectors under > the > >ASF umbrella following a similar repo structure as AWS ( > >https://github.com/apache/flink-connector-aws). In our case: > >apache/flink-connectors-gcp. > >- > > > >Currently, we have no Flink committers on our team. We are actively > >involved in the Apache Beam community and have a number of ASF members > > on > >the team. > > > > > > We saw that one of the original motivations for externalizing connectors > > was to encourage more activity and contributions around connectors by > > easing the contribution overhead. We understand that the decision was > > ultimately made to host the externalized connector repos under the ASF > > organization. For the same reasons (release infra, quality assurance, > > integration with the community, etc.), we would like all GCP connectors > to > > live under the ASF organization. > > > > We want to ask the Flink community what you all think of this idea, and > > what would be the best way for us to go about contributing something like > > this. We are excited to contribute and want to learn and follow your > > practices. > > > > A specific issue we know of is that our changes need approval from Flink > > committers. Do you have a suggestion for how best to go about a new > > contribution like ours from a team that does not have committers? Is it > > possible, for example, to partner with a committer (or a small cohort) > for > > tight engagement? We also know about ASF voting and release process, but > > that doesn't seem to be as much of a potential hurdle. > > > > Huge thanks in advance for sharing your thoughts! > > > > > > Claire > > >
[jira] [Created] (FLINK-34448) ChangelogLocalRecoveryITCase failed fatally with 127 exit code
Matthias Pohl created FLINK-34448:
-
Summary: ChangelogLocalRecoveryITCase failed fatally with 127 exit
code
Key: FLINK-34448
URL: https://issues.apache.org/jira/browse/FLINK-34448
Project: Flink
Issue Type: Bug
Components: Runtime / Coordination
Affects Versions: 1.20.0
Reporter: Matthias Pohl
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=57550&view=logs&j=2c3cbe13-dee0-5837-cf47-3053da9a8a78&t=b78d9d30-509a-5cea-1fef-db7abaa325ae&l=8897
\
{code}
Feb 16 02:43:47 02:43:47.142 [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.2.2:test (integration-tests)
on project flink-tests:
Feb 16 02:43:47 02:43:47.142 [ERROR]
Feb 16 02:43:47 02:43:47.142 [ERROR] Please refer to
/__w/1/s/flink-tests/target/surefire-reports for the individual test results.
Feb 16 02:43:47 02:43:47.142 [ERROR] Please refer to dump files (if any exist)
[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
Feb 16 02:43:47 02:43:47.142 [ERROR] ExecutionException The forked VM
terminated without properly saying goodbye. VM crash or System.exit called?
Feb 16 02:43:47 02:43:47.142 [ERROR] Command was /bin/sh -c cd
'/__w/1/s/flink-tests' && '/usr/lib/jvm/jdk-11.0.19+7/bin/java' '-XX:+UseG1GC'
'-Xms256m' '-XX:+IgnoreUnrecognizedVMOptions'
'--add-opens=java.base/java.util=ALL-UNNAMED'
'--add-opens=java.base/java.io=ALL-UNNAMED' '-Xmx1536m' '-jar'
'/__w/1/s/flink-tests/target/surefire/surefirebooter-20240216015747138_560.jar'
'/__w/1/s/flink-tests/target/surefire' '2024-02-16T01-57-43_286-jvmRun4'
'surefire-20240216015747138_558tmp' 'surefire_185-20240216015747138_559tmp'
Feb 16 02:43:47 02:43:47.142 [ERROR] Error occurred in starting fork, check
output in log
Feb 16 02:43:47 02:43:47.142 [ERROR] Process Exit Code: 127
Feb 16 02:43:47 02:43:47.142 [ERROR] Crashed tests:
Feb 16 02:43:47 02:43:47.142 [ERROR]
org.apache.flink.test.checkpointing.ChangelogLocalRecoveryITCase
Feb 16 02:43:47 02:43:47.142 [ERROR]
org.apache.maven.surefire.booter.SurefireBooterForkException:
ExecutionException The forked VM terminated without properly saying goodbye. VM
crash or System.exit called?
Feb 16 02:43:47 02:43:47.142 [ERROR] Command was /bin/sh -c cd
'/__w/1/s/flink-tests' && '/usr/lib/jvm/jdk-11.0.19+7/bin/java' '-XX:+UseG1GC'
'-Xms256m' '-XX:+IgnoreUnrecognizedVMOptions'
'--add-opens=java.base/java.util=ALL-UNNAMED'
'--add-opens=java.base/java.io=ALL-UNNAMED' '-Xmx1536m' '-jar'
'/__w/1/s/flink-tests/target/surefire/surefirebooter-20240216015747138_560.jar'
'/__w/1/s/flink-tests/target/surefire' '2024-02-16T01-57-43_286-jvmRun4'
'surefire-20240216015747138_558tmp' 'surefire_185-20240216015747138_559tmp'
Feb 16 02:43:47 02:43:47.142 [ERROR] Error occurred in starting fork, check
output in log
Feb 16 02:43:47 02:43:47.142 [ERROR] Process Exit Code: 127
Feb 16 02:43:47 02:43:47.142 [ERROR] Crashed tests:
Feb 16 02:43:47 02:43:47.142 [ERROR]
org.apache.flink.test.checkpointing.ChangelogLocalRecoveryITCase
Feb 16 02:43:47 02:43:47.142 [ERROR]at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:456)
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
