Re: [DISCUSS] FLINK-35369: Improve `Table API and SQL` page or add new page to guide new users to right Flink SQL option

2024-05-16 Thread Martijn Visser
Hi Keith Lee,

Yeah, I think it makes sense that large changes to documentation should be
FLIP worthy. We've done it before when we reorganized the project website
as well.

>From a strict point of view, we can't retrospectively change an accepted
FLIP: we can create a new FLIP that refers to the old one. I would do that.

Best regards,

Martijn

On Thu, May 16, 2024 at 11:13 PM Keith Lee 
wrote:

> Hi Martijn
>
> Thank you for pointing me to this FLIP. I initially thought of making
> limited scoped improvement hence the Jira.
>
> Given that the Flip was voted on more than four years ago. Would it make
> sense to for me to update the FLIP, reopen discussion and redrive a vote
> for it?
>
> On a side note, should FLIP criteria [1] be updated so that reorganisation
> of public documentation fall under it as well?
>
> Best regards
>
> Keith Lee
>
> [1]
>
> https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=65145551#FlinkImprovementProposals-Whatisconsidereda%22majorchange%22thatneedsaFLIP
> ?
>
>
> On Thu, 16 May 2024 at 13:03, Martijn Visser 
> wrote:
>
> > Hi Keith Lee,
> >
> > There is actually an open and accepted FLIP [1] that was just never
> > implemented. I think that needs to be taken into account as well, since
> it
> > was voted on. I think it also makes more sense to have a proposal as a
> > FLIP, instead of under a Jira.
> >
> > Best regards,
> >
> > Martijn
> >
> > [1]
> > https://cwiki.apache.org/confluence/pages/view
> page.action?pageId=127405685
> > <
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=127405685
> >
> >
> > On Wed, May 15, 2024 at 10:58 PM Keith Lee 
> > wrote:
> >
> > > Hello everyone,
> > >
> > > I'd like to start a discussion on improving `Table API and SQL`
> overview
> > > page or add a new page to give new users quick overview of options
> > > available. I've opted for improvement Jira instead of a FLIP as the
> > change
> > > does not affect public interfaces or Flink runtime.
> > >
> > > https://issues.apache.org/jira/browse/FLINK-35369
> > >
> > > Appreciate your thoughts and suggestions.
> > >
> > > Best regards
> > > Keith Lee
> > >
> >
>


Re: [DISCUSS] FLINK-35369: Improve `Table API and SQL` page or add new page to guide new users to right Flink SQL option

2024-05-16 Thread Keith Lee
Hi Martijn

Thank you for pointing me to this FLIP. I initially thought of making
limited scoped improvement hence the Jira.

Given that the Flip was voted on more than four years ago. Would it make
sense to for me to update the FLIP, reopen discussion and redrive a vote
for it?

On a side note, should FLIP criteria [1] be updated so that reorganisation
of public documentation fall under it as well?

Best regards

Keith Lee

[1]
https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=65145551#FlinkImprovementProposals-Whatisconsidereda%22majorchange%22thatneedsaFLIP?


On Thu, 16 May 2024 at 13:03, Martijn Visser 
wrote:

> Hi Keith Lee,
>
> There is actually an open and accepted FLIP [1] that was just never
> implemented. I think that needs to be taken into account as well, since it
> was voted on. I think it also makes more sense to have a proposal as a
> FLIP, instead of under a Jira.
>
> Best regards,
>
> Martijn
>
> [1]
> https://cwiki.apache.org/confluence/pages/view page.action?pageId=127405685
> 
>
> On Wed, May 15, 2024 at 10:58 PM Keith Lee 
> wrote:
>
> > Hello everyone,
> >
> > I'd like to start a discussion on improving `Table API and SQL` overview
> > page or add a new page to give new users quick overview of options
> > available. I've opted for improvement Jira instead of a FLIP as the
> change
> > does not affect public interfaces or Flink runtime.
> >
> > https://issues.apache.org/jira/browse/FLINK-35369
> >
> > Appreciate your thoughts and suggestions.
> >
> > Best regards
> > Keith Lee
> >
>


Re: [DISCUSS] FLINK-35369: Improve `Table API and SQL` page or add new page to guide new users to right Flink SQL option

2024-05-16 Thread Martijn Visser
Hi Keith Lee,

There is actually an open and accepted FLIP [1] that was just never
implemented. I think that needs to be taken into account as well, since it
was voted on. I think it also makes more sense to have a proposal as a
FLIP, instead of under a Jira.

Best regards,

Martijn

[1]
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=127405685

On Wed, May 15, 2024 at 10:58 PM Keith Lee 
wrote:

> Hello everyone,
>
> I'd like to start a discussion on improving `Table API and SQL` overview
> page or add a new page to give new users quick overview of options
> available. I've opted for improvement Jira instead of a FLIP as the change
> does not affect public interfaces or Flink runtime.
>
> https://issues.apache.org/jira/browse/FLINK-35369
>
> Appreciate your thoughts and suggestions.
>
> Best regards
> Keith Lee
>


[DISCUSS] FLINK-35369: Improve `Table API and SQL` page or add new page to guide new users to right Flink SQL option

2024-05-15 Thread Keith Lee
Hello everyone,

I'd like to start a discussion on improving `Table API and SQL` overview
page or add a new page to give new users quick overview of options
available. I've opted for improvement Jira instead of a FLIP as the change
does not affect public interfaces or Flink runtime.

https://issues.apache.org/jira/browse/FLINK-35369

Appreciate your thoughts and suggestions.

Best regards
Keith Lee