Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi, since there are no more comments for a while, if there are no more comments for another day, I will start a vote thread. Thanks, Ferenc On Thursday, March 14th, 2024 at 11:20, Ferenc Csaky wrote: > > > Hi, > > Gentle ping to see if there are any other concerns or things that seems > missing from the FLIP. > > Best, > Ferenc > > > > > On Monday, March 11th, 2024 at 11:11, Ferenc Csaky ferenc.cs...@pm.me.INVALID > wrote: > > > Hi Jing, > > > > Thank you for your comments! Updated the FLIP with reasoning on the > > proposed release versions and included them in the headline "Release" field. > > > > Best, > > Ferenc > > > > On Sunday, March 10th, 2024 at 16:59, Jing Ge j...@ververica.com.INVALID > > wrote: > > > > > Hi Ferenc, > > > > > > Thanks for the proposal! +1 for it! > > > > > > Similar to what Leonard mentioned. I would suggest: > > > 1. Use the "release" to define the release version of the Kudu connector > > > itself. > > > 2. Optionally, add one more row underneath to describe which Flink > > > versions > > > this release will be compatible with, e.g. 1.17, 1.18. I think it makes > > > sense to support at least two last Flink releases. An example could be > > > found at [1] > > > > > > Best regards, > > > Jing > > > > > > [1] https://lists.apache.org/thread/jcjfy3fgpg5cdnb9noslq2c77h0gtcwp > > > > > > On Sun, Mar 10, 2024 at 3:46 PM Yanquan Lv decq12y...@gmail.com wrote: > > > > > > > Hi Ferenc, +1 for this FLIP. > > > > > > > > Ferenc Csaky ferenc.cs...@pm.me.invalid 于2024年3月9日周六 01:49写道： > > > > > > > > > Thank you Jeyhun, Leonard, and Hang for your comments! Let me > > > > > address them from earliest to latest. > > > > > > > > > > > How do you plan the review process in this case (e.g. incremental > > > > > > over existing codebase or cumulative all at once) ? > > > > > > > > > > I think incremental would be less time consuming and complex for > > > > > reviewers so I would leaning towards that direction. I would > > > > > imagine multiple subtasks for migrating the existing code, and > > > > > updating the deprecated interfaces, so those should be separate PRs > > > > > and > > > > > the release can be initiated when everything is merged. > > > > > > > > > > > (1) About the release version, could you specify kudu connector > > > > > > version > > > > > > instead of flink version 1.18 as external connector version is > > > > > > different > > > > > > with flink? > > > > > > (2) About the connector config options, could you enumerate these > > > > > > options so that we can review they’re reasonable or not? > > > > > > > > > > I added these to the FLIP, copied the current configs options as is, > > > > > PTAL. > > > > > > > > > > > (3) Metrics is also key part of connector, could you add the > > > > > > supported > > > > > > connector metrics to public interface as well? > > > > > > > > > > The current Bahir conenctor code does not include any metrics and I > > > > > did > > > > > not plan to include them into the scope of this FLIP. > > > > > > > > > > > I think that how to state this code originally lived in Bahir may > > > > > > be in > > > > > > the > > > > > > FLIP. > > > > > > > > > > I might miss your point, but the FLIP contains this: "Migrating the > > > > > current code keeping the history and noting it explicitly it was > > > > > forked > > > > > from the Bahir repository [2]." Pls. share if you meant something > > > > > else. > > > > > > > > > > Best, > > > > > Ferenc > > > > > > > > > > On Friday, March 8th, 2024 at 10:42, Hang Ruan ruanhang1...@gmail.com > > > > > wrote: > > > > > > > > > > > Hi, Ferenc. > > > > > > > > > > > > Thanks for the FLIP discussion. +1 for the proposal. > > > > > > I think that how to state this code originally lived in Bahir may > > > > > > be in > > > > > > the > > > > > > FLIP. > > > > > > > > > > > > Best, > > > > > > Hang > > > > > > > > > > > > Leonard Xu xbjt...@gmail.com 于2024年3月7日周四 14:14写道： > > > > > > > > > > > > > Thanks Ferenc for kicking off this discussion, I left some > > > > > > > comments > > > > > > > here: > > > > > > > > > > > > > > (1) About the release version, could you specify kudu connector > > > > > > > version > > > > > > > instead of flink version 1.18 as external connector version is > > > > > > > different > > > > > > > with flink ? > > > > > > > > > > > > > > (2) About the connector config options, could you enumerate these > > > > > > > options > > > > > > > so that we can review they’re reasonable or not? > > > > > > > > > > > > > > (3) Metrics is also key part of connector, could you add the > > > > > > > supported > > > > > > > connector metrics to public interface as well? > > > > > > > > > > > > > > Best, > > > > > > > Leonard > > > > > > > > > > > > > > > 2024年3月6日 下午11:23，Ferenc Csaky ferenc.cs...@pm.me.INVALID 写道： > > > > > > > > > > > > > > > > Hello devs, > > > > > > > > > > > > > > > > Opening this thread to discuss a FLIP [1] about
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi, Gentle ping to see if there are any other concerns or things that seems missing from the FLIP. Best, Ferenc On Monday, March 11th, 2024 at 11:11, Ferenc Csaky wrote: > > > Hi Jing, > > Thank you for your comments! Updated the FLIP with reasoning on the proposed > release versions and included them in the headline "Release" field. > > Best, > Ferenc > > > > > On Sunday, March 10th, 2024 at 16:59, Jing Ge j...@ververica.com.INVALID > wrote: > > > Hi Ferenc, > > > > Thanks for the proposal! +1 for it! > > > > Similar to what Leonard mentioned. I would suggest: > > 1. Use the "release" to define the release version of the Kudu connector > > itself. > > 2. Optionally, add one more row underneath to describe which Flink versions > > this release will be compatible with, e.g. 1.17, 1.18. I think it makes > > sense to support at least two last Flink releases. An example could be > > found at [1] > > > > Best regards, > > Jing > > > > [1] https://lists.apache.org/thread/jcjfy3fgpg5cdnb9noslq2c77h0gtcwp > > > > On Sun, Mar 10, 2024 at 3:46 PM Yanquan Lv decq12y...@gmail.com wrote: > > > > > Hi Ferenc, +1 for this FLIP. > > > > > > Ferenc Csaky ferenc.cs...@pm.me.invalid 于2024年3月9日周六 01:49写道： > > > > > > > Thank you Jeyhun, Leonard, and Hang for your comments! Let me > > > > address them from earliest to latest. > > > > > > > > > How do you plan the review process in this case (e.g. incremental > > > > > over existing codebase or cumulative all at once) ? > > > > > > > > I think incremental would be less time consuming and complex for > > > > reviewers so I would leaning towards that direction. I would > > > > imagine multiple subtasks for migrating the existing code, and > > > > updating the deprecated interfaces, so those should be separate PRs and > > > > the release can be initiated when everything is merged. > > > > > > > > > (1) About the release version, could you specify kudu connector > > > > > version > > > > > instead of flink version 1.18 as external connector version is > > > > > different > > > > > with flink? > > > > > (2) About the connector config options, could you enumerate these > > > > > options so that we can review they’re reasonable or not? > > > > > > > > I added these to the FLIP, copied the current configs options as is, > > > > PTAL. > > > > > > > > > (3) Metrics is also key part of connector, could you add the supported > > > > > connector metrics to public interface as well? > > > > > > > > The current Bahir conenctor code does not include any metrics and I did > > > > not plan to include them into the scope of this FLIP. > > > > > > > > > I think that how to state this code originally lived in Bahir may be > > > > > in > > > > > the > > > > > FLIP. > > > > > > > > I might miss your point, but the FLIP contains this: "Migrating the > > > > current code keeping the history and noting it explicitly it was forked > > > > from the Bahir repository [2]." Pls. share if you meant something else. > > > > > > > > Best, > > > > Ferenc > > > > > > > > On Friday, March 8th, 2024 at 10:42, Hang Ruan ruanhang1...@gmail.com > > > > wrote: > > > > > > > > > Hi, Ferenc. > > > > > > > > > > Thanks for the FLIP discussion. +1 for the proposal. > > > > > I think that how to state this code originally lived in Bahir may be > > > > > in > > > > > the > > > > > FLIP. > > > > > > > > > > Best, > > > > > Hang > > > > > > > > > > Leonard Xu xbjt...@gmail.com 于2024年3月7日周四 14:14写道： > > > > > > > > > > > Thanks Ferenc for kicking off this discussion, I left some comments > > > > > > here: > > > > > > > > > > > > (1) About the release version, could you specify kudu connector > > > > > > version > > > > > > instead of flink version 1.18 as external connector version is > > > > > > different > > > > > > with flink ? > > > > > > > > > > > > (2) About the connector config options, could you enumerate these > > > > > > options > > > > > > so that we can review they’re reasonable or not? > > > > > > > > > > > > (3) Metrics is also key part of connector, could you add the > > > > > > supported > > > > > > connector metrics to public interface as well? > > > > > > > > > > > > Best, > > > > > > Leonard > > > > > > > > > > > > > 2024年3月6日 下午11:23，Ferenc Csaky ferenc.cs...@pm.me.INVALID 写道： > > > > > > > > > > > > > > Hello devs, > > > > > > > > > > > > > > Opening this thread to discuss a FLIP [1] about externalizing the > > > > > > > Kudu > > > > > > > connector, as recently > > > > > > > the Apache Bahir project were moved to the attic [2]. Some details > > > > > > > were > > > > > > > discussed already > > > > > > > in another thread [3]. I am proposing to externalize this > > > > > > > connector > > > > > > > and > > > > > > > keep it maintainable, > > > > > > > and up to date. > > > > > > > > > > > > > > Best regards, > > > > > > > Ferenc > > > > > > > > > > > > > > [1] > > > > > >
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi Jing, Thank you for your comments! Updated the FLIP with reasoning on the proposed release versions and included them in the headline "Release" field. Best, Ferenc On Sunday, March 10th, 2024 at 16:59, Jing Ge wrote: > > > Hi Ferenc, > > Thanks for the proposal! +1 for it! > > Similar to what Leonard mentioned. I would suggest: > 1. Use the "release" to define the release version of the Kudu connector > itself. > 2. Optionally, add one more row underneath to describe which Flink versions > this release will be compatible with, e.g. 1.17, 1.18. I think it makes > sense to support at least two last Flink releases. An example could be > found at [1] > > Best regards, > Jing > > [1] https://lists.apache.org/thread/jcjfy3fgpg5cdnb9noslq2c77h0gtcwp > > On Sun, Mar 10, 2024 at 3:46 PM Yanquan Lv decq12y...@gmail.com wrote: > > > Hi Ferenc, +1 for this FLIP. > > > > Ferenc Csaky ferenc.cs...@pm.me.invalid 于2024年3月9日周六 01:49写道： > > > > > Thank you Jeyhun, Leonard, and Hang for your comments! Let me > > > address them from earliest to latest. > > > > > > > How do you plan the review process in this case (e.g. incremental > > > > over existing codebase or cumulative all at once) ? > > > > > > I think incremental would be less time consuming and complex for > > > reviewers so I would leaning towards that direction. I would > > > imagine multiple subtasks for migrating the existing code, and > > > updating the deprecated interfaces, so those should be separate PRs and > > > the release can be initiated when everything is merged. > > > > > > > (1) About the release version, could you specify kudu connector version > > > > instead of flink version 1.18 as external connector version is different > > > > with flink? > > > > (2) About the connector config options, could you enumerate these > > > > options so that we can review they’re reasonable or not? > > > > > > I added these to the FLIP, copied the current configs options as is, > > > PTAL. > > > > > > > (3) Metrics is also key part of connector, could you add the supported > > > > connector metrics to public interface as well? > > > > > > The current Bahir conenctor code does not include any metrics and I did > > > not plan to include them into the scope of this FLIP. > > > > > > > I think that how to state this code originally lived in Bahir may be in > > > > the > > > > FLIP. > > > > > > I might miss your point, but the FLIP contains this: "Migrating the > > > current code keeping the history and noting it explicitly it was forked > > > from the Bahir repository [2]." Pls. share if you meant something else. > > > > > > Best, > > > Ferenc > > > > > > On Friday, March 8th, 2024 at 10:42, Hang Ruan ruanhang1...@gmail.com > > > wrote: > > > > > > > Hi, Ferenc. > > > > > > > > Thanks for the FLIP discussion. +1 for the proposal. > > > > I think that how to state this code originally lived in Bahir may be in > > > > the > > > > FLIP. > > > > > > > > Best, > > > > Hang > > > > > > > > Leonard Xu xbjt...@gmail.com 于2024年3月7日周四 14:14写道： > > > > > > > > > Thanks Ferenc for kicking off this discussion, I left some comments > > > > > here: > > > > > > > > > > (1) About the release version, could you specify kudu connector > > > > > version > > > > > instead of flink version 1.18 as external connector version is > > > > > different > > > > > with flink ? > > > > > > > > > > (2) About the connector config options, could you enumerate these > > > > > options > > > > > so that we can review they’re reasonable or not? > > > > > > > > > > (3) Metrics is also key part of connector, could you add the > > > > > supported > > > > > connector metrics to public interface as well? > > > > > > > > > > Best, > > > > > Leonard > > > > > > > > > > > 2024年3月6日 下午11:23，Ferenc Csaky ferenc.cs...@pm.me.INVALID 写道： > > > > > > > > > > > > Hello devs, > > > > > > > > > > > > Opening this thread to discuss a FLIP [1] about externalizing the > > > > > > Kudu > > > > > > connector, as recently > > > > > > the Apache Bahir project were moved to the attic [2]. Some details > > > > > > were > > > > > > discussed already > > > > > > in another thread [3]. I am proposing to externalize this connector > > > > > > and > > > > > > keep it maintainable, > > > > > > and up to date. > > > > > > > > > > > > Best regards, > > > > > > Ferenc > > > > > > > > > > > > [1] > > > > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > > > > > > > > [2] https://bahir.apache.org/ > > > > > > [3] > > > > > > https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi Ferenc, Thanks for the proposal! +1 for it! Similar to what Leonard mentioned. I would suggest: 1. Use the "release" to define the release version of the Kudu connector itself. 2. Optionally, add one more row underneath to describe which Flink versions this release will be compatible with, e.g. 1.17, 1.18. I think it makes sense to support at least two last Flink releases. An example could be found at [1] Best regards, Jing [1] https://lists.apache.org/thread/jcjfy3fgpg5cdnb9noslq2c77h0gtcwp On Sun, Mar 10, 2024 at 3:46 PM Yanquan Lv wrote: > Hi Ferenc, +1 for this FLIP. > > Ferenc Csaky 于2024年3月9日周六 01:49写道： > > > Thank you Jeyhun, Leonard, and Hang for your comments! Let me > > address them from earliest to latest. > > > > > How do you plan the review process in this case (e.g. incremental > > over existing codebase or cumulative all at once) ? > > > > I think incremental would be less time consuming and complex for > > reviewers so I would leaning towards that direction. I would > > imagine multiple subtasks for migrating the existing code, and > > updating the deprecated interfaces, so those should be separate PRs and > > the release can be initiated when everything is merged. > > > > > (1) About the release version, could you specify kudu connector version > > instead of flink version 1.18 as external connector version is different > > with flink? > > > (2) About the connector config options, could you enumerate these > > options so that we can review they’re reasonable or not? > > > > I added these to the FLIP, copied the current configs options as is, > PTAL. > > > > > (3) Metrics is also key part of connector, could you add the supported > > connector metrics to public interface as well? > > > > The current Bahir conenctor code does not include any metrics and I did > > not plan to include them into the scope of this FLIP. > > > > > I think that how to state this code originally lived in Bahir may be in > > the > > FLIP. > > > > I might miss your point, but the FLIP contains this: "Migrating the > > current code keeping the history and noting it explicitly it was forked > > from the Bahir repository [2]." Pls. share if you meant something else. > > > > Best, > > Ferenc > > > > > > > > On Friday, March 8th, 2024 at 10:42, Hang Ruan > > wrote: > > > > > > > > > > > Hi, Ferenc. > > > > > > Thanks for the FLIP discussion. +1 for the proposal. > > > I think that how to state this code originally lived in Bahir may be in > > the > > > FLIP. > > > > > > Best, > > > Hang > > > > > > Leonard Xu xbjt...@gmail.com 于2024年3月7日周四 14:14写道： > > > > > > > Thanks Ferenc for kicking off this discussion, I left some comments > > here: > > > > > > > > (1) About the release version, could you specify kudu connector > version > > > > instead of flink version 1.18 as external connector version is > > different > > > > with flink ? > > > > > > > > (2) About the connector config options, could you enumerate these > > options > > > > so that we can review they’re reasonable or not? > > > > > > > > (3) Metrics is also key part of connector, could you add the > supported > > > > connector metrics to public interface as well? > > > > > > > > Best, > > > > Leonard > > > > > > > > > 2024年3月6日 下午11:23，Ferenc Csaky ferenc.cs...@pm.me.INVALID 写道： > > > > > > > > > > Hello devs, > > > > > > > > > > Opening this thread to discuss a FLIP [1] about externalizing the > > Kudu > > > > > connector, as recently > > > > > the Apache Bahir project were moved to the attic [2]. Some details > > were > > > > > discussed already > > > > > in another thread [3]. I am proposing to externalize this connector > > and > > > > > keep it maintainable, > > > > > and up to date. > > > > > > > > > > Best regards, > > > > > Ferenc > > > > > > > > > > [1] > > > > > > > > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > > > > > [2] https://bahir.apache.org/ > > > > > [3] > https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq > > >
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi Ferenc, +1 for this FLIP. Ferenc Csaky 于2024年3月9日周六 01:49写道： > Thank you Jeyhun, Leonard, and Hang for your comments! Let me > address them from earliest to latest. > > > How do you plan the review process in this case (e.g. incremental > over existing codebase or cumulative all at once) ? > > I think incremental would be less time consuming and complex for > reviewers so I would leaning towards that direction. I would > imagine multiple subtasks for migrating the existing code, and > updating the deprecated interfaces, so those should be separate PRs and > the release can be initiated when everything is merged. > > > (1) About the release version, could you specify kudu connector version > instead of flink version 1.18 as external connector version is different > with flink? > > (2) About the connector config options, could you enumerate these > options so that we can review they’re reasonable or not? > > I added these to the FLIP, copied the current configs options as is, PTAL. > > > (3) Metrics is also key part of connector, could you add the supported > connector metrics to public interface as well? > > The current Bahir conenctor code does not include any metrics and I did > not plan to include them into the scope of this FLIP. > > > I think that how to state this code originally lived in Bahir may be in > the > FLIP. > > I might miss your point, but the FLIP contains this: "Migrating the > current code keeping the history and noting it explicitly it was forked > from the Bahir repository [2]." Pls. share if you meant something else. > > Best, > Ferenc > > > > On Friday, March 8th, 2024 at 10:42, Hang Ruan > wrote: > > > > > > > Hi, Ferenc. > > > > Thanks for the FLIP discussion. +1 for the proposal. > > I think that how to state this code originally lived in Bahir may be in > the > > FLIP. > > > > Best, > > Hang > > > > Leonard Xu xbjt...@gmail.com 于2024年3月7日周四 14:14写道： > > > > > Thanks Ferenc for kicking off this discussion, I left some comments > here: > > > > > > (1) About the release version, could you specify kudu connector version > > > instead of flink version 1.18 as external connector version is > different > > > with flink ? > > > > > > (2) About the connector config options, could you enumerate these > options > > > so that we can review they’re reasonable or not? > > > > > > (3) Metrics is also key part of connector, could you add the supported > > > connector metrics to public interface as well? > > > > > > Best, > > > Leonard > > > > > > > 2024年3月6日 下午11:23，Ferenc Csaky ferenc.cs...@pm.me.INVALID 写道： > > > > > > > > Hello devs, > > > > > > > > Opening this thread to discuss a FLIP [1] about externalizing the > Kudu > > > > connector, as recently > > > > the Apache Bahir project were moved to the attic [2]. Some details > were > > > > discussed already > > > > in another thread [3]. I am proposing to externalize this connector > and > > > > keep it maintainable, > > > > and up to date. > > > > > > > > Best regards, > > > > Ferenc > > > > > > > > [1] > > > > > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > > > > [2] https://bahir.apache.org/ > > > > [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq >
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Thank you Jeyhun, Leonard, and Hang for your comments! Let me address them from earliest to latest. > How do you plan the review process in this case (e.g. incremental over existing codebase or cumulative all at once) ? I think incremental would be less time consuming and complex for reviewers so I would leaning towards that direction. I would imagine multiple subtasks for migrating the existing code, and updating the deprecated interfaces, so those should be separate PRs and the release can be initiated when everything is merged. > (1) About the release version, could you specify kudu connector version > instead of flink version 1.18 as external connector version is different with > flink? > (2) About the connector config options, could you enumerate these options so > that we can review they’re reasonable or not? I added these to the FLIP, copied the current configs options as is, PTAL. > (3) Metrics is also key part of connector, could you add the supported > connector metrics to public interface as well? The current Bahir conenctor code does not include any metrics and I did not plan to include them into the scope of this FLIP. > I think that how to state this code originally lived in Bahir may be in the FLIP. I might miss your point, but the FLIP contains this: "Migrating the current code keeping the history and noting it explicitly it was forked from the Bahir repository [2]." Pls. share if you meant something else. Best, Ferenc On Friday, March 8th, 2024 at 10:42, Hang Ruan wrote: > > > Hi, Ferenc. > > Thanks for the FLIP discussion. +1 for the proposal. > I think that how to state this code originally lived in Bahir may be in the > FLIP. > > Best, > Hang > > Leonard Xu xbjt...@gmail.com 于2024年3月7日周四 14:14写道： > > > Thanks Ferenc for kicking off this discussion, I left some comments here: > > > > (1) About the release version, could you specify kudu connector version > > instead of flink version 1.18 as external connector version is different > > with flink ? > > > > (2) About the connector config options, could you enumerate these options > > so that we can review they’re reasonable or not? > > > > (3) Metrics is also key part of connector, could you add the supported > > connector metrics to public interface as well? > > > > Best, > > Leonard > > > > > 2024年3月6日 下午11:23，Ferenc Csaky ferenc.cs...@pm.me.INVALID 写道： > > > > > > Hello devs, > > > > > > Opening this thread to discuss a FLIP [1] about externalizing the Kudu > > > connector, as recently > > > the Apache Bahir project were moved to the attic [2]. Some details were > > > discussed already > > > in another thread [3]. I am proposing to externalize this connector and > > > keep it maintainable, > > > and up to date. > > > > > > Best regards, > > > Ferenc > > > > > > [1] > > > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > > > [2] https://bahir.apache.org/ > > > [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi, Ferenc. Thanks for the FLIP discussion. +1 for the proposal. I think that how to state this code originally lived in Bahir may be in the FLIP. Best, Hang Leonard Xu 于2024年3月7日周四 14:14写道： > Thanks Ferenc for kicking off this discussion, I left some comments here: > > (1) About the release version, could you specify kudu connector version > instead of flink version 1.18 as external connector version is different > with flink ? > > (2) About the connector config options, could you enumerate these options > so that we can review they’re reasonable or not? > > (3) Metrics is also key part of connector, could you add the supported > connector metrics to public interface as well? > > > Best, > Leonard > > > > 2024年3月6日 下午11:23，Ferenc Csaky 写道： > > > > Hello devs, > > > > Opening this thread to discuss a FLIP [1] about externalizing the Kudu > connector, as recently > > the Apache Bahir project were moved to the attic [2]. Some details were > discussed already > > in another thread [3]. I am proposing to externalize this connector and > keep it maintainable, > > and up to date. > > > > Best regards, > > Ferenc > > > > [1] > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > > [2] https://bahir.apache.org/ > > [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq > >
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Thanks Ferenc for kicking off this discussion, I left some comments here: (1) About the release version, could you specify kudu connector version instead of flink version 1.18 as external connector version is different with flink ? (2) About the connector config options, could you enumerate these options so that we can review they’re reasonable or not? (3) Metrics is also key part of connector, could you add the supported connector metrics to public interface as well? Best, Leonard > 2024年3月6日 下午11:23，Ferenc Csaky 写道： > > Hello devs, > > Opening this thread to discuss a FLIP [1] about externalizing the Kudu > connector, as recently > the Apache Bahir project were moved to the attic [2]. Some details were > discussed already > in another thread [3]. I am proposing to externalize this connector and keep > it maintainable, > and up to date. > > Best regards, > Ferenc > > [1] > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > [2] https://bahir.apache.org/ > [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi Ferenc, +1 for the FLIP. One minor comment. As part of the externalization process, the DataStream connector > implementation can be updated to the new Source/Sink APIs - How do you plan the review process in this case (e.g. incremental over existing codebase or cumulative all at once) ? Regards, Jeyhun On Wed, Mar 6, 2024 at 4:28 PM Márton Balassi wrote: > Hi Feri, > > +1. Thanks for initiating this, the FLIP proposal looks good to me. > > On Wed, Mar 6, 2024 at 4:24 PM Ferenc Csaky > wrote: > > > Hello devs, > > > > Opening this thread to discuss a FLIP [1] about externalizing the Kudu > > connector, as recently > > the Apache Bahir project were moved to the attic [2]. Some details were > > discussed already > > in another thread [3]. I am proposing to externalize this connector and > > keep it maintainable, > > and up to date. > > > > Best regards, > > Ferenc > > > > [1] > > > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > > [2] https://bahir.apache.org/ > > [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq >
Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hi Feri, +1. Thanks for initiating this, the FLIP proposal looks good to me. On Wed, Mar 6, 2024 at 4:24 PM Ferenc Csaky wrote: > Hello devs, > > Opening this thread to discuss a FLIP [1] about externalizing the Kudu > connector, as recently > the Apache Bahir project were moved to the attic [2]. Some details were > discussed already > in another thread [3]. I am proposing to externalize this connector and > keep it maintainable, > and up to date. > > Best regards, > Ferenc > > [1] > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > [2] https://bahir.apache.org/ > [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq
[DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir
Hello devs, Opening this thread to discuss a FLIP [1] about externalizing the Kudu connector, as recently the Apache Bahir project were moved to the attic [2]. Some details were discussed already in another thread [3]. I am proposing to externalize this connector and keep it maintainable, and up to date. Best regards, Ferenc [1] https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE [2] https://bahir.apache.org/ [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq
