Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-16 Thread Etienne Chauchot

Hi,

OK. I thought that not changing the artifact did not require a new RC as 
the release doc says that "some changes" do not require RC invalidation 
(it is my first release :) ). Thanks.


I'll cancel this release vote and start a RC2 vote.

Regarding the empty tool directory, as mentioned below all the 
connectors (cassandra, kafka, pulsar, parent, ...) released so far have 
this empty directory in the source release which I find confusing as 
well as mentioned.


I'll take the opportunity of the connector-parent RC2 to exclude that 
directory from connector-parent and I'll do another hotfix PR to change 
the release script and exclude the whole tools directory instead of 
tools/releasing/shared as now. That way, with next release, all the 
connectors will have their source release cleaned.


Best

Etienne

Le 15/02/2024 à 17:41, Chesnay Schepler a écrit :
Martijn is correct in that if the source release got changed we need 
to vet everything again.
If anything else had been changed instead there'd be a bit of leeway 
but the source release itself is the most important bit of a release 
and we just can't allow changes to that after the fact and still allow 
votes to count.


As for the change itself, it's good that the shared directory is now 
excluded, but we still have a de-facto empty tools directory.
That's ultimately the (really minor) issue I was referring to that I'd 
like to see resolved /eventually/, because an empty directory in a 
source release is just a bit confusing ("Is the release missing 
something?").


On 15/02/2024 17:27, Martijn Visser wrote:

Hi Etienne,

I fixed the source release [1] as requested, it no more contains 
tools/release/shared directory.

I don't think that is the correct way: my understanding is that this
invalidates basically all the votes, because now the checked artifact
has changed. It was requested to file a ticket as a follow-up, not to
immediately change the binary. We can't have a lazy consensus on a
release topic, with a changed artifact.

Best regards,

Martijn

On Thu, Feb 15, 2024 at 2:32 PM Etienne 
Chauchot  wrote:

Hi,

Considering that the code and artifact have note changed since last 
vote

(only source release and tag have changed) and considering that there
were already 3 binding votes for this RC1, I'll do this on a lazy
consensus. I'll release if no one objects until tomorrow as it will be
72h since last change.

Best

Etienne

Le 13/02/2024 à 13:24, Etienne Chauchot a écrit :

Hi all,

I fixed the source release [1] as requested, it no more contains
tools/release/shared directory.

I found out why it contained that directory, it was because parent_pom
branch was referring to an incorrect sub-module mount point for
release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3).

And by the way I noticed that all the connectors source releases were
containing an empty tools/releasing directory because only
tools/releasing/shared is excluded in the source release script and
not the whole tools/releasing directory. It seems a bit messy to me so
I think we should fix that in the release scripts later on for next
connectors releases.

I also found out that the RC1 tag was pointing to my fork instead of
the main repo so I remade the tag (4)

Apart of that, the code and artifact have not changed so I did not
invalidate the RC1.

Please confirm that I can proceed to the release.

Best

Etienne

[1]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/ 



[2]https://issues.apache.org/jira/browse/FLINK-34364

[3]https://github.com/apache/flink-connector-shared-utils/pull/36

[4]
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1 




Le 05/02/2024 à 12:36, Etienne Chauchot a écrit :

Hi,

I just got back from vacations. I'll close the vote thread and
proceed to the release later this week.

Here is the ticket:https://issues.apache.org/jira/browse/FLINK-34364

Best

Etienne

Le 04/02/2024 à 05:06, Qingsheng Ren a écrit :

+1 (binding)

- Verified checksum and signature
- Verified pom content
- Built flink-connector-kafka from source with the parent pom in 
staging


Best,
Qingsheng

On Thu, Feb 1, 2024 at 11:19 PM Chesnay 
Schepler   wrote:



- checked source/maven pom contents

Please file a ticket to exclude tools/release from the source 
release.


+1 (binding)

On 29/01/2024 15:59, Maximilian Michels wrote:

- Inspected the source for licenses and corresponding headers
- Checksums and signature OK

+1 (binding)

On Tue, Jan 23, 2024 at 4:08 PM Etienne 
Chauchot

wrote:

Hi everyone,

Please review and vote on the release candidate #1 for the 
version

1.1.0, as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific 
comments)


The complete staging area is available for your review, which 
includes:

* JIRA release notes [1],
* the official Apache source release to be deployed to 
dist.apache.org

[2], which are signed with the key with 

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-15 Thread Chesnay Schepler
Martijn is correct in that if the source release got changed we need to 
vet everything again.
If anything else had been changed instead there'd be a bit of leeway but 
the source release itself is the most important bit of a release and we 
just can't allow changes to that after the fact and still allow votes to 
count.


As for the change itself, it's good that the shared directory is now 
excluded, but we still have a de-facto empty tools directory.
That's ultimately the (really minor) issue I was referring to that I'd 
like to see resolved /eventually/, because an empty directory in a 
source release is just a bit confusing ("Is the release missing 
something?").


On 15/02/2024 17:27, Martijn Visser wrote:

Hi Etienne,


I fixed the source release [1] as requested, it no more contains 
tools/release/shared directory.

I don't think that is the correct way: my understanding is that this
invalidates basically all the votes, because now the checked artifact
has changed. It was requested to file a ticket as a follow-up, not to
immediately change the binary. We can't have a lazy consensus on a
release topic, with a changed artifact.

Best regards,

Martijn

On Thu, Feb 15, 2024 at 2:32 PM Etienne Chauchot  wrote:

Hi,

Considering that the code and artifact have note changed since last vote
(only source release and tag have changed) and considering that there
were already 3 binding votes for this RC1, I'll do this on a lazy
consensus. I'll release if no one objects until tomorrow as it will be
72h since last change.

Best

Etienne

Le 13/02/2024 à 13:24, Etienne Chauchot a écrit :

Hi all,

I fixed the source release [1] as requested, it no more contains
tools/release/shared directory.

I found out why it contained that directory, it was because parent_pom
branch was referring to an incorrect sub-module mount point for
release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3).

And by the way I noticed that all the connectors source releases were
containing an empty tools/releasing directory because only
tools/releasing/shared is excluded in the source release script and
not the whole tools/releasing directory. It seems a bit messy to me so
I think we should fix that in the release scripts later on for next
connectors releases.

I also found out that the RC1 tag was pointing to my fork instead of
the main repo so I remade the tag (4)

Apart of that, the code and artifact have not changed so I did not
invalidate the RC1.

Please confirm that I can proceed to the release.

Best

Etienne

[1]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/

[2]https://issues.apache.org/jira/browse/FLINK-34364

[3]https://github.com/apache/flink-connector-shared-utils/pull/36

[4]
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1


Le 05/02/2024 à 12:36, Etienne Chauchot a écrit :

Hi,

I just got back from vacations. I'll close the vote thread and
proceed to the release later this week.

Here is the ticket:https://issues.apache.org/jira/browse/FLINK-34364

Best

Etienne

Le 04/02/2024 à 05:06, Qingsheng Ren a écrit :

+1 (binding)

- Verified checksum and signature
- Verified pom content
- Built flink-connector-kafka from source with the parent pom in staging

Best,
Qingsheng

On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler   wrote:


- checked source/maven pom contents

Please file a ticket to exclude tools/release from the source release.

+1 (binding)

On 29/01/2024 15:59, Maximilian Michels wrote:

- Inspected the source for licenses and corresponding headers
- Checksums and signature OK

+1 (binding)

On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot

wrote:

Hi everyone,

Please review and vote on the release candidate #1 for the version
1.1.0, as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v1.1.0-rc1 [5],
* website pull request listing the new release [6]

* confluence wiki: connector parent upgrade to version 1.1.0 that will
be validated after the artifact is released (there is no PR mechanism on
the wiki) [7]

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,

Etienne

[1]


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442

[2]


https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1

[3]https://dist.apache.org/repos/dist/release/flink/KEYS
[4]

https://repository.apache.org/content/repositories/orgapacheflink-1698/

[5]


https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1


Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-15 Thread Martijn Visser
Hi Etienne,

> I fixed the source release [1] as requested, it no more contains 
> tools/release/shared directory.

I don't think that is the correct way: my understanding is that this
invalidates basically all the votes, because now the checked artifact
has changed. It was requested to file a ticket as a follow-up, not to
immediately change the binary. We can't have a lazy consensus on a
release topic, with a changed artifact.

Best regards,

Martijn

On Thu, Feb 15, 2024 at 2:32 PM Etienne Chauchot  wrote:
>
> Hi,
>
> Considering that the code and artifact have note changed since last vote
> (only source release and tag have changed) and considering that there
> were already 3 binding votes for this RC1, I'll do this on a lazy
> consensus. I'll release if no one objects until tomorrow as it will be
> 72h since last change.
>
> Best
>
> Etienne
>
> Le 13/02/2024 à 13:24, Etienne Chauchot a écrit :
> >
> > Hi all,
> >
> > I fixed the source release [1] as requested, it no more contains
> > tools/release/shared directory.
> >
> > I found out why it contained that directory, it was because parent_pom
> > branch was referring to an incorrect sub-module mount point for
> > release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3).
> >
> > And by the way I noticed that all the connectors source releases were
> > containing an empty tools/releasing directory because only
> > tools/releasing/shared is excluded in the source release script and
> > not the whole tools/releasing directory. It seems a bit messy to me so
> > I think we should fix that in the release scripts later on for next
> > connectors releases.
> >
> > I also found out that the RC1 tag was pointing to my fork instead of
> > the main repo so I remade the tag (4)
> >
> > Apart of that, the code and artifact have not changed so I did not
> > invalidate the RC1.
> >
> > Please confirm that I can proceed to the release.
> >
> > Best
> >
> > Etienne
> >
> > [1]
> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/
> >
> > [2] https://issues.apache.org/jira/browse/FLINK-34364
> >
> > [3] https://github.com/apache/flink-connector-shared-utils/pull/36
> >
> > [4]
> > https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1
> >
> >
> > Le 05/02/2024 à 12:36, Etienne Chauchot a écrit :
> >>
> >> Hi,
> >>
> >> I just got back from vacations. I'll close the vote thread and
> >> proceed to the release later this week.
> >>
> >> Here is the ticket: https://issues.apache.org/jira/browse/FLINK-34364
> >>
> >> Best
> >>
> >> Etienne
> >>
> >> Le 04/02/2024 à 05:06, Qingsheng Ren a écrit :
> >>> +1 (binding)
> >>>
> >>> - Verified checksum and signature
> >>> - Verified pom content
> >>> - Built flink-connector-kafka from source with the parent pom in staging
> >>>
> >>> Best,
> >>> Qingsheng
> >>>
> >>> On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler  
> >>> wrote:
> >>>
>  - checked source/maven pom contents
> 
>  Please file a ticket to exclude tools/release from the source release.
> 
>  +1 (binding)
> 
>  On 29/01/2024 15:59, Maximilian Michels wrote:
> > - Inspected the source for licenses and corresponding headers
> > - Checksums and signature OK
> >
> > +1 (binding)
> >
> > On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot
>  wrote:
> >> Hi everyone,
> >>
> >> Please review and vote on the release candidate #1 for the version
> >> 1.1.0, as follows:
> >>
> >> [ ] +1, Approve the release
> >> [ ] -1, Do not approve the release (please provide specific comments)
> >>
> >> The complete staging area is available for your review, which includes:
> >> * JIRA release notes [1],
> >> * the official Apache source release to be deployed to dist.apache.org
> >> [2], which are signed with the key with fingerprint
> >> D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
> >> * all artifacts to be deployed to the Maven Central Repository [4],
> >> * source code tag v1.1.0-rc1 [5],
> >> * website pull request listing the new release [6]
> >>
> >> * confluence wiki: connector parent upgrade to version 1.1.0 that will
> >> be validated after the artifact is released (there is no PR mechanism 
> >> on
> >> the wiki) [7]
> >>
> >> The vote will be open for at least 72 hours. It is adopted by majority
> >> approval, with at least 3 PMC affirmative votes.
> >>
> >> Thanks,
> >>
> >> Etienne
> >>
> >> [1]
> >>
>  https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442
> >> [2]
> >>
>  https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1
> >> [3]https://dist.apache.org/repos/dist/release/flink/KEYS
> >> [4]
>  https://repository.apache.org/content/repositories/orgapacheflink-1698/
> >> [5]
> >>
>  

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-15 Thread Etienne Chauchot

Hi,

Considering that the code and artifact have note changed since last vote 
(only source release and tag have changed) and considering that there 
were already 3 binding votes for this RC1, I'll do this on a lazy 
consensus. I'll release if no one objects until tomorrow as it will be 
72h since last change.


Best

Etienne

Le 13/02/2024 à 13:24, Etienne Chauchot a écrit :


Hi all,

I fixed the source release [1] as requested, it no more contains 
tools/release/shared directory.


I found out why it contained that directory, it was because parent_pom 
branch was referring to an incorrect sub-module mount point for 
release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3).


And by the way I noticed that all the connectors source releases were 
containing an empty tools/releasing directory because only 
tools/releasing/shared is excluded in the source release script and 
not the whole tools/releasing directory. It seems a bit messy to me so 
I think we should fix that in the release scripts later on for next 
connectors releases.


I also found out that the RC1 tag was pointing to my fork instead of 
the main repo so I remade the tag (4)


Apart of that, the code and artifact have not changed so I did not 
invalidate the RC1.


Please confirm that I can proceed to the release.

Best

Etienne

[1] 
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/


[2] https://issues.apache.org/jira/browse/FLINK-34364

[3] https://github.com/apache/flink-connector-shared-utils/pull/36

[4] 
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1



Le 05/02/2024 à 12:36, Etienne Chauchot a écrit :


Hi,

I just got back from vacations. I'll close the vote thread and 
proceed to the release later this week.


Here is the ticket: https://issues.apache.org/jira/browse/FLINK-34364

Best

Etienne

Le 04/02/2024 à 05:06, Qingsheng Ren a écrit :

+1 (binding)

- Verified checksum and signature
- Verified pom content
- Built flink-connector-kafka from source with the parent pom in staging

Best,
Qingsheng

On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler  wrote:


- checked source/maven pom contents

Please file a ticket to exclude tools/release from the source release.

+1 (binding)

On 29/01/2024 15:59, Maximilian Michels wrote:

- Inspected the source for licenses and corresponding headers
- Checksums and signature OK

+1 (binding)

On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot

wrote:

Hi everyone,

Please review and vote on the release candidate #1 for the version
1.1.0, as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v1.1.0-rc1 [5],
* website pull request listing the new release [6]

* confluence wiki: connector parent upgrade to version 1.1.0 that will
be validated after the artifact is released (there is no PR mechanism on
the wiki) [7]

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,

Etienne

[1]


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442

[2]


https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1

[3]https://dist.apache.org/repos/dist/release/flink/KEYS
[4]

https://repository.apache.org/content/repositories/orgapacheflink-1698/

[5]


https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1

[6]https://github.com/apache/flink-web/pull/717

[7]


https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development



Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-13 Thread Etienne Chauchot

Hi all,

I fixed the source release [1] as requested, it no more contains 
tools/release/shared directory.


I found out why it contained that directory, it was because parent_pom 
branch was referring to an incorrect sub-module mount point for 
release_utils branch (cf FLINK-34364 [2]). Here is the fixing PR (3).


And by the way I noticed that all the connectors source releases were 
containing an empty tools/releasing directory because only 
tools/releasing/shared is excluded in the source release script and not 
the whole tools/releasing directory. It seems a bit messy to me so I 
think we should fix that in the release scripts later on for next 
connectors releases.


I also found out that the RC1 tag was pointing to my fork instead of the 
main repo so I remade the tag (4)


Apart of that, the code and artifact have not changed so I did not 
invalidate the RC1.


Please confirm that I can proceed to the release.

Best

Etienne

[1] 
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1/


[2] https://issues.apache.org/jira/browse/FLINK-34364

[3] https://github.com/apache/flink-connector-shared-utils/pull/36

[4] 
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1



Le 05/02/2024 à 12:36, Etienne Chauchot a écrit :


Hi,

I just got back from vacations. I'll close the vote thread and proceed 
to the release later this week.


Here is the ticket: https://issues.apache.org/jira/browse/FLINK-34364

Best

Etienne

Le 04/02/2024 à 05:06, Qingsheng Ren a écrit :

+1 (binding)

- Verified checksum and signature
- Verified pom content
- Built flink-connector-kafka from source with the parent pom in staging

Best,
Qingsheng

On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler  wrote:


- checked source/maven pom contents

Please file a ticket to exclude tools/release from the source release.

+1 (binding)

On 29/01/2024 15:59, Maximilian Michels wrote:

- Inspected the source for licenses and corresponding headers
- Checksums and signature OK

+1 (binding)

On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot

wrote:

Hi everyone,

Please review and vote on the release candidate #1 for the version
1.1.0, as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v1.1.0-rc1 [5],
* website pull request listing the new release [6]

* confluence wiki: connector parent upgrade to version 1.1.0 that will
be validated after the artifact is released (there is no PR mechanism on
the wiki) [7]

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,

Etienne

[1]


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442

[2]


https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1

[3]https://dist.apache.org/repos/dist/release/flink/KEYS
[4]

https://repository.apache.org/content/repositories/orgapacheflink-1698/

[5]


https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1

[6]https://github.com/apache/flink-web/pull/717

[7]


https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development



Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-05 Thread Etienne Chauchot

Hi,

I just got back from vacations. I'll close the vote thread and proceed 
to the release later this week.


Here is the ticket: https://issues.apache.org/jira/browse/FLINK-34364

Best

Etienne

Le 04/02/2024 à 05:06, Qingsheng Ren a écrit :

+1 (binding)

- Verified checksum and signature
- Verified pom content
- Built flink-connector-kafka from source with the parent pom in staging

Best,
Qingsheng

On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler  wrote:


- checked source/maven pom contents

Please file a ticket to exclude tools/release from the source release.

+1 (binding)

On 29/01/2024 15:59, Maximilian Michels wrote:

- Inspected the source for licenses and corresponding headers
- Checksums and signature OK

+1 (binding)

On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot

wrote:

Hi everyone,

Please review and vote on the release candidate #1 for the version
1.1.0, as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v1.1.0-rc1 [5],
* website pull request listing the new release [6]

* confluence wiki: connector parent upgrade to version 1.1.0 that will
be validated after the artifact is released (there is no PR mechanism on
the wiki) [7]

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,

Etienne

[1]


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442

[2]


https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1

[3]https://dist.apache.org/repos/dist/release/flink/KEYS
[4]

https://repository.apache.org/content/repositories/orgapacheflink-1698/

[5]


https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1

[6]https://github.com/apache/flink-web/pull/717

[7]


https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development



Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-03 Thread Qingsheng Ren
+1 (binding)

- Verified checksum and signature
- Verified pom content
- Built flink-connector-kafka from source with the parent pom in staging

Best,
Qingsheng

On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler  wrote:

> - checked source/maven pom contents
>
> Please file a ticket to exclude tools/release from the source release.
>
> +1 (binding)
>
> On 29/01/2024 15:59, Maximilian Michels wrote:
> > - Inspected the source for licenses and corresponding headers
> > - Checksums and signature OK
> >
> > +1 (binding)
> >
> > On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot 
> wrote:
> >> Hi everyone,
> >>
> >> Please review and vote on the release candidate #1 for the version
> >> 1.1.0, as follows:
> >>
> >> [ ] +1, Approve the release
> >> [ ] -1, Do not approve the release (please provide specific comments)
> >>
> >> The complete staging area is available for your review, which includes:
> >> * JIRA release notes [1],
> >> * the official Apache source release to be deployed to dist.apache.org
> >> [2], which are signed with the key with fingerprint
> >> D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
> >> * all artifacts to be deployed to the Maven Central Repository [4],
> >> * source code tag v1.1.0-rc1 [5],
> >> * website pull request listing the new release [6]
> >>
> >> * confluence wiki: connector parent upgrade to version 1.1.0 that will
> >> be validated after the artifact is released (there is no PR mechanism on
> >> the wiki) [7]
> >>
> >> The vote will be open for at least 72 hours. It is adopted by majority
> >> approval, with at least 3 PMC affirmative votes.
> >>
> >> Thanks,
> >>
> >> Etienne
> >>
> >> [1]
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442
> >> [2]
> >>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1
> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1698/
> >> [5]
> >>
> https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1
> >> [6] https://github.com/apache/flink-web/pull/717
> >>
> >> [7]
> >>
> https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development
>
>


Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-01 Thread Chesnay Schepler

- checked source/maven pom contents

Please file a ticket to exclude tools/release from the source release.

+1 (binding)

On 29/01/2024 15:59, Maximilian Michels wrote:

- Inspected the source for licenses and corresponding headers
- Checksums and signature OK

+1 (binding)

On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot  wrote:

Hi everyone,

Please review and vote on the release candidate #1 for the version
1.1.0, as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v1.1.0-rc1 [5],
* website pull request listing the new release [6]

* confluence wiki: connector parent upgrade to version 1.1.0 that will
be validated after the artifact is released (there is no PR mechanism on
the wiki) [7]

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,

Etienne

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1698/
[5]
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1
[6] https://github.com/apache/flink-web/pull/717

[7]
https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development




Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-01-29 Thread Maximilian Michels
- Inspected the source for licenses and corresponding headers
- Checksums and signature OK

+1 (binding)

On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot  wrote:
>
> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version
> 1.1.0, as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with fingerprint
> D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v1.1.0-rc1 [5],
> * website pull request listing the new release [6]
>
> * confluence wiki: connector parent upgrade to version 1.1.0 that will
> be validated after the artifact is released (there is no PR mechanism on
> the wiki) [7]
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
>
> Etienne
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1698/
> [5]
> https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1
> [6] https://github.com/apache/flink-web/pull/717
>
> [7]
> https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development


[VOTE] Release flink-connector-parent, release candidate #1

2024-01-23 Thread Etienne Chauchot

Hi everyone,

Please review and vote on the release candidate #1 for the version 
1.1.0, as follows:


[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org 
[2], which are signed with the key with fingerprint 
D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],

* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v1.1.0-rc1 [5],
* website pull request listing the new release [6]

* confluence wiki: connector parent upgrade to version 1.1.0 that will 
be validated after the artifact is released (there is no PR mechanism on 
the wiki) [7]


The vote will be open for at least 72 hours. It is adopted by majority 
approval, with at least 3 PMC affirmative votes.


Thanks,

Etienne

[1] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353442
[2] 
https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc1

[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1698/
[5] 
https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc1

[6] https://github.com/apache/flink-web/pull/717

[7] 
https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development