Re: Plugins with Java source are not being built (was Re: building a sample site with dispatcher fails)

2010-08-29 Thread Brian M Dube
On Tue, Aug 24, 2010 at 08:02:15PM -0700, Brian M Dube wrote:
 On Wed, Aug 04, 2010 at 08:48:31AM +0200, Vicent Mas wrote:
  Hi,
  
  while investigating the problems that I sent yesterday to this list
  (thread 'Unable to run forrest')
  and due to the long time I've been without using forrest I decided to
  start with the simplest task
  i.e. build a sample site using $ forrest seed. It works fine if I
  don't use dispatcher, but when I
  activated the dispatcher in the forrest.properties file I got an
  Internal Server Error page in my browser:
 
 Plugins with Java source are not currently being built due to r951789.
 
 With that change reverted and everything else current, it works for
 me. The change in r951789 was to fix some errors with forrestbot, but
 the context of the problem is now lost on me; so I don't know the
 appropriate solution.

See r990630 [1].

I approached the solution from the other side. Instead of trying to
detect the use of Java from the parent build file, plugins that have
Java source files need to declare this in their build file. The
functionality is the same as the publish property.

I've included FIXME notes where the requires-java property was added
because a few custom Ant tasks may simplify the entire system.

Brian

[1] http://svn.apache.org/viewvc?view=revisionrevision=990630


Re: Plugins with Java source are not being built (was Re: building a sample site with dispatcher fails)

2010-08-25 Thread Vicent Mas
2010/8/25 Brian M Dube bd...@apache.org:
 On Wed, Aug 04, 2010 at 08:48:31AM +0200, Vicent Mas wrote:
 Hi,

 while investigating the problems that I sent yesterday to this list
 (thread 'Unable to run forrest')
 and due to the long time I've been without using forrest I decided to
 start with the simplest task
 i.e. build a sample site using $ forrest seed. It works fine if I
 don't use dispatcher, but when I
 activated the dispatcher in the forrest.properties file I got an
 Internal Server Error page in my browser:

 Plugins with Java source are not currently being built due to r951789.

 With that change reverted and everything else current, it works for
 me. The change in r951789 was to fix some errors with forrestbot, but
 the context of the problem is now lost on me; so I don't know the
 appropriate solution.

 Brian



Hi,

your suggestion works for me. Finally I can use the dispatcher
so I will come back to my real website and try to fix/tune it.

THANKS A LOT :-)

-- 
Share what you know, learn what you don't.


Plugins with Java source are not being built (was Re: building a sample site with dispatcher fails)

2010-08-24 Thread Brian M Dube
On Wed, Aug 04, 2010 at 08:48:31AM +0200, Vicent Mas wrote:
 Hi,
 
 while investigating the problems that I sent yesterday to this list
 (thread 'Unable to run forrest')
 and due to the long time I've been without using forrest I decided to
 start with the simplest task
 i.e. build a sample site using $ forrest seed. It works fine if I
 don't use dispatcher, but when I
 activated the dispatcher in the forrest.properties file I got an
 Internal Server Error page in my browser:

Plugins with Java source are not currently being built due to r951789.

With that change reverted and everything else current, it works for
me. The change in r951789 was to fix some errors with forrestbot, but
the context of the problem is now lost on me; so I don't know the
appropriate solution.

Brian


Re: Plugins with Java source are not being built (was Re: building a sample site with dispatcher fails)

2010-08-24 Thread David Crossley
Brian M Dube wrote:
 
 Plugins with Java source are not currently being built due to r951789.
 
 With that change reverted and everything else current, it works for
 me. The change in r951789 was to fix some errors with forrestbot, but
 the context of the problem is now lost on me; so I don't know the
 appropriate solution.

Wonder why it works properly for some people.

It was nothing to do with forrestbot. That part is
misleading.

See discussion around 5 June 2010.

-David


Re: Plugins with Java source are not being built (was Re: building a sample site with dispatcher fails)

2010-08-24 Thread Brian M Dube
On Tue, Aug 24, 2010 at 08:02:15PM -0700, Brian M Dube wrote:
 On Wed, Aug 04, 2010 at 08:48:31AM +0200, Vicent Mas wrote:
  Hi,
  
  while investigating the problems that I sent yesterday to this list
  (thread 'Unable to run forrest')
  and due to the long time I've been without using forrest I decided to
  start with the simplest task
  i.e. build a sample site using $ forrest seed. It works fine if I
  don't use dispatcher, but when I
  activated the dispatcher in the forrest.properties file I got an
  Internal Server Error page in my browser:
 
 Plugins with Java source are not currently being built due to r951789.
 
 With that change reverted and everything else current, it works for
 me. The change in r951789 was to fix some errors with forrestbot, but
 the context of the problem is now lost on me; so I don't know the
 appropriate solution.

This thread appears to be related:

Subject: Re: svn commit: r951719 - /forrest/trunk/plugins/build.xml
Message-ID: aanlktik7sru6tqznfbsxgqrg8jworqje-0qn5devt...@mail.gmail.com
http://www.mail-archive.com/dev@forrest.apache.org/msg16453.html

But it's still not clear to me what problem this was trying to solve.

Anyway, I don't see support for wildcards in the source for the
Available Ant task.

Brian


Re: Plugins with Java source are not being built (was Re: building a sample site with dispatcher fails)

2010-08-24 Thread Brian M Dube
On Wed, Aug 25, 2010 at 01:51:29PM +1000, David Crossley wrote:
 Brian M Dube wrote:
  
  Plugins with Java source are not currently being built due to r951789.
  
  With that change reverted and everything else current, it works for
  me. The change in r951789 was to fix some errors with forrestbot, but
  the context of the problem is now lost on me; so I don't know the
  appropriate solution.
 
 Wonder why it works properly for some people.

'ant clean' in a plugin directory does not remove the jar from that
plugin's build directory. I had to manually delete the plugin's build
directory at each iteration to find the svn revision that caused the
issue (for me). Otherwise it looked like the plugin, dispatcher in
this case, was being built correctly and it was not. Perhaps this
allows some people to carry on without issue, while a fresh checkout
will not build the plugin source.

Brian


Re: Plugins with Java source are not being built (was Re: building a sample site with dispatcher fails)

2010-08-24 Thread Brian M Dube
On Wed, Aug 25, 2010 at 01:51:29PM +1000, David Crossley wrote:
 Brian M Dube wrote:
  
  Plugins with Java source are not currently being built due to r951789.
  
  With that change reverted and everything else current, it works for
  me. The change in r951789 was to fix some errors with forrestbot, but
  the context of the problem is now lost on me; so I don't know the
  appropriate solution.
 
 Wonder why it works properly for some people.
 
 It was nothing to do with forrestbot. That part is
 misleading.

I'm only going by the svn commit log. I don't remember what the issue
was.

Brian

 See discussion around 5 June 2010.
 
 -David