Re: [Proposal] forrest clean removing build/
On 12/05/07, Thorsten Scherler [EMAIL PROTECTED] wrote: Hi all, I would like to propose that forrest clean removes the whole build/ directory instead only some directories within. -1 that would require users to build forrest. +0 to removing everything except the build artifacts. Ross
Re: [Proposal] forrest clean removing build/
Thorsten Scherler wrote: I would like to propose that forrest clean removes the whole build/ directory instead only some directories within. I no concerns are issued within the next 72 hours I will change the corresponding ant target to remove the whole build/. What's your reason for that proposal? I had a similar issue some time ago because to many ../ in a link would create content below the site-dir but that would require some other fix to make sense. Best regards, Ferdinand Soethe
Re: [Proposal] forrest clean removing build/
On Sun, 2007-05-13 at 15:07 +0100, Ross Gardler wrote: On 12/05/07, Thorsten Scherler [EMAIL PROTECTED] wrote: Hi all, I would like to propose that forrest clean removes the whole build/ directory instead only some directories within. -1 that would require users to build forrest. I am talking about: cd site-author forrest clean That is not forcing user to build forrest. It is project specific and removes the build in site-author/build. It is not equal to cd main ./build.sh clean See Re: svn commit: r536953 [1/14] why I would like to change the behavior. salu2 -- Thorsten Scherler thorsten.at.apache.org Open Source Java consulting, training and solutions
Re: [Proposal] forrest clean removing build/
On Sun, 2007-05-13 at 16:14 +0200, Ferdinand Soethe wrote: Thorsten Scherler wrote: I would like to propose that forrest clean removes the whole build/ directory instead only some directories within. I no concerns are issued within the next 72 hours I will change the corresponding ant target to remove the whole build/. What's your reason for that proposal? http://marc.info/?t=11788285774r=1w=2 Since forrest clean did not removed the whole build dir I had old files in the build/forrest-docs dir. The forrestbot is always adding all files that he can find so it added 0.6. If forrest clean would have removed build/ I would not added 0.6 docs again. salu2 -- Thorsten Scherler thorsten.at.apache.org Open Source Java consulting, training and solutions
Re: [Proposal] forrest clean removing build/
On 13/05/07, Thorsten Scherler [EMAIL PROTECTED] wrote: On Sun, 2007-05-13 at 15:07 +0100, Ross Gardler wrote: On 12/05/07, Thorsten Scherler [EMAIL PROTECTED] wrote: Hi all, I would like to propose that forrest clean removes the whole build/ directory instead only some directories within. -1 that would require users to build forrest. I am talking about: cd site-author forrest clean That is not forcing user to build forrest. It is project specific and removes the build in site-author/build. You're right - no objection from me then. Ross
Re: [Proposal] forrest clean removing build/
Thorsten Scherler wrote: See Re: svn commit: r536953 [1/14] why I would like to change the behavior. Sounds like a bug. Makes sense to fix it. Not sure about side-effects of removing build completely, so +0 Ferdinand
Re: [Proposal] forrest clean removing build/
Thorsten Scherler wrote: Ross Gardler wrote: Thorsten Scherler wrote: I would like to propose that forrest clean removes the whole build/ directory instead only some directories within. -1 that would require users to build forrest. I am talking about: cd site-author forrest clean That is not forcing user to build forrest. It is project specific and removes the build in site-author/build. It is not equal to cd main ./build.sh clean See Re: svn commit: r536953 [1/14] why I would like to change the behavior. I do have a concern. Doing 'forrest clean' should only remove build/site/ directory because that was the process that created it, i.e. doing 'forrest site'. Doing 'forrest -f ...' is invoking the forrestbot, i.e not the 'forrest site' style of build. The forrestbot's own 'clean' workstage [1] should handle its own spawn, e.g. site-author/build/forrest-docs/ which was the result of 'forrest -f publish.xml' i.e. a forrestbot run on site-author. I also have projects with separate forrestbot runs, so have e.g. build/stage1/ and build/stage2/ [1] Forrestbot doesn't yet have a 'clean' workstage. Should be easy. Going by memory there is something in our Issue tracker perhaps related. In your origin email Re: svn commit: r536953 you wrote: Is there any special reason why forrest clean is not just doing rm -rf build but rm -rf build/webapp rm -rf build/tmp? It also removes the build/site directory. -David
