Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
BTW, where can I find this forrest-sample-2 so I could run it myself? I've only run forrest seed now. run build test in main to test all the test cases. test sites will then be created in forrest/build directory. Best regards, Ferdinand Soethe
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Thanks Jeremias, some great improvements as far as I can see. Especially the keep together for notes. I have tested the patch but not committed it because it broke trunk. Here is the list of problems Forrest reported: ^samples-b/ ^samples-c/ ^samples-c/subdir/ ^samples-c/showonlywhenselected/ ^pluginDocs/plugins_0_90/ * [1/35][35/41] 7.657s 13.7Kb linkmap.html * [3/36][3/31]1.296s 8.6Kb samples-b/static.html * [4/35][0/0] 2.829s 106.1Kb samples-b/static.pdf * [5/39][5/37]0.75s 26.7Kb samples-b/sample.html WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. table (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. list-item-body (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. list-item (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. list-block (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. flow (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. page-sequence (http://www.w3.org/1999/XSL/Format) WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. root (http://www.w3.org/1999/XSL/Format) X [0] samples-b/sample.pdf BROKEN: Error(Unknown location): fo:table-header is missing child elements. Required Content Model: marker* (table-row+|table-cell+) * [8/37][1/24]0.812s 7.2Kb samples-c/i18n.html * [9/36][0/0] 0.344s 105.7Kb samples-c/i18n.pdf * [10/36] [1/31]0.609s 7.9Kb samples-b/usemap.html * [11/35] [0/0] 0.532s 106.8Kb samples-b/usemap.pdf * [12/35] [1/25]0.656s 6.9Kb samples-c/showonlywhenselected/page1.html * [13/34] [0/0] 0.219s 104.7Kb samples-c/showonlywhenselected/page1.pdf * [15/32] [0/0] 11.157s 7.4Kb images/group.png * [16/33] [2/31]1.156s 10.8Kb samples-b/embedded_html.html * [17/36] [4/28]0.734s 8.9Kb samples-c/index.html ^samples-b/site:index * [19/34] [0/2] 0.047s 3.6Kb samples-b/embedded_html.xml WARN - Bookmarks: Unresolved id reference __toc__ found. WARN - Bookmark with IDRef __toc__ has a null PageViewport. * [20/33] [0/0] 0.75s 105.0Kb linkmap.pdf * [21/32] [0/0] 0.0s 951b/images/usemap.gif * [22/33] [2/31]0.343s 7.8Kb samples-b/ascii-art.html * [23/32] [0/0] 0.954s 107.7Kb samples-b/ascii-art.pdf * [24/31] [0/0] 0.234s 8.3Kb images/project.png * [26/30] [1/20]2.0s 59.4Kb pluginDocs/plugins_0_90/index.html ^pluginDocs/plugins_0_90/ * [27/30] [1/40]0.672s 10.3Kb index.html * [28/29] [0/0] 0.25s 105.4Kb index.pdf * [29/29] [1/25]0.609s 7.0Kb samples-c/showonlywhenselected/page2.html ^samples-b/ext:forrest * [30/28] [0/9] 0.11s 19.2Kb samples-b/sample.xml * [31/27] [0/0] 0.25s 10.3Kb * [33/25] [0/0] 0.375s 3.2Kb skin/basic.css * [34/25] [1/34]0.641s 10.3Kb samples-b/index.html * [35/25] [1/27]0.672s 7.2Kb samples-c/subdir/index.html * [36/37] [13/13] 0.343s 13.4Kb skin/screen.css * [38/35] [0/0] 0.234s 319bskin/images/rc-b-r-15-1body-2menu-3menu.png * [39/34] [0/0] 0.079s 209b skin/images/rc-t-l-5-1header-2tab-selected-3tab-selected.png * [40/33] [0/0] 0.046s 200b skin/images/rc-b-r-5-1header-2tab-selected-3tab-selected.png * [41/32] [0/0] 0.047s 214b skin/images/rc-t-r-5-1header-2tab-unselected-3tab-unselected.png * [42/31] [0/0] 0.047s 199b skin/images/rc-t-l-5-1header-2searchbox-3searchbox.png * [44/30] [1/20]0.609s 5.5Kb samples-a/index.html * [45/29] [0/0] 0.25s 105.0Kb samples-a/index.pdf * [46/28] [0/0] 0.047s 214b skin/images/rc-t-r-5-1header-2searchbox-3searchbox.png * [47/27] [0/0] 0.062s 1.3Kb skin/print.css * [48/26] [0/0] 0.047s 390bskin/images/rc-t-r-15-1body-2menu-3menu.png ^pluginDocs/plugins_0_90/ ^samples-b/ * [50/37] [13/49] 0.812s 30.9Kb samples-b/linking.html * [51/36] [0/0] 0.281s
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Ferdinand Soethe wrote: Thanks Jeremias, some great improvements as far as I can see. Especially the keep together for notes. I have tested the patch but not committed it because it broke trunk. Here is the list of problems Forrest reported: Woops, i just committed it without testing. Sorry, i should not have done that. Forrestbot is going to admonish me on its next run. If we cannot fix it soon, then i suppose i should revert. I noticed before this that we we already we getting many new WARN messages (i.e. not related to this commit). I wonder why those are not going to the logfile. -David
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Ferdinand Soethe wrote: X [0] samples-b/sample.pdf BROKEN: Error(Unknown location): fo:table-header is missing child elements. Required Content Model: marker* (table-row+|table-cell+) I tested it on our site-author docs which have many more docs with tables. It does not report errors for all docs that contain tables, e.g. content/xdocs/docs_0_90/linking.xml is okay. I supsect perhaps table captions. Need more investigation. -David
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
David Crossley wrote: Ferdinand Soethe wrote: X [0] samples-b/sample.pdf BROKEN: Error(Unknown location): fo:table-header is missing child elements. Required Content Model: marker* (table-row+|table-cell+) I tested it on our site-author docs which have many more docs with tables. It does not report errors for all docs that contain tables, e.g. content/xdocs/docs_0_90/linking.xml is okay. I supsect perhaps table captions. Need more investigation. No, the captions are okay. I found the problem by comparing documents that failed with all docs in site-author that contain tables. We have some sources that have tables with no trth.../tr header row. I added a hack with r632692 to handle that. Can someone do better xsl? The other failure case is because we have some tables with a th on every row, e.g. docs_0_90/sitemap-ref.xml See line 453 in resources/stylesheets/helper-commonElements.xsl r632692 which does not handle it. Can someone help with that? -David
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
David Crossley wrote: David Crossley wrote: Ferdinand Soethe wrote: X [0] samples-b/sample.pdf BROKEN: Error(Unknown location): fo:table-header is missing child elements. Required Content Model: marker* (table-row+|table-cell+) I tested it on our site-author docs which have many more docs with tables. It does not report errors for all docs that contain tables, e.g. content/xdocs/docs_0_90/linking.xml is okay. I supsect perhaps table captions. Need more investigation. No, the captions are okay. I found the problem by comparing documents that failed with all docs in site-author that contain tables. We have some sources that have tables with no trth.../tr header row. I added a hack with r632692 to handle that. Can someone do better xsl? The other failure case is because we have some tables with a th on every row, e.g. docs_0_90/sitemap-ref.xml See line 453 in resources/stylesheets/helper-commonElements.xsl r632692 which does not handle it. Can someone help with that? Forrestbot keeps complaining because we excercise the latter bug with the automatically generated tables in pluginDocs/plugins_0_90/index.pdf I think that i have fixed it now at r632714. -David
