[GitHub] incubator-geode issue #290: GEODE-2092: Security examples should not be in t...
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/290 Merged in latest develop branch. Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #297: GEODE-734: gfsh export stack-traces should not r...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/297 Thanks for the contribution! However, I don't think we should require user input in order to gather stack traces. Quite often a user will automate collection (`gfsh export stack-traces ...`) and will not be able to provide input. Here's a few ways we could extend the current behavior: - Provide an option to auto-generate a unique name - Provide an option that would cause the export to fail if the provided file name is already present. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #290: GEODE-2092: Security examples should not be in t...
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/290 Confict fixed. Precheckin running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/283 I tried to pull this in but I get an error message about the branch not existing: fatal: Couldn't find remote ref feature/GEODE-2098 Looks like the pull request is still open, but the branch has been destroyed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #293: GEODE-1653: Executing a fire-and-forget function...
Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/293 Some additional information on using Awaitility: Use a larger timeout value such as 60 seconds. If you use 1 second, then sometime the test is going to have a false failure when it runs on a slow machine or because a garbage collection occurs during the test. Awaitility will only wait until the condition is met -- it will early out from the 60 second timeout. The test will then pass on slower machines or in case of GC. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #282: GEODE-1740: Inconsistencies with concurrent clea...
Github user pdxrunner commented on the issue: https://github.com/apache/incubator-geode/pull/282 This looks good. I'll pull it in as my first commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
JavaLaunchHelper warning when starting server
I've started seeing the following intermixed with GFSH output when starting servers on a Mac: objc[16455]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined. Has anyone seen this on a Linux OS? -Kirk
Re: JavaLaunchHelper warning when starting server
I think this is a problem with Java... I recall that this is a known issue in Java and nothing to worry about. On 11/28/16 14:02, Kirk Lund wrote: I've started seeing the following intermixed with GFSH output when starting servers on a Mac: objc[16455]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined. Has anyone seen this on a Linux OS? -Kirk
Global scope regions
Looks like global regions cannot be created using GFSH. We should either add support for global scope to GFSH or remove global scope (and the RegionLock APIs). Does anyone know if global scope is officially deprecated? Or why it's not supported by GFSH? -Kirk
Re: Global scope regions
I think it was never added. I think we keep on favoring shortcuts above correct configuration properties. --Udo On 11/28/16 15:15, Kirk Lund wrote: Looks like global regions cannot be created using GFSH. We should either add support for global scope to GFSH or remove global scope (and the RegionLock APIs). Does anyone know if global scope is officially deprecated? Or why it's not supported by GFSH? -Kirk
Re: Review Request 53685: GEODE-1955: properly disconnect gfsh session so that it won't leave heartbeat thread around to pollute other tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/ --- (Updated Nov. 28, 2016, 11:27 p.m.) Review request for geode, Kevin Duling, Kirk Lund, and Udo Kohlmeyer. Changes --- Added the ignored tests back and fix the issues brought up in the review Repository: geode Description --- * add the "disconnect" command when we close the GfshShellConnectionRule so that no heartbeat thread is left to pollute other tests. * Fix the test so that it truely test the jmx ssl connection, and fix the configuration mishaps. * The above fix revealed another bug (GEODE-2099: race condition), ignored the other two tests for now. Diffs (updated) - geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java c58a398ef9094ceecde2d7c6e806931dff872552 geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java 3a2660cca88a0ae4070eab7c496e2079bfb63a7d geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java 3731d4d19ea7227d91e9714ccf2b56424098aaf3 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/JmxOperationInvoker.java 0fa47d434d599de81acebc275175eb087e9deb79 geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 0c16c1a628a4785bba302ed651e3017e2ce7a563 Diff: https://reviews.apache.org/r/53685/diff/ Testing --- Thanks, Jinmei Liao
Re: Global scope regions
Yep, the --type argument in gfsh matches the enum values of org.apache.geode.cache.RegionShortcut which doesn't include any shortcuts for global. On Mon, Nov 28, 2016 at 3:17 PM, Udo Kohlmeyer wrote: > I think it was never added. I think we keep on favoring shortcuts above > correct configuration properties. > > --Udo > > > > On 11/28/16 15:15, Kirk Lund wrote: > >> Looks like global regions cannot be created using GFSH. We should either >> add support for global scope to GFSH or remove global scope (and the >> RegionLock APIs). >> >> Does anyone know if global scope is officially deprecated? Or why it's not >> supported by GFSH? >> >> -Kirk >> >> >
Re: Global scope regions
I think we need to add --data-policy and --scope to GFSH. --Udo On 11/28/16 15:39, Kirk Lund wrote: Yep, the --type argument in gfsh matches the enum values of org.apache.geode.cache.RegionShortcut which doesn't include any shortcuts for global. On Mon, Nov 28, 2016 at 3:17 PM, Udo Kohlmeyer wrote: I think it was never added. I think we keep on favoring shortcuts above correct configuration properties. --Udo On 11/28/16 15:15, Kirk Lund wrote: Looks like global regions cannot be created using GFSH. We should either add support for global scope to GFSH or remove global scope (and the RegionLock APIs). Does anyone know if global scope is officially deprecated? Or why it's not supported by GFSH? -Kirk
Re: Global scope regions
We could allow the User to specify either a --type or a combination of --data-policy and --scope but not all three. Apparently the introduction of RegionShortcut (and its use for --type) was supposed to simplify things. AttributesFactory was deprecated in favor of using shortcuts. The shortcuts combine Scope, DataPolicy, InterestPolicy, InterestResultPolicy, EvictionAttributes/Algorithm, ExpirationAttributes/Action, etc. Specifying all of the legal combinations with enum Shortcuts was the direction taken to eliminate incompatible combinations. I'm not sure adding --data-policy and --scope would be enough. I think we'd have to add the others as well to give full flexibility to justify having them. It's probably simpler at this point to introduce shortcuts for global and its few variations. Adding anything else probably warrants further discussion. At a minimum, I gather that global regions are not deprecated (just not encouraged due to performance compared with other scopes). I'll file a bug against gfsh because we can't create a global region. -Kirk On Mon, Nov 28, 2016 at 3:40 PM, Udo Kohlmeyer wrote: > I think we need to add --data-policy and --scope to GFSH. > > --Udo > > > > On 11/28/16 15:39, Kirk Lund wrote: > >> Yep, the --type argument in gfsh matches the enum values of >> org.apache.geode.cache.RegionShortcut which doesn't include any shortcuts >> for global. >> >> >> On Mon, Nov 28, 2016 at 3:17 PM, Udo Kohlmeyer >> wrote: >> >> I think it was never added. I think we keep on favoring shortcuts above >>> correct configuration properties. >>> >>> --Udo >>> >>> >>> >>> On 11/28/16 15:15, Kirk Lund wrote: >>> >>> Looks like global regions cannot be created using GFSH. We should either add support for global scope to GFSH or remove global scope (and the RegionLock APIs). Does anyone know if global scope is officially deprecated? Or why it's not supported by GFSH? -Kirk >
[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/294#discussion_r89939851
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java
---
@@ -45,7 +45,9 @@ private void takeScreenshot(String screenshotName) {
if (driver instanceof TakesScreenshot) {
File tempFile = ((TakesScreenshot)
driver).getScreenshotAs(OutputType.FILE);
try {
-FileUtils.copyFile(tempFile, new File("build/screenshots/" +
screenshotName + ".png"));
+File screenshot = new File("build/screenshots/" + screenshotName +
".png");
+FileUtils.copyFile(tempFile, screenshot);
+System.err.println("Screenshot saved to: " +
screenshot.getCanonicalPath());
--- End diff --
Is this an accidental change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #298: [GEODE-1122] Fix Dependency on environment varia...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/298 This closes #298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #298: [GEODE-1122] Fix Dependency on environmen...
Github user davinash closed the pull request at: https://github.com/apache/incubator-geode/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
