[jira] [Updated] (GEODE-2509) Build failed at openSUSE LEAP 42.2

[Danilo Chang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Danilo Chang updated GEODE-2509:

Description: 
geode-native C++ client build failed at openSUSE LEAP 42.2, because the library 
folder name is different at 32bit or 64bit environment (lib64 at 64bit 
environment and lib at 32bit environment). Now 2 components has this issue, 
libxml2 and xerces-c.

The attachment file is the solution I try to fix this issue (use --libdir to 
specify the path). However, I don't know Geode native C++ client prefer to use 
the same lib folder name or not. So I create this JIRA item.

  was:
geode-native C+++ client build failed at openSUSE LEAP 42.2, because the 
library folder name is different at 32bit or 64bit environment (lib64 at 64bit 
environment and lib at 32bit environment). Now 2 components has this issue, 
libxml2 and xerces-c.

The attachment file is the solution I try to fix this issue (use --libdir to 
specify the path). However, I don't know Geode native C+++ client prefer to use 
the same lib folder name or not. So I create this JIRA item.


> Build failed at openSUSE LEAP 42.2
> --
>
> Key: GEODE-2509
> URL: https://issues.apache.org/jira/browse/GEODE-2509
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Danilo Chang
> Attachments: fix_build_opensuse.patch
>
>
> geode-native C++ client build failed at openSUSE LEAP 42.2, because the 
> library folder name is different at 32bit or 64bit environment (lib64 at 
> 64bit environment and lib at 32bit environment). Now 2 components has this 
> issue, libxml2 and xerces-c.
> The attachment file is the solution I try to fix this issue (use --libdir to 
> specify the path). However, I don't know Geode native C++ client prefer to 
> use the same lib folder name or not. So I create this JIRA item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2509) Build failed at openSUSE LEAP 42.2

[Danilo Chang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Danilo Chang updated GEODE-2509:

Attachment: fix_build_opensuse.patch

> Build failed at openSUSE LEAP 42.2
> --
>
> Key: GEODE-2509
> URL: https://issues.apache.org/jira/browse/GEODE-2509
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Danilo Chang
> Attachments: fix_build_opensuse.patch
>
>
> geode-native C+++ client build failed at openSUSE LEAP 42.2, because the 
> library folder name is different at 32bit or 64bit environment (lib64 at 
> 64bit environment and lib at 32bit environment). Now 2 components has this 
> issue, libxml2 and xerces-c.
> The attachment file is the solution I try to fix this issue (use --libdir to 
> specify the path). However, I don't know Geode native C+++ client prefer to 
> use the same lib folder name or not. So I create this JIRA item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2509) Build failed at openSUSE LEAP 42.2

[Danilo Chang (JIRA)]

Danilo Chang created GEODE-2509:
---

 Summary: Build failed at openSUSE LEAP 42.2
 Key: GEODE-2509
 URL: https://issues.apache.org/jira/browse/GEODE-2509
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Danilo Chang


geode-native C+++ client build failed at openSUSE LEAP 42.2, because the 
library folder name is different at 32bit or 64bit environment (lib64 at 64bit 
environment and lib at 32bit environment). Now 2 components has this issue, 
libxml2 and xerces-c.

The attachment file is the solution I try to fix this issue (use --libdir to 
specify the path). However, I don't know Geode native C+++ client prefer to use 
the same lib folder name or not. So I create this JIRA item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2490) Tombstone messages are getting processed inline

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872871#comment-15872871
 ] 

ASF subversion and git services commented on GEODE-2490:


Commit 826bdbfe2ae2f4b3cd27760584684bc35e19e9b7 in geode's branch 
refs/heads/develop from [~agingade]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=826bdbf ]

GEODE-2490: Avoid processing tombstone GC message in-line

Currently the tombstone message sent for replicas are getting
processed in-line instead of handing it to thread pool.
Based on the number of nodes in the cluster, this may take
long time to process, impacting other cache operation that
required to be processed in-line.

The change provided here enables tombstone messages to
be not processed in-line instead processed in separate
thread.


> Tombstone messages are getting processed inline
> ---
>
> Key: GEODE-2490
> URL: https://issues.apache.org/jira/browse/GEODE-2490
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Assignee: Anilkumar Gingade
>
> Tombstone:
> As part of consistency checking, when an entry is destroyed, the member 
> temporarily retains the entry to detect possible conflicts with operations 
> that have occurred. The retained entry is referred to as a tombstone.
> When tombstones are removed, tombstone messages are sent to region replicas; 
> and in case of Partitioned Region (PR) messages are also sent to peer region 
> nodes for client events.
> Currently the tombstone message sent for replicas are getting processed 
> in-line. Based on the number of nodes in the cluster, this may take long time 
> to process, impacting other cache operation that required to be processed 
> in-line. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872826#comment-15872826
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit fc1624ccec7efb967bef53840a6d01c9624ce791 in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fc1624c ]

GEODE-2142: removing tests so run precheckin


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56803: GEODE-2142: Update GEODE-JSON module with compliant ORG.JSON implementation

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56803/
---

(Updated Feb. 18, 2017, 12:46 a.m.)


Review request for geode, Anthony Baker, Jacob Barrett, Jinmei Liao, and Kirk 
Lund.


Repository: geode


Description
---

Removed non-compliant ORJ.JSON implementation with a compliant opensource 
ORG.JSON implementation


Diffs (updated)
-

  LICENSE 9bfdd83c9 
  NOTICE 13a30d3bb 
  geode-assembly/src/main/dist/LICENSE 4769f9a55 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
8525b5862 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/json/GfJsonObject.java
 69666ff9d 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 e08d9b7c0 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
 06060a4c6 
  geode-json/build.gradle PRE-CREATION 
  geode-json/src/main/java/org/json/CDL.java d78935bd7 
  geode-json/src/main/java/org/json/Cookie.java 21f88d8bd 
  geode-json/src/main/java/org/json/CookieList.java 35e1a97f4 
  geode-json/src/main/java/org/json/HTTP.java 1e815aabe 
  geode-json/src/main/java/org/json/HTTPTokener.java 72c9b8878 
  geode-json/src/main/java/org/json/JSON.java PRE-CREATION 
  geode-json/src/main/java/org/json/JSONArray.java edaefa420 
  geode-json/src/main/java/org/json/JSONException.java b65efe25c 
  geode-json/src/main/java/org/json/JSONML.java b535614f8 
  geode-json/src/main/java/org/json/JSONObject.java a2c6d8b6a 
  geode-json/src/main/java/org/json/JSONStringer.java 234e17451 
  geode-json/src/main/java/org/json/JSONTokener.java 4dd2ba2cc 
  geode-json/src/main/java/org/json/JSONWriter.java 7d4704b21 
  geode-json/src/main/java/org/json/XML.java ae6d61a49 
  geode-json/src/main/java/org/json/XMLTokener.java f56a1f6a5 
  geode-json/src/test/java/org/json/FileTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONArrayTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONFunctionTestObject.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONObjectTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONStringerTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONTokenerTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/ParsingTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/SelfUseTest.java PRE-CREATION 
  geode-json/src/test/resources/sample-01.json PRE-CREATION 

Diff: https://reviews.apache.org/r/56803/diff/


Testing
---

pre-checkin = in progress


Thanks,

Udo Kohlmeyer

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872812#comment-15872812
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 71f2af706a0b9751da256696ab55f336432ac3bd in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=71f2af7 ]

GEODE-2142: final compiling build


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872787#comment-15872787
 ] 

ASF GitHub Bot commented on GEODE-2497:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/402#discussion_r101873819
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
 ---
@@ -159,77 +159,74 @@ public void testConnectAfterBeingShunned() {
**/
   @Test
   public void testSurpriseMemberHandling() {
-VM vm0 = Host.getHost(0).getVM(0);
-
-InternalDistributedSystem sys = getSystem();
-MembershipManager mgr = 
MembershipManagerHelper.getMembershipManager(sys);
 
+System.setProperty(DistributionConfig.GEMFIRE_PREFIX + 
"surprise-member-timeout", "3000");
 try {
-  InternalDistributedMember mbr =
-  new InternalDistributedMember(NetworkUtils.getIPLiteral(), 
12345);
+  InternalDistributedSystem sys = getSystem();
+  MembershipManager mgr = 
MembershipManagerHelper.getMembershipManager(sys);
+  assertTrue(((GMSMembershipManager) mgr).isCleanupTimerStarted());
 
-  // first make sure we can't add this as a surprise member (bug 
#44566)
-
-  // if the view number isn't being recorded correctly the test will 
pass but the
-  // functionality is broken
-  Assert.assertTrue("expected view ID to be greater than zero", 
mgr.getView().getViewId() > 0);
-
-  int oldViewId = mbr.getVmViewId();
-  mbr.setVmViewId((int) mgr.getView().getViewId() - 1);
-  org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
-  .info("current membership view is " + mgr.getView());
-  org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
-  .info("created ID " + mbr + " with view ID " + 
mbr.getVmViewId());
-  sys.getLogWriter()
-  .info("attempt to add old 
member");
-  sys.getLogWriter()
-  .info("Removing shunned GemFire 
node");
   try {
-boolean accepted = mgr.addSurpriseMember(mbr);
-Assert.assertTrue("member with old ID was not rejected (bug 
#44566)", !accepted);
-  } finally {
+InternalDistributedMember mbr =
+new InternalDistributedMember(NetworkUtils.getIPLiteral(), 
12345);
+
+// first make sure we can't add this as a surprise member (bug 
#44566)
+
+// if the view number isn't being recorded correctly the test will 
pass but the
+// functionality is broken
+Assert.assertTrue("expected view ID to be greater than zero",
+mgr.getView().getViewId() > 0);
+
+int oldViewId = mbr.getVmViewId();
+mbr.setVmViewId((int) mgr.getView().getViewId() - 1);
+org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
+.info("current membership view is " + mgr.getView());
+org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
+.info("created ID " + mbr + " with view ID " + 
mbr.getVmViewId());
 sys.getLogWriter()
-.info("attempt to add old 
member");
+.info("attempt to add old 
member");
 sys.getLogWriter().info(
-"Removing shunned GemFire 
node");
-  }
-  mbr.setVmViewId(oldViewId);
-
-  // now forcibly add it as a surprise member and show that it is 
reaped
-  long gracePeriod = 5000;
-  long startTime = System.currentTimeMillis();
-  long timeout = ((GMSMembershipManager) 
mgr).getSurpriseMemberTimeout();
-  long birthTime = startTime - timeout + gracePeriod;
-  MembershipManagerHelper.addSurpriseMember(sys, mbr, birthTime);
-  assertTrue("Member was not a surprise member", 
mgr.isSurpriseMember(mbr));
-
-  // force a real view change
-  SerializableRunnable connectDisconnect = new SerializableRunnable() {
-public void run() {
-  getSystem().disconnect();
+"Removing shunned GemFire 
node");
+try {
+  boolean accepted = mgr.addSurpriseMember(mbr);
+  Assert.assertTrue("member with old ID was not rejected (bug 
#44566)", !accepted);
+} finally {
+  sys.getLogWriter().info(
+  "attempt to add old 
member");
--- End diff --

Is this the old method of adding expected exceptions?


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>   

[GitHub] geode pull request #402: GEODE-2497 surprise members are never timed out dur...

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/402#discussion_r101873819
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
 ---
@@ -159,77 +159,74 @@ public void testConnectAfterBeingShunned() {
**/
   @Test
   public void testSurpriseMemberHandling() {
-VM vm0 = Host.getHost(0).getVM(0);
-
-InternalDistributedSystem sys = getSystem();
-MembershipManager mgr = 
MembershipManagerHelper.getMembershipManager(sys);
 
+System.setProperty(DistributionConfig.GEMFIRE_PREFIX + 
"surprise-member-timeout", "3000");
 try {
-  InternalDistributedMember mbr =
-  new InternalDistributedMember(NetworkUtils.getIPLiteral(), 
12345);
+  InternalDistributedSystem sys = getSystem();
+  MembershipManager mgr = 
MembershipManagerHelper.getMembershipManager(sys);
+  assertTrue(((GMSMembershipManager) mgr).isCleanupTimerStarted());
 
-  // first make sure we can't add this as a surprise member (bug 
#44566)
-
-  // if the view number isn't being recorded correctly the test will 
pass but the
-  // functionality is broken
-  Assert.assertTrue("expected view ID to be greater than zero", 
mgr.getView().getViewId() > 0);
-
-  int oldViewId = mbr.getVmViewId();
-  mbr.setVmViewId((int) mgr.getView().getViewId() - 1);
-  org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
-  .info("current membership view is " + mgr.getView());
-  org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
-  .info("created ID " + mbr + " with view ID " + 
mbr.getVmViewId());
-  sys.getLogWriter()
-  .info("attempt to add old 
member");
-  sys.getLogWriter()
-  .info("Removing shunned GemFire 
node");
   try {
-boolean accepted = mgr.addSurpriseMember(mbr);
-Assert.assertTrue("member with old ID was not rejected (bug 
#44566)", !accepted);
-  } finally {
+InternalDistributedMember mbr =
+new InternalDistributedMember(NetworkUtils.getIPLiteral(), 
12345);
+
+// first make sure we can't add this as a surprise member (bug 
#44566)
+
+// if the view number isn't being recorded correctly the test will 
pass but the
+// functionality is broken
+Assert.assertTrue("expected view ID to be greater than zero",
+mgr.getView().getViewId() > 0);
+
+int oldViewId = mbr.getVmViewId();
+mbr.setVmViewId((int) mgr.getView().getViewId() - 1);
+org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
+.info("current membership view is " + mgr.getView());
+org.apache.geode.test.dunit.LogWriterUtils.getLogWriter()
+.info("created ID " + mbr + " with view ID " + 
mbr.getVmViewId());
 sys.getLogWriter()
-.info("attempt to add old 
member");
+.info("attempt to add old 
member");
 sys.getLogWriter().info(
-"Removing shunned GemFire 
node");
-  }
-  mbr.setVmViewId(oldViewId);
-
-  // now forcibly add it as a surprise member and show that it is 
reaped
-  long gracePeriod = 5000;
-  long startTime = System.currentTimeMillis();
-  long timeout = ((GMSMembershipManager) 
mgr).getSurpriseMemberTimeout();
-  long birthTime = startTime - timeout + gracePeriod;
-  MembershipManagerHelper.addSurpriseMember(sys, mbr, birthTime);
-  assertTrue("Member was not a surprise member", 
mgr.isSurpriseMember(mbr));
-
-  // force a real view change
-  SerializableRunnable connectDisconnect = new SerializableRunnable() {
-public void run() {
-  getSystem().disconnect();
+"Removing shunned GemFire 
node");
+try {
+  boolean accepted = mgr.addSurpriseMember(mbr);
+  Assert.assertTrue("member with old ID was not rejected (bug 
#44566)", !accepted);
+} finally {
+  sys.getLogWriter().info(
+  "attempt to add old 
member");
--- End diff --

Is this the old method of adding expected exceptions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review166005
---


Ship it!




Ship It!

- Ken Howe


On Feb. 17, 2017, 11:56 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56801/
> ---
> 
> (Updated Feb. 17, 2017, 11:56 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
>  e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
>   geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
> b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
>  a96f8afe75675bb733956cf28bc129e6a7c23b25 
>   geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
> 2d729303a27179876e2f8a96c0542d796f426e16 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
> 4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> e53aa5d55437116dc466e551c793af87f24012df 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> 270c8335a88c48fd3b036b65b50d7fd2b7734a81 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
>  a71394139cd8cc4582122f2d587d0f4434b9ce12 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
>  e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
>  86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  20d1c4ff92fbd54956334c923e1bacfea8825aa6 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
> 7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
>  f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
>   geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
> 2d6921b9a2087928dffebd2dc050f3967170962b 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
>  66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
>  f126146d3098f009eda8388273b52758b7d0ee28 
>   
> geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
>  01151931473e882905a4443535f2c2306e34ff63 
>   geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
> 942059e110487f3f886ef5749134190768a87eac 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
> 22f66a3efdb670684c0108ab22dc07c43e0265b1 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
>  3852dee6613dd67ed85d61365c7ad6ca02306f78 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java
>  00bb6fb9064b46ef5622e7e11632a36ec71097dd 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java
>  1d18ed146382e36c894c72ab642e8055fd316df1 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
> 4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
> cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
> 10931e194d20369350720736a4435aa5998ca0cc 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
> a89c0d13ececb47bf7345624d4e7d128e01d6a45 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
>  6955dc829330f8766c172da32795fd8ee6b98f7e 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java
>  55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java
>  9c459a9b737fc80d7a7cd0242927abf2691855b3 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java
>  138f3acc5abb96831af60a43560334494793d60b 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsJUnitT

[jira] [Commented] (GEODE-2508) Generize lib naming

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872763#comment-15872763
 ] 

ASF GitHub Bot commented on GEODE-2508:
---

GitHub user echobravopapa opened a pull request:

https://github.com/apache/geode-native/pull/19

GEODE-2508: Inital work on making lib names generic.

Just a sneak peak, I think I may have a couple tweaks/additions next week.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 2aa2c5acb151ef08761e88290666f3e7e5c6546a
Author: Ernest Burghardt 
Date:   2017-02-17T23:53:25Z

GEODE-2508: Inital work on making lib names generic.




> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #19: GEODE-2508: Inital work on making lib names g...

[echobravopapa]

GitHub user echobravopapa opened a pull request:

https://github.com/apache/geode-native/pull/19

GEODE-2508: Inital work on making lib names generic.

Just a sneak peak, I think I may have a couple tweaks/additions next week.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 2aa2c5acb151ef08761e88290666f3e7e5c6546a
Author: Ernest Burghardt 
Date:   2017-02-17T23:53:25Z

GEODE-2508: Inital work on making lib names generic.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/
---

(Updated Feb. 17, 2017, 3:56 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.


Changes
---

Removed useless comment and optimized a few more statements.


Repository: geode


Description
---

GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
org.apache.commons.io.FileUtils


Diffs (updated)
-

  
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
 e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
  geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
 a96f8afe75675bb733956cf28bc129e6a7c23b25 
  geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
2d729303a27179876e2f8a96c0542d796f426e16 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
e53aa5d55437116dc466e551c793af87f24012df 
  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
270c8335a88c48fd3b036b65b50d7fd2b7734a81 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
 a71394139cd8cc4582122f2d587d0f4434b9ce12 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
 e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
 86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
  
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
 20d1c4ff92fbd54956334c923e1bacfea8825aa6 
  geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
  
geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
 f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
  geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
2d6921b9a2087928dffebd2dc050f3967170962b 
  
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
 66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
  
geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
 f126146d3098f009eda8388273b52758b7d0ee28 
  
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
 01151931473e882905a4443535f2c2306e34ff63 
  geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
942059e110487f3f886ef5749134190768a87eac 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
22f66a3efdb670684c0108ab22dc07c43e0265b1 
  
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 3852dee6613dd67ed85d61365c7ad6ca02306f78 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java 
00bb6fb9064b46ef5622e7e11632a36ec71097dd 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java 
1d18ed146382e36c894c72ab642e8055fd316df1 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
10931e194d20369350720736a4435aa5998ca0cc 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
a89c0d13ececb47bf7345624d4e7d128e01d6a45 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
 6955dc829330f8766c172da32795fd8ee6b98f7e 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java
 55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 
  
geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java
 9c459a9b737fc80d7a7cd0242927abf2691855b3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java 
138f3acc5abb96831af60a43560334494793d60b 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsJUnitTest.java
 2529639f200e3670cb7d108f70e2c0e9a3702401 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PersistentPartitionedRegionJUnitTest.java
 478f5e3f8827b78bc5aba5449698ce3fd3768b6c 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 47520bc8177feecf70dc0ede5a17607385b90dd3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPart

Review Request 56803: GEODE-2142: Update GEODE-JSON module with compliant ORG.JSON implementation

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56803/
---

Review request for geode, Anthony Baker, Jacob Barrett, Jinmei Liao, and Kirk 
Lund.


Repository: geode


Description
---

Removed non-compliant ORJ.JSON implementation with a compliant opensource 
ORG.JSON implementation


Diffs
-

  LICENSE 9bfdd83c9 
  NOTICE 13a30d3bb 
  geode-assembly/src/main/dist/LICENSE 4769f9a55 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
8525b5862 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/json/GfJsonObject.java
 69666ff9d 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 e08d9b7c0 
  geode-json/build.gradle PRE-CREATION 
  geode-json/src/main/java/org/json/CDL.java d78935bd7 
  geode-json/src/main/java/org/json/Cookie.java 21f88d8bd 
  geode-json/src/main/java/org/json/CookieList.java 35e1a97f4 
  geode-json/src/main/java/org/json/HTTP.java 1e815aabe 
  geode-json/src/main/java/org/json/HTTPTokener.java 72c9b8878 
  geode-json/src/main/java/org/json/JSON.java PRE-CREATION 
  geode-json/src/main/java/org/json/JSONArray.java edaefa420 
  geode-json/src/main/java/org/json/JSONException.java b65efe25c 
  geode-json/src/main/java/org/json/JSONML.java b535614f8 
  geode-json/src/main/java/org/json/JSONObject.java a2c6d8b6a 
  geode-json/src/main/java/org/json/JSONStringer.java 234e17451 
  geode-json/src/main/java/org/json/JSONTokener.java 4dd2ba2cc 
  geode-json/src/main/java/org/json/JSONWriter.java 7d4704b21 
  geode-json/src/main/java/org/json/XML.java ae6d61a49 
  geode-json/src/main/java/org/json/XMLTokener.java f56a1f6a5 
  geode-json/src/test/java/org/json/FileTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONArrayTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONFunctionTestObject.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONObjectTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONStringerTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/JSONTokenerTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/ParsingTest.java PRE-CREATION 
  geode-json/src/test/java/org/json/SelfUseTest.java PRE-CREATION 
  geode-json/src/test/resources/sample-01.json PRE-CREATION 

Diff: https://reviews.apache.org/r/56803/diff/


Testing
---

pre-checkin = in progress


Thanks,

Udo Kohlmeyer

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872757#comment-15872757
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 1067ba0387e7910512b83018356a75b1b2c61726 in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1067ba0 ]

GEODE-2142: cyclical dependency in gradle build


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872748#comment-15872748
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit f5a097256d0b1667fa89e4701c20a8455ecb807a in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f5a0972 ]

GEODE-2142: spotless


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review165987
---


Fix it, then Ship it!





geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
(line 2777)


Do you need the old filename pattern regex in a comment? The extensions are 
all explicitly defined in the new listFiles call so the commnet doesn't add 
anything to the readability of the code.


- Ken Howe


On Feb. 17, 2017, 10:21 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56801/
> ---
> 
> (Updated Feb. 17, 2017, 10:21 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
>  e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
>   geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
> b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
>  a96f8afe75675bb733956cf28bc129e6a7c23b25 
>   geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
> 2d729303a27179876e2f8a96c0542d796f426e16 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
> 4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> e53aa5d55437116dc466e551c793af87f24012df 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> 270c8335a88c48fd3b036b65b50d7fd2b7734a81 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
>  a71394139cd8cc4582122f2d587d0f4434b9ce12 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
>  e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
>  86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  20d1c4ff92fbd54956334c923e1bacfea8825aa6 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
> 7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
>  f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
>   geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
> 2d6921b9a2087928dffebd2dc050f3967170962b 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
>  66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
>  f126146d3098f009eda8388273b52758b7d0ee28 
>   
> geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
>  01151931473e882905a4443535f2c2306e34ff63 
>   geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
> 942059e110487f3f886ef5749134190768a87eac 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
> 22f66a3efdb670684c0108ab22dc07c43e0265b1 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
>  3852dee6613dd67ed85d61365c7ad6ca02306f78 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java
>  00bb6fb9064b46ef5622e7e11632a36ec71097dd 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java
>  1d18ed146382e36c894c72ab642e8055fd316df1 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
> 4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
> cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
> 10931e194d20369350720736a4435aa5998ca0cc 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
> a89c0d13ececb47bf7345624d4e7d128e01d6a45 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
>  6955dc829330f8766c172da32795fd8ee6b98f7e 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java
>  55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 
>   
> geode-core/

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872714#comment-15872714
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 00f1d3d7bd9053b85b2fb2258299cdf6a79acd86 in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=00f1d3d ]

GEODE-2142: Amending JSONObject.java with cyclicalDependency management
Refactoring some code in GfJsonObject.java


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872711#comment-15872711
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 0b4ac2fed6e99ba19afba63a6f6ab132b6fd55b0 in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0b4ac2f ]

GEODE-2142: Removal of offending JSON.ORG code and license information


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872715#comment-15872715
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 38c5286a06dc444f23a9b5ed4ccaf5a87a8c902e in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=38c5286 ]

GEODE-2142: Refactoring of tests to work with new JSONObject class.
Changing file export to use Base64 encoding.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872712#comment-15872712
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 575d8f13ffd0aab40eda571f593bd67c685bc054 in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=575d8f1 ]

GEODE-2142: Removal of offending JSON.ORG code and license information


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872713#comment-15872713
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 7e78537701c83e3dd429cf68f6f35ba22e95f7aa in geode's branch 
refs/heads/feature/GEODE-2142 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=7e78537 ]

GEODE-2142: Adding JSON library from the https://github.com/tdunning/open-json 
project


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review165995
---


Ship it!




Ship It!

- Jared Stewart


On Feb. 17, 2017, 10:21 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56801/
> ---
> 
> (Updated Feb. 17, 2017, 10:21 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
>  e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
>   geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
> b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
>  a96f8afe75675bb733956cf28bc129e6a7c23b25 
>   geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
> 2d729303a27179876e2f8a96c0542d796f426e16 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
> 4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> e53aa5d55437116dc466e551c793af87f24012df 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> 270c8335a88c48fd3b036b65b50d7fd2b7734a81 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
>  a71394139cd8cc4582122f2d587d0f4434b9ce12 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
>  e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
>  86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  20d1c4ff92fbd54956334c923e1bacfea8825aa6 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
> 7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
>  f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
>   geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
> 2d6921b9a2087928dffebd2dc050f3967170962b 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
>  66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
>  f126146d3098f009eda8388273b52758b7d0ee28 
>   
> geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
>  01151931473e882905a4443535f2c2306e34ff63 
>   geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
> 942059e110487f3f886ef5749134190768a87eac 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
> 22f66a3efdb670684c0108ab22dc07c43e0265b1 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
>  3852dee6613dd67ed85d61365c7ad6ca02306f78 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java
>  00bb6fb9064b46ef5622e7e11632a36ec71097dd 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java
>  1d18ed146382e36c894c72ab642e8055fd316df1 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
> 4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
> cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
> 10931e194d20369350720736a4435aa5998ca0cc 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
> a89c0d13ececb47bf7345624d4e7d128e01d6a45 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
>  6955dc829330f8766c172da32795fd8ee6b98f7e 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java
>  55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java
>  9c459a9b737fc80d7a7cd0242927abf2691855b3 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java
>  138f3acc5abb96831af60a43560334494793d60b 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsJ

[jira] [Resolved] (GEODE-1964) Add docs for native client to native client repo

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-1964.

Resolution: Fixed

Initial doc set for this code contribution is now in place.

> Add docs for native client to native client repo
> 
>
> Key: GEODE-1964
> URL: https://issues.apache.org/jira/browse/GEODE-1964
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> After the native client code has been merged to develop, the documentation 
> should follow. This subtask allows us to 'park' the existing docs on a 
> feature branch until they're needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1964) Add docs for native client to native client repo

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872704#comment-15872704
 ] 

ASF subversion and git services commented on GEODE-1964:


Commit eef8e2ff54ad1be0b746df5e9768ac49c1661881 in geode-native's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=eef8e2f ]

GEODE-1964 Update QuickStart docs to show cmake procedures.


> Add docs for native client to native client repo
> 
>
> Key: GEODE-1964
> URL: https://issues.apache.org/jira/browse/GEODE-1964
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> After the native client code has been merged to develop, the documentation 
> should follow. This subtask allows us to 'park' the existing docs on a 
> feature branch until they're needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #401: Remove generated html files

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/401


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

[Michael William Dodge]

I've modified PR #13 to remove the vestigial executable and to elide the 
duplicate GEODE_ in the legacy include guards.

Sarge

> On 17 Feb, 2017, at 11:06, pivotal-jbarrett  wrote:
> 
> Github user pivotal-jbarrett commented on a diff in the pull request:
> 
>https://github.com/apache/geode-native/pull/13#discussion_r101825168
> 
>--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
>@@ -1,7 +1,7 @@
> #pragma once
> 
>-#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_
>-#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_
>+#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_
>--- End diff --
> 
>I see an argument that `include/geode/` is the root for the public 
> headers, therefore the guards should be `GEODE_ATTRIBUTESFACTORY_H_`.
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[jira] [Created] (GEODE-2508) Generize lib naming

[Ernest Burghardt (JIRA)]

Ernest Burghardt created GEODE-2508:
---

 Summary: Generize lib naming
 Key: GEODE-2508
 URL: https://issues.apache.org/jira/browse/GEODE-2508
 Project: Geode
  Issue Type: Improvement
  Components: native client
Reporter: Ernest Burghardt


Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #475 was SUCCESSFUL (with 1679 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #475 was successful.
---
Scheduled
1681 tests in total.

https://build.spring.io/browse/SGF-NAG-475/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/
---

(Updated Feb. 17, 2017, 2:21 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.


Changes
---

Incorporated Jared's suggestions


Repository: geode


Description
---

GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
org.apache.commons.io.FileUtils


Diffs (updated)
-

  
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
 e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
  geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
 a96f8afe75675bb733956cf28bc129e6a7c23b25 
  geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
2d729303a27179876e2f8a96c0542d796f426e16 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
e53aa5d55437116dc466e551c793af87f24012df 
  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
270c8335a88c48fd3b036b65b50d7fd2b7734a81 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
 a71394139cd8cc4582122f2d587d0f4434b9ce12 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
 e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
 86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
  
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
 20d1c4ff92fbd54956334c923e1bacfea8825aa6 
  geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
  
geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
 f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
  geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
2d6921b9a2087928dffebd2dc050f3967170962b 
  
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
 66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
  
geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
 f126146d3098f009eda8388273b52758b7d0ee28 
  
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
 01151931473e882905a4443535f2c2306e34ff63 
  geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
942059e110487f3f886ef5749134190768a87eac 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
22f66a3efdb670684c0108ab22dc07c43e0265b1 
  
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 3852dee6613dd67ed85d61365c7ad6ca02306f78 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java 
00bb6fb9064b46ef5622e7e11632a36ec71097dd 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java 
1d18ed146382e36c894c72ab642e8055fd316df1 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
10931e194d20369350720736a4435aa5998ca0cc 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
a89c0d13ececb47bf7345624d4e7d128e01d6a45 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
 6955dc829330f8766c172da32795fd8ee6b98f7e 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java
 55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 
  
geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java
 9c459a9b737fc80d7a7cd0242927abf2691855b3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java 
138f3acc5abb96831af60a43560334494793d60b 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsJUnitTest.java
 2529639f200e3670cb7d108f70e2c0e9a3702401 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PersistentPartitionedRegionJUnitTest.java
 478f5e3f8827b78bc5aba5449698ce3fd3768b6c 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 47520bc8177feecf70dc0ede5a17607385b90dd3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java
 

Re: Automating docker builds for geode-native

[Anthony Baker]

Yep, but there’s still this:

https://github.com/docker/docker/issues/12169

(if we don’t build from source, then there are timing issues around when the 
tag is created vs when the binaries are available to download from mirrors)

Anthony

> On Feb 17, 2017, at 2:12 PM, William Markito Oliveira 
>  wrote:
> 
> What about creating a .dockerignore file ?  ->
> https://docs.docker.com/engine/reference/builder/#/dockerignore-file
> 
> 
> 
> On Fri, Feb 17, 2017 at 10:02 AM, Anthony Baker  wrote:
> 
>> 
>>> On Feb 10, 2017, at 12:29 PM, Anthony Baker  wrote:
>>> 
>>> The geode-native build, like most c++ projects, requires a fairly
>> specific toolchain.  Now that we have a docker build environment [1], I’d
>> like to ask INFRA to automate the creation and publishing of docker images
>> for geode-native.  This can be done by integrating GitHub / DockerHub [2].
>> Note that the docker image would *only* be for build purposes and would not
>> contain source or binaries from geode-native.  By publishing our build
>> toolchain in a docker image:
>>> 
>>> 1) it makes contributing easier
>>> 2) it makes our travis-ci builds faster (currently at ~30min)
>>> 3) it paves the way to create a nightly Jenkins job for geode-native
>>> 
>>> I suggest publishing this image under the apache namespace [3] as
>> geode-native-build.  Thoughts?
>>> 
>>> Anthony
>>> 
>>> [1] https://github.com/apache/geode-native/blob/develop/
>> docker/Dockerfile
>>> [2] https://issues.apache.org/jira/browse/INFRA-11584?jql=
>> project%20%3D%20INFRA%20AND%20text%20~%20docker
>>> [3] https://hub.docker.com/u/apache/
>> 
>> It turns out there are some quirks with automated docker builds.  The
>> docker container will get rebuilt based on pushes to specific branches or
>> when tags are created that match a regex pattern.  This is not super useful
>> when the container is used to define a build environment.  For now, I just
>> manually pushed the build image to our docker hub account as:
>> 
>>apachegeode/geode-native-build
>> 
>> We could consider using this automation to build release images.  However,
>> the Dockerfile must live in the project root and the container size becomes
>> larger than just downloading the binaries we publish on ASF.
>> 
>> Anthony
>> 
>> 
> 
> 
> -- 
> ~/William

Re: for discussion: separate website into its own repo

[William Markito Oliveira]

+1

On Fri, Feb 17, 2017 at 4:15 PM, Karen Miller  wrote:

> Seems like everyone is in favor of the separate repo.  I'll request one
> early next week.
> I created https://issues.apache.org/jira/browse/GEODE-2507 to handle the
> first parts
> of the task of getting the new repo up and running.
>
>
> On Fri, Feb 17, 2017 at 9:25 AM, Kirk Lund  wrote:
>
> > +1
> >
> > On Thu, Feb 16, 2017 at 4:45 PM, Joey McAllister  >
> > wrote:
> >
> > > +1 to Karen's suggestion of moving the website to its own repo.
> > >
> > > +1 to Dan's suggestion scripting the website build/publishing with a CI
> > > system based on commits.
> > >
> > > On Thu, Feb 16, 2017 at 4:38 PM Dan Smith  wrote:
> > >
> > > > +1
> > > >
> > > > I think the current setup is confusing, because the website is
> supposed
> > > to
> > > > include docs that are generated from the last release, but the site
> > > > instructions say the site should be generated from develop. A
> separate
> > > repo
> > > > with a single branch will probably reduce confusion.
> > > >
> > > > We also need to script the website building and publishing, and
> ideally
> > > > have the publishing done by a CI system based on commits. It looks
> like
> > > > some other projects are talking about doing this with jenkins
> jenkins -
> > > see
> > > > INFRA-10722 for example.
> > > >
> > > > -Dan
> > > >
> > > > On Thu, Feb 16, 2017 at 4:10 PM, Karen Miller 
> > > wrote:
> > > >
> > > > > I think that the website content that is currently in
> > geode/geode-site
> > > > > ought to be moved to its own repository.  The driving reason for
> this
> > > is
> > > > > that changes to the website occur on a different schedule than code
> > > > > releases.  We often want to add a new committer's name or a new
> > > > > event, and these items are not associated with sw releases. A new
> > > website
> > > > > release that comes from the develop branch may have commits that
> > > > > should not yet be made public.
> > > > >
> > > > > Are there downsides to separating the website content into its own
> > > repo?
> > > > >
> > > >
> > >
> >
>



-- 
~/William

Re: Automating docker builds for geode-native

[William Markito Oliveira]

What about creating a .dockerignore file ?  ->
https://docs.docker.com/engine/reference/builder/#/dockerignore-file



On Fri, Feb 17, 2017 at 10:02 AM, Anthony Baker  wrote:

>
> > On Feb 10, 2017, at 12:29 PM, Anthony Baker  wrote:
> >
> > The geode-native build, like most c++ projects, requires a fairly
> specific toolchain.  Now that we have a docker build environment [1], I’d
> like to ask INFRA to automate the creation and publishing of docker images
> for geode-native.  This can be done by integrating GitHub / DockerHub [2].
> Note that the docker image would *only* be for build purposes and would not
> contain source or binaries from geode-native.  By publishing our build
> toolchain in a docker image:
> >
> > 1) it makes contributing easier
> > 2) it makes our travis-ci builds faster (currently at ~30min)
> > 3) it paves the way to create a nightly Jenkins job for geode-native
> >
> > I suggest publishing this image under the apache namespace [3] as
> geode-native-build.  Thoughts?
> >
> > Anthony
> >
> > [1] https://github.com/apache/geode-native/blob/develop/
> docker/Dockerfile
> > [2] https://issues.apache.org/jira/browse/INFRA-11584?jql=
> project%20%3D%20INFRA%20AND%20text%20~%20docker
> > [3] https://hub.docker.com/u/apache/
>
> It turns out there are some quirks with automated docker builds.  The
> docker container will get rebuilt based on pushes to specific branches or
> when tags are created that match a regex pattern.  This is not super useful
> when the container is used to define a build environment.  For now, I just
> manually pushed the build image to our docker hub account as:
>
> apachegeode/geode-native-build
>
> We could consider using this automation to build release images.  However,
> the Dockerfile must live in the project root and the container size becomes
> larger than just downloading the binaries we publish on ASF.
>
> Anthony
>
>


-- 
~/William

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Kevin Duling]

> On Feb. 17, 2017, 1:41 p.m., Jared Stewart wrote:
> > geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java,
> >  line 134
> > 
> >
> > I think one call to ```FileUtils.forceDelete(deleteMe);``` can replace 
> > the block from 123-128

Almost.  The `if exists` test is still necessary or a 
`java.io.FileNotFoundException: File does not exist` is thrown.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review165975
---


On Feb. 17, 2017, 1:09 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56801/
> ---
> 
> (Updated Feb. 17, 2017, 1:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
>  e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
>   geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
> b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
>  a96f8afe75675bb733956cf28bc129e6a7c23b25 
>   geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
> 2d729303a27179876e2f8a96c0542d796f426e16 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
> 4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> e53aa5d55437116dc466e551c793af87f24012df 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> 270c8335a88c48fd3b036b65b50d7fd2b7734a81 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
>  a71394139cd8cc4582122f2d587d0f4434b9ce12 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
>  e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
>  86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  20d1c4ff92fbd54956334c923e1bacfea8825aa6 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
> 7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
>  f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
>   geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
> 2d6921b9a2087928dffebd2dc050f3967170962b 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
>  66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
>  f126146d3098f009eda8388273b52758b7d0ee28 
>   
> geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
>  01151931473e882905a4443535f2c2306e34ff63 
>   geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
> 942059e110487f3f886ef5749134190768a87eac 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
> 22f66a3efdb670684c0108ab22dc07c43e0265b1 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
>  3852dee6613dd67ed85d61365c7ad6ca02306f78 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java
>  00bb6fb9064b46ef5622e7e11632a36ec71097dd 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java
>  1d18ed146382e36c894c72ab642e8055fd316df1 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
> 4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
> cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
> 10931e194d20369350720736a4435aa5998ca0cc 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
> a89c0d13ececb47bf7345624d4e7d128e01d6a45 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
>  6955dc829330f8766c172da32795fd8ee6b98f7e 
>   
> geode-core/src/test/java/org/apache/geode/i

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872609#comment-15872609
 ] 

ASF subversion and git services commented on GEODE-2309:


Commit 0657197f5099dc2e5d7735079ab7ef5165ec8947 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=0657197 ]

GEODE-2309: Remove or ignore apache-rat flagged files

This closes #12.


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2309) Replace or add ASF copyright statements in source.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872611#comment-15872611
 ] 

ASF GitHub Bot commented on GEODE-2309:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/12


> Replace or add ASF copyright statements in source.
> --
>
> Key: GEODE-2309
> URL: https://issues.apache.org/jira/browse/GEODE-2309
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #12: GEODE-2309: Remove or ignore apache-rat flagg...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872600#comment-15872600
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 1253d7808e3d35d2d6868e98e1ccb5bfa1749e35 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1253d78 ]

Revert "GEODE-2142: Spotless"

This reverts commit 2e3a88f7bc61796042140aa92b44390b9970b53e.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872601#comment-15872601
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 0805036e81756e3d843f3227e94927a520a07946 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0805036 ]

Revert "GEODE-2142: Removal of non-compliant org.json implementation."

This reverts commit b3ec80bc72fee3a40da297945a85d8df6c2a6460.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872595#comment-15872595
 ] 

ASF subversion and git services commented on GEODE-2484:


Commit d7f6ac3d4978ae42266191c18e44eb3875c99156 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=d7f6ac3 ]

Revert "GEODE-2484 Replace ace calls to standard functions"

Broken CL compiling on VS 2013 which does not have complete
C++11 features, e.g. std::snprintf.

This reverts commit d4e0a8447b1e54d5c34a35069bc24a30d8258e2e.

This closes #18.


> Remove ACE from native client dependencies
> --
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: David Kimura
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872598#comment-15872598
 ] 

ASF GitHub Bot commented on GEODE-2484:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/18


> Remove ACE from native client dependencies
> --
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: David Kimura
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #18: Revert "GEODE-2484 Replace ace calls to stand...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872594#comment-15872594
 ] 

ASF GitHub Bot commented on GEODE-2484:
---

Github user mmartell closed the pull request at:

https://github.com/apache/geode-native/pull/15


> Remove ACE from native client dependencies
> --
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: David Kimura
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...

[mmartell]

Github user mmartell closed the pull request at:

https://github.com/apache/geode-native/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review165975
---




geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
 (line 102)


I think this might be a bit more resilient way to do the same thing since 
it doesn't rely on String manipulation:

```
backup = outputDir.toPath().relativize(backup.toPath()).toFile();
```



geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
 (line 123)


I think one call to ```FileUtils.forceDelete(deleteMe);``` can replace the 
block from 123-128


- Jared Stewart


On Feb. 17, 2017, 9:09 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56801/
> ---
> 
> (Updated Feb. 17, 2017, 9:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
>  e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
>   geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
> b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
>  a96f8afe75675bb733956cf28bc129e6a7c23b25 
>   geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
> 2d729303a27179876e2f8a96c0542d796f426e16 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
> 4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> e53aa5d55437116dc466e551c793af87f24012df 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> 270c8335a88c48fd3b036b65b50d7fd2b7734a81 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
>  a71394139cd8cc4582122f2d587d0f4434b9ce12 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
>  e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
>  86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  20d1c4ff92fbd54956334c923e1bacfea8825aa6 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
> 7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
>  f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
>   geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
> 2d6921b9a2087928dffebd2dc050f3967170962b 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
>  66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
>  f126146d3098f009eda8388273b52758b7d0ee28 
>   
> geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
>  01151931473e882905a4443535f2c2306e34ff63 
>   geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
> 942059e110487f3f886ef5749134190768a87eac 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
> 22f66a3efdb670684c0108ab22dc07c43e0265b1 
>   
> geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
>  3852dee6613dd67ed85d61365c7ad6ca02306f78 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java
>  00bb6fb9064b46ef5622e7e11632a36ec71097dd 
>   
> geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java
>  1d18ed146382e36c894c72ab642e8055fd316df1 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
> 4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
>   geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
> cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
> 10931e194d20369350720736a4435aa5998ca0cc 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
> a89c0d13ececb47bf7345624d4e7d128e01d6a45 
>   
> geode-core/src/test/java/org/apach

Re: [jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[Anthony Baker]

I have to say I’m -1 on this change for the following reasons:

- Was not posted for review that I can see
- Includes System.err statements 
- Includes changes that don’t seem relevant to the purpose of the commit?
- Does not update LICENSE for removal of org.json

A matter of style it would be nice to have a more explanatory statement as well.

Anthony

> On Feb 17, 2017, at 1:01 PM, ASF subversion and git services (JIRA) 
>  wrote:
> 
> 
>[ 
> https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872512#comment-15872512
>  ] 
> 
> ASF subversion and git services commented on GEODE-2142:
> 
> 
> Commit b3ec80bc72fee3a40da297945a85d8df6c2a6460 in geode's branch 
> refs/heads/develop from [~ukohlmeyer]
> [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b3ec80b ]
> 
> GEODE-2142: Removal of non-compliant org.json implementation.
> 
> 
>> Remove JSON.org dependency
>> --
>> 
>>Key: GEODE-2142
>>URL: https://issues.apache.org/jira/browse/GEODE-2142
>>Project: Geode
>> Issue Type: Bug
>> Components: build
>>   Reporter: Anthony Baker
>>   Priority: Blocker
>> Labels: json
>> 
>> ASF has determined that the JSON library should be treated as Category X and 
>> is incompatible with ASLv2.
>> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
>> prior to that time must state this usage via NOTICE.
>> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
>> There are related reasons for removing the JSON library anyway, but this bug 
>> captures the legal reasons.
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)

[GitHub] geode-native issue #18: Revert "GEODE-2484 Replace ace calls to standard fun...

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/18
  
Wise choice, this can revisited in the future when the community has more 
time and inclination to make the jump to a toolchain with complete or more 
complete C++11 support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2484) Remove ACE from native client dependencies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872539#comment-15872539
 ] 

ASF GitHub Bot commented on GEODE-2484:
---

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/18

Revert "GEODE-2484 Replace ace calls to standard functions"

Revert build break on VS 2013 which does not have complete
C++11 features, e.g. std::snprintf.

This reverts commit d4e0a8447b1e54d5c34a35069bc24a30d8258e2e.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18


commit e35aa3aa32172ff207438ccded3dfea599f50afb
Author: David Kimura 
Date:   2017-02-17T21:16:05Z

Revert "GEODE-2484 Replace ace calls to standard functions"

Broken CL compiling on VS 2013 which does not have complete
C++11 features, e.g. std::snprintf.

This reverts commit d4e0a8447b1e54d5c34a35069bc24a30d8258e2e.




> Remove ACE from native client dependencies
> --
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: David Kimura
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #18: Revert "GEODE-2484 Replace ace calls to stand...

[dgkimura]

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/18

Revert "GEODE-2484 Replace ace calls to standard functions"

Revert build break on VS 2013 which does not have complete
C++11 features, e.g. std::snprintf.

This reverts commit d4e0a8447b1e54d5c34a35069bc24a30d8258e2e.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18


commit e35aa3aa32172ff207438ccded3dfea599f50afb
Author: David Kimura 
Date:   2017-02-17T21:16:05Z

Revert "GEODE-2484 Replace ace calls to standard functions"

Broken CL compiling on VS 2013 which does not have complete
C++11 features, e.g. std::snprintf.

This reverts commit d4e0a8447b1e54d5c34a35069bc24a30d8258e2e.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2507:
-
Description: 
Move the web site content to its own repo.
1. Acquire the repo.  Name it geode-site.
2. Populate the repo with the current web site's contents
3. Request that the asf-site branch be switched from the geode repo to this new 
geode-site repo, and test that everything works
4. Update the contents of LICENSE files for geode and geode-site
5. Setup auto-publish by creating an INFRA JIRA ticket
6. Revise README for publishing instructions


  was:
Move the web site content to its own repo.
1. Acquire the repo.  Name it geode-site.
2. Populate the repo with the current web site's contents
3. Request that the asf-site branch be switched from the geode repo to this new 
geode-site repo, and test that everything works
4. Create new GEODE JIRA tickets that address how we generate (and hopefully 
autogenerate) revisions of the Geode web page.  Also, create new GEODE JIRA 
tickets that revise our README files with instructions that any committer can 
follow to update the Geode web page.


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2507:
-
Description: 
Move the web site content to its own repo.
1. Acquire the repo.  Name it geode-site.
2. Populate the repo with the current web site's contents on the master branch
3. Request that the asf-site branch be switched from the geode repo to this new 
geode-site repo, and test that everything works
4. Update the contents of LICENSE files for geode and geode-site
5. Setup auto-publish by creating an INFRA JIRA ticket
6. Revise README for publishing instructions


  was:
Move the web site content to its own repo.
1. Acquire the repo.  Name it geode-site.
2. Populate the repo with the current web site's contents
3. Request that the asf-site branch be switched from the geode repo to this new 
geode-site repo, and test that everything works
4. Update the contents of LICENSE files for geode and geode-site
5. Setup auto-publish by creating an INFRA JIRA ticket
6. Revise README for publishing instructions



> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: for discussion: separate website into its own repo

[Karen Miller]

Seems like everyone is in favor of the separate repo.  I'll request one
early next week.
I created https://issues.apache.org/jira/browse/GEODE-2507 to handle the
first parts
of the task of getting the new repo up and running.


On Fri, Feb 17, 2017 at 9:25 AM, Kirk Lund  wrote:

> +1
>
> On Thu, Feb 16, 2017 at 4:45 PM, Joey McAllister 
> wrote:
>
> > +1 to Karen's suggestion of moving the website to its own repo.
> >
> > +1 to Dan's suggestion scripting the website build/publishing with a CI
> > system based on commits.
> >
> > On Thu, Feb 16, 2017 at 4:38 PM Dan Smith  wrote:
> >
> > > +1
> > >
> > > I think the current setup is confusing, because the website is supposed
> > to
> > > include docs that are generated from the last release, but the site
> > > instructions say the site should be generated from develop. A separate
> > repo
> > > with a single branch will probably reduce confusion.
> > >
> > > We also need to script the website building and publishing, and ideally
> > > have the publishing done by a CI system based on commits. It looks like
> > > some other projects are talking about doing this with jenkins jenkins -
> > see
> > > INFRA-10722 for example.
> > >
> > > -Dan
> > >
> > > On Thu, Feb 16, 2017 at 4:10 PM, Karen Miller 
> > wrote:
> > >
> > > > I think that the website content that is currently in
> geode/geode-site
> > > > ought to be moved to its own repository.  The driving reason for this
> > is
> > > > that changes to the website occur on a different schedule than code
> > > > releases.  We often want to add a new committer's name or a new
> > > > event, and these items are not associated with sw releases. A new
> > website
> > > > release that comes from the develop branch may have commits that
> > > > should not yet be made public.
> > > >
> > > > Are there downsides to separating the website content into its own
> > repo?
> > > >
> > >
> >
>

[jira] [Created] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[Karen Smoler Miller (JIRA)]

Karen Smoler Miller created GEODE-2507:
--

 Summary: Acquire and populate new geode-site repo for the web site
 Key: GEODE-2507
 URL: https://issues.apache.org/jira/browse/GEODE-2507
 Project: Geode
  Issue Type: New Feature
  Components: web-content
Reporter: Karen Smoler Miller


Move the web site content to its own repo.
1. Acquire the repo.  Name it geode-site.
2. Populate the repo with the current web site's contents
3. Request that the asf-site branch be switched from the geode repo to this new 
geode-site repo, and test that everything works
4. Create new GEODE JIRA tickets that address how we generate (and hopefully 
autogenerate) revisions of the Geode web page.  Also, create new GEODE JIRA 
tickets that revise our README files with instructions that any committer can 
follow to update the Geode web page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Propose a new implementation for collections in Geode transaction (GEODE-2392)

[Anilkumar Gingade]

>> 1) Do you know why we don’t set detectReadConflicts [1] true by
default?  I would guess that most users would not expect dirty reads in the
context of a repeatable read isolation level.

The reason was to support common isolation level, read-committed with
pessimistic repeatable-read semantic (don't check read conflicts), and easy
to write application (reduced error handling)...Also, If application wanted
to have read conflicts, it could do so by reading and writing the same data
back. Later we added the system property to help this scenario, we may need
to re-look at it.

>>  In the case of non-local reads on a Partitioned Region, shouldn’t we
throw a TransactionDataNotColocatedException?
Yes, we throw exception for non-local read (get). But for collection apis,
we don't throw exception (key set can read data from remote node),
inconsistent behavior.

>> 3) Some cache operations throw an UnsupportedOperationInTransactionException.
Is there a reason we don’t for containsValue()?
Its a overlook, one more inconsistent behavior.

Based on the conversation till now:
1. Support collection apis (including containsValue()) within transaction
without adding them to TX state. OR
2. Throw exception if collection APIs are invoked within TX.

1. Is what we proposing.

We think supporting repeatable-read with conflict detection by default,
should be treated as separate ticket.

Please let us know your views, so that we can finalize on this.

Thanks,
-Anil.



On Tue, Feb 14, 2017 at 3:04 PM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:

> +1 for supporting repeatable read semantics consistently. throw
> Unsupportedexception if some apis are not supported inside tx.
> -Hitesh.  From: Anthony Baker 
>  To: dev@geode.apache.org
>  Sent: Monday, February 13, 2017 8:08 AM
>  Subject: Re: Propose a new implementation for collections in Geode
> transaction (GEODE-2392)
>
> Questions:
>
> 1) Do you know why we don’t set detectReadConflicts [1] true by default?
> I would guess that most users would not expect dirty reads in the context
> of a repeatable read isolation level.
> 2) In the case of non-local reads on a Partitioned Region, shouldn’t we
> throw a TransactionDataNotColocatedException?
> 3) Some cache operations throw an UnsupportedOperationInTransactionException.
> Is there a reason we don’t for containsValue()?
>
>
> Anthony
>
> [1] https://geode.apache.org/docs/guide/developing/transactions/
> transaction_semantics.html
>
> > On Feb 10, 2017, at 12:23 PM, Anilkumar Gingade 
> wrote:
> >
> > As Eric mentioned, this will address the current inconsistencies in the
> > product and will provide consistent behavior with replicated and
> > partitioned region.
> >
> > Also, if we look into typical database transaction applications, the
> > transaction queries doesn't touch/read all the records in the table,
> mostly
> > or always they are targeted queries (with where clause) with small result
> > set. In Geode case, without support for any filtering option with
> > collection api's, it may have to bring in all the region entries into the
> > Tx state, which application may not be looking for...The better solution
> to
> > support this is by making Geode queries transactional; which can provide
> > repeatable read semantic on sub-set data.
> >
> > I agree, its hard for application to distinguish what apis are part of Tx
> > and what is not...Option to address this could be, proper documentation
> or
> > not allowing collection apis inside the Tx. In needed, application has to
> > suspend the Tx, to call them.
> >
> > -Anil.
> >
> >
> >
> >
> >
> >
> >
> >
> > On Fri, Feb 10, 2017 at 10:57 AM, Eric Shu  wrote:
> >
> >> Hi Dan,
> >>
> >> Currently query results do not reflect transaction state at all. The new
> >> proposal won't change that.
> >>
> >> On Fri, Feb 10, 2017 at 10:47 AM, Eric Shu  wrote:
> >>
> >>> Please note even in our current transaction implementation, repeatable
> >>> read is not supported on collection operation in transaction with
> >>> Partitioned Region. Currently, only the local entry set (resides in the
> >>> local node) of a PR is copied into the txState, while data on the
> remote
> >>> nodes are not. Another call of the collection operation of the same
> >>> transaction could have different results for the data on the remote
> >> nodes.
> >>>
> >>> In addition, containValue() call currently does not support repeatable
> >>> read either. It does not copy all data into txState (replicated or
> >>> partitioned regions.)
> >>>
> >>> Currently we only support limited repeatable read for collection
> >>> operations in transaction (at least for PR).
> >>>
> >>> On Fri, Feb 10, 2017 at 8:36 AM, Anthony Baker 
> >> wrote:
> >>>
>  I tend to agree with Mike.  Removing collection reads from the txn
> state
>  changes the programming model and makes it harder to write a Geode
>  application.  We’re leaking internal details into the public behavior.
> 
>  Is there another way

Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/
---

Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
org.apache.commons.io.FileUtils


Diffs
-

  
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
 e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
  geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
 a96f8afe75675bb733956cf28bc129e6a7c23b25 
  geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
2d729303a27179876e2f8a96c0542d796f426e16 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
e53aa5d55437116dc466e551c793af87f24012df 
  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
270c8335a88c48fd3b036b65b50d7fd2b7734a81 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
 a71394139cd8cc4582122f2d587d0f4434b9ce12 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
 e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
 86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
  
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
 20d1c4ff92fbd54956334c923e1bacfea8825aa6 
  geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
  
geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
 f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
  geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
2d6921b9a2087928dffebd2dc050f3967170962b 
  
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
 66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
  
geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
 f126146d3098f009eda8388273b52758b7d0ee28 
  
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
 01151931473e882905a4443535f2c2306e34ff63 
  geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
942059e110487f3f886ef5749134190768a87eac 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
22f66a3efdb670684c0108ab22dc07c43e0265b1 
  
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 3852dee6613dd67ed85d61365c7ad6ca02306f78 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java 
00bb6fb9064b46ef5622e7e11632a36ec71097dd 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java 
1d18ed146382e36c894c72ab642e8055fd316df1 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
10931e194d20369350720736a4435aa5998ca0cc 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
a89c0d13ececb47bf7345624d4e7d128e01d6a45 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
 6955dc829330f8766c172da32795fd8ee6b98f7e 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java
 55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 
  
geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java
 9c459a9b737fc80d7a7cd0242927abf2691855b3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java 
138f3acc5abb96831af60a43560334494793d60b 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsJUnitTest.java
 2529639f200e3670cb7d108f70e2c0e9a3702401 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PersistentPartitionedRegionJUnitTest.java
 478f5e3f8827b78bc5aba5449698ce3fd3768b6c 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 47520bc8177feecf70dc0ede5a17607385b90dd3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java
 09893be48c4dd0dbd9fadb8a07484e2e84430ee7 
  
geode-core/src/test/java/org/apache/geode/internal/cac

[jira] [Commented] (GEODE-2506) Update spring dependencies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872525#comment-15872525
 ] 

ASF GitHub Bot commented on GEODE-2506:
---

GitHub user metatype opened a pull request:

https://github.com/apache/geode/pull/403

GEODE-2506 Update Spring from 4.3.2 to 4.3.6

Update Spring framework version.  Also implement a version override
strategy for transitive dependencies.  This ensures that versions
specified in gradle/dependency-versions.properties are honored.
Useful when a newer version of a transitive dependency is needed
but we'd prefer not to declare a first class dependency.

This change affects commons-beanutils which used 1.8.3 from
shiro-core but we specify 1.9.3.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/metatype/incubator-geode feature/GEODE-2506

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #403


commit 01962d6ea5be23f620434c707f683e63afd514ca
Author: Anthony Baker 
Date:   2017-02-17T20:26:59Z

GEODE-2506 Update Spring from 4.3.2 to 4.3.6

Update Spring framework version.  Also implement a version override
strategy for transitive dependencies.  This ensures that versions
specified in gradle/dependency-versions.properties are honored.
Useful when a newer version of a transitive dependency is needed
but we'd prefer not to declare a first class dependency.

This change affects commons-beanutils which used 1.8.3 from
shiro-core but we specify 1.9.3.




> Update spring dependencies
> --
>
> Key: GEODE-2506
> URL: https://issues.apache.org/jira/browse/GEODE-2506
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> Update Spring dependencies from 4.3.2 to 4.3.6 to pick up latest maintenance 
> and security fixes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6

[metatype]

GitHub user metatype opened a pull request:

https://github.com/apache/geode/pull/403

GEODE-2506 Update Spring from 4.3.2 to 4.3.6

Update Spring framework version.  Also implement a version override
strategy for transitive dependencies.  This ensures that versions
specified in gradle/dependency-versions.properties are honored.
Useful when a newer version of a transitive dependency is needed
but we'd prefer not to declare a first class dependency.

This change affects commons-beanutils which used 1.8.3 from
shiro-core but we specify 1.9.3.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/metatype/incubator-geode feature/GEODE-2506

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #403


commit 01962d6ea5be23f620434c707f683e63afd514ca
Author: Anthony Baker 
Date:   2017-02-17T20:26:59Z

GEODE-2506 Update Spring from 4.3.2 to 4.3.6

Update Spring framework version.  Also implement a version override
strategy for transitive dependencies.  This ensures that versions
specified in gradle/dependency-versions.properties are honored.
Useful when a newer version of a transitive dependency is needed
but we'd prefer not to declare a first class dependency.

This change affects commons-beanutils which used 1.8.3 from
shiro-core but we specify 1.9.3.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872514#comment-15872514
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 2e3a88f7bc61796042140aa92b44390b9970b53e in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2e3a88f ]

GEODE-2142: Spotless


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872512#comment-15872512
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit b3ec80bc72fee3a40da297945a85d8df6c2a6460 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b3ec80b ]

GEODE-2142: Removal of non-compliant org.json implementation.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872495#comment-15872495
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 3910177d15a08ab297e38d5dca866fa9488801b5 in geode's branch 
refs/heads/feature/OrgJsonRefactor from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3910177 ]

GEODE-2142: Removal of non-compliant org.json implementation.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2506) Update spring dependencies

[Anthony Baker (JIRA)]

Anthony Baker created GEODE-2506:


 Summary: Update spring dependencies
 Key: GEODE-2506
 URL: https://issues.apache.org/jira/browse/GEODE-2506
 Project: Geode
  Issue Type: Improvement
  Components: build
Reporter: Anthony Baker


Update Spring dependencies from 4.3.2 to 4.3.6 to pick up latest maintenance 
and security fixes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2414) Determine a mechanism to stream a zip file from server to locator

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872414#comment-15872414
 ] 

ASF subversion and git services commented on GEODE-2414:


Commit 6c141f9e1f6c086ddb7507418036efc449bcf22a in geode's branch 
refs/heads/feature/GEODE-2267 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6c141f9 ]

GEODE-2414: Destroy export logs region after using it to avoid unnecessary 
network traffic


> Determine a mechanism to stream a zip file from server to locator
> -
>
> Key: GEODE-2414
> URL: https://issues.apache.org/jira/browse/GEODE-2414
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Our export command will execute a function on servers (one at a time) to 
> build up a zip file of the artifacts for that server.  Then, the zip file 
> needs to be sent back to the locator, so that the locator can aggregate 
> together the files from all servers.  However, we need to make sure to 
> chunk/stream the data that we send from server to locator so that neither 
> member will run out of memory if the file is very large.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2505) create region command should verify region attributes

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2505:
---

 Summary: create region command should verify region attributes
 Key: GEODE-2505
 URL: https://issues.apache.org/jira/browse/GEODE-2505
 Project: Geode
  Issue Type: Improvement
  Components: gfsh
Reporter: Swapnil Bawaskar


The gfsh {{create region}} command tries to be idempotent. If I try to create 
the same region twice I get the below message:
{noformat}
Member | Status
-- | --
serv1  | Skipping "serv1". Region "foo" already exists.
{noformat}

However, when a user is using a gfsh script to configure a cluster, and 
inadvertently changes the region attributes the {{create region}} command will 
still succeed. 

{noformat}
gfsh>create region --name=foo --type=REPLICATE
Member | Status
-- | 
serv1  | Region "/foo" created on "serv1"

gfsh>create region --name=foo --type=PARTITION
Member | Status
-- | --
serv1  | Skipping "serv1". Region "foo" already exists.
{noformat}

We should verify the region attributes, and if the attributes don't match we 
should log an error asking the user to export the data from the existing 
region, destroy the region, create the region again with new attributes and 
import the data.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: PROXY and CACHING_PROXY regions on Client

[Anilkumar Gingade]

I see caching-proxy and proxy as:

CACHING_PROXY - A VIEW (table view) to the data source, which
represents/stores data for a particular business requirement, this view is
created by interest registration or adding the entries through put (changes
are reflected in source region) or get (fetched from source). Any operation
performed will be applied on this local view, as the business logic is
applied to this data.
E.g. storing specific portfolios for a fund, and calculation will be made
for these portfolios.

PROXY - A handle to remote data source, with limited support/availability
on the source data. Similar to executing queries on remote table. The
limitation could be with:
Changing or altering the region - As NoSQL doesn't have strong security
features like SQL databases (for a reason, not to be as complex as
database).
Retrieving all the source data (entries, keys, values) - Most of the time
the clients are only interested in the data which are required for their
use-cases, this could be done by executing query or providing filter
support on collection apis.

-Anil.



On Wed, Feb 15, 2017 at 2:50 PM, Darrel Schneider 
wrote:

> The following is in regard to methods on Region and how they behave on a
> PROXY.
> I agree with Mike that changing destroyRegion on a PROXY to now also
> destroy the region on the server might cause existing users problems. It is
> odd that they would have used this method from a client since they could
> have instead called localDestroyRegion and, as a client, a would want to be
> careful not to destroy the server state region since I am not able to
> recreate it. But they may have found destroyRegion left the server alone
> and so used it because its method name is shorter. So I agree that it would
> be safer to leave this method alone.
>
> But for all the other methods that let you inspect the data in a Region
> using a PROXY does anyone see a problem with fixing them to tell you what
> is on the server? All these methods currently are noops (i.e. return 0 for
> size always, return an empty set always for keys) so would anyone be happy
> with the current implementation of them? Would fixing these to tell you the
> actual size of the Region your PROXY delegates to break an existing
> application?
>
> If you create a PARTITIONED_PROXY on a member of a cluster then it forwards
> all these operations to a member that has data. But if you create a
> REPLICATE_PROXY on a member of a cluster none of these same operations are
> fowarded. Same goes for PROXY on a client. I think all of these methods
> should be brought in line with the PARTITIONED_PROXY behavior.
>
> I found that "getSnapshotService" on a client PROXY does forward its
> operations to the server. So its behavior does not need to change.
>
>
> On Wed, Feb 15, 2017 at 12:33 PM, Swapnil Bawaskar 
> wrote:
>
> > Re: breaking existing code; we could throw UnsupportedOperationException
> > for these two methods:
> > - invalidateRegion()
> > - destroyRegion()
> >
> > I do not see anyone using/depending on invalidateRegion, since the
> behavior
> > currently is a no-op.
> > destroyRegion currently only gets rid of the handle to the region, so it
> is
> > most likely being used when the client is shutting down, so fixing
> existing
> > applications should be straight forward.
> >
> > On Wed, Feb 15, 2017 at 12:27 PM Swapnil Bawaskar 
> > wrote:
> >
> > > @John The intention behind this proposal is to make Geode client
> > > development easy for new users. So, looking at this as a new user, I
> > would
> > > say that having to "create" a PROXY region only to find out that it
> does
> > > nothing on the server, is more confusing than an overloaded
> getRegion().
> > >
> > > To summarize, the proposal for getRegion() is:
> > > 1. lookup if the region exists already and return it; this applies to
> > > regions that have been created through API and cache.xml. This is the
> > > current behavior.
> > > 2. If the region does not exist:
> > > 2.a. check if it exists on the server, if so create a PROXY region
> under
> > > the covers and return it. Do this only on the client
> > > 2.b. If it does not exist on the server, throw an exception.
> > >
> > >
> > >
> > > On Wed, Feb 15, 2017 at 9:38 AM John Blum  wrote:
> > >
> > > @Eric-
> > >
> > > Hmm...
> > >
> > > Well, I'd argue that it is still confusing to "*overload*" the purpose
> of
> > > getRegion("path") to dually "*get*" (the primary function/purpose) and
> > also
> > > "*create*" (secondary).
> > >
> > > I'd also say that the getRegion("path") API call is not exclusive to a
> > > *ClientCache*, particularly since getRegion("path") is on RegionService
> > > <
> > > http://data-docs-samples.cfapps.io/docs-gemfire/latest/
> > javadocs/japi/com/gemstone/gemfire/cache/RegionService.
> > html#getRegion(java.lang.String)
> > > >
> > > [1],
> > > which both ClientCache and Cache implement, indirectly through
> > > GemFireCache,
> > > I might add.  Therefore, getRegion("path") has a com

[jira] [Commented] (GEODE-2476) Replace gfcpp with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872323#comment-15872323
 ] 

ASF GitHub Bot commented on GEODE-2476:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101825168
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
 #pragma once
 
-#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_
-#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_
+#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_
--- End diff --

I see an argument that `include/geode/` is the root for the public headers, 
therefore the guards should be `GEODE_ATTRIBUTESFACTORY_H_`.


> Replace gfcpp with geode
> 
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101825168
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
 #pragma once
 
-#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_
-#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_
+#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_
--- End diff --

I see an argument that `include/geode/` is the root for the public headers, 
therefore the guards should be `GEODE_ATTRIBUTESFACTORY_H_`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2476) Replace gfcpp with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872316#comment-15872316
 ] 

ASF GitHub Bot commented on GEODE-2476:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101824812
  
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
 add_subdirectory(cryptoimpl)
 add_subdirectory(dhimpl)
 add_subdirectory(sqliteimpl)
-add_subdirectory(gfcpp)
+add_subdirectory(getversion)
--- End diff --

If they are relying on it then their scripts will break either way. There 
are better ways to get version. I don't think I have ever seen anyone anywhere 
use it. I don't even see it in our documents. I say kill it!


> Replace gfcpp with geode
> 
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101824812
  
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
 add_subdirectory(cryptoimpl)
 add_subdirectory(dhimpl)
 add_subdirectory(sqliteimpl)
-add_subdirectory(gfcpp)
+add_subdirectory(getversion)
--- End diff --

If they are relying on it then their scripts will break either way. There 
are better ways to get version. I don't think I have ever seen anyone anywhere 
use it. I don't even see it in our documents. I say kill it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #400: Add geode-redis to assembly.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872271#comment-15872271
 ] 

ASF GitHub Bot commented on GEODE-2440:
---

GitHub user mmartell opened a pull request:

https://github.com/apache/geode-native/pull/17

GEODE-2440: Switch hashcode() return type.

- Convert from uint32_t to int32_t to match server.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmartell/geode-native feature/GEODE-2440

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit b7bc7a8e8cb71de5a1aded62bd88163517f07e4b
Author: Mike Martell 
Date:   2017-02-17T17:53:29Z

GEODE-2440: Switch hashcode() return type.

- Convert from uint32_t to int32_t to match server.




> Fix CacheableKey::hashcode to int32_t to match Server.
> --
>
> Key: GEODE-2440
> URL: https://issues.apache.org/jira/browse/GEODE-2440
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #17: GEODE-2440: Switch hashcode() return type.

[mmartell]

GitHub user mmartell opened a pull request:

https://github.com/apache/geode-native/pull/17

GEODE-2440: Switch hashcode() return type.

- Convert from uint32_t to int32_t to match server.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmartell/geode-native feature/GEODE-2440

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit b7bc7a8e8cb71de5a1aded62bd88163517f07e4b
Author: Mike Martell 
Date:   2017-02-17T17:53:29Z

GEODE-2440: Switch hashcode() return type.

- Convert from uint32_t to int32_t to match server.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872264#comment-15872264
 ] 

ASF GitHub Bot commented on GEODE-2497:
---

GitHub user bschuchardt opened a pull request:

https://github.com/apache/geode/pull/402

GEODE-2497 surprise members are never timed out during startup

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2497

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #402


commit 8d45ca22737282abe279d3c863478f904f2e1926
Author: Bruce Schuchardt 
Date:   2017-02-17T18:17:21Z

GEODE-2497 surprise members are never timed out during startup

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.




> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #402: GEODE-2497 surprise members are never timed out dur...

[bschuchardt]

GitHub user bschuchardt opened a pull request:

https://github.com/apache/geode/pull/402

GEODE-2497 surprise members are never timed out during startup

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2497

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #402


commit 8d45ca22737282abe279d3c863478f904f2e1926
Author: Bruce Schuchardt 
Date:   2017-02-17T18:17:21Z

GEODE-2497 surprise members are never timed out during startup

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872247#comment-15872247
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 8d45ca22737282abe279d3c863478f904f2e1926 in geode's branch 
refs/heads/feature/GEODE-2497 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8d45ca2 ]

GEODE-2497 surprise members are never timed out during startup

Moved the creation of the timer to GMSMembershipManager.started()

Removed write-lock in timer-creation method since it's only called from
one place now

Altered the way that the timer-creation method finds the
InternalDistributedSystem.  The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.

Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.

Altered the surprise-member unit test to run faster.  It now completes in
under 10 seconds.


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2504) Add first class support for SortedSet

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2504:
---

 Summary: Add first class support for SortedSet
 Key: GEODE-2504
 URL: https://issues.apache.org/jira/browse/GEODE-2504
 Project: Geode
  Issue Type: New Feature
Reporter: Swapnil Bawaskar


In addition to Region which implements {{java.util.ConcurrentHashMap}} we 
should add first class support for other data structures like SortedMap i.e. 
implement {{java.util.ConcurrentSkipListMap}}.

Our Redis implementation currently supports Redis SortedSets that are backed by 
Partitioned Region; a scalable SortedMap implementation would be useful for 
non-redis users as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2503) Add first class support for list

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2503:
---

 Summary: Add first class support for list
 Key: GEODE-2503
 URL: https://issues.apache.org/jira/browse/GEODE-2503
 Project: Geode
  Issue Type: New Feature
Reporter: Swapnil Bawaskar


In addition to Region which implements {{java.util.ConcurrentHashMap}} we 
should add first class support for other data structures like list i.e. 
implement {{java.util.ConcurrentLinkedDeque}}.

Our Redis implementation currently supports Redis lists that are backed by 
Partitioned Region; a scalable list implementation would be useful for 
non-redis users as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2502) Resolve ACE license compatibility

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2502:
-
Priority: Blocker  (was: Major)

> Resolve ACE license compatibility
> -
>
> Key: GEODE-2502
> URL: https://issues.apache.org/jira/browse/GEODE-2502
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>Priority: Blocker
>
> See LEGAL-289.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2502) Resolve ACE license compatibility

[Anthony Baker (JIRA)]

Anthony Baker created GEODE-2502:


 Summary: Resolve ACE license compatibility
 Key: GEODE-2502
 URL: https://issues.apache.org/jira/browse/GEODE-2502
 Project: Geode
  Issue Type: Sub-task
  Components: native client
Reporter: Anthony Baker


See LEGAL-289.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-1416) Prepare geode-native for a source release

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-1416:
-
Summary: Prepare geode-native for a source release  (was: Merge native 
client code to develop branch)

> Prepare geode-native for a source release
> -
>
> Key: GEODE-1416
> URL: https://issues.apache.org/jira/browse/GEODE-1416
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Anthony Baker
>
> The next-gen-native-client-software-grant branch [1] contains the GemFire 
> native client. In order to merge this code into the develop branch, we need 
> to: 
> 1) Review the code and determine what 3rd party libraries are bundled with 
> the source and binary distributions. These will need to be properly 
> attributed in the respective LICENSE and NOTICE files. 
> 2) Update the source headers to remove old copyrights and replace with the 
> Apache source header. 
> 3) Improve the build process to make it simpler for contributors and users. 
> This includes writing up build instructions. 
> 4) Incorporate other suggestions from the community. 
> [1] 
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=shortlog;h=refs/heads/next-gen-native-client-software-grant



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: for discussion: separate website into its own repo

[Kirk Lund]

+1

On Thu, Feb 16, 2017 at 4:45 PM, Joey McAllister 
wrote:

> +1 to Karen's suggestion of moving the website to its own repo.
>
> +1 to Dan's suggestion scripting the website build/publishing with a CI
> system based on commits.
>
> On Thu, Feb 16, 2017 at 4:38 PM Dan Smith  wrote:
>
> > +1
> >
> > I think the current setup is confusing, because the website is supposed
> to
> > include docs that are generated from the last release, but the site
> > instructions say the site should be generated from develop. A separate
> repo
> > with a single branch will probably reduce confusion.
> >
> > We also need to script the website building and publishing, and ideally
> > have the publishing done by a CI system based on commits. It looks like
> > some other projects are talking about doing this with jenkins jenkins -
> see
> > INFRA-10722 for example.
> >
> > -Dan
> >
> > On Thu, Feb 16, 2017 at 4:10 PM, Karen Miller 
> wrote:
> >
> > > I think that the website content that is currently in geode/geode-site
> > > ought to be moved to its own repository.  The driving reason for this
> is
> > > that changes to the website occur on a different schedule than code
> > > releases.  We often want to add a new committer's name or a new
> > > event, and these items are not associated with sw releases. A new
> website
> > > release that comes from the develop branch may have commits that
> > > should not yet be made public.
> > >
> > > Are there downsides to separating the website content into its own
> repo?
> > >
> >
>

Re: Build failed in Jenkins: Geode-nightly #751

[Dan Smith]

This AnalyzeSerializablesJUnitTest failure is my fault. It's fixed now.

-Dan

On Fri, Feb 17, 2017 at 8:55 AM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> See 
>
> Changes:
>
> [lhughesgodfrey] Added keys for Lynn Hughes-Godfrey
>
> [gzhou] GEODE-1956: fix the race condition that cause the vm only hosts 1
>
> [abaker] Revert "GEODE-1956: fix the race condition that cause the vm only
> hosts
>
> [hkhamesra] Removed "-SNAPSHOT" from gradle.properties
>
> [bschuchardt] GEODE-2368 Need to fix log message in DirectChannel
>
> [bschuchardt] GEODE-1965 Create backward-compatibility unit test framework
>
> [upthewaterspout] GEODE-2386: Wait until classpath doesn't contain
> gradle-worker.jar
>
> [upthewaterspout] GEODE-2386 Don't call System.setProperties(null) when
> rule is used twice
>
> [hkhamesra] Updated KEYS file.
>
> [bschuchardt] GEODE-2433  Backwards compatibility tests are not actually
> running
>
> [bschuchardt] GEODE-2433 Backwards compatibility tests are not actually
> running
>
> [upthewaterspout] GEODE-2432: Disable maven artifacts for geode-benchmarks
>
> [bschuchardt] GEODE-2433  Backwards compatibility tests are not actually
> running
>
> [upthewaterspout] GEODE-2434: Generate old version classpaths in doLast
>
> [jiliao] GEODE-2430: Refactor ZipUtils
>
> [jiliao] GEODE-2430: Remove jar and zip files from test resources
>
> [jiliao] GEODE-2430: Fix failing tests
>
> [dbarnes] GEODE-2052: Docs to segregate types of properties Added Server /
> Locator
>
> [klund] GEODE-2474: refactor code to use SystemUtils for OS system
> properties
>
> [klund] GEODE-2481: extract default properties generation to its own class
>
> [huynhja] GEODE-2491: Reduce logging of handled exceptions in
> LuceneEventListener
>
> [dbarnes] GEODE-2052 (docs) Add server-only flag to deploy-working-dir
> property
>
> [kmiller] Updated index.html.
>
> [kmiller] Add 1.1.0 manual and docs/index.html page to website content.
>
> [klund] GEODE-2496: apply Flaky category to flaky test due to
> ConnectExceptions
>
> [kmiller] GEODE-2498 Revise published 1.1.0 manual, so it has no
> references to
>
> [upthewaterspout] GEODE-2402: Write to the lucene region buckets using a
> callback argument
>
> [upthewaterspout] Reducing the time taken by a test that was waiting 60
> seconds
>
> [upthewaterspout] Make sure IndexRepositorySpy doesn't mock the same
> object twice
>
> --
> [...truncated 546 lines...]
> org/apache/geode/internal/cache/InitialImageOperation$
> GIITestHook,false,isRunning:boolean,region_name:java/lang/
> String,type:org/apache/geode/internal/cache/InitialImageOperation$
> GIITestHookType
>
>
> If the class is not persisted or sent over the wire add it to the
> excludedClasses.txt file in the
> /org/apache/geode/codeAnalysis/ directory.  Otherwise if this doesn't
> break backward compatibility move the file actualSerializables.dat to
> the
> codeAnalysis test directory and rename to sanctionedSerializables.txt
> at org.junit.Assert.fail(Assert.java:88)
> at org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest.
> testSerializables(AnalyzeSerializablesJUnitTest.java:234)
>
> 3363 tests completed, 1 failed, 165 skipped
> :geode-core:integrationTest FAILED
> :geode-cq:assemble
> :geode-cq:compileTestJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-cq:processTestResources
> :geode-cq:testClasses
> :geode-cq:checkMissedTests
> :geode-cq:spotlessJavaCheck
> :geode-cq:spotlessCheck
> :geode-cq:test
> :geode-cq:check
> :geode-cq:build
> :geode-cq:distributedTest
> :geode-cq:flakyTest
> :geode-cq:integrationTest
> :geode-json:assemble
> :geode-json:compileTestJava UP-TO-DATE
> :geode-json:processTestResources UP-TO-DATE
> :geode-json:testClasses UP-TO-DATE
> :geode-json:checkMissedTests UP-TO-DATE
> :geode-json:spotlessJavaCheck
> :geode-json:spotlessCheck
> :geode-json:test UP-TO-DATE
> :geode-json:check
> :geode-json:build
> :geode-json:distributedTest UP-TO-DATE
> :geode-json:flakyTest UP-TO-DATE
> :geode-json:integrationTest UP-TO-DATE
> :geode-junit:javadoc
> :geode-junit:javadocJar
> :geode-junit:sourcesJar
> :geode-junit:signArchives SKIPPED
> :geode-junit:assemble
> :geode-junit:compileTestJava
> :geode-junit:processTestResources UP-TO-DATE
> :geode-junit:testClasses
> :geode-junit:checkMissedTests
> :geode-junit:spotlessJavaCheck
> :geode-junit:spotlessCheck
> :geode-junit:test
> :geode-junit:check
> :geode-junit:build
> :geode-junit:distributedTest
> :geode-junit:flakyTest
> :geode-junit:integrationTest
> :geode-lucene:assemble
> :geode-lucene:compileTestJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: So

[jira] [Resolved] (GEODE-2498) Revise 1.1.0 manual to remove references to 1.0.0-incubating

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-2498.

Resolution: Fixed
  Assignee: Karen Smoler Miller

No fixed version assigned, as this was a 1.1.0 issue that was fixed after the 
release.  The website is now changed, and both the 1.1.0 and 1.2 (assumed next 
version number) manuals are affected by the change.

> Revise 1.1.0 manual to remove references to 1.0.0-incubating
> 
>
> Key: GEODE-2498
> URL: https://issues.apache.org/jira/browse/GEODE-2498
> Project: Geode
>  Issue Type: Bug
>  Components: docs, web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> There are two errant instances within the Geode 1.1.0 manual that say 
> 1.0.0-incubating.  This task is to remove these references, and further, to 
> revise the prose such that it does not contain a version number that would 
> need to be changed in future releases.  That  would avoid the mistake that 
> occurred with the 1.1.0 manual.
> The 2 instances are within files
> * {{geode-docs/about_geode.html.md.erb}}
> * {{geode-docs/prereq_and_install.html.md.erb}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #401: Remove generated html files

[metatype]

GitHub user metatype opened a pull request:

https://github.com/apache/geode/pull/401

Remove generated html files

Delete generated html files from geode-site/website/content/docs/guide
since these files can be rebuilt from geode-docs/ and the generated
content is only used in the asf-site branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/metatype/incubator-geode develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #401


commit 43fcadee6cfd57ee4191ae200d5c6ce20ab123b1
Author: Anthony Baker 
Date:   2017-02-17T16:56:48Z

Remove generated html files

Delete generated html files from geode-site/website/content/docs/guide
since these files can be rebuilt from geode-docs/ and the generated
content is only used in the asf-site branch.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #751

[Apache Jenkins Server]

See 

Changes:

[lhughesgodfrey] Added keys for Lynn Hughes-Godfrey

[gzhou] GEODE-1956: fix the race condition that cause the vm only hosts 1

[abaker] Revert "GEODE-1956: fix the race condition that cause the vm only hosts

[hkhamesra] Removed "-SNAPSHOT" from gradle.properties

[bschuchardt] GEODE-2368 Need to fix log message in DirectChannel

[bschuchardt] GEODE-1965 Create backward-compatibility unit test framework

[upthewaterspout] GEODE-2386: Wait until classpath doesn't contain 
gradle-worker.jar

[upthewaterspout] GEODE-2386 Don't call System.setProperties(null) when rule is 
used twice

[hkhamesra] Updated KEYS file.

[bschuchardt] GEODE-2433  Backwards compatibility tests are not actually running

[bschuchardt] GEODE-2433 Backwards compatibility tests are not actually running

[upthewaterspout] GEODE-2432: Disable maven artifacts for geode-benchmarks

[bschuchardt] GEODE-2433  Backwards compatibility tests are not actually running

[upthewaterspout] GEODE-2434: Generate old version classpaths in doLast

[jiliao] GEODE-2430: Refactor ZipUtils

[jiliao] GEODE-2430: Remove jar and zip files from test resources

[jiliao] GEODE-2430: Fix failing tests

[dbarnes] GEODE-2052: Docs to segregate types of properties Added Server / 
Locator

[klund] GEODE-2474: refactor code to use SystemUtils for OS system properties

[klund] GEODE-2481: extract default properties generation to its own class

[huynhja] GEODE-2491: Reduce logging of handled exceptions in 
LuceneEventListener

[dbarnes] GEODE-2052 (docs) Add server-only flag to deploy-working-dir property

[kmiller] Updated index.html.

[kmiller] Add 1.1.0 manual and docs/index.html page to website content.

[klund] GEODE-2496: apply Flaky category to flaky test due to ConnectExceptions

[kmiller] GEODE-2498 Revise published 1.1.0 manual, so it has no references to

[upthewaterspout] GEODE-2402: Write to the lucene region buckets using a 
callback argument

[upthewaterspout] Reducing the time taken by a test that was waiting 60 seconds

[upthewaterspout] Make sure IndexRepositorySpy doesn't mock the same object 
twice

--
[...truncated 546 lines...]

org/apache/geode/internal/cache/InitialImageOperation$GIITestHook,false,isRunning:boolean,region_name:java/lang/String,type:org/apache/geode/internal/cache/InitialImageOperation$GIITestHookType


If the class is not persisted or sent over the wire add it to the 
excludedClasses.txt file in the 
/org/apache/geode/codeAnalysis/ directory.  Otherwise if this doesn't 
break backward compatibility move the file actualSerializables.dat to the 
codeAnalysis test directory and rename to sanctionedSerializables.txt
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest.testSerializables(AnalyzeSerializablesJUnitTest.java:234)

3363 tests completed, 1 failed, 165 skipped
:geode-core:integrationTest FAILED
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:as

[jira] [Commented] (GEODE-2476) Replace gfcpp with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872092#comment-15872092
 ] 

ASF GitHub Bot commented on GEODE-2476:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101796694
  
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
 add_subdirectory(cryptoimpl)
 add_subdirectory(dhimpl)
 add_subdirectory(sqliteimpl)
-add_subdirectory(gfcpp)
+add_subdirectory(getversion)
--- End diff --

I'm totally cool with deleting it. I didn't because it's been part of the 
install; some users may rely on it to determine version?


> Replace gfcpp with geode
> 
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101796694
  
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
 add_subdirectory(cryptoimpl)
 add_subdirectory(dhimpl)
 add_subdirectory(sqliteimpl)
-add_subdirectory(gfcpp)
+add_subdirectory(getversion)
--- End diff --

I'm totally cool with deleting it. I didn't because it's been part of the 
install; some users may rely on it to determine version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2476) Replace gfcpp with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872090#comment-15872090
 ] 

ASF GitHub Bot commented on GEODE-2476:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101796462
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
 #pragma once
 
-#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_
-#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_
+#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_
--- End diff --

Google specification is project name, directory name, file name.


> Replace gfcpp with geode
> 
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101796462
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
 #pragma once
 
-#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_
-#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_
+#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_
--- End diff --

Google specification is project name, directory name, file name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101796329
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -20,7 +20,7 @@
  * limitations under the License.
  */
 
-#include "gfcpp_globals.hpp"
+#include "geode_globals.hpp"
 #include "gf_types.hpp"
--- End diff --

That's a separate JIRA ticket and hence will be a separate (upcoming) PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2476) Replace gfcpp with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872089#comment-15872089
 ] 

ASF GitHub Bot commented on GEODE-2476:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101796329
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -20,7 +20,7 @@
  * limitations under the License.
  */
 
-#include "gfcpp_globals.hpp"
+#include "geode_globals.hpp"
 #include "gf_types.hpp"
--- End diff --

That's a separate JIRA ticket and hence will be a separate (upcoming) PR.


> Replace gfcpp with geode
> 
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-348) MemoryThresholdsOffHeapDUnitTest.testPRClientPutRejection fail intermittently with "Expected to go normal"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872083#comment-15872083
 ] 

ASF GitHub Bot commented on GEODE-348:
--

Github user echobravopapa closed the pull request at:

https://github.com/apache/geode-native/pull/14


> MemoryThresholdsOffHeapDUnitTest.testPRClientPutRejection fail intermittently 
> with "Expected to go normal"
> --
>
> Key: GEODE-348
> URL: https://issues.apache.org/jira/browse/GEODE-348
> Project: Geode
>  Issue Type: Bug
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>  Labels: CI
> Fix For: 1.0.0-incubating.M1
>
>
> This test has been failing intermittently on internal builds. Here is an 
> example:
> {code}
>   at 
> com.gemstone.gemfire.cache.management.MemoryThresholdsOffHeapDUnitTest.doClientServerTest(MemoryThresholdsOffHeapDUnitTest.java:1455)
>   at 
> com.gemstone.gemfire.cache.management.MemoryThresholdsOffHeapDUnitTest.testPRClientPutRejection(MemoryThresholdsOffHeapDUnitTest.java:1301)
> [snip]
> Caused by: junit.framework.AssertionFailedError: Event never occurred after 
> 5000 ms: Expected to go normal
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.TestCase.fail(TestCase.java:227)
>   at 
> dunit.DistributedTestCase.waitForCriterion(DistributedTestCase.java:1162)
>   at 
> com.gemstone.gemfire.cache.management.MemoryThresholdsOffHeapDUnitTest$42.run(MemoryThresholdsOffHeapDUnitTest.java:1473)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #14: GEODE-348: fix cast to be in compliance with ...

[echobravopapa]

Github user echobravopapa closed the pull request at:

https://github.com/apache/geode-native/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: GeodeRedisAdapter improvments/feedback

[Hitesh Khamesra]

Right..

Sent from Yahoo Mail on Android 
 
  On Fri, Feb 17, 2017 at 8:05 AM, Wes Williams wrote:   
I'm not clear on the reference to "I like the idea of first class data
structures like Lists and Sorted Sets."

Is the suggestion here to extend Geode to not only support a distributed
ConcurrentHashMap but also distributed ConcurrentList's and
ConcurrentSortedSet's?


*Wes Williams | Pivotal Advisory **Data Engineer*
781.606.0325
http://pivotal.io/big-data/pivotal-gemfire

On Thu, Feb 16, 2017 at 10:34 AM, Michael Stolz  wrote:

> I like the idea of first class data structures like Lists and Sorted Sets.
>
> I'm not sure which side of the fence I'm on in terms of very large objects
> and using Regions to represent them. Feels very heavy because of all the
> overhead of a Region entry in Geode (over 300 bytes per entry).
>
> I think the main reason people will want to use Geode in place of Redis
> will be horizontal scale in terms of the number of structures first, size
> of structures second, ability to get additional enterprise features like
> synchronous instead of asynchronous replication from masters to slaves
> (zero-data-loss) multi-site and even multi-cloud use cases (WAN Gateway).
>
>
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: +1-631-835-4771
>
> On Wed, Feb 15, 2017 at 8:09 PM, Swapnil Bawaskar 
> wrote:
>
> > I think we as a community need to determine what value do we want to add
> > with the Redis adapter. Redis already does a great job storing small data
> > structures in memory and sharding them. We do a great job of making sure
> > that these data structures are horizontally scalable; why would we want
> to
> > replicate what another open source project is already implementing?
> >
> > Having said that, I would like to see a configuration property that lets
> > the user chose between a single server vs a distributed collection.
> >
> >
> > > I think we could have the following options:
> > >
> > >  1. have a property that could be set to use either single server
> > >    collections over use the current distributed collection
> > >  2. have first class collection implementations that are distributed by
> > >    nature, as using key:value as the hammer for all does not make
> sense
> > >
> >
> > I don't think these options are mutually exclusive. We should make lists
> > and SortedSets first class data structures in Geode alongside regions.
> >
>
  

Passed: apache/geode#2055 (rel/v1.1.0manualrev-2017-02-16 - 7f0f4d5)

[Travis CI]

Build Update for apache/geode
-

Build: #2055
Status: Passed

Duration: 9 minutes and 15 seconds
Commit: 7f0f4d5 (rel/v1.1.0manualrev-2017-02-16)
Author: Karen Miller
Message: GEODE-2498 Revise published 1.1.0 manual, so it has
no references to 1.0.0-incubating

View the changeset: 
https://github.com/apache/geode/compare/rel/v1.1.0manualrev-2017-02-16

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/202450652

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 56767: GEODE-2402: Write to the lucene region buckets using a callback argument

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56767/#review165900
---


Ship it!




fix and ship it.

- xiaojian zhou


On Feb. 16, 2017, 9:15 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56767/
> ---
> 
> (Updated Feb. 16, 2017, 9:15 p.m.)
> 
> 
> Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a callback argument when writing to the file and chunk regions. 
> The file and chunk regions now have a partition listener to
> route the put to the correct bucket.
> 
> The reason for all of this is that in some cases, the core code can can
> send a message that only includes the PR id and the key. We need want
> the core to be able to resolve the correct bucket from just those
> things, which requires having the PartitionListener that uses the 
> callback argument.
> 
> Note that I'm still writing directly to the BucketRegions, rather than
> the partition region. I had some changes to write to the partitioned region,
> but I'm seeing some filesystem corruption with those changes so I'd like
> to just get this much in at that point.
> 
> Added a test of putting to the file and chunk regions during GII, which
> is the case where the core code sends a message that includes only the PR id
> and the key.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
>  3ec8152cfe43b7499fe52ba31bdf2d9e1df2d48f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalDataSet.java 
> c4858dc168a0c26750e28dff280197bad3164185 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 00401e9ac7adfd5e3e8962476bddc6c9a8281af4 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  44f84277363b9e8f6bba8407c7f02609a2c2150d 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java
>  57dd0a56882b4087770348c3f58df29df9fdc893 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  53b4e083372127ef5670324bf3b687986d7f58bf 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/directory/RegionDirectory.java
>  362cf932f265cd4b6095cc1c790b7f1bcbc3b259 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java
>  f3975bf4bae8e28d6a9329788e939f101e857897 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingFixedResolver.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingMap.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingResolver.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  f1ee9871911f7ecfd3084c464ed8b67e9f28800a 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  931edc5269fc29de8e29f3099314a12959644f3b 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java
>  dd9fa6b71f1bceccaec56eef1c6b5adc7c88c550 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  496721a5c2534e543f4f68d2285cf6e211cd5505 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java
>  78909034138d9188b19067b5112e4c366750581b 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingMapTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56767/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: GeodeRedisAdapter improvments/feedback

[Wes Williams]

I'm not clear on the reference to "I like the idea of first class data
structures like Lists and Sorted Sets."

Is the suggestion here to extend Geode to not only support a distributed
ConcurrentHashMap but also distributed ConcurrentList's and
ConcurrentSortedSet's?


*Wes Williams | Pivotal Advisory **Data Engineer*
781.606.0325
http://pivotal.io/big-data/pivotal-gemfire

On Thu, Feb 16, 2017 at 10:34 AM, Michael Stolz  wrote:

> I like the idea of first class data structures like Lists and Sorted Sets.
>
> I'm not sure which side of the fence I'm on in terms of very large objects
> and using Regions to represent them. Feels very heavy because of all the
> overhead of a Region entry in Geode (over 300 bytes per entry).
>
> I think the main reason people will want to use Geode in place of Redis
> will be horizontal scale in terms of the number of structures first, size
> of structures second, ability to get additional enterprise features like
> synchronous instead of asynchronous replication from masters to slaves
> (zero-data-loss) multi-site and even multi-cloud use cases (WAN Gateway).
>
>
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: +1-631-835-4771
>
> On Wed, Feb 15, 2017 at 8:09 PM, Swapnil Bawaskar 
> wrote:
>
> > I think we as a community need to determine what value do we want to add
> > with the Redis adapter. Redis already does a great job storing small data
> > structures in memory and sharding them. We do a great job of making sure
> > that these data structures are horizontally scalable; why would we want
> to
> > replicate what another open source project is already implementing?
> >
> > Having said that, I would like to see a configuration property that lets
> > the user chose between a single server vs a distributed collection.
> >
> >
> > > I think we could have the following options:
> > >
> > >  1. have a property that could be set to use either single server
> > > collections over use the current distributed collection
> > >  2. have first class collection implementations that are distributed by
> > > nature, as using key:value as the hammer for all does not make
> sense
> > >
> >
> > I don't think these options are mutually exclusive. We should make lists
> > and SortedSets first class data structures in Geode alongside regions.
> >
>

Re: for discussion: separate website into its own repo

[Udo Kohlmeyer]

+1 for grown up project with multiple repositories.

+1 Karen's multiple repos

+1 For Dan...


On 2/16/17 17:01, Greg Chase wrote:

The single repository is from our time as an incubating project.

Now we can act like a grown up project 😜

This email encrypted by tiny buttons & fat thumbs, beta voice recognition, and 
autocorrect on my iPhone.


On Feb 16, 2017, at 4:57 PM, Anilkumar Gingade  wrote:

+1

On Thu, Feb 16, 2017 at 4:45 PM, Joey McAllister 
wrote:


+1 to Karen's suggestion of moving the website to its own repo.

+1 to Dan's suggestion scripting the website build/publishing with a CI
system based on commits.


On Thu, Feb 16, 2017 at 4:38 PM Dan Smith  wrote:

+1

I think the current setup is confusing, because the website is supposed

to

include docs that are generated from the last release, but the site
instructions say the site should be generated from develop. A separate

repo

with a single branch will probably reduce confusion.

We also need to script the website building and publishing, and ideally
have the publishing done by a CI system based on commits. It looks like
some other projects are talking about doing this with jenkins jenkins -

see

INFRA-10722 for example.

-Dan

On Thu, Feb 16, 2017 at 4:10 PM, Karen Miller 

wrote:

I think that the website content that is currently in geode/geode-site
ought to be moved to its own repository.  The driving reason for this

is

that changes to the website occur on a different schedule than code
releases.  We often want to add a new committer's name or a new
event, and these items are not associated with sw releases. A new

website

release that comes from the develop branch may have commits that
should not yet be made public.

Are there downsides to separating the website content into its own

repo?

Re: [ANNOUNCE] Apache Geode release 1.1.0

[Jun Aoki]

Congrats!

On Thu, Feb 16, 2017 at 4:39 PM, Nitin Lamba  wrote:

> Great!
> Congrats team!!
>
> On Thu, Feb 16, 2017 at 3:49 PM, Greg Chase  wrote:
>
> > Awesome and congratulations!
> >
> > This email encrypted by tiny buttons & fat thumbs, beta voice
> recognition,
> > and autocorrect on my iPhone.
> >
> > > On Feb 15, 2017, at 5:34 PM, Hitesh Khamesra <
> hiteshkhame...@apache.org>
> > wrote:
> > >
> > > The Apache Geode team is proud to announce Apache Geode release version
> > 1.1.0
> > >
> > > Apache *Geode* is a data management platform that provides a
> > > database-like consistency model, reliable transaction processing and a
> > > shared-nothing architecture to maintain very low latency performance
> with
> > > high concurrency processing.
> > >
> > > The release artifacts are available at:
> > >  http://geode.apache.org/releases/
> > >
> > > To use the artifacts, please use the following documentation:
> > >  http://geode.apache.org/docs/guide/11/about_geode.html
> > >
> > > Git source:
> > >  https://git-wip-us.apache.org/repos/asf?p=geode.git;a=tag;h=
> > 1d7a03bbab47a154b59dc6a4e811f7fc4a74c941
> > >
> > > Git commit SHA1: 2286fd064a52173eab8fdcfadfb89a01e81ef728
> > >
> > > Release Notes:
> > >  https://cwiki.apache.org/confluence/display/GEODE/
> > Release+Notes#ReleaseNotes-1.1.0
> > >
> > > We would like to thank all the contributors that made the release
> > possible.
> > >
> > > Regards,
> > > Hitesh & Karen on behalf of the Apache Geode team
> >
>



-- 
Thank you,
- jun

*Pivotal*

[jira] [Commented] (GEODE-2476) Replace gfcpp with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872003#comment-15872003
 ] 

ASF GitHub Bot commented on GEODE-2476:
---

Github user mmartell commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101782908
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
 #pragma once
 
-#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_
-#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_
+#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_
--- End diff --

+1 for GEODE_ATTRIBUTES_FACTORY_H_


> Replace gfcpp with geode
> 
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2476) Replace gfcpp with geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872004#comment-15872004
 ] 

ASF GitHub Bot commented on GEODE-2476:
---

Github user mmartell commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/13#discussion_r101783052
  
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -20,7 +20,7 @@
  * limitations under the License.
  */
 
-#include "gfcpp_globals.hpp"
+#include "geode_globals.hpp"
 #include "gf_types.hpp"
--- End diff --

+1 for geode_types.hpp


> Replace gfcpp with geode
> 
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)