[GitHub] geode pull request #619: GEODE-2901: Refining session replication tests

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/619


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: slf4j-jdk

2017-07-10 Thread David Anuta
It looks like that might have been caused by my commit for GEODE-2901.
slf4j-jdk.jar is included in the Tomcat zip folder located within the
geode-assembly/build/install/apache-geode/tools/Modules/ modules directory
and the change extracts that folder.

I've created GEODE-3179  to
resolve the issue and will work on fixing it shortly.

On Mon, Jul 10, 2017 at 10:53 AM, Kirk Lund  wrote:

> Does anyone know how and where "slf4j-jdk" was added as a dependency and
> bundled jar?
>
> I get the feeling that everyone is expecting someone else (the person who
> added it?) is going to fix it. Was it added in a PR maybe?
>
> Error
> java.lang.AssertionError: The bundled jars have changed. Please make sure
> you update the licence and notice
> as described in
> https://cwiki.apache.org/confluence/display/GEODE/
> License+Guide+for+Contributors
> When fixed, copy geode-assembly/build/test/bundled_jars.txt
> to src/test/resources/expected_jars.txt
> Removed Jars
> --
> Added Jars
> --
> slf4j-jdk
> Stacktrace
> java.lang.AssertionError: The bundled jars have changed. Please make sure
> you update the licence and notice
> as described in
> https://cwiki.apache.org/confluence/display/GEODE/
> License+Guide+for+Contributors
> When fixed, copy geode-assembly/build/test/bundled_jars.txt
> to src/test/resources/expected_jars.txt
> Removed Jars
> --
> Added Jars
> --
> slf4j-jdk
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.geode.BundledJarsJUnitTest.verifyBundledJarsHaveNotChange
> d(BundledJarsJUnitTest.java:81)
>



-- 
David Anuta


[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #612 was SUCCESSFUL (with 1908 tests)

2017-07-10 Thread Spring CI

---
Spring Data GemFire > Nightly-ApacheGeode > #612 was successful.
---
Scheduled
1910 tests in total.

https://build.spring.io/browse/SGF-NAG-612/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...

2017-07-10 Thread ladyVader
Github user ladyVader commented on the issue:

https://github.com/apache/geode/pull/622
  
Looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...

2017-07-10 Thread DivineEnder
Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/622
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #623: GEODE-3156: add AcceptanceTest gradle target and ju...

2017-07-10 Thread kirklund
GitHub user kirklund opened a pull request:

https://github.com/apache/geode/pull/623

GEODE-3156: add AcceptanceTest gradle target and junit category

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [*] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [*] Is your initial contribution a single, squashed commit?

- [*] Does `gradlew build` run cleanly?

- [*] Have you written or updated unit tests to verify your changes?

- [*] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kirklund/geode acceptanceTests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #623


commit 13a68b2dc6151dd2bfa9d9c89ae6bfeafcc43cd3
Author: Kirk Lund 
Date:   2017-07-10T21:43:33Z

GEODE-3156: add AcceptanceTest gradle target and junit category




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-10 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review180088
---




geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java
Lines 96 (patched)


Deprecated text should mention the release 1st deprecated in and the API 
that user should use instead. Something like:

@deprecated As of Geode 1.3, please use getCredentials(Properties, 
DistributedMember, boolean)


- Kirk Lund


On July 6, 2017, 4:03 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 6, 2017, 4:03 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: Review Request 60347: GEODE-3097: GFSH works over HTTP with SSL

2017-07-10 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60347/#review180091
---




geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
Lines 125 (patched)


Remove catch block? Method already "throws Exception"


- Kirk Lund


On June 21, 2017, 10:48 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60347/
> ---
> 
> (Updated June 21, 2017, 10:48 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3097: GFSH works over HTTP with SSL
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
>  2da95a7c3f305aab4e615d4be7b14c19b9b31dbc 
>   
> geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
>  844e0322eecdc93c4d46c546f4df2d278c5f15cd 
> 
> 
> Diff: https://reviews.apache.org/r/60347/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>



Re: Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver

2017-07-10 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60202/#review180089
---


Ship it!




Ship It!

- Kirk Lund


On June 19, 2017, 7:08 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60202/
> ---
> 
> (Updated June 19, 2017, 7:08 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3056: fix the message for invalid partition-resolver
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
>  842802ba7b7ed34aa52974dcf327015051f22e1b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java
>  47d150d180dada8066f1e644b293c56096b2a969 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60202/diff/1/
> 
> 
> Testing
> ---
> 
> newly added test and precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: Review Request 60257: GEODE-3100/GEM-1256: move authorize* call to external SecurityService and have it available in Cache

2017-07-10 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60257/#review180087
---




geode-core/src/main/java/org/apache/geode/cache/Cache.java
Lines 444 (patched)


I think you should hold off on adding this and propose it on dev@geode. I'd 
like to see you commit everything else as soon as possible though.


- Kirk Lund


On June 21, 2017, 3 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60257/
> ---
> 
> (Updated June 21, 2017, 3 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * move the authorize* call to external SecurityService
> * Add getSecurityService() that returns the external SecuritySerfice in Cache
> * Add a getCache method in FunctionContext
> * Add a test to demonstrate the locking in GetRegionFunction and fix it.
> 
> revision 1 is a small changeset that shows all the above. 
> revision 2 is a simple rename of the internal SecurityService to 
> InternalSecurityService. It touches a lot of files, but the changes are 
> pretty autonomous.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/cache/Cache.java 
> 66a3cd8097f8b526d0bd69f3afbd2dc55fa1ac3e 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 9b23f6c1a8ed3449d8a49029d6364f1e989e367c 
>   
> geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 
> 74f05c557d3cd7bc05e0389419ef84e17d797bf4 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  15723557915e2b810270ba58a2195dda8c68 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  b682d93fd5c4b5340e2c30be72c5572e031e26ed 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  c52ccbc1cc5a293d70b177e38f03dc17c7db 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  01d99951bc70547fb311f2edbfec8dde1be799f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  2d6af1a22644d427ec2d17863cef27a8d8961491 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  f895b964794f99127f1f0c9564f3f85213e0af22 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 7d4b6d4988a836854bc2a54a40c761152a635b14 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5eaa5a4bd237d9d8954ce69323912a6be5139fd0 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> 4c229db09f59deb8d36cc56a532ea0c7d3202977 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
>  39190f3c9d6ff2403542b729ee8d9c254bf6898f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> 110d6ef2a59c652cbdc860aad745d123e3b344e5 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cefedc8bce415b97b18a32ba083ea2f257 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
>  cc78cca048c0215c2086fab80e7834419bdf65a6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
>  184aa36fc5509285001155e20d846cc717544d2f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
>  d7e354887b000aad402627acd3b9340d8101e4f8 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
>  32735b9ab17fe9467cea46096bd177902145e4bd 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652803d7b6af9e6157ba84ba842c5da58e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
>  8b896945a8f136b3081df6efec51edec304f3086 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
>  5a4a07b81b18d33e465bd3aa46ad4232b976b608 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
>  cb4b261586a3536cfd5609e627a37cbca7ecf81f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
>  610af436cd96b0663d69915d8a1b37549e4f7bc2 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
>  ae95caec718141e6567cc57cf1c24193210132fc 
>   

Re: getSizeInBytes() return type

2017-07-10 Thread Michael Stolz
I don't think it is appropriate to store objects of 2GB size in Geode.
I know we have hit networking issues with such large objects in the past.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Sun, Jul 9, 2017 at 2:13 AM, Daniel Farcovich <
daniel.farcov...@amdocs.com> wrote:

> Raising this question again.
>
> Daniel
>
> From: Daniel Farcovich
> Sent: Wednesday, July 05, 2017 1:26 PM
> To: 'dev@geode.apache.org' 
> Subject: getSizeInBytes() return type
>
>
> Hi,
> We implement getSizeInBytes() in from Sizeable interface.
> We have objects with size bigger than MAXINT, bigger than 2GB.
> What is the impact of refactoring the code to return long instead of int?
> I mean except the technical aspect of changing the return types of the
> calling functions etc.
> Which mechanisms / functionalities will be affected from this change, I
> know rebalancing will be affected for example.
>
> Thanks,
> Daniel Farcovich
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>


Failed: jinmeiliao/geode#11 (query2 - adb393d)

2017-07-10 Thread Travis CI
Build Update for jinmeiliao/geode
-

Build: #11
Status: Failed

Duration: 27 minutes and 42 seconds
Commit: adb393d (query2)
Author: Jinmei Liao
Message: create a query2 command

View the changeset: 
https://github.com/jinmeiliao/geode/compare/e715abfb9fc1^...adb393d573f2

View the full build log and details: 
https://travis-ci.org/jinmeiliao/geode/builds/252117838?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications



Build failed in Jenkins: Geode-nightly-flaky #61

2017-07-10 Thread Apache Jenkins Server
See 


Changes:

[eshu] GEODE-3015: Fix a flaky test by adding wait.

--
[...truncated 98.18 KB...]
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/classmate/1.3.1/classmate-1.3.1.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin/1.2.0.RELEASE/spring-plugin-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct-parent/1.0.0.Final/mapstruct-parent-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.10/2.8.6/jackson-module-scala_2.10-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger2/2.6.1/springfox-swagger2-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-ui/2.6.1/springfox-swagger-ui-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/hateoas/spring-hateoas/0.23.0.RELEASE/spring-hateoas-0.23.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-paranamer/2.8.6/jackson-module-paranamer-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-annotations/1.5.10/swagger-annotations-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.jar
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.jar
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-web-api:processResources
:geode-web-api:classes
:geode-assembly:docs
:geode-assembly:gfshDepsJar
:geode-common:javadocJar
:geode-common:sourcesJar
:geode-common:signArchives SKIPPED
:geode-core:javadocJar
:geode-core:raJar
:geode-core:jcaJar
:geode-core:sourcesJar
:geode-core:signArchives SKIPPED
:geode-core:webJar
:geode-cq:jar
:geode-cq:javadoc
:geode-cq:javadocJar
:geode-cq:sourcesJar
:geode-cq:signArchives SKIPPED
:geode-json:javadocJar
:geode-json:sourcesJar
:geode-json:signArchives SKIPPED
:geode-lucene:jar
:geode-lucene:javadoc
:geode-lucene:javadocJar
:geode-lucene:sourcesJar
:geode-lucene:signArchives SKIPPED
:geode-old-client-support:jar
:geode-old-client-support:javadoc
:geode-old-client-support:javadocJar
:geode-old-client-support:sourcesJar
:geode-old-client-support:signArchives SKIPPED
:geode-protobuf:jar
:geode-protobuf:javadoc
:geode-protobuf:javadocJar
:geode-protobuf:sourcesJar
:geode-protobuf:signArchives SKIPPED
:geode-pulse:javadoc
:geode-pulse:javadocJar
:geode-pulse:sourcesJar
:geode-pulse:war
:geode-pulse:signArchives SKIPPED
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-wan:jar
:geode-wan:javadoc
:geode-wan:javadocJar
:geode-wan:sourcesJar
:geode-wan:signArchives SKIPPED
:geode-web:javadoc UP-TO-DATE
:geode-web:javadocJar
:geode-web:sourcesJar
:geode-web:war
:geode-web:signArchives SKIPPED
:geode-web-api:javadoc
:geode-web-api:javadocJar
:geode-web-api:sourcesJar
:geode-web-api:war
:geode-web-api:signArchives SKIPPED
:geode-assembly:installDist
:geode-pulse:jar
:geode-assembly:compileTestJava
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core-uberjar/1.6.3/cargo-core-uberjar-1.6.3.pom
Download 
https://repo1.maven.org/maven2/org/codehaus/cargo/cargo-core/1.6.3/cargo-core-1.6.3.pom

Re: Query for JMX "Async Event Queue properties"

2017-07-10 Thread Barry Oglesby
Dinesh,

The getRegionAssociatedMembers method looks like it could be improved.

It currently does this:

- gets the distributed MBean for the region
- if one doesn't exist it returns null
- if one does exist, it gets the members for that bean (which are the
members with that region)
- if there are none, it tries to get the members using a function
- returns the members

Instead of returning null if the MBean can't be found, it could try using
the function.

I made a hack fix to do that and the query worked:

Cluster-1 gfsh>query --query="select * from
/AsyncEventQueue_db_PARALLEL_GATEWAY_SENDER_QUEUE"

Result : true
startCount : 0
endCount   : 20
Rows   : 1

DSFID | action | bucketId | callbackArgument | creationTime  |
deserializedValue |   enumListenerEvent
   | eventId |
 eventSequenceID   | initialized | key | keyToConflate |
numberOfParts |operation | possibleDuplicate |
 rawValue  | region | regionPath | regionToConflate |
  senderCallbackArgument |  serializedValue   |
serializedValueNotAvailable | serializedValueSize | shadowKey | sizeInBytes
| substituteValue | value
 | valueIsObject | valueToConflate | versionTimeStamp
- | -- |  |  | - |
- |
-- |
--- |
-- | --- | --- |
- | - |  |
- | -- | -- | -- |
 |
-- |
-- | --- | --- |
- | --- | --- |
-- | - |
--- | 
-134  | 0  | 0| null | 1499708631487 | 0
  | org.apache.geode.internal.cache.EnumListenerEvent.AFTER_CREATE |
org.apache.geode.internal.cache.EventID |
org.apache.geode.cache.wan.EventSequenceID | true| 0   | 0
| 9 | org.apache.geode.cache.Operation | false
| org.json.JSONArray | null   | /data  | /data|
org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackArgument |
org.json.JSONArray | false   | 17  |
113   | 365 | null|
org.apache.geode.internal.cache.VMCachedDeserializable | 1 | 0
  | 1499708631486

You could write your own function to do the same thing.

I tried that and got:

Cluster-1 gfsh>execute function --id=QueryAsyncEventQueueRegionFunction
--result-collector=QueryAsyncEventQueueRegionFunctionResultCollector
Execution summary

  Member ID/Name| Function Execution Result
--- |
--
server1(40603):1027 |
SenderEventImpl[id=EventIDid=25bytes;threadID=0x1|1;sequenceID=0;bucketId=0];action=0;operation=CREATE;region=/data;key=0;value=0;valueIsObject=1;numberOfParts=9;callbackArgument=GatewaySenderEventCallbackArgumen..


Thanks,
Barry Oglesby


On Fri, Jun 16, 2017 at 5:38 AM, Dinesh Akhand  wrote:

> Hi Team
>
> Regarding the following metrics:
>
> /AsyncEventQueue_XYZ_PARALLEL_GATEWAY_SENDER_QUEUE:PartitionedRegionStats.
> dataStoreEntryCount
> /AsyncEventQueue_XYZ_PARALLEL_GATEWAY_SENDER_QUEUE:PartitionedRegionStats.
> dataStoreBytesInUse
>
>
> I found only count for async queue in JMX , it called here EventQueueSize
> = PartitionedRegionStats.dataStoreEntryCount
>
> /** AsyncEventQueue Stats **/
>   public static final String ASYNCEVENTQUEUE_EVENTS_QUEUE_SIZE =
> "eventQueueSize"
>
> we having Missing  PartitionedRegionStats.dataStoreBytesInUse in JMX for
> Async Qeueue.
>
> Can you help me , which property I need to map for it.
>
> Thanks,
> Dinesh Akhand
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>


slf4j-jdk

2017-07-10 Thread Kirk Lund
Does anyone know how and where "slf4j-jdk" was added as a dependency and
bundled jar?

I get the feeling that everyone is expecting someone else (the person who
added it?) is going to fix it. Was it added in a PR maybe?

Error
java.lang.AssertionError: The bundled jars have changed. Please make sure
you update the licence and notice
as described in
https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors
When fixed, copy geode-assembly/build/test/bundled_jars.txt
to src/test/resources/expected_jars.txt
Removed Jars
--
Added Jars
--
slf4j-jdk
Stacktrace
java.lang.AssertionError: The bundled jars have changed. Please make sure
you update the licence and notice
as described in
https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors
When fixed, copy geode-assembly/build/test/bundled_jars.txt
to src/test/resources/expected_jars.txt
Removed Jars
--
Added Jars
--
slf4j-jdk
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
org.apache.geode.BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged(BundledJarsJUnitTest.java:81)


Build failed in Jenkins: Geode-nightly #892

2017-07-10 Thread Apache Jenkins Server
See 

--
[...truncated 112.76 KB...]
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources UP-TO-DATE
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:integrationTest
:geode-web:assemble

Re: getSizeInBytes() return type

2017-07-10 Thread Darrel Schneider
I agree with Jake that supporting values whose serialized size is larger
than 2G would be a big change.
Geode has a number of places in the implementation that use a byte array to
store the serialized object form and the maximum array length in Java is 2G.

On Mon, Jul 10, 2017 at 8:43 AM, Jacob Barrett  wrote:

> Daniel,
>
> A change like this would be pretty deep and impact things like off heap and
> the network protocol.
>
> You really need to consider the problems with storing such large objects
> and ask yourself if you can do something different. Transferring a large
> object requires that it be serialized into memory first so a 2GB object
> requires 2GB of contiguous memory space for the byte[]. Allocating a 2GB
> array will always be done immediately in the old generation and very high
> probability result in a stop the world (STW) GC compaction event to
> defragment the memory enough to allocate it. Every JVM that touches this
> object (clients, primary, secondaries) will be STW GC'ing on nearly every
> transmission of this object. If there are many of these objects on the
> server then STW compaction events may take longer than the server timeout
> and result in servers being ejected from the cluster. If auto
> recover/rebalancing is enabled this could cause other servers to be force
> to take on these large objects are result in them also entering a STW
> compaction event and they too could be ejected.
>
> I mention this because I have seen this happen with an application where
> they were trying to store 1GB objects. It is highly recommend that you
> restructure your objects into regions of smaller objects. Since it is
> likely your 2GB object isn't a single object but a relationship of many
> much smaller objects then this should be very easy to do.
>
> -Jake
>
>
> On Sat, Jul 8, 2017 at 11:13 PM Daniel Farcovich <
> daniel.farcov...@amdocs.com> wrote:
>
> > Raising this question again.
> >
> > Daniel
> >
> > From: Daniel Farcovich
> > Sent: Wednesday, July 05, 2017 1:26 PM
> > To: 'dev@geode.apache.org' 
> > Subject: getSizeInBytes() return type
> >
> >
> > Hi,
> > We implement getSizeInBytes() in from Sizeable interface.
> > We have objects with size bigger than MAXINT, bigger than 2GB.
> > What is the impact of refactoring the code to return long instead of int?
> > I mean except the technical aspect of changing the return types of the
> > calling functions etc.
> > Which mechanisms / functionalities will be affected from this change, I
> > know rebalancing will be affected for example.
> >
> > Thanks,
> > Daniel Farcovich
> >
> >
> > This message and the information contained herein is proprietary and
> > confidential and subject to the Amdocs policy statement,
> >
> > you may review at https://www.amdocs.com/about/email-disclaimer <
> > https://www.amdocs.com/about/email-disclaimer>
> >
>


Re: Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver

2017-07-10 Thread Emily Yeh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60202/#review180043
---


Ship it!




Ship It!

- Emily Yeh


On June 19, 2017, 7:08 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60202/
> ---
> 
> (Updated June 19, 2017, 7:08 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3056: fix the message for invalid partition-resolver
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
>  842802ba7b7ed34aa52974dcf327015051f22e1b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java
>  47d150d180dada8066f1e644b293c56096b2a969 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60202/diff/1/
> 
> 
> Testing
> ---
> 
> newly added test and precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: getSizeInBytes() return type

2017-07-10 Thread Jacob Barrett
Daniel,

A change like this would be pretty deep and impact things like off heap and
the network protocol.

You really need to consider the problems with storing such large objects
and ask yourself if you can do something different. Transferring a large
object requires that it be serialized into memory first so a 2GB object
requires 2GB of contiguous memory space for the byte[]. Allocating a 2GB
array will always be done immediately in the old generation and very high
probability result in a stop the world (STW) GC compaction event to
defragment the memory enough to allocate it. Every JVM that touches this
object (clients, primary, secondaries) will be STW GC'ing on nearly every
transmission of this object. If there are many of these objects on the
server then STW compaction events may take longer than the server timeout
and result in servers being ejected from the cluster. If auto
recover/rebalancing is enabled this could cause other servers to be force
to take on these large objects are result in them also entering a STW
compaction event and they too could be ejected.

I mention this because I have seen this happen with an application where
they were trying to store 1GB objects. It is highly recommend that you
restructure your objects into regions of smaller objects. Since it is
likely your 2GB object isn't a single object but a relationship of many
much smaller objects then this should be very easy to do.

-Jake


On Sat, Jul 8, 2017 at 11:13 PM Daniel Farcovich <
daniel.farcov...@amdocs.com> wrote:

> Raising this question again.
>
> Daniel
>
> From: Daniel Farcovich
> Sent: Wednesday, July 05, 2017 1:26 PM
> To: 'dev@geode.apache.org' 
> Subject: getSizeInBytes() return type
>
>
> Hi,
> We implement getSizeInBytes() in from Sizeable interface.
> We have objects with size bigger than MAXINT, bigger than 2GB.
> What is the impact of refactoring the code to return long instead of int?
> I mean except the technical aspect of changing the return types of the
> calling functions etc.
> Which mechanisms / functionalities will be affected from this change, I
> know rebalancing will be affected for example.
>
> Thanks,
> Daniel Farcovich
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>


[GitHub] geode pull request #611: GEODE-3145 Add new protocol to Geode JAR

2017-07-10 Thread pivotal-amurmann
Github user pivotal-amurmann closed the pull request at:

https://github.com/apache/geode/pull/611


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---