[GitHub] geode-native pull request #19: GEODE-2508: Inital work on making lib names g...

[echobravopapa]

Github user echobravopapa closed the pull request at:

https://github.com/apache/geode-native/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #19: GEODE-2508: Inital work on making lib names g...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/19#discussion_r102271148
  
--- Diff: src/cppcache/integration-test/CMakeLists.txt ---
@@ -21,7 +21,7 @@ target_link_libraries(${TEST_UTILS_LIB}
   PRIVATE
 ACE
   PUBLIC
-apache-geode
+${PRODUCT_LIB_NAME}
--- End diff --

Rather than changing the target name of the library throughout CMake by 
using a variable I suggest just controlling the output name of the binary using 
the OUTPUT_NAME property.

set_target_properties(apache-geode PROPERTIES OUTPUT_NAME 
${PRODUCT_LIB_NAME})

This way the target stays "apache-geode" but the results of the output will 
be adjusted.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #19: GEODE-2508: Inital work on making lib names g...

[echobravopapa]

GitHub user echobravopapa opened a pull request:

https://github.com/apache/geode-native/pull/19

GEODE-2508: Inital work on making lib names generic.

Just a sneak peak, I think I may have a couple tweaks/additions next week.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 2aa2c5acb151ef08761e88290666f3e7e5c6546a
Author: Ernest Burghardt 
Date:   2017-02-17T23:53:25Z

GEODE-2508: Inital work on making lib names generic.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---