[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-27 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread echobravopapa 
Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/73#discussion_r107950987
  
--- Diff: 
docs/geode-native-docs/introduction/developing-windows.html.md.erb ---
@@ -21,18 +21,18 @@ limitations under the License.
 
 Geode uses the Visual Studio 2010 Service Pack 1 compiler for C++ programs 
on Windows, which invokes Microsoft® `cl.exe` from the command line 
at compile time.
 
-The Geode native client supports .NET 4.0 and Visual Studio 2010. For 
advantages and more information on the features of .NET 4.0 and Visual Studio 
2010 SP1, see 
[http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx)
 and 
[http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx).
+The Geode client supports .NET 4.0 and Visual Studio 2010. For advantages 
and more information on the features of .NET 4.0 and Visual Studio 2010 SP1, 
see 
[http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx)
 and 
[http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx).
 
 Visual Studio 2010 SP1 is the recommended compiler. If you are using any 
other compiler, contact technical support for assistance.
--- End diff --

Let's remove any references to "contacting tech support" as this is not a 
concept in an Apache project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread echobravopapa 
Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/73#discussion_r107950403
  
--- Diff: 
docs/geode-native-docs/introduction/developing-solaris.html.md.erb ---
@@ -19,25 +19,25 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 
-This section describes how to build and run a native client application on 
Solaris.
+This section describes how to build and run a client application on 
Solaris.
 
 ## Step 1. Set Environment Variables
 
-**Note:** When compiling external projects or applications that are used 
or referenced by the native client, make sure that you compile them for the 
same target architecture as your native client installation. For example, if 
you installed the 32-bit (x86) version of the native client, compile your 
external projects for 32-bit (x86) architecture.
+**Note:** When compiling external projects or applications that are used 
or referenced by the client, make sure that you compile them for the same 
target architecture as your client installation. For example, if you installed 
the 32-bit (x86) version of the client, compile your external projects for 
32-bit (x86) architecture.
 
-Set the native client environment variables on each Solaris host. For each 
case, *product-dir* is the path to the native client product directory.
+Set the client environment variables on each Solaris host. For each case, 
*product-dir* is the path to the client product directory.
 
 **For Bourne and Korn shells (sh, ksh, bash)**
 
 
-GFCPP=_product-dir_; export GFCPP
-PATH=$GFCPP/bin:$PATH;export PATH
-LD\_LIBRARY\_PATH=$GFCPP/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH
+GEODE=_product-dir_; export GEODE
+PATH=$GEODE/bin:$PATH;export PATH
+LD\_LIBRARY\_PATH=$GEODE/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH
 
 
--- End diff --

The future life of Solaris is very much up in the air, this section could 
be removed as I don't think it is regarding the "current" version of SunStudio


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread echobravopapa 
Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/73#discussion_r107950013
  
--- Diff: docs/geode-native-docs/introduction/developing-linux.html.md.erb 
---
@@ -19,48 +19,48 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 
-This section describes how to build and run a native client application on 
Linux.
+This section describes how to build and run a client application on Linux.
 
-**Note:** When compiling external projects or applications that are used 
or referenced by the Geode native client, make sure that you compile them for 
the same target architecture as your native client installation. For example, 
if you installed the 64-bit (x86) version of the native client, compile your 
external projects for 64-bit (x86) architecture.
+**Note:** When compiling external projects or applications that are used 
or referenced by the Geode client, make sure that you compile them for the same 
target architecture as your client installation. For example, if you installed 
the 64-bit (x86) version of the client, compile your external projects for 
64-bit (x86) architecture.
 
 ## Step 1. Set Environment Variables
 
-Set the native client environment variables on each Linux host. For each 
case, *product-dir* is the path to the native client product directory.
+Set the client environment variables on each Linux host. For each case, 
*product-dir* is the path to the client product directory.
 
 **For Bourne and Korn shells (sh, ksh, bash)**
 
 
-GFCPP=_product-dir_;export GFCPP
-PATH=$GFCPP/bin:$PATH;export PATH
-LD\_LIBRARY\_PATH=$GFCPP/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH
+GEODE=_product-dir_;export GEODE
+PATH=$GEODE/bin:$PATH;export PATH
+LD\_LIBRARY\_PATH=$GEODE/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH
 
 
-## Step 2. Compile C++ Clients and Dynamically Link Them 
to the GemFire Library
+## Step 2. Compile C++ Clients and Dynamically Link Them 
to the Geode Library
 
-On Linux, the `g++` compiler is supported. To build and link a C++ client 
to GemFire on Linux, the compilation command line must include the arguments 
listed in the following table.
+On Linux, the `g++` compiler is supported. To build and link a C++ client 
to Geode on Linux, the compilation command line must include the arguments 
listed in the following table.
 
 
 
 | Argument   | Explanation 
 |
 
||--|
 | `-D_REENTRANT` | Required to compile Linux programs in a thread-safe 
way. |
 | `-m32` or `-m64`   | Enables 32-bit or 64-bit compilation.   
 |
-| `-I$GFCPP/include` | Specifies the native client `include` directory.
 |
+| `-I$GEODE/include` | Specifies the client `include` directory. |
 
 
-The following table lists the linker switches that must be present on the 
command line when dynamically linking to the GemFire library.
+The following table lists the linker switches that must be present on the 
command line when dynamically linking to the Geode library.
 
 
 
 | Argument| Explanation
|
 
|-||
-| `-rpath $GFCPP/lib` | Tells the linker to look in `$GFCPP/lib` for 
libraries on which the native client library depends. |
-| `-L$GFCPP/lib`  | Tells the linker where to find the named 
libraries.|
+| `-rpath $GEODE/lib` | Tells the linker to look in `$GEODE/lib` for 
libraries on which the client library depends. |
+| `-L$GEODE/lib`  | Tells the linker where to find the named 
libraries.|
 | `-o durableclient`  | Tells the linker to output an object file named 
'durableclient'.   |
-| `-lgfcppcache`  | Links the native client C++ cache library to the 
compiled executable.  |
+| `-lgfcppcache`  | Links the client C++ cache library to the compiled 
executable.  |
 
 
-The following examples compile and link the 
`$GFCPP/SampleCode/quickstart/cpp/DurableClient.cpp` client to the 
`durableclient` output file.
+The following examples compile and link the 
`$GEODE/SampleCode/quickstart/cpp/DurableClient.cpp` client to the 
`durableclient` output file.
 
 **Compiling and Dynamically Linking on Linux for 32-bit**
--- End diff --

It would be better to have the examples

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread PivotalSarge 
Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/73#discussion_r107939092
  
--- Diff: 
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -20,26 +20,26 @@ limitations under the License.
 
 
 
-Pivotal 
GemFire Native Client 9.0 Documentation
+Apache Geode 
Client Documentation
 
 
 
-
-Supported
 Configurations and System Requirements
-
+   
+   System 
Configurations
+   
 
 
 
-Getting 
Started with a Native Client
+Getting 
Started with the Client
 
 
-About the 
Native Client
+About the 
Client
 
 
-Installing the 
Native Client
+Installing the 
Geode Client
--- End diff --

Elsewhere it's just "Client", not "Geode Client".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-23 Thread davebarnes97 
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/73

GEODE-2513 Unbrand C++ API docs: Getting Started section

Please review for terminology only. Also in scope is a rewrite of the 
system "requirements" which are now "guidelines".
NOT in scope are (1) making sure the QuickStarts still run with the new 
names in place, and (2) un-branding filenames. These are the subjects of 
separate pull requests in progress.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-GetStarted

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit ce3b552689d204a554af66dd49118aacf473d815
Author: Dave Barnes 
Date:   2017-03-23T23:26:05Z

GEODE-2513 Unbrand C++ API docs: Getting Started section




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---