[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/403 I think I should pull this in before applying https://reviews.apache.org/r/56934/. My changes for GEODE-2460 are missing the webapp NOTICE changes and the change to gradle/dependency-resolution.gradle. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/403 It seems like it might be simpler to add an explicit dependency for commons-beanutils to geode-core. That way if we later introduce some new dependency which requires say commons-beanutils 1.10.1, there will be no need to troubleshoot since dependency resolution will still work as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user metatype commented on the issue: https://github.com/apache/geode/pull/403 In this case geode-pulse uses commons-beanutils v1.9.3 while geode-core is pulling in commons-beanutils v1.8.3 via shiro-core. The version is different between `lib/*` and `geode-pulse-*.war`. The override resolution strategy gives us another way to control transitive dependencies. In some (rare) instances, we may want to ship a different version than specified in the pom file. Let me know if you think this is getting overly complicated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/403 Can you explain why the version override strategy is necessary? I think geode-pulse (or any other submodule with an explicit dependency on commons-beantuils) should end up with version 1.9.3 already without any change to `dependency-resolution.gradle`, since the version you've specified (1.9.3) is higher than the one coming in transitively (1.8.3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user metatype commented on the issue: https://github.com/apache/geode/pull/403 @upthewaterspout @scmbuildguy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
