Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168474
---


Ship it!




Ship It!

- Ken Howe


On March 7, 2017, 7:09 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57390/
> ---
> 
> (Updated March 7, 2017, 7:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
>   gradle/dependency-versions.properties 
> 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 
> 
> 
> Diff: https://reviews.apache.org/r/57390/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> Ran the test 20 times by hand locally without failure: `./gradlew 
> geode-assembly:integrationTest 
> -DintegrationTest.single=RestSecurityIntegrationTest`
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168199
---


Ship it!




Ship It!

- Jinmei Liao


On March 7, 2017, 7:09 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57390/
> ---
> 
> (Updated March 7, 2017, 7:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
>   gradle/dependency-versions.properties 
> 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 
> 
> 
> Diff: https://reviews.apache.org/r/57390/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> Ran the test 20 times by hand locally without failure: `./gradlew 
> geode-assembly:integrationTest 
> -DintegrationTest.single=RestSecurityIntegrationTest`
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168193
---


Ship it!




Ship It!

- Kirk Lund


On March 7, 2017, 7:09 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57390/
> ---
> 
> (Updated March 7, 2017, 7:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
>   gradle/dependency-versions.properties 
> 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 
> 
> 
> Diff: https://reviews.apache.org/r/57390/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> Ran the test 20 times by hand locally without failure: `./gradlew 
> geode-assembly:integrationTest 
> -DintegrationTest.single=RestSecurityIntegrationTest`
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168190
---


Ship it!




Ship It!

- Jared Stewart


On March 7, 2017, 7:09 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57390/
> ---
> 
> (Updated March 7, 2017, 7:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
>   gradle/dependency-versions.properties 
> 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 
> 
> 
> Diff: https://reviews.apache.org/r/57390/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> Ran the test 20 times by hand locally without failure: `./gradlew 
> geode-assembly:integrationTest 
> -DintegrationTest.single=RestSecurityIntegrationTest`
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Kevin Duling]

> On March 7, 2017, 10:54 a.m., Kirk Lund wrote:
> > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
> > Line 81 (original), 81 (patched)
> > 
> >
> > Another option is to make this a weaker assertion:
> > ```java
> > assertThat(restClient.getContentType(response)).containsIgnoringCase(MediaType.APPLICATION_JSON_UTF8_VALUE);
> > ```
> 
> Kirk Lund wrote:
> Not sure why the markdown didn't work for me this time. Maybe the syntax 
> changed in the new reviewboard.
> 
> 
> assertThat(restClient.getContentType(response)).containsIgnoringCase(MediaType.APPLICATION_JSON_UTF8_VALUE);

I like that better, going to go that route.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168170
---


On March 7, 2017, 9:48 a.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57390/
> ---
> 
> (Updated March 7, 2017, 9:48 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
>   gradle/dependency-versions.properties 
> 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 
> 
> 
> Diff: https://reviews.apache.org/r/57390/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> Ran the test 20 times by hand locally without failure: `./gradlew 
> geode-assembly:integrationTest 
> -DintegrationTest.single=RestSecurityIntegrationTest`
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Kirk Lund]

> On March 7, 2017, 6:54 p.m., Kirk Lund wrote:
> > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
> > Line 81 (original), 81 (patched)
> > 
> >
> > Another option is to make this a weaker assertion:
> > ```java
> > assertThat(restClient.getContentType(response)).containsIgnoringCase(MediaType.APPLICATION_JSON_UTF8_VALUE);
> > ```

Not sure why the markdown didn't work for me this time. Maybe the syntax 
changed in the new reviewboard.

assertThat(restClient.getContentType(response)).containsIgnoringCase(MediaType.APPLICATION_JSON_UTF8_VALUE);


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168170
---


On March 7, 2017, 5:48 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57390/
> ---
> 
> (Updated March 7, 2017, 5:48 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
>   gradle/dependency-versions.properties 
> 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 
> 
> 
> Diff: https://reviews.apache.org/r/57390/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> Ran the test 20 times by hand locally without failure: `./gradlew 
> geode-assembly:integrationTest 
> -DintegrationTest.single=RestSecurityIntegrationTest`
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168170
---


Ship it!




Ship It!

Consider change to AssertJ in order to use containsIgnoringCase assertion.


geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
Line 81 (original), 81 (patched)


Another option is to make this a weaker assertion:
```java
assertThat(restClient.getContentType(response)).containsIgnoringCase(MediaType.APPLICATION_JSON_UTF8_VALUE);
```


- Kirk Lund


On March 7, 2017, 5:48 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57390/
> ---
> 
> (Updated March 7, 2017, 5:48 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
>   gradle/dependency-versions.properties 
> 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 
> 
> 
> Diff: https://reviews.apache.org/r/57390/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> Ran the test 20 times by hand locally without failure: `./gradlew 
> geode-assembly:integrationTest 
> -DintegrationTest.single=RestSecurityIntegrationTest`
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/
---

Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
 75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
  gradle/dependency-versions.properties 
34e5d67882c5d1cd82cce04e31ebc69dab6f4251 


Diff: https://reviews.apache.org/r/57390/diff/1/


Testing
---

precheckin running

Ran the test 20 times by hand locally without failure: `./gradlew 
geode-assembly:integrationTest 
-DintegrationTest.single=RestSecurityIntegrationTest`


Thanks,

Kevin Duling