Re: Review Request 47617: GEODE-17: add regionName in some of the commands authorization

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47617/
---

(Updated May 20, 2016, 1:19 a.m.)


Review request for geode.


Repository: geode


Description
---

GEODE-17: add regionName in some of the commands authorization

* added region check in query commands
* added region check in alter region
* added region check in define index/create index


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
 322c59e1f1a42818efa5a58cab6e3268774d60eb 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 06c096fbbb3fdc75c3d7feaa2f41186cdcfd4174 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java
 fafea9a4843bddaef2df4c7d8404cead37b64c1c 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java
 24f9f7173de6a8947fac00a14168ec0b51c95182 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java
 b4e73406c534744b8f7f92c3a598b88e9a18c885 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/MemberMXBeanAdapter.java
 a3d4cd02921ead659a8b44201f5d11be4820abe6 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java
 0864e5226eff853bdcb03e305b489ddd1e5a207e 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java
 b21302e44770974591364316bffc733234d6 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java
 667330ce0dcba0fc571d8466559a700b7c4f587e 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json
 638ae07802ddf4967513803eb98b394486361f6c 

Diff: https://reviews.apache.org/r/47617/diff/


Testing
---

precheckin running


Thanks,

Jinmei Liao

Re: Review Request 47553: GEODE-1397: Rename HelpCommandsJUnitTest to ...IntegrationTest

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47553/#review134069
---


Ship it!





geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java
 (line 80)


[Not an issue] Another option is:

getClass().getResourceAsStream(...)


- Kirk Lund


On May 18, 2016, 9:32 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47553/
> ---
> 
> (Updated May 18, 2016, 9:32 p.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1397: Fixing testOfflineHelp
> 
> 
> GEODE-1397: Adding new help text from create async-event-queue
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java
>  1d81d2e0dfe1600fa500a6c2a7f320790e6aa836 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties
>  a9dc64cbb5d0162aaa0927f3faec98632ced1c33 
> 
> Diff: https://reviews.apache.org/r/47553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 47606: GEODE-1412: ignore-eviction-expiration flag was not used in the http controller

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47606/#review134068
---


Ship it!




Ship It!

- Kirk Lund


On May 19, 2016, 5:14 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47606/
> ---
> 
> (Updated May 19, 2016, 5:14 p.m.)
> 
> 
> Review request for geode, Anil Kumar B, Jinmei Liao, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1412: ignore-eviction-expiration flag was not used in the http 
> controller
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/QueueCommandsController.java
>  83d7bc1da6f265d84ba154539217a735a10dbfe8 
> 
> Diff: https://reviews.apache.org/r/47606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 47607: GEODE-1417: geode-web:war task does not include the necessary web components from core

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47607/#review134067
---


Ship it!




Ship It!

- Kirk Lund


On May 19, 2016, 5:44 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47607/
> ---
> 
> (Updated May 19, 2016, 5:44 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1417: geode-web:war task does not include the necessary web components 
> from core
> 
> 
> Diffs
> -
> 
>   geode-web/build.gradle 228751b6067d0034c8071c52b80d4019fa5747d9 
> 
> Diff: https://reviews.apache.org/r/47607/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 47618: remove assertion of dunit jvm count

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47618/#review134066
---


Ship it!




Ship It!

- Kirk Lund


On May 19, 2016, 10:58 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47618/
> ---
> 
> (Updated May 19, 2016, 10:58 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1414
> https://issues.apache.org/jira/browse/GEODE-1414
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> remove assertion of dunit jvm count
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
>  9ad102d2a3e8c78e82639035f9f251639f7a72b6 
> 
> Diff: https://reviews.apache.org/r/47618/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Review Request 47618: remove assertion of dunit jvm count

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47618/
---

Review request for geode, Kirk Lund and Sai Boorlagadda.


Bugs: GEODE-1414
https://issues.apache.org/jira/browse/GEODE-1414


Repository: geode


Description
---

remove assertion of dunit jvm count


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
 9ad102d2a3e8c78e82639035f9f251639f7a72b6 

Diff: https://reviews.apache.org/r/47618/diff/


Testing
---

precheckin


Thanks,

Darrel Schneider

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/
---

(Updated May 19, 2016, 10:54 p.m.)


Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider, 
Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.


Changes
---

Based on review removed waits for events that were not needed...


Repository: geode


Description
---

GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. 
The test stops the CQ and verifies no events are recieved in stopped state; it 
was doing that by checking operations/events that happend before stop and not 
counting the changes happened during stop. In a slower environment, it could so 
happen that the CQ may not have recieved all the events before it is stopped, 
thus causing the validation to fail.


Diffs (updated)
-

  
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java
 130f924643ad350539f02a59f34b6ba18cef1c10 

Diff: https://reviews.apache.org/r/47615/diff/


Testing
---

Reproduced the issue by slowing down the CQ listener processing. Verified the 
test passes with the changes...


Thanks,

anilkumar gingade

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #314 was SUCCESSFUL (with 1398 tests). Change made by John Blum .

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #314 was successful.
---
Scheduled with changes by John Blum .
1400 tests in total.

https://build.spring.io/browse/SGF-NAG-314/




--
Code Changes
--
John Blum  (2fe1029abfad1e7b02287deea8e9980e9f461d52):

>SGF-500 - Add support for the 'ignoreEvictionAndExpiration' configuration 
>property on AsyncEventQueue and AsyncEventQueueFactory



--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 47606: GEODE-1412: ignore-eviction-expiration flag was not used in the http controller

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47606/#review134061
---


Ship it!




Ship It!

- anilkumar gingade


On May 19, 2016, 5:14 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47606/
> ---
> 
> (Updated May 19, 2016, 5:14 p.m.)
> 
> 
> Review request for geode, Anil Kumar B, Jinmei Liao, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1412: ignore-eviction-expiration flag was not used in the http 
> controller
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/QueueCommandsController.java
>  83d7bc1da6f265d84ba154539217a735a10dbfe8 
> 
> Diff: https://reviews.apache.org/r/47606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/#review134060
---


Ship it!




- Jason Huynh


On May 19, 2016, 9:47 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47615/
> ---
> 
> (Updated May 19, 2016, 9:47 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider, 
> Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-988: Added wait for events to arrive on stopped CQ before it is 
> stopped. The test stops the CQ and verifies no events are recieved in stopped 
> state; it was doing that by checking operations/events that happend before 
> stop and not counting the changes happened during stop. In a slower 
> environment, it could so happen that the CQ may not have recieved all the 
> events before it is stopped, thus causing the validation to fail.
> 
> 
> Diffs
> -
> 
>   
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java
>  130f924643ad350539f02a59f34b6ba18cef1c10 
> 
> Diff: https://reviews.apache.org/r/47615/diff/
> 
> 
> Testing
> ---
> 
> Reproduced the issue by slowing down the CQ listener processing. Verified the 
> test passes with the changes...
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

[anilkumar gingade]

> On May 19, 2016, 10 p.m., Jason Huynh wrote:
> > Long term this test could probably be broken up into smaller chunks as it's 
> > testing multiple scenarios

Agree...


> On May 19, 2016, 10 p.m., Jason Huynh wrote:
> > geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java,
> >  line 432
> > 
> >
> > I think having the waitForUpdate (which happens a few lines below) will 
> > be enough for cq_1?  He won't get the create and update out of order 
> > correct?

Yes...waiting for update is good enough...It doesn't recieve events out of 
order in this case/test. I added there, for debugging purpose, to identify 
which event got missed...If the test is working as expected, it should not add 
any overhead...


> On May 19, 2016, 10 p.m., Jason Huynh wrote:
> > geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java,
> >  line 433
> > 
> >
> > I don't think we need this one here (for cq_3), we have a wait for 
> > updated later and do not do any validation until after the update.

Its not needed...I will remove this validation...And send a new review 
request...


- anilkumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/#review134056
---


On May 19, 2016, 9:47 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47615/
> ---
> 
> (Updated May 19, 2016, 9:47 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider, 
> Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-988: Added wait for events to arrive on stopped CQ before it is 
> stopped. The test stops the CQ and verifies no events are recieved in stopped 
> state; it was doing that by checking operations/events that happend before 
> stop and not counting the changes happened during stop. In a slower 
> environment, it could so happen that the CQ may not have recieved all the 
> events before it is stopped, thus causing the validation to fail.
> 
> 
> Diffs
> -
> 
>   
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java
>  130f924643ad350539f02a59f34b6ba18cef1c10 
> 
> Diff: https://reviews.apache.org/r/47615/diff/
> 
> 
> Testing
> ---
> 
> Reproduced the issue by slowing down the CQ listener processing. Verified the 
> test passes with the changes...
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/#review134056
---



Long term this test could probably be broken up into smaller chunks as it's 
testing multiple scenarios


geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java
 (line 432)


I think having the waitForUpdate (which happens a few lines below) will be 
enough for cq_1?  He won't get the create and update out of order correct?



geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java
 (line 433)


I don't think we need this one here (for cq_3), we have a wait for updated 
later and do not do any validation until after the update.


- Jason Huynh


On May 19, 2016, 9:47 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47615/
> ---
> 
> (Updated May 19, 2016, 9:47 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider, 
> Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-988: Added wait for events to arrive on stopped CQ before it is 
> stopped. The test stops the CQ and verifies no events are recieved in stopped 
> state; it was doing that by checking operations/events that happend before 
> stop and not counting the changes happened during stop. In a slower 
> environment, it could so happen that the CQ may not have recieved all the 
> events before it is stopped, thus causing the validation to fail.
> 
> 
> Diffs
> -
> 
>   
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java
>  130f924643ad350539f02a59f34b6ba18cef1c10 
> 
> Diff: https://reviews.apache.org/r/47615/diff/
> 
> 
> Testing
> ---
> 
> Reproduced the issue by slowing down the CQ listener processing. Verified the 
> test passes with the changes...
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Review Request 47617: GEODE-17: add regionName in some of the commands authorization

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47617/
---

Review request for geode.


Repository: geode


Description
---

GEODE-17: add regionName in some of the commands authorization

* added region check in query commands
* added region check in alter region
* added region check in define index/create index


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
 322c59e1f1a42818efa5a58cab6e3268774d60eb 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 06c096fbbb3fdc75c3d7feaa2f41186cdcfd4174 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java
 fafea9a4843bddaef2df4c7d8404cead37b64c1c 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java
 24f9f7173de6a8947fac00a14168ec0b51c95182 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java
 b4e73406c534744b8f7f92c3a598b88e9a18c885 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java
 667330ce0dcba0fc571d8466559a700b7c4f587e 

Diff: https://reviews.apache.org/r/47617/diff/


Testing
---

precheckin running


Thanks,

Jinmei Liao

Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that by ch

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/
---

Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider, 
Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou.


Repository: geode


Description
---

GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. 
The test stops the CQ and verifies no events are recieved in stopped state; it 
was doing that by checking operations/events that happend before stop and not 
counting the changes happened during stop. In a slower environment, it could so 
happen that the CQ may not have recieved all the events before it is stopped, 
thus causing the validation to fail.


Diffs
-

  
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java
 130f924643ad350539f02a59f34b6ba18cef1c10 

Diff: https://reviews.apache.org/r/47615/diff/


Testing
---

Reproduced the issue by slowing down the CQ listener processing. Verified the 
test passes with the changes...


Thanks,

anilkumar gingade

Re: Review Request 47496: Adding transaction tests for lucene indexes

[Barry Oglesby]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47496/#review134034
---


Ship it!




Ship It!

- Barry Oglesby


On May 19, 2016, 6:32 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47496/
> ---
> 
> (Updated May 19, 2016, 6:32 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added integration tests to test three scenarios:
> 1.) the lucene indexes are not updated during an in flight transaction (begin 
> but before rollback or commit)
> 2.) the lucene indexes are updated after a commit
> 3.) the lucene indexes are not changed after a rollback
> 
> todo:
> Do we want to add a dunit test for multiple vms and threads doing 
> transactions?  I avoided adding this test for now as I thought that was more 
> of a "testing the geode transaction feature" rather than testing how the 
> feature affects lucene.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
>  4c28938 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java
>  23983cb 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java
>  c302460 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
>  fa3392c 
> 
> Diff: https://reviews.apache.org/r/47496/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 47496: Adding transaction tests for lucene indexes

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47496/#review134033
---


Ship it!




Ship It!

- Dan Smith


On May 19, 2016, 6:32 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47496/
> ---
> 
> (Updated May 19, 2016, 6:32 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added integration tests to test three scenarios:
> 1.) the lucene indexes are not updated during an in flight transaction (begin 
> but before rollback or commit)
> 2.) the lucene indexes are updated after a commit
> 3.) the lucene indexes are not changed after a rollback
> 
> todo:
> Do we want to add a dunit test for multiple vms and threads doing 
> transactions?  I avoided adding this test for now as I thought that was more 
> of a "testing the geode transaction feature" rather than testing how the 
> feature affects lucene.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
>  4c28938 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java
>  23983cb 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java
>  c302460 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
>  fa3392c 
> 
> Diff: https://reviews.apache.org/r/47496/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 47496: Adding transaction tests for lucene indexes

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47496/
---

(Updated May 19, 2016, 6:32 p.m.)


Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
Smith, and xiaojian zhou.


Changes
---

Updated based on review comments
Migrated a few tests from LuceneServiceImplIntegrationTest to better locations


Repository: geode


Description
---

Added integration tests to test three scenarios:
1.) the lucene indexes are not updated during an in flight transaction (begin 
but before rollback or commit)
2.) the lucene indexes are updated after a commit
3.) the lucene indexes are not changed after a rollback

todo:
Do we want to add a dunit test for multiple vms and threads doing transactions? 
 I avoided adding this test for now as I thought that was more of a "testing 
the geode transaction feature" rather than testing how the feature affects 
lucene.


Diffs (updated)
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
 4c28938 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java
 23983cb 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java
 c302460 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
 fa3392c 

Diff: https://reviews.apache.org/r/47496/diff/


Testing
---


Thanks,

Jason Huynh

[GitHub] incubator-geode pull request: GEODE-1296: change conditional in ge...

[dschneider-pivotal]

Github user dschneider-pivotal commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/145#discussion_r63931246
  
--- Diff: 
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java
 ---
@@ -816,6 +820,7 @@ public void 
getRawBytesShouldThrowExceptionIfValueIsCompressed() {
 chunk.getRawBytes();
 
 chunk.release();
+fail("Expected getRawBytes() for a compressed value to throw 
java.lang.AssertionError");
--- End diff --

Why is this "fail" call added. Doesn't the "expected" on the Test 
annotation take care of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 47496: Adding transaction tests for lucene indexes

[Jason Huynh]

> On May 18, 2016, 1 a.m., Dan Smith wrote:
> > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java,
> >  line 352
> > 
> >
> > I'm actually surprised this works, since the field names are "title" 
> > and "description", not "text".

Looked into this a bit, apparently I need to use description:"\hello world\" as 
the string, otherwise lucene will look for the word "world" in the default 
field which was the reason why it was working the way it was.  In our case the 
default I think are all fields or whatever the QueryParser is passed


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47496/#review133671
---


On May 17, 2016, 10:54 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47496/
> ---
> 
> (Updated May 17, 2016, 10:54 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added integration tests to test three scenarios:
> 1.) the lucene indexes are not updated during an in flight transaction (begin 
> but before rollback or commit)
> 2.) the lucene indexes are updated after a commit
> 3.) the lucene indexes are not changed after a rollback
> 
> todo:
> Do we want to add a dunit test for multiple vms and threads doing 
> transactions?  I avoided adding this test for now as I thought that was more 
> of a "testing the geode transaction feature" rather than testing how the 
> feature affects lucene.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
>  fa3392c 
> 
> Diff: https://reviews.apache.org/r/47496/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 47496: Adding transaction tests for lucene indexes

[Jason Huynh]

> On May 18, 2016, 12:16 a.m., anilkumar gingade wrote:
> > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java,
> >  line 321
> > 
> >
> > How about moving these puts into region initialization method?

I left it this way for now because I think there will be cases where we want to 
create a region with different data and not necessarily have the same data 
every time.  Each test can specifically tune the data they want to use and 
expect.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47496/#review133663
---


On May 17, 2016, 10:54 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47496/
> ---
> 
> (Updated May 17, 2016, 10:54 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added integration tests to test three scenarios:
> 1.) the lucene indexes are not updated during an in flight transaction (begin 
> but before rollback or commit)
> 2.) the lucene indexes are updated after a commit
> 3.) the lucene indexes are not changed after a rollback
> 
> todo:
> Do we want to add a dunit test for multiple vms and threads doing 
> transactions?  I avoided adding this test for now as I thought that was more 
> of a "testing the geode transaction feature" rather than testing how the 
> feature affects lucene.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
>  fa3392c 
> 
> Diff: https://reviews.apache.org/r/47496/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[GitHub] incubator-geode pull request: GEODE-1296: change conditional in ge...

[dschneider-pivotal]

Github user dschneider-pivotal commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/145#discussion_r63930600
  
--- Diff: 
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java
 ---
@@ -42,6 +42,10 @@
 @Category(UnitTest.class)
 public class OffHeapStoredObjectJUnitTest extends 
AbstractStoredObjectTestBase {
 
+  static {
--- End diff --

Remove this static block. I talked with Kirk and we think that java 
assertions are enabled consistently from both gradle and the IDE


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: GEODE-1296: change conditional in ge...

[dschneider-pivotal]

Github user dschneider-pivotal commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/145#discussion_r63930434
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java
 ---
@@ -417,11 +417,13 @@ public void setSerializedValue(byte[] value) {
   MemoryAllocatorImpl.getAllocator().getStats().incReads();
   return result;
 }
+/**
+ * This method should only be called on uncompressed objects
+ * @return byte array of the StoredObject value. 
+ */
 protected byte[] getRawBytes() {
+  assert !isCompressed();
   byte[] result = getCompressedBytes();
--- End diff --

Combine these two lines into "return getCompressedBytes();"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Donation of GemFire native client code

[Nitin Lamba]

Great news indeed!!

Now that this code is on its way to be contributed, would it make sense to
include node-gemfire  driver (BSD
license) and manage it as part of Geode? Makes it a fairly compelling stack
for javascript developers...

Nitin

On Thu, May 19, 2016 at 9:03 AM, Anilkumar Gingade 
wrote:

> Thats a great newsIt opens up all our client code accessible to
> community...
>
> -Anil.
>
>
> On Thu, May 19, 2016 at 8:56 AM, Anthony Baker  wrote:
>
> > I am pleased to announce the donation of additional GemFire client
> drivers
> > to the Geode community. This source code donation includes a C++ client
> and
> > a .NET client.
> >
> > The C++ client allows an application to connect to a cluster using
> > intelligent network routing for low latency reads and writes.  The C++
> > client can additionally cache data locally and receive update
> notifications
> > or register continuous queries.  The .NET client wraps the C++ libraries
> > and enables .NET applications to be written for Geode.  Both of these
> > clients are functionally equivalatent to the already donated Java client
> > for Geode.
> >
> > The Software Grant Agreement for this code has been accepted by the ASF
> > secretary.
> >
> > The donated code currently sits in a separate branch in the Geode
> > repository named native-client-software-grant [1] and is awaiting
> community
> > review.  I encourage everyone in the Geode community to review this
> > donation and provide feedback.  In particular your input on build
> > improvements would be really helpful.  Once the community has reached a
> > consensus we can determine next steps and how this code might get merged
> > into the develop branch [2] so that all users can access these features.
> > Your suggestions are most welcome!
> >
> > Thanks,
> > Anthony
> >
> > [1]
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;f=geode-client-native;h=0fd3464f85be2dba96ad1c2692b4bc28b1df1d64;hb=refs/heads/native-client-software-grant
> > [2] https://issues.apache.org/jira/browse/GEODE-1416
> >
>

Re: [gemfire-mm] Re: Region Permission

[Swapnil Bawaskar]

If I have read permissions on a region, I would expect "describe region" to
work.
I could live with a "permission denied" for "list region", however, it
would be nice to get a list of all regions I have permissions for.

On Thu, May 19, 2016 at 10:44 AM, Michael Stolz  wrote:

> Permission denied is fine if CLUSTER:READ is disallowed.
>
> The regions returned should be those regions he has access to.
>
> Data Administrator should have access to all regions.
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771
> On May 19, 2016 12:22 PM, "Jinmei Liao"  wrote:
>
>> I want to get some clarification on what permission is need to guard the
>> operation of "list regions" and "describe region".
>>
>> Currently anyone that has "CLUSTER:READ" are able to execute those two
>> commands, regardless whether he has "READ/WRITE/MANAGE" permissions to the
>> regions. And if a user only has read permission for a specific region,
>> when
>> he goes to execute "list regions", he will get a "permission denied"
>> message instead of seeing a list of regions that he has access to. Is this
>> the expected behavior? Or a better question is: what is the expected
>> behavior?
>>
>> --
>> Cheers
>>
>> Jinmei
>>
>

Review Request 47607: GEODE-1417: geode-web:war task does not include the necessary web components from core

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47607/
---

Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-1417: geode-web:war task does not include the necessary web components 
from core


Diffs
-

  geode-web/build.gradle 228751b6067d0034c8071c52b80d4019fa5747d9 

Diff: https://reviews.apache.org/r/47607/diff/


Testing
---


Thanks,

Jens Deppe

Re: Region Permission

[Michael Stolz]

Permission denied is fine if CLUSTER:READ is disallowed.

The regions returned should be those regions he has access to.

Data Administrator should have access to all regions.

--
Mike Stolz
Principal Engineer - Gemfire Product Manager
Mobile: 631-835-4771
On May 19, 2016 12:22 PM, "Jinmei Liao"  wrote:

> I want to get some clarification on what permission is need to guard the
> operation of "list regions" and "describe region".
>
> Currently anyone that has "CLUSTER:READ" are able to execute those two
> commands, regardless whether he has "READ/WRITE/MANAGE" permissions to the
> regions. And if a user only has read permission for a specific region, when
> he goes to execute "list regions", he will get a "permission denied"
> message instead of seeing a list of regions that he has access to. Is this
> the expected behavior? Or a better question is: what is the expected
> behavior?
>
> --
> Cheers
>
> Jinmei
>

Re: Review Request 47568: change async event pool to use all its threads

[Sai Boorlagadda]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47568/#review133987
---


Ship it!




Ship It!

- Sai Boorlagadda


On May 19, 2016, 12:14 a.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47568/
> ---
> 
> (Updated May 19, 2016, 12:14 a.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1246
> https://issues.apache.org/jira/browse/GEODE-1246
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed async event pool to use all its threads.
> A new unit test was added that failed with the old pool and passes with the 
> new.
> 
> 
> The system property gemfire.Cache.EVENT_THREAD_LIMIT can be used to configure
> the number of threads used the async cache listener invocation.
> It defaults to 16.
> 
> A bunch of changes were made so that the unit test could create a real 
> GemFireCacheImpl with a mocked DistributedSystem.
> I enhanced the DistributedSystem created by "Fakes".
> 
> The actual fix for the threading issue is limited to GemFireCacheImpl:
>   this.eventThreadPool = new PooledExecutorWithDMStats(q, EVENT_THREAD_LIMIT, 
> this.cachePerfStats.getEventPoolHelper(), tf, 1000);
> and the changes to PooledExecutorWithDMStats (which are not actually needed 
> but will prevent someone from calling a particular constructor with a queue 
> that is not a SynchronousQueue.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/PooledExecutorWithDMStats.java
>  0a9f9eca2b4c343fb69bd9bbce2ff76de5ea2faf 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockService.java
>  610944e71a1b97cc11a534412c68a6dc98e909f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
>  96b7bbcf706ef52e02f01a424035e945050d2dee 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
> b5ff7ee8f56b0ce64f78db072d98104ac654b392 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/jndi/JNDIInvoker.java 
> b3aecc4ef7d9b5d06ac528f2a70a469a1b32b328 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GemFireCacheImplTest.java
>  PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/test/fake/Fakes.java 
> 2a1fd8e343681f5cd41fa42145d2ae2fb73fd2c3 
> 
> Diff: https://reviews.apache.org/r/47568/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Region Permission

[Jinmei Liao]

I want to get some clarification on what permission is need to guard the
operation of "list regions" and "describe region".

Currently anyone that has "CLUSTER:READ" are able to execute those two
commands, regardless whether he has "READ/WRITE/MANAGE" permissions to the
regions. And if a user only has read permission for a specific region, when
he goes to execute "list regions", he will get a "permission denied"
message instead of seeing a list of regions that he has access to. Is this
the expected behavior? Or a better question is: what is the expected
behavior?

-- 
Cheers

Jinmei

Review Request 47606: GEODE-1412: ignore-eviction-expiration flag was not used in the http controller

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47606/
---

Review request for geode, Anil Kumar B, Jinmei Liao, and Kirk Lund.


Repository: geode


Description
---

GEODE-1412: ignore-eviction-expiration flag was not used in the http controller


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/QueueCommandsController.java
 83d7bc1da6f265d84ba154539217a735a10dbfe8 

Diff: https://reviews.apache.org/r/47606/diff/


Testing
---


Thanks,

Jens Deppe

Re: Review Request 47567: GEODE-17: clean up error messages

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47567/#review133978
---


Ship it!




Ship It!

- Jens Deppe


On May 19, 2016, 3:03 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47567/
> ---
> 
> (Updated May 19, 2016, 3:03 p.m.)
> 
> 
> Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-17: clean up error messages
> 
> * clean up authentication/authorization error messages
> * Catch Authorization exception later in the command chain to avoid 
> unnecesary parsing of command result
> * Add ExceptionHandler in controller to set the http header correctly
> * Catch Authorization exception in gfsh execution for better error report
> 
> Output:
> gfsh>connect --user=guest
> password: *
> Connecting to Locator at [host=localhost, port=10334] ..
> Connecting to Manager at [host=10.0.0.245, port=1099] ..
> Successfully connected to: [host=10.0.0.245, port=1099]
> 
> gfsh>list members
> Unauthorized. Reason : Subject does not have permission [CLUSTER:READ]
> 
> gfsh>disconnect
> Disconnecting from: 10.0.0.245[1099]
> Disconnected from : 10.0.0.245[1099]
> 
> gfsh>connect --use-http --user=guest
> password: *
> Successfully connected to: GemFire Manager HTTP service @ 
> http://localhost:7070/gemfire/v1
> 
> gfsh>list members
> Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not 
> have permission [CLUSTER:READ].
> 
> gfsh>list clients
> Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not 
> have permission [CLUSTER:READ].
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
>  236b00b2e93f38074da24e157222c2146133decb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java
>  67ad60d55ada59a9376a92d3d828739481013c95 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/CommandProcessor.java
>  7edc3e418e272dde61225655606b95f3ef456984 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/ResultBuilder.java
>  6b435d36bfae4adac44140f07b87a70ea3268d8d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java
>  c5ebe9af351a6d73e470697196d890285b88c6c7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java
>  ab49270110c46cc7068d0910a5b8e9ed675f1ed5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
>  c41197241789eee0fe97de4531f1bbe85b874360 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/AbstractHttpOperationInvoker.java
>  b2159d26d84cda2580ac7117e17c2c083db812f7 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java
>  377ab7761976d12c5915bba3999a0e0e272112c7 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MemberMBeanSecurityJUnitTest.java
>  8261d09a0d3181d26f487602901ab5fb22d051c0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java
>  03d39fdb7553a1797ac438f4c39ced6f22003419 
> 
> Diff: https://reviews.apache.org/r/47567/diff/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 47606: GEODE-1412: ignore-eviction-expiration flag was not used in the http controller

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47606/#review133975
---


Ship it!




Ship It!

- Jinmei Liao


On May 19, 2016, 5:14 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47606/
> ---
> 
> (Updated May 19, 2016, 5:14 p.m.)
> 
> 
> Review request for geode, Anil Kumar B, Jinmei Liao, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1412: ignore-eviction-expiration flag was not used in the http 
> controller
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/QueueCommandsController.java
>  83d7bc1da6f265d84ba154539217a735a10dbfe8 
> 
> Diff: https://reviews.apache.org/r/47606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 47567: GEODE-17: clean up error messages

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47567/#review133971
---


Ship it!




Ship It!

- Kirk Lund


On May 19, 2016, 3:03 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47567/
> ---
> 
> (Updated May 19, 2016, 3:03 p.m.)
> 
> 
> Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-17: clean up error messages
> 
> * clean up authentication/authorization error messages
> * Catch Authorization exception later in the command chain to avoid 
> unnecesary parsing of command result
> * Add ExceptionHandler in controller to set the http header correctly
> * Catch Authorization exception in gfsh execution for better error report
> 
> Output:
> gfsh>connect --user=guest
> password: *
> Connecting to Locator at [host=localhost, port=10334] ..
> Connecting to Manager at [host=10.0.0.245, port=1099] ..
> Successfully connected to: [host=10.0.0.245, port=1099]
> 
> gfsh>list members
> Unauthorized. Reason : Subject does not have permission [CLUSTER:READ]
> 
> gfsh>disconnect
> Disconnecting from: 10.0.0.245[1099]
> Disconnected from : 10.0.0.245[1099]
> 
> gfsh>connect --use-http --user=guest
> password: *
> Successfully connected to: GemFire Manager HTTP service @ 
> http://localhost:7070/gemfire/v1
> 
> gfsh>list members
> Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not 
> have permission [CLUSTER:READ].
> 
> gfsh>list clients
> Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not 
> have permission [CLUSTER:READ].
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
>  236b00b2e93f38074da24e157222c2146133decb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java
>  67ad60d55ada59a9376a92d3d828739481013c95 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/CommandProcessor.java
>  7edc3e418e272dde61225655606b95f3ef456984 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/ResultBuilder.java
>  6b435d36bfae4adac44140f07b87a70ea3268d8d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java
>  c5ebe9af351a6d73e470697196d890285b88c6c7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java
>  ab49270110c46cc7068d0910a5b8e9ed675f1ed5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
>  c41197241789eee0fe97de4531f1bbe85b874360 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/AbstractHttpOperationInvoker.java
>  b2159d26d84cda2580ac7117e17c2c083db812f7 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java
>  377ab7761976d12c5915bba3999a0e0e272112c7 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MemberMBeanSecurityJUnitTest.java
>  8261d09a0d3181d26f487602901ab5fb22d051c0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java
>  03d39fdb7553a1797ac438f4c39ced6f22003419 
> 
> Diff: https://reviews.apache.org/r/47567/diff/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: [ANNOUNCE] Donation of GemFire native client code

[Anilkumar Gingade]

Thats a great newsIt opens up all our client code accessible to
community...

-Anil.


On Thu, May 19, 2016 at 8:56 AM, Anthony Baker  wrote:

> I am pleased to announce the donation of additional GemFire client drivers
> to the Geode community. This source code donation includes a C++ client and
> a .NET client.
>
> The C++ client allows an application to connect to a cluster using
> intelligent network routing for low latency reads and writes.  The C++
> client can additionally cache data locally and receive update notifications
> or register continuous queries.  The .NET client wraps the C++ libraries
> and enables .NET applications to be written for Geode.  Both of these
> clients are functionally equivalatent to the already donated Java client
> for Geode.
>
> The Software Grant Agreement for this code has been accepted by the ASF
> secretary.
>
> The donated code currently sits in a separate branch in the Geode
> repository named native-client-software-grant [1] and is awaiting community
> review.  I encourage everyone in the Geode community to review this
> donation and provide feedback.  In particular your input on build
> improvements would be really helpful.  Once the community has reached a
> consensus we can determine next steps and how this code might get merged
> into the develop branch [2] so that all users can access these features.
> Your suggestions are most welcome!
>
> Thanks,
> Anthony
>
> [1]
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;f=geode-client-native;h=0fd3464f85be2dba96ad1c2692b4bc28b1df1d64;hb=refs/heads/native-client-software-grant
> [2] https://issues.apache.org/jira/browse/GEODE-1416
>

[ANNOUNCE] Donation of GemFire native client code

[Anthony Baker]

I am pleased to announce the donation of additional GemFire client drivers
to the Geode community. This source code donation includes a C++ client and
a .NET client.

The C++ client allows an application to connect to a cluster using
intelligent network routing for low latency reads and writes.  The C++
client can additionally cache data locally and receive update notifications
or register continuous queries.  The .NET client wraps the C++ libraries
and enables .NET applications to be written for Geode.  Both of these
clients are functionally equivalatent to the already donated Java client
for Geode.

The Software Grant Agreement for this code has been accepted by the ASF
secretary.

The donated code currently sits in a separate branch in the Geode
repository named native-client-software-grant [1] and is awaiting community
review.  I encourage everyone in the Geode community to review this
donation and provide feedback.  In particular your input on build
improvements would be really helpful.  Once the community has reached a
consensus we can determine next steps and how this code might get merged
into the develop branch [2] so that all users can access these features.
Your suggestions are most welcome!

Thanks,
Anthony

[1]
https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;f=geode-client-native;h=0fd3464f85be2dba96ad1c2692b4bc28b1df1d64;hb=refs/heads/native-client-software-grant
[2] https://issues.apache.org/jira/browse/GEODE-1416

Re: Review Request 47567: GEODE-17: clean up error messages

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47567/
---

(Updated May 19, 2016, 3:03 p.m.)


Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-17: clean up error messages

* clean up authentication/authorization error messages
* Catch Authorization exception later in the command chain to avoid unnecesary 
parsing of command result
* Add ExceptionHandler in controller to set the http header correctly
* Catch Authorization exception in gfsh execution for better error report

Output:
gfsh>connect --user=guest
password: *
Connecting to Locator at [host=localhost, port=10334] ..
Connecting to Manager at [host=10.0.0.245, port=1099] ..
Successfully connected to: [host=10.0.0.245, port=1099]

gfsh>list members
Unauthorized. Reason : Subject does not have permission [CLUSTER:READ]

gfsh>disconnect
Disconnecting from: 10.0.0.245[1099]
Disconnected from : 10.0.0.245[1099]

gfsh>connect --use-http --user=guest
password: *
Successfully connected to: GemFire Manager HTTP service @ 
http://localhost:7070/gemfire/v1

gfsh>list members
Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not 
have permission [CLUSTER:READ].

gfsh>list clients
Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not 
have permission [CLUSTER:READ].


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
 236b00b2e93f38074da24e157222c2146133decb 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java
 67ad60d55ada59a9376a92d3d828739481013c95 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/CommandProcessor.java
 7edc3e418e272dde61225655606b95f3ef456984 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/ResultBuilder.java
 6b435d36bfae4adac44140f07b87a70ea3268d8d 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java
 c5ebe9af351a6d73e470697196d890285b88c6c7 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java
 ab49270110c46cc7068d0910a5b8e9ed675f1ed5 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
 c41197241789eee0fe97de4531f1bbe85b874360 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/AbstractHttpOperationInvoker.java
 b2159d26d84cda2580ac7117e17c2c083db812f7 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java
 377ab7761976d12c5915bba3999a0e0e272112c7 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MemberMBeanSecurityJUnitTest.java
 8261d09a0d3181d26f487602901ab5fb22d051c0 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java
 03d39fdb7553a1797ac438f4c39ced6f22003419 

Diff: https://reviews.apache.org/r/47567/diff/


Testing (updated)
---

precheckin successful


Thanks,

Jinmei Liao

Build failed in Jenkins: Geode-nightly #473

[Apache Jenkins Server]

See 

Changes:

[jiliao] GEODE-17: format changes after a review

[jdeppe] GEODE-1293: Revert some changes which broke publishing

[jchen] GEODE-1133 SeparateClassloaderTestRunner has to be re-implemented

[hkhamesra] GEODE-1391 Update javadocs for JSONFormatter

[upthewaterspout] GEODE-1378: Don't launch dunit VMs in checkMissedTests

[upthewaterspout] GEODE-357: Remove third server from

[bschuchardt] added my gnupg key

[dschneider] GEODE-1292: change defragment to not create fragments > 2G

--
[...truncated 676 lines...]
com.gemstone.gemfire.management.internal.cli.commands.CommandOverHttpDUnitTest 
> 
com.gemstone.gemfire.management.internal.cli.commands.queuecommandsdunittest.testasynceventqu...@com.gemstone.gemfire.management.internal.cli.commands.CommandOverHttpDUnitTest
 FAILED
com.gemstone.gemfire.test.dunit.RMIException: While invoking 
com.gemstone.gemfire.management.internal.cli.commands.QueueCommandsDUnitTest$3.run
 in VM 1 running on Host asf902.gq1.ygridcore.net with 4 VMs
at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:389)
at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:355)
at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:293)
at 
com.gemstone.gemfire.management.internal.cli.commands.QueueCommandsDUnitTest.testAsyncEventQueue(QueueCommandsDUnitTest.java:191)

Caused by:
java.lang.AssertionError: expected: but was:

127 tests completed, 1 failed, 3 skipped
:geode-web:distributedTest FAILED
:geode-web:integrationTest
:geode-web-api:assemble
:geode-web-api:compileTestJava UP-TO-DATE
:geode-web-api:processTestResources UP-TO-DATE
:geode-web-api:testClasses UP-TO-DATE
:geode-web-api:checkMissedTests UP-TO-DATE
:geode-web-api:test UP-TO-DATE
:geode-web-api:check
:geode-web-api:build
:geode-web-api:distributedTest UP-TO-DATE
:geode-web-api:integrationTest UP-TO-DATE
:combineReports
All test reports at 

:extensions/geode-modules:precheckin
:extensions/geode-modules-assembly:precheckin
:extensions/geode-modules-hibernate:precheckin
:extensions/geode-modules-session:precheckin
:extensions/geode-modules-tomcat7:precheckin
:geode-assembly:precheckin
:geode-common:precheckin
:geode-core:precheckin
:geode-cq:precheckin
:geode-joptsimple:precheckin
:geode-json:precheckin
:geode-junit:precheckin
:geode-lucene:precheckin
:geode-pulse:precheckin
:geode-rebalancer:precheckin
:geode-web-api:precheckin
:extensions/geode-modules:uploadArchivesCould not transfer metadata 
org.apache.geode:geode-modules:1.0.0-incubating.M3-SNAPSHOT/maven-metadata.xml 
from/to remote (https://repository.apache.org/content/repositories/snapshots): 
Failed to transfer file: 
https://repository.apache.org/content/repositories/snapshots/org/apache/geode/geode-modules/1.0.0-incubating.M3-SNAPSHOT/maven-metadata.xml.
 Return code is: 502 , ReasonPhrase:Proxy Error.
 FAILED
:extensions/geode-modules-assembly:uploadArchives SKIPPED
:extensions/geode-modules-hibernate:uploadArchivesCould not transfer artifact 
org.apache.geode:geode-modules-hibernate:jar:1.0.0-incubating.M3-20160519.132302-29
 from/to remote (https://repository.apache.org/content/repositories/snapshots): 
Failed to transfer file: 
https://repository.apache.org/content/repositories/snapshots/org/apache/geode/geode-modules-hibernate/1.0.0-incubating.M3-SNAPSHOT/geode-modules-hibernate-1.0.0-incubating.M3-20160519.132302-29.jar.
 Return code is: 502, ReasonPhrase: Proxy Error.
Could not transfer artifact 
org.apache.geode:geode-modules-hibernate:pom:1.0.0-incubating.M3-20160519.132302-29
 from/to remote (https://repository.apache.org/content/repositories/snapshots): 
Connection timed out
Could not transfer artifact 
org.apache.geode:geode-modules-hibernate:jar:sources:1.0.0-incubating.M3-20160519.132302-29
 from/to remote (https://repository.apache.org/content/repositories/snapshots): 
Connection timed out
Could not transfer artifact 
org.apache.geode:geode-modules-hibernate:jar:javadoc:1.0.0-incubating.M3-20160519.132302-29
 from/to remote (https://repository.apache.org/content/repositories/snapshots): 
Connection timed out
 FAILED
:extensions/geode-modules-session:uploadArchivesCould not transfer metadata 
org.apache.geode:geode-modules-session:1.0.0-incubating.M3-SNAPSHOT/maven-metadata.xml
 from/to remote (https://repository.apache.org/content/repositories/snapshots): 
Failed to transfer file: 
https://repository.apache.org/content/repositories/snapshots/org/apache/geode/geode-modules-session/1.0.0-incubating.M3-SNAPSHOT/maven-metadata.xml.
 Return code is: 503 , ReasonPhrase:Service Unavailable.
 FAILED
:extensions/geode-modules-tomcat7:uploadArchivesCould not transfer metadata 
org.apache.geode:geode-modules-tomcat7:1.0.0-incubating.M3-SNAPSHOT/maven-metadata.xml
 from/to remote (https://repository.apache.org/content/repositories/snapsho