Re: How to execute a Partition Region join in a Function context...

2016-07-12 Thread John Blum
Note, for everyone's reference, I found the following link in a Google
search which helped me figure out my collocated PRs, Equi-Join Query
problem...

https://pubs.vmware.com/vfabric5/index.jsp?topic=/com.vmware.vfabric.gemfire.6.6/developing/partitioned_regions/join_query_partitioned_regions.html

For *Pivotal GemFire*, the reference is here...

http://gemfire.docs.pivotal.io/docs-gemfire/latest/developing/partitioned_regions/join_query_partitioned_regions.html

And for *Apache Geode*, the reference is here...

http://geode.docs.pivotal.io/docs/developing/partitioned_regions/join_query_partitioned_regions.html


I have to say that the key to properly performing an Equi-Join Query on
collocated PRs (inside a Function, no-less), given the following code
snippet from the documentation, was not very obvious...

   SelectResults result = (SelectResults)*query
 .execute((RegionFunctionContext)context)*;


Thanks,
John



On Tue, Jul 12, 2016 at 6:54 PM, John Blum  wrote:

> Thanks for the fast response Dan.
>
> Unfortunately, that did not work, given the following...
>
> protected static final String CUSTOMERS_WITH_CONTACTS_QUERY =
>"SELECT DISTINCT customer FROM /Customers customer, /Contacts contact"
>   + " WHERE customer.firstName = contact.person.firstName AND
> customer.lastName = contact.person.lastName";
>
> @GemfireFunction
> public List
> findAllCustomersWithContactInformation(FunctionContext functionContext) {
>return executeQueryOnRegion(toRegionFunctionContext(functionContext));
> }
>
> protected List executeQueryOnRegion(RegionFunctionContext
> regionFunctionContext) {
>return executeQueryOnRegion(*PartitionRegionHelper.*
> *getLocalDataForContext**(regionFunctionContext)*);
> }
>
> @SuppressWarnings("unchecked")
> protected List executeQueryOnRegion(Region
> customers) {
>try {
>   QueryService queryService =
> customers.getRegionService().getQueryService();
>   Query query = queryService.newQuery(CUSTOMERS_WITH_CONTACTS_QUERY);
>   Object results = query.execute();
>   Assert.isInstanceOf(SelectResults.class, results);
>   return ((SelectResults) results).asList();
>}
>catch (Exception e) {
>   throw new RuntimeException("?", e);
>}
> }
>
> However, the following does work...
>
> @SuppressWarnings("unchecked")
> protected List executeQueryInFunctionContext(RegionFunctionContext
> *functionContext*) {
>try {
>   QueryService queryService =
> functionContext.getDataSet().getRegionService().getQueryService();
>   Query query = queryService.newQuery(CUSTOMERS_WITH_CONTACTS_QUERY);
>   Object results = *query.execute(functionContext);*
>   Assert.isInstanceOf(SelectResults.class, results);
>   return ((SelectResults) results).asList();
>}
>catch (Exception e) {
>   throw new RuntimeException("?", e);
>}
> }
>
> This would probably make for a good example in the *Apache Geode*
> examples, sometime, ;-).  I can contribute this after SpringOne.
>
> Thanks again,
> John
>
>
> On Tue, Jul 12, 2016 at 6:03 PM, Dan Smith  wrote:
>
>> I'm not sure, but I think you might need to use the query method on the
>> Region returned from PartitionRegionHelper.getLocalDataForContext.
>>
>> -Dan
>>
>> On Tue, Jul 12, 2016 at 5:57 PM, John Blum  wrote:
>>
>> > I have 2 PRs (Customers & Contacts) and I am running a query to find all
>> > customers with contact information.  I have collocated both Customers
>> and
>> > Contacts.  Initially, I tried to run the query outside a GemFire
>> Function,
>> > which failed with...
>> >
>> > java.lang.UnsupportedOperationException: *A query on a Partitioned
>> Region (
>> > Customers ) may not reference any other region if query is NOT executed
>> > within a Function*
>> > at
>> >
>> >
>> com.gemstone.gemfire.cache.query.internal.DefaultQuery.checkQueryOnPR(DefaultQuery.java:638)
>> > at
>> >
>> >
>> com.gemstone.gemfire.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:351)
>> > at
>> >
>> >
>> org.springframework.data.gemfire.GemfireTemplate.find(GemfireTemplate.java:299)
>> >
>> > So, then I proceeded to attempt to execute my query...
>> >
>> > SELECT DISTINCT customer
>> > FROM /Customers customer, /Contacts contact"
>> > WHERE customer.firstName = contact.person.firstName
>> > AND customer.lastName = contact.person.lastName
>> >
>> > ... in a Function as instructed, however, I ended up with the same
>> > Exception.
>> >
>> > I am trying to figure out how to properly execute a JOIN on 2
>> "collocated"
>> > PRs from within a Function, given the FunctionContext (or possibly the
>> > local data set of the PR using RegionFunctionContext.getDataSet(), or
>> > something like that).
>> >
>> > Any help is appreciated.
>> >
>> > Thanks,
>> >
>> > -John
>> >
>>
>
>
>
> --
> -John
> 503-504-8657
> john.blum10101 (skype)
>



-- 
-John
503-504-8657
john.blum10101 (skype)


Re: How to execute a Partition Region join in a Function context...

2016-07-12 Thread John Blum
Thanks for the fast response Dan.

Unfortunately, that did not work, given the following...

protected static final String CUSTOMERS_WITH_CONTACTS_QUERY =
   "SELECT DISTINCT customer FROM /Customers customer, /Contacts contact"
  + " WHERE customer.firstName = contact.person.firstName AND
customer.lastName = contact.person.lastName";

@GemfireFunction
public List
findAllCustomersWithContactInformation(FunctionContext functionContext) {
   return executeQueryOnRegion(toRegionFunctionContext(functionContext));
}

protected List executeQueryOnRegion(RegionFunctionContext
regionFunctionContext) {
   return executeQueryOnRegion(*PartitionRegionHelper.*
*getLocalDataForContext**(regionFunctionContext)*);
}

@SuppressWarnings("unchecked")
protected List executeQueryOnRegion(Region
customers) {
   try {
  QueryService queryService =
customers.getRegionService().getQueryService();
  Query query = queryService.newQuery(CUSTOMERS_WITH_CONTACTS_QUERY);
  Object results = query.execute();
  Assert.isInstanceOf(SelectResults.class, results);
  return ((SelectResults) results).asList();
   }
   catch (Exception e) {
  throw new RuntimeException("?", e);
   }
}

However, the following does work...

@SuppressWarnings("unchecked")
protected List executeQueryInFunctionContext(RegionFunctionContext
*functionContext*) {
   try {
  QueryService queryService =
functionContext.getDataSet().getRegionService().getQueryService();
  Query query = queryService.newQuery(CUSTOMERS_WITH_CONTACTS_QUERY);
  Object results = *query.execute(functionContext);*
  Assert.isInstanceOf(SelectResults.class, results);
  return ((SelectResults) results).asList();
   }
   catch (Exception e) {
  throw new RuntimeException("?", e);
   }
}

This would probably make for a good example in the *Apache Geode* examples,
sometime, ;-).  I can contribute this after SpringOne.

Thanks again,
John


On Tue, Jul 12, 2016 at 6:03 PM, Dan Smith  wrote:

> I'm not sure, but I think you might need to use the query method on the
> Region returned from PartitionRegionHelper.getLocalDataForContext.
>
> -Dan
>
> On Tue, Jul 12, 2016 at 5:57 PM, John Blum  wrote:
>
> > I have 2 PRs (Customers & Contacts) and I am running a query to find all
> > customers with contact information.  I have collocated both Customers and
> > Contacts.  Initially, I tried to run the query outside a GemFire
> Function,
> > which failed with...
> >
> > java.lang.UnsupportedOperationException: *A query on a Partitioned
> Region (
> > Customers ) may not reference any other region if query is NOT executed
> > within a Function*
> > at
> >
> >
> com.gemstone.gemfire.cache.query.internal.DefaultQuery.checkQueryOnPR(DefaultQuery.java:638)
> > at
> >
> >
> com.gemstone.gemfire.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:351)
> > at
> >
> >
> org.springframework.data.gemfire.GemfireTemplate.find(GemfireTemplate.java:299)
> >
> > So, then I proceeded to attempt to execute my query...
> >
> > SELECT DISTINCT customer
> > FROM /Customers customer, /Contacts contact"
> > WHERE customer.firstName = contact.person.firstName
> > AND customer.lastName = contact.person.lastName
> >
> > ... in a Function as instructed, however, I ended up with the same
> > Exception.
> >
> > I am trying to figure out how to properly execute a JOIN on 2
> "collocated"
> > PRs from within a Function, given the FunctionContext (or possibly the
> > local data set of the PR using RegionFunctionContext.getDataSet(), or
> > something like that).
> >
> > Any help is appreciated.
> >
> > Thanks,
> >
> > -John
> >
>



-- 
-John
503-504-8657
john.blum10101 (skype)


Re: How to execute a Partition Region join in a Function context...

2016-07-12 Thread Dan Smith
I'm not sure, but I think you might need to use the query method on the
Region returned from PartitionRegionHelper.getLocalDataForContext.

-Dan

On Tue, Jul 12, 2016 at 5:57 PM, John Blum  wrote:

> I have 2 PRs (Customers & Contacts) and I am running a query to find all
> customers with contact information.  I have collocated both Customers and
> Contacts.  Initially, I tried to run the query outside a GemFire Function,
> which failed with...
>
> java.lang.UnsupportedOperationException: *A query on a Partitioned Region (
> Customers ) may not reference any other region if query is NOT executed
> within a Function*
> at
>
> com.gemstone.gemfire.cache.query.internal.DefaultQuery.checkQueryOnPR(DefaultQuery.java:638)
> at
>
> com.gemstone.gemfire.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:351)
> at
>
> org.springframework.data.gemfire.GemfireTemplate.find(GemfireTemplate.java:299)
>
> So, then I proceeded to attempt to execute my query...
>
> SELECT DISTINCT customer
> FROM /Customers customer, /Contacts contact"
> WHERE customer.firstName = contact.person.firstName
> AND customer.lastName = contact.person.lastName
>
> ... in a Function as instructed, however, I ended up with the same
> Exception.
>
> I am trying to figure out how to properly execute a JOIN on 2 "collocated"
> PRs from within a Function, given the FunctionContext (or possibly the
> local data set of the PR using RegionFunctionContext.getDataSet(), or
> something like that).
>
> Any help is appreciated.
>
> Thanks,
>
> -John
>


How to execute a Partition Region join in a Function context...

2016-07-12 Thread John Blum
I have 2 PRs (Customers & Contacts) and I am running a query to find all
customers with contact information.  I have collocated both Customers and
Contacts.  Initially, I tried to run the query outside a GemFire Function,
which failed with...

java.lang.UnsupportedOperationException: *A query on a Partitioned Region (
Customers ) may not reference any other region if query is NOT executed
within a Function*
at
com.gemstone.gemfire.cache.query.internal.DefaultQuery.checkQueryOnPR(DefaultQuery.java:638)
at
com.gemstone.gemfire.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:351)
at
org.springframework.data.gemfire.GemfireTemplate.find(GemfireTemplate.java:299)

So, then I proceeded to attempt to execute my query...

SELECT DISTINCT customer
FROM /Customers customer, /Contacts contact"
WHERE customer.firstName = contact.person.firstName
AND customer.lastName = contact.person.lastName

... in a Function as instructed, however, I ended up with the same
Exception.

I am trying to figure out how to properly execute a JOIN on 2 "collocated"
PRs from within a Function, given the FunctionContext (or possibly the
local data set of the PR using RegionFunctionContext.getDataSet(), or
something like that).

Any help is appreciated.

Thanks,

-John


Re: Review Request 49966: GEODE-11 Adding tests of closing a cache during index updates

2016-07-12 Thread xiaojian zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49966/#review141994
---


Ship it!




Update and ship it.

- xiaojian zhou


On July 12, 2016, 9:18 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49966/
> ---
> 
> (Updated July 12, 2016, 9:18 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Testing failover of lucene indexes by closing the cache while in the
> middle of updating lucene indexes. Currently there are tests for closing
> the cache before the index repository commit, and also during the commit
> after a fixed number of updates to the underling index data regions.
> 
> I refactored the lucene tests to use 7 buckets, rather than 113, so they 
> take less time and are easier to debug.
> 
> I also removed a call to Thread.interrupt in the WAN code because it was 
> interrupting itself in my callback. We should never be using interrupt 
> in the product.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  9cde6dd9b63e23ac3903c40e2d364766fffc725a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
>  b63c7cbcda2cb610e07020607ae892377785e17b 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/IndexRepositoryFactory.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPRBase.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRegionSpy.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRepositorySpy.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49966/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



[GitHub] incubator-geode pull request #193: GEODE-1646: repackage new Security classe...

2016-07-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/193


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread theseusyang
Dan ,I have updated some test pages successfully!

Thank you very much!



2016-07-13 1:23 GMT+08:00 Dan Smith [via Apache Geode (Incubating)
Developers Forum] :

> Ok, I think you should be able to add a page
> https://cwiki.apache.org/confluence/display/GEODE/Index now.
>
> Thanks!
> -Dan
>
> On Tue, Jul 12, 2016 at 10:30 AM, yang theseus <[hidden email]
> >
> wrote:
>
> > Great, Dan!
> > On apache wiki, My name is theseusyang , or email is [hidden email]
> 
> >
> > 2016-07-13 1:28 GMT+08:00 yang theseus <[hidden email]
> >:
> >
> > > xiaojian, Can you open a writing permission for me?
> > >
> > > thank you
> > >
> > > 2016-07-13 1:18 GMT+08:00 yang theseus <[hidden email]
> >:
> > >
> > >> Indeed, I have no the permits to add contents on wiki page.
> > >>
> > >> 2016-07-13 0:45 GMT+08:00 theseusyang <[hidden email]
> >:
> > >>
> > >>> Ok, thanks xiaojian.
> > >>>
> > >>> 2016-07-13 0:42 GMT+08:00 Xiaojian Zhou [via Apache Geode
> (Incubating)
> > >>> Developers Forum] <[hidden email]
> >:
> > >>>
> > >>> > You can add a wiki page for geode with chinese characters. I just
> did
> > >>> some
> > >>> > test.
> > >>> >
> > >>> >
> > >>> >
> > >>>
> >
> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
> > >>> >
> > >>> > I added some chinese characters into above document.
> > >>> >
> > >>> > On Tue, Jul 12, 2016 at 9:33 AM, theseusyang <[hidden email]
> > >>> > > wrote:
> > >>> >
> > >>> > > Yeah, xiaojian.
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> > > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode
> > >>> (Incubating)
> > >>> > > Developers Forum] <[hidden email]
> > >>> > >:
> > >>>
> > >>> > >
> > >>> > > > Do you mean to publish into geode wiki or check into geode
> source
> > >>> > code?
> > >>> > > >
> > >>> > > > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> > >>> > > > > wrote:
> > >>> > > >
> > >>> > > > > Do you mean chinese file name or content in a PDF or text
> file?
> > >>> > > > >
> > >>> > > > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> > >>> > > > >
> > >>> > > > > wrote:
> > >>> > > > >
> > >>> > > > >> Hi All,
> > >>> > > > >>
> > >>> > > > >> I have translated some chinese documents about geode
> > >>> installation,
> > >>> > > > >> deployment,features.
> > >>> > > > >> Now the main question is that How to put the chinese
> documents
> > >>> to
> > >>> > > > apache
> > >>> > > > >> geode site?
> > >>> > > > >>
> > >>> > > > >> Does anybody know that?
> > >>> > > > >>
> > >>> > > > >> Thank you very much!
> > >>> > > > >>
> > >>> > > > >> theseus yang
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >> --
> > >>> > > > >> View this message in context:
> > >>> > > > >>
> > >>> > > >
> > >>> > >
> > >>> >
> > >>>
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> > >>> > > > >> Sent from the Apache Geode (Incubating) Developers Forum
> > mailing
> > >>> > list
> > >>> > > > >> archive at Nabble.com.
> > >>> > > > >>
> > >>> > > > >
> > >>> > > > >
> > >>> > > >
> > >>> > > >
> > >>> > > > --
> > >>> > > > If you reply to this email, your message will be added to the
> > >>> > discussion
> > >>> > > > below:
> > >>> > > >
> > >>> > > >
> > >>> > >
> > >>> >
> > >>>
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> > >>> > > > To unsubscribe from How to commit the chinese documents to
> apache
> > >>> > geode
> > >>> > > > site?, click here
> > >>> > > > <
> > >>> > > >
> > >>> > > > .
> > >>> > > > NAML
> > >>> > > > <
> > >>> > >
> > >>> >
> > >>>
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> > >>> > > >
> > >>> > > >
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> > > --
> > >>> > > View this message in context:
> > >>> > >
> > >>> >
> > >>>
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/H

Re: Review Request 49966: GEODE-11 Adding tests of closing a cache during index updates

2016-07-12 Thread Barry Oglesby

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49966/#review141983
---


Ship it!




Ship It!

- Barry Oglesby


On July 12, 2016, 9:18 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49966/
> ---
> 
> (Updated July 12, 2016, 9:18 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Testing failover of lucene indexes by closing the cache while in the
> middle of updating lucene indexes. Currently there are tests for closing
> the cache before the index repository commit, and also during the commit
> after a fixed number of updates to the underling index data regions.
> 
> I refactored the lucene tests to use 7 buckets, rather than 113, so they 
> take less time and are easier to debug.
> 
> I also removed a call to Thread.interrupt in the WAN code because it was 
> interrupting itself in my callback. We should never be using interrupt 
> in the product.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  9cde6dd9b63e23ac3903c40e2d364766fffc725a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
>  b63c7cbcda2cb610e07020607ae892377785e17b 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/IndexRepositoryFactory.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPRBase.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRegionSpy.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRepositorySpy.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49966/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



Re: Trouble with AnalyzeSerializablesJUnitTest

2016-07-12 Thread Kirk Lund
Good eye -- that's it! Turns out I have two instances
of actualSerializables.dat which is output from the test:

1) ./geode-core/actualSerializables.dat
2) ./geode-core/build/integrationTest/actualSerializables.dat

./geode-core/actualSerializables.dat was generated when I ran
AnalyzeSerializablesJUnitTest within my IDE (IntelliJ). This one is old.

./geode-core/build/integrationTest/actualSerializables.dat was generated
when I ran the test from the command-line. This is the correct one.

I was overwriting the sanctionedSerializables.txt file with the wrong one.

I have it passing now!

Thanks,
Kirk

On Tue, Jul 12, 2016 at 4:15 PM, Bruce Schuchardt 
wrote:

> How did an actualSerializables.dat file come to be in the geode-core
> directory?  It should be in the geode-core/build/integrationTest
> directory.  Verify that the sanctionedSerializables.txt file has the Redis
> classes in it.  If that's not the problem I can look into it with you.
>
>
> Le 7/12/2016 à 11:53 AM, Kirk Lund a écrit :
>
>> Looks like I need some help with AnalyzeSerializablesJUnitTest.
>>
>> When I run the test it fails and my understanding is that I need to update
>> the sanctionedSerializables.txt and excludedClasses.txt as appropriate.
>>
>> I've copied actualSerializables.dat over sanctionedSerializables.txt after
>> running the test:
>>
>> $ cp ./geode-core/actualSerializables.dat
>>
>> ./geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt
>>
>> I've added GeodePermission and GeodeSecurityUtil to excludedClasses.txt:
>>
>> I've done a clean and a build and the test still fails 100% for me. Now
>> I'm
>> sure I've followed this process before (many times in fact). Is this
>> failing because the test can't handle "org/apache/geode" or something?
>>
>> -Kirk
>>
>> com.gemstone.gemfire.codeAnalysis.AnalyzeSerializablesJUnitTest >
>> testSerializables
>>   FAILED
>>  java.lang.AssertionError: New or moved
>> classes
>>
>>
>> org/apache/geode/redis/internal/RedisCommandParserException,true,4707944288714910949:
>> new class
>>  org/apache/geode/redis/internal/RedisCommandType,false: new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$1,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$10,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$100,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$101,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$102,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$103,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$104,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$105,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$106,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$107,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$108,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$109,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$11,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$110,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new class
>>
>>
>> org/apache/geode/redis/internal/RedisCommandType$111,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
>> new 

Re: GMSAuthenticator

2016-07-12 Thread Kirk Lund
Ok, I'll plan to change GMSAuthenticator (and GMSAuthenticatorJUnitTest) to
use the DistributionConfig then. That'll be more consistent and correct.

Thanks,
Kirk


On Tue, Jul 12, 2016 at 4:19 PM, Bruce Schuchardt 
wrote:

> I think we should get rid of that.  It's a hack that the engineer who
> implemented the old AUTH protocol used because he didn't know how to get
> hold of the DistributionConfig.  GMSAuthenticator can get at the config
> through services.getConfig().getDistributionConfig().
>
>
>
> Le 7/12/2016 à 2:36 PM, Hitesh Khamesra a écrit :
>
>> It seems InternalDistributedSystem(DistributedConfigImpl) sets system
>> property while creating ds.
>>
>>  if (securityPeerAuthInit != null && securityPeerAuthInit.length() >
>> 0) {
>>System.setProperty(SECURITY_SYSTEM_PREFIX +
>> SECURITY_PEER_AUTH_INIT,
>>securityPeerAuthInit);
>>  }
>>  if (securityPeerAuthenticator != null
>>  && securityPeerAuthenticator.length() > 0) {
>>System.setProperty(SECURITY_SYSTEM_PREFIX
>>+ SECURITY_PEER_AUTHENTICATOR, securityPeerAuthenticator);
>>  }
>>
>>
>>
>>From: Kirk Lund 
>>   To: geode ; Hitesh Khamesra <
>> hitesh...@yahoo.com>
>>   Sent: Tuesday, July 12, 2016 2:24 PM
>>   Subject: Re: GMSAuthenticator
>> I still don't see DistributionConfig or Properties ever being passed
>> into
>> GMSAuthenticator.
>>
>> The following method is for testing only so gemfire properties are never
>> passed in by product code:
>>
>> /**
>>   * For testing only.
>>   */
>> Properties getCredentials(DistributedMember member, Properties secProps) {
>>
>> The following method is the only one used by the product but it doesn't
>> pass any config in:
>>
>> /**
>>   * Get credential object for the given GemFire distributed member.
>>   *
>>   * @param  member
>>   *the target distributed member
>>   * @return the credential object
>>   */
>> @Override
>> public Object getCredentials(InternalDistributedMember member) {
>>try {
>>  return getCredentials(member, securityProps);
>>
>> So the only source of config seems to be that securityProps variable, and
>> the declaration is the ONLY place where securityProps is ever set (and
>> nothing ever modifies it):
>>
>> private Properties securityProps = getSecurityProps();
>>
>> You can see that getSecurityProps() only ever reads from system
>> properties:
>>
>> Properties getSecurityProps() {
>>Properties props = new Properties();
>>Set keys = System.getProperties().keySet();
>>for (Object key: keys) {
>>  String propKey = (String) key;
>>  if (propKey.startsWith(secPrefix)) {
>>props.setProperty(propKey.substring(gemfireSysPrefixLen),
>> System.getProperty(propKey));
>>  }
>>}
>>return props;
>> }
>>
>> It would appear to me that the only way to successfully provide gemfire
>> security- propertes to GMSAuthenticator is via System properties.
>>
>> -Kirk
>>
>> On Tue, Jul 12, 2016 at 1:56 PM, Hitesh Khamesra <
>> hitesh...@yahoo.com.invalid> wrote:
>>
>> One can specify following in gemfire.properties file
>>>/**
>>>  * The static String definition of the
>>> "security-peer-authenticator"
>>>  * property
>>>  */
>>>String SECURITY_PEER_AUTHENTICATOR = SECURITY_PREFIX +
>>> "peer-authenticator";
>>>
>>>
>>>From: Kirk Lund 
>>>To: geode 
>>>Sent: Tuesday, July 12, 2016 11:56 AM
>>>Subject: GMSAuthenticator
>>>
>>> We're looking into modifying peer authentication to work with
>>> org.apache.geode.security.SecurityManager as well as the deprecated
>>> Authenticator and AccessControl.
>>>
>>> GMSAuthenticator appears to only work with Security Properties that are
>>> specified as System Properties with "gemfire." prefix. The other areas of
>>> the product that perform authentication appear to work whether the
>>> Security
>>> Properties are specified with either System Properties or a Properties
>>> instance passed into connect.
>>>
>>> The online documentation for enabling peer authentication says to use
>>> gemfire.properties, but from what I can tell the GMSAuthenticator won't
>>> work with gemfire.properties and will instead require you to specify
>>> System
>>> properties ala
>>> -Dgemfire.security-peer-authenticator=MyAuthenticator.create.
>>>
>>> Am I missing some code path that supports non-System properties in
>>> GMSAuthenticator? Or is peer authentication limited to only working with
>>> System properties?
>>>
>>> Thanks,
>>> Kirk
>>>
>>>
>>>
>>>
>>>
>>
>>
>
>


Re: GMSAuthenticator

2016-07-12 Thread Bruce Schuchardt
I think we should get rid of that.  It's a hack that the engineer who 
implemented the old AUTH protocol used because he didn't know how to get 
hold of the DistributionConfig.  GMSAuthenticator can get at the config 
through services.getConfig().getDistributionConfig().



Le 7/12/2016 à 2:36 PM, Hitesh Khamesra a écrit :

It seems InternalDistributedSystem(DistributedConfigImpl) sets system property 
while creating ds.

 if (securityPeerAuthInit != null && securityPeerAuthInit.length() > 0) {
   System.setProperty(SECURITY_SYSTEM_PREFIX + SECURITY_PEER_AUTH_INIT,
   securityPeerAuthInit);
 }
 if (securityPeerAuthenticator != null
 && securityPeerAuthenticator.length() > 0) {
   System.setProperty(SECURITY_SYSTEM_PREFIX
   + SECURITY_PEER_AUTHENTICATOR, securityPeerAuthenticator);
 }



   From: Kirk Lund 
  To: geode ; Hitesh Khamesra 

  Sent: Tuesday, July 12, 2016 2:24 PM
  Subject: Re: GMSAuthenticator

I still don't see DistributionConfig or Properties ever being passed into

GMSAuthenticator.

The following method is for testing only so gemfire properties are never
passed in by product code:

/**
  * For testing only.
  */
Properties getCredentials(DistributedMember member, Properties secProps) {

The following method is the only one used by the product but it doesn't
pass any config in:

/**
  * Get credential object for the given GemFire distributed member.
  *
  * @param  member
  *the target distributed member
  * @return the credential object
  */
@Override
public Object getCredentials(InternalDistributedMember member) {
   try {
 return getCredentials(member, securityProps);

So the only source of config seems to be that securityProps variable, and
the declaration is the ONLY place where securityProps is ever set (and
nothing ever modifies it):

private Properties securityProps = getSecurityProps();

You can see that getSecurityProps() only ever reads from system properties:

Properties getSecurityProps() {
   Properties props = new Properties();
   Set keys = System.getProperties().keySet();
   for (Object key: keys) {
 String propKey = (String) key;
 if (propKey.startsWith(secPrefix)) {
   props.setProperty(propKey.substring(gemfireSysPrefixLen),
System.getProperty(propKey));
 }
   }
   return props;
}

It would appear to me that the only way to successfully provide gemfire
security- propertes to GMSAuthenticator is via System properties.

-Kirk

On Tue, Jul 12, 2016 at 1:56 PM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:


One can specify following in gemfire.properties file
   /**
 * The static String definition of the
"security-peer-authenticator"
 * property
 */
   String SECURITY_PEER_AUTHENTICATOR = SECURITY_PREFIX +
"peer-authenticator";


   From: Kirk Lund 
   To: geode 
   Sent: Tuesday, July 12, 2016 11:56 AM
   Subject: GMSAuthenticator

We're looking into modifying peer authentication to work with
org.apache.geode.security.SecurityManager as well as the deprecated
Authenticator and AccessControl.

GMSAuthenticator appears to only work with Security Properties that are
specified as System Properties with "gemfire." prefix. The other areas of
the product that perform authentication appear to work whether the Security
Properties are specified with either System Properties or a Properties
instance passed into connect.

The online documentation for enabling peer authentication says to use
gemfire.properties, but from what I can tell the GMSAuthenticator won't
work with gemfire.properties and will instead require you to specify System
properties ala
-Dgemfire.security-peer-authenticator=MyAuthenticator.create.

Am I missing some code path that supports non-System properties in
GMSAuthenticator? Or is peer authentication limited to only working with
System properties?

Thanks,
Kirk






   




Re: Trouble with AnalyzeSerializablesJUnitTest

2016-07-12 Thread Bruce Schuchardt
How did an actualSerializables.dat file come to be in the geode-core 
directory?  It should be in the geode-core/build/integrationTest 
directory.  Verify that the sanctionedSerializables.txt file has the 
Redis classes in it.  If that's not the problem I can look into it with you.


Le 7/12/2016 à 11:53 AM, Kirk Lund a écrit :

Looks like I need some help with AnalyzeSerializablesJUnitTest.

When I run the test it fails and my understanding is that I need to update
the sanctionedSerializables.txt and excludedClasses.txt as appropriate.

I've copied actualSerializables.dat over sanctionedSerializables.txt after
running the test:

$ cp ./geode-core/actualSerializables.dat
./geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt

I've added GeodePermission and GeodeSecurityUtil to excludedClasses.txt:

I've done a clean and a build and the test still fails 100% for me. Now I'm
sure I've followed this process before (many times in fact). Is this
failing because the test can't handle "org/apache/geode" or something?

-Kirk

com.gemstone.gemfire.codeAnalysis.AnalyzeSerializablesJUnitTest >
testSerializables
  FAILED
 java.lang.AssertionError: New or moved
classes

org/apache/geode/redis/internal/RedisCommandParserException,true,4707944288714910949:
new class
 org/apache/geode/redis/internal/RedisCommandType,false: new class

org/apache/geode/redis/internal/RedisCommandType$1,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$10,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$100,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$101,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$102,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$103,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$104,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$105,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$106,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$107,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$108,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$109,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$11,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$110,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$111,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$112,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$113,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$12,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$13,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$14,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisComman

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #368 was SUCCESSFUL (with 1410 tests)

2016-07-12 Thread Spring CI

---
Spring Data GemFire > Nightly-ApacheGeode > #368 was successful.
---
Scheduled
1412 tests in total.

https://build.spring.io/browse/SGF-NAG-368/





--
This message is automatically generated by Atlassian Bamboo

Re: GMSAuthenticator

2016-07-12 Thread Kirk Lund
Ah, thank you Hitesh! I didn't realize InternalDistributedSystem was doing
that with the security properties.

-Kirk

On Tue, Jul 12, 2016 at 2:36 PM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:

> It seems InternalDistributedSystem(DistributedConfigImpl) sets system
> property while creating ds.
>
> if (securityPeerAuthInit != null && securityPeerAuthInit.length() > 0)
> {
>   System.setProperty(SECURITY_SYSTEM_PREFIX + SECURITY_PEER_AUTH_INIT,
>   securityPeerAuthInit);
> }
> if (securityPeerAuthenticator != null
> && securityPeerAuthenticator.length() > 0) {
>   System.setProperty(SECURITY_SYSTEM_PREFIX
>   + SECURITY_PEER_AUTHENTICATOR, securityPeerAuthenticator);
> }
>
>
>
>   From: Kirk Lund 
>  To: geode ; Hitesh Khamesra <
> hitesh...@yahoo.com>
>  Sent: Tuesday, July 12, 2016 2:24 PM
>  Subject: Re: GMSAuthenticator
>
> I still don't see DistributionConfig or Properties ever being passed into
> GMSAuthenticator.
>
> The following method is for testing only so gemfire properties are never
> passed in by product code:
>
> /**
>  * For testing only.
>  */
> Properties getCredentials(DistributedMember member, Properties secProps) {
>
> The following method is the only one used by the product but it doesn't
> pass any config in:
>
> /**
>  * Get credential object for the given GemFire distributed member.
>  *
>  * @param  member
>  *the target distributed member
>  * @return the credential object
>  */
> @Override
> public Object getCredentials(InternalDistributedMember member) {
>   try {
> return getCredentials(member, securityProps);
>
> So the only source of config seems to be that securityProps variable, and
> the declaration is the ONLY place where securityProps is ever set (and
> nothing ever modifies it):
>
> private Properties securityProps = getSecurityProps();
>
> You can see that getSecurityProps() only ever reads from system properties:
>
> Properties getSecurityProps() {
>   Properties props = new Properties();
>   Set keys = System.getProperties().keySet();
>   for (Object key: keys) {
> String propKey = (String) key;
> if (propKey.startsWith(secPrefix)) {
>   props.setProperty(propKey.substring(gemfireSysPrefixLen),
> System.getProperty(propKey));
> }
>   }
>   return props;
> }
>
> It would appear to me that the only way to successfully provide gemfire
> security- propertes to GMSAuthenticator is via System properties.
>
> -Kirk
>
> On Tue, Jul 12, 2016 at 1:56 PM, Hitesh Khamesra <
> hitesh...@yahoo.com.invalid> wrote:
>
> > One can specify following in gemfire.properties file
> >  /**
> >* The static String definition of the
> > "security-peer-authenticator"
> >* property
> >*/
> >  String SECURITY_PEER_AUTHENTICATOR = SECURITY_PREFIX +
> > "peer-authenticator";
> >
> >
> >  From: Kirk Lund 
> >  To: geode 
> >  Sent: Tuesday, July 12, 2016 11:56 AM
> >  Subject: GMSAuthenticator
> >
> > We're looking into modifying peer authentication to work with
> > org.apache.geode.security.SecurityManager as well as the deprecated
> > Authenticator and AccessControl.
> >
> > GMSAuthenticator appears to only work with Security Properties that are
> > specified as System Properties with "gemfire." prefix. The other areas of
> > the product that perform authentication appear to work whether the
> Security
> > Properties are specified with either System Properties or a Properties
> > instance passed into connect.
> >
> > The online documentation for enabling peer authentication says to use
> > gemfire.properties, but from what I can tell the GMSAuthenticator won't
> > work with gemfire.properties and will instead require you to specify
> System
> > properties ala
> > -Dgemfire.security-peer-authenticator=MyAuthenticator.create.
> >
> > Am I missing some code path that supports non-System properties in
> > GMSAuthenticator? Or is peer authentication limited to only working with
> > System properties?
> >
> > Thanks,
> > Kirk
> >
> >
> >
> >
>
>
>
>


Re: Security - callback

2016-07-12 Thread Jinmei Liao
We will look into performance once we get all the functionality into place.
There are ways to do the checks earlier in the call and we will look into
that shortly.

On Tue, Jul 12, 2016 at 2:22 PM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:

> We are calling " GeodeSecurityUtil.authorizeRegionWrite(regionName);" in
> each client-server command . This call does lots of work to figure out
> whether security is configured or not. Can we have some boolean check to
> avoid that as it hurts performance.




-- 
Cheers

Jinmei


Re: GMSAuthenticator

2016-07-12 Thread Hitesh Khamesra
It seems InternalDistributedSystem(DistributedConfigImpl) sets system property 
while creating ds.

    if (securityPeerAuthInit != null && securityPeerAuthInit.length() > 0) {
  System.setProperty(SECURITY_SYSTEM_PREFIX + SECURITY_PEER_AUTH_INIT,
  securityPeerAuthInit);
    }
    if (securityPeerAuthenticator != null
    && securityPeerAuthenticator.length() > 0) {
  System.setProperty(SECURITY_SYSTEM_PREFIX
  + SECURITY_PEER_AUTHENTICATOR, securityPeerAuthenticator);
    }



  From: Kirk Lund 
 To: geode ; Hitesh Khamesra 
 
 Sent: Tuesday, July 12, 2016 2:24 PM
 Subject: Re: GMSAuthenticator
   
I still don't see DistributionConfig or Properties ever being passed into
GMSAuthenticator.

The following method is for testing only so gemfire properties are never
passed in by product code:

/**
 * For testing only.
 */
Properties getCredentials(DistributedMember member, Properties secProps) {

The following method is the only one used by the product but it doesn't
pass any config in:

/**
 * Get credential object for the given GemFire distributed member.
 *
 * @param  member
 *        the target distributed member
 * @return the credential object
 */
@Override
public Object getCredentials(InternalDistributedMember member) {
  try {
    return getCredentials(member, securityProps);

So the only source of config seems to be that securityProps variable, and
the declaration is the ONLY place where securityProps is ever set (and
nothing ever modifies it):

private Properties securityProps = getSecurityProps();

You can see that getSecurityProps() only ever reads from system properties:

Properties getSecurityProps() {
  Properties props = new Properties();
  Set keys = System.getProperties().keySet();
  for (Object key: keys) {
    String propKey = (String) key;
    if (propKey.startsWith(secPrefix)) {
      props.setProperty(propKey.substring(gemfireSysPrefixLen),
System.getProperty(propKey));
    }
  }
  return props;
}

It would appear to me that the only way to successfully provide gemfire
security- propertes to GMSAuthenticator is via System properties.

-Kirk

On Tue, Jul 12, 2016 at 1:56 PM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:

> One can specify following in gemfire.properties file
>  /**
>    * The static String definition of the
> "security-peer-authenticator"
>    * property
>    */
>  String SECURITY_PEER_AUTHENTICATOR = SECURITY_PREFIX +
> "peer-authenticator";
>
>
>      From: Kirk Lund 
>  To: geode 
>  Sent: Tuesday, July 12, 2016 11:56 AM
>  Subject: GMSAuthenticator
>
> We're looking into modifying peer authentication to work with
> org.apache.geode.security.SecurityManager as well as the deprecated
> Authenticator and AccessControl.
>
> GMSAuthenticator appears to only work with Security Properties that are
> specified as System Properties with "gemfire." prefix. The other areas of
> the product that perform authentication appear to work whether the Security
> Properties are specified with either System Properties or a Properties
> instance passed into connect.
>
> The online documentation for enabling peer authentication says to use
> gemfire.properties, but from what I can tell the GMSAuthenticator won't
> work with gemfire.properties and will instead require you to specify System
> properties ala
> -Dgemfire.security-peer-authenticator=MyAuthenticator.create.
>
> Am I missing some code path that supports non-System properties in
> GMSAuthenticator? Or is peer authentication limited to only working with
> System properties?
>
> Thanks,
> Kirk
>
>
>
>


  

Security - callback

2016-07-12 Thread Hitesh Khamesra
We are calling " GeodeSecurityUtil.authorizeRegionWrite(regionName);" in each 
client-server command . This call does lots of work to figure out whether 
security is configured or not. Can we have some boolean check to avoid that as 
it hurts performance.

Re: GMSAuthenticator

2016-07-12 Thread Kirk Lund
I still don't see DistributionConfig or Properties ever being passed into
GMSAuthenticator.

The following method is for testing only so gemfire properties are never
passed in by product code:

/**
 * For testing only.
 */
Properties getCredentials(DistributedMember member, Properties secProps) {

The following method is the only one used by the product but it doesn't
pass any config in:

/**
 * Get credential object for the given GemFire distributed member.
 *
 * @param  member
 * the target distributed member
 * @return the credential object
 */
@Override
public Object getCredentials(InternalDistributedMember member) {
  try {
return getCredentials(member, securityProps);

So the only source of config seems to be that securityProps variable, and
the declaration is the ONLY place where securityProps is ever set (and
nothing ever modifies it):

private Properties securityProps = getSecurityProps();

You can see that getSecurityProps() only ever reads from system properties:

Properties getSecurityProps() {
  Properties props = new Properties();
  Set keys = System.getProperties().keySet();
  for (Object key: keys) {
String propKey = (String) key;
if (propKey.startsWith(secPrefix)) {
  props.setProperty(propKey.substring(gemfireSysPrefixLen),
System.getProperty(propKey));
}
  }
  return props;
}

It would appear to me that the only way to successfully provide gemfire
security- propertes to GMSAuthenticator is via System properties.

-Kirk

On Tue, Jul 12, 2016 at 1:56 PM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:

> One can specify following in gemfire.properties file
>   /**
>* The static String definition of the
> "security-peer-authenticator"
>* property
>*/
>   String SECURITY_PEER_AUTHENTICATOR = SECURITY_PREFIX +
> "peer-authenticator";
>
>
>   From: Kirk Lund 
>  To: geode 
>  Sent: Tuesday, July 12, 2016 11:56 AM
>  Subject: GMSAuthenticator
>
> We're looking into modifying peer authentication to work with
> org.apache.geode.security.SecurityManager as well as the deprecated
> Authenticator and AccessControl.
>
> GMSAuthenticator appears to only work with Security Properties that are
> specified as System Properties with "gemfire." prefix. The other areas of
> the product that perform authentication appear to work whether the Security
> Properties are specified with either System Properties or a Properties
> instance passed into connect.
>
> The online documentation for enabling peer authentication says to use
> gemfire.properties, but from what I can tell the GMSAuthenticator won't
> work with gemfire.properties and will instead require you to specify System
> properties ala
> -Dgemfire.security-peer-authenticator=MyAuthenticator.create.
>
> Am I missing some code path that supports non-System properties in
> GMSAuthenticator? Or is peer authentication limited to only working with
> System properties?
>
> Thanks,
> Kirk
>
>
>
>


Review Request 49966: GEODE-11 Adding tests of closing a cache during index updates

2016-07-12 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49966/
---

Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, and 
xiaojian zhou.


Repository: geode


Description
---

Testing failover of lucene indexes by closing the cache while in the
middle of updating lucene indexes. Currently there are tests for closing
the cache before the index repository commit, and also during the commit
after a fixed number of updates to the underling index data regions.

I refactored the lucene tests to use 7 buckets, rather than 113, so they 
take less time and are easier to debug.

I also removed a call to Thread.interrupt in the WAN code because it was 
interrupting itself in my callback. We should never be using interrupt 
in the product.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
 9cde6dd9b63e23ac3903c40e2d364766fffc725a 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
 b63c7cbcda2cb610e07020607ae892377785e17b 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/IndexRepositoryFactory.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPRBase.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRDUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRegionSpy.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRepositorySpy.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49966/diff/


Testing
---


Thanks,

Dan Smith



Re: GMSAuthenticator

2016-07-12 Thread Hitesh Khamesra
One can specify following in gemfire.properties file
  /**
   * The static String definition of the "security-peer-authenticator"
   * property
   */
  String SECURITY_PEER_AUTHENTICATOR = SECURITY_PREFIX + "peer-authenticator";


  From: Kirk Lund 
 To: geode  
 Sent: Tuesday, July 12, 2016 11:56 AM
 Subject: GMSAuthenticator
   
We're looking into modifying peer authentication to work with
org.apache.geode.security.SecurityManager as well as the deprecated
Authenticator and AccessControl.

GMSAuthenticator appears to only work with Security Properties that are
specified as System Properties with "gemfire." prefix. The other areas of
the product that perform authentication appear to work whether the Security
Properties are specified with either System Properties or a Properties
instance passed into connect.

The online documentation for enabling peer authentication says to use
gemfire.properties, but from what I can tell the GMSAuthenticator won't
work with gemfire.properties and will instead require you to specify System
properties ala -Dgemfire.security-peer-authenticator=MyAuthenticator.create.

Am I missing some code path that supports non-System properties in
GMSAuthenticator? Or is peer authentication limited to only working with
System properties?

Thanks,
Kirk


  

GMSAuthenticator

2016-07-12 Thread Kirk Lund
We're looking into modifying peer authentication to work with
org.apache.geode.security.SecurityManager as well as the deprecated
Authenticator and AccessControl.

GMSAuthenticator appears to only work with Security Properties that are
specified as System Properties with "gemfire." prefix. The other areas of
the product that perform authentication appear to work whether the Security
Properties are specified with either System Properties or a Properties
instance passed into connect.

The online documentation for enabling peer authentication says to use
gemfire.properties, but from what I can tell the GMSAuthenticator won't
work with gemfire.properties and will instead require you to specify System
properties ala -Dgemfire.security-peer-authenticator=MyAuthenticator.create.

Am I missing some code path that supports non-System properties in
GMSAuthenticator? Or is peer authentication limited to only working with
System properties?

Thanks,
Kirk


[GitHub] incubator-geode issue #198: GEODE-1571: Create no argument constructor for S...

2016-07-12 Thread jinmeiliao
Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/198
  
I'll handle this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Trouble with AnalyzeSerializablesJUnitTest

2016-07-12 Thread Kirk Lund
Looks like I need some help with AnalyzeSerializablesJUnitTest.

When I run the test it fails and my understanding is that I need to update
the sanctionedSerializables.txt and excludedClasses.txt as appropriate.

I've copied actualSerializables.dat over sanctionedSerializables.txt after
running the test:

$ cp ./geode-core/actualSerializables.dat
./geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt

I've added GeodePermission and GeodeSecurityUtil to excludedClasses.txt:

I've done a clean and a build and the test still fails 100% for me. Now I'm
sure I've followed this process before (many times in fact). Is this
failing because the test can't handle "org/apache/geode" or something?

-Kirk

com.gemstone.gemfire.codeAnalysis.AnalyzeSerializablesJUnitTest >
testSerializables
 FAILED
java.lang.AssertionError: New or moved
classes

org/apache/geode/redis/internal/RedisCommandParserException,true,4707944288714910949:
new class
org/apache/geode/redis/internal/RedisCommandType,false: new class

org/apache/geode/redis/internal/RedisCommandType$1,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$10,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$100,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$101,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$102,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$103,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$104,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$105,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$106,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$107,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$108,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$109,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$11,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$110,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$111,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$112,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$113,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$12,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$13,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$14,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$15,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/internal/RedisCommandType$16,false,dataType:org/apache/geode/redis/internal/RedisDataType,executor:org/apache/geode/redis/internal/Executor:
new class

org/apache/geode/redis/inte

[GitHub] incubator-geode pull request #198: GEODE-1571: Create no argument constructo...

2016-07-12 Thread gracemeilen
GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/198

GEODE-1571: Create no argument constructor for SampleSecurityManager



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1571

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #198


commit 28823f9b236a113fba961941a864f6a98ee0db91
Author: gmeilen 
Date:   2016-07-12T18:26:53Z

GEODE-1571: Create no argument constructor for SampleSecurityManager

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Missing Sign Off on Board Report

2016-07-12 Thread Nabarun Nag
As per the incubator wiki,

Tue July 12

Mentor signoff due by end of day


Please do let us know if any modifications are required  in the report.

Regards
Nabarun Nag

On Tue, Jul 12, 2016 at 11:00 AM Kirk Lund  wrote:

> Please let us know if we skipped anything on our end for getting this
> reported completed.
>
> Thank you,
> Kirk
>
>
> On Tue, Jul 12, 2016 at 10:40 AM, John D. Ament 
> wrote:
>
> > Geode Podling,
> >
> > Your report is missing sign off from your mentors.  Please try to get it
> > ASAP.
> >
> > John
> >
>


[GitHub] incubator-geode pull request #197: GEODE-1571: Added no argument Constructor...

2016-07-12 Thread gracemeilen
Github user gracemeilen closed the pull request at:

https://github.com/apache/incubator-geode/pull/197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request #197: GEODE-1571: Added no argument Constructor...

2016-07-12 Thread gracemeilen
GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/197

GEODE-1571: Added no argument Constructor to SampleSecurityManager



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1571

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #197


commit ea48bd660a9eeb5bf48659b017a972bcb169d5df
Author: Darrel Schneider 
Date:   2016-07-07T23:58:23Z

GEODE-1302: remove unused RunCacheInOldGemfire

commit 8148c891b6f395e18fdb4dc6797ae3fdcc00fa5f
Author: Jinmei Liao 
Date:   2016-07-08T15:49:37Z

GEODE-1571: fix precheckin failures

commit f8b620c6343f429ff35e7d209683a68e3de76a7c
Author: Jinmei Liao 
Date:   2016-07-08T15:50:39Z

Merge branch 'develop' into feature/GEODE-1571

commit 7965bd758bc67022d933215984d46bf1aafefaba
Author: Jinmei Liao 
Date:   2016-07-08T17:38:44Z

GEODE-1571: fix messing test category and ignore the unsupported api tests.

* tests are ignored because server would treat them as internal message and 
won't bind the correct message to it.

commit dfd481e0bcb6cdc42f16461c2444c04718424629
Author: Kirk Lund 
Date:   2016-07-08T18:08:40Z

GEODE-1566: rename GeodeRedisServer and repackage redis code into 
org.apache.geode

This closes #182

commit 617d31327abaa85150b7a6795ee04d1dfd542ce1
Author: gmeilen 
Date:   2016-07-08T18:36:50Z

GEODE-1571: Write DUnit test for SecurityManager init() and close()

This closes #192

commit bd75c732aa21d4d92e78d5cd960a507039d0fd40
Author: William Markito 
Date:   2016-06-09T03:30:32Z

[GEODE-33] - Adding geode-example module
Creating a simple example for replicated regions to test the proposed 
example model
Adding script tests
Adding server folders to gitignore
Adding gitignore and readme files

commit d3d8543110ae772d76c114d2d8d52d53355e4e07
Author: Karen Miller 
Date:   2016-06-15T18:07:03Z

Merge #158 into feature/GEODE-33
GEODE-1530: geode-examples setEnv.sh script needs to export path

Without an export of the path, using the GEODE_HOME env variable,
the scripts/startAll.sh script will pick up the first gfsh in the
path that it finds.

Also updated the scripts/stopAll.sh script to run the setEnv.sh
script, so that stopAll.sh uses the correct gfsh.

commit b7c5965043ad187aa31f2ed963fb56b4c62a5df9
Author: Karen Miller 
Date:   2016-06-15T21:34:37Z

GEODE-1531: Improve README.md for replicated example

- Improved the appearance of the markdown

- Added commands for how to kill a single server

- Added last step to run scripts/stopAll.sh so the system is
  shut down when the example ends, not leaving a locator and
  a server running

- Improved the prose describing what the example does

commit fb75348a3ded7fddb45424956cd946cf13b5a20b
Author: Karen Miller 
Date:   2016-06-15T22:30:03Z

GEODE-1525: Examples README.md should set env variable
GEODE-1523: Improve examples README.md markdown

This PR fixes addresses both GEODE-1525 and GEODE-1523, as they
both change the contents of the same file: geode-examples/README.md.

- Each example will likely use a scripts/setEnv.sh script to set
  the path to gfsh. The script depends on a GEODE_HOME environment
  variable, so this top level of instructions for setting up
  the examples now tells the user to set a GEODE_HOME env variable
  directly after the installation.

- Implement a more strict markdown that displays correctly for a
  wide variety of markdown implementations.

- Put in links for the 3 references.

- Improve the prose.

commit ab4bdd9fa8561da95858d6e74bb885273468907d
Author: William Markito 
Date:   2016-06-21T07:00:41Z

[GEODE-33] Fixed hardcoded path for resources on tests
- Included rat exclusion rules

commit c76554ca9bf3570ea4437b26fdb59e0d74dd3d3d
Author: William Markito 
Date:   2016-06-21T18:43:50Z

GEODE-33 - Adding link to replicated examples

commit 859dc76ac81dd563262f38918c33f465378cdc7e
Author: William Markito 
Date:   2016-06-21T18:47:19Z

GEODE-33 - Removing quote from folder name

commit 3eaa1cdfc12491bfafd7be39b2cacc175363cf6b
Author: Karen Miller 
Date:   2016-06-24T16:27:51Z

GEODE-33: clarify GEODE_HOME value

Clarify prose that identifies value to set for GEODE_HOME,
based on dev feedback.

commit a4010b2043ee708b8c85c987d21169da69af6df6
Author: William Markito 
Date:   2016-07-07T21:07:24Z

GEODE-33 - Applying PR feedback items
* Minor fixes (adding mavenLocal to list of repositories, fixed dependency 
versions and use of gradle.properties).
* Locator 

Re: Missing Sign Off on Board Report

2016-07-12 Thread Kirk Lund
Please let us know if we skipped anything on our end for getting this
reported completed.

Thank you,
Kirk


On Tue, Jul 12, 2016 at 10:40 AM, John D. Ament 
wrote:

> Geode Podling,
>
> Your report is missing sign off from your mentors.  Please try to get it
> ASAP.
>
> John
>


Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-07-12 Thread Hitesh Khamesra


> On July 12, 2016, 5:28 p.m., Bruce Schuchardt wrote:
> > I think you've chosen the correct bits to serialize but we don't need extra 
> > instance variables and flags to do this.  Get rid of 
> > InternalDistributedMember.shallowNetMember and the new bit flag in 
> > GMSMember and just add specific serialization methods to GMSMember that 
> > avoid writing non-essential information.  For example,
> > 
> > JGroupsMessenger.createJGMessage:
> >   ((GMSMember)localAddress.getNetMember()).writeShallow(out);
> >   
> > GMSMember.writeShallow:
> > Version.writeOrdinal(out, this.versionOrdinal, true);
> > 
> > int flags = 0;
> > if (networkPartitionDetectionEnabled) flags |= NPD_ENABLED_BIT;
> > if (preferredForCoordinator) flags |= PREFERRED_FOR_COORD_BIT;
> > out.writeShort(flags);
> > DataSerializer.writeInetAddress(inetAddr, out);
> > out.writeInt(udpPort);
> > out.writeInt(vmViewId);
> > out.writeLong(uuidMSBs);
> > out.writeLong(uuidLSBs);
> > 
> > JGroupsMessenger.readJGMessage can do something similar
> > GMSMember m = GMSMember.readShallow(dis);

We can do by adding this two methods. But don't we think this will add 
serialization/de code in two methods(kind of duplicate)


- Hitesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49962/#review141922
---


On July 12, 2016, 4:52 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49962/
> ---
> 
> (Updated July 12, 2016, 4:52 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removed extra fields from distributedmember while serialization/de. Planning 
> to do this in udp-security branch.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java
>  067b71b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java
>  d5d0b8e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
>  5c0a327 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java
>  7eef594 
> 
> Diff: https://reviews.apache.org/r/49962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>



Missing Sign Off on Board Report

2016-07-12 Thread John D. Ament
Geode Podling,

Your report is missing sign off from your mentors.  Please try to get it
ASAP.

John


Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread Dan Smith
Ok, I think you should be able to add a page
https://cwiki.apache.org/confluence/display/GEODE/Index now.

Thanks!
-Dan

On Tue, Jul 12, 2016 at 10:30 AM, yang theseus 
wrote:

> Great, Dan!
> On apache wiki, My name is theseusyang , or email is theseusy...@gmail.com
>
> 2016-07-13 1:28 GMT+08:00 yang theseus :
>
> > xiaojian, Can you open a writing permission for me?
> >
> > thank you
> >
> > 2016-07-13 1:18 GMT+08:00 yang theseus :
> >
> >> Indeed, I have no the permits to add contents on wiki page.
> >>
> >> 2016-07-13 0:45 GMT+08:00 theseusyang :
> >>
> >>> Ok, thanks xiaojian.
> >>>
> >>> 2016-07-13 0:42 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
> >>> Developers Forum] :
> >>>
> >>> > You can add a wiki page for geode with chinese characters. I just did
> >>> some
> >>> > test.
> >>> >
> >>> >
> >>> >
> >>>
> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
> >>> >
> >>> > I added some chinese characters into above document.
> >>> >
> >>> > On Tue, Jul 12, 2016 at 9:33 AM, theseusyang <[hidden email]
> >>> > > wrote:
> >>> >
> >>> > > Yeah, xiaojian.
> >>> > >
> >>> > >
> >>> > >
> >>> > > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode
> >>> (Incubating)
> >>> > > Developers Forum] <[hidden email]
> >>> > >:
> >>>
> >>> > >
> >>> > > > Do you mean to publish into geode wiki or check into geode source
> >>> > code?
> >>> > > >
> >>> > > > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> >>> > > > > wrote:
> >>> > > >
> >>> > > > > Do you mean chinese file name or content in a PDF or text file?
> >>> > > > >
> >>> > > > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> >>> > > > >
> >>> > > > > wrote:
> >>> > > > >
> >>> > > > >> Hi All,
> >>> > > > >>
> >>> > > > >> I have translated some chinese documents about geode
> >>> installation,
> >>> > > > >> deployment,features.
> >>> > > > >> Now the main question is that How to put the chinese documents
> >>> to
> >>> > > > apache
> >>> > > > >> geode site?
> >>> > > > >>
> >>> > > > >> Does anybody know that?
> >>> > > > >>
> >>> > > > >> Thank you very much!
> >>> > > > >>
> >>> > > > >> theseus yang
> >>> > > > >>
> >>> > > > >>
> >>> > > > >>
> >>> > > > >> --
> >>> > > > >> View this message in context:
> >>> > > > >>
> >>> > > >
> >>> > >
> >>> >
> >>>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> >>> > > > >> Sent from the Apache Geode (Incubating) Developers Forum
> mailing
> >>> > list
> >>> > > > >> archive at Nabble.com.
> >>> > > > >>
> >>> > > > >
> >>> > > > >
> >>> > > >
> >>> > > >
> >>> > > > --
> >>> > > > If you reply to this email, your message will be added to the
> >>> > discussion
> >>> > > > below:
> >>> > > >
> >>> > > >
> >>> > >
> >>> >
> >>>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> >>> > > > To unsubscribe from How to commit the chinese documents to apache
> >>> > geode
> >>> > > > site?, click here
> >>> > > > <
> >>> > > >
> >>> > > > .
> >>> > > > NAML
> >>> > > > <
> >>> > >
> >>> >
> >>>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> >>> > > >
> >>> > > >
> >>> > >
> >>> > >
> >>> > >
> >>> > >
> >>> > > --
> >>> > > View this message in context:
> >>> > >
> >>> >
> >>>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
> >>> > > Sent from the Apache Geode (Incubating) Developers Forum mailing
> list
> >>> > > archive at Nabble.com.
> >>> > >
> >>> >
> >>> >
> >>> > --
> >>> > If you reply to this email, your message will be added to the
> >>> discussion
> >>> > below:
> >>> >
> >>> >
> >>>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7137.html
> >>> > To unsubscribe from How to commit the chinese documents to apache
> geode
> >>> > site?, click here
> >>> > <
> >>>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
> >>> >
> >>> > .
>

Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread yang theseus
Great, Dan!
On apache wiki, My name is theseusyang , or email is theseusy...@gmail.com

2016-07-13 1:28 GMT+08:00 yang theseus :

> xiaojian, Can you open a writing permission for me?
>
> thank you
>
> 2016-07-13 1:18 GMT+08:00 yang theseus :
>
>> Indeed, I have no the permits to add contents on wiki page.
>>
>> 2016-07-13 0:45 GMT+08:00 theseusyang :
>>
>>> Ok, thanks xiaojian.
>>>
>>> 2016-07-13 0:42 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
>>> Developers Forum] :
>>>
>>> > You can add a wiki page for geode with chinese characters. I just did
>>> some
>>> > test.
>>> >
>>> >
>>> >
>>> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
>>> >
>>> > I added some chinese characters into above document.
>>> >
>>> > On Tue, Jul 12, 2016 at 9:33 AM, theseusyang <[hidden email]
>>> > > wrote:
>>> >
>>> > > Yeah, xiaojian.
>>> > >
>>> > >
>>> > >
>>> > > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode
>>> (Incubating)
>>> > > Developers Forum] <[hidden email]
>>> > >:
>>>
>>> > >
>>> > > > Do you mean to publish into geode wiki or check into geode source
>>> > code?
>>> > > >
>>> > > > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
>>> > > > > wrote:
>>> > > >
>>> > > > > Do you mean chinese file name or content in a PDF or text file?
>>> > > > >
>>> > > > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
>>> > > > >
>>> > > > > wrote:
>>> > > > >
>>> > > > >> Hi All,
>>> > > > >>
>>> > > > >> I have translated some chinese documents about geode
>>> installation,
>>> > > > >> deployment,features.
>>> > > > >> Now the main question is that How to put the chinese documents
>>> to
>>> > > > apache
>>> > > > >> geode site?
>>> > > > >>
>>> > > > >> Does anybody know that?
>>> > > > >>
>>> > > > >> Thank you very much!
>>> > > > >>
>>> > > > >> theseus yang
>>> > > > >>
>>> > > > >>
>>> > > > >>
>>> > > > >> --
>>> > > > >> View this message in context:
>>> > > > >>
>>> > > >
>>> > >
>>> >
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
>>> > > > >> Sent from the Apache Geode (Incubating) Developers Forum mailing
>>> > list
>>> > > > >> archive at Nabble.com.
>>> > > > >>
>>> > > > >
>>> > > > >
>>> > > >
>>> > > >
>>> > > > --
>>> > > > If you reply to this email, your message will be added to the
>>> > discussion
>>> > > > below:
>>> > > >
>>> > > >
>>> > >
>>> >
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
>>> > > > To unsubscribe from How to commit the chinese documents to apache
>>> > geode
>>> > > > site?, click here
>>> > > > <
>>> > > >
>>> > > > .
>>> > > > NAML
>>> > > > <
>>> > >
>>> >
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
>>> > > >
>>> > > >
>>> > >
>>> > >
>>> > >
>>> > >
>>> > > --
>>> > > View this message in context:
>>> > >
>>> >
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
>>> > > Sent from the Apache Geode (Incubating) Developers Forum mailing list
>>> > > archive at Nabble.com.
>>> > >
>>> >
>>> >
>>> > --
>>> > If you reply to this email, your message will be added to the
>>> discussion
>>> > below:
>>> >
>>> >
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7137.html
>>> > To unsubscribe from How to commit the chinese documents to apache geode
>>> > site?, click here
>>> > <
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
>>> >
>>> > .
>>> > NAML
>>> > <
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-07-12 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49962/#review141922
---



I think you've chosen the correct bits to serialize but we don't need extra 
instance variables and flags to do this.  Get rid of 
InternalDistributedMember.shallowNetMember and the new bit flag in GMSMember 
and just add specific serialization methods to GMSMember that avoid writing 
non-essential information.  For example,

JGroupsMessenger.createJGMessage:
  ((GMSMember)localAddress.getNetMember()).writeShallow(out);
  
GMSMember.writeShallow:
Version.writeOrdinal(out, this.versionOrdinal, true);

int flags = 0;
if (networkPartitionDetectionEnabled) flags |= NPD_ENABLED_BIT;
if (preferredForCoordinator) flags |= PREFERRED_FOR_COORD_BIT;
out.writeShort(flags);
DataSerializer.writeInetAddress(inetAddr, out);
out.writeInt(udpPort);
out.writeInt(vmViewId);
out.writeLong(uuidMSBs);
out.writeLong(uuidLSBs);

JGroupsMessenger.readJGMessage can do something similar
GMSMember m = GMSMember.readShallow(dis);

- Bruce Schuchardt


On July 12, 2016, 4:52 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49962/
> ---
> 
> (Updated July 12, 2016, 4:52 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removed extra fields from distributedmember while serialization/de. Planning 
> to do this in udp-security branch.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java
>  067b71b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java
>  d5d0b8e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
>  5c0a327 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java
>  7eef594 
> 
> Diff: https://reviews.apache.org/r/49962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>



Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread yang theseus
xiaojian, Can you open a writing permission for me?

thank you

2016-07-13 1:18 GMT+08:00 yang theseus :

> Indeed, I have no the permits to add contents on wiki page.
>
> 2016-07-13 0:45 GMT+08:00 theseusyang :
>
>> Ok, thanks xiaojian.
>>
>> 2016-07-13 0:42 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
>> Developers Forum] :
>>
>> > You can add a wiki page for geode with chinese characters. I just did
>> some
>> > test.
>> >
>> >
>> >
>> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
>> >
>> > I added some chinese characters into above document.
>> >
>> > On Tue, Jul 12, 2016 at 9:33 AM, theseusyang <[hidden email]
>> > > wrote:
>> >
>> > > Yeah, xiaojian.
>> > >
>> > >
>> > >
>> > > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode
>> (Incubating)
>> > > Developers Forum] <[hidden email]
>> > >:
>>
>> > >
>> > > > Do you mean to publish into geode wiki or check into geode source
>> > code?
>> > > >
>> > > > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
>> > > > > wrote:
>> > > >
>> > > > > Do you mean chinese file name or content in a PDF or text file?
>> > > > >
>> > > > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
>> > > > >
>> > > > > wrote:
>> > > > >
>> > > > >> Hi All,
>> > > > >>
>> > > > >> I have translated some chinese documents about geode
>> installation,
>> > > > >> deployment,features.
>> > > > >> Now the main question is that How to put the chinese documents to
>> > > > apache
>> > > > >> geode site?
>> > > > >>
>> > > > >> Does anybody know that?
>> > > > >>
>> > > > >> Thank you very much!
>> > > > >>
>> > > > >> theseus yang
>> > > > >>
>> > > > >>
>> > > > >>
>> > > > >> --
>> > > > >> View this message in context:
>> > > > >>
>> > > >
>> > >
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
>> > > > >> Sent from the Apache Geode (Incubating) Developers Forum mailing
>> > list
>> > > > >> archive at Nabble.com.
>> > > > >>
>> > > > >
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > > If you reply to this email, your message will be added to the
>> > discussion
>> > > > below:
>> > > >
>> > > >
>> > >
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
>> > > > To unsubscribe from How to commit the chinese documents to apache
>> > geode
>> > > > site?, click here
>> > > > <
>> > > >
>> > > > .
>> > > > NAML
>> > > > <
>> > >
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
>> > > >
>> > > >
>> > >
>> > >
>> > >
>> > >
>> > > --
>> > > View this message in context:
>> > >
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
>> > > Sent from the Apache Geode (Incubating) Developers Forum mailing list
>> > > archive at Nabble.com.
>> > >
>> >
>> >
>> > --
>> > If you reply to this email, your message will be added to the discussion
>> > below:
>> >
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7137.html
>> > To unsubscribe from How to commit the chinese documents to apache geode
>> > site?, click here
>> > <
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
>> >
>> > .
>> > NAML
>> > <
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
>> >
>> >
>>
>>
>>
>>
>> --
>> View this message in context:
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7139.html
>> Sent from the Apache Geode (I

Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread Dan Smith
Hi Theseus,

What's your username on the apache wiki? If you don't have an account, you
can create one. If you send me your username I think I can grant you write
access to the geode wiki.

If you think the translations belong on http://geode.incubator.apache.org/
rather than the wiki (https://cwiki.apache.org/confluence/display/GEODE/)
we can figure that out too - it will involves filing pull requests for
content geode-site/website. The wiki is probably the easier place to start
with though.

-Dan

On Tue, Jul 12, 2016 at 10:18 AM, yang theseus 
wrote:

> Indeed, I have no the permits to add contents on wiki page.
>
> 2016-07-13 0:45 GMT+08:00 theseusyang :
>
> > Ok, thanks xiaojian.
> >
> > 2016-07-13 0:42 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
> > Developers Forum] :
> >
> > > You can add a wiki page for geode with chinese characters. I just did
> > some
> > > test.
> > >
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
> > >
> > > I added some chinese characters into above document.
> > >
> > > On Tue, Jul 12, 2016 at 9:33 AM, theseusyang <[hidden email]
> > > > wrote:
> > >
> > > > Yeah, xiaojian.
> > > >
> > > >
> > > >
> > > > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode
> (Incubating)
> > > > Developers Forum] <[hidden email]
> > > >:
> > > >
> > > > > Do you mean to publish into geode wiki or check into geode source
> > > code?
> > > > >
> > > > > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> > > > > > wrote:
> > > > >
> > > > > > Do you mean chinese file name or content in a PDF or text file?
> > > > > >
> > > > > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Hi All,
> > > > > >>
> > > > > >> I have translated some chinese documents about geode
> installation,
> > > > > >> deployment,features.
> > > > > >> Now the main question is that How to put the chinese documents
> to
> > > > > apache
> > > > > >> geode site?
> > > > > >>
> > > > > >> Does anybody know that?
> > > > > >>
> > > > > >> Thank you very much!
> > > > > >>
> > > > > >> theseus yang
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> --
> > > > > >> View this message in context:
> > > > > >>
> > > > >
> > > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> > > > > >> Sent from the Apache Geode (Incubating) Developers Forum mailing
> > > list
> > > > > >> archive at Nabble.com.
> > > > > >>
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > If you reply to this email, your message will be added to the
> > > discussion
> > > > > below:
> > > > >
> > > > >
> > > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> > > > > To unsubscribe from How to commit the chinese documents to apache
> > > geode
> > > > > site?, click here
> > > > > <
> > > > >
> > > > > .
> > > > > NAML
> > > > > <
> > > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > View this message in context:
> > > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
> > > > Sent from the Apache Geode (Incubating) Developers Forum mailing list
> > > > archive at Nabble.com.
> > > >
> > >
> > >
> > > --
> > > If you reply to this email, your message will be added to the
> discussion
> > > below:
> > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7137.html
> > > To unsubscribe from How to commit the chinese documents to apache geode
> > > site?, click here
> > > <
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
> > >
> > > .
> > > NAML
> > > <
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21n

Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread yang theseus
Indeed, I have no the permits to add contents on wiki page.

2016-07-13 0:45 GMT+08:00 theseusyang :

> Ok, thanks xiaojian.
>
> 2016-07-13 0:42 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
> Developers Forum] :
>
> > You can add a wiki page for geode with chinese characters. I just did
> some
> > test.
> >
> >
> >
> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
> >
> > I added some chinese characters into above document.
> >
> > On Tue, Jul 12, 2016 at 9:33 AM, theseusyang <[hidden email]
> > > wrote:
> >
> > > Yeah, xiaojian.
> > >
> > >
> > >
> > > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
> > > Developers Forum] <[hidden email]
> > >:
> > >
> > > > Do you mean to publish into geode wiki or check into geode source
> > code?
> > > >
> > > > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> > > > > wrote:
> > > >
> > > > > Do you mean chinese file name or content in a PDF or text file?
> > > > >
> > > > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> > > > >
> > > > > wrote:
> > > > >
> > > > >> Hi All,
> > > > >>
> > > > >> I have translated some chinese documents about geode installation,
> > > > >> deployment,features.
> > > > >> Now the main question is that How to put the chinese documents to
> > > > apache
> > > > >> geode site?
> > > > >>
> > > > >> Does anybody know that?
> > > > >>
> > > > >> Thank you very much!
> > > > >>
> > > > >> theseus yang
> > > > >>
> > > > >>
> > > > >>
> > > > >> --
> > > > >> View this message in context:
> > > > >>
> > > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> > > > >> Sent from the Apache Geode (Incubating) Developers Forum mailing
> > list
> > > > >> archive at Nabble.com.
> > > > >>
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > If you reply to this email, your message will be added to the
> > discussion
> > > > below:
> > > >
> > > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> > > > To unsubscribe from How to commit the chinese documents to apache
> > geode
> > > > site?, click here
> > > > <
> > > >
> > > > .
> > > > NAML
> > > > <
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> > > >
> > > >
> > >
> > >
> > >
> > >
> > > --
> > > View this message in context:
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
> > > Sent from the Apache Geode (Incubating) Developers Forum mailing list
> > > archive at Nabble.com.
> > >
> >
> >
> > --
> > If you reply to this email, your message will be added to the discussion
> > below:
> >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7137.html
> > To unsubscribe from How to commit the chinese documents to apache geode
> > site?, click here
> > <
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
> >
> > .
> > NAML
> > <
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> >
> >
>
>
>
>
> --
> View this message in context:
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7139.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>


Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread theseusyang
Ok, thanks xiaojian.

2016-07-13 0:42 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
Developers Forum] :

> You can add a wiki page for geode with chinese characters. I just did some
> test.
>
>
> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
>
> I added some chinese characters into above document.
>
> On Tue, Jul 12, 2016 at 9:33 AM, theseusyang <[hidden email]
> > wrote:
>
> > Yeah, xiaojian.
> >
> >
> >
> > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
> > Developers Forum] <[hidden email]
> >:
> >
> > > Do you mean to publish into geode wiki or check into geode source
> code?
> > >
> > > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> > > > wrote:
> > >
> > > > Do you mean chinese file name or content in a PDF or text file?
> > > >
> > > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > >> Hi All,
> > > >>
> > > >> I have translated some chinese documents about geode installation,
> > > >> deployment,features.
> > > >> Now the main question is that How to put the chinese documents to
> > > apache
> > > >> geode site?
> > > >>
> > > >> Does anybody know that?
> > > >>
> > > >> Thank you very much!
> > > >>
> > > >> theseus yang
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> View this message in context:
> > > >>
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> > > >> Sent from the Apache Geode (Incubating) Developers Forum mailing
> list
> > > >> archive at Nabble.com.
> > > >>
> > > >
> > > >
> > >
> > >
> > > --
> > > If you reply to this email, your message will be added to the
> discussion
> > > below:
> > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> > > To unsubscribe from How to commit the chinese documents to apache
> geode
> > > site?, click here
> > > <
> > >
> > > .
> > > NAML
> > > <
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> > >
> > >
> >
> >
> >
> >
> > --
> > View this message in context:
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
> > Sent from the Apache Geode (Incubating) Developers Forum mailing list
> > archive at Nabble.com.
> >
>
>
> --
> If you reply to this email, your message will be added to the discussion
> below:
>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7137.html
> To unsubscribe from How to commit the chinese documents to apache geode
> site?, click here
> 
> .
> NAML
> 
>




--
View this message in context: 
http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7139.html
Sent from the Apache Geode (Incubating) Developers Forum mailing list archive 
at Nabble.com.

Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread Xiaojian Zhou
If you don't have authority to add the page into geode's wiki, you can send
it to me.

On Tue, Jul 12, 2016 at 9:58 AM, Xiaojian Zhou  wrote:

> You can add a wiki page for geode with chinese characters. I just did some
> test.
>
>
> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
>
> I added some chinese characters into above document.
>
> On Tue, Jul 12, 2016 at 9:33 AM, theseusyang 
> wrote:
>
>> Yeah, xiaojian.
>>
>>
>>
>> 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
>> Developers Forum] :
>>
>> > Do you mean to publish into geode wiki or check into geode source code?
>> >
>> > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
>> > > wrote:
>> >
>> > > Do you mean chinese file name or content in a PDF or text file?
>> > >
>> > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
>> > >
>> > > wrote:
>> > >
>> > >> Hi All,
>> > >>
>> > >> I have translated some chinese documents about geode installation,
>> > >> deployment,features.
>> > >> Now the main question is that How to put the chinese documents to
>> > apache
>> > >> geode site?
>> > >>
>> > >> Does anybody know that?
>> > >>
>> > >> Thank you very much!
>> > >>
>> > >> theseus yang
>> > >>
>> > >>
>> > >>
>> > >> --
>> > >> View this message in context:
>> > >>
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
>> > >> Sent from the Apache Geode (Incubating) Developers Forum mailing list
>> > >> archive at Nabble.com.
>> > >>
>> > >
>> > >
>> >
>> >
>> > --
>> > If you reply to this email, your message will be added to the discussion
>> > below:
>> >
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
>> > To unsubscribe from How to commit the chinese documents to apache geode
>> > site?, click here
>> > <
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
>> >
>> > .
>> > NAML
>> > <
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
>> >
>> >
>>
>>
>>
>>
>> --
>> View this message in context:
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
>> Sent from the Apache Geode (Incubating) Developers Forum mailing list
>> archive at Nabble.com.
>>
>
>


Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread Xiaojian Zhou
You can add a wiki page for geode with chinese characters. I just did some
test.

https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter

I added some chinese characters into above document.

On Tue, Jul 12, 2016 at 9:33 AM, theseusyang  wrote:

> Yeah, xiaojian.
>
>
>
> 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
> Developers Forum] :
>
> > Do you mean to publish into geode wiki or check into geode source code?
> >
> > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> > > wrote:
> >
> > > Do you mean chinese file name or content in a PDF or text file?
> > >
> > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> > >
> > > wrote:
> > >
> > >> Hi All,
> > >>
> > >> I have translated some chinese documents about geode installation,
> > >> deployment,features.
> > >> Now the main question is that How to put the chinese documents to
> > apache
> > >> geode site?
> > >>
> > >> Does anybody know that?
> > >>
> > >> Thank you very much!
> > >>
> > >> theseus yang
> > >>
> > >>
> > >>
> > >> --
> > >> View this message in context:
> > >>
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> > >> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> > >> archive at Nabble.com.
> > >>
> > >
> > >
> >
> >
> > --
> > If you reply to this email, your message will be added to the discussion
> > below:
> >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> > To unsubscribe from How to commit the chinese documents to apache geode
> > site?, click here
> > <
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
> >
> > .
> > NAML
> > <
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> >
> >
>
>
>
>
> --
> View this message in context:
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>


[GitHub] incubator-geode issue #193: GEODE-1646: repackage new Security classes in or...

2016-07-12 Thread kirklund
Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/193
  
AnalyzeSerializablesJUnitTest.testSerializables fails but it's easy to fix. 
I'll include a change to the expected serializables so it passes with this 
change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-07-12 Thread Hitesh Khamesra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49962/
---

Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.


Repository: geode


Description
---

Removed extra fields from distributedmember while serialization/de. Planning to 
do this in udp-security branch.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java
 067b71b 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java
 d5d0b8e 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
 5c0a327 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java
 7eef594 

Diff: https://reviews.apache.org/r/49962/diff/


Testing
---


Thanks,

Hitesh Khamesra



[GitHub] incubator-geode pull request #195: GEODE-1598: fix auto-completion problems

2016-07-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/195


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread theseusyang
Yeah, xiaojian.



2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
Developers Forum] :

> Do you mean to publish into geode wiki or check into geode source code?
>
> On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> > wrote:
>
> > Do you mean chinese file name or content in a PDF or text file?
> >
> > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> >
> > wrote:
> >
> >> Hi All,
> >>
> >> I have translated some chinese documents about geode installation,
> >> deployment,features.
> >> Now the main question is that How to put the chinese documents to
> apache
> >> geode site?
> >>
> >> Does anybody know that?
> >>
> >> Thank you very much!
> >>
> >> theseus yang
> >>
> >>
> >>
> >> --
> >> View this message in context:
> >>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> >> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> >> archive at Nabble.com.
> >>
> >
> >
>
>
> --
> If you reply to this email, your message will be added to the discussion
> below:
>
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> To unsubscribe from How to commit the chinese documents to apache geode
> site?, click here
> 
> .
> NAML
> 
>




--
View this message in context: 
http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
Sent from the Apache Geode (Incubating) Developers Forum mailing list archive 
at Nabble.com.

[GitHub] incubator-geode issue #196: GEODE-1617: Regions can be created with a variet...

2016-07-12 Thread kjduling
Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/196
  
Ok, good.  The errors are "correct" because regions are being created with 
invalid names.  I'll update the tests and determine which are internal regions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #195: GEODE-1598: fix auto-completion problems

2016-07-12 Thread kirklund
Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/195
  
JoptOptionParserTest.parseInputWithUndefinedOptionShouldThrow fails with 
this change but I have a fix for it and will commit it with this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #196: GEODE-1617: Regions can be created with a variet...

2016-07-12 Thread kirklund
Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/196
  
Precheckin has lots of failures including in pivotal smoketests:


https://jenkins.eng.pivotal.io/jenkins/job/GEM-patch-build-closed/342/#showFailuresLink


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Review Request 49959: GEODE-1571: fix nightly failure

2016-07-12 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49959/
---

Review request for geode, Grace Meilen, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-1571: fix nightly failure


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
 9a3be0491eb80d3b34b53a7f9f4cf1645cbce65d 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java
 48f6a40ac94da03ffc5c9eba691f8abbb563f557 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java
 6a3d38251ed588d63e8ee637c9198a11ca1d90c6 
  geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Server.java 
429a11b63eecde16bcd52cc35a8b59a36b780a03 

Diff: https://reviews.apache.org/r/49959/diff/


Testing
---


Thanks,

Jinmei Liao



Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread Xiaojian Zhou
Do you mean chinese file name or content in a PDF or text file?

On Tue, Jul 12, 2016 at 3:28 AM, theseusyang  wrote:

> Hi All,
>
> I have translated some chinese documents about geode installation,
> deployment,features.
> Now the main question is that How to put the chinese documents to apache
> geode site?
>
> Does anybody know that?
>
> Thank you very much!
>
> theseus yang
>
>
>
> --
> View this message in context:
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>


Re: How to commit the chinese documents to apache geode site?

2016-07-12 Thread Xiaojian Zhou
Do you mean to publish into geode wiki or check into geode source code?

On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou  wrote:

> Do you mean chinese file name or content in a PDF or text file?
>
> On Tue, Jul 12, 2016 at 3:28 AM, theseusyang 
> wrote:
>
>> Hi All,
>>
>> I have translated some chinese documents about geode installation,
>> deployment,features.
>> Now the main question is that How to put the chinese documents to apache
>> geode site?
>>
>> Does anybody know that?
>>
>> Thank you very much!
>>
>> theseus yang
>>
>>
>>
>> --
>> View this message in context:
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
>> Sent from the Apache Geode (Incubating) Developers Forum mailing list
>> archive at Nabble.com.
>>
>
>


Build failed in Jenkins: Geode-nightly #527

2016-07-12 Thread Apache Jenkins Server
See 

Changes:

[jiliao] GEODE-1571: security code tidy up.

[huynhja] GEODE-1588: AckReader and Dispatching thread are shut down before

[klund] GEODE-1452: annotate disabled tests with @Ignore and rename

[gzhou] GEODE-11: GFSH commands for Lucene

[jiliao] GEODE-1571: documentation and code cleanup

[sbawaskar] fixing the version from 1.0.0-incubating.1.0.0-SNAPSHOT to

--
[...truncated 621 lines...]
at 
com.gemstone.gemfire.security.IntegratedSecurityCacheLifecycleDistributedTest.verifyInitCloseInvoked(IntegratedSecurityCacheLifecycleDistributedTest.java:104)
at 
com.gemstone.gemfire.security.IntegratedSecurityCacheLifecycleDistributedTest.initAndCloseTest(IntegratedSecurityCacheLifecycleDistributedTest.java:89)

7408 tests completed, 1 failed, 587 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest

com.gemstone.gemfire.security.IntegratedSecurityCacheLifecycleIntegrationTest > 
initAndCloseTest FAILED
org.junit.ComparisonFailure: expected:<[1]> but was:<[0]>
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
com.gemstone.gemfire.security.IntegratedSecurityCacheLifecycleIntegrationTest.initAndCloseTest(IntegratedSecurityCacheLifecycleIntegrationTest.java:71)

3214 tests completed, 1 failed, 175 skipped
:geode-core:integrationTest FAILED
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava:31:
 warning: RE is internal proprietary API and may be removed in a future release
import com.sun.org.apache.regexp.internal.RE;
 ^
:31:
 warning: RE is internal proprietary API and may be removed in a future release
import com.sun.org.apache.regexp.internal.RE;
 ^
:31:
 warning: RE is internal proprietary API and may be removed in a future release
import com.sun.org.apache.regexp.internal.RE;
 ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 warnings

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pul

How to commit the chinese documents to apache geode site?

2016-07-12 Thread theseusyang
Hi All,

I have translated some chinese documents about geode installation,
deployment,features.
Now the main question is that How to put the chinese documents to apache
geode site?

Does anybody know that?

Thank you very much!

theseus yang



--
View this message in context: 
http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
Sent from the Apache Geode (Incubating) Developers Forum mailing list archive 
at Nabble.com.