> On July 12, 2016, 5:28 p.m., Bruce Schuchardt wrote: > > I think you've chosen the correct bits to serialize but we don't need extra > > instance variables and flags to do this. Get rid of > > InternalDistributedMember.shallowNetMember and the new bit flag in > > GMSMember and just add specific serialization methods to GMSMember that > > avoid writing non-essential information. For example, > > > > JGroupsMessenger.createJGMessage: > > ((GMSMember)localAddress.getNetMember()).writeShallow(out); > > > > GMSMember.writeShallow: > > Version.writeOrdinal(out, this.versionOrdinal, true); > > > > int flags = 0; > > if (networkPartitionDetectionEnabled) flags |= NPD_ENABLED_BIT; > > if (preferredForCoordinator) flags |= PREFERRED_FOR_COORD_BIT; > > out.writeShort(flags); > > DataSerializer.writeInetAddress(inetAddr, out); > > out.writeInt(udpPort); > > out.writeInt(vmViewId); > > out.writeLong(uuidMSBs); > > out.writeLong(uuidLSBs); > > > > JGroupsMessenger.readJGMessage can do something similar > > GMSMember m = GMSMember.readShallow(dis);
We can do by adding this two methods. But don't we think this will add serialization/de code in two methods(kind of duplicate) - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49962/#review141922 ----------------------------------------------------------- On July 12, 2016, 4:52 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49962/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 4:52 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Removed extra fields from distributedmember while serialization/de. Planning > to do this in udp-security branch. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java > 067b71b > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java > d5d0b8e > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java > 5c0a327 > > geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java > 7eef594 > > Diff: https://reviews.apache.org/r/49962/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
