Re: IntelliJ project dependencies

2016-08-16 Thread Nabarun Nag 
+1 Same issue as  Bruce's 1st email with IntelliJ 2016.2.1
Upgraded to 2016.2.2 - same issue again.

MacOS 10.11.6

The dependencies break down when a new IntelliJ major version is released.
GEODE-1194 fixed by Jens was  for  the dependency issue in IntelliJ
2016.1.1.





On Tue, Aug 16, 2016 at 3:53 PM Bruce Schuchardt 
wrote:

> I'm not sure what I had this morning but I'm now using 2016.2.2
> community edition with the same JDK you're using.  Maybe it's a problem
> unique to MS-Windows.
>
>
> Le 8/16/2016 à 3:43 PM, Kirk Lund a écrit :
> > The project I'm using was created/imported today. My modules view for
> > geode-core shows the tools.jar in the list of the Project Settings
> > | Modules | Dependencies for geode-core:
> >
> > geode-core_jca
> > geode-core_legacyDUnit
> > geode-core_main
> > geode-core_test
> >
> > Here's my IntelliJ version and info (on Mac) according to the About:
> >
> > IntelliJ IDEA 2016.1.2
> > Build #IC-145.971, built on April 29, 2016
> > JRE: 1.8.0_76-release-b162 x86_64
> > JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
> >
> > My Project Settings | Modules | Dependencies also shows that I'm using
> > "jdk1.8.0_66" -- I'm not sure why that's different from the info in the
> > About window.
> >
> > -Kirk
> >
> >
> > On Tue, Aug 16, 2016 at 3:28 PM, Bruce Schuchardt <
> bschucha...@pivotal.io>
> > wrote:
> >
> >> After pulling down the latest patches to IntelliJ this worked for me as
> >> well, though it still doesn't configure geode-core to require tools.jar.
> >> Thanks Kirk
> >>
> >>
> >> Le 8/16/2016 à 12:21 PM, Kirk Lund a écrit :
> >>
> >>> All I know of is upgrading Gradle version to 2.14.1 on Aug 2.
> >>>
> >>> I just built a new IntelliJ project for Geode myself without any
> problems.
> >>> I don't use the "gradle idea" target (is that what you're using?). That
> >>> produces a project that doesn't work for me. Instead I create a new
> >>> "Project from Existing Sources" like this:
> >>>
> >>> 1) File | New | "Project from Existing Sources..."
> >>> 2) select your Geode checkout and hit OK
> >>> 3) select "Import project from external model", select Gradle and hit
> Next
> >>>
> >>> -Kirk
> >>>
> >>>
> >>> On Tue, Aug 16, 2016 at 10:37 AM, Bruce Schuchardt <
> >>> bschucha...@pivotal.io>
> >>> wrote:
> >>>
> >>> Has something changed in project dependencies recently?
>  I rebuilt my IntelliJ project last Friday and found that there were
>  missing dependencies that broke my build.  The modules geode-web_test,
>  geode-cq_test, geode-lucene_test, etc, did not have a dependency on
>  geode-core_test.  That gave IntelliJ all sorts of grief until I
> manually
>  added them.
> 
> 
> 
>
>

[GitHub] incubator-geode issue #233: GEODE11: Fixing bugs in lucene gfsh commands

2016-08-16 Thread agingade 
Github user agingade commented on the issue:

https://github.com/apache/incubator-geode/pull/233
  
Looks good...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-16 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51010/#review145913
---


Ship it!




Looks good. I have some ideas on how we might be able to avoid having to call 
getLocatorVM, getNodeVM, etc. but I can always try to do that later. I'd say 
check it in!

- Dan Smith


On Aug. 12, 2016, 11:58 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51010/
> ---
> 
> (Updated Aug. 12, 2016, 11:58 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, Kirk 
> Lund, William Markito, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added test to validate Cluster configuration support for Lucene indexes.
> 
> Added a new Rule to create Distributed System with test/custom 
> configuration...The "LocatorServerConfigurationRule" makes it easier to 
> create a Locator or cluster nodes with required configuration.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51010/diff/
> 
> 
> Testing
> ---
> 
> Run the newly added test.
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Re: Review Request 51098: GEODE-1781: repackage internal statistics classes and refactor statistics tests

2016-08-16 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51098/#review145886
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java
 (line 29)


Change "Bridge" to "Cache"


- Darrel Schneider


On Aug. 15, 2016, 6:39 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51098/
> ---
> 
> (Updated Aug. 15, 2016, 6:39 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Kevin Duling, Lynn 
> Hughes-Godfrey, Lynn Gallinat, and Dan Smith.
> 
> 
> Bugs: GEODE-1781
> https://issues.apache.org/jira/browse/GEODE-1781
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1781: repackage internal statistics classes and refactor statistics 
> tests
> 
> * move internal statistics classes and tests into 
> com.gemstone.gemfire.internal.statistics pkg
> * modify tests to include integration and distributed in names
> * modify tests to use TemporaryFolder and TestName rules
> * remove unused classes and dead code from statistics tests
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionStatistics.java
>  2d59103 
>   
> extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/util/ModuleStatistics.java
>  82e882c 
>   geode-core/src/main/java/com/gemstone/gemfire/StatisticsFactory.java 
> 3ef5ba5 
>   geode-core/src/main/java/com/gemstone/gemfire/StatisticsTypeFactory.java 
> 9b6c546 
>   
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/MemberHealthEvaluator.java
>  d0710ca 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueStats.java
>  8d541a3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionStats.java
>  4bd4439 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java
>  d155602 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java
>  b26d76b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/CqQueryVsdStats.java
>  e9d30d5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexStats.java
>  77941b6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java
>  c4803ab 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  1ea5611 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java
>  f59ed84 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockStats.java
>  9a61c10 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractStatisticsFactory.java
>  972e670e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/ArchiveSplitter.java 
> 28b9dd7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsFactory.java
>  9d280eb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java
>  aa8da50 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireStatSampler.java
>  1eb35d0 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatHelper.java 
> 7ff0b1b 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ff9d2fb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcFsStatistics.java
>  3070287 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcessStats.java 
> 05bc284 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxSystemStats.java 
> 22158da 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatListener.java 
> c46bc2f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsFactory.java
>  6f8315a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsImpl.java
>  cf59e1f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/OSXProcessStats.java 
> 0706c7b 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/OSXSystemStats.java 
> 8d440ca 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/OsStatisticsFactory.java
>  7dac90e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/ProcessStats.java 
> c80e340 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SimpleStatSampler.java 
> b3cc56b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisProcessStats.java
>  d07d398 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisSystemStats.java
>  9f56943 
>   
>

Re: Review Request 51098: GEODE-1781: repackage internal statistics classes and refactor statistics tests

2016-08-16 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51098/#review145890
---


Ship it!




Ship It!

- Darrel Schneider


On Aug. 15, 2016, 6:39 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51098/
> ---
> 
> (Updated Aug. 15, 2016, 6:39 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Kevin Duling, Lynn 
> Hughes-Godfrey, Lynn Gallinat, and Dan Smith.
> 
> 
> Bugs: GEODE-1781
> https://issues.apache.org/jira/browse/GEODE-1781
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1781: repackage internal statistics classes and refactor statistics 
> tests
> 
> * move internal statistics classes and tests into 
> com.gemstone.gemfire.internal.statistics pkg
> * modify tests to include integration and distributed in names
> * modify tests to use TemporaryFolder and TestName rules
> * remove unused classes and dead code from statistics tests
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionStatistics.java
>  2d59103 
>   
> extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/util/ModuleStatistics.java
>  82e882c 
>   geode-core/src/main/java/com/gemstone/gemfire/StatisticsFactory.java 
> 3ef5ba5 
>   geode-core/src/main/java/com/gemstone/gemfire/StatisticsTypeFactory.java 
> 9b6c546 
>   
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/MemberHealthEvaluator.java
>  d0710ca 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueStats.java
>  8d541a3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionStats.java
>  4bd4439 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java
>  d155602 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java
>  b26d76b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/CqQueryVsdStats.java
>  e9d30d5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexStats.java
>  77941b6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java
>  c4803ab 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  1ea5611 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java
>  f59ed84 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockStats.java
>  9a61c10 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractStatisticsFactory.java
>  972e670e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/ArchiveSplitter.java 
> 28b9dd7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsFactory.java
>  9d280eb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java
>  aa8da50 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireStatSampler.java
>  1eb35d0 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatHelper.java 
> 7ff0b1b 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ff9d2fb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcFsStatistics.java
>  3070287 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcessStats.java 
> 05bc284 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxSystemStats.java 
> 22158da 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatListener.java 
> c46bc2f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsFactory.java
>  6f8315a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsImpl.java
>  cf59e1f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/OSXProcessStats.java 
> 0706c7b 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/OSXSystemStats.java 
> 8d440ca 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/OsStatisticsFactory.java
>  7dac90e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/ProcessStats.java 
> c80e340 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SimpleStatSampler.java 
> b3cc56b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisProcessStats.java
>  d07d398 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisSystemStats.java
>  9f56943 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveFormat.java 
> d1e67f9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveReader.java

IntelliJ project dependencies

2016-08-16 Thread Bruce Schuchardt 

Has something changed in project dependencies recently?

I rebuilt my IntelliJ project last Friday and found that there were 
missing dependencies that broke my build.  The modules geode-web_test, 
geode-cq_test, geode-lucene_test, etc, did not have a dependency on 
geode-core_test.  That gave IntelliJ all sorts of grief until I manually 
added them.

Re: Review Request 51125: GEODE-1782: stat resources with different time stamps should not be equal

2016-08-16 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51125/#review145879
---


Ship it!




Ship It!

- Darrel Schneider


On Aug. 15, 2016, 6:56 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51125/
> ---
> 
> (Updated Aug. 15, 2016, 6:56 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Darrel Schneider, Kevin Duling, Lynn 
> Hughes-Godfrey, Lynn Gallinat, and Dan Smith.
> 
> 
> Bugs: GEODE-1782
> https://issues.apache.org/jira/browse/GEODE-1782
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1782: stat resources with different time stamps should not be equal
> 
> * StatArchiveWithConsecutiveResourceInstGenerator generates gfs with multiple 
> stat resources of same name but different times
> * StatArchiveWithConsecutiveResourceInstIntegrationTest confirms existence of 
> bug GEODE-1782: StatArchiveReader ignores later stats reso
> urce with same name as closed stats resource
> * ResourceInstTest verifies the underlying issue in 
> StatArchiveReader.ResourceInst.equals and the fix
> 
> Note: this changeset builds upon the changeset for GEODE-1781 (same branch): 
> https://reviews.apache.org/r/51098
> 
> Explanation of new tests: I started out with a very large .gfs file and 
> reproduced the bug with 
> StatArchiveWithConsecutiveResourceInstIntegrationTest. Darrel helped identify 
> the underlying cause in StatArchiveReader.ResourceInst.equals. I then wrote 
> the unit test ResourceInstTest to reproduce the bug at the lowest level 
> possible and fix it. Next I created 
> StatArchiveWithConsecutiveResourceInstGenerator to generate a tiny .gfs file 
> for StatArchiveWithConsecutiveResourceInstIntegrationTest so that I could 
> check it in as well since it verifies the bug and the fix at a higher level.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveReader.java
>  12637bc 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/ResourceInstTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstGenerator.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstGeneratorTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatUtils.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstIntegrationTest.gfs
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51125/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 51098: GEODE-1781: repackage internal statistics classes and refactor statistics tests

2016-08-16 Thread Kevin Duling 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51098/#review145878
---


Ship it!




Ship It!

- Kevin Duling


On Aug. 15, 2016, 6:39 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51098/
> ---
> 
> (Updated Aug. 15, 2016, 6:39 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Kevin Duling, Lynn 
> Hughes-Godfrey, Lynn Gallinat, and Dan Smith.
> 
> 
> Bugs: GEODE-1781
> https://issues.apache.org/jira/browse/GEODE-1781
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1781: repackage internal statistics classes and refactor statistics 
> tests
> 
> * move internal statistics classes and tests into 
> com.gemstone.gemfire.internal.statistics pkg
> * modify tests to include integration and distributed in names
> * modify tests to use TemporaryFolder and TestName rules
> * remove unused classes and dead code from statistics tests
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionStatistics.java
>  2d59103 
>   
> extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/util/ModuleStatistics.java
>  82e882c 
>   geode-core/src/main/java/com/gemstone/gemfire/StatisticsFactory.java 
> 3ef5ba5 
>   geode-core/src/main/java/com/gemstone/gemfire/StatisticsTypeFactory.java 
> 9b6c546 
>   
> geode-core/src/main/java/com/gemstone/gemfire/admin/internal/MemberHealthEvaluator.java
>  d0710ca 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueStats.java
>  8d541a3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionStats.java
>  4bd4439 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java
>  d155602 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java
>  b26d76b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/CqQueryVsdStats.java
>  e9d30d5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexStats.java
>  77941b6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java
>  c4803ab 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  1ea5611 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java
>  f59ed84 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockStats.java
>  9a61c10 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractStatisticsFactory.java
>  972e670e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/ArchiveSplitter.java 
> 28b9dd7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsFactory.java
>  9d280eb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java
>  aa8da50 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireStatSampler.java
>  1eb35d0 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatHelper.java 
> 7ff0b1b 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ff9d2fb 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcFsStatistics.java
>  3070287 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcessStats.java 
> 05bc284 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxSystemStats.java 
> 22158da 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatListener.java 
> c46bc2f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsFactory.java
>  6f8315a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsImpl.java
>  cf59e1f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/OSXProcessStats.java 
> 0706c7b 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/OSXSystemStats.java 
> 8d440ca 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/OsStatisticsFactory.java
>  7dac90e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/ProcessStats.java 
> c80e340 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SimpleStatSampler.java 
> b3cc56b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisProcessStats.java
>  d07d398 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisSystemStats.java
>  9f56943 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveFormat.java 
> d1e67f9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveReader.java 
>

Re: Review Request 51125: GEODE-1782: stat resources with different time stamps should not be equal

2016-08-16 Thread Kevin Duling 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51125/#review145877
---



In the equals() method, there are several more fields that aren't compared.  
Should they be?

- Kevin Duling


On Aug. 15, 2016, 6:56 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51125/
> ---
> 
> (Updated Aug. 15, 2016, 6:56 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Darrel Schneider, Kevin Duling, Lynn 
> Hughes-Godfrey, Lynn Gallinat, and Dan Smith.
> 
> 
> Bugs: GEODE-1782
> https://issues.apache.org/jira/browse/GEODE-1782
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1782: stat resources with different time stamps should not be equal
> 
> * StatArchiveWithConsecutiveResourceInstGenerator generates gfs with multiple 
> stat resources of same name but different times
> * StatArchiveWithConsecutiveResourceInstIntegrationTest confirms existence of 
> bug GEODE-1782: StatArchiveReader ignores later stats reso
> urce with same name as closed stats resource
> * ResourceInstTest verifies the underlying issue in 
> StatArchiveReader.ResourceInst.equals and the fix
> 
> Note: this changeset builds upon the changeset for GEODE-1781 (same branch): 
> https://reviews.apache.org/r/51098
> 
> Explanation of new tests: I started out with a very large .gfs file and 
> reproduced the bug with 
> StatArchiveWithConsecutiveResourceInstIntegrationTest. Darrel helped identify 
> the underlying cause in StatArchiveReader.ResourceInst.equals. I then wrote 
> the unit test ResourceInstTest to reproduce the bug at the lowest level 
> possible and fix it. Next I created 
> StatArchiveWithConsecutiveResourceInstGenerator to generate a tiny .gfs file 
> for StatArchiveWithConsecutiveResourceInstIntegrationTest so that I could 
> check it in as well since it verifies the bug and the fix at a higher level.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveReader.java
>  12637bc 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/ResourceInstTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstGenerator.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstGeneratorTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatUtils.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstIntegrationTest.gfs
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51125/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Trying to upgrade spring-security

2016-08-16 Thread Kevin Duling 
Yes, that's my experience so far. But this particular error persists
regardless of how deep down the rabbit hole I gone and I haven't been able
to solve it.  I think it's due to an older slf4j being bundled in to jetty.

I'll give those commands a try and see whether they help or not.

On Tue, Aug 16, 2016 at 8:53 AM, Anthony Baker  wrote:

> Not sure if this is related to your error, but it looks like that version
> of spring-security would at least require moving to spring framework 4.3.1
> and possibly more dep updates as well.  You should be able to run some
> gradle commands (dependencies, dependencyInsight, dumpDependencies) to help
> sort out the full list of version changes needed.
>
> Anthony
>
> > On Aug 16, 2016, at 8:39 AM, Kevin Duling  wrote:
> >
> > I'm working on adding security to the REST methods and wanted to start by
> > upgrading spring-security to the latest version.
> >
> > Bumping the version from 4.1.1 from 3.1.7, I ran in to
> > GfshCommandsOverHttpSecurityTest failing under geode-web.  The error
> was:
> >
> > [warn 2016/08/12 15:37:52.078 PDT  tid=0x1] loader constraint
> > violation: when resolving method "org.slf4j.impl.StaticLoggerBinder.
> > getLoggerFactory()Lorg/slf4j/ILoggerFactory;" the class loader
> (instance of
> > org/eclipse/jetty/webapp/WebAppClassLoader) of the current class,
> > org/slf4j/LoggerFactory, and the class loader (instance of
> > sun/misc/Launcher$AppClassLoader) for the method's defining class,
> > org/slf4j/impl/StaticLoggerBinder, have different Class objects for the
> > type org/slf4j/ILoggerFactory used in the signature
> > java.lang.LinkageError: loader constraint violation: when resolving
> method
> > "org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/
> ILoggerFactory;"
> > the class loader (instance of org/eclipse/jetty/webapp/
> WebAppClassLoader)
> > of the current class, org/slf4j/LoggerFactory, and the class loader
> > (instance of sun/misc/Launcher$AppClassLoader) for the method's defining
> > class, org/slf4j/impl/StaticLoggerBinder, have different Class objects
> for
> > the type org/slf4j/ILoggerFactory used in the signature
>
>

Re: Trying to upgrade spring-security

2016-08-16 Thread Anthony Baker 
Not sure if this is related to your error, but it looks like that version of 
spring-security would at least require moving to spring framework 4.3.1 and 
possibly more dep updates as well.  You should be able to run some gradle 
commands (dependencies, dependencyInsight, dumpDependencies) to help sort out 
the full list of version changes needed.

Anthony

> On Aug 16, 2016, at 8:39 AM, Kevin Duling  wrote:
> 
> I'm working on adding security to the REST methods and wanted to start by
> upgrading spring-security to the latest version.
> 
> Bumping the version from 4.1.1 from 3.1.7, I ran in to
> GfshCommandsOverHttpSecurityTest failing under geode-web.  The error was:
> 
> [warn 2016/08/12 15:37:52.078 PDT  tid=0x1] loader constraint
> violation: when resolving method "org.slf4j.impl.StaticLoggerBinder.
> getLoggerFactory()Lorg/slf4j/ILoggerFactory;" the class loader (instance of
> org/eclipse/jetty/webapp/WebAppClassLoader) of the current class,
> org/slf4j/LoggerFactory, and the class loader (instance of
> sun/misc/Launcher$AppClassLoader) for the method's defining class,
> org/slf4j/impl/StaticLoggerBinder, have different Class objects for the
> type org/slf4j/ILoggerFactory used in the signature
> java.lang.LinkageError: loader constraint violation: when resolving method
> "org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory;"
> the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader)
> of the current class, org/slf4j/LoggerFactory, and the class loader
> (instance of sun/misc/Launcher$AppClassLoader) for the method's defining
> class, org/slf4j/impl/StaticLoggerBinder, have different Class objects for
> the type org/slf4j/ILoggerFactory used in the signature



signature.asc
Description: Message signed with OpenPGP using GPGMail

Trying to upgrade spring-security

2016-08-16 Thread Kevin Duling 
I'm working on adding security to the REST methods and wanted to start by
upgrading spring-security to the latest version.

Bumping the version from 4.1.1 from 3.1.7, I ran in to
GfshCommandsOverHttpSecurityTest failing under geode-web.  The error was:

[warn 2016/08/12 15:37:52.078 PDT  tid=0x1] loader constraint
violation: when resolving method "org.slf4j.impl.StaticLoggerBinder.
getLoggerFactory()Lorg/slf4j/ILoggerFactory;" the class loader (instance of
org/eclipse/jetty/webapp/WebAppClassLoader) of the current class,
org/slf4j/LoggerFactory, and the class loader (instance of
sun/misc/Launcher$AppClassLoader) for the method's defining class,
org/slf4j/impl/StaticLoggerBinder, have different Class objects for the
type org/slf4j/ILoggerFactory used in the signature
java.lang.LinkageError: loader constraint violation: when resolving method
"org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory;"
the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader)
of the current class, org/slf4j/LoggerFactory, and the class loader
(instance of sun/misc/Launcher$AppClassLoader) for the method's defining
class, org/slf4j/impl/StaticLoggerBinder, have different Class objects for
the type org/slf4j/ILoggerFactory used in the signature

Jenkins build is back to normal : Geode-nightly #562

2016-08-16 Thread Apache Jenkins Server 
See