Re: Review Request 51585: let getId() return unique name

2016-09-01 Thread xiaojian zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/
---

(Updated Sept. 2, 2016, 12:48 a.m.)


Review request for geode and Dan Smith.


Changes
---

a revised version using "lucene_" as prefix


Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11


Repository: geode


Description
---

Should return the internal unique name of the index for each lucene index.


Diffs (updated)
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java
 720d20d 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
 29a8e62 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java
 c64dd3d 

Diff: https://reviews.apache.org/r/51585/diff/


Testing
---

geode-lucene:precheckin


Thanks,

xiaojian zhou



Re: Review Request 51590: GEODE-1838: remove unused test classes

2016-09-01 Thread Jason Huynh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51590/#review147621
---


Ship it!




Ship It!

- Jason Huynh


On Sept. 2, 2016, 12:18 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51590/
> ---
> 
> (Updated Sept. 2, 2016, 12:18 a.m.)
> 
> 
> Review request for geode, Jason Huynh and nabarun nag.
> 
> 
> Bugs: GEODE-1838
> https://issues.apache.org/jira/browse/GEODE-1838
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1838: remove unused test classes
> 
> For GEODE-1832, the changes shown in https://reviews.apache.org/r/51589/ 
> removes the only dependency on the classes in the cacheRunner package.
> 
> 
> Diffs
> -
> 
>   geode-core/src/test/java/cacheRunner/Portfolio.java 5dd2b7e 
>   geode-core/src/test/java/cacheRunner/Position.java 4e7e6e1 
> 
> Diff: https://reviews.apache.org/r/51590/diff/
> 
> 
> Testing
> ---
> 
> clean build, precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>



Re: Review Request 51589: GEODE-1832: remove dependency on cacheRunner package

2016-09-01 Thread Jason Huynh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51589/#review147620
---


Ship it!




Ship It!

- Jason Huynh


On Sept. 2, 2016, 12:15 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51589/
> ---
> 
> (Updated Sept. 2, 2016, 12:15 a.m.)
> 
> 
> Review request for geode, Jason Huynh and nabarun nag.
> 
> 
> Bugs: GEODE-1832
> https://issues.apache.org/jira/browse/GEODE-1832
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1832: remove dependency on cacheRunner package
> 
> Comment out disabled test with note about how to rewrite the test. See
> GEODE-1837.
> 
> Also removed unused imports.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
>  3ab90c9 
> 
> Diff: https://reviews.apache.org/r/51589/diff/
> 
> 
> Testing
> ---
> 
> clean build, RemoteQueryDUnitTest, precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>



Review Request 51590: GEODE-1838: remove unused test classes

2016-09-01 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51590/
---

Review request for geode, Jason Huynh and nabarun nag.


Bugs: GEODE-1838
https://issues.apache.org/jira/browse/GEODE-1838


Repository: geode


Description
---

GEODE-1838: remove unused test classes

For GEODE-1832, the changes shown in https://reviews.apache.org/r/51589/ 
removes the only dependency on the classes in the cacheRunner package.


Diffs
-

  geode-core/src/test/java/cacheRunner/Portfolio.java 5dd2b7e 
  geode-core/src/test/java/cacheRunner/Position.java 4e7e6e1 

Diff: https://reviews.apache.org/r/51590/diff/


Testing
---

clean build, precheckin


Thanks,

Kirk Lund



Review Request 51589: GEODE-1832: remove dependency on cacheRunner package

2016-09-01 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51589/
---

Review request for geode, Jason Huynh and nabarun nag.


Bugs: GEODE-1832
https://issues.apache.org/jira/browse/GEODE-1832


Repository: geode


Description
---

GEODE-1832: remove dependency on cacheRunner package

Comment out disabled test with note about how to rewrite the test. See
GEODE-1837.

Also removed unused imports.


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
 3ab90c9 

Diff: https://reviews.apache.org/r/51589/diff/


Testing
---

clean build, RemoteQueryDUnitTest, precheckin


Thanks,

Kirk Lund



Re: Review Request 51585: let getId() return unique name

2016-09-01 Thread xiaojian zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/
---

(Updated Sept. 1, 2016, 10:55 p.m.)


Review request for geode and Dan Smith.


Changes
---

refactor it. It should contain region name all the time.


Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11


Repository: geode


Description
---

Should return the internal unique name of the index for each lucene index.


Diffs (updated)
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java
 720d20d 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
 29a8e62 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java
 c64dd3d 

Diff: https://reviews.apache.org/r/51585/diff/


Testing
---

geode-lucene:precheckin


Thanks,

xiaojian zhou



[GitHub] incubator-geode pull request #236: Feature/geode 1570

2016-09-01 Thread kjduling
Github user kjduling closed the pull request at:

https://github.com/apache/incubator-geode/pull/236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #236: Feature/geode 1570

2016-09-01 Thread kjduling
Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/236
  
Closing as this was only a temp.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 51585: let getId() return unique name

2016-09-01 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/#review147613
---



I think the ID needs to include something indicating that this profile is for 
lucene, rather than some other cache service. Maybe the fully qualified name of 
the class? I don't think adding the region really makes a difference, because 
the profile is already region specific.

- Dan Smith


On Sept. 1, 2016, 10:04 p.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51585/
> ---
> 
> (Updated Sept. 1, 2016, 10:04 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-11
> https://issues.apache.org/jira/browse/GEODE-11
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Should return the internal unique name of the index for each lucene index.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java
>  720d20d 
> 
> Diff: https://reviews.apache.org/r/51585/diff/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>



Review Request 51585: let getId() return unique name

2016-09-01 Thread xiaojian zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/
---

Review request for geode and Dan Smith.


Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11


Repository: geode


Description
---

Should return the internal unique name of the index for each lucene index.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java
 720d20d 

Diff: https://reviews.apache.org/r/51585/diff/


Testing
---

geode-lucene:precheckin


Thanks,

xiaojian zhou



Re: Build failed in Jenkins: Geode-nightly #579

2016-09-01 Thread Kirk Lund
#577 hit this same OOME failure.

However, #578 did not. It failed with a BindException in
DiskRegionJUnitTest.

-Kirk


On Thu, Sep 1, 2016 at 1:56 PM, Dan Smith  wrote:

> I think we've seen something like this before when tests are logging too
> much. Jenkins is trying to parse the test result xml files, which contain
> all of the stdout from the test.
>
> -Dan
>
> On Thu, Sep 1, 2016 at 1:41 PM, Kirk Lund  wrote:
>
> > We're getting OOME failures in Hudson fairly frequently in the nightly
> > build. Any ideas what the issue is? Do we need to change the job
> > configuration or exclude more build machines?
> >
> > -Kirk
> >
> > -- Forwarded message --
> > From: Apache Jenkins Server 
> > Date: Thu, Sep 1, 2016 at 1:23 PM
> > Subject: Build failed in Jenkins: Geode-nightly #579
> > To: dev@geode.incubator.apache.org, hkhame...@pivotal.io,
> gz...@pivotal.io
> > ,
> > upthewatersp...@apache.org, sbawas...@pivotal.io, bogle...@pivotal.io,
> > aba...@pivotal.io
> >
> >
> > See 
> >
> > Changes:
> >
> > [abaker] GEODE-1809: Improve error handling
> >
> > [gzhou] GEODE-11: create index repository using raw Lucene directory.
> >
> > [gzhou] GEODE-11: need to fix the junit test case when adding FSDirectory
> >
> > --
> > [...truncated 486 lines...]
> > [fatal 2016/09/01 10:44:41.170 UTC 
> tid=0x1e1]
> > (tid=481 msgId=19) No longer connected to localhost[27402].
> >
> > 7606 tests completed, 1 failed, 588 skipped
> > :geode-core:distributedTest FAILED
> > :geode-core:flakyTest
> > :geode-core:integrationTest
> > :geode-cq:assemble
> > :geode-cq:compileTestJavaNote: Some input files use or override a
> > deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > Note: Some input files use unchecked or unsafe operations.
> > Note: Recompile with -Xlint:unchecked for details.
> >
> > :geode-cq:processTestResources
> > :geode-cq:testClasses
> > :geode-cq:checkMissedTests
> > :geode-cq:test
> > :geode-cq:check
> > :geode-cq:build
> > :geode-cq:distributedTest
> > :geode-cq:flakyTest
> > :geode-cq:integrationTest
> > :geode-json:assemble
> > :geode-json:compileTestJava UP-TO-DATE
> > :geode-json:processTestResources UP-TO-DATE
> > :geode-json:testClasses UP-TO-DATE
> > :geode-json:checkMissedTests UP-TO-DATE
> > :geode-json:test UP-TO-DATE
> > :geode-json:check
> > :geode-json:build
> > :geode-json:distributedTest UP-TO-DATE
> > :geode-json:flakyTest UP-TO-DATE
> > :geode-json:integrationTest UP-TO-DATE
> > :geode-junit:javadoc
> > :geode-junit:javadocJar
> > :geode-junit:sourcesJar
> > :geode-junit:signArchives SKIPPED
> > :geode-junit:assemble
> > :geode-junit:compileTestJava
> > :geode-junit:processTestResources UP-TO-DATE
> > :geode-junit:testClasses
> > :geode-junit:checkMissedTests
> > :geode-junit:test
> > :geode-junit:check
> > :geode-junit:build
> > :geode-junit:distributedTest
> > :geode-junit:flakyTest
> > :geode-junit:integrationTest
> > :geode-lucene:assemble
> > :geode-lucene:compileTestJavaNote: Some input files use or override a
> > deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > Note: Some input files use unchecked or unsafe operations.
> > Note: Recompile with -Xlint:unchecked for details.
> >
> > :geode-lucene:processTestResources
> > :geode-lucene:testClasses
> > :geode-lucene:checkMissedTests
> > :geode-lucene:test
> > :geode-lucene:check
> > :geode-lucene:build
> > :geode-lucene:distributedTest
> > :geode-lucene:flakyTest
> > :geode-lucene:integrationTest
> > :geode-pulse:assemble
> > :geode-pulse:compileTestJavaNote:  > job/Geode-nightly/ws/geode-pulse/src/test/java/com/
> > vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java> uses or
> overrides
> > a deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > Note: Some input files use unchecked or unsafe operations.
> > Note: Recompile with -Xlint:unchecked for details.
> >
> > :geode-pulse:processTestResources
> > :geode-pulse:testClasses
> > :geode-pulse:checkMissedTests
> > :geode-pulse:test
> > :geode-pulse:check
> > :geode-pulse:build
> > :geode-pulse:distributedTest
> > :geode-pulse:flakyTest
> > :geode-pulse:integrationTest
> > :geode-rebalancer:jar
> > :geode-rebalancer:javadoc
> > :geode-rebalancer:javadocJar
> > :geode-rebalancer:sourcesJar
> > :geode-rebalancer:signArchives SKIPPED
> > :geode-rebalancer:assemble
> > :geode-rebalancer:compileTestJava
> > :geode-rebalancer:processTestResources UP-TO-DATE
> > :geode-rebalancer:testClasses
> > :geode-rebalancer:checkMissedTests
> > :geode-rebalancer:test
> > :geode-rebalancer:check
> > :geode-rebalancer:build
> > :geode-rebalancer:distributedTest
> > :geode-rebalancer:flakyTest
> > :geode-rebalancer:integrationTest
> > :geode-wan:assemble
> > :geode-wan:compileTestJavaNote: Some input files use or override a
> > deprecated API.
> > Note: Recompile with -Xlint:deprecation fo

Re: Build failed in Jenkins: Geode-nightly #579

2016-09-01 Thread Dan Smith
I think we've seen something like this before when tests are logging too
much. Jenkins is trying to parse the test result xml files, which contain
all of the stdout from the test.

-Dan

On Thu, Sep 1, 2016 at 1:41 PM, Kirk Lund  wrote:

> We're getting OOME failures in Hudson fairly frequently in the nightly
> build. Any ideas what the issue is? Do we need to change the job
> configuration or exclude more build machines?
>
> -Kirk
>
> -- Forwarded message --
> From: Apache Jenkins Server 
> Date: Thu, Sep 1, 2016 at 1:23 PM
> Subject: Build failed in Jenkins: Geode-nightly #579
> To: dev@geode.incubator.apache.org, hkhame...@pivotal.io, gz...@pivotal.io
> ,
> upthewatersp...@apache.org, sbawas...@pivotal.io, bogle...@pivotal.io,
> aba...@pivotal.io
>
>
> See 
>
> Changes:
>
> [abaker] GEODE-1809: Improve error handling
>
> [gzhou] GEODE-11: create index repository using raw Lucene directory.
>
> [gzhou] GEODE-11: need to fix the junit test case when adding FSDirectory
>
> --
> [...truncated 486 lines...]
> [fatal 2016/09/01 10:44:41.170 UTC  tid=0x1e1]
> (tid=481 msgId=19) No longer connected to localhost[27402].
>
> 7606 tests completed, 1 failed, 588 skipped
> :geode-core:distributedTest FAILED
> :geode-core:flakyTest
> :geode-core:integrationTest
> :geode-cq:assemble
> :geode-cq:compileTestJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-cq:processTestResources
> :geode-cq:testClasses
> :geode-cq:checkMissedTests
> :geode-cq:test
> :geode-cq:check
> :geode-cq:build
> :geode-cq:distributedTest
> :geode-cq:flakyTest
> :geode-cq:integrationTest
> :geode-json:assemble
> :geode-json:compileTestJava UP-TO-DATE
> :geode-json:processTestResources UP-TO-DATE
> :geode-json:testClasses UP-TO-DATE
> :geode-json:checkMissedTests UP-TO-DATE
> :geode-json:test UP-TO-DATE
> :geode-json:check
> :geode-json:build
> :geode-json:distributedTest UP-TO-DATE
> :geode-json:flakyTest UP-TO-DATE
> :geode-json:integrationTest UP-TO-DATE
> :geode-junit:javadoc
> :geode-junit:javadocJar
> :geode-junit:sourcesJar
> :geode-junit:signArchives SKIPPED
> :geode-junit:assemble
> :geode-junit:compileTestJava
> :geode-junit:processTestResources UP-TO-DATE
> :geode-junit:testClasses
> :geode-junit:checkMissedTests
> :geode-junit:test
> :geode-junit:check
> :geode-junit:build
> :geode-junit:distributedTest
> :geode-junit:flakyTest
> :geode-junit:integrationTest
> :geode-lucene:assemble
> :geode-lucene:compileTestJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-lucene:processTestResources
> :geode-lucene:testClasses
> :geode-lucene:checkMissedTests
> :geode-lucene:test
> :geode-lucene:check
> :geode-lucene:build
> :geode-lucene:distributedTest
> :geode-lucene:flakyTest
> :geode-lucene:integrationTest
> :geode-pulse:assemble
> :geode-pulse:compileTestJavaNote:  job/Geode-nightly/ws/geode-pulse/src/test/java/com/
> vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java> uses or overrides
> a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-pulse:processTestResources
> :geode-pulse:testClasses
> :geode-pulse:checkMissedTests
> :geode-pulse:test
> :geode-pulse:check
> :geode-pulse:build
> :geode-pulse:distributedTest
> :geode-pulse:flakyTest
> :geode-pulse:integrationTest
> :geode-rebalancer:jar
> :geode-rebalancer:javadoc
> :geode-rebalancer:javadocJar
> :geode-rebalancer:sourcesJar
> :geode-rebalancer:signArchives SKIPPED
> :geode-rebalancer:assemble
> :geode-rebalancer:compileTestJava
> :geode-rebalancer:processTestResources UP-TO-DATE
> :geode-rebalancer:testClasses
> :geode-rebalancer:checkMissedTests
> :geode-rebalancer:test
> :geode-rebalancer:check
> :geode-rebalancer:build
> :geode-rebalancer:distributedTest
> :geode-rebalancer:flakyTest
> :geode-rebalancer:integrationTest
> :geode-wan:assemble
> :geode-wan:compileTestJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-wan:processTestResources
> :geode-wan:testClasses
> :geode-wan:checkMissedTests
> :geode-wan:test
> :geode-wan:check
> :geode-wan:build
> :geode-wan:distributedTest
> :geode-wan:flakyTest
> :geode-wan:integrationTest
> :geode-web:assemble
> :geode-web:compileTestJavaNote:  job/Geode-nigh

Fwd: Build failed in Jenkins: Geode-nightly #579

2016-09-01 Thread Kirk Lund
We're getting OOME failures in Hudson fairly frequently in the nightly
build. Any ideas what the issue is? Do we need to change the job
configuration or exclude more build machines?

-Kirk

-- Forwarded message --
From: Apache Jenkins Server 
Date: Thu, Sep 1, 2016 at 1:23 PM
Subject: Build failed in Jenkins: Geode-nightly #579
To: dev@geode.incubator.apache.org, hkhame...@pivotal.io, gz...@pivotal.io,
upthewatersp...@apache.org, sbawas...@pivotal.io, bogle...@pivotal.io,
aba...@pivotal.io


See 

Changes:

[abaker] GEODE-1809: Improve error handling

[gzhou] GEODE-11: create index repository using raw Lucene directory.

[gzhou] GEODE-11: need to fix the junit test case when adding FSDirectory

--
[...truncated 486 lines...]
[fatal 2016/09/01 10:44:41.170 UTC  tid=0x1e1]
(tid=481 msgId=19) No longer connected to localhost[27402].

7606 tests completed, 1 failed, 588 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote:  uses or overrides
a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:flakyTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote:  uses or overrides a deprecated
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web:processTestResources UP-TO-DATE
:geode-web:testClasses
:geode-web:checkMissedTests
:geode-web:test
:geode-web:check
:geode-web:build
:geode-web:distributedTest
:geode-web:flakyT

Build failed in Jenkins: Geode-nightly #579

2016-09-01 Thread Apache Jenkins Server
See 

Changes:

[abaker] GEODE-1809: Improve error handling

[gzhou] GEODE-11: create index repository using raw Lucene directory.

[gzhou] GEODE-11: need to fix the junit test case when adding FSDirectory

--
[...truncated 486 lines...]
[fatal 2016/09/01 10:44:41.170 UTC  tid=0x1e1] 
(tid=481 msgId=19) No longer connected to localhost[27402].

7606 tests completed, 1 failed, 588 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:flakyTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web:processTestResources UP-TO-DATE
:geode-web:testClasses
:geode-web:checkMissedTests
:geode-web:test
:geode-web:check
:geode-web:build
:geode-web:distributedTest
:geode-web:flakyTest
:geode-web:integrationTest
:geode-web-api:assemble
:geode-web-api:compileTestJava UP-TO-DATE
:geode-web-api:processTestResources UP-TO-DATE
:geode-web-api:testClasses UP-TO-DATE
:geode-web-api:checkMissedTests UP-TO-DATE
:geode-web-api:test UP-TO-DATE
:geode-web-api:check
:geode-web-api:build
:geode-web-api:distributedTest UP-TO-DATE
:geode-web-api:flakyTest UP-TO-DATE
:geode-web-api:integrationTest UP-TO-DATE
:combineReports
All test reports at 


Re: Review Request 51577: GEODE-1834: initilize the socketcreator correctly

2016-09-01 Thread Kirk Lund


> On Sept. 1, 2016, 5:26 p.m., Kirk Lund wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java, 
> > line 331
> > 
> >
> > No calls ever pass in "true" for reinitialize. I think this shouldn't 
> > be added unless there's a code path that needs it. Also, we would need a 
> > new test added that exercises this arg as well.
> 
> Jinmei Liao wrote:
> The original calls pass in "true", only the JmxManagerLocatorRequest will 
> pass in "false"

Oops! I see that now on line 293 of SocketCreator. I closed the issue.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51577/#review147579
---


On Sept. 1, 2016, 4:30 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51577/
> ---
> 
> (Updated Sept. 1, 2016, 4:30 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1834: initilize the socketcreator correctly
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
> fded3c3b1dc3cf6d2af31291c97adb9f35cd1150 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
>  861f51d4e0077440ab3128e6053c389cecfd9bb8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java
>  d0d906a8f86ce6a882beb79f91906f5ba5e0ec28 
> 
> Diff: https://reviews.apache.org/r/51577/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



[GitHub] incubator-geode pull request #236: Feature/geode 1570

2016-09-01 Thread kjduling
GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/236

Feature/geode 1570

temp pull request - don't accept

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1570

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #236


commit cc348a08966fda96077287f14f2594acf0a8013b
Author: Kevin J. Duling 
Date:   2016-08-31T17:25:46Z

GEODE-1570: Developer REST API should be secured

Checkpoint - Basic Authentication is working along with using 
GeodeSecurityUtil to validate users.

commit 0628e95f22abb68f58bc99791ae9bc238a859739
Author: Kevin J. Duling 
Date:   2016-08-31T17:54:44Z

GEODE-1570: Developer REST API should be secured

Missing files

commit 528a1675126ac308e172fc9c05c41c47ed98feb9
Author: Kevin J. Duling 
Date:   2016-08-31T18:20:43Z

GEODE-1570: Developer REST API should be secured

Protected delete region data

commit 98eba8af4a5d1b15069f6313cae739480b477b54
Author: Kevin J. Duling 
Date:   2016-08-31T23:28:16Z

GEODE-1570: Developer REST API should be secured

401s are now properly returned for unknown users

commit 1efd32344ba3221bf852a5e97d4827c2a7396b23
Author: Kevin J. Duling 
Date:   2016-09-01T17:35:31Z

GEODE-1570: Developer REST API should be secured

autowire AccessDeniedHandler

commit 81ab3180f26b5a7ebb883526d8924ec9e1f64369
Author: Kevin Duling 
Date:   2016-09-01T17:53:50Z

Merged with develop




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 51577: GEODE-1834: initilize the socketcreator correctly

2016-09-01 Thread Jinmei Liao


> On Sept. 1, 2016, 5:26 p.m., Kirk Lund wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java, 
> > line 331
> > 
> >
> > No calls ever pass in "true" for reinitialize. I think this shouldn't 
> > be added unless there's a code path that needs it. Also, we would need a 
> > new test added that exercises this arg as well.

The original calls pass in "true", only the JmxManagerLocatorRequest will pass 
in "false"


> On Sept. 1, 2016, 5:26 p.m., Kirk Lund wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java,
> >  line 92
> > 
> >
> > Since this class has no tests but we're trying to switch to TDD, you 
> > really should introduce a new JmxManagerLocatorRequestTest (UnitTest 
> > category) that exercises the modified method at a minimum.

Will add in a test


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51577/#review147579
---


On Sept. 1, 2016, 4:30 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51577/
> ---
> 
> (Updated Sept. 1, 2016, 4:30 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1834: initilize the socketcreator correctly
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
> fded3c3b1dc3cf6d2af31291c97adb9f35cd1150 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
>  861f51d4e0077440ab3128e6053c389cecfd9bb8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java
>  d0d906a8f86ce6a882beb79f91906f5ba5e0ec28 
> 
> Diff: https://reviews.apache.org/r/51577/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: Review Request 51577: GEODE-1834: initilize the socketcreator correctly

2016-09-01 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51577/#review147579
---




geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java (line 
303)


No calls ever pass in "true" for reinitialize. I think this shouldn't be 
added unless there's a code path that needs it. Also, we would need a new test 
added that exercises this arg as well.



geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
 (line 89)


Since this class has no tests but we're trying to switch to TDD, you really 
should introduce a new JmxManagerLocatorRequestTest (UnitTest category) that 
exercises the modified method at a minimum.


- Kirk Lund


On Sept. 1, 2016, 4:30 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51577/
> ---
> 
> (Updated Sept. 1, 2016, 4:30 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1834: initilize the socketcreator correctly
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
> fded3c3b1dc3cf6d2af31291c97adb9f35cd1150 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
>  861f51d4e0077440ab3128e6053c389cecfd9bb8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java
>  d0d906a8f86ce6a882beb79f91906f5ba5e0ec28 
> 
> Diff: https://reviews.apache.org/r/51577/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Review Request 51577: GEODE-1834: initilize the socketcreator correctly

2016-09-01 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51577/
---

Review request for geode, Bruce Schuchardt and Kirk Lund.


Repository: geode


Description
---

GEODE-1834: initilize the socketcreator correctly


Diffs
-

  geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
fded3c3b1dc3cf6d2af31291c97adb9f35cd1150 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
 861f51d4e0077440ab3128e6053c389cecfd9bb8 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/JSSESocketJUnitTest.java 
d0d906a8f86ce6a882beb79f91906f5ba5e0ec28 

Diff: https://reviews.apache.org/r/51577/diff/


Testing
---


Thanks,

Jinmei Liao



[GitHub] incubator-geode pull request #235: GEODE-1818: Bug37377DUnitTest passes with...

2016-09-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: Geode-nightly #578

2016-09-01 Thread Apache Jenkins Server
See 

Changes:

[hkhamesra] GEODE-900 Test was using stale cache.

[hkhamesra] GEODE-1372 Updated java docs.

[hkhamesra] GEODE-1828 Added logging to debug the test

[boglesby] GEODE-1819: modified BRQ so that all initialization is done before

--
[...truncated 710 lines...]
:geode-core:checkMissedTests
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:flakyTest
:geode-core:integrationTest

com.gemstone.gemfire.internal.cache.DiskRegionJUnitTest > 
testBridgeServerRunningInSynchPersistOnlyForIOExceptionCase FAILED
java.net.BindException: Failed to create server socket on  null[5,555]
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:814)
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:774)
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:738)
at 
com.gemstone.gemfire.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:470)
at 
com.gemstone.gemfire.internal.cache.CacheServerImpl.start(CacheServerImpl.java:323)
at 
com.gemstone.gemfire.internal.cache.DiskRegionJUnitTest.testBridgeServerRunningInSynchPersistOnlyForIOExceptionCase(DiskRegionJUnitTest.java:2215)

Caused by:
java.net.BindException: Address already in use
at java.net.PlainSocketImpl.socketBind(Native Method)
at 
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
at java.net.ServerSocket.bind(ServerSocket.java:375)
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:811)
... 5 more

com.gemstone.gemfire.internal.cache.DiskRegionJUnitTest > 
testBridgeServerStoppingInSynchPersistOnlyForIOExceptionCase FAILED
java.net.BindException: Failed to create server socket on  null[5,555]
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:814)
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:774)
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:738)
at 
com.gemstone.gemfire.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:470)
at 
com.gemstone.gemfire.internal.cache.CacheServerImpl.start(CacheServerImpl.java:323)
at 
com.gemstone.gemfire.internal.cache.DiskRegionJUnitTest.testBridgeServerStoppingInSynchPersistOnlyForIOExceptionCase(DiskRegionJUnitTest.java:2103)

Caused by:
java.net.BindException: Address already in use
at java.net.PlainSocketImpl.socketBind(Native Method)
at 
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
at java.net.ServerSocket.bind(ServerSocket.java:375)
at 
com.gemstone.gemfire.internal.SocketCreator.createServerSocket(SocketCreator.java:811)
... 5 more

3247 tests completed, 2 failed, 175 skipped
:geode-core:integrationTest FAILED
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.0.0/lucene-test-framework-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.0.0/lucene-codecs-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.0.0/lucene-test-framework-6.0.0.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.0.0/lucene-codecs-6.0.0.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files