Re: Deprecate DynamicRegionFactory

[John Blum]

+1 - forget deprecated; delete it.

On Tue, Oct 11, 2016 at 8:22 PM, Udo Kohlmeyer 
wrote:

> +1 - I see no real benefit for this.
>
>
>
> On 12/10/16 1:10 pm, William Markito wrote:
>
>> +1 -  We always discouraged people using dynamic regions
>>
>> On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith  wrote:
>>
>> I'd like to reopen the discussion about deprecating
>>> DynamicRegionFactory. This is some old crufty code I don't think we
>>> want anyone to use. I see we had a ticket to deprecated it
>>> (GEODE-388), but we chose not to do it because we don't have an
>>> alternative API to create regions from the client (GEODE-215).
>>>
>>> The thing is, there is a pretty easy workaround to use functions to
>>> create regions from the client. Personally I'd recommend that over
>>> DynamicRegionFactory. Can we just deprecate DynamicRegionFactory now
>>> and implement GEODE-215 later?
>>>
>>> -Dan
>>>
>>>
>>
>>
>


-- 
-John
503-504-8657
john.blum10101 (skype)

Re: Deprecate DynamicRegionFactory

[Udo Kohlmeyer]

+1 - I see no real benefit for this.


On 12/10/16 1:10 pm, William Markito wrote:

+1 -  We always discouraged people using dynamic regions

On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith  wrote:


I'd like to reopen the discussion about deprecating
DynamicRegionFactory. This is some old crufty code I don't think we
want anyone to use. I see we had a ticket to deprecated it
(GEODE-388), but we chose not to do it because we don't have an
alternative API to create regions from the client (GEODE-215).

The thing is, there is a pretty easy workaround to use functions to
create regions from the client. Personally I'd recommend that over
DynamicRegionFactory. Can we just deprecate DynamicRegionFactory now
and implement GEODE-215 later?

-Dan

Re: Deprecate DynamicRegionFactory

[Jinmei Liao]

+1 drop it if we don't want people to use it.

On Tue, Oct 11, 2016 at 8:15 PM, Kirk Lund  wrote:

> +1 drop it as a bug with no need for replacement (or in favor of using a
> function)
>
> On Tuesday, October 11, 2016, William Markito  wrote:
>
> > +1 -  We always discouraged people using dynamic regions
> >
> > On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith  > > wrote:
> >
> > > I'd like to reopen the discussion about deprecating
> > > DynamicRegionFactory. This is some old crufty code I don't think we
> > > want anyone to use. I see we had a ticket to deprecated it
> > > (GEODE-388), but we chose not to do it because we don't have an
> > > alternative API to create regions from the client (GEODE-215).
> > >
> > > The thing is, there is a pretty easy workaround to use functions to
> > > create regions from the client. Personally I'd recommend that over
> > > DynamicRegionFactory. Can we just deprecate DynamicRegionFactory now
> > > and implement GEODE-215 later?
> > >
> > > -Dan
> > >
> >
> >
> >
> > --
> >
> > ~/William
> >
>



-- 
Cheers

Jinmei

Re: Deprecate DynamicRegionFactory

[Kirk Lund]

+1 drop it as a bug with no need for replacement (or in favor of using a
function)

On Tuesday, October 11, 2016, William Markito  wrote:

> +1 -  We always discouraged people using dynamic regions
>
> On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith  > wrote:
>
> > I'd like to reopen the discussion about deprecating
> > DynamicRegionFactory. This is some old crufty code I don't think we
> > want anyone to use. I see we had a ticket to deprecated it
> > (GEODE-388), but we chose not to do it because we don't have an
> > alternative API to create regions from the client (GEODE-215).
> >
> > The thing is, there is a pretty easy workaround to use functions to
> > create regions from the client. Personally I'd recommend that over
> > DynamicRegionFactory. Can we just deprecate DynamicRegionFactory now
> > and implement GEODE-215 later?
> >
> > -Dan
> >
>
>
>
> --
>
> ~/William
>

Re: Review Request 52751: GEODE-1986: correctly set the flag indicating if cluster configuration service is running or not on a locator.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52751/
---

(Updated Oct. 12, 2016, 2:21 a.m.)


Review request for geode, Jared Stewart, John Blum, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-1986: correctly set the flag indicating if cluster configuration service 
is running or not on a locator.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 17303c1f984a90159f924a262d0ec843410cec16 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
d166397e3d5897347500e5447637fb4b99895388 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithEmbededLocatorDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/52751/diff/


Testing
---

prechecking running


Thanks,

Jinmei Liao

Re: Deprecate DynamicRegionFactory

[William Markito]

+1 -  We always discouraged people using dynamic regions

On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith  wrote:

> I'd like to reopen the discussion about deprecating
> DynamicRegionFactory. This is some old crufty code I don't think we
> want anyone to use. I see we had a ticket to deprecated it
> (GEODE-388), but we chose not to do it because we don't have an
> alternative API to create regions from the client (GEODE-215).
>
> The thing is, there is a pretty easy workaround to use functions to
> create regions from the client. Personally I'd recommend that over
> DynamicRegionFactory. Can we just deprecate DynamicRegionFactory now
> and implement GEODE-215 later?
>
> -Dan
>



-- 

~/William

Re: Using Fix Version on JIRA

[William Markito]

Thanks Swap, that sounds good.

The missing part now is people using the Fix Version on the tickets before
marking them as resolved.

On Tue, Oct 11, 2016 at 3:38 PM, Swapnil Bawaskar 
wrote:

> Hi William, please refer to this thread for how this should work for 1.0:
> http://markmail.org/message/lmxtps7clvyphpg2
>
> On Mon, Oct 10, 2016 at 10:02 PM, William Markito 
> wrote:
>
> > This may sound like a simple and not really important, but it's key to
> > track issues and which release the fix is part of.
> >
> > It also helps in generating automated release notes through JIRA, such as
> > this one [1] from M3.
> >
> > Since we already created a release branch for 1.0 but there is work still
> > on-going in develop I'd like to encourage people to use the Fix Version
> > field with even more attention so we don't lose track of where the work
> has
> > been completed.
> >
> > Any thoughts or ideas on how we can approach this ?
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12318420&version=12335358
> >
> > --
> >
> > ~/William
> >
>



-- 

~/William

Re: Review Request 52742: GEODE-1979: refactor tests using LocatorServerConfigurationRule

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52742/
---

(Updated Oct. 12, 2016, 1:11 a.m.)


Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-1979: refactor tests using LocatorServerConfigurationRule


Diffs
-

  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
 ff7f0282ae0bd0bed74aca6e549c8b3162d76900 
  
geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
 877f0571d6b6985d0cda43c35f0abae6cbc12a88 
  
geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
 dae062acb980a93d00b5498e6ac99eda97918a39 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerConfigurationRule.java
 2fa262c732662becbba0eb48ce47e7d88b0fec5c 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
 f837530e2bcd6026102d5a1267a48ac8b37578fe 

Diff: https://reviews.apache.org/r/52742/diff/


Testing (updated)
---

precheckin running


Thanks,

Jinmei Liao

Re: Review Request 52742: GEODE-1979: refactor tests using LocatorServerConfigurationRule

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52742/
---

(Updated Oct. 12, 2016, 1:10 a.m.)


Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-1979: refactor tests using LocatorServerConfigurationRule


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
 ff7f0282ae0bd0bed74aca6e549c8b3162d76900 
  
geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
 877f0571d6b6985d0cda43c35f0abae6cbc12a88 
  
geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
 dae062acb980a93d00b5498e6ac99eda97918a39 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerConfigurationRule.java
 2fa262c732662becbba0eb48ce47e7d88b0fec5c 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
 f837530e2bcd6026102d5a1267a48ac8b37578fe 

Diff: https://reviews.apache.org/r/52742/diff/


Testing
---

the affected tests


Thanks,

Jinmei Liao

[GitHub] incubator-geode pull request #257: Feature/geode 1952

[joeymcallister]

GitHub user joeymcallister opened a pull request:

https://github.com/apache/incubator-geode/pull/257

Feature/geode 1952

Adds `geode-book` directory for building the end-user documentation from 
the content in the `geode-docs` directory. Updates the `geode-docs` README for 
building the docs locally.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joeymcallister/incubator-geode 
feature/GEODE-1952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #257


commit d9d8b59b325c0581ff54c97db91b52adb0f4714c
Author: Joey McAllister 
Date:   2016-10-11T20:34:06Z

Add geode-book dir for docs build

commit 1c98ba56cf609ee61b5872cd696db95d4bcfebaa
Author: Joey McAllister 
Date:   2016-10-11T21:06:36Z

Revert "Add geode-book dir for docs build"

This reverts commit d9d8b59b325c0581ff54c97db91b52adb0f4714c.

commit e9b44af4e996ac739cd632704e925d525b9fcca1
Author: Joey McAllister 
Date:   2016-10-11T21:24:40Z

GEODE-1952 Add geode-book dir to build docs

commit 7592ba1027e51ae84dcfbed297534522557fbbec
Author: Joey McAllister 
Date:   2016-10-11T21:38:11Z

GEODE-1952 Remove old redirects

commit 36d1f39d68a847dc574e267c51efa89f9c980bd6
Author: Joey McAllister 
Date:   2016-10-11T22:54:54Z

GEODE-1952 Update docs README, config

commit 0b31275966beaf4039afd913b8644c81a32c1758
Author: Joey McAllister 
Date:   2016-10-12T00:29:12Z

GEODE-1952 Add book README; edit docs README, CONTRIBUTE




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 52759: GEODE-1991: Removing sleeps from HARegionQueueJUnitTest

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52759/
---

Review request for geode, nabarun nag and xiaojian zhou.


Repository: geode


Description
---

Getting rid of a bunch of sleeps in HARegionQueueJUnitTest to fix a
bunch of tests with race conditions. Tests of expiration were sleeping
for short amounts of time and then asserting that expiration happened or
didn't. Changing these sleeps to use Awailitily.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionQueueJUnitTest.java
 48fb3a2769994233ea7c899e324506c102517456 
  
geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueJUnitTest.java
 37047583d477c06ac9788ba5df960fe74b225229 

Diff: https://reviews.apache.org/r/52759/diff/


Testing
---


Thanks,

Dan Smith

Re: Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

[Dan Smith]

> On Oct. 11, 2016, 10:11 p.m., Jason Huynh wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java,
> >  line 371
> > 
> >
> > Was this intended for this diff?

Ah, that was supposed to be a separate change. Thanks!


> On Oct. 11, 2016, 10:11 p.m., Jason Huynh wrote:
> > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java,
> >  line 173
> > 
> >
> > Would you be able to remove/modify this comment a bit?  Mostly remove 
> > the bug number as it's not a geode number any more

Sure, I'll update that.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52750/#review152219
---


On Oct. 11, 2016, 9:53 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52750/
> ---
> 
> (Updated Oct. 11, 2016, 9:53 p.m.)
> 
> 
> Review request for geode, Jason Huynh and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changing the logic for how to we check to see if an entry may have been
> concurrently modified while an indexed query is in progress.
> 
> The new logic just has a time window, defaulting to 10 minutes. If the
> entry was changed less than 10 minutes for the query started, we will
> reevaluate the index expression to make sure the entry is still valid.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java
>  8ef82f1bee9831fa50a93f87bb9ed0b644a542b4 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  84ba926ee35638c4263a0d93a8be3fef1e2c5f7f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 46ccd47e96e75a8c4c6f3075b65a2d2447043213 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/IndexManagerJUnitTest.java
>  c7633ea05b0f8a90baf0c8f9e9849480421ebd45 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceNoReevaluationIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexAPIJUnitTest.java
>  7cc2c12f80ba4248edca9035bbdfd839d20f70ad 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java
>  1160d4bdb755e39a2a5c52fb167b86e760e0ae88 
> 
> Diff: https://reviews.apache.org/r/52750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Deprecate DynamicRegionFactory

[Dan Smith]

I'd like to reopen the discussion about deprecating
DynamicRegionFactory. This is some old crufty code I don't think we
want anyone to use. I see we had a ticket to deprecated it
(GEODE-388), but we chose not to do it because we don't have an
alternative API to create regions from the client (GEODE-215).

The thing is, there is a pretty easy workaround to use functions to
create regions from the client. Personally I'd recommend that over
DynamicRegionFactory. Can we just deprecate DynamicRegionFactory now
and implement GEODE-215 later?

-Dan

Spring Data Geode 1.0.0.APACHE-GEODE-INCUBATING-M3 Released!

[John Blum]

Now, many Moons overdue, and for that, I apologize to both the Spring and
Apache Geode communities for the delay, however, I am extremely pleased to
officially announce the release of *Spring Data Geode* with support for
Apache Geode 1.0.0-incubating.M3.  Bits in Maven Central [1].

*So, why should Apache Geode developers use Spring to build enterprise
applications that use Apache Geode?*

1. Spring has highly consistent, robust and comfortable/familiar
programming model that is second to none.

2. But, more importantly, SDG protects developers from unexpected changes,
such as API breaking changes introduced between versions of Apache Geode,
or for instance, GEODE-37 [2], the new package structure (com.gemstone.gemfire
-> org.apache.geode), which will affect your applications.

3. SDG makes it easy to switch between Apache Geode and Pivotal GemFire if
the time ever arises where you need the added support.  It is as simple as
switching the dependency from...


  org.springframework.data
  *spring-data-geode*
  *1.0.0.APACHE-GEODE-INCUBATING-M3*


To...


  org.springframework.data
  *spring-data-gemfire*
  *1.8.4.RELEASE*


NOTE: versions very after time.

4. By using Spring, and SDG specifically, you can easily integrate with the
vast array of other powerful Spring technologies, all OSS (e.g. Spring
Session [Data GemFire|Geode] [3] for Session replication, or Spring XD [4]
for streaming).

See *Luke Shannon* and I's presentation [5] (slides 6-14) on all ways in
which Apache Geode (and/or Pivotal GemFire) has been weaved into the fabric
of Spring.

5. Finally, SDG has just answered the question on how to "*get up and
running as quickly and easily as possible*" by combing Spring Boot with
SDG's new, but complimentary *Annotation configuration model*.

For instance, to create a "managed"/Manager, Geode peer/cache server
application with an embedded Locator that you can easily and quickly
connect to using *Gfsh* in order to inspect or get/put data into the
declared (Example) Region, just define...

@SpringBootApplication
@CacheServerApplication
@EnableLocator
@EnableManager
@Import(ExampleApplicationConfiguration.class)
public class ExampleApplication {

  public static void main(String[] args) {
SpringApplication.run(ExampleApplication.class, args);
  }

  @Configuration
  static class ExampleApplicationConfiguration {

@Bean(name = *"Example"*)
LocalRegionFactoryBean exampleRegion(GemFireCache
gemfireCache) {
  LocalRegionFactoryBean exampleRegion = new
LocalRegionFactoryBean<>();
  exampleRegion.setCache(gemfireCache);
  exampleRegion.setClose(false);
  return exampleRegion;
}
  }
}


In subsequent releases, this configuration will be simplified even further
by introducing convenient configuration for Regions based on the
application domain model classes and/or when using the SD *Repository*
abstraction [6].  I.e. this configuration will become something like...

@SpringBootApplication
@CacheServerApplication
@EnableLocator
@EnableManager
@WithLocalRegions({ "Example" })
public class ExampleApplication {

  public static void main(String[] args) {
SpringApplication.run(ExampleApplication.class, args);
  }
}

The @WithLocalRegions with even allow a entityScan attribute referring to
either a class (used as the root), or package containing your application
domain objects to "determine" the required Regions. Your application domain
objects would typically be annotated with the @Region annotation anyway
when using the SD *Repository* abstraction, like so...

@Region("People")
class Person {
  ...
}

By inspecting this class, or the package (and sub-packages) this class is
in, we can determine the Regions your application will need to persist your
data.

Simple, quick and easy!

To see more information on the release, see my blog post on spring.io [7].

We are planning a series of blogs and examples to really help solidify the
use of Apache Geode in your applications.

Stay tuned for more!

-- 
-John

[1] http://search.maven.org/#search%7Cga%7C1%7Cspring-data-geode
[2] https://issues.apache.org/jira/browse/GEODE-37
[3]
http://docs.spring.io/spring-session/docs/1.2.2.RELEASE/reference/html5/#httpsession-gemfire
[4] http://projects.spring.io/spring-xd/
[5]
http://www.slideshare.net/john_blum/spring-data-and-inmemory-data-management-in-action
[6]
http://docs.spring.io/spring-data-gemfire/docs/current/reference/html/#gemfire-repositories
[7]
https://spring.io/blog/2016/10/11/spring-data-geode-1-0-0-apache-geode-incubating-m3-released

Re: Using Fix Version on JIRA

[Swapnil Bawaskar]

Hi William, please refer to this thread for how this should work for 1.0:
http://markmail.org/message/lmxtps7clvyphpg2

On Mon, Oct 10, 2016 at 10:02 PM, William Markito 
wrote:

> This may sound like a simple and not really important, but it's key to
> track issues and which release the fix is part of.
>
> It also helps in generating automated release notes through JIRA, such as
> this one [1] from M3.
>
> Since we already created a release branch for 1.0 but there is work still
> on-going in develop I'd like to encourage people to use the Fix Version
> field with even more attention so we don't lose track of where the work has
> been completed.
>
> Any thoughts or ideas on how we can approach this ?
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420&version=12335358
>
> --
>
> ~/William
>

[GitHub] incubator-geode pull request #256: Feature/geode 1532

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/256#discussion_r82900400
  
--- Diff: geode-pulse/src/main/webapp/WEB-INF/spring-security.xml ---
@@ -20,15 +20,14 @@
xmlns:context="http://www.springframework.org/schema/context";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://www.springframework.org/schema/beans
-   http://www.springframework.org/schema/beans/spring-beans.xsd
+   http://www.springframework.org/schema/beans/spring-beans-4.3.xsd
--- End diff --

We should use versionless xsd.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #256: Feature/geode 1532

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/256#discussion_r82900331
  
--- Diff: geode-pulse/build.gradle ---
@@ -68,6 +68,11 @@ dependencies {
   testCompile project(':geode-core')
   testCompile files(project(':geode-core').sourceSets.test.output)
 
+  testCompile(group: 'com.codeborne', name: 'phantomjsdriver', version: 
project.'phantomjsdriver.version') {
+  exclude module: 'selenium-remote-driver' //by artifact name
+  exclude module: 'selenium-java' //by artifact name
+  }
+
   testCompile 'org.seleniumhq.selenium:selenium-firefox-driver:' + 
project.'selenium.version'
--- End diff --

If we are not using firefox driver anymore, we can take this out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52750/#review152219
---


Fix it, then Ship it!





geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java
 (line 145)


Would you be able to remove/modify this comment a bit?  Mostly remove the 
bug number as it's not a geode number any more



geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
(line 371)


Was this intended for this diff?


- Jason Huynh


On Oct. 11, 2016, 9:53 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52750/
> ---
> 
> (Updated Oct. 11, 2016, 9:53 p.m.)
> 
> 
> Review request for geode, Jason Huynh and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changing the logic for how to we check to see if an entry may have been
> concurrently modified while an indexed query is in progress.
> 
> The new logic just has a time window, defaulting to 10 minutes. If the
> entry was changed less than 10 minutes for the query started, we will
> reevaluate the index expression to make sure the entry is still valid.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java
>  8ef82f1bee9831fa50a93f87bb9ed0b644a542b4 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  84ba926ee35638c4263a0d93a8be3fef1e2c5f7f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 46ccd47e96e75a8c4c6f3075b65a2d2447043213 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/IndexManagerJUnitTest.java
>  c7633ea05b0f8a90baf0c8f9e9849480421ebd45 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceNoReevaluationIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexAPIJUnitTest.java
>  7cc2c12f80ba4248edca9035bbdfd839d20f70ad 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java
>  1160d4bdb755e39a2a5c52fb167b86e760e0ae88 
> 
> Diff: https://reviews.apache.org/r/52750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52750/
---

Review request for geode, Jason Huynh and nabarun nag.


Repository: geode


Description
---

Changing the logic for how to we check to see if an entry may have been
concurrently modified while an indexed query is in progress.

The new logic just has a time window, defaulting to 10 minutes. If the
entry was changed less than 10 minutes for the query started, we will
reevaluate the index expression to make sure the entry is still valid.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java
 8ef82f1bee9831fa50a93f87bb9ed0b644a542b4 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
84ba926ee35638c4263a0d93a8be3fef1e2c5f7f 
  geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
46ccd47e96e75a8c4c6f3075b65a2d2447043213 
  
geode-core/src/test/java/org/apache/geode/cache/query/internal/IndexManagerJUnitTest.java
 c7633ea05b0f8a90baf0c8f9e9849480421ebd45 
  
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceNoReevaluationIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexAPIJUnitTest.java
 7cc2c12f80ba4248edca9035bbdfd839d20f70ad 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java
 1160d4bdb755e39a2a5c52fb167b86e760e0ae88 

Diff: https://reviews.apache.org/r/52750/diff/


Testing
---


Thanks,

Dan Smith

Review Request 52751: GEODE-1986: correctly set the flag indicating if cluster configuration service is running or not on a locator.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52751/
---

Review request for geode, Jared Stewart, John Blum, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-1986: correctly set the flag indicating if cluster configuration service 
is running or not on a locator.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 17303c1f984a90159f924a262d0ec843410cec16 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
d166397e3d5897347500e5447637fb4b99895388 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithEmbededLocatorDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/52751/diff/


Testing
---

prechecking running


Thanks,

Jinmei Liao

Re: Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52725/
---

(Updated Oct. 11, 2016, 8:37 p.m.)


Review request for geode, Bruce Schuchardt and Hitesh Khamesra.


Changes
---

Amended class changes to reduce formatting diffs


Repository: geode


Description
---

Amended the logic in the ClientMetadataService to more reliably increment the 
nonSingleHopsCount. This is done rather than amended each data Op that were to 
use it.

Seems to have vast amounts of formatting changes. 
Code that has changed:
ClientMetadataService : scheduleGetPRMetaData. line 455 and 537
GemFireCacheImpl : getClientMetadataService. line 1970 moved the return 
clientMetadataService to outside the sync block
SingleHopStatsDUnitTest: line 370 removed redundant logic. if/else code blocks 
exact same implementation


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java
 c863d46 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
d166397 
  
geode-core/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java
 a7c7b48 

Diff: https://reviews.apache.org/r/52725/diff/


Testing
---

Pre-checkin started


Thanks,

Udo Kohlmeyer

Re: Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52725/#review152162
---



I think it is very important not to do reformatting with other fixes.
I recommend that you redo this fix without the reformatting changes.
Reformatting should be done as a seperate ticket. If your IDE is configured
to do automatic reformatting it should be changed to not be automatic.

- Darrel Schneider


On Oct. 10, 2016, 8:34 p.m., Udo Kohlmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52725/
> ---
> 
> (Updated Oct. 10, 2016, 8:34 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Amended the logic in the ClientMetadataService to more reliably increment the 
> nonSingleHopsCount. This is done rather than amended each data Op that were 
> to use it.
> 
> Seems to have vast amounts of formatting changes. 
> Code that has changed:
> ClientMetadataService : scheduleGetPRMetaData. line 455 and 537
> GemFireCacheImpl : getClientMetadataService. line 1970 moved the return 
> clientMetadataService to outside the sync block
> SingleHopStatsDUnitTest: line 370 removed redundant logic. if/else code 
> blocks exact same implementation
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java
>  c863d46 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  d166397 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java
>  a7c7b48 
> 
> Diff: https://reviews.apache.org/r/52725/diff/
> 
> 
> Testing
> ---
> 
> Pre-checkin started
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

Re: Review Request 52575: GEODE-1962: increment notQueuedConflated stat is peeked object is unresolvable from off heap

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52575/#review152160
---


Ship it!




Ship It!

- Dan Smith


On Oct. 5, 2016, 9:28 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52575/
> ---
> 
> (Updated Oct. 5, 2016, 9:28 p.m.)
> 
> 
> Review request for geode, nabarun nag and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> There is a scenario where the stats do not reflect an event being conflated.  
> After peeking the original object from the bucketRegionQueue, when we try to 
> resolve from off heap, if the resolved value is null, we just continue.  
> Instead we should behave similar to the bucketRegionQueue peek method, where 
> it increments the stat if the object itself is null.
> 
> Minor refactoring and changing of method visibility for testing purposes
> Removed some unused code
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
>  1a9b126 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java
>  f1d4408 
> 
> Diff: https://reviews.apache.org/r/52575/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 52724: GEODE-1570: improve rest security framework

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52724/#review152154
---


Ship it!




I like the new annotations!  The controllers can be cleaned up a bit by 
removing unnecessary if statements checking the log level:
```
if (logger.isDebugEnabled()) {
...
}
```

(See 
https://logging.apache.org/log4j/2.x/performance.html#asyncLoggingWithParams)

- Jared Stewart


On Oct. 11, 2016, 3:56 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52724/
> ---
> 
> (Updated Oct. 11, 2016, 3:56 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * use annotations for authorization
> * consolidate the test classes
> * delete unused classes
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
>  7d232ce6332175287c02af46b4b83309f41f66f1 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityEndpointsDUnitTest.java
>  149a905af9d0ed0fb88b6a23d08d598546cf29a1 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  a515de5b3a08eff3d78aed31c22b374cd51dbffe 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  d645bbf2f37510378b39576f56239bc1aa5c9a07 
>   geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java 
> d6be5402fbee9d4a18c3e143384fed2e83acbda7 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
>  ee5d7146011af843c2d403bc67cd3fa5aa836547 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
>  54dd9e51f9a44183aea10378e243f96ba9d4b456 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
>  232f0345e7db4503500ed03f1b0097ec830e6d6c 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
>  8cec1101b355e703d882bae8591c56c52f74d12e 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
>  c05845ad612d7ad43656af099c5c50dafb3c9bb8 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
>  2df95aac231bf947cac7615069a28f65c50dd6fa 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthentication.java
>  c4226f6ab46b42ae3884365804df1d2010cc9de3 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java
>  c482047cb49d5d06f726d52e9157bd91c7b8ef72 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthority.java
>  fd216287e663db8e738683784da5461f5f7d8c9c 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52724/diff/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Review Request 52742: GEODE-1979: refactor tests using LocatorServerConfigurationRule

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52742/
---

Review request for geode.


Repository: geode


Description
---

GEODE-1979: refactor tests using LocatorServerConfigurationRule


Diffs
-

  
geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
 dae062acb980a93d00b5498e6ac99eda97918a39 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerConfigurationRule.java
 2fa262c732662becbba0eb48ce47e7d88b0fec5c 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
 f837530e2bcd6026102d5a1267a48ac8b37578fe 

Diff: https://reviews.apache.org/r/52742/diff/


Testing
---

the affected tests


Thanks,

Jinmei Liao

[GitHub] incubator-geode pull request #256: Feature/geode 1532

[jaredjstewart]

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/256

Feature/geode 1532

GEODE-999: Convert pulse uiTests to phantomJS.
GEODE-1966: Prevent unauthorized users from viewing pulseVersion details.
GEODE-1532: Fix Pulse clickjacking vulnerability.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-1532

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #256


commit 96f10a5b2aad7c0a2b3c34d16c0cffdca7c1156e
Author: Jared Stewart 
Date:   2016-10-03T21:15:59Z

GEODE-999: All unignored UITests now pass

commit ed66a2dab64f3adbfb19b66f2daf8f367cdd8002
Author: Jared Stewart 
Date:   2016-10-05T19:09:12Z

GEODE-999: Converted from Firefox driver to PhantomJS driver to run UITests 
in headless mode

commit a7d537fee7a70ca4b696b7c87ccb9873d4f91ecb
Author: Jared Stewart 
Date:   2016-10-10T18:50:42Z

Moved pulse ui tests into their own package.

commit 0b9e625dc866fff1281255095d632f0119ae4086
Author: Jared Stewart 
Date:   2016-10-10T23:59:07Z

GEODE-1966: Unauthorized users cannot access pulseVersion details

commit 655f2286efe3218f419b614d9e4ceb15c6cfe505
Author: Jared Stewart 
Date:   2016-10-11T01:48:01Z

GEODE-1532: Fix Pulse Clickjacking vuln.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : Geode-release #33

[Apache Jenkins Server]

See