Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Dave Barnes]

I'm a fan of PDFs, too, for their searchability among other things.
There's no process in place, yet, for generating a good-looking PDF from
the Markdown sources. Something to put on the to-do list.
Right now, HTML format is the best presentation.

On Monday, October 17, 2016, William Markito  wrote:

> IHMO, it would be really nice to ship a PDF version of the docs.
>
> About the examples, if we could package and ship sources only for that
> module, that would be cool as well.
>
>
>
> On Mon, Oct 17, 2016 at 5:21 PM, Dan Smith  > wrote:
>
> > Along these lines, should we distributing the docs with the binary
> release?
> > Or maybe just providing a link to them? The README.md shipped with
> 1.0.RC2
> > points to http://geode.docs.pivotal.io/ .
> >
> > What about geode-examples? Should that be part of the binary release?
> >
> > -Dan
> >
> > On Mon, Oct 17, 2016 at 2:21 PM, Joey McAllister  >
> > wrote:
> >
> > > @Roman: Nothing that I can think of, apart from giving the community
> time
> > > to offer feedback here (which, it looks like, is all positive). William
> > > Markito and I were able to build and test a local version of the
> website
> > > with the docs included.
> > >
> > > Based on the +1s here, I'd like to go ahead and push the current docs
> to
> > > the website. I'll also document the process in a README.
> > >
> > > On Mon, Oct 17, 2016 at 12:49 PM Roman Shaposhnik <
> ro...@shaposhnik.org >
> > > wrote:
> > >
> > > > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker  >
> > > wrote:
> > > > > Since the geode docs have now been merged to the develop branch,
> > let’s
> > > > start
> > > > > hosting them on http://geode.apache.org.  Thoughts?
> > > >
> > > > Huge +1! Anything stopping you from pushing the first update and
> start
> > > > maintaining
> > > > it a'la Hadoop:
> > > > https://hadoop.apache.org/docs/
> > > > ?
> > > >
> > > > Thanks,
> > > > Roman.
> > > >
> > >
> >
>
>
>
> --
>
> ~/William
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[William Markito]

IHMO, it would be really nice to ship a PDF version of the docs.

About the examples, if we could package and ship sources only for that
module, that would be cool as well.



On Mon, Oct 17, 2016 at 5:21 PM, Dan Smith  wrote:

> Along these lines, should we distributing the docs with the binary release?
> Or maybe just providing a link to them? The README.md shipped with 1.0.RC2
> points to http://geode.docs.pivotal.io/ .
>
> What about geode-examples? Should that be part of the binary release?
>
> -Dan
>
> On Mon, Oct 17, 2016 at 2:21 PM, Joey McAllister 
> wrote:
>
> > @Roman: Nothing that I can think of, apart from giving the community time
> > to offer feedback here (which, it looks like, is all positive). William
> > Markito and I were able to build and test a local version of the website
> > with the docs included.
> >
> > Based on the +1s here, I'd like to go ahead and push the current docs to
> > the website. I'll also document the process in a README.
> >
> > On Mon, Oct 17, 2016 at 12:49 PM Roman Shaposhnik 
> > wrote:
> >
> > > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker 
> > wrote:
> > > > Since the geode docs have now been merged to the develop branch,
> let’s
> > > start
> > > > hosting them on http://geode.apache.org.  Thoughts?
> > >
> > > Huge +1! Anything stopping you from pushing the first update and start
> > > maintaining
> > > it a'la Hadoop:
> > > https://hadoop.apache.org/docs/
> > > ?
> > >
> > > Thanks,
> > > Roman.
> > >
> >
>



-- 

~/William

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Dan Smith]

Along these lines, should we distributing the docs with the binary release?
Or maybe just providing a link to them? The README.md shipped with 1.0.RC2
points to http://geode.docs.pivotal.io/ .

What about geode-examples? Should that be part of the binary release?

-Dan

On Mon, Oct 17, 2016 at 2:21 PM, Joey McAllister 
wrote:

> @Roman: Nothing that I can think of, apart from giving the community time
> to offer feedback here (which, it looks like, is all positive). William
> Markito and I were able to build and test a local version of the website
> with the docs included.
>
> Based on the +1s here, I'd like to go ahead and push the current docs to
> the website. I'll also document the process in a README.
>
> On Mon, Oct 17, 2016 at 12:49 PM Roman Shaposhnik 
> wrote:
>
> > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker 
> wrote:
> > > Since the geode docs have now been merged to the develop branch, let’s
> > start
> > > hosting them on http://geode.apache.org.  Thoughts?
> >
> > Huge +1! Anything stopping you from pushing the first update and start
> > maintaining
> > it a'la Hadoop:
> > https://hadoop.apache.org/docs/
> > ?
> >
> > Thanks,
> > Roman.
> >
>

Re: Review Request 52963: GEODE-388: Deprecating DynamicRegionFactory

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52963/#review152995
---


Ship it!




Ship It!

- Jinmei Liao


On Oct. 18, 2016, 12:06 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52963/
> ---
> 
> (Updated Oct. 18, 2016, 12:06 a.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Marking DynamicRegionFactory as deprecated.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 3cfa73b840785cab94d4ca54aac1338304a20f30 
> 
> Diff: https://reviews.apache.org/r/52963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Mark Bretl]

+1

- Checked signatures
- Ran gfsh: ./gfsh version --full
- Built from source
- Verified Commit ID atches with source tar ball
- Reviewed BUILDING.md

Under 'Build from Source on Windows' in BUILDING.md it states minimum
Gradle is 2.12, when the gradle.properites file has 2.14.1. When run with
2.12, the build fails due to our Gradle version check. I am not sure how
many people will try to build from source on Windows, but it is an issue.
The workaround is to download the 2.14.1 version of Gradle.Its not a big
deal, only a small issue out of the box with Windows. BUILDING.md needs to
be updated.

Also, a big +1 for the binary tar ball for 1.0 is 23MB smaller than M3.

--Mark

On Mon, Oct 17, 2016 at 3:54 PM, Karen Miller  wrote:

> @Anil:
> Without the fix that GEODE-1883 should bring, client caches only have 1 way
> of setting
> the security properties: do it via the callback.
>
> Once the fix is in, client caches should again have 2 ways of setting the
> security
> properties: 1.  do it via the callback, or 2. place in a
> security.properties file.
>
> The docs on the release/1.0.0-incubating branch (and therefore in the
> release candidate)
> list the 2 ways of setting the security properties.  However, GEODE-1883
> has not been
> fixed for the release candidate, so this documentation detail is wrong in
> the release
> candidate.
>
> The docs in the develop branch list only the 1 way.
>
> Does this explanation help?
>
> On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade 
> wrote:
>
> > +1 for release...
> >
> > On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade 
> > wrote:
> >
> > > Hi Karen,
> > >
> > > The fix still keeps the doc stating:
> > > "a client will need to set its credential, composed of the two
> properties
> > > `security-username` and `security-password`."
> > >
> > > What i see is, additional doc about setting the auth properties using
> > > callbacks
> > >
> > > Am i missing anything?
> > >
> > > -Anil.
> > >
> > >
> > >
> > >
> > > On Mon, Oct 17, 2016 at 1:12 PM, Karen Miller 
> > wrote:
> > >
> > >> +0
> > >>
> > >> With GEODE-1883 being moved to a subsequent release, the just-donated
> > docs
> > >> are not-quite current with respect to how a client cache may set its
> > >> credentials for
> > >> authentication.  I put in a fix for this on the develop branch:
> > >> https://github.com/apache/incubator-geode/commit/f1df6fc5920
> > >> d0d1eebd210e816e61ad44074d39d
> > >>
> > >> If there were to be a third release candidate, a cherry pick of this
> > >> commit
> > >> will correct the
> > >> 1.0.0-incubating documentation.
> > >>
> > >>
> > >>
> > >> On Mon, Oct 17, 2016 at 12:10 PM, Dan Smith 
> wrote:
> > >>
> > >> > +1
> > >> >
> > >> > Checked
> > >> >   * signatures
> > >> >   * maven repo with simple sample app
> > >> >   * command line test through gfsh
> > >> >   * built the source
> > >> >
> > >> > Checked it with this thing:
> > >> > https://github.com/upthewaterspout/geode-release-check
> > >> >
> > >> > On Mon, Oct 17, 2016 at 11:55 AM, William Markito <
> > wmark...@pivotal.io>
> > >> > wrote:
> > >> >
> > >> > > +1
> > >> > >
> > >> > >  Checked SHA, signatures, build/run, sample app and command line
> > >> testing
> > >> > > through gfsh.
> > >> > >
> > >> > > On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund 
> > wrote:
> > >> > >
> > >> > > > +1 I think we should target GEODE-2004 and GEODE-1883 for a
> point
> > >> > release
> > >> > > > after 1.0.0
> > >> > > >
> > >> > > >
> > >> > > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao  >
> > >> > wrote:
> > >> > > >
> > >> > > > > +0
> > >> > > > >
> > >> > > > > This candidate does not include the fix for GEODE-2004 and
> > >> > GEODE-1883.
> > >> > > > It's
> > >> > > > > not a must fix though.
> > >> > > > >
> > >> > > > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker <
> > aba...@pivotal.io
> > >> >
> > >> > > > wrote:
> > >> > > > >
> > >> > > > > > +1
> > >> > > > > >
> > >> > > > > > * Verified sha’s
> > >> > > > > > * Verified signatures
> > >> > > > > > * Verified tag signature
> > >> > > > > > * Build and run from src distro
> > >> > > > > > * Checked src distro for binaries
> > >> > > > > > * Run some examples from mvn repo
> > >> > > > > > * Reviewed LICENSE and NOTICE
> > >> > > > > >
> > >> > > > > > Anthony
> > >> > > > > >
> > >> > > > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <
> > >> > > sbawas...@pivotal.io>
> > >> > > > > > wrote:
> > >> > > > > > >
> > >> > > > > > > All,
> > >> > > > > > >
> > >> > > > > > > This is the second release candidate for Apache Geode,
> > version
> > >> > > > > > > 1.0.0-incubating. I discarded the first release candidate
> > >> since
> > >> > my
> > >> > > > pgp
> > >> > > > > > > key was missing from the KEYS file.
> > >> > > > > > > Thanks to all the community members to drive towards this
> > >> > > milestone!
> > >> > > > > > >
> > >> > > > > > > It fixes the following issues:
> > >> > > > > > >
> > >> > > > > > >https://issues.apache.org/jira/secure/Rel

Review Request 52963: GEODE-388: Deprecating DynamicRegionFactory

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52963/
---

Review request for geode and Darrel Schneider.


Repository: geode


Description
---

Marking DynamicRegionFactory as deprecated.


Diffs
-

  geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
3cfa73b840785cab94d4ca54aac1338304a20f30 

Diff: https://reviews.apache.org/r/52963/diff/


Testing
---


Thanks,

Dan Smith

Re: Review Request 52891: GEODE-538: Add check for persistent data recovery

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52891/
---

(Updated Oct. 17, 2016, 11:15 p.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, Scott 
Jewell, and Dan Smith.


Repository: geode


Description
---

PartitionedRegion.getNodeForBucketReadOrLoad can return an invalid node
if persistent data recovery is in process and a get() targets a bucket
that
hasn't been recoverd yet. This can result in returning an incorrect
value (null) or throwing ConflictingPersistentDataException from a get()
or put() on the region.

This change adds a check for persistent recovery to be completed
before creating the new bucket. If recovery isn't complete then the
operation on the region will fail with a PartitionOfflineException.

Queries on a region while persistent recovery is in progress can also
result in incorrect results so a similar check is added to
DefaultQuery.checkQueryOnPR.

New DUnit tests added for gets, puts, and queries for cases where persistent
colocated child regions haven't been started and where the child region
has been started but persistent recovery is still in progress when
the region operation is attempted.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/cache/query/Query.java e27687d 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/DefaultQuery.java
 58df390 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PRHARedundancyProvider.java
 cfedb67 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java 
baab79f 
  geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
8bfdd68 
  
geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRBasicQueryDUnitTest.java
 8ef907a 
  
geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryDUnitHelper.java
 cfb4190 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 0a25228 

Diff: https://reviews.apache.org/r/52891/diff/


Testing
---

precheckin


Thanks,

Ken Howe

Re: Review Request 52956: GEODE-2011: add FlakyTest category to testNonPersistentServerRestartAutoSerializer

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52956/#review152982
---


Ship it!




Ship It!

- Bruce Schuchardt


On Oct. 17, 2016, 8:03 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52956/
> ---
> 
> (Updated Oct. 17, 2016, 8:03 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2011
> https://issues.apache.org/jira/browse/GEODE-2011
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2011: add FlakyTest category to 
> testNonPersistentServerRestartAutoSerializer
> 
> 
> Diffs
> -
> 
>   geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java 
> 1afb1ad 
> 
> Diff: https://reviews.apache.org/r/52956/diff/
> 
> 
> Testing
> ---
> 
> build
> PdxClientServerDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Karen Miller]

@Anil:
Without the fix that GEODE-1883 should bring, client caches only have 1 way
of setting
the security properties: do it via the callback.

Once the fix is in, client caches should again have 2 ways of setting the
security
properties: 1.  do it via the callback, or 2. place in a
security.properties file.

The docs on the release/1.0.0-incubating branch (and therefore in the
release candidate)
list the 2 ways of setting the security properties.  However, GEODE-1883
has not been
fixed for the release candidate, so this documentation detail is wrong in
the release
candidate.

The docs in the develop branch list only the 1 way.

Does this explanation help?

On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade 
wrote:

> +1 for release...
>
> On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade 
> wrote:
>
> > Hi Karen,
> >
> > The fix still keeps the doc stating:
> > "a client will need to set its credential, composed of the two properties
> > `security-username` and `security-password`."
> >
> > What i see is, additional doc about setting the auth properties using
> > callbacks
> >
> > Am i missing anything?
> >
> > -Anil.
> >
> >
> >
> >
> > On Mon, Oct 17, 2016 at 1:12 PM, Karen Miller 
> wrote:
> >
> >> +0
> >>
> >> With GEODE-1883 being moved to a subsequent release, the just-donated
> docs
> >> are not-quite current with respect to how a client cache may set its
> >> credentials for
> >> authentication.  I put in a fix for this on the develop branch:
> >> https://github.com/apache/incubator-geode/commit/f1df6fc5920
> >> d0d1eebd210e816e61ad44074d39d
> >>
> >> If there were to be a third release candidate, a cherry pick of this
> >> commit
> >> will correct the
> >> 1.0.0-incubating documentation.
> >>
> >>
> >>
> >> On Mon, Oct 17, 2016 at 12:10 PM, Dan Smith  wrote:
> >>
> >> > +1
> >> >
> >> > Checked
> >> >   * signatures
> >> >   * maven repo with simple sample app
> >> >   * command line test through gfsh
> >> >   * built the source
> >> >
> >> > Checked it with this thing:
> >> > https://github.com/upthewaterspout/geode-release-check
> >> >
> >> > On Mon, Oct 17, 2016 at 11:55 AM, William Markito <
> wmark...@pivotal.io>
> >> > wrote:
> >> >
> >> > > +1
> >> > >
> >> > >  Checked SHA, signatures, build/run, sample app and command line
> >> testing
> >> > > through gfsh.
> >> > >
> >> > > On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund 
> wrote:
> >> > >
> >> > > > +1 I think we should target GEODE-2004 and GEODE-1883 for a point
> >> > release
> >> > > > after 1.0.0
> >> > > >
> >> > > >
> >> > > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao 
> >> > wrote:
> >> > > >
> >> > > > > +0
> >> > > > >
> >> > > > > This candidate does not include the fix for GEODE-2004 and
> >> > GEODE-1883.
> >> > > > It's
> >> > > > > not a must fix though.
> >> > > > >
> >> > > > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker <
> aba...@pivotal.io
> >> >
> >> > > > wrote:
> >> > > > >
> >> > > > > > +1
> >> > > > > >
> >> > > > > > * Verified sha’s
> >> > > > > > * Verified signatures
> >> > > > > > * Verified tag signature
> >> > > > > > * Build and run from src distro
> >> > > > > > * Checked src distro for binaries
> >> > > > > > * Run some examples from mvn repo
> >> > > > > > * Reviewed LICENSE and NOTICE
> >> > > > > >
> >> > > > > > Anthony
> >> > > > > >
> >> > > > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <
> >> > > sbawas...@pivotal.io>
> >> > > > > > wrote:
> >> > > > > > >
> >> > > > > > > All,
> >> > > > > > >
> >> > > > > > > This is the second release candidate for Apache Geode,
> version
> >> > > > > > > 1.0.0-incubating. I discarded the first release candidate
> >> since
> >> > my
> >> > > > pgp
> >> > > > > > > key was missing from the KEYS file.
> >> > > > > > > Thanks to all the community members to drive towards this
> >> > > milestone!
> >> > > > > > >
> >> > > > > > > It fixes the following issues:
> >> > > > > > >
> >> > > > > > >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> > > > > > projectId=12318420&version=12332343
> >> > > > > > >
> >> > > > > > > *** Please download, test and vote by Wednesday, October 19,
> >> 0800
> >> > > hrs
> >> > > > > > > US Pacific.
> >> > > > > > >
> >> > > > > > > Note that we are voting upon the source (tag):
> >> > > > > > >   rel/1.0.0-incubating.RC2
> >> > > > > > >  >> > > > > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> >> > > > > > >
> >> > > > > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> >> > > > > > >  >> > > > > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1
> c975870753>
> >> > > > > > >
> >> > > > > > > Source and binary files:
> >> > > > > > >   https://dist.apache.org/repos/
> dist/dev/incubator/geode/1.0.
> >> > > > > > 0-incubating.RC2/
> >> > > > > > >
> >> > > > > > > The documentation on how to install and use Apache Geode are
> >> > hosted
> >> > > > > > > on pivotal.

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Anilkumar Gingade]

+1 for release...

On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade 
wrote:

> Hi Karen,
>
> The fix still keeps the doc stating:
> "a client will need to set its credential, composed of the two properties
> `security-username` and `security-password`."
>
> What i see is, additional doc about setting the auth properties using
> callbacks
>
> Am i missing anything?
>
> -Anil.
>
>
>
>
> On Mon, Oct 17, 2016 at 1:12 PM, Karen Miller  wrote:
>
>> +0
>>
>> With GEODE-1883 being moved to a subsequent release, the just-donated docs
>> are not-quite current with respect to how a client cache may set its
>> credentials for
>> authentication.  I put in a fix for this on the develop branch:
>> https://github.com/apache/incubator-geode/commit/f1df6fc5920
>> d0d1eebd210e816e61ad44074d39d
>>
>> If there were to be a third release candidate, a cherry pick of this
>> commit
>> will correct the
>> 1.0.0-incubating documentation.
>>
>>
>>
>> On Mon, Oct 17, 2016 at 12:10 PM, Dan Smith  wrote:
>>
>> > +1
>> >
>> > Checked
>> >   * signatures
>> >   * maven repo with simple sample app
>> >   * command line test through gfsh
>> >   * built the source
>> >
>> > Checked it with this thing:
>> > https://github.com/upthewaterspout/geode-release-check
>> >
>> > On Mon, Oct 17, 2016 at 11:55 AM, William Markito 
>> > wrote:
>> >
>> > > +1
>> > >
>> > >  Checked SHA, signatures, build/run, sample app and command line
>> testing
>> > > through gfsh.
>> > >
>> > > On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund  wrote:
>> > >
>> > > > +1 I think we should target GEODE-2004 and GEODE-1883 for a point
>> > release
>> > > > after 1.0.0
>> > > >
>> > > >
>> > > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao 
>> > wrote:
>> > > >
>> > > > > +0
>> > > > >
>> > > > > This candidate does not include the fix for GEODE-2004 and
>> > GEODE-1883.
>> > > > It's
>> > > > > not a must fix though.
>> > > > >
>> > > > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker > >
>> > > > wrote:
>> > > > >
>> > > > > > +1
>> > > > > >
>> > > > > > * Verified sha’s
>> > > > > > * Verified signatures
>> > > > > > * Verified tag signature
>> > > > > > * Build and run from src distro
>> > > > > > * Checked src distro for binaries
>> > > > > > * Run some examples from mvn repo
>> > > > > > * Reviewed LICENSE and NOTICE
>> > > > > >
>> > > > > > Anthony
>> > > > > >
>> > > > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <
>> > > sbawas...@pivotal.io>
>> > > > > > wrote:
>> > > > > > >
>> > > > > > > All,
>> > > > > > >
>> > > > > > > This is the second release candidate for Apache Geode, version
>> > > > > > > 1.0.0-incubating. I discarded the first release candidate
>> since
>> > my
>> > > > pgp
>> > > > > > > key was missing from the KEYS file.
>> > > > > > > Thanks to all the community members to drive towards this
>> > > milestone!
>> > > > > > >
>> > > > > > > It fixes the following issues:
>> > > > > > >
>> > > > > > >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > > > > > projectId=12318420&version=12332343
>> > > > > > >
>> > > > > > > *** Please download, test and vote by Wednesday, October 19,
>> 0800
>> > > hrs
>> > > > > > > US Pacific.
>> > > > > > >
>> > > > > > > Note that we are voting upon the source (tag):
>> > > > > > >   rel/1.0.0-incubating.RC2
>> > > > > > > > > > > > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
>> > > > > > >
>> > > > > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
>> > > > > > > > > > > > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753>
>> > > > > > >
>> > > > > > > Source and binary files:
>> > > > > > >   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
>> > > > > > 0-incubating.RC2/
>> > > > > > >
>> > > > > > > The documentation on how to install and use Apache Geode are
>> > hosted
>> > > > > > > on pivotal.io:
>> > > > > > >   http://geode.docs.pivotal.io
>> > > > > > >
>> > > > > > > Maven staging repo:
>> > > > > > >   https://repository.apache.org/content/repositories/
>> > > > > > orgapachegeode-1014/
>> > > > > > >
>> > > > > > > Geode's KEYS file containing PGP keys we use to sign the
>> release:
>> > > > > > >   https://github.com/apache/incubator-geode/blob/release/
>> > > > > > 1.0.0-incubating/KEYS
>> > > > > > >
>> > > > > > > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
>> > > > > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9
>> 02DB
>> > > > > > >
>> > > > > > > Thanks,
>> > > > > > >
>> > > > > > > Swapnil.
>> > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > > > --
>> > > > > Cheers
>> > > > >
>> > > > > Jinmei
>> > > > >
>> > > >
>> > >
>> > >
>> > >
>> > > --
>> > >
>> > > ~/William
>> > >
>> >
>>
>
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Anilkumar Gingade]

Hi Karen,

The fix still keeps the doc stating:
"a client will need to set its credential, composed of the two properties
`security-username` and `security-password`."

What i see is, additional doc about setting the auth properties using
callbacks

Am i missing anything?

-Anil.




On Mon, Oct 17, 2016 at 1:12 PM, Karen Miller  wrote:

> +0
>
> With GEODE-1883 being moved to a subsequent release, the just-donated docs
> are not-quite current with respect to how a client cache may set its
> credentials for
> authentication.  I put in a fix for this on the develop branch:
> https://github.com/apache/incubator-geode/commit/
> f1df6fc5920d0d1eebd210e816e61ad44074d39d
>
> If there were to be a third release candidate, a cherry pick of this commit
> will correct the
> 1.0.0-incubating documentation.
>
>
>
> On Mon, Oct 17, 2016 at 12:10 PM, Dan Smith  wrote:
>
> > +1
> >
> > Checked
> >   * signatures
> >   * maven repo with simple sample app
> >   * command line test through gfsh
> >   * built the source
> >
> > Checked it with this thing:
> > https://github.com/upthewaterspout/geode-release-check
> >
> > On Mon, Oct 17, 2016 at 11:55 AM, William Markito 
> > wrote:
> >
> > > +1
> > >
> > >  Checked SHA, signatures, build/run, sample app and command line
> testing
> > > through gfsh.
> > >
> > > On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund  wrote:
> > >
> > > > +1 I think we should target GEODE-2004 and GEODE-1883 for a point
> > release
> > > > after 1.0.0
> > > >
> > > >
> > > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao 
> > wrote:
> > > >
> > > > > +0
> > > > >
> > > > > This candidate does not include the fix for GEODE-2004 and
> > GEODE-1883.
> > > > It's
> > > > > not a must fix though.
> > > > >
> > > > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker 
> > > > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > * Verified sha’s
> > > > > > * Verified signatures
> > > > > > * Verified tag signature
> > > > > > * Build and run from src distro
> > > > > > * Checked src distro for binaries
> > > > > > * Run some examples from mvn repo
> > > > > > * Reviewed LICENSE and NOTICE
> > > > > >
> > > > > > Anthony
> > > > > >
> > > > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <
> > > sbawas...@pivotal.io>
> > > > > > wrote:
> > > > > > >
> > > > > > > All,
> > > > > > >
> > > > > > > This is the second release candidate for Apache Geode, version
> > > > > > > 1.0.0-incubating. I discarded the first release candidate since
> > my
> > > > pgp
> > > > > > > key was missing from the KEYS file.
> > > > > > > Thanks to all the community members to drive towards this
> > > milestone!
> > > > > > >
> > > > > > > It fixes the following issues:
> > > > > > >
> > > > > > >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > > projectId=12318420&version=12332343
> > > > > > >
> > > > > > > *** Please download, test and vote by Wednesday, October 19,
> 0800
> > > hrs
> > > > > > > US Pacific.
> > > > > > >
> > > > > > > Note that we are voting upon the source (tag):
> > > > > > >   rel/1.0.0-incubating.RC2
> > > > > > >  > > > > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> > > > > > >
> > > > > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> > > > > > >  > > > > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753>
> > > > > > >
> > > > > > > Source and binary files:
> > > > > > >   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> > > > > > 0-incubating.RC2/
> > > > > > >
> > > > > > > The documentation on how to install and use Apache Geode are
> > hosted
> > > > > > > on pivotal.io:
> > > > > > >   http://geode.docs.pivotal.io
> > > > > > >
> > > > > > > Maven staging repo:
> > > > > > >   https://repository.apache.org/content/repositories/
> > > > > > orgapachegeode-1014/
> > > > > > >
> > > > > > > Geode's KEYS file containing PGP keys we use to sign the
> release:
> > > > > > >   https://github.com/apache/incubator-geode/blob/release/
> > > > > > 1.0.0-incubating/KEYS
> > > > > > >
> > > > > > > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> > > > > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Swapnil.
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Cheers
> > > > >
> > > > > Jinmei
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > ~/William
> > >
> >
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Joey McAllister]

@Roman: Nothing that I can think of, apart from giving the community time
to offer feedback here (which, it looks like, is all positive). William
Markito and I were able to build and test a local version of the website
with the docs included.

Based on the +1s here, I'd like to go ahead and push the current docs to
the website. I'll also document the process in a README.

On Mon, Oct 17, 2016 at 12:49 PM Roman Shaposhnik 
wrote:

> On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker  wrote:
> > Since the geode docs have now been merged to the develop branch, let’s
> start
> > hosting them on http://geode.apache.org.  Thoughts?
>
> Huge +1! Anything stopping you from pushing the first update and start
> maintaining
> it a'la Hadoop:
> https://hadoop.apache.org/docs/
> ?
>
> Thanks,
> Roman.
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Mark Bretl]

+1

On Mon, Oct 17, 2016 at 2:04 PM, Kirk Lund  wrote:

> +1
>
>
> On Mon, Oct 17, 2016 at 12:49 PM, Roman Shaposhnik 
> wrote:
>
> > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker 
> wrote:
> > > Since the geode docs have now been merged to the develop branch, let’s
> > start
> > > hosting them on http://geode.apache.org.  Thoughts?
> >
> > Huge +1! Anything stopping you from pushing the first update and start
> > maintaining
> > it a'la Hadoop:
> > https://hadoop.apache.org/docs/
> > ?
> >
> > Thanks,
> > Roman.
> >
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Kirk Lund]

+1


On Mon, Oct 17, 2016 at 12:49 PM, Roman Shaposhnik 
wrote:

> On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker  wrote:
> > Since the geode docs have now been merged to the develop branch, let’s
> start
> > hosting them on http://geode.apache.org.  Thoughts?
>
> Huge +1! Anything stopping you from pushing the first update and start
> maintaining
> it a'la Hadoop:
> https://hadoop.apache.org/docs/
> ?
>
> Thanks,
> Roman.
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Niall Pemberton]

+1

:)

Niall

On Mon, Oct 17, 2016 at 6:57 PM, Anthony Baker  wrote:

> Since the geode docs have now been merged to the develop branch, let’s
> start hosting them on http://geode.apache.org.  Thoughts?
>
> Anthony
>
>
> On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> wrote:
>
>
> The documentation on how to install and use Apache Geode are hosted
> on pivotal.io:
>   http://geode.docs.pivotal.io
>
>
>

Re: Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52949/#review152942
---


Ship it!




Ship It!

- Kevin Duling


On Oct. 17, 2016, 12:18 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52949/
> ---
> 
> (Updated Oct. 17, 2016, 12:18 p.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kevin Duling.
> 
> 
> Bugs: GEODE-2009
> https://issues.apache.org/jira/browse/GEODE-2009
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2009: apply FlakyTest category to 
> testCreateAlterDestroyUpdatesSharedConfig
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
>  5fa06d9 
> 
> Diff: https://reviews.apache.org/r/52949/diff/
> 
> 
> Testing
> ---
> 
> build, CreateAlterDestroyRegionCommandsDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 52937: GEODE-2007: fix unchecked warnings

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52937/#review152946
---


Ship it!




Huzzah for reducing warnings!

- Kevin Duling


On Oct. 17, 2016, 12:52 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52937/
> ---
> 
> (Updated Oct. 17, 2016, 12:52 p.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kevin Duling.
> 
> 
> Bugs: GEODE-2007
> https://issues.apache.org/jira/browse/GEODE-2007
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Fix the gradle build warnings for "uses unchecked or unsafe operations"
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-tomcat7/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession7.java
>  0df05ff 
>   
> extensions/geode-modules-tomcat8/src/test/java/org/apache/geode/modules/session/Tomcat8SessionsClientServerDUnitTest.java
>  8b29048 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  6c195e7 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ha/HARegionQueue.java
>  027a1b5 
>   
> geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DeltaPropagationWithCQDUnitTest.java
>  3990265 
>   
> geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java
>  0b48e16 
> 
> Diff: https://reviews.apache.org/r/52937/diff/
> 
> 
> Testing
> ---
> 
> build
> modified tests
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 52956: GEODE-2011: add FlakyTest category to testNonPersistentServerRestartAutoSerializer

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52956/#review152945
---


Ship it!




Ship It!

- Kevin Duling


On Oct. 17, 2016, 1:03 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52956/
> ---
> 
> (Updated Oct. 17, 2016, 1:03 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2011
> https://issues.apache.org/jira/browse/GEODE-2011
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2011: add FlakyTest category to 
> testNonPersistentServerRestartAutoSerializer
> 
> 
> Diffs
> -
> 
>   geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java 
> 1afb1ad 
> 
> Diff: https://reviews.apache.org/r/52956/diff/
> 
> 
> Testing
> ---
> 
> build
> PdxClientServerDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Karen Miller]

+0

With GEODE-1883 being moved to a subsequent release, the just-donated docs
are not-quite current with respect to how a client cache may set its
credentials for
authentication.  I put in a fix for this on the develop branch:
https://github.com/apache/incubator-geode/commit/f1df6fc5920d0d1eebd210e816e61ad44074d39d

If there were to be a third release candidate, a cherry pick of this commit
will correct the
1.0.0-incubating documentation.



On Mon, Oct 17, 2016 at 12:10 PM, Dan Smith  wrote:

> +1
>
> Checked
>   * signatures
>   * maven repo with simple sample app
>   * command line test through gfsh
>   * built the source
>
> Checked it with this thing:
> https://github.com/upthewaterspout/geode-release-check
>
> On Mon, Oct 17, 2016 at 11:55 AM, William Markito 
> wrote:
>
> > +1
> >
> >  Checked SHA, signatures, build/run, sample app and command line testing
> > through gfsh.
> >
> > On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund  wrote:
> >
> > > +1 I think we should target GEODE-2004 and GEODE-1883 for a point
> release
> > > after 1.0.0
> > >
> > >
> > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao 
> wrote:
> > >
> > > > +0
> > > >
> > > > This candidate does not include the fix for GEODE-2004 and
> GEODE-1883.
> > > It's
> > > > not a must fix though.
> > > >
> > > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker 
> > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > * Verified sha’s
> > > > > * Verified signatures
> > > > > * Verified tag signature
> > > > > * Build and run from src distro
> > > > > * Checked src distro for binaries
> > > > > * Run some examples from mvn repo
> > > > > * Reviewed LICENSE and NOTICE
> > > > >
> > > > > Anthony
> > > > >
> > > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <
> > sbawas...@pivotal.io>
> > > > > wrote:
> > > > > >
> > > > > > All,
> > > > > >
> > > > > > This is the second release candidate for Apache Geode, version
> > > > > > 1.0.0-incubating. I discarded the first release candidate since
> my
> > > pgp
> > > > > > key was missing from the KEYS file.
> > > > > > Thanks to all the community members to drive towards this
> > milestone!
> > > > > >
> > > > > > It fixes the following issues:
> > > > > >
> > > > > >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > projectId=12318420&version=12332343
> > > > > >
> > > > > > *** Please download, test and vote by Wednesday, October 19, 0800
> > hrs
> > > > > > US Pacific.
> > > > > >
> > > > > > Note that we are voting upon the source (tag):
> > > > > >   rel/1.0.0-incubating.RC2
> > > > > >  > > > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> > > > > >
> > > > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> > > > > >  > > > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753>
> > > > > >
> > > > > > Source and binary files:
> > > > > >   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> > > > > 0-incubating.RC2/
> > > > > >
> > > > > > The documentation on how to install and use Apache Geode are
> hosted
> > > > > > on pivotal.io:
> > > > > >   http://geode.docs.pivotal.io
> > > > > >
> > > > > > Maven staging repo:
> > > > > >   https://repository.apache.org/content/repositories/
> > > > > orgapachegeode-1014/
> > > > > >
> > > > > > Geode's KEYS file containing PGP keys we use to sign the release:
> > > > > >   https://github.com/apache/incubator-geode/blob/release/
> > > > > 1.0.0-incubating/KEYS
> > > > > >
> > > > > > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> > > > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Swapnil.
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Cheers
> > > >
> > > > Jinmei
> > > >
> > >
> >
> >
> >
> > --
> >
> > ~/William
> >
>

Review Request 52956: GEODE-2011: add FlakyTest category to testNonPersistentServerRestartAutoSerializer

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52956/
---

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2011
https://issues.apache.org/jira/browse/GEODE-2011


Repository: geode


Description
---

GEODE-2011: add FlakyTest category to 
testNonPersistentServerRestartAutoSerializer


Diffs
-

  geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java 
1afb1ad 

Diff: https://reviews.apache.org/r/52956/diff/


Testing
---

build
PdxClientServerDUnitTest


Thanks,

Kirk Lund

Re: Review Request 52891: GEODE-538: Add check for persistent data recovery

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52891/#review152936
---




geode-core/src/main/java/org/apache/geode/cache/query/internal/DefaultQuery.java
 (line 608)


We are caling this in two places...And we are trying to determine offline 
disk stores while throwing exception...Can we move this to a method in PR...And 
call that function here...
E.g.:

isPROffline() throws PartitionOfflineException () {
}



geode-core/src/main/java/org/apache/geode/cache/query/internal/DefaultQuery.java
 (line 611)


We need to add this exception to the javadoc for query.execute(*) (Query 
interface).


- anilkumar gingade


On Oct. 14, 2016, 10:39 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52891/
> ---
> 
> (Updated Oct. 14, 2016, 10:39 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, 
> Scott Jewell, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> PartitionedRegion.getNodeForBucketReadOrLoad can return an invalid node
> if persistent data recovery is in process and a get() targets a bucket
> that
> hasn't been recoverd yet. This can result in returning an incorrect
> value (null) or throwing ConflictingPersistentDataException from a get()
> or put() on the region.
> 
> This change adds a check for persistent recovery to be completed
> before creating the new bucket. If recovery isn't complete then the
> operation on the region will fail with a PartitionOfflineException.
> 
> Queries on a region while persistent recovery is in progress can also
> result in incorrect results so a similar check is added to
> DefaultQuery.checkQueryOnPR.
> 
> New DUnit tests added for gets, puts, and queries for cases where persistent
> colocated child regions haven't been started and where the child region
> has been started but persistent recovery is still in progress when
> the region operation is attempted.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/DefaultQuery.java
>  58df3904e32b1af140bda92e0aba16da28c6a109 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PRHARedundancyProvider.java
>  cfedb677bceb884cd726f26e5bd0047876a668ab 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  baab79f930ab0eca03ab04660a21d10f5508f578 
>   
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
> 8bfdd686eb50605e12cb59015d5ddab99714c563 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRBasicQueryDUnitTest.java
>  8ef907ac85195d0433f3e2f923a7a9e02fc48fff 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryDUnitHelper.java
>  cfb419036817d994ef49e4e0bcfb304d15db300e 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
>  0a25228c9b2fd5066bbaf7f806462bcff36f0ba9 
> 
> Diff: https://reviews.apache.org/r/52891/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

Review Request 52937: GEODE-2007: fix unchecked warnings

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52937/
---

Review request for geode, Jinmei Liao and Kevin Duling.


Bugs: GEODE-2007
https://issues.apache.org/jira/browse/GEODE-2007


Repository: geode


Description
---

Fix the gradle build warnings for "uses unchecked or unsafe operations"


Diffs
-

  
extensions/geode-modules-tomcat7/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession7.java
 0df05ff 
  
extensions/geode-modules-tomcat8/src/test/java/org/apache/geode/modules/session/Tomcat8SessionsClientServerDUnitTest.java
 8b29048 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
6c195e7 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ha/HARegionQueue.java 
027a1b5 
  
geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DeltaPropagationWithCQDUnitTest.java
 3990265 
  
geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java
 0b48e16 

Diff: https://reviews.apache.org/r/52937/diff/


Testing
---

build
modified tests
precheckin in progress


Thanks,

Kirk Lund

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Roman Shaposhnik]

On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker  wrote:
> Since the geode docs have now been merged to the develop branch, let’s start
> hosting them on http://geode.apache.org.  Thoughts?

Huge +1! Anything stopping you from pushing the first update and start
maintaining
it a'la Hadoop:
https://hadoop.apache.org/docs/
?

Thanks,
Roman.

Re: Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52936/#review152931
---


Ship it!




Ship It!

- Jinmei Liao


On Oct. 17, 2016, 5:59 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52936/
> ---
> 
> (Updated Oct. 17, 2016, 5:59 p.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kevin Duling.
> 
> 
> Bugs: GEODE-2006
> https://issues.apache.org/jira/browse/GEODE-2006
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2006: add FlakyTest category to testSelectCommand
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
>  5417ccb 
> 
> Diff: https://reviews.apache.org/r/52936/diff/
> 
> 
> Testing
> ---
> 
> build, GemfireDataCommandsDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52949/#review152930
---


Ship it!




Ship It!

- Jinmei Liao


On Oct. 17, 2016, 7:18 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52949/
> ---
> 
> (Updated Oct. 17, 2016, 7:18 p.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kevin Duling.
> 
> 
> Bugs: GEODE-2009
> https://issues.apache.org/jira/browse/GEODE-2009
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2009: apply FlakyTest category to 
> testCreateAlterDestroyUpdatesSharedConfig
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
>  5fa06d9 
> 
> Diff: https://reviews.apache.org/r/52949/diff/
> 
> 
> Testing
> ---
> 
> build, CreateAlterDestroyRegionCommandsDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Jinmei Liao]

+1

On Mon, Oct 17, 2016 at 12:05 PM, Dan Smith  wrote:

> +1 - I was going to ask about this on the release thread. Let's put them up
> on geode.apache.org!
>
> -Dan
>
> On Mon, Oct 17, 2016 at 11:33 AM, Swapnil Bawaskar 
> wrote:
>
> > +1, It would be great to have this by the time we put the vote out on
> > general@incubator
> >
> > On Mon, Oct 17, 2016 at 10:59 AM, Joey McAllister <
> jmcallis...@pivotal.io>
> > wrote:
> >
> > > Only a very enthusiastic +1. :)
> > >
> > > On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker 
> > wrote:
> > >
> > > > Since the geode docs have now been merged to the develop branch,
> let’s
> > > > start hosting them on http://geode.apache.org.  Thoughts?
> > > >
> > > > Anthony
> > > >
> > > >
> > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> > > > wrote:
> > > >
> > > >
> > > > The documentation on how to install and use Apache Geode are hosted
> > > > on pivotal.io:
> > > >   http://geode.docs.pivotal.io
> > > >
> > > >
> > > >
> > >
> >
>



-- 
Cheers

Jinmei

Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52949/
---

Review request for geode, Jinmei Liao and Kevin Duling.


Bugs: GEODE-2009
https://issues.apache.org/jira/browse/GEODE-2009


Repository: geode


Description
---

GEODE-2009: apply FlakyTest category to 
testCreateAlterDestroyUpdatesSharedConfig


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
 5fa06d9 

Diff: https://reviews.apache.org/r/52949/diff/


Testing
---

build, CreateAlterDestroyRegionCommandsDUnitTest


Thanks,

Kirk Lund

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Dan Smith]

+1 - I was going to ask about this on the release thread. Let's put them up
on geode.apache.org!

-Dan

On Mon, Oct 17, 2016 at 11:33 AM, Swapnil Bawaskar 
wrote:

> +1, It would be great to have this by the time we put the vote out on
> general@incubator
>
> On Mon, Oct 17, 2016 at 10:59 AM, Joey McAllister 
> wrote:
>
> > Only a very enthusiastic +1. :)
> >
> > On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker 
> wrote:
> >
> > > Since the geode docs have now been merged to the develop branch, let’s
> > > start hosting them on http://geode.apache.org.  Thoughts?
> > >
> > > Anthony
> > >
> > >
> > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> > > wrote:
> > >
> > >
> > > The documentation on how to install and use Apache Geode are hosted
> > > on pivotal.io:
> > >   http://geode.docs.pivotal.io
> > >
> > >
> > >
> >
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Dan Smith]

+1

Checked
  * signatures
  * maven repo with simple sample app
  * command line test through gfsh
  * built the source

Checked it with this thing:
https://github.com/upthewaterspout/geode-release-check

On Mon, Oct 17, 2016 at 11:55 AM, William Markito 
wrote:

> +1
>
>  Checked SHA, signatures, build/run, sample app and command line testing
> through gfsh.
>
> On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund  wrote:
>
> > +1 I think we should target GEODE-2004 and GEODE-1883 for a point release
> > after 1.0.0
> >
> >
> > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao  wrote:
> >
> > > +0
> > >
> > > This candidate does not include the fix for GEODE-2004 and GEODE-1883.
> > It's
> > > not a must fix though.
> > >
> > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker 
> > wrote:
> > >
> > > > +1
> > > >
> > > > * Verified sha’s
> > > > * Verified signatures
> > > > * Verified tag signature
> > > > * Build and run from src distro
> > > > * Checked src distro for binaries
> > > > * Run some examples from mvn repo
> > > > * Reviewed LICENSE and NOTICE
> > > >
> > > > Anthony
> > > >
> > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <
> sbawas...@pivotal.io>
> > > > wrote:
> > > > >
> > > > > All,
> > > > >
> > > > > This is the second release candidate for Apache Geode, version
> > > > > 1.0.0-incubating. I discarded the first release candidate since my
> > pgp
> > > > > key was missing from the KEYS file.
> > > > > Thanks to all the community members to drive towards this
> milestone!
> > > > >
> > > > > It fixes the following issues:
> > > > >
> > > > >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > projectId=12318420&version=12332343
> > > > >
> > > > > *** Please download, test and vote by Wednesday, October 19, 0800
> hrs
> > > > > US Pacific.
> > > > >
> > > > > Note that we are voting upon the source (tag):
> > > > >   rel/1.0.0-incubating.RC2
> > > > >  > > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> > > > >
> > > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> > > > >  > > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753>
> > > > >
> > > > > Source and binary files:
> > > > >   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> > > > 0-incubating.RC2/
> > > > >
> > > > > The documentation on how to install and use Apache Geode are hosted
> > > > > on pivotal.io:
> > > > >   http://geode.docs.pivotal.io
> > > > >
> > > > > Maven staging repo:
> > > > >   https://repository.apache.org/content/repositories/
> > > > orgapachegeode-1014/
> > > > >
> > > > > Geode's KEYS file containing PGP keys we use to sign the release:
> > > > >   https://github.com/apache/incubator-geode/blob/release/
> > > > 1.0.0-incubating/KEYS
> > > > >
> > > > > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> > > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Swapnil.
> > > >
> > > >
> > >
> > >
> > > --
> > > Cheers
> > >
> > > Jinmei
> > >
> >
>
>
>
> --
>
> ~/William
>

[GitHub] incubator-geode pull request #262: GEODE-2004: Create/update/delete query th...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[William Markito]

+1

 Checked SHA, signatures, build/run, sample app and command line testing
through gfsh.

On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund  wrote:

> +1 I think we should target GEODE-2004 and GEODE-1883 for a point release
> after 1.0.0
>
>
> On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao  wrote:
>
> > +0
> >
> > This candidate does not include the fix for GEODE-2004 and GEODE-1883.
> It's
> > not a must fix though.
> >
> > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker 
> wrote:
> >
> > > +1
> > >
> > > * Verified sha’s
> > > * Verified signatures
> > > * Verified tag signature
> > > * Build and run from src distro
> > > * Checked src distro for binaries
> > > * Run some examples from mvn repo
> > > * Reviewed LICENSE and NOTICE
> > >
> > > Anthony
> > >
> > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> > > wrote:
> > > >
> > > > All,
> > > >
> > > > This is the second release candidate for Apache Geode, version
> > > > 1.0.0-incubating. I discarded the first release candidate since my
> pgp
> > > > key was missing from the KEYS file.
> > > > Thanks to all the community members to drive towards this milestone!
> > > >
> > > > It fixes the following issues:
> > > >
> > > >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > projectId=12318420&version=12332343
> > > >
> > > > *** Please download, test and vote by Wednesday, October 19, 0800 hrs
> > > > US Pacific.
> > > >
> > > > Note that we are voting upon the source (tag):
> > > >   rel/1.0.0-incubating.RC2
> > > >  > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> > > >
> > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> > > >  > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753>
> > > >
> > > > Source and binary files:
> > > >   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> > > 0-incubating.RC2/
> > > >
> > > > The documentation on how to install and use Apache Geode are hosted
> > > > on pivotal.io:
> > > >   http://geode.docs.pivotal.io
> > > >
> > > > Maven staging repo:
> > > >   https://repository.apache.org/content/repositories/
> > > orgapachegeode-1014/
> > > >
> > > > Geode's KEYS file containing PGP keys we use to sign the release:
> > > >   https://github.com/apache/incubator-geode/blob/release/
> > > 1.0.0-incubating/KEYS
> > > >
> > > > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
> > > >
> > > > Thanks,
> > > >
> > > > Swapnil.
> > >
> > >
> >
> >
> > --
> > Cheers
> >
> > Jinmei
> >
>



-- 

~/William

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[William Markito]

+1

On Mon, Oct 17, 2016 at 11:33 AM, Swapnil Bawaskar 
wrote:

> +1, It would be great to have this by the time we put the vote out on
> general@incubator
>
> On Mon, Oct 17, 2016 at 10:59 AM, Joey McAllister 
> wrote:
>
> > Only a very enthusiastic +1. :)
> >
> > On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker 
> wrote:
> >
> > > Since the geode docs have now been merged to the develop branch, let’s
> > > start hosting them on http://geode.apache.org.  Thoughts?
> > >
> > > Anthony
> > >
> > >
> > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> > > wrote:
> > >
> > >
> > > The documentation on how to install and use Apache Geode are hosted
> > > on pivotal.io:
> > >   http://geode.docs.pivotal.io
> > >
> > >
> > >
> >
>



-- 

~/William

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Swapnil Bawaskar]

+1, It would be great to have this by the time we put the vote out on
general@incubator

On Mon, Oct 17, 2016 at 10:59 AM, Joey McAllister 
wrote:

> Only a very enthusiastic +1. :)
>
> On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker  wrote:
>
> > Since the geode docs have now been merged to the develop branch, let’s
> > start hosting them on http://geode.apache.org.  Thoughts?
> >
> > Anthony
> >
> >
> > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> > wrote:
> >
> >
> > The documentation on how to install and use Apache Geode are hosted
> > on pivotal.io:
> >   http://geode.docs.pivotal.io
> >
> >
> >
>

Re: Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52936/#review152920
---


Ship it!




Ship It!

- Kevin Duling


On Oct. 17, 2016, 10:59 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52936/
> ---
> 
> (Updated Oct. 17, 2016, 10:59 a.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kevin Duling.
> 
> 
> Bugs: GEODE-2006
> https://issues.apache.org/jira/browse/GEODE-2006
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2006: add FlakyTest category to testSelectCommand
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
>  5417ccb 
> 
> Diff: https://reviews.apache.org/r/52936/diff/
> 
> 
> Testing
> ---
> 
> build, GemfireDataCommandsDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[GitHub] incubator-geode pull request #262: GEODE-2004: Create/update/delete query th...

[kjduling]

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/262

GEODE-2004: Create/update/delete query through rest api should requir…

…e DATA:READ instead of DATA:WRITE

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit 08745c9084c7cbfb4229bb0e9edcced1363224bd
Author: Kevin Duling 
Date:   2016-10-17T18:02:54Z

GEODE-2004: Create/update/delete query through rest api should require 
DATA:READ instead of DATA:WRITE




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52931/#review152916
---


Ship it!





geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
 (line 47)


You could move these to the Rule and use a fluent style API:

@Rule
public LocatorServerStartupRule lsRule = 
LocatorServerStartupRule.builder().setProperty(SECURITY_PEER_AUTHENTICATOR, 
DummyAuthenticator.class.getName()).startLocatorVM(0).build();

JUnit started changing the base Rules to use fluent builder similar to the 
above. We have some Rules like this as well.


- Kirk Lund


On Oct. 17, 2016, 3:10 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52931/
> ---
> 
> (Updated Oct. 17, 2016, 3:10 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * added more tetss
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  72dbd1aff32c718c1e6f72b940ade523c9cd8847 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  bb147c7a24868adf0aaa1e860ca6114ffa032afc 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
>  5364c910a4c4e9d24de8be26b63a62428f48d0a7 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
>  d3ed823887c15ca06aba76e20a964c25e5dee8b4 
>   
> geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
>  f6928bfa0db529c38b521d4bc72d013272981e1a 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  71894c8a27a8768db2e7e99b1a2b981253e4ec67 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
>  bcc5ab3bca842d741bced5c59117472c77659ba6 
> 
> Diff: https://reviews.apache.org/r/52931/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Joey McAllister]

Only a very enthusiastic +1. :)

On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker  wrote:

> Since the geode docs have now been merged to the develop branch, let’s
> start hosting them on http://geode.apache.org.  Thoughts?
>
> Anthony
>
>
> On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> wrote:
>
>
> The documentation on how to install and use Apache Geode are hosted
> on pivotal.io:
>   http://geode.docs.pivotal.io
>
>
>

Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52936/
---

Review request for geode, Jinmei Liao and Kevin Duling.


Bugs: GEODE-2006
https://issues.apache.org/jira/browse/GEODE-2006


Repository: geode


Description
---

GEODE-2006: add FlakyTest category to testSelectCommand


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
 5417ccb 

Diff: https://reviews.apache.org/r/52936/diff/


Testing
---

build, GemfireDataCommandsDUnitTest


Thanks,

Kirk Lund

Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Anthony Baker]

Since the geode docs have now been merged to the develop branch, let’s start 
hosting them on http://geode.apache.org.  Thoughts?

Anthony


> On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar  wrote:
> 
> 
> The documentation on how to install and use Apache Geode are hosted
> on pivotal.io :
>   http://geode.docs.pivotal.io 



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: Review Request 52935: GEODE-2005: fix javadoc warning

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52935/#review152911
---


Ship it!




Ship It!

- Jinmei Liao


On Oct. 17, 2016, 5:44 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52935/
> ---
> 
> (Updated Oct. 17, 2016, 5:44 p.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kevin Duling.
> 
> 
> Bugs: GEODE-2005
> https://issues.apache.org/jira/browse/GEODE-2005
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Fix javadoc warning.
> Line up @param and @return tags.
> Minor cleanup of javadocs.
> Delete extra blank lines.
> 
> 
> Diffs
> -
> 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
>  2bcb31b 
> 
> Diff: https://reviews.apache.org/r/52935/diff/
> 
> 
> Testing
> ---
> 
> javadoc
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Review Request 52935: GEODE-2005: fix javadoc warning

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52935/
---

Review request for geode, Jinmei Liao and Kevin Duling.


Bugs: GEODE-2005
https://issues.apache.org/jira/browse/GEODE-2005


Repository: geode


Description
---

Fix javadoc warning.
Line up @param and @return tags.
Minor cleanup of javadocs.
Delete extra blank lines.


Diffs
-

  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
 2bcb31b 

Diff: https://reviews.apache.org/r/52935/diff/


Testing
---

javadoc


Thanks,

Kirk Lund

Re: Review Request 52933: GEODE-1874: setNextNeighbor method allocates a HashSet on every p2p message received

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52933/#review152910
---


Ship it!




Ship It!

- Bruce Schuchardt


On Oct. 17, 2016, 5:18 p.m., Udo Kohlmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52933/
> ---
> 
> (Updated Oct. 17, 2016, 5:18 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Amended the logic in setNextNeighbor to not recreate HashSet every time. Also 
> amended logic in contactedBy to only call setNextNeighbor in a "state change" 
> rather than everytime the contactedBy method is called
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>  aafb498 
> 
> Diff: https://reviews.apache.org/r/52933/diff/
> 
> 
> Testing
> ---
> 
> precheckin - Done
> comms regression - in progress
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Kirk Lund]

+1 I think we should target GEODE-2004 and GEODE-1883 for a point release
after 1.0.0


On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao  wrote:

> +0
>
> This candidate does not include the fix for GEODE-2004 and GEODE-1883. It's
> not a must fix though.
>
> On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker  wrote:
>
> > +1
> >
> > * Verified sha’s
> > * Verified signatures
> > * Verified tag signature
> > * Build and run from src distro
> > * Checked src distro for binaries
> > * Run some examples from mvn repo
> > * Reviewed LICENSE and NOTICE
> >
> > Anthony
> >
> > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> > wrote:
> > >
> > > All,
> > >
> > > This is the second release candidate for Apache Geode, version
> > > 1.0.0-incubating. I discarded the first release candidate since my pgp
> > > key was missing from the KEYS file.
> > > Thanks to all the community members to drive towards this milestone!
> > >
> > > It fixes the following issues:
> > >
> > >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12318420&version=12332343
> > >
> > > *** Please download, test and vote by Wednesday, October 19, 0800 hrs
> > > US Pacific.
> > >
> > > Note that we are voting upon the source (tag):
> > >   rel/1.0.0-incubating.RC2
> > >  > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> > >
> > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> > >  > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753>
> > >
> > > Source and binary files:
> > >   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> > 0-incubating.RC2/
> > >
> > > The documentation on how to install and use Apache Geode are hosted
> > > on pivotal.io:
> > >   http://geode.docs.pivotal.io
> > >
> > > Maven staging repo:
> > >   https://repository.apache.org/content/repositories/
> > orgapachegeode-1014/
> > >
> > > Geode's KEYS file containing PGP keys we use to sign the release:
> > >   https://github.com/apache/incubator-geode/blob/release/
> > 1.0.0-incubating/KEYS
> > >
> > > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> > > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
> > >
> > > Thanks,
> > >
> > > Swapnil.
> >
> >
>
>
> --
> Cheers
>
> Jinmei
>

Review Request 52933: GEODE-1874: setNextNeighbor method allocates a HashSet on every p2p message received

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52933/
---

Review request for geode, Bruce Schuchardt and Hitesh Khamesra.


Repository: geode


Description
---

Amended the logic in setNextNeighbor to not recreate HashSet every time. Also 
amended logic in contactedBy to only call setNextNeighbor in a "state change" 
rather than everytime the contactedBy method is called


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
 aafb498 

Diff: https://reviews.apache.org/r/52933/diff/


Testing
---

precheckin - Done
comms regression - in progress


Thanks,

Udo Kohlmeyer

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Jinmei Liao]

+0

This candidate does not include the fix for GEODE-2004 and GEODE-1883. It's
not a must fix though.

On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker  wrote:

> +1
>
> * Verified sha’s
> * Verified signatures
> * Verified tag signature
> * Build and run from src distro
> * Checked src distro for binaries
> * Run some examples from mvn repo
> * Reviewed LICENSE and NOTICE
>
> Anthony
>
> > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar 
> wrote:
> >
> > All,
> >
> > This is the second release candidate for Apache Geode, version
> > 1.0.0-incubating. I discarded the first release candidate since my pgp
> > key was missing from the KEYS file.
> > Thanks to all the community members to drive towards this milestone!
> >
> > It fixes the following issues:
> >
> >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420&version=12332343
> >
> > *** Please download, test and vote by Wednesday, October 19, 0800 hrs
> > US Pacific.
> >
> > Note that we are voting upon the source (tag):
> >   rel/1.0.0-incubating.RC2
> >  geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> >
> > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> >  geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1c975870753>
> >
> > Source and binary files:
> >   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> 0-incubating.RC2/
> >
> > The documentation on how to install and use Apache Geode are hosted
> > on pivotal.io:
> >   http://geode.docs.pivotal.io
> >
> > Maven staging repo:
> >   https://repository.apache.org/content/repositories/
> orgapachegeode-1014/
> >
> > Geode's KEYS file containing PGP keys we use to sign the release:
> >   https://github.com/apache/incubator-geode/blob/release/
> 1.0.0-incubating/KEYS
> >
> > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB
> >
> > Thanks,
> >
> > Swapnil.
>
>


-- 
Cheers

Jinmei

Re: Review Request 52896: GEODE-706 Fixed race condition between expiry thread and put thread.

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52896/#review152895
---




geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java (line 
8721)


It would be a lot better to have two different methods, one that takes an 
expiryTask parameter and another that doesn't.


- Bruce Schuchardt


On Oct. 14, 2016, 9:05 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52896/
> ---
> 
> (Updated Oct. 14, 2016, 9:05 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Darrel Schneider, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> There was possibility that expiry thread destroying the entry and
> another thread doing update on same key. In this case expiry thread
> cancel's existing task and update thread adds expiry task. But this
> tasks are refer by regionEntry, which is same for both the threads.
> So in this case if expiry thread cancel's task after update thread
> then that entry will never expire.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  5861e9a 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/EntryEventImpl.java 
> 6a964c0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/EntryExpiryTask.java 
> 816f32f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> a6951de 
> 
> Diff: https://reviews.apache.org/r/52896/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Re: Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52931/#review152888
---


Ship it!




Ship It!

- Kevin Duling


On Oct. 17, 2016, 8:10 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52931/
> ---
> 
> (Updated Oct. 17, 2016, 8:10 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * added more tetss
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  72dbd1aff32c718c1e6f72b940ade523c9cd8847 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  bb147c7a24868adf0aaa1e860ca6114ffa032afc 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
>  5364c910a4c4e9d24de8be26b63a62428f48d0a7 
>   
> geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
>  d3ed823887c15ca06aba76e20a964c25e5dee8b4 
>   
> geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
>  f6928bfa0db529c38b521d4bc72d013272981e1a 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  71894c8a27a8768db2e7e99b1a2b981253e4ec67 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
>  bcc5ab3bca842d741bced5c59117472c77659ba6 
> 
> Diff: https://reviews.apache.org/r/52931/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52889/#review152890
---


Ship it!




Ship It!

- Kevin Duling


On Oct. 14, 2016, 11:41 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52889/
> ---
> 
> (Updated Oct. 14, 2016, 11:41 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * created ServerStarter and LocatorStarter in the rule package
> * refacterred LocatorServerConfigurationRule
> * refactor tests to use these rules
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
>  59e00c8bd0a7f2759f579abf99a87fcd98b42a06 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  79b70f875f74c15eb041e9d1cbd5b1f8ceeda899 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/AccessControlMBeanJUnitTest.java
>  c22fff3655131cf908a54289b66faf84311c5c69 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthenticationJUnitTest.java
>  388094840fc587e662d231783fd5c7c8faf7b485 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java
>  7bbfbcc9691000601cf6bf4dd0be7c7394cf3fcf 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanShiroJUnitTest.java
>  721a4312456e0f1eaf41a6c1f41016cfe56450e4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerStartupRule.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CliCommandsSecurityTest.java
>  84155a9d82292dc70c6412908a1b57a09c1aea98 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/DataCommandsSecurityTest.java
>  0084cb8f5471ce7ecab086c955a842766d6ed790 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
>  750ce2ac76ecd0860f5f678a22615697c9ea5009 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GatewayReceiverMBeanSecurityTest.java
>  b64a6f7b1c63eb41f5823b4971d5041431748db9 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GatewaySenderMBeanSecurityTest.java
>  9acf8dbd172cca27ba4da942b3d5c1bd0368ff83 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
>  34fd5a994c5a69d64398de3cb867892a30827e2c 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  def17920b198e88f358dfcf4025f4a3eee6fd0df 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshShellConnectionRule.java
>  4d1bae904c4964ca2be713fd8450f2f5f6db2552 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/JMXConnectionConfiguration.java
>  4f57baa85e3b5cd084ffd33c61f7741d20b0fdc9 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameTest.java
>  c544e6fe0f8d3c1975775979d1354c4adc7cf87a 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/JsonAuthorizationCacheStartRule.java
>  136319c06d9bd1e46b452219bf2894cf969fc1f1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/LockServiceMBeanAuthorizationJUnitTest.java
>  1377fb643d035ad911ee5ceb80b87dfd72855428 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/MBeanSecurityJUnitTest.java
>  4beff0bd55d69601266a0a856c8dcb80ffd4e1f7 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/MBeanServerConnectionRule.java
>  92430327e999af627e88956fc24aa1592e9a000d 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/ManagerMBeanAuthorizationJUnitTest.java
>  873b6491f6703378d87383d96dc35e299b19a3fa 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/MemberMBeanSecurityJUnitTest.java
>  e5cbd15da9274d2a86be399f45c9239b2ae373be 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/ResourcePermissionTest.java
>  d6491ffde316401b215b712d33d60ced8a2b65cf 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/ShiroCacheStartRule.java
>  848c05c77e6b9082075b07c5c91e21eeadde1bc0 
>   
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
>  d2e44408317b0f815

Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52931/
---

Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

* added more tetss


Diffs
-

  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 72dbd1aff32c718c1e6f72b940ade523c9cd8847 
  
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
 bb147c7a24868adf0aaa1e860ca6114ffa032afc 
  
geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
 5364c910a4c4e9d24de8be26b63a62428f48d0a7 
  
geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
 d3ed823887c15ca06aba76e20a964c25e5dee8b4 
  
geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
 f6928bfa0db529c38b521d4bc72d013272981e1a 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 71894c8a27a8768db2e7e99b1a2b981253e4ec67 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
 bcc5ab3bca842d741bced5c59117472c77659ba6 

Diff: https://reviews.apache.org/r/52931/diff/


Testing
---


Thanks,

Jinmei Liao