[GitHub] incubator-geode pull request #245: native-client-software-grant - ClientMeta...

[fdaniel7]

Github user fdaniel7 commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/245#discussion_r84839367
  
--- Diff: geode-client-native/src/cppcache/impl/ClientMetadataService.cpp 
---
@@ -1,925 +1 @@
-/*=
- * Copyright (c) 2010-2014 Pivotal Software, Inc. All Rights Reserved.
- * This product is protected by U.S. and international copyright
- * and intellectual property laws. Pivotal products are covered by
- * one or more patents listed at http://www.pivotal.io/patents.
- *=
- */
-#include "TcrMessage.hpp"
-#include "ClientMetadataService.hpp"
-#include "ThinClientPoolDM.hpp"
-#include "../FixedPartitionResolver.hpp"
-#include 
-#include 
-#include 
-
-namespace gemfire {
-  const char * ClientMetadataService::NC_CMDSvcThread = "NC CMDSvcThread";
-  ClientMetadataService::~ClientMetadataService ()
-  {
-delete m_regionQueue;
-if(m_bucketWaitTimeout > 0)
-{
-  try
-  {
-std::map::iterator  bi;
-for (bi = m_bucketStatus.begin(); bi != m_bucketStatus.end(); ++bi)
-{
-  delete bi->second;
-}
-
-  }catch(...)
-  {
-LOGINFO("Exception in ClientMetadataService destructor");
-  }
-}
-  }
-
-  ClientMetadataService::ClientMetadataService(PoolPtr pool)
-/* adongre
-* CID 28928: Uninitialized scalar field (UNINIT_CTOR)
-*/
-: m_run(false)
-
-  {
-m_regionQueue = new Queue(false);
-m_pool = pool;
-m_bucketWaitTimeout = 
DistributedSystem::getSystemProperties()->bucketWaitTimeout();
-  }
-
-  int ClientMetadataService::svc() {
-DistributedSystemImpl::setThreadName(NC_CMDSvcThread);
-LOGINFO("ClientMetadataService started for pool %s", 
m_pool->getName()); 
-while (m_run) {
-  m_regionQueueSema.acquire( );
-  ThinClientPoolDM* tcrdm = dynamic_cast< ThinClientPoolDM* >( 
m_pool.ptr( ) ); 
-  CacheImpl * cache = tcrdm->getConnectionManager().getCacheImpl();
-  while(true)
-  {
-std::string * regionFullPath = m_regionQueue->get();
-
-if(regionFullPath != NULL && regionFullPath->c_str() != NULL )
-{
-  while(true) 
-  {
-if(m_regionQueue->size() > 0) 
-{
-  std::string * nextRegionFullPath = m_regionQueue->get();
-  if(nextRegionFullPath != NULL && nextRegionFullPath->c_str() 
!= NULL && regionFullPath->compare(nextRegionFullPath->c_str()) == 0)
-  {
-delete nextRegionFullPath;//we are going for same
-  }
-  else
-  {
-//different region; put it back
-m_regionQueue->put(nextRegionFullPath);
-break;
-  }
-} else
-  break;
-  }
-}
-
-if (!cache->isCacheDestroyPending() && regionFullPath != NULL && 
regionFullPath->c_str() != NULL) {
-  getClientPRMetadata(regionFullPath->c_str());
-  delete regionFullPath;
-  regionFullPath = NULL;
-}
-else
-{
-  delete regionFullPath;
-  regionFullPath = NULL;
-  break;
-}
-  }
-  //while(m_regionQueueSema.tryacquire( ) != -1); // release all
-}
-LOGINFO("ClientMetadataService stopped for pool %s", 
m_pool->getName());
-return 0;
-  }
-
-  void  ClientMetadataService::getClientPRMetadata(const char * 
regionFullPath) {
-if (regionFullPath == NULL) return;
-ThinClientPoolDM* tcrdm = dynamic_cast< ThinClientPoolDM* >( 
m_pool.ptr( ) );
-if(tcrdm == NULL)
-{
-  throw IllegalArgumentException("ClientMetaData: pool cast to 
ThinClientPoolDM failed");
-}
-// That means metadata for the region not found, So only for the first 
time for a particular region use GetClientPartitionAttributesOp
-// TcrMessage to fetch the metadata and put it into map for later 
use.send this message to server and get metadata from server.
-TcrMessage reply;
-std::string path(regionFullPath);
-ClientMetadataPtr cptr = NULLPTR;
-   {
- ReadGuard guard( m_regionMetadataLock );
-RegionMetadataMapType::iterator itr = m_regionMetaDataMap.find(path);
-if (itr != m_regionMetaDataMap.end()) {
-  cptr = itr->second;
-}
- //cptr = m_regionMetaDataMap[path];
-   }
-ClientMetadataPtr newCptr = NULLPTR;

GEODE-25 and Cryptography Audit

[William Markito]

I was checking GEODE-25 and found that there is already an attached PDF
with information around export compliance, etc...

https://issues.apache.org/jira/browse/GEODE-25

Is there anything else actually pending to resolve GEODE-25 ?  Some
discussions happened on the ticket but I'm not sure if they're conclusive.

Thanks,
-- 
~/William

Passed: apache/incubator-geode#1305 (rel/v1.0.0-incubating - 280a407)

[Travis CI]

Build Update for apache/incubator-geode
-

Build: #1305
Status: Passed

Duration: 16 minutes and 2 seconds
Commit: 280a407 (rel/v1.0.0-incubating)
Author: Swapnil Bawaskar
Message: Adding my PGP key to KEYS

View the changeset: 
https://github.com/apache/incubator-geode/compare/rel/v1.0.0-incubating

View the full build log and details: 
https://travis-ci.org/apache/incubator-geode/builds/170359099

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[GitHub] incubator-geode pull request #267: Feature/geode 2015

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #270: GEODE-2014: Upgrade Swagger libraries

[kjduling]

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/270

GEODE-2014: Upgrade Swagger libraries

Updated expected jars list after swagger update

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2014

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #270


commit 07d8ed53d6a69123011e05db5a5bf3c47dc2a35a
Author: Kevin Duling 
Date:   2016-10-24T23:23:26Z

GEODE-2014: Upgrade Swagger libraries

Updated expected jars list after swagger update




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 53154: GEODE-2026: fix flaky test

[Darrel Schneider]

> On Oct. 24, 2016, 4:24 p.m., Scott Jewell wrote:
> > Code looks good.
> > 
> > Seems like 30 seconds is one of those things that should normally happen 
> > very fast,
> > but occasionally might be hung up for some reason (i.e. GC), so why not 
> > wait 200 or something.
> > A longer wait max would not slow the test down, but might miss an 
> > occasional GC pause or something.

I changed it to 60 which is used in lots of our tests.


- Darrel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53154/#review153756
---


On Oct. 24, 2016, 4:19 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53154/
> ---
> 
> (Updated Oct. 24, 2016, 4:19 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken 
> Howe.
> 
> 
> Bugs: GEODE-2026
> https://issues.apache.org/jira/browse/GEODE-2026
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test was initializing a value to a String,
> then starting an async thread that would keep
> changing it to an int,
> it slept for 100ms and then assummed that the async
> thread had changed the value to an Integer.
> In rare cases the thread never was able to to its first
> put so the value was still a String.
> 
> The test now waits for the async thread to change the value
> to an Integer instead of doing a 100ms sleep.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
>  5ca3d014b4bac01e239561301666fae5fb0d61ea 
> 
> Diff: https://reviews.apache.org/r/53154/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 53154: GEODE-2026: fix flaky test

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53154/#review153760
---




geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
 (line 1632)


no need to "throw InterruptedException"


- Darrel Schneider


On Oct. 24, 2016, 4:19 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53154/
> ---
> 
> (Updated Oct. 24, 2016, 4:19 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken 
> Howe.
> 
> 
> Bugs: GEODE-2026
> https://issues.apache.org/jira/browse/GEODE-2026
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test was initializing a value to a String,
> then starting an async thread that would keep
> changing it to an int,
> it slept for 100ms and then assummed that the async
> thread had changed the value to an Integer.
> In rare cases the thread never was able to to its first
> put so the value was still a String.
> 
> The test now waits for the async thread to change the value
> to an Integer instead of doing a 100ms sleep.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
>  5ca3d014b4bac01e239561301666fae5fb0d61ea 
> 
> Diff: https://reviews.apache.org/r/53154/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 53154: GEODE-2026: fix flaky test

[Scott Jewell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53154/#review153756
---


Ship it!




Code looks good.

Seems like 30 seconds is one of those things that should normally happen very 
fast,
but occasionally might be hung up for some reason (i.e. GC), so why not wait 
200 or something.
A longer wait max would not slow the test down, but might miss an occasional GC 
pause or something.

- Scott Jewell


On Oct. 24, 2016, 11:19 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53154/
> ---
> 
> (Updated Oct. 24, 2016, 11:19 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken 
> Howe.
> 
> 
> Bugs: GEODE-2026
> https://issues.apache.org/jira/browse/GEODE-2026
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test was initializing a value to a String,
> then starting an async thread that would keep
> changing it to an int,
> it slept for 100ms and then assummed that the async
> thread had changed the value to an Integer.
> In rare cases the thread never was able to to its first
> put so the value was still a String.
> 
> The test now waits for the async thread to change the value
> to an Integer instead of doing a 100ms sleep.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
>  5ca3d014b4bac01e239561301666fae5fb0d61ea 
> 
> Diff: https://reviews.apache.org/r/53154/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Review Request 53154: GEODE-2026: fix flaky test

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53154/
---

Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken 
Howe.


Bugs: GEODE-2026
https://issues.apache.org/jira/browse/GEODE-2026


Repository: geode


Description
---

The test was initializing a value to a String,
then starting an async thread that would keep
changing it to an int,
it slept for 100ms and then assummed that the async
thread had changed the value to an Integer.
In rare cases the thread never was able to to its first
put so the value was still a String.

The test now waits for the async thread to change the value
to an Integer instead of doing a 100ms sleep.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
 5ca3d014b4bac01e239561301666fae5fb0d61ea 

Diff: https://reviews.apache.org/r/53154/diff/


Testing
---

precheckin


Thanks,

Darrel Schneider

Re: more spotless problems on Windows

[Bruce Schuchardt]

The lineEndings setting works great.  I've pushed the change to develop

On Mon, Oct 24, 2016 at 3:47 PM, Dan Smith  wrote:

> I think we have a fix for the spotless line ending issue on windows; Bruce
> will check it in shortly:
>
> diff --git a/build.gradle b/build.gradle
> index a734e05..6e82433 100755
> --- a/build.gradle
> +++ b/build.gradle
> @@ -88,6 +88,7 @@ subprojects {
>
>apply plugin: "com.diffplug.gradle.spotless"
>spotless {
> +lineEndings = 'unix';
>  java {
>eclipseFormatFile
> "${rootProject.projectDir}/etc/eclipse-java-google-style.xml"
>
>
> On Mon, Oct 24, 2016 at 2:50 PM, Bruce Schuchardt 
> wrote:
>
> > Running geode-core:spotlessCheck complains that all of the .java files
> > have format violations
> >
> > * What went wrong:
> > Execution failed for task ':geode-core:spotlessJavaCheck'.
> > > Format violations were found. Run 'gradlew spotlessApply' to fix them.
> > geode-core\src\jca\java\org\apache\geode\internal\ra\GFConne
> > ctionFactoryImpl.java
> > geode-core\src\jca\java\org\apache\geode\internal\ra\
> GFConnectionImpl.java
> > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> > LocalTransaction.java
> > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> > ManagedConnection.java
> > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> > ManagedConnectionFactory.java
> > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> > ManagedConnectionnMetaData.java
> > etc.
> >
> > Until this is fixed I can't validate that the changes I check in conform
> > to the formatting rules.
> >
>

Re: more spotless problems on Windows

[Dan Smith]

I think we have a fix for the spotless line ending issue on windows; Bruce
will check it in shortly:

diff --git a/build.gradle b/build.gradle
index a734e05..6e82433 100755
--- a/build.gradle
+++ b/build.gradle
@@ -88,6 +88,7 @@ subprojects {

   apply plugin: "com.diffplug.gradle.spotless"
   spotless {
+lineEndings = 'unix';
 java {
   eclipseFormatFile
"${rootProject.projectDir}/etc/eclipse-java-google-style.xml"


On Mon, Oct 24, 2016 at 2:50 PM, Bruce Schuchardt 
wrote:

> Running geode-core:spotlessCheck complains that all of the .java files
> have format violations
>
> * What went wrong:
> Execution failed for task ':geode-core:spotlessJavaCheck'.
> > Format violations were found. Run 'gradlew spotlessApply' to fix them.
> geode-core\src\jca\java\org\apache\geode\internal\ra\GFConne
> ctionFactoryImpl.java
> geode-core\src\jca\java\org\apache\geode\internal\ra\GFConnectionImpl.java
> geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> LocalTransaction.java
> geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> ManagedConnection.java
> geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> ManagedConnectionFactory.java
> geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA
> ManagedConnectionnMetaData.java
> etc.
>
> Until this is fixed I can't validate that the changes I check in conform
> to the formatting rules.
>

[GitHub] incubator-geode issue #267: Feature/geode 2015

[joeymcallister]

Github user joeymcallister commented on the issue:

https://github.com/apache/incubator-geode/pull/267
  
@karensmolermiller I committed a new README.md file with the two changes 
you suggested. My markdown editors showed the correct formatting before the 
changes, as well as after the changes. Please review to make sure they're 
registering in your markdown editor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #267: Feature/geode 2015

[karensmolermiller]

Github user karensmolermiller commented on the issue:

https://github.com/apache/incubator-geode/pull/267
  
+1 on this PR with two minor alterations in the `geode-book/README.md` file:

- the markdown is not quite right. Adding appropriate blank lines and 
indenting the fixed width text sections by 4 spaces will make the last 
section's 4 numbered items appear as 1, 2, 3, 4.  They currently appear as 1, 
1, 1, 1.
- the first of the 3 commands to embed the User Guide into the website 
content (what will be step number 2) is missing a period at the end of the 
command.
The *incorrect* commands:

```
   $ tar cvf ~/Desktop/new-guide-content.tar
   $ cd ../../../geode-site/content
   $ tar xvf ~/Desktop/new-guide-content.tar
```

The correct commands are

```
   $ tar cvf ~/Desktop/new-guide-content.tar .
   $ cd ../../../geode-site/content
   $ tar xvf ~/Desktop/new-guide-content.tar
```

_Note:_  when merging in this PR to a current develop branch, there will be 
a conflict (as noted in the PR) on the subnav.  Keep the develop branch's (new) 
link to the Automated Rebalance section, but update its path to include 
`/guide`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

more spotless problems on Windows

[Bruce Schuchardt]

Running geode-core:spotlessCheck complains that all of the .java files 
have format violations


* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.
> Format violations were found. Run 'gradlew spotlessApply' to fix them.
geode-core\src\jca\java\org\apache\geode\internal\ra\GFConnectionFactoryImpl.java
geode-core\src\jca\java\org\apache\geode\internal\ra\GFConnectionImpl.java
geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCALocalTransaction.java
geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCAManagedConnection.java
geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCAManagedConnectionFactory.java
geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCAManagedConnectionnMetaData.java
etc.

Until this is fixed I can't validate that the changes I check in conform 
to the formatting rules.

Re: Coding practices/standards

[Bruce Schuchardt]

I'm having trouble with Spotless.   spotlessApply on MS-Windows is 
changing all of the files it touches to have CRLF line separators. 
Adding endWithNewline() to the java config in build.gradle doesn't 
help.  If I run geode-core:spotlessApply I end up with over 5000 
modified files.



Le 10/24/2016 à 11:09 AM, Udo Kohlmeyer a écrit :

+1 - Nice work. Thx


On 24/10/16 10:40 am, Dan Smith wrote:

Doing a spotlessApply on my feature branch before rebasing didn't help
bring down the number of conflicts.

I came up with this sequence of steps to rebase a feature branch on 
develop

that avoids the need to manually resolve conflicts with the formatting
changes. The trick here is to pick up *just* the formatting changes 
in one
of the steps, and then reject any formatting changes that conflict 
with my

changes.

#Rebase onto the commit before the spotless change. Resolve conflicts 
if any

git rebase 56917a26a8916b83f0cec6e85285b5040ff66ee6

#Rebase onto the spotless change, automatically throwing away the
formatting changes if they conflict.
git rebase -Xtheirs c2319bb7a6201d5ae82ecb0fe23a1e3b8072c2e1

#Rebase onto the rest of develop. Resolve conflicts if any.
git rebase origin/develop

#Apply formatting
./gradlew geode-core:spotlessApply

-Dan

On Fri, Oct 21, 2016 at 4:34 PM, Jared Stewart  
wrote:



Try this commit hash instead: d0175ec5aa8acf1b34ece3183fe03e9874450cbb
(from feature/spotlessPlugin).



On Oct 21, 2016, at 4:16 PM, Kirk Lund  wrote:

FYI, feeb5c98402881156b34e222c58ce15c71a4fca7 doesn't exist in the

Apache

git repo.

Is there a way to reformat a branch and then rebase on develop to

minimize

conflicts?

-Kirk


On Fri, Oct 21, 2016 at 1:36 PM, Jared Stewart 

wrote:
Fantastic, thanks for merging this in Mark.  For anyone with 
outstanding
work on branches made before this change, your life may be made 
easier

by

cherry-picking feeb5c98402881156b34e222c58ce15c71a4fca7 (which added
Spotless) into your branch and then running ‘gradlew 
spotlessApply’ on

it

before attempting to merge into develop.

— Jared
On Oct 21, 2016, at 1:33 PM, Mark Bretl  
wrote:


Thanks Jared for the suggestion of Spotless and follow-up work.

This is now completed and checked into develop. As this does 
touch many

files, be prepared the next time you pull.

--Mark



On Fri, Oct 21, 2016 at 1:21 PM, Jared Stewart 

wrote:

Done! :)

- Jared

On Oct 21, 2016, at 12:27 PM, Mark Bretl 

wrote:

One more time! :)

Conflicting files
geode-core/src/test/java/org/apache/geode/disttx/

PRDistTXDUnitTest.java

geode-core/src/test/java/org/apache/geode/disttx/

PRDistTXWithVersionsDUnitTest.java

geode-core/src/test/java/org/apache/geode/internal/cache/execute/

PRTransactionDUnitTest.java

--Mark

On Fri, Oct 21, 2016 at 12:08 PM, Jared Stewart 

wrote:

I just pulled and rebased onto develop, and force pushed into the

existing

pull request.  It should be clean to merge in now.

Thanks,
Jared

On Oct 21, 2016, at 11:57 AM, Mark Bretl 

wrote:

I believe there is enough consensus here to check this into

develop.
Jared, due to recent checkins into develop, can you update 
the pull

request

one more time? Trying to make this as clean as possible. I will

check

into

develop after the update, unless someone else gets to it first.

All, can we hold checkins on develop until the new formatter is

applied?

Thanks,

--Mark

On Fri, Oct 21, 2016 at 9:03 AM, Kenneth Howe 

wrote:

+1


On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt <

bschucha...@pivotal.io>

wrote:

+1

Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit :

+1


On 20/10/16 4:56 pm, Mark Bretl wrote:

+1 as well...

- Pulled changes
- Executed './gradlew clean build' and was successful.
- Modified a couple of random files to test
- Ran './gradlew clean build' again and failed expectedly
- Ran './gradlew spotlessApply', task was successful
- Ran './gradlew clean build' and succeeded

Great addition! As long as others are good with the 
formatter,

then I

am

good.

--Mark

On Thu, Oct 20, 2016 at 3:40 PM, Kirk Lund 


wrote:

+1 I just added my approval to the PR (and again here)


On Thu, Oct 20, 2016 at 3:25 PM, Jared Stewart <

jstew...@pivotal.io

wrote:


I have opened a pull request here <

https://github.com/apache/
incubator-geode/pull/268> to enable the Spotless plugin 
and

to

switch to

the Google Java Style formatter templates.



On Oct 18, 2016, at 4:32 PM, Kirk Lund 

wrote:

For reference TRAC #38741 was a bug with the summary

"EOFException

during

deserialize on client update with copy-on-read=true"

-Kirk


On Tue, Oct 18, 2016 at 4:27 PM, Jared Stewart <

jstew...@pivotal.io

wrote:

To give everyone an update, using the Google Java Style

eclipse

template

there is an issue spotlessCheck where fails for
geode-core/src/test/java/org/apache/geode/cache30/

Bug38741DUnitTest.java
even if you run it directly after spotlessApply. This 
needs

to

be
investigated and fixed before I can open a pull 
request to

enable

spotless.
On Oct 14,

[GitHub] incubator-geode pull request #269: GEODE-2015: Fix docs paths

[joeymcallister]

Github user joeymcallister closed the pull request at:

https://github.com/apache/incubator-geode/pull/269


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #269: GEODE-2015: Fix docs paths

[joeymcallister]

Github user joeymcallister commented on the issue:

https://github.com/apache/incubator-geode/pull/269
  
This PR is complete. Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Donation of Geode documentation

[Joey McAllister]

Hi Anil,

The search functionality on the old version of the docs was a third-party
feature held over from GemFire documentation. We'll need to research
options that are Apache friendly.

Joey

On Mon, Oct 24, 2016 at 12:23 PM Anilkumar Gingade 
wrote:

> I don't see any "search" option with docs? Did we miss it...
>
> http://geode.incubator.apache.org/docs/guide/about_geode.html
>
> -Anil.
>
>
> On Thu, Sep 29, 2016 at 8:27 PM, Anthony Baker  wrote:
>
> > I am pleased to announce the donation of Geode documentation to the
> > Geode community.
> >
> > The documentation provides a complete user guide for Geode. This
> > donation includes the source necessary to build the documentation site
> > currently hosted by Pivotal [1]. The documentation source has been
> > converted into a community-friendly markdown format.
> >
> > The Software Grant Agreement for this code has been accepted by the ASF
> > secretary.
> >
> > The donated source currently sits in a separate branch in the Geode
> > repository named staging/docs-grant1 [2] and is awaiting community
> > review. I encourage everyone in the Geode community to review this
> > donation and provide feedback. Once the community has reached a
> > consensus we can determine next steps and how this code might get
> > merged into the develop branch [3]. This will allow the geode
> > community to accept documentation contributions and self-host the
> > documentation on the project website. Your suggestions are most
> > welcome!
> >
> > Thanks,
> > Anthony
> >
> > [1] http://geode.docs.pivotal.io
> > [2] https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> > git;a=tree;h=refs/heads/staging/docs-grant1;hb=refs/
> > heads/staging/docs-grant1
> > [3] https://issues.apache.org/jira/browse/GEODE-1952
> >
>

Re: [ANNOUNCE] Donation of Geode documentation

[Anilkumar Gingade]

I don't see any "search" option with docs? Did we miss it...

http://geode.incubator.apache.org/docs/guide/about_geode.html

-Anil.


On Thu, Sep 29, 2016 at 8:27 PM, Anthony Baker  wrote:

> I am pleased to announce the donation of Geode documentation to the
> Geode community.
>
> The documentation provides a complete user guide for Geode. This
> donation includes the source necessary to build the documentation site
> currently hosted by Pivotal [1]. The documentation source has been
> converted into a community-friendly markdown format.
>
> The Software Grant Agreement for this code has been accepted by the ASF
> secretary.
>
> The donated source currently sits in a separate branch in the Geode
> repository named staging/docs-grant1 [2] and is awaiting community
> review. I encourage everyone in the Geode community to review this
> donation and provide feedback. Once the community has reached a
> consensus we can determine next steps and how this code might get
> merged into the develop branch [3]. This will allow the geode
> community to accept documentation contributions and self-host the
> documentation on the project website. Your suggestions are most
> welcome!
>
> Thanks,
> Anthony
>
> [1] http://geode.docs.pivotal.io
> [2] https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> git;a=tree;h=refs/heads/staging/docs-grant1;hb=refs/
> heads/staging/docs-grant1
> [3] https://issues.apache.org/jira/browse/GEODE-1952
>

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/265


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 53107: GEODE-2023: Add Lucene documentation

[Joey McAllister]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53107/#review153718
---


Ship it!




Ship It!

- Joey McAllister


On Oct. 21, 2016, 10:56 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53107/
> ---
> 
> (Updated Oct. 21, 2016, 10:56 p.m.)
> 
> 
> Review request for geode, Joey McAllister and Karen Miller.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2023: Add Lucene documentation
> 
> 
> Diffs
> -
> 
>   geode-book/master_middleman/source/subnavs/geode-subnav.erb 
> 2373f4b397952372a61923c5b57ef8f6d2102ee3 
>   geode-docs/tools_modules/book_intro.html.md.erb 
> 852e3c9de6eba2f83f0c513912c53b771889509e 
>   geode-docs/tools_modules/lucene_integration.html.md.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53107/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Coding practices/standards

[Udo Kohlmeyer]

+1 - Nice work. Thx


On 24/10/16 10:40 am, Dan Smith wrote:

Doing a spotlessApply on my feature branch before rebasing didn't help
bring down the number of conflicts.

I came up with this sequence of steps to rebase a feature branch on develop
that avoids the need to manually resolve conflicts with the formatting
changes. The trick here is to pick up *just* the formatting changes in one
of the steps, and then reject any formatting changes that conflict with my
changes.

#Rebase onto the commit before the spotless change. Resolve conflicts if any
git rebase 56917a26a8916b83f0cec6e85285b5040ff66ee6

#Rebase onto the spotless change, automatically throwing away the
formatting changes if they conflict.
git rebase -Xtheirs c2319bb7a6201d5ae82ecb0fe23a1e3b8072c2e1

#Rebase onto the rest of develop. Resolve conflicts if any.
git rebase origin/develop

#Apply formatting
./gradlew geode-core:spotlessApply

-Dan

On Fri, Oct 21, 2016 at 4:34 PM, Jared Stewart  wrote:


Try this commit hash instead: d0175ec5aa8acf1b34ece3183fe03e9874450cbb
(from feature/spotlessPlugin).



On Oct 21, 2016, at 4:16 PM, Kirk Lund  wrote:

FYI, feeb5c98402881156b34e222c58ce15c71a4fca7 doesn't exist in the

Apache

git repo.

Is there a way to reformat a branch and then rebase on develop to

minimize

conflicts?

-Kirk


On Fri, Oct 21, 2016 at 1:36 PM, Jared Stewart 

wrote:

Fantastic, thanks for merging this in Mark.  For anyone with outstanding
work on branches made before this change, your life may be made easier

by

cherry-picking feeb5c98402881156b34e222c58ce15c71a4fca7 (which added
Spotless) into your branch and then running ‘gradlew spotlessApply’ on

it

before attempting to merge into develop.

— Jared

On Oct 21, 2016, at 1:33 PM, Mark Bretl  wrote:

Thanks Jared for the suggestion of Spotless and follow-up work.

This is now completed and checked into develop. As this does touch many
files, be prepared the next time you pull.

--Mark



On Fri, Oct 21, 2016 at 1:21 PM, Jared Stewart 

wrote:

Done! :)

- Jared

On Oct 21, 2016, at 12:27 PM, Mark Bretl 

wrote:

One more time! :)

Conflicting files
geode-core/src/test/java/org/apache/geode/disttx/

PRDistTXDUnitTest.java

geode-core/src/test/java/org/apache/geode/disttx/

PRDistTXWithVersionsDUnitTest.java

geode-core/src/test/java/org/apache/geode/internal/cache/execute/

PRTransactionDUnitTest.java

--Mark

On Fri, Oct 21, 2016 at 12:08 PM, Jared Stewart 
wrote:

I just pulled and rebased onto develop, and force pushed into the

existing

pull request.  It should be clean to merge in now.

Thanks,
Jared

On Oct 21, 2016, at 11:57 AM, Mark Bretl 

wrote:

I believe there is enough consensus here to check this into

develop.

Jared, due to recent checkins into develop, can you update the pull

request

one more time? Trying to make this as clean as possible. I will

check

into

develop after the update, unless someone else gets to it first.

All, can we hold checkins on develop until the new formatter is

applied?

Thanks,

--Mark

On Fri, Oct 21, 2016 at 9:03 AM, Kenneth Howe 

wrote:

+1


On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt <

bschucha...@pivotal.io>

wrote:

+1

Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit :

+1


On 20/10/16 4:56 pm, Mark Bretl wrote:

+1 as well...

- Pulled changes
- Executed './gradlew clean build' and was successful.
- Modified a couple of random files to test
- Ran './gradlew clean build' again and failed expectedly
- Ran './gradlew spotlessApply', task was successful
- Ran './gradlew clean build' and succeeded

Great addition! As long as others are good with the formatter,

then I

am

good.

--Mark

On Thu, Oct 20, 2016 at 3:40 PM, Kirk Lund 

wrote:

+1 I just added my approval to the PR (and again here)


On Thu, Oct 20, 2016 at 3:25 PM, Jared Stewart <

jstew...@pivotal.io

wrote:


I have opened a pull request here <

https://github.com/apache/

incubator-geode/pull/268> to enable the Spotless plugin and

to

switch to

the Google Java Style formatter templates.



On Oct 18, 2016, at 4:32 PM, Kirk Lund 

wrote:

For reference TRAC #38741 was a bug with the summary

"EOFException

during

deserialize on client update with copy-on-read=true"

-Kirk


On Tue, Oct 18, 2016 at 4:27 PM, Jared Stewart <

jstew...@pivotal.io

wrote:

To give everyone an update, using the Google Java Style

eclipse

template

there is an issue spotlessCheck where fails for
geode-core/src/test/java/org/apache/geode/cache30/

Bug38741DUnitTest.java

even if you run it directly after spotlessApply. This needs

to

be

investigated and fixed before I can open a pull request to

enable

spotless.

On Oct 14, 2016, at 4:57 PM, Dan Smith 
wrote:

+1 - The formatting looks better now.

-Dan

On Thu, Oct 13, 2016 at 11:06 AM, Jared Stewart <

jstew...@pivotal.io

wrote:

I agree that the formatter needs fixing up.  Our wiki <
https://cwiki.apache.org/confluence/display/GEODE/Code+

Style+Guide>

says

that we follow the Google Java Style guide, but that is

no

Re: Review Request 53107: GEODE-2023: Add Lucene documentation

[Karen Miller]

> On Oct. 24, 2016, 5:56 p.m., Karen Miller wrote:
> > Ship It!

Nice addition to the documentation.  I also verified that the rat check passes.

Note that this patch will merge nicely into the develop branch, but will both 
be incorrect and cause a conflict in short order when the new paths to the 
documentation (hosted within Apache) get merged into the develop branch.  We 
can fix those issues when they occur.


- Karen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53107/#review153714
---


On Oct. 21, 2016, 10:56 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53107/
> ---
> 
> (Updated Oct. 21, 2016, 10:56 p.m.)
> 
> 
> Review request for geode, Joey McAllister and Karen Miller.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2023: Add Lucene documentation
> 
> 
> Diffs
> -
> 
>   geode-book/master_middleman/source/subnavs/geode-subnav.erb 
> 2373f4b397952372a61923c5b57ef8f6d2102ee3 
>   geode-docs/tools_modules/book_intro.html.md.erb 
> 852e3c9de6eba2f83f0c513912c53b771889509e 
>   geode-docs/tools_modules/lucene_integration.html.md.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53107/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Review Request 53107: GEODE-2023: Add Lucene documentation

[Karen Miller]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53107/#review153714
---


Ship it!




Ship It!

- Karen Miller


On Oct. 21, 2016, 10:56 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53107/
> ---
> 
> (Updated Oct. 21, 2016, 10:56 p.m.)
> 
> 
> Review request for geode, Joey McAllister and Karen Miller.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2023: Add Lucene documentation
> 
> 
> Diffs
> -
> 
>   geode-book/master_middleman/source/subnavs/geode-subnav.erb 
> 2373f4b397952372a61923c5b57ef8f6d2102ee3 
>   geode-docs/tools_modules/book_intro.html.md.erb 
> 852e3c9de6eba2f83f0c513912c53b771889509e 
>   geode-docs/tools_modules/lucene_integration.html.md.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53107/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Coding practices/standards

[Jared Stewart]

This is awesome, thank you for taking the time to figure out how to do this 
smoothly.

—Jared
> On Oct 24, 2016, at 10:40 AM, Dan Smith  wrote:
> 
> Doing a spotlessApply on my feature branch before rebasing didn't help
> bring down the number of conflicts.
> 
> I came up with this sequence of steps to rebase a feature branch on develop
> that avoids the need to manually resolve conflicts with the formatting
> changes. The trick here is to pick up *just* the formatting changes in one
> of the steps, and then reject any formatting changes that conflict with my
> changes.
> 
> #Rebase onto the commit before the spotless change. Resolve conflicts if any
> git rebase 56917a26a8916b83f0cec6e85285b5040ff66ee6
> 
> #Rebase onto the spotless change, automatically throwing away the
> formatting changes if they conflict.
> git rebase -Xtheirs c2319bb7a6201d5ae82ecb0fe23a1e3b8072c2e1
> 
> #Rebase onto the rest of develop. Resolve conflicts if any.
> git rebase origin/develop
> 
> #Apply formatting
> ./gradlew geode-core:spotlessApply
> 
> -Dan
> 
> On Fri, Oct 21, 2016 at 4:34 PM, Jared Stewart  wrote:
> 
>> Try this commit hash instead: d0175ec5aa8acf1b34ece3183fe03e9874450cbb
>> (from feature/spotlessPlugin).
>> 
>> 
>>> On Oct 21, 2016, at 4:16 PM, Kirk Lund  wrote:
>>> 
>>> FYI, feeb5c98402881156b34e222c58ce15c71a4fca7 doesn't exist in the
>> Apache
>>> git repo.
>>> 
>>> Is there a way to reformat a branch and then rebase on develop to
>> minimize
>>> conflicts?
>>> 
>>> -Kirk
>>> 
>>> 
>>> On Fri, Oct 21, 2016 at 1:36 PM, Jared Stewart 
>> wrote:
>>> 
 Fantastic, thanks for merging this in Mark.  For anyone with outstanding
 work on branches made before this change, your life may be made easier
>> by
 cherry-picking feeb5c98402881156b34e222c58ce15c71a4fca7 (which added
 Spotless) into your branch and then running ‘gradlew spotlessApply’ on
>> it
 before attempting to merge into develop.
 
 — Jared
> On Oct 21, 2016, at 1:33 PM, Mark Bretl  wrote:
> 
> Thanks Jared for the suggestion of Spotless and follow-up work.
> 
> This is now completed and checked into develop. As this does touch many
> files, be prepared the next time you pull.
> 
> --Mark
> 
> 
> 
> On Fri, Oct 21, 2016 at 1:21 PM, Jared Stewart 
 wrote:
> 
>> Done! :)
>> 
>> - Jared
>>> On Oct 21, 2016, at 12:27 PM, Mark Bretl 
>> wrote:
>>> 
>>> One more time! :)
>>> 
>>> Conflicting files
>>> geode-core/src/test/java/org/apache/geode/disttx/
 PRDistTXDUnitTest.java
>>> geode-core/src/test/java/org/apache/geode/disttx/
>> PRDistTXWithVersionsDUnitTest.java
>>> geode-core/src/test/java/org/apache/geode/internal/cache/execute/
>> PRTransactionDUnitTest.java
>>> 
>>> --Mark
>>> 
>>> On Fri, Oct 21, 2016 at 12:08 PM, Jared Stewart >> 
>> wrote:
>>> 
 I just pulled and rebased onto develop, and force pushed into the
>> existing
 pull request.  It should be clean to merge in now.
 
 Thanks,
 Jared
> On Oct 21, 2016, at 11:57 AM, Mark Bretl 
 wrote:
> 
> I believe there is enough consensus here to check this into
>> develop.
> 
> Jared, due to recent checkins into develop, can you update the pull
 request
> one more time? Trying to make this as clean as possible. I will
>> check
 into
> develop after the update, unless someone else gets to it first.
> 
> All, can we hold checkins on develop until the new formatter is
>> applied?
> 
> Thanks,
> 
> --Mark
> 
> On Fri, Oct 21, 2016 at 9:03 AM, Kenneth Howe 
>> wrote:
> 
>> +1
>> 
>>> On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt <
>> bschucha...@pivotal.io>
>> wrote:
>>> 
>>> +1
>>> 
>>> Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit :
 +1
 
 
 On 20/10/16 4:56 pm, Mark Bretl wrote:
> +1 as well...
> 
> - Pulled changes
> - Executed './gradlew clean build' and was successful.
> - Modified a couple of random files to test
> - Ran './gradlew clean build' again and failed expectedly
> - Ran './gradlew spotlessApply', task was successful
> - Ran './gradlew clean build' and succeeded
> 
> Great addition! As long as others are good with the formatter,
>> then I
>> am
> good.
> 
> --Mark
> 
> On Thu, Oct 20, 2016 at 3:40 PM, Kirk Lund 
>> wrote:
> 
>> +1 I just added my approval to the PR (and again here)
>> 
>> 
>> On Thu, Oct 20, 2016 at 3:25 PM, Jared Stewart <
>> jstew...@pivotal.io
>

Re: Coding practices/standards

[Dan Smith]

Doing a spotlessApply on my feature branch before rebasing didn't help
bring down the number of conflicts.

I came up with this sequence of steps to rebase a feature branch on develop
that avoids the need to manually resolve conflicts with the formatting
changes. The trick here is to pick up *just* the formatting changes in one
of the steps, and then reject any formatting changes that conflict with my
changes.

#Rebase onto the commit before the spotless change. Resolve conflicts if any
git rebase 56917a26a8916b83f0cec6e85285b5040ff66ee6

#Rebase onto the spotless change, automatically throwing away the
formatting changes if they conflict.
git rebase -Xtheirs c2319bb7a6201d5ae82ecb0fe23a1e3b8072c2e1

#Rebase onto the rest of develop. Resolve conflicts if any.
git rebase origin/develop

#Apply formatting
./gradlew geode-core:spotlessApply

-Dan

On Fri, Oct 21, 2016 at 4:34 PM, Jared Stewart  wrote:

> Try this commit hash instead: d0175ec5aa8acf1b34ece3183fe03e9874450cbb
> (from feature/spotlessPlugin).
>
>
> > On Oct 21, 2016, at 4:16 PM, Kirk Lund  wrote:
> >
> > FYI, feeb5c98402881156b34e222c58ce15c71a4fca7 doesn't exist in the
> Apache
> > git repo.
> >
> > Is there a way to reformat a branch and then rebase on develop to
> minimize
> > conflicts?
> >
> > -Kirk
> >
> >
> > On Fri, Oct 21, 2016 at 1:36 PM, Jared Stewart 
> wrote:
> >
> >> Fantastic, thanks for merging this in Mark.  For anyone with outstanding
> >> work on branches made before this change, your life may be made easier
> by
> >> cherry-picking feeb5c98402881156b34e222c58ce15c71a4fca7 (which added
> >> Spotless) into your branch and then running ‘gradlew spotlessApply’ on
> it
> >> before attempting to merge into develop.
> >>
> >> — Jared
> >>> On Oct 21, 2016, at 1:33 PM, Mark Bretl  wrote:
> >>>
> >>> Thanks Jared for the suggestion of Spotless and follow-up work.
> >>>
> >>> This is now completed and checked into develop. As this does touch many
> >>> files, be prepared the next time you pull.
> >>>
> >>> --Mark
> >>>
> >>>
> >>>
> >>> On Fri, Oct 21, 2016 at 1:21 PM, Jared Stewart 
> >> wrote:
> >>>
>  Done! :)
> 
>  - Jared
> > On Oct 21, 2016, at 12:27 PM, Mark Bretl 
> wrote:
> >
> > One more time! :)
> >
> > Conflicting files
> > geode-core/src/test/java/org/apache/geode/disttx/
> >> PRDistTXDUnitTest.java
> > geode-core/src/test/java/org/apache/geode/disttx/
>  PRDistTXWithVersionsDUnitTest.java
> > geode-core/src/test/java/org/apache/geode/internal/cache/execute/
>  PRTransactionDUnitTest.java
> >
> > --Mark
> >
> > On Fri, Oct 21, 2016 at 12:08 PM, Jared Stewart  >
>  wrote:
> >
> >> I just pulled and rebased onto develop, and force pushed into the
>  existing
> >> pull request.  It should be clean to merge in now.
> >>
> >> Thanks,
> >> Jared
> >>> On Oct 21, 2016, at 11:57 AM, Mark Bretl 
> >> wrote:
> >>>
> >>> I believe there is enough consensus here to check this into
> develop.
> >>>
> >>> Jared, due to recent checkins into develop, can you update the pull
> >> request
> >>> one more time? Trying to make this as clean as possible. I will
> check
> >> into
> >>> develop after the update, unless someone else gets to it first.
> >>>
> >>> All, can we hold checkins on develop until the new formatter is
>  applied?
> >>>
> >>> Thanks,
> >>>
> >>> --Mark
> >>>
> >>> On Fri, Oct 21, 2016 at 9:03 AM, Kenneth Howe 
>  wrote:
> >>>
>  +1
> 
> > On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt <
>  bschucha...@pivotal.io>
>  wrote:
> >
> > +1
> >
> > Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit :
> >> +1
> >>
> >>
> >> On 20/10/16 4:56 pm, Mark Bretl wrote:
> >>> +1 as well...
> >>>
> >>> - Pulled changes
> >>> - Executed './gradlew clean build' and was successful.
> >>> - Modified a couple of random files to test
> >>> - Ran './gradlew clean build' again and failed expectedly
> >>> - Ran './gradlew spotlessApply', task was successful
> >>> - Ran './gradlew clean build' and succeeded
> >>>
> >>> Great addition! As long as others are good with the formatter,
>  then I
>  am
> >>> good.
> >>>
> >>> --Mark
> >>>
> >>> On Thu, Oct 20, 2016 at 3:40 PM, Kirk Lund 
>  wrote:
> >>>
>  +1 I just added my approval to the PR (and again here)
> 
> 
>  On Thu, Oct 20, 2016 at 3:25 PM, Jared Stewart <
>  jstew...@pivotal.io
> >>>
>  wrote:
> 
> > I have opened a pull request here <
> https://github.com/apache/
> > incubator-geode/pull/268> to enable the Spotless plugin and
> to
>  switch to
> > the Google Jav

Re: Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53026/#review153706
---


Ship it!




Ship It!

- Dan Smith


On Oct. 24, 2016, 4:33 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53026/
> ---
> 
> (Updated Oct. 24, 2016, 4:33 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * While creating VMs for the DUnit tests sometimes GC may kick in
> * But the test framework requires the VMs to be ready within 30 seconds.
> * So we have increased the timeout to 2min to account for the time consumed 
> by GC
> * This is to handle errors in CI running in slower machines.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
>  6618d2a 
> 
> Diff: https://reviews.apache.org/r/53026/diff/
> 
> 
> Testing
> ---
> 
> precheck
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53026/
---

Review request for geode and Dan Smith.


Repository: geode


Description
---

* While creating VMs for the DUnit tests sometimes GC may kick in
* But the test framework requires the VMs to be ready within 30 seconds.
* So we have increased the timeout to 2min to account for the time consumed by 
GC
* This is to handle errors in CI running in slower machines.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
 6618d2a 

Diff: https://reviews.apache.org/r/53026/diff/


Testing
---

precheck


Thanks,

nabarun nag