Re: [VOTE] Release Mail 2.0.0-M1
Side note: referencing tag+hash + dist (dev) area (only thing we vote against) would be neat for future votes since we dont vote on a staging repo. Anyway thanks for doing it, really great to see you back ;) PS: dont forget jira and site updates, we missed it by the past and hurts way later when we need to catch up. Le lun. 23 mai 2022 à 18:15, David Blevins a écrit : > Vote passes with 6 +1s (4 binding) > > As noted in the other vote I didn't propose a final as we haven't yet run > the full set of TCK tests for this library, specifically the signature > tests. In particular, the signature tests verify all the classes and > method signatures match the expected set and there are no > additions/changes, etc. These are separate from the > com.sun.ts.tests.javamail tests. > > In the past we would always ensure these tests before releasing. > > > -David > > > > On May 14, 2022, at 2:27 PM, David Blevins > wrote: > > > > Hey All, > > > > If I was thinking ahead I'd have put these both in the same staging repo > and vote :) > > > > Staging Maven repository: > > > > - > https://repository.apache.org/content/repositories/orgapachegeronimo-1153/ > > > > The only change is conversion from javax to the jakarta namespace via > contributor Richard Zowalla and a change from "javamail" to simply "mail" > > > > > > Please vote to approve this release: > > [ ] +1 Approve the release > > [ ] 0 Abstain (please provide specific comments) > > [ ] -1 Don't approve the release (please provide specific comments) > > > > This vote will be open for at least 72 hours. > > > > -David > > > >
GERONIMO-6832 - SigTests + TCK Failures for Activation 2.0.0-M1
Hi all, I gave it a try: the main issues were related to the change regarding java.desktop. I added a patch (svn diff) to https://issues.apache.org/jira/browse/GERONIMO-6832 with some changes. With this changes, the TCK + Sigtests are now passing for Java 8 + Java 11: [javatest.batch] Number of tests completed: 90 (90 pass, 0 fail, 0 errors) [javatest.batch] *** [javatest.batch] Completed running 90 tests. [javatest.batch] Number of Tests Passed = 90 [javatest.batch] Number of Tests Failed = 0 [javatest.batch] Number of Tests with Errors = 0 [javatest.batch] Number of Tests Not Run = 0 If someone can have a look, it would be appreciated. Gruß Richard Am Montag, dem 23.05.2022 um 18:47 + schrieb Zowalla, Richard: > Hi all, > > I did run the sig tests + tck on the 2.0.0-M1 and found some issues. > Subsequently, I created > https://issues.apache.org/jira/browse/GERONIMO-6832 and will try to > fix > them. > > Gruß > Richard >
[jira] [Comment Edited] (GERONIMO-6832) Fix TCK + Signature Tests for geronimo-activation_2.0_spec
[
https://issues.apache.org/jira/browse/GERONIMO-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541138#comment-17541138
]
Richard Zowalla edited comment on GERONIMO-6832 at 5/23/22 7:48 PM:
{code:java}
[javatest.batch] Number of tests completed: 90 (90 pass, 0 fail, 0 errors)
[javatest.batch] ***
[javatest.batch] Completed running 90 tests.
[javatest.batch] Number of Tests Passed = 90
[javatest.batch] Number of Tests Failed = 0
[javatest.batch] Number of Tests with Errors = 0
[javatest.batch] Number of Tests Not Run = 0
[javatest.batch] ---
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/ActivationDataFlavor_Test.java#ActivationDataFlavor_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/equals_Test.java#equals_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/getHumanPresentableName_Test.java#getHumanPresentableName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/getMimeType_Test.java#getMimeType_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/getRepresentationClass_Test.java#getRepresentationClass_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/isMimeTypeEqual_Test.java#isMimeTypeEqual_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/normalizeMimeType_Test.java#normalizeMimeType_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/normalizeMimeTypeParameter_Test.java#normalizeMimeTypeParameter_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/setHumanPresentableName_Test.java#setHumanPresentableName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/CommandInfo_Test.java#CommandInfo_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/getCommandClass_Test.java#getCommandClass_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/getCommandName_Test.java#getCommandName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/getCommandObject_Test.java#getCommandObject_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getAllCommands_Test.java#getAllCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getCommand_Test.java#getCommand_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getDefaultCommandMap_Test.java#getDefaultCommandMap_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getPreferredCommands_Test.java#getPreferredCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/setDefaultCommandMap_Test.java#setDefaultCommandMap_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/DataHandler_Test.java#DataHandler_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getAllCommands_Test.java#getAllCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getBean_Test.java#getBean_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getCommand_Test.java#getCommand_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getContent_Test.java#getContent_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getContentType_Test.java#getContentType_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getDataSource_Test.java#getDataSource_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getInputStream_Test.java#getInputStream_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getName_Test.java#getName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getOutputStream_Test.java#getOutputStream_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getPreferredCommands_Test.java#getPreferredCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getTransferData_Test.java#getTransferData_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getTransferDataFlavors_Test.java
[jira] [Commented] (GERONIMO-6832) Fix TCK + Signature Tests for geronimo-activation_2.0_spec
[
https://issues.apache.org/jira/browse/GERONIMO-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541138#comment-17541138
]
Richard Zowalla commented on GERONIMO-6832:
---
{code:java}
[javatest.batch] Number of tests completed: 90 (90 pass, 0 fail, 0 errors)
[javatest.batch] ***
[javatest.batch] Completed running 90 tests.
[javatest.batch] Number of Tests Passed = 90
[javatest.batch] Number of Tests Failed = 0
[javatest.batch] Number of Tests with Errors = 0
[javatest.batch] Number of Tests Not Run = 0
[javatest.batch] ---
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/ActivationDataFlavor_Test.java#ActivationDataFlavor_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/equals_Test.java#equals_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/getHumanPresentableName_Test.java#getHumanPresentableName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/getMimeType_Test.java#getMimeType_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/getRepresentationClass_Test.java#getRepresentationClass_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/isMimeTypeEqual_Test.java#isMimeTypeEqual_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/normalizeMimeType_Test.java#normalizeMimeType_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/normalizeMimeTypeParameter_Test.java#normalizeMimeTypeParameter_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/ActivationDataFlavor/setHumanPresentableName_Test.java#setHumanPresentableName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/CommandInfo_Test.java#CommandInfo_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/getCommandClass_Test.java#getCommandClass_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/getCommandName_Test.java#getCommandName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandInfo/getCommandObject_Test.java#getCommandObject_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getAllCommands_Test.java#getAllCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getCommand_Test.java#getCommand_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getDefaultCommandMap_Test.java#getDefaultCommandMap_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/getPreferredCommands_Test.java#getPreferredCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/CommandMap/setDefaultCommandMap_Test.java#setDefaultCommandMap_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/DataHandler_Test.java#DataHandler_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getAllCommands_Test.java#getAllCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getBean_Test.java#getBean_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getCommand_Test.java#getCommand_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getContent_Test.java#getContent_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getContentType_Test.java#getContentType_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getDataSource_Test.java#getDataSource_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getInputStream_Test.java#getInputStream_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getName_Test.java#getName_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getOutputStream_Test.java#getOutputStream_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getPreferredCommands_Test.java#getPreferredCommands_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getTransferData_Test.java#getTransferData_Test
[javatest.batch]
PASSEDjavasoft/sqe/tests/api/jakarta/activation/DataHandler/getTransferDataFlavors_Test.java#getTransferDataFlavors_Test
[javatest.batch]
PA
[jira] [Updated] (GERONIMO-6832) Fix TCK + Signature Tests for geronimo-activation_2.0_spec
[ https://issues.apache.org/jira/browse/GERONIMO-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Zowalla updated GERONIMO-6832: -- Attachment: GERONIMO-6832.diff > Fix TCK + Signature Tests for geronimo-activation_2.0_spec > -- > > Key: GERONIMO-6832 > URL: https://issues.apache.org/jira/browse/GERONIMO-6832 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) >Reporter: Richard Zowalla >Priority: Major > Attachments: GERONIMO-6832.diff > > > Did run the sigtests + TCK and found some issues. > Sigtests currently fail due to some issues regarding the removal of the > depenency towards java.desktop + TCK also have has issues. > Did test with the milestone version. I will try to fix them. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (GERONIMO-6832) Fix TCK + Signature Tests for geronimo-activation_2.0_spec
Richard Zowalla created GERONIMO-6832: - Summary: Fix TCK + Signature Tests for geronimo-activation_2.0_spec Key: GERONIMO-6832 URL: https://issues.apache.org/jira/browse/GERONIMO-6832 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Reporter: Richard Zowalla Did run the sigtests + TCK and found some issues. Sigtests currently fail due to some issues regarding the removal of the depenency towards java.desktop + TCK also have has issues. Did test with the milestone version. I will try to fix them. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: [RESULT] Release Activation 2.0.0-M1
Hi all, I did run the sig tests + tck on the 2.0.0-M1 and found some issues. Subsequently, I created https://issues.apache.org/jira/browse/GERONIMO-6832 and will try to fix them. Gruß Richard Am Montag, dem 23.05.2022 um 08:55 -0700 schrieb David Blevins: > Vote passes with 6 +1s (4 binding) > > As noted I didn't go for a final as we still haven't run the full set > of TCK tests which include the signature tests. If someone would > like to do that or propose a final without doing that, they're > welcome to do so. > > > -David > > > > On May 14, 2022, at 2:00 PM, David Blevins > > wrote: > > > > Hey All, > > > > We're thinking to do a release on the TomEE side and this is one of > > the snapshot dependencies we have. I've prepped a 2.0.0-M1 with > > the idea that being a milestone it should be fairly non- > > controversial to propose without a heads up and I haven't checked > > the TCK status. I know we're not yet actively running the > > signature tests on the TomEE side. > > > > I propose we release 2.0.0-M1 so we have some non-snapshots to work > > with and come back to 2.0.0 as things look 100% on all fronts > > > > Staging Maven repository: > > > > - > > https://repository.apache.org/content/repositories/orgapachegeronimo-1153/ > > > > The only change is conversion from javax to the jakarta namespace > > via contributor Richard Zowalla. > > > > > > Please vote to approve this release: > > [ ] +1 Approve the release > > [ ] 0 Abstain (please provide specific comments) > > [ ] -1 Don't approve the release (please provide specific comments) > > > > This vote will be open for at least 72 hours. > > > > -David > >
Re: [VOTE] Release Mail 2.0.0-M1
Vote passes with 6 +1s (4 binding) As noted in the other vote I didn't propose a final as we haven't yet run the full set of TCK tests for this library, specifically the signature tests. In particular, the signature tests verify all the classes and method signatures match the expected set and there are no additions/changes, etc. These are separate from the com.sun.ts.tests.javamail tests. In the past we would always ensure these tests before releasing. -David > On May 14, 2022, at 2:27 PM, David Blevins wrote: > > Hey All, > > If I was thinking ahead I'd have put these both in the same staging repo and > vote :) > > Staging Maven repository: > > - https://repository.apache.org/content/repositories/orgapachegeronimo-1153/ > > The only change is conversion from javax to the jakarta namespace via > contributor Richard Zowalla and a change from "javamail" to simply "mail" > > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Abstain (please provide specific comments) > [ ] -1 Don't approve the release (please provide specific comments) > > This vote will be open for at least 72 hours. > > -David > smime.p7s Description: S/MIME cryptographic signature
Re: [VOTE] Release Mail 2.0.0-M1
+1 (binding) -David > On May 14, 2022, at 2:27 PM, David Blevins wrote: > > Hey All, > > If I was thinking ahead I'd have put these both in the same staging repo and > vote :) > > Staging Maven repository: > > - https://repository.apache.org/content/repositories/orgapachegeronimo-1153/ > > The only change is conversion from javax to the jakarta namespace via > contributor Richard Zowalla and a change from "javamail" to simply "mail" > > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Abstain (please provide specific comments) > [ ] -1 Don't approve the release (please provide specific comments) > > This vote will be open for at least 72 hours. > > -David > smime.p7s Description: S/MIME cryptographic signature
[RESULT] Release Activation 2.0.0-M1
Vote passes with 6 +1s (4 binding) As noted I didn't go for a final as we still haven't run the full set of TCK tests which include the signature tests. If someone would like to do that or propose a final without doing that, they're welcome to do so. -David > On May 14, 2022, at 2:00 PM, David Blevins wrote: > > Hey All, > > We're thinking to do a release on the TomEE side and this is one of the > snapshot dependencies we have. I've prepped a 2.0.0-M1 with the idea that > being a milestone it should be fairly non-controversial to propose without a > heads up and I haven't checked the TCK status. I know we're not yet actively > running the signature tests on the TomEE side. > > I propose we release 2.0.0-M1 so we have some non-snapshots to work with and > come back to 2.0.0 as things look 100% on all fronts > > Staging Maven repository: > > - https://repository.apache.org/content/repositories/orgapachegeronimo-1153/ > > The only change is conversion from javax to the jakarta namespace via > contributor Richard Zowalla. > > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Abstain (please provide specific comments) > [ ] -1 Don't approve the release (please provide specific comments) > > This vote will be open for at least 72 hours. > > -David > smime.p7s Description: S/MIME cryptographic signature
Re: [VOTE] Release Activation 2.0.0-M1
My +1 -David > On May 14, 2022, at 2:00 PM, David Blevins wrote: > > Hey All, > > We're thinking to do a release on the TomEE side and this is one of the > snapshot dependencies we have. I've prepped a 2.0.0-M1 with the idea that > being a milestone it should be fairly non-controversial to propose without a > heads up and I haven't checked the TCK status. I know we're not yet actively > running the signature tests on the TomEE side. > > I propose we release 2.0.0-M1 so we have some non-snapshots to work with and > come back to 2.0.0 as things look 100% on all fronts > > Staging Maven repository: > > - https://repository.apache.org/content/repositories/orgapachegeronimo-1153/ > > The only change is conversion from javax to the jakarta namespace via > contributor Richard Zowalla. > > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Abstain (please provide specific comments) > [ ] -1 Don't approve the release (please provide specific comments) > > This vote will be open for at least 72 hours. > > -David > smime.p7s Description: S/MIME cryptographic signature
