[jira] Commented: (GERONIMODEVTOOLS-325) Download and Install button should be disabled/enabled appropriately
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622119#action_12622119 ] Ashish Jain commented on GERONIMODEVTOOLS-325: -- This JIRA can be closed as this feature will no longer be available from GEP 2.1.2 onwards. Download and Install button should be disabled/enabled appropriately -- Key: GERONIMODEVTOOLS-325 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 Project: Geronimo-Devtools Issue Type: Bug Components: eclipse-plugin Affects Versions: 2.1.2 Reporter: B.J. Reed Assignee: B.J. Reed Priority: Trivial Fix For: 2.1.2 Attachments: GERONIMODEVTOOLS-325.patch After selecting which server I want to use, the Application Server Installation Directory field is blank and the Download and Install button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. If I enter a directory that does not exist, a message shows at the top of the dialog saying The specified directory does not exist. 2) the button should be disabled when that message appears and enabled when one of the download allowable messages appears (there seem to be several). 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the Download and Install button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-325) Download and Install button should be disabled/enabled appropriately
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619825#action_12619825 ] Ashish Jain commented on GERONIMODEVTOOLS-325: -- Removing patches from JIRA as I will be uploading a new one. Download and Install button should be disabled/enabled appropriately -- Key: GERONIMODEVTOOLS-325 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 Project: Geronimo-Devtools Issue Type: Bug Components: eclipse-plugin Affects Versions: 2.1.2 Reporter: B.J. Reed Assignee: B.J. Reed Priority: Trivial Fix For: 2.1.2 After selecting which server I want to use, the Application Server Installation Directory field is blank and the Download and Install button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. If I enter a directory that does not exist, a message shows at the top of the dialog saying The specified directory does not exist. 2) the button should be disabled when that message appears and enabled when one of the download allowable messages appears (there seem to be several). 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the Download and Install button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-325) Download and Install button should be disabled/enabled appropriately
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619815#action_12619815 ] Ashish Jain commented on GERONIMODEVTOOLS-325: -- Hi BJ, Thanks for your comments. Not sure why you got the compilation error. However just wanted to explain more on this fix. The idea about this fix was to segregate Download and Install from Specify An Existing Application Server Installation Directory text box. That is why there are two DirectoryDialog 1) For an existing geronimo installation. 2) For a new installation directory. 1) type in C:\f\geronimo-tomcat6-javaee5-2.1.1 in the entry field and click download and install since it looks enabled (nothing happens). failed because you need to give a valid directory. However I guess this patch may still confuse users. I will go ahead and modify the patch and upload an updated one soon. Download and Install button should be disabled/enabled appropriately -- Key: GERONIMODEVTOOLS-325 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 Project: Geronimo-Devtools Issue Type: Bug Components: eclipse-plugin Affects Versions: 2.1.2 Reporter: B.J. Reed Assignee: B.J. Reed Priority: Trivial Fix For: 2.1.2 Attachments: GERONIMODEVTOOLS-325.patch, GERONIMODEVTOOLS-325_updated.patch, GERONIMODEVTOOLS-325_updated_latest.patch After selecting which server I want to use, the Application Server Installation Directory field is blank and the Download and Install button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. If I enter a directory that does not exist, a message shows at the top of the dialog saying The specified directory does not exist. 2) the button should be disabled when that message appears and enabled when one of the download allowable messages appears (there seem to be several). 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the Download and Install button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-325) Download and Install button should be disabled/enabled appropriately
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619885#action_12619885 ] B.J. Reed commented on GERONIMODEVTOOLS-325: Thanks Ashish for taking a second look at this. I like this solution better than the first. To whoever commits the patch, when I applied it, it still changed the CofirmationInstallDialog dialog line that I mentioned above (maybe it's just my machine), so please verify that this line doesn't get changed in the long run. Download and Install button should be disabled/enabled appropriately -- Key: GERONIMODEVTOOLS-325 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 Project: Geronimo-Devtools Issue Type: Bug Components: eclipse-plugin Affects Versions: 2.1.2 Reporter: B.J. Reed Assignee: B.J. Reed Priority: Trivial Fix For: 2.1.2 Attachments: GERONIMODEVTOOLS-325.patch After selecting which server I want to use, the Application Server Installation Directory field is blank and the Download and Install button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. If I enter a directory that does not exist, a message shows at the top of the dialog saying The specified directory does not exist. 2) the button should be disabled when that message appears and enabled when one of the download allowable messages appears (there seem to be several). 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the Download and Install button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-325) Download and Install button should be disabled/enabled appropriately
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12620039#action_12620039 ] Tim McConnell commented on GERONIMODEVTOOLS-325: HI Ashish, thanks for working on this and you seem to be getting much closer. There are still a couple small problems though: 1. When using the Download and Install button, it forces me to browse to a location whereas before it used to allow me to enter a directory of my choice manually. It's probably better to allow both manual entry and the usage of the Browse button and let the user decide which they would like to do. 2. It's a bit confusing having one variable named installDir (with uppercase 'D') and another one named installdir (with lowercase 'd') 3. After the Download and Install button is clicked, the GEP does in fact download the zip file for the server. It should then populate the installation directory text field so that the Next or Finish button can be immediately clicked. As it is now with your patch, it forces the user to Browse to the installation directory, which is not what we want. Download and Install button should be disabled/enabled appropriately -- Key: GERONIMODEVTOOLS-325 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 Project: Geronimo-Devtools Issue Type: Bug Components: eclipse-plugin Affects Versions: 2.1.2 Reporter: B.J. Reed Assignee: B.J. Reed Priority: Trivial Fix For: 2.1.2 Attachments: GERONIMODEVTOOLS-325.patch After selecting which server I want to use, the Application Server Installation Directory field is blank and the Download and Install button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. If I enter a directory that does not exist, a message shows at the top of the dialog saying The specified directory does not exist. 2) the button should be disabled when that message appears and enabled when one of the download allowable messages appears (there seem to be several). 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the Download and Install button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-325) Download and Install button should be disabled/enabled appropriately
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619526#action_12619526 ] B.J. Reed commented on GERONIMODEVTOOLS-325: This is an improvement. I had a problem installing the patch, specifically, there is a snippet of code that was changed from ConfirmInstallDialog dialog = new ConfirmInstallDialog(shell, getRuntimeName(), installDir.getText(), license); to ConfirmInstallDialog dialog = new ConfirmInstallDialog(shell, getRuntimeName(), installDir, license); This line did not compile. Changing it back made it compile. After making that change, the processing seems a little better, but it would be nice to have the download and install button visually grayed out so that the user knew by looking at it that it is not enabled. Also what happens now if I want to download to a new directory doesn't really seem very good. Clarifying my steps and what I see I want to download into a new direcotry of c:\f 1. type in C:\f\geronimo-tomcat6-javaee5-2.1.1 in the entry field and click download and install since it looks enabled (nothing happens). 2. Click Browse and create the necessary folders 3. Now clicking download and install brings up the same dialog I just had when I clicked on the browse button. (why is this dialog here? I already have the correct text in the entry field for where I want to download to) Then it proceeds to the license and downloading. Download and Install button should be disabled/enabled appropriately -- Key: GERONIMODEVTOOLS-325 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 Project: Geronimo-Devtools Issue Type: Bug Components: eclipse-plugin Affects Versions: 2.1.2 Reporter: B.J. Reed Assignee: B.J. Reed Priority: Trivial Fix For: 2.1.2 Attachments: GERONIMODEVTOOLS-325.patch, GERONIMODEVTOOLS-325_updated.patch, GERONIMODEVTOOLS-325_updated_latest.patch After selecting which server I want to use, the Application Server Installation Directory field is blank and the Download and Install button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. If I enter a directory that does not exist, a message shows at the top of the dialog saying The specified directory does not exist. 2) the button should be disabled when that message appears and enabled when one of the download allowable messages appears (there seem to be several). 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the Download and Install button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-325) Download and Install button should be disabled/enabled appropriately
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12607412#action_12607412 ] Ted Kirby commented on GERONIMODEVTOOLS-325: If you work on this, you might also consider looking at: GERONIMODEVTOOLS-334 Download and Install fails, and hoses eclipse for plugin development which suggests a case (if it can be detected) when the button should not be shown at all. Download and Install button should be disabled/enabled appropriately -- Key: GERONIMODEVTOOLS-325 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 Project: Geronimo-Devtools Issue Type: Bug Components: eclipse-plugin Affects Versions: 2.1.2 Reporter: B.J. Reed Assignee: Tim McConnell Priority: Trivial Fix For: 2.1.2 After selecting which server I want to use, the Application Server Installation Directory field is blank and the Download and Install button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. If I enter a directory that does not exist, a message shows at the top of the dialog saying The specified directory does not exist. 2) the button should be disabled when that message appears and enabled when one of the download allowable messages appears (there seem to be several). 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the Download and Install button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
