Re: New module: geronimo-testsupport
TestNG does not require 1.5, it can use Javadoc-style annotations.
But, I am not planning on doing anything at the moment to switch the
build over to TestNG. I do however think that is the right
direction. But right now I'm more concerned about getting tests to
use logging and not spit out tons of junk when running.
--jason
On Aug 19, 2006, at 9:52 PM, Bill Dudney wrote:
Hi Jason,
If you have it extending from TestCase then people will use those
methods in writing their tests which would force the dependency
even if unintended.
Could we make this class a decorator? Then many fewer would be
likely to use it as a superclass but instead would import it and
use it simply to decorate their tests.
BTW I'm all for doing this module and I don't want the TestNG vs
JUnit discussion to detract from getting started. Since it requires
JDK 5 it might be worth forgetting TestNG for now and looking to
convert to TestNG after the move the jdk 5 is complete.
TTFN,
-bd-
On Aug 19, 2006, at 4:10 PM, Jason Dillon wrote:
I'm all for TestNG... hopefully now the maven reports are all
happy since its now supported by surefire.
But, the TestSupport classes does not need to be JUnit specific,
the same code will work fine in TestNG... and once we switch over
to TNG fully (if or when that is), all we need to do (optionally)
is drop the extends from TestCase and everything else should be fine.
--jason
On Aug 19, 2006, at 8:49 AM, Bill Dudney wrote:
Hi Jason,
Before going too deeply in to the JUnit space what do you think
of using TestNG. I've used it on a couple of applications and
found it very nice to work with. Its yet another reason to move
to JDK 5 though so I'm not sure about timing (although you can
use it with JDK 1.4 I've not done that and I don't like
annotations in comments generally).
TTFN,
-bd-
On Aug 17, 2006, at 4:48 PM, Jason Dillon wrote:
Most likely.
--jason
On Aug 17, 2006, at 3:42 PM, David Jencks wrote:
YAY!!!
Can you make the File ref to ${basedir} work in idea without
setting test properties?
thanks
david jencks
On Aug 17, 2006, at 3:24 PM, Jason Dillon wrote:
I'd like to add a new module to our build, geronimo-
testsupport, which provides at the moment a single TestSupport
class which sets up logging and some other commonly used bits
(like the File ref to ${basedir}).
And then incrementally I'd like for all of our test classes to
extend from this instead of junit.framework.TestCase.
Any objections?
--jason
Re: New module: geronimo-testsupport
Hi Jason,
Before going too deeply in to the JUnit space what do you think of
using TestNG. I've used it on a couple of applications and found it
very nice to work with. Its yet another reason to move to JDK 5
though so I'm not sure about timing (although you can use it with JDK
1.4 I've not done that and I don't like annotations in comments
generally).
TTFN,
-bd-
On Aug 17, 2006, at 4:48 PM, Jason Dillon wrote:
Most likely.
--jason
On Aug 17, 2006, at 3:42 PM, David Jencks wrote:
YAY!!!
Can you make the File ref to ${basedir} work in idea without
setting test properties?
thanks
david jencks
On Aug 17, 2006, at 3:24 PM, Jason Dillon wrote:
I'd like to add a new module to our build, geronimo-testsupport,
which provides at the moment a single TestSupport class which
sets up logging and some other commonly used bits (like the File
ref to ${basedir}).
And then incrementally I'd like for all of our test classes to
extend from this instead of junit.framework.TestCase.
Any objections?
--jason
Re: New module: geronimo-testsupport
I'm all for TestNG... hopefully now the maven reports are all happy
since its now supported by surefire.
But, the TestSupport classes does not need to be JUnit specific, the
same code will work fine in TestNG... and once we switch over to TNG
fully (if or when that is), all we need to do (optionally) is drop
the extends from TestCase and everything else should be fine.
--jason
On Aug 19, 2006, at 8:49 AM, Bill Dudney wrote:
Hi Jason,
Before going too deeply in to the JUnit space what do you think of
using TestNG. I've used it on a couple of applications and found it
very nice to work with. Its yet another reason to move to JDK 5
though so I'm not sure about timing (although you can use it with
JDK 1.4 I've not done that and I don't like annotations in comments
generally).
TTFN,
-bd-
On Aug 17, 2006, at 4:48 PM, Jason Dillon wrote:
Most likely.
--jason
On Aug 17, 2006, at 3:42 PM, David Jencks wrote:
YAY!!!
Can you make the File ref to ${basedir} work in idea without
setting test properties?
thanks
david jencks
On Aug 17, 2006, at 3:24 PM, Jason Dillon wrote:
I'd like to add a new module to our build, geronimo-testsupport,
which provides at the moment a single TestSupport class which
sets up logging and some other commonly used bits (like the File
ref to ${basedir}).
And then incrementally I'd like for all of our test classes to
extend from this instead of junit.framework.TestCase.
Any objections?
--jason
Re: New module: geronimo-testsupport
On Aug 19, 2006, at 3:10 PM, Jason Dillon wrote: I'm all for TestNG... hopefully now the maven reports are all happy since its now supported by surefire. But, the TestSupport classes does not need to be JUnit specific, the same code will work fine in TestNG... and once we switch over to TNG fully (if or when that is), all we need to do (optionally) is drop the extends from TestCase and everything else should be fine. How would that be possible since TestCase is what imports the assert methods? -dain
Re: New module: geronimo-testsupport
My point was that TestSupport is as of right now now dependent on JUnit. But, even if we do move on to use TestNG there is no major reason why we would need to change the parent class... we could, but don't have to. --jason On Aug 19, 2006, at 5:21 PM, Dain Sundstrom wrote: On Aug 19, 2006, at 3:10 PM, Jason Dillon wrote: I'm all for TestNG... hopefully now the maven reports are all happy since its now supported by surefire. But, the TestSupport classes does not need to be JUnit specific, the same code will work fine in TestNG... and once we switch over to TNG fully (if or when that is), all we need to do (optionally) is drop the extends from TestCase and everything else should be fine. How would that be possible since TestCase is what imports the assert methods? -dain
Re: New module: geronimo-testsupport
Hi Jason,
If you have it extending from TestCase then people will use those
methods in writing their tests which would force the dependency even
if unintended.
Could we make this class a decorator? Then many fewer would be likely
to use it as a superclass but instead would import it and use it
simply to decorate their tests.
BTW I'm all for doing this module and I don't want the TestNG vs
JUnit discussion to detract from getting started. Since it requires
JDK 5 it might be worth forgetting TestNG for now and looking to
convert to TestNG after the move the jdk 5 is complete.
TTFN,
-bd-
On Aug 19, 2006, at 4:10 PM, Jason Dillon wrote:
I'm all for TestNG... hopefully now the maven reports are all happy
since its now supported by surefire.
But, the TestSupport classes does not need to be JUnit specific,
the same code will work fine in TestNG... and once we switch over
to TNG fully (if or when that is), all we need to do (optionally)
is drop the extends from TestCase and everything else should be fine.
--jason
On Aug 19, 2006, at 8:49 AM, Bill Dudney wrote:
Hi Jason,
Before going too deeply in to the JUnit space what do you think of
using TestNG. I've used it on a couple of applications and found
it very nice to work with. Its yet another reason to move to JDK 5
though so I'm not sure about timing (although you can use it with
JDK 1.4 I've not done that and I don't like annotations in
comments generally).
TTFN,
-bd-
On Aug 17, 2006, at 4:48 PM, Jason Dillon wrote:
Most likely.
--jason
On Aug 17, 2006, at 3:42 PM, David Jencks wrote:
YAY!!!
Can you make the File ref to ${basedir} work in idea without
setting test properties?
thanks
david jencks
On Aug 17, 2006, at 3:24 PM, Jason Dillon wrote:
I'd like to add a new module to our build, geronimo-
testsupport, which provides at the moment a single TestSupport
class which sets up logging and some other commonly used bits
(like the File ref to ${basedir}).
And then incrementally I'd like for all of our test classes to
extend from this instead of junit.framework.TestCase.
Any objections?
--jason
New module: geronimo-testsupport
I'd like to add a new module to our build, geronimo-testsupport,
which provides at the moment a single TestSupport class which sets up
logging and some other commonly used bits (like the File ref to $
{basedir}).
And then incrementally I'd like for all of our test classes to extend
from this instead of junit.framework.TestCase.
Any objections?
--jason
Re: New module: geronimo-testsupport
YAY!!!
Can you make the File ref to ${basedir} work in idea without setting
test properties?
thanks
david jencks
On Aug 17, 2006, at 3:24 PM, Jason Dillon wrote:
I'd like to add a new module to our build, geronimo-testsupport,
which provides at the moment a single TestSupport class which sets
up logging and some other commonly used bits (like the File ref to $
{basedir}).
And then incrementally I'd like for all of our test classes to
extend from this instead of junit.framework.TestCase.
Any objections?
--jason
Re: New module: geronimo-testsupport
Most likely.
--jason
On Aug 17, 2006, at 3:42 PM, David Jencks wrote:
YAY!!!
Can you make the File ref to ${basedir} work in idea without
setting test properties?
thanks
david jencks
On Aug 17, 2006, at 3:24 PM, Jason Dillon wrote:
I'd like to add a new module to our build, geronimo-testsupport,
which provides at the moment a single TestSupport class which sets
up logging and some other commonly used bits (like the File ref to
${basedir}).
And then incrementally I'd like for all of our test classes to
extend from this instead of junit.framework.TestCase.
Any objections?
--jason
